Re: [PATCH 9/9] drm/tilcdc: Use backlight power constants

2024-08-15 Thread Thomas Zimmermann
Ping. This patch still needs an ack. Am 31.07.24 um 14:17 schrieb Thomas Zimmermann: Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Jyri Sarha

Re: [PATCH 9/9] drm/tilcdc: Use backlight power constants

2024-08-15 Thread Tomi Valkeinen
Hi, On 15/08/2024 10:59, Thomas Zimmermann wrote: Ping. This patch still needs an ack. Am 31.07.24 um 14:17 schrieb Thomas Zimmermann: Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics.

Re: [PATCH 9/9] drm/tilcdc: Use backlight power constants

2024-08-15 Thread Thomas Zimmermann
Am 15.08.24 um 10:07 schrieb Tomi Valkeinen: Hi, On 15/08/2024 10:59, Thomas Zimmermann wrote: Ping. This patch still needs an ack. Am 31.07.24 um 14:17 schrieb Thomas Zimmermann: Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so

Re: A huge warning in dmesg pointing to drivers/gpu/drm/i915/display/intel_tc.c

2024-08-15 Thread Jani Nikula
[dropped a bunch of mailing lists and maintainers, added Imre] On Thu, 15 Aug 2024, "Renan W. P." wrote: > [2.] Full description of the problem/report: > > I can't identify any factual problems beyond a warning in dmesg triggered at > every boot, i.e., I have seen no features affected. The dme

[PATCH] drm/i915: make intel_display_power_domain_str() static

2024-08-15 Thread Jani Nikula
The function isn't used outside of intel_display_power.c. Make it static. Suggested-by: Imre Deak Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- drivers/gpu/drm/i915/display/intel_display_power.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-)

Re: [PATCH] drm/i915: make __intel_display_power_is_enabled() static

2024-08-15 Thread Jani Nikula
On Wed, 14 Aug 2024, Imre Deak wrote: > On Tue, Aug 13, 2024 at 06:12:16PM +0300, Jani Nikula wrote: >> The function isn't used outside of intel_display_power.c. Make it >> static. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Imre Deak Thanks, pushed to din. > Same applies to intel_displ

Re: [RESEND 2/2] drm/edid: make drm_edid_block_valid() static

2024-08-15 Thread Jani Nikula
On Mon, 12 Aug 2024, Jani Nikula wrote: > drm_edid_block_valid() is no longer used outside of drm_edid.c. Make it > static. > > Acked-by: Zhi Wang > Signed-off-by: Jani Nikula Both pushed to drm-misc-next with Sima's R-b on patch 2. BR, Jani. > > --- > > Cc: Zhenyu Wang > Cc: Zhi Wang > Cc

✗ Fi.CI.SPARSE: warning for drm/i915: make intel_display_power_domain_str() static

2024-08-15 Thread Patchwork
== Series Details == Series: drm/i915: make intel_display_power_domain_str() static URL : https://patchwork.freedesktop.org/series/137342/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for drm/i915: make intel_display_power_domain_str() static

2024-08-15 Thread Patchwork
== Series Details == Series: drm/i915: make intel_display_power_domain_str() static URL : https://patchwork.freedesktop.org/series/137342/ State : success == Summary == CI Bug Log - changes from CI_DRM_15233 -> Patchwork_137342v1 Summary --

[PULL] drm-misc-fixes

2024-08-15 Thread Thomas Zimmermann
Hi Dave, Sima, here's the weekly PR for drm-misc-fixes. It resolves an OOB access in v3d and a few minor errors. Best regards Thomas drm-misc-fixes-2024-08-15: Short summary of fixes pull: panel: - dt-bindings style fixes panel-orientation: - add quirk for Any Loki Max - add quirk for Any Loki

Re: [PATCH] drm/i915: make intel_display_power_domain_str() static

2024-08-15 Thread Imre Deak
On Thu, Aug 15, 2024 at 03:00:02PM +0300, Jani Nikula wrote: > The function isn't used outside of intel_display_power.c. Make it > static. > > Suggested-by: Imre Deak > Signed-off-by: Jani Nikula Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- > driv

Re: linux-next: manual merge of the drm-xe tree with the drm-intel tree

2024-08-15 Thread Lucas De Marchi
On Thu, Aug 15, 2024 at 11:37:17AM GMT, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the drm-xe tree got a conflict in: drivers/gpu/drm/xe/display/xe_display.c between commit: 769b081c18b9 ("drm/i915/opregion: convert to struct intel_display") from the drm-intel tree and com

[PULL] drm-xe-fixes

2024-08-15 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes another round of drm-xe-fixes. The amount of patches is higher for this round, but not because we have more fixes merged this week, but because of me and because a few fixes are depending on some other prep/refactor patches, now merged. 1. As I had told you last week,

Re: [PATCH] drm/i915/guc: Change GEM_WARN_ON to guc_err to prevent taints in CI

2024-08-15 Thread Narvaez, Jesus
On 8/9/2024 2:39 PM, Cavitt, Jonathan wrote: -Original Message- From: Intel-gfx On Behalf Of Jesus Narvaez Sent: Thursday, August 8, 2024 1:50 PM To: intel-gfx@lists.freedesktop.org Cc: Narvaez, Jesus Subject: [PATCH] drm/i915/guc: Change GEM_WARN_ON to guc_err to prevent taints in

Re: [PATCH] drm/i915/gem: Remove unnecessary cast

2024-08-15 Thread Rodrigo Vivi
On Wed, Aug 14, 2024 at 07:59:47PM +0200, Andi Shyti wrote: > The cast from "long" to "unsigned long" is unnecessary. Remove > it. I don't believe we can be that bold in this statement. Some static analyzer tools might not agree and tell that if the start or end are negative values we could have u

Re: [PATCH 1/7] drm/i915/display: support struct intel_atomic_state in to_intel_display()

2024-08-15 Thread Rodrigo Vivi
On Tue, Aug 13, 2024 at 07:41:17PM +0300, Jani Nikula wrote: > Add support for converting struct intel_atomic_state pointers to struct > intel_display pointers. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/intel_display_types.h | 3 +++ > 1 fil

Re: [PATCH 2/7] drm/i915/display: convert intel_link_bw.c to struct intel_display

2024-08-15 Thread Rodrigo Vivi
On Tue, Aug 13, 2024 at 07:41:18PM +0300, Jani Nikula wrote: > Going forward, struct intel_display shall replace struct > drm_i915_private as the main display device data pointer type. Convert > intel_link_bw.[ch] to struct intel_display. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi

Re: [PATCH 3/7] drm/i915/display: convert intel_load_detect.c to struct intel_display

2024-08-15 Thread Rodrigo Vivi
On Tue, Aug 13, 2024 at 07:41:19PM +0300, Jani Nikula wrote: > Going forward, struct intel_display shall replace struct > drm_i915_private as the main display device data pointer type. Convert > intel_load_detect.[ch] to struct intel_display. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo V

Re: [PATCH 3/7] drm/i915/display: convert intel_load_detect.c to struct intel_display

2024-08-15 Thread Rodrigo Vivi
On Tue, Aug 13, 2024 at 07:41:19PM +0300, Jani Nikula wrote: > Going forward, struct intel_display shall replace struct > drm_i915_private as the main display device data pointer type. Convert > intel_load_detect.[ch] to struct intel_display. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo V

Re: [PATCH 3/7] drm/i915/display: convert intel_load_detect.c to struct intel_display

2024-08-15 Thread Rodrigo Vivi
On Tue, Aug 13, 2024 at 07:41:19PM +0300, Jani Nikula wrote: > Going forward, struct intel_display shall replace struct > drm_i915_private as the main display device data pointer type. Convert > intel_load_detect.[ch] to struct intel_display. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo V

Re: [PATCH 4/7] drm/i915/alpm: convert to struct intel_display

2024-08-15 Thread Rodrigo Vivi
On Tue, Aug 13, 2024 at 07:41:20PM +0300, Jani Nikula wrote: > Going forward, struct intel_display shall replace struct > drm_i915_private as the main display device data pointer type. Convert > intel_alpm.[ch] to struct intel_display. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi (

Re: [PATCH 5/7] drm/i915/lspcon: convert to struct intel_display

2024-08-15 Thread Rodrigo Vivi
On Tue, Aug 13, 2024 at 07:41:21PM +0300, Jani Nikula wrote: > Going forward, struct intel_display shall replace struct > drm_i915_private as the main display device data pointer type. Convert > intel_lspcon.[ch] to struct intel_display. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi

Re: [PATCH 6/7] drm/i915/display: convert dp aux backlight to struct intel_display

2024-08-15 Thread Rodrigo Vivi
On Tue, Aug 13, 2024 at 07:41:22PM +0300, Jani Nikula wrote: > Going forward, struct intel_display shall replace struct > drm_i915_private as the main display device data pointer type. Convert > intel_dp_aux_backlight.[ch] to struct intel_display. > > Signed-off-by: Jani Nikula Reviewed-by: Rodr

Re: [PATCH 7/7] drm/i915/hti: convert to struct intel_display

2024-08-15 Thread Rodrigo Vivi
On Tue, Aug 13, 2024 at 07:41:23PM +0300, Jani Nikula wrote: > Going forward, struct intel_display shall replace struct > drm_i915_private as the main display device data pointer type. Convert > intel_hti.[ch] to struct intel_display. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi >