[PATCHv2] drm/xe/display: Change HPD to polling on runtime suspend

2024-08-08 Thread Arun R Murthy
HPD is interrupt based and on runtime suspend change it to polling as HPD is not a wakeup event. A worker thread is scheduled for doing this polling and it keeps polling for HPD live status on an internval of 10s. On runtime resume disable polling and fallback to interrupt mechanism. v2: move poll

✗ Fi.CI.BUILD: failure for drm/xe/display: Change HPD to polling on runtime suspend

2024-08-08 Thread Patchwork
== Series Details == Series: drm/xe/display: Change HPD to polling on runtime suspend URL : https://patchwork.freedesktop.org/series/137026/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/137026/revisions/1/mbox/ not applied Applying: drm/xe/displ

[PULL] drm-misc-fixes

2024-08-08 Thread Maxime Ripard
Hi, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2024-08-08: A fix for drm/client to prevent a null pointer dereference, a fix for a double-free in drm/bridge-connector, a fix for a gem shmem test, and a fix for async flips updates. The following changes since commit 9c685f61722d30a2

Re: [PATCH] drm/xe/pm: Change HPD to polling on runtime suspend

2024-08-08 Thread Jani Nikula
On Wed, 07 Aug 2024, Imre Deak wrote: > On Wed, Aug 07, 2024 at 12:15:33PM +0300, Murthy, Arun R wrote: >> >> > -Original Message- >> > From: Deak, Imre >> > Sent: Tuesday, August 6, 2024 10:11 PM >> > To: Murthy, Arun R >> > Cc: intel...@lists.freedesktop.org; intel-gfx@lists.freedeskt

[PULL] drm-intel-fixes

2024-08-08 Thread Tvrtko Ursulin
Hi Dave, Sima, A small bunch of fixes for the weekly cycle: Fix for Meteorlake dual PPS, vma offset calculation and tidy when partial mapping and unbreaking of eviction handling on DG2 small bar systems. Regards, Tvrtko drm-intel-fixes-2024-08-08: - correct dual pps handling for MTL_PCH+ [d

[RFC] Add AS_SDP to fastset

2024-08-08 Thread Mitul Golani
Add full modeset being triggered during VRR enable/disable, specially when panel has Adaptive sync SDP suypport. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_d

Re: [RFC] Add AS_SDP to fastset

2024-08-08 Thread Jani Nikula
On Thu, 08 Aug 2024, Mitul Golani wrote: > Add full modeset being triggered during VRR enable/disable, specially > when panel has Adaptive sync SDP suypport. I don't understand what that is trying to say. BR, Jani. > > Signed-off-by: Mitul Golani > --- > drivers/gpu/drm/i915/display/intel_dis

✓ Fi.CI.BAT: success for drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev3)

2024-08-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev3) URL : https://patchwork.freedesktop.org/series/136975/ State : success == Summary == CI Bug Log - changes from CI_DRM_15198 -> Patchwork_136975v3 S

✗ Fi.CI.SPARSE: warning for drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev3)

2024-08-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev3) URL : https://patchwork.freedesktop.org/series/136975/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH] drm/i915/gem: Improve pfn calculation readability in vm_fault_gtt()

2024-08-08 Thread Andi Shyti
Hi, On Wed, Aug 07, 2024 at 11:45:53AM +0100, Andi Shyti wrote: > By moving the pfn calculation to the set_address_limits() > function we improve code readability. This way, > set_address_limits() is responsible for calculating all memory > mapping paramenters: "start", "end" and "pfn". > > This

✗ Fi.CI.CHECKPATCH: warning for Add AS_SDP to fastset

2024-08-08 Thread Patchwork
== Series Details == Series: Add AS_SDP to fastset URL : https://patchwork.freedesktop.org/series/137035/ State : warning == Summary == Error: dim checkpatch failed b51884e98ba6 Add AS_SDP to fastset -:20: ERROR:SPACING: space required before the open parenthesis '(' #20: FILE: drivers/gpu/drm

✓ Fi.CI.BAT: success for Add AS_SDP to fastset

2024-08-08 Thread Patchwork
== Series Details == Series: Add AS_SDP to fastset URL : https://patchwork.freedesktop.org/series/137035/ State : success == Summary == CI Bug Log - changes from CI_DRM_15198 -> Patchwork_137035v1 Summary --- **SUCCESS** No regres

Re: [PATCH 1/9] drm/amdgpu: Use backlight power constants

2024-08-08 Thread Alex Deucher
On Thu, Aug 8, 2024 at 1:19 AM Thomas Zimmermann wrote: > > Hi > > Am 07.08.24 um 21:47 schrieb Alex Deucher: > > On Tue, Aug 6, 2024 at 3:06 AM Thomas Zimmermann > > wrote: > >> Hi > >> > >> Am 05.08.24 um 21:00 schrieb Deucher, Alexander: > >>> [Public] > >>> > -Original Message-

Re: [PATCH 0/3] drm/i915: remove __i915_printk()

2024-08-08 Thread Jani Nikula
On Tue, 06 Aug 2024, Jani Nikula wrote: > I don't think we need the bug reporting request in the few specific > places that lead to __i915_printk(). With them gone, there's really no > need for __i915_printk(). Just switch to regular drm logging. Thanks for the reviews and acks, pushed to din wit

[PATCH v2 00/10] drm/xe & drm/i915: drvdata usage changes

2024-08-08 Thread Jani Nikula
v2 of https://patchwork.freedesktop.org/series/136621/ Removed "drm/xe/tests: fix drvdata usage" from v1 in favour of "drm/xe/tests: remove unused leftover xe_call_for_each_device()" here. Due to the display dependency, I think it would be best to merge the whole thing via drm-intel-next, and do

[PATCH v2 01/10] drm/xe/tests: remove unused leftover xe_call_for_each_device()

2024-08-08 Thread Jani Nikula
xe_call_for_each_device() has been unused since commit 57ecead343e7 ("drm/xe/tests: Convert xe_mocs live tests"). Remove it and the related dev_to_xe_device_fn() and struct kunit_test_data. Cc: Gustavo Sousa Cc: Lucas De Marchi Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/tests/xe_pci.c

[PATCH v2 02/10] drm/xe: use pdev_to_xe_device() instead of pci_get_drvdata() directly

2024-08-08 Thread Jani Nikula
We have a helper for converting pci device to xe device, use it. Reviewed-by: Gustavo Sousa Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/xe_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c index f818aa69f3ca

[PATCH v2 03/10] drm/xe: add kdev_to_xe_device() helper and use it

2024-08-08 Thread Jani Nikula
There are enough users for kernel device to xe device conversion, add a helper for it. Reviewed-by: Gustavo Sousa Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/xe_device.h| 5 + drivers/gpu/drm/xe/xe_gsc_proxy.c | 9 ++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff -

[PATCH v2 04/10] drm/i915: use pdev_to_i915() instead of pci_get_drvdata() directly

2024-08-08 Thread Jani Nikula
We have a helper for converting pci device to i915 device, use it. v2: Also convert i915_pci_probe() (Gustavo) Cc: Gustavo Sousa Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_pc

[PATCH v2 05/10] drm/i915 & drm/xe: save struct drm_device to drvdata

2024-08-08 Thread Jani Nikula
In the future, the display code shall not have any idea about struct xe_device or struct drm_i915_private, but will need to get at the struct drm_device via drvdata. Store the struct drm_device pointer to drvdata instead of the driver specific pointer. Avoid passing NULL to container_of() via to_i

[PATCH v2 06/10] drm/i915: support struct device and pci_dev in to_intel_display()

2024-08-08 Thread Jani Nikula
Now that both xe and i915 store struct drm_device in drvdata, we can trivially support struct device and struct pci_dev in to_intel_display(). We do need to check for NULL drvdata before converting it into struct intel_device pointer, though. Do it in __drm_device_to_intel_display(). v2: Add NULL

[PATCH v2 07/10] drm/i915/audio: migrate away from kdev_to_i915()

2024-08-08 Thread Jani Nikula
Use to_intel_display() instead of kdev_to_i915() in the audio component API hooks. Avoid further drive-by changes at this point, and just convert the display pointer to i915, and leave the struct intel_display conversion for later. Reviewed-by: Gustavo Sousa Signed-off-by: Jani Nikula --- drive

[PATCH v2 08/10] drm/i915/hdcp: migrate away from kdev_to_i915() in bind/unbind

2024-08-08 Thread Jani Nikula
Use to_intel_display() instead of kdev_to_i915() in the HDCP component API hooks. Avoid further drive-by changes at this point, and just convert the display pointer to i915, and leave the struct intel_display conversion for later. Reviewed-by: Gustavo Sousa Signed-off-by: Jani Nikula --- driver

[PATCH v2 09/10] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging

2024-08-08 Thread Jani Nikula
Use to_intel_display() instead of kdev_to_i915() in the HDCP component API hooks. Avoid further drive-by changes at this point, and just convert the display pointer to i915, and leave the struct intel_display conversion for later. The NULL error checking in the hooks make this a bit cumbersome. I'

[PATCH v2 10/10] drm/xe/display: remove unused compat kdev_to_i915() and pdev_to_i915()

2024-08-08 Thread Jani Nikula
The display code no longer uses kdev_to_i915() or pdev_to_i915() helpers. Remove them. Reviewed-by: Gustavo Sousa Signed-off-by: Jani Nikula --- drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i9

Re: [PATCH v2 00/10] drm/xe & drm/i915: drvdata usage changes

2024-08-08 Thread Lucas De Marchi
On Thu, Aug 08, 2024 at 06:15:45PM GMT, Jani Nikula wrote: v2 of https://patchwork.freedesktop.org/series/136621/ Removed "drm/xe/tests: fix drvdata usage" from v1 in favour of "drm/xe/tests: remove unused leftover xe_call_for_each_device()" here. Due to the display dependency, I think it would

✗ Fi.CI.SPARSE: warning for drm/xe & drm/i915: drvdata usage changes (rev2)

2024-08-08 Thread Patchwork
== Series Details == Series: drm/xe & drm/i915: drvdata usage changes (rev2) URL : https://patchwork.freedesktop.org/series/136621/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH 2/2] drm/i915/gem: Calculate object page offset for partial memory mapping

2024-08-08 Thread Nirmoy Das
On 8/7/2024 12:05 PM, Andi Shyti wrote: To enable partial memory mapping of GPU virtual memory, it's necessary to introduce an offset to the object's memory (obj->mm.pages) scatterlist. This adjustment compensates for instances when userspace mappings do not start from the beginning of the obje

✓ Fi.CI.BAT: success for drm/xe & drm/i915: drvdata usage changes (rev2)

2024-08-08 Thread Patchwork
== Series Details == Series: drm/xe & drm/i915: drvdata usage changes (rev2) URL : https://patchwork.freedesktop.org/series/136621/ State : success == Summary == CI Bug Log - changes from CI_DRM_15198 -> Patchwork_136621v2 Summary ---

Re: [PATCH 1/2] drm/i915/gem: Do not look for the exact address in node

2024-08-08 Thread Nirmoy Das
On 8/7/2024 12:05 PM, Andi Shyti wrote: In preparation for the upcoming partial memory mapping feature, we want to make sure that when looking for a node we consider also the offset and not just the starting address of the virtual memory node. Signed-off-by: Andi Shyti Reviewed-by: Nirmoy Da

[PULL] drm-xe-fixes

2024-08-08 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our first round of 6.11 fixes as I was out last week. Dim failed to cherry-pick some cases that I'm going to take a deeper look today/tomorrow, so probably some more fixes coming next week towards -rc4... Thanks, Rodrigo. drm-xe-fixes-2024-08-08: - Fix off-by-one whe

Re: [PULL] drm-intel-fixes

2024-08-08 Thread Krzysztof Kozlowski
On 08/08/2024 10:45, Tvrtko Ursulin wrote: > > Hi Dave, Sima, > > A small bunch of fixes for the weekly cycle: ... > > > Andi Shyti (2): > drm/i915/gem: Adjust vma offset for framebuffer mmap offset > drm/i915/gem: Fi

Re: [PULL] drm-intel-fixes

2024-08-08 Thread Krzysztof Kozlowski
On 08/08/2024 20:35, Krzysztof Kozlowski wrote: > On 08/08/2024 10:45, Tvrtko Ursulin wrote: >> >> Hi Dave, Sima, >> >> A small bunch of fixes for the weekly cycle: > > ... > >> >> >> Andi Shyti (2): >> drm/i915/gem: Adjust vm

✗ Fi.CI.SPARSE: warning for drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev4)

2024-08-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev4) URL : https://patchwork.freedesktop.org/series/136975/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PULL] drm-misc-next

2024-08-08 Thread Daniel Vetter
On Thu, Aug 01, 2024 at 02:14:06PM +0200, Thomas Zimmermann wrote: > Hi Dave, Sima, > > here's the first PR for drm-misc-next for what will become Linux v6.12. > It's the ususal mix of new features and bug fixes. Nouveau got a larger > refactoring, there are some improvements within TTM, work on t

✗ Fi.CI.BAT: failure for drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev4)

2024-08-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev4) URL : https://patchwork.freedesktop.org/series/136975/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15200 -> Patchwork_136975v4 S

[PATCH] drm/i915/guc: Change GEM_WARN_ON to guc_err to prevent taints in CI

2024-08-08 Thread Jesus Narvaez
This warning was supposed to catch a harmless issue, but changing to guc_error should prevent kernel taints in CI runs. Signed-off-by: Jesus Narvaez --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915

✓ Fi.CI.BAT: success for drm/i915/guc: Change GEM_WARN_ON to guc_err to prevent taints in CI

2024-08-08 Thread Patchwork
== Series Details == Series: drm/i915/guc: Change GEM_WARN_ON to guc_err to prevent taints in CI URL : https://patchwork.freedesktop.org/series/137064/ State : success == Summary == CI Bug Log - changes from CI_DRM_15202 -> Patchwork_137064v1 ===

[PATCH] drm/i915/guc: Fix missing enable of Wa_14019159160 on ARL

2024-08-08 Thread John . C . Harrison
From: John Harrison The previous update to enable the workaround on ARL only changed two out of three places where the w/a needs to be enabled. That meant the GuC side was operational but not the KMD side. And as the KMD side is the trigger, it meant the w/a was not actually active. So fix that.

✗ Fi.CI.SPARSE: warning for drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev5)

2024-08-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev5) URL : https://patchwork.freedesktop.org/series/136975/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev5)

2024-08-08 Thread Patchwork
== Series Details == Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev5) URL : https://patchwork.freedesktop.org/series/136975/ State : success == Summary == CI Bug Log - changes from CI_DRM_15202 -> Patchwork_136975v5 S

✓ Fi.CI.BAT: success for drm/i915/guc: Fix missing enable of Wa_14019159160 on ARL

2024-08-08 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix missing enable of Wa_14019159160 on ARL URL : https://patchwork.freedesktop.org/series/137067/ State : success == Summary == CI Bug Log - changes from CI_DRM_15202 -> Patchwork_137067v1 Summary

[PATCH] drm/i915/hdcp: Use correct cp_irq_count

2024-08-08 Thread Suraj Kandpal
We are checking cp_irq_count from the wrong hdcp structure which ends up giving timed out errors. Extract it from the correct intel_hdcp structure. Fixes: 8c9e4f68b861 ("drm/i915/hdcp: Use per-device debugs") Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 4 +++-

[PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-08 Thread Raag Jadav
Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 653.00 mV fan1:3833 RPM power1: N/A (max = 43.00 W) energy1: 32.02 k

✓ Fi.CI.BAT: success for drm/i915/hdcp: Use correct cp_irq_count

2024-08-08 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Use correct cp_irq_count URL : https://patchwork.freedesktop.org/series/137072/ State : success == Summary == CI Bug Log - changes from CI_DRM_15203 -> Patchwork_137072v1 Summary --- **SUCC

✓ Fi.CI.BAT: success for drm/i915/hwmon: expose fan speed (rev4)

2024-08-08 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: expose fan speed (rev4) URL : https://patchwork.freedesktop.org/series/136036/ State : success == Summary == CI Bug Log - changes from CI_DRM_15203 -> Patchwork_136036v4 Summary --- **SUCC