[PATCH v1] drm/i915/dp: Modify DP lane count from DPCD reading

2024-06-28 Thread Ben Kao
We found that the external monitor would be failed to display when hot-plug with dual Type-C USB cable on Dell WD19DC dock. Due to the host would receive 2 lanes setting when the first HPD, then receive 4 lanes setting later, but the host only sets 2 lanes DP and skips to set 4 lanes DP. I modify D

Re: [PATCH v1] drm/i915/dp: Modify DP lane count from DPCD reading

2024-06-28 Thread Jani Nikula
On Fri, 28 Jun 2024, Ben Kao wrote: > We found that the external monitor would be failed to display > when hot-plug with dual Type-C USB cable on Dell WD19DC dock. > Due to the host would receive 2 lanes setting when the first HPD, > then receive 4 lanes setting later, but the host only sets 2 lan

RE: [PATCH v1] drm/i915/dp: Modify DP lane count from DPCD reading

2024-06-28 Thread Kao, Ben
> On Fri, 28 Jun 2024, Ben Kao wrote: > > We found that the external monitor would be failed to display when > > hot-plug with dual Type-C USB cable on Dell WD19DC dock. > > Due to the host would receive 2 lanes setting when the first HPD, then > > receive 4 lanes setting later, but the host only

RE: [PATCH 01/14] drm/i915: Calculate vblank delay more accurately

2024-06-28 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, June 25, 2024 12:40 AM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 01/14] drm/i915: Calculate vblank delay more accurately > > From: Ville Syrjälä > > Calculate the vblank delay in the vbl

RE: [PATCH 02/14] drm/i915: Make vrr_{enabling, disabling}() usable outside intel_display.c

2024-06-28 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, June 25, 2024 12:40 AM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 02/14] drm/i915: Make vrr_{enabling, disabling}() usable > outside intel_display.c > > From: Ville Syrjälä > > Give vrr_e

RE: [PATCH 03/14] drm/i915/dsb: Hook up DSB error interrupts

2024-06-28 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, June 25, 2024 12:40 AM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 03/14] drm/i915/dsb: Hook up DSB error interrupts > > From: Ville Syrjälä > > Enable all DSB error/fault interrupts so th

Re: linux-next: build failure after merge of the drm-intel tree

2024-06-28 Thread Jani Nikula
On Fri, 28 Jun 2024, Dave Airlie wrote: > On Tue, 18 Jun 2024 at 05:26, Rodrigo Vivi wrote: >> >> On Wed, Jun 12, 2024 at 02:12:39PM +1000, Stephen Rothwell wrote: >> > Hi all, >> > >> > After merging the drm-intel tree, today's linux-next build (i386 >> > defconfig) failed like this: >> > >> > x

✗ Fi.CI.BAT: failure for drm/i915/dp: Modify DP lane count from DPCD reading

2024-06-28 Thread Patchwork
== Series Details == Series: drm/i915/dp: Modify DP lane count from DPCD reading URL : https://patchwork.freedesktop.org/series/135505/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15013 -> Patchwork_135505v1 Summary -

Re: ✗ Fi.CI.IGT: failure for drm/i915/mtl: Skip PLL state verification in TBT mode

2024-06-28 Thread Imre Deak
On Thu, Jun 27, 2024 at 02:37:28AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/mtl: Skip PLL state verification in TBT mode > URL : https://patchwork.freedesktop.org/series/135441/ > State : failure Thanks for the review, pushed to -din also adding Closes: https://gitlab

Re: [PATCH 1/5] drm/i915: Disable compression tricks on JSL

2024-06-28 Thread Ville Syrjälä
On Fri, Jun 28, 2024 at 12:33:12AM +0200, Andi Shyti wrote: > Hi Ville, > > On Mon, Jun 24, 2024 at 06:05:34PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Bspec asks us to disable some compression trick on JSL. While the > > bspec description is pretty vague it looks like this is

Re: [PATCH 03/14] drm/i915/dsb: Hook up DSB error interrupts

2024-06-28 Thread Ville Syrjälä
On Fri, Jun 28, 2024 at 09:21:24AM +, Manna, Animesh wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf Of Ville > > Syrjala > > Sent: Tuesday, June 25, 2024 12:40 AM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH 03/14] drm/i915/dsb: Hook up DSB error inter

[PATCH v3 0/8] drm/i915: PREEMPT_RT related fixups.

2024-06-28 Thread Sebastian Andrzej Siewior
Hi, The following patches are from the PREEMPT_RT queue. It is mostly about disabling interrupts/preemption which leads to problems. Unfortunately DRM_I915_LOW_LEVEL_TRACEPOINTS had to be disabled because it acquires locks from within trace points. Making the lock a raw_spinlock_t led to higher l

[PATCH v3 1/8] drm/i915: Use preempt_disable/enable_rt() where recommended

2024-06-28 Thread Sebastian Andrzej Siewior
From: Mike Galbraith Mario Kleiner suggest in commit ad3543ede630f ("drm/intel: Push get_scanout_position() timestamping into kms driver.") a spots where preemption should be disabled on PREEMPT_RT. The difference is that on PREEMPT_RT the intel_uncore::lock disables neither preemption nor in

[PATCH v3 7/8] drm/i915/guc: Consider also RCU depth in busy loop.

2024-06-28 Thread Sebastian Andrzej Siewior
intel_guc_send_busy_loop() looks at in_atomic() and irqs_disabled() to decide if it should busy-spin while waiting or if it may sleep. Both checks will report false on PREEMPT_RT if sleeping spinlocks are acquired leading to RCU splats while the function sleeps. Check also if RCU has been disabled

[PATCH v3 6/8] drm/i915: Drop the irqs_disabled() check

2024-06-28 Thread Sebastian Andrzej Siewior
The !irqs_disabled() check triggers on PREEMPT_RT even with i915_sched_engine::lock acquired. The reason is the lock is transformed into a sleeping lock on PREEMPT_RT and does not disable interrupts. There is no need to check for disabled interrupts. The lockdep annotation below already check if t

[PATCH v3 2/8] drm/i915: Don't disable interrupts on PREEMPT_RT during atomic updates

2024-06-28 Thread Sebastian Andrzej Siewior
From: Mike Galbraith Commit 8d7849db3eab7 ("drm/i915: Make sprite updates atomic") started disabling interrupts across atomic updates. This breaks on PREEMPT_RT because within this section the code attempt to acquire spinlock_t locks which are sleeping locks on PREEMPT_RT. According to the c

[PATCH v3 5/8] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock()

2024-06-28 Thread Sebastian Andrzej Siewior
execlists_dequeue() is invoked from a function which uses local_irq_disable() to disable interrupts so the spin_lock() behaves like spin_lock_irq(). This breaks PREEMPT_RT because local_irq_disable() + spin_lock() is not the same as spin_lock_irq(). execlists_dequeue_irq() and execlists_dequeue()

[PATCH v3 3/8] drm/i915: Don't check for atomic context on PREEMPT_RT

2024-06-28 Thread Sebastian Andrzej Siewior
The !in_atomic() check in _wait_for_atomic() triggers on PREEMPT_RT because the uncore::lock is a spinlock_t and does not disable preemption or interrupts. Changing the uncore:lock to a raw_spinlock_t doubles the worst case latency on an otherwise idle testbox during testing. Ignore _WAIT_FOR_ATO

[PATCH v3 4/8] drm/i915: Disable tracing points on PREEMPT_RT

2024-06-28 Thread Sebastian Andrzej Siewior
Luca Abeni reported this: | BUG: scheduling while atomic: kworker/u8:2/15203/0x0003 | CPU: 1 PID: 15203 Comm: kworker/u8:2 Not tainted 4.19.1-rt3 #10 | Call Trace: | rt_spin_lock+0x3f/0x50 | gen6_read32+0x45/0x1d0 [i915] | g4x_get_vblank_counter+0x36/0x40 [i915] | trace_event_raw_event_i915

[PATCH v3 8/8] Revert "drm/i915: Depend on !PREEMPT_RT."

2024-06-28 Thread Sebastian Andrzej Siewior
Once the known issues are addressed, it should be safe to enable the driver. Acked-by: Tvrtko Ursulin Signed-off-by: Sebastian Andrzej Siewior --- drivers/gpu/drm/i915/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index 59

✗ Fi.CI.CHECKPATCH: warning for drm/i915: PREEMPT_RT related fixups. (rev12)

2024-06-28 Thread Patchwork
== Series Details == Series: drm/i915: PREEMPT_RT related fixups. (rev12) URL : https://patchwork.freedesktop.org/series/95463/ State : warning == Summary == Error: dim checkpatch failed 4262ab871c62 drm/i915: Use preempt_disable/enable_rt() where recommended -:7: WARNING:COMMIT_LOG_LONG_LINE:

✗ Fi.CI.SPARSE: warning for drm/i915: PREEMPT_RT related fixups. (rev12)

2024-06-28 Thread Patchwork
== Series Details == Series: drm/i915: PREEMPT_RT related fixups. (rev12) URL : https://patchwork.freedesktop.org/series/95463/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for drm/i915: PREEMPT_RT related fixups. (rev12)

2024-06-28 Thread Patchwork
== Series Details == Series: drm/i915: PREEMPT_RT related fixups. (rev12) URL : https://patchwork.freedesktop.org/series/95463/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15013 -> Patchwork_95463v12 Summary --- **

RE: ✗ Fi.CI.BAT: failure for drm/i915: PREEMPT_RT related fixups. (rev12)

2024-06-28 Thread Saarinen, Jani
Hi, > -Original Message- > From: Intel-gfx On Behalf Of > Patchwork > Sent: Friday, 28 June 2024 16.43 > To: Sebastian Andrzej Siewior > Cc: intel-gfx@lists.freedesktop.org > Subject: ✗ Fi.CI.BAT: failure for drm/i915: PREEMPT_RT related fixups. (rev12) > > Patch Details > Series:

Re: [PATCH 1/9] drm: Add helpers for x16 fixed point values

2024-06-28 Thread Imre Deak
On Thu, Jun 27, 2024 at 06:41:46PM +0300, Jani Nikula wrote: > On Wed, 19 Jun 2024, Imre Deak wrote: > > On Wed, Jun 19, 2024 at 01:10:09PM +0300, Jani Nikula wrote: > >> On Fri, 14 Jun 2024, Imre Deak wrote: > >> > Add helpers to convert between x16 fixed point and integer/fraction > >> > values

[PULL] drm-intel-next

2024-06-28 Thread Jani Nikula
Hi Dave & Sima - Another feature pull towards v6.11, hopefully last. This should also fix the 32-bit build issue [1] seen in drm-next. BR, Jani. [1] https://lore.kernel.org/r/CAPM=9tyNGA2wEgnsKdSyjHRGVikywZLdueZj=sytmfyeunz...@mail.gmail.com drm-intel-next-2024-06-28: drm/i915 feature pull

[PATCH v2 2/9] drm/display/dsc: Add a helper to dump the DSC configuration

2024-06-28 Thread Imre Deak
Add a helper to dump the Display Stream Compression configuration, taken into use in the i915 driver by a later patch. v2: - Rebase on the s/DRM_X16/FXP_Q4 change. - s/DSC configration/DSC configuration in the function documentation. Signed-off-by: Imre Deak --- drivers/gpu/drm/display/drm_dsc_

[PATCH v2 3/9] drm/i915: Replace to_bpp_x16() with fxp_q4_from_int()

2024-06-28 Thread Imre Deak
Replace the to_bpp_x16() helper defined by the driver with the equivalent fxp_q4_from_int() helper defined by DRM core. v2: Rebase on the s/drm_x16/fxp_q4 change. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_bios.c | 5 +++-- .../gpu/drm/i915/display/intel_display_type

[PATCH v2 0/9] drm/i915: Dump DSC state to dmesg/debugfs

2024-06-28 Thread Imre Deak
This is v2 of [1], renaming the helpers from drm_x16 to fxp_q4 as suggested by Jani. [1] https://lore.kernel.org/all/20240614173911.3743172-1-imre.d...@intel.com Cc: Jani Nikula Imre Deak (9): drm: Add helpers for q4 fixed point values drm/display/dsc: Add a helper to dump the DSC configura

[PATCH v2 5/9] drm/i915: Replace to_bpp_int_roundup() with fxp_q4_to_int_roundup()

2024-06-28 Thread Imre Deak
Replace the to_bpp_int_roundup() helper defined by the driver with the equivalent fxp_q4_to_int_roundup() helper defined by DRM core. v2: Rebase on s/drm_x16/fxp_q4 change. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_cdclk.c | 5 - drivers/gpu/drm/i915/display/in

[PATCH v2 1/9] drm: Add helpers for q4 fixed point values

2024-06-28 Thread Imre Deak
Add helpers to convert between q4 fixed point and integer/fraction values. Also add the format/argument macros required to printk q4 fixed point variables. The q4 notation is based on the short variant described by https://en.wikipedia.org/wiki/Q_(number_format) where only the number of fraction

[PATCH v2 4/9] drm/i915: Replace to_bpp_int() with fxp_q4_to_int()

2024-06-28 Thread Imre Deak
Replace the to_bpp_int() helper defined by the driver with the equivalent fxp_q4_to_int() helper defined by DRM core. v2: Rebase on the s/drm_x16/fxp_q4 change. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/icl_dsi.c | 9 + drivers/gpu/drm/i915/display/intel_disp

[PATCH v2 6/9] drm/i915: Replace to_bpp_frac() with fxp_q4_to_frac()

2024-06-28 Thread Imre Deak
Replace the to_bpp_frac() helper defined by the driver with the equivalent fxp_q4_to_frac() helper defined by DRM core. v2: Rebase on the s/drm_x16/fxp_q4 change. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_display_types.h | 7 +-- drivers/gpu/drm/i915/display/intel_dp.c

[PATCH v2 7/9] drm/i915: Replace BPP_X16_FMT()/ARGS() with FXP_Q4_FMT()/ARGS()

2024-06-28 Thread Imre Deak
Replace the BPP_X16_FMT()/ARGS() helpers defined by the driver with the equivalent FXP_Q4_FMT()/ARGS() helpers defined by DRM core. v2: Rebase on the s/DRM_X16/FXP_Q4 change. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_audio.c | 5 +++-- drivers/gpu/drm/i915/display/i

[PATCH v2 9/9] drm/i915: Remove DSC register dump

2024-06-28 Thread Imre Deak
The Display Engine's DSC register values are deducted from the DSC configuration stored in intel_crtc_state::dsc. The latter one is dumped in a human-readable format, so dumping the register values is redundant, remove it. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_vdsc.c |

[PATCH v2 8/9] drm/i915: Dump DSC state to dmesg and debugfs/i915_display_info

2024-06-28 Thread Imre Deak
Dump the DSC state to dmesg during HW readout and state computation as well as the i915_display_info debugfs entry. v2: Rebase on the s/DRM_X16/FXP_Q4 change. Signed-off-by: Imre Deak --- .../drm/i915/display/intel_crtc_state_dump.c | 3 +++ .../drm/i915/display/intel_display_debugfs.c | 4

[PATCH 0/1] On Xe2 platform always require ccs alignment on tile4

2024-06-28 Thread Juha-Pekka Heikkila
There is difference with tile4 on Xe2 platforms vs older platforms where for tile4 is always enabled decompression on display when on Xe2. This will cause requirement to be aligned for ccs with framebuffer strides with tile4. Maybe need to consider new modifier for Xe2 because of this requirement.

[PATCH 1/1] drm/i915/display: On Xe2 platform always require ccs alignment on tile4

2024-06-28 Thread Juha-Pekka Heikkila
On Xe2 platform with tile4 decompression is enabled unconditionally hence consider tile4 as ccs modifier Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/display/intel_fb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Dump DSC state to dmesg/debugfs (rev2)

2024-06-28 Thread Patchwork
== Series Details == Series: drm/i915: Dump DSC state to dmesg/debugfs (rev2) URL : https://patchwork.freedesktop.org/series/134906/ State : warning == Summary == Error: dim checkpatch failed 4affbe7acace drm: Add helpers for q4 fixed point values -:46: WARNING:LONG_LINE: line length of 112 ex

✗ Fi.CI.SPARSE: warning for drm/i915: Dump DSC state to dmesg/debugfs (rev2)

2024-06-28 Thread Patchwork
== Series Details == Series: drm/i915: Dump DSC state to dmesg/debugfs (rev2) URL : https://patchwork.freedesktop.org/series/134906/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for drm/i915: Dump DSC state to dmesg/debugfs (rev2)

2024-06-28 Thread Patchwork
== Series Details == Series: drm/i915: Dump DSC state to dmesg/debugfs (rev2) URL : https://patchwork.freedesktop.org/series/134906/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15013 -> Patchwork_134906v2 Summary ---

✗ Fi.CI.BAT: failure for On Xe2 platform always require ccs alignment on tile4

2024-06-28 Thread Patchwork
== Series Details == Series: On Xe2 platform always require ccs alignment on tile4 URL : https://patchwork.freedesktop.org/series/135531/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15013 -> Patchwork_135531v1 Summary ---

Re: [PATCH 2/2] drm/i915: disable fbc due to Wa_16023588340

2024-06-28 Thread Rodrigo Vivi
On Fri, Jun 28, 2024 at 12:30:57AM -0500, Lucas De Marchi wrote: > On Wed, Jun 26, 2024 at 10:42:24AM GMT, Matt Roper wrote: > > On Wed, Jun 26, 2024 at 01:26:00PM -0400, Rodrigo Vivi wrote: > > > On Wed, Jun 26, 2024 at 05:17:41PM +0100, Matthew Auld wrote: > > > > On 26/06/2024 16:53, Rodrigo Viv

Re: [PATCH 2/2] drm/i915: disable fbc due to Wa_16023588340

2024-06-28 Thread Lucas De Marchi
On Fri, Jun 28, 2024 at 02:36:16PM GMT, Rodrigo Vivi wrote: On Fri, Jun 28, 2024 at 12:30:57AM -0500, Lucas De Marchi wrote: On Wed, Jun 26, 2024 at 10:42:24AM GMT, Matt Roper wrote: > On Wed, Jun 26, 2024 at 01:26:00PM -0400, Rodrigo Vivi wrote: > > On Wed, Jun 26, 2024 at 05:17:41PM +0100, Mat

[PATCH] i915/perf: Remove code to update PWR_CLK_STATE for gen12

2024-06-28 Thread Umesh Nerlige Ramappa
PWR_CLK_STATE only needs to be modified up until gen11. For gen12 this code is not applicable. Remove code to update context image with PWR_CLK_STATE for gen12. Fixes: 00a7f0d7155c ("drm/i915/tgl: Add perf support on TGL") Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_perf.c

✗ Fi.CI.BAT: failure for i915/perf: Remove code to update PWR_CLK_STATE for gen12

2024-06-28 Thread Patchwork
== Series Details == Series: i915/perf: Remove code to update PWR_CLK_STATE for gen12 URL : https://patchwork.freedesktop.org/series/135549/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15013 -> Patchwork_135549v1 Summary

Re: [PATCH] i915/perf: Remove code to update PWR_CLK_STATE for gen12

2024-06-28 Thread Dixit, Ashutosh
On Fri, 28 Jun 2024 17:56:43 -0700, Umesh Nerlige Ramappa wrote: > > PWR_CLK_STATE only needs to be modified up until gen11. For gen12 this > code is not applicable. Remove code to update context image with > PWR_CLK_STATE for gen12. > > Fixes: 00a7f0d7155c ("drm/i915/tgl: Add perf support on TGL")

RE: Regression on linux-next (next-20240625)

2024-06-28 Thread Borah, Chaitanya Kumar
> -Original Message- > From: Sidhartha Kumar > Sent: Friday, June 28, 2024 8:24 PM > To: Borah, Chaitanya Kumar > Cc: liam.howl...@oracle.com; a...@linux-foundation.org; linux- > m...@kvack.org; maple-t...@lists.infradead.org; Nikula, Jani > ; Saarinen, Jani ; Kurmi, > Suresh Kumar ; in