✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Fixed a screen flickering when turning on display from off

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915/display: Fixed a screen flickering when turning on display from off URL : https://patchwork.freedesktop.org/series/130780/ State : warning == Summary == Error: dim checkpatch failed 10200bbd0b75 drm/i915/display: Fixed a screen flickering when turning on

[PATCH v4 1/5] drm/i915/display: Make intel_dp_aux_fw_sync_len available for PSR code

2024-03-06 Thread Jouni Högander
ALPM AUX-Wake fast wake sync pulse count is needed by PSR to calculate IO wake and fast wake lines. Convert intel_dp_aux_fw_sync_len as non-static to make it available for PSR code. v2: use int instead of u8 Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 2 +- d

[PATCH v4 2/5] drm/i915/psr: Improve fast and IO wake lines calculation

2024-03-06 Thread Jouni Högander
Current fast and IO wake lines calculation is assuming fast wake sync length is 18 pulses. Let's improve this by checking actual length. Add getter for IO buffer wake time and return 10 us there which was assumed with static 42 us IO wake time. Upcoming patches will extent this for different displ

[PATCH v4 3/5] drm/i915/psr: Calculate IO wake and fast wake lines for DISPLAY_VER < 12

2024-03-06 Thread Jouni Högander
Bspec mentions 50 us for IO wake time and 32 us for fast wake time. 32 us is most probably wrong as it doesn't meet the specification as fast wake time is calculated in Bspec like this: 10..16 us (precharge) + 8 us (preamble) + 4 us (phy_wake) + 20 us (tfw_exit_latency) Instead of using these con

[PATCH v4 0/5] IO and fast wake lines calculation and increase fw sync length

2024-03-06 Thread Jouni Högander
This patch set is improving IO and fast wake lines calculation in PSR code: Use actual fast wake sync pulse count in calculation Implement getter for IO buffer wake times and use that. Better presentation on how these are calculated. Use calculation for display version < 12 as well. Also number

[PATCH v4 4/5] drm/i915/psr: Add IO buffer wake times for LunarLake and beyond

2024-03-06 Thread Jouni Högander
IO buffer wake time used for IO wake calculation is dependent on port clock on LunarLake and beyond. Take this into account in get_io_buffer_wake_time. Bspec: 65450 Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 9 - 1 file changed, 8 insertions(+), 1 delet

[PATCH v4 5/5] drm/i915/display: Increase number of fast wake precharge pulses

2024-03-06 Thread Jouni Högander
Increasing number of fast wake sync pulses seem to fix problems with certain PSR panels. This should be ok for other panels as well as the eDP specification allows 10...16 precharge pulses and we are still within that range. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9739 Signed-off

✗ Fi.CI.BAT: failure for drm/i915/display: Fixed a screen flickering when turning on display from off

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915/display: Fixed a screen flickering when turning on display from off URL : https://patchwork.freedesktop.org/series/130780/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14395 -> Patchwork_130780v1 =

[PATCH] drm/i915/dp: Enable AUX based backlight for HDR

2024-03-06 Thread Suraj Kandpal
As of now whenerver HDR is switched on we use the PWM to change the backlight as opposed to AUX based backlight changes in terms of nits. This patch writes to the appropriate DPCD registers to enable aux based backlight using values in nits. --v2 -Fix max_cll and max_fall assignment [Jani] -Fix th

Re: [PATCH] drm/i915/display: Fixed a screen flickering when turning on display from off

2024-03-06 Thread Jani Nikula
On Wed, 06 Mar 2024, gareth...@intel.com wrote: > From: Gareth Yu > > Turn on the panel from zero brightness of the last state, the panel was set > a maximum PWM in the flow. Once the panel initialization is completed, the > backlight is restored to zero brightness. There is a flckering generated.

[PATCH v3 0/6] ALPM AUX-Less

2024-03-06 Thread Jouni Högander
This patch set is implementing calculation of ALPM AUX-Less parameters for Intel HW and writing them in case of AUX-Less is enabled. It is also enabling ALPM AUX-Less for eDP Panel Replay. Current code is not allowing Panel Replay on eDP. Patches for this are coming later. This implementation is o

[PATCH v3 1/6] drm/display: Add missing aux less alpm wake related bits

2024-03-06 Thread Jouni Högander
eDP1.5 adds some more bits into DP_RECEIVER_ALPM_CAP and DP_RECEIVER_ALPM_CONFIG registers. Add definitions for these. Signed-off-by: Jouni Högander --- include/drm/display/drm_dp.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/drm/display/drm_dp.h b/include/drm

[PATCH v3 2/6] drm/i915/psr: Add missing ALPM AUX-Less register definitions

2024-03-06 Thread Jouni Högander
Couple of ALPM AUX-Less related fields are missing from ALPM register definitions. Add these and remove some duplicate definitions. Bspec: 70294 V2: add Bspec reference Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr_regs.h | 12 1 file changed, 8 insertio

[PATCH v3 3/6] drm/i915/psr: Calculate aux less wake time

2024-03-06 Thread Jouni Högander
Calculate aux less wake time and store it into alpm_params struct Bspec: 71477 v3: - use ALPM_CTL_AUX_LESS_WAKE_TIME_MASK instead of value 63 v2: - use variables instead of values directly - fix max value - move converting port clock to Mhz into _lnl_compute_aux_less_wake_time Signed-off

[PATCH v3 4/6] drm/i915/psr: Silence period and lfps half cycle

2024-03-06 Thread Jouni Högander
Add get function for silence period and lfps half cycle. Values are taken from the tables in bspec. Bspec: 71632 v3: - use PORT_ALPM_CTL_SILENCE_PERIOD_MASK instead of value 255 - use PORT_ALPM_LFPS_CTL_LAST_LFPS_HALF_CYCLE_DURATION_MASK instead of value 31 v2: - fix some checks - add

[PATCH v3 5/6] drm/i915/psr: Enable ALPM for eDP Panel replay

2024-03-06 Thread Jouni Högander
Enable ALPM AUX-Less for Panel Replay eDP. Also write all calculated AUX-Less configuration values accordingly. Bspec: 71477 v3: - do not use alpm_ctl as uninitialized variable v2: - do not set AUX-Wake related bits for AUX-Less case - drop switch to active latency - add SLEEP_HOLD_TIME_5

[PATCH v3 6/6] drm/i915/psr: Do not write ALPM configuration for PSR1 or DP2.0 Panel Replay

2024-03-06 Thread Jouni Högander
No need to write ALPM configuration for DP2.0 Panel Replay or PSR1. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.

✗ Fi.CI.BAT: failure for drm/i915: Make crtc disable more atomic (rev2)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Make crtc disable more atomic (rev2) URL : https://patchwork.freedesktop.org/series/130715/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14396 -> Patchwork_130715v2 Summary ---

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Use drm_printer more (rev6)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Use drm_printer more (rev6) URL : https://patchwork.freedesktop.org/series/129956/ State : warning == Summary == Error: dim checkpatch failed d386f64d74bf drm/i915: Indicate which pipe failed the fastset check overall 9418dec47256 drm/i915: Include CRTC i

✗ Fi.CI.SPARSE: warning for drm/i915: Use drm_printer more (rev6)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Use drm_printer more (rev6) URL : https://patchwork.freedesktop.org/series/129956/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.BAT: failure for drm/i915: Use drm_printer more (rev6)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Use drm_printer more (rev6) URL : https://patchwork.freedesktop.org/series/129956/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14396 -> Patchwork_129956v6 Summary --- **FAILUR

RE: [PATCH 1/3] drm/i915/vrr: Generate VRR "safe window" for DSB

2024-03-06 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 6, 2024 9:38 AM > To: intel-gfx@lists.freedesktop.org > Cc: sta...@vger.kernel.org > Subject: [PATCH 1/3] drm/i915/vrr: Generate VRR "safe window" for DSB > > From: Ville Syrjälä > > Looks lik

[RFC v2 0/4] drm/i915: better high level abstraction for display

2024-03-06 Thread Jani Nikula
This is v2 of [1]. Improve the abstractions for display code. The main goals are: 1) The display code does not access struct drm_i915_private or struct xe_device. It only uses its own struct intel_display instead. 2) The i915 and xe driver cores do not access struct intel_display directly.

[RFC v2 1/4] drm/i915/display: ideas for further separating display code from the rest

2024-03-06 Thread Jani Nikula
Long term goal: Separate display code from struct drm_i915_private and i915_drv.h, and everything in them. Ditto for xe. First step, draft some ideas how we could use struct intel_display as the main device structure for display, while struct drm_device remains in struct drm_i915_private (or, in t

[RFC v2 2/4] drm/i915/display: add generic to_intel_display() macro

2024-03-06 Thread Jani Nikula
Convert various pointers to struct intel_display * using _Generic(). Add some macro magic to make adding new conversions easier, and somewhat abstract the need to cast each generic association. The cast is required because all associations needs to compile, regardless of the type and the generic s

[RFC v2 3/4] drm/i915/display: accept either i915 or display for feature tests

2024-03-06 Thread Jani Nikula
Use _Generic() to allow passing either struct drm_i915_private * or struct intel_display * to the feature test macros. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_device.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[RFC v2 4/4] drm/i915/display: test various to_intel_display() scenarios

2024-03-06 Thread Jani Nikula
Drafting and testing various cases for switching to struct intel_display. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 6 +++--- drivers/gpu/drm/i915/display/intel_hdmi.c | 13 +++-- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/gp

RE: [PATCH 2/3] drm/i915/dsb: Fix DSB vblank waits when using VRR

2024-03-06 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 6, 2024 9:38 AM > To: intel-gfx@lists.freedesktop.org > Cc: sta...@vger.kernel.org > Subject: [PATCH 2/3] drm/i915/dsb: Fix DSB vblank waits when using VRR > > From: Ville Syrjälä > > Looks li

Re: [PATCH] drm/i915/dp: Enable AUX based backlight for HDR

2024-03-06 Thread Ville Syrjälä
On Wed, Mar 06, 2024 at 02:29:15PM +0530, Suraj Kandpal wrote: > As of now whenerver HDR is switched on we use the PWM to change the > backlight as opposed to AUX based backlight changes in terms of nits. > This patch writes to the appropriate DPCD registers to enable aux > based backlight using va

RE: [PATCH 3/3] drm/i915/dsb: Always set DSB_SKIP_WAITS_EN

2024-03-06 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 6, 2024 9:38 AM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 3/3] drm/i915/dsb: Always set DSB_SKIP_WAITS_EN > > From: Ville Syrjälä > > Bspec asks us to always set the DSB_SKIP_WAI

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix DSB vblank waits with VRR

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Fix DSB vblank waits with VRR URL : https://patchwork.freedesktop.org/series/130783/ State : warning == Summary == Error: dim checkpatch failed c527f76b1196 drm/i915/vrr: Generate VRR "safe window" for DSB 75c1e2c71126 drm/i915/dsb: Fix DSB vblank waits w

✗ Fi.CI.SPARSE: warning for drm/i915: Fix DSB vblank waits with VRR

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Fix DSB vblank waits with VRR URL : https://patchwork.freedesktop.org/series/130783/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:11

Re: [RFC v2 1/4] drm/i915/display: ideas for further separating display code from the rest

2024-03-06 Thread Jani Nikula
On Wed, 06 Mar 2024, Jani Nikula wrote: > Long term goal: Separate display code from struct drm_i915_private and > i915_drv.h, and everything in them. Ditto for xe. > > First step, draft some ideas how we could use struct intel_display as > the main device structure for display, while struct drm_d

✓ Fi.CI.BAT: success for drm/i915: Fix DSB vblank waits with VRR

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Fix DSB vblank waits with VRR URL : https://patchwork.freedesktop.org/series/130783/ State : success == Summary == CI Bug Log - changes from CI_DRM_14396 -> Patchwork_130783v1 Summary --- **SUCC

Re: [PATCH] drm/i915/scaler: Update Pipe src size check for DISPLAY_VER >= 12

2024-03-06 Thread Nautiyal, Ankit K
On 3/5/2024 8:56 PM, Ville Syrjälä wrote: On Mon, Feb 19, 2024 at 11:22:55AM +0530, Ankit Nautiyal wrote: For Earlier platforms, the Pipe source size is 12-bits so max pipe source width and height is 4096. For newer platforms it is 13-bits so theoretically max height is 8192, but maximum width

✗ Fi.CI.CHECKPATCH: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev5)

2024-03-06 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev5) URL : https://patchwork.freedesktop.org/series/130335/ State : warning == Summary == Error: dim checkpatch failed 56cdd12ac09c drm/i915: Enable Wa_16019325821 39caaedf6e24 drm/i915/guc: Add support for w/a KLV

✗ Fi.CI.SPARSE: warning for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev5)

2024-03-06 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev5) URL : https://patchwork.freedesktop.org/series/130335/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for Enable Wa_14019159160 and Wa_16019325821 for MTL (rev5)

2024-03-06 Thread Patchwork
== Series Details == Series: Enable Wa_14019159160 and Wa_16019325821 for MTL (rev5) URL : https://patchwork.freedesktop.org/series/130335/ State : success == Summary == CI Bug Log - changes from CI_DRM_14396 -> Patchwork_130335v5 Summary -

✗ Fi.CI.SPARSE: warning for TTM unlockable restartable LRU list iteration (rev4)

2024-03-06 Thread Patchwork
== Series Details == Series: TTM unlockable restartable LRU list iteration (rev4) URL : https://patchwork.freedesktop.org/series/130001/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for TTM unlockable restartable LRU list iteration (rev4)

2024-03-06 Thread Patchwork
== Series Details == Series: TTM unlockable restartable LRU list iteration (rev4) URL : https://patchwork.freedesktop.org/series/130001/ State : success == Summary == CI Bug Log - changes from CI_DRM_14396 -> Patchwork_130001v4 Summary

Re: [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe

2024-03-06 Thread Souza, Jose
On Wed, 2024-02-28 at 16:02 +0200, Juha-Pekka Heikkila wrote: > AuxCCS framebuffers don't work on Xe driver hence disable them > from plane capabilities until they are fixed. FlatCCS framebuffers > work and they are left enabled. CCS is left untouched for i915 > driver. > Fixes: 44e694958b95 ("dr

[PATCH v3 0/6] drm/i915/mst: enable MST mode for 128b/132b single-stream sideband

2024-03-06 Thread Jani Nikula
v3 of https://patchwork.freedesktop.org/series/129468/ Jani Nikula (6): drm/mst: read sideband messaging cap drm/i915/mst: improve debug logging of DP MST mode detect drm/i915/mst: abstract choosing the MST mode to use drm/i915/mst: use the MST mode detected previously drm/i915/mst: add

[PATCH v3 1/6] drm/mst: read sideband messaging cap

2024-03-06 Thread Jani Nikula
Amend drm_dp_read_mst_cap() to return an enum, indicating "SST", "SST with sideband messaging", or "MST". Modify all call sites to take the new return value into account. v2: - Rename enumerators (Ville) Cc: Arun R Murthy Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula

[PATCH v3 2/6] drm/i915/mst: improve debug logging of DP MST mode detect

2024-03-06 Thread Jani Nikula
Rename intel_dp_can_mst() to intel_dp_mst_detect(), and move all DP MST detect debug logging there. Debug log the sink's MST capability, including single-stream sideband messaging support, and the decision whether to enable MST mode or not. Do this regardless of whether we're actually enabling MST

[PATCH v3 3/6] drm/i915/mst: abstract choosing the MST mode to use

2024-03-06 Thread Jani Nikula
Clarify the conditions for choosing the MST mode to use by adding a new function intel_dp_mst_mode_choose(). This also prepares for being able to extend the MST modes to single-stream sideband messaging. Cc: Arun R Murthy Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula

[PATCH v3 4/6] drm/i915/mst: use the MST mode detected previously

2024-03-06 Thread Jani Nikula
Drop the duplicate read of DP_MSTM_CAP DPCD register, and the duplicate logic for choosing MST mode, and store the chosen mode in struct intel_dp. Rename intel_dp_configure_mst() to intel_dp_mst_configure() while at it. v2: Rebase on drm_dp_mst_detect() returning the mode, not bool Cc: Arun R Mur

[PATCH v3 6/6] drm/i915/mst: enable MST mode for 128b/132b single-stream sideband

2024-03-06 Thread Jani Nikula
If the sink supports 128b/132b and single-stream sideband messaging, enable MST mode. With this, the topology manager will still write DP_MSTM_CTRL, which should be ignored by the sink. In the future, the topology manager should probably only set the sideband messaging related parts of the registe

[PATCH v3 5/6] drm/i915/mst: add intel_dp_mst_disconnect()

2024-03-06 Thread Jani Nikula
Abstract the MST mode disconnect to a separate function. Cc: Arun R Murthy Cc: Ville Syrjälä Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/

Re: [PULL] drm-misc-fixes

2024-03-06 Thread Maxime Ripard
Hi, On Thu, Feb 29, 2024 at 01:54:30PM +, Matthew Auld wrote: > On 29/02/2024 13:37, Maxime Ripard wrote: > > Hi, > > > > Here's this week drm-misc fixes PR. > > > > There's two commits for files unders drivers/soc/qcom that don't have a > > maintainer Acked-by. Bjorn's Acked-by was provided

[PATCH] drm/i915: Drop WA 16015675438

2024-03-06 Thread Lucas De Marchi
With dynamic load-balancing disabled on the compute side, there's no reason left to enable WA 16015675438. Drop it from both PVC and DG2. Note that this can be done because now the driver always set a fixed partition of EUs during initialization via the ccs_mode configuration. The flag to GuC is s

Re: [PATCH v7 2/6] drm/i915: Unregister in-kernel clients

2024-03-06 Thread Thomas Zimmermann
Hi Am 05.03.24 um 17:25 schrieb Jani Nikula: On Tue, 05 Mar 2024, Rodrigo Vivi wrote: On Fri, Mar 01, 2024 at 02:42:55PM +0100, Thomas Zimmermann wrote: Unregister all in-kernel clients before unloading the i915 driver. For other drivers, drm_dev_unregister() does this automatically. As i915

Re: linux-next: build failure after merge of the kunit-next tree

2024-03-06 Thread Shuah Khan
Hi Stephen, On 3/1/24 15:30, Shuah Khan wrote: Hi Stephen, On 3/1/24 13:46, Stephen Rothwell wrote: Hi Shuah, On Fri, 1 Mar 2024 09:05:57 -0700 Shuah Khan wrote: On 3/1/24 03:43, Stephen Rothwell wrote: Hi all, On Fri, 1 Mar 2024 15:15:02 +0800 David Gow wrote: On Thu, 29 Feb 2024 at

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

2024-03-06 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/5/2024 5:41 PM, Christian König wrote: Am 05.03.24 um 12:14 schrieb Paneer Selvam, Arunpravin: On 3/5/2024 4:33 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add amdgp

Re: [PATCH v8 1/3] drm/buddy: Implement tracking clear page feature

2024-03-06 Thread Paneer Selvam, Arunpravin
Hi Matthew, Ping? Thanks, Arun. On 3/4/2024 10:02 PM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Tr

RE: Regression on linux-next (next-20240228)

2024-03-06 Thread Borah, Chaitanya Kumar
Hello Mathew, > -Original Message- > From: Matthew Wilcox > Sent: Tuesday, March 5, 2024 11:19 PM > To: Borah, Chaitanya Kumar > Cc: intel-gfx@lists.freedesktop.org; Kurmi, Suresh Kumar > ; Saarinen, Jani > Subject: Re: Regression on linux-next (next-20240228) > > On Tue, Mar 05, 2024

Re: ✗ Fi.CI.BAT: failure for drm/i915: Convert fbdev to DRM client (rev7)

2024-03-06 Thread Thomas Zimmermann
FYI, there's a possible regression reported here. I was not able to reproduce this bug locally with neither i915 nor xe. Am 01.03.24 um 18:42 schrieb Patchwork: Project List - Patchwork *Patch Details* *Series:* drm/i915: Convert fbdev to DRM client (rev7) *URL:* https://patchwork.freede

Re: [PATCH v8 1/3] drm/buddy: Implement tracking clear page feature

2024-03-06 Thread Matthew Auld
On 04/03/2024 16:32, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Track the available cleared pages siz

Re: [RFC v2 2/4] drm/i915/display: add generic to_intel_display() macro

2024-03-06 Thread Rodrigo Vivi
On Wed, Mar 06, 2024 at 02:24:36PM +0200, Jani Nikula wrote: > Convert various pointers to struct intel_display * using _Generic(). > > Add some macro magic to make adding new conversions easier, and somewhat > abstract the need to cast each generic association. The cast is required > because all

✗ Fi.CI.SPARSE: warning for IO and fast wake lines calculation and increase fw sync length (rev4)

2024-03-06 Thread Patchwork
== Series Details == Series: IO and fast wake lines calculation and increase fw sync length (rev4) URL : https://patchwork.freedesktop.org/series/130173/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./ar

Re: [RFC v2 0/4] drm/i915: better high level abstraction for display

2024-03-06 Thread Rodrigo Vivi
On Wed, Mar 06, 2024 at 02:24:34PM +0200, Jani Nikula wrote: > This is v2 of [1]. Improve the abstractions for display code. > > The main goals are: > > 1) The display code does not access struct drm_i915_private or struct >xe_device. It only uses its own struct intel_display instead. > > 2)

[PATCH 00/22] drm: fix headers, add header test facility

2024-03-06 Thread Jani Nikula
First, fix a bunch of issues in drm headers, uncovered with the last patch. A few kernel-doc warnings are just brushed under the carpet for now, with a FIXME comment. Otherwise, pretty straightforward stuff. Second, add a header test facility to catch issues at build time when CONFIG_DRM_HEADER_TE

[PATCH 02/22] drm: add missing header guards to drm_internal.h

2024-03-06 Thread Jani Nikula
Including the file twice leads to errors. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_internal.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h index 8e4faf0a28e6..d69744c9ac15 100644 --- a/drivers/gpu/drm/drm_inter

[PATCH 01/22] drm/crtc: make drm_crtc_internal.h self-contained

2024-03-06 Thread Jani Nikula
Forward declare struct drm_printer. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_crtc_internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h index a514d5207e41..72c26f996b3b 100644 --- a/drivers/gpu/drm/drm_

[PATCH 05/22] drm: bridge: samsung-dsim: make samsung-dsim.h self-contained

2024-03-06 Thread Jani Nikula
Include and forward declare struct platform device. Signed-off-by: Jani Nikula --- include/drm/bridge/samsung-dsim.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h index e0c105051246..9764d6eb5beb 100

✓ Fi.CI.BAT: success for IO and fast wake lines calculation and increase fw sync length (rev4)

2024-03-06 Thread Patchwork
== Series Details == Series: IO and fast wake lines calculation and increase fw sync length (rev4) URL : https://patchwork.freedesktop.org/series/130173/ State : success == Summary == CI Bug Log - changes from CI_DRM_14398 -> Patchwork_130173v4 =

[PATCH 03/22] drm/kunit: fix drm_kunit_helpers.h kernel-doc

2024-03-06 Thread Jani Nikula
s/_features/_feat/ to match code. Signed-off-by: Jani Nikula --- include/drm/drm_kunit_helpers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_kunit_helpers.h b/include/drm/drm_kunit_helpers.h index 6e99627edf45..e7cc17ee4934 100644 --- a/include/drm/drm_kun

[PATCH 04/22] drm/amdgpu: make amd_asic_type.h self-contained

2024-03-06 Thread Jani Nikula
Include for u8. Signed-off-by: Jani Nikula --- include/drm/amd_asic_type.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/amd_asic_type.h b/include/drm/amd_asic_type.h index 724c45e3e9a7..9be85b821aa6 100644 --- a/include/drm/amd_asic_type.h +++ b/include/drm/amd_asic_type.h

[PATCH 07/22] drm/crc: make drm_debugfs_crc.h self-contained and fix kernel-doc

2024-03-06 Thread Jani Nikula
Add a number of require includes and forward declare struct drm_crtc. s/crc/crcs/ kernel-doc to match code. Signed-off-by: Jani Nikula --- include/drm/drm_debugfs_crc.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_debugfs_crc.h b/include/drm/drm_debu

[PATCH 06/22] drm/dp_mst: fix drm_dp_mst_helper.h kernel-doc

2024-03-06 Thread Jani Nikula
Drop excess vcpi member documentation. Signed-off-by: Jani Nikula --- include/drm/display/drm_dp_mst_helper.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/drm/display/drm_dp_mst_helper.h b/include/drm/display/drm_dp_mst_helper.h index 9b19d8bd520a..3ae88a383a41 100644 --- a/includ

[PATCH 09/22] drm: fix drm_format_helper.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
As the documentation says, all the fields are considered private. Mark them private also for kernel-doc to silence warnings. Signed-off-by: Jani Nikula --- include/drm/drm_format_helper.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_format_helper.h b/include/drm/drm_format

[PATCH 08/22] drm/encoder: silence drm_encoder_slave.h kernel-doc

2024-03-06 Thread Jani Nikula
Mark some parts private to silence kernel-doc warnings, and add FIXME. Signed-off-by: Jani Nikula --- include/drm/drm_encoder_slave.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/drm_encoder_slave.h b/include/drm/drm_encoder_slave.h index 7214101fd731..7f0ee97bb3a5 100644 -

[PATCH 10/22] drm/lease: make drm_lease.h self-contained

2024-03-06 Thread Jani Nikula
Include for types used. Signed-off-by: Jani Nikula --- include/drm/drm_lease.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_lease.h b/include/drm/drm_lease.h index 5c9ef6a2aeae..53545b4ca9ef 100644 --- a/include/drm/drm_lease.h +++ b/include/drm/drm_lease.h @@ -6,6 +6,8

[PATCH 11/22] drm: fix drm_gem_vram_helper.h kernel-doc

2024-03-06 Thread Jani Nikula
Remove excess funcs kernel-doc. Signed-off-by: Jani Nikula --- include/drm/drm_gem_vram_helper.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/drm/drm_gem_vram_helper.h b/include/drm/drm_gem_vram_helper.h index e18429f09e53..c89c9bafeb44 100644 --- a/include/drm/drm_gem_vram_helper

[PATCH 12/22] drm/of: make drm_of.h self-contained

2024-03-06 Thread Jani Nikula
Include for ERR_PTR. Signed-off-by: Jani Nikula --- include/drm/drm_of.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_of.h b/include/drm/drm_of.h index 082a6e980d01..02d1cdd7f798 100644 --- a/include/drm/drm_of.h +++ b/include/drm/drm_of.h @@ -2,6 +2,7 @@ #ifndef __DRM_O

[PATCH 13/22] drm/i2c: silence ch7006.h and sil164.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
Mark some members private to silence kernel-doc warnings, and add FIXME comments. Signed-off-by: Jani Nikula --- include/drm/i2c/ch7006.h | 1 + include/drm/i2c/sil164.h | 1 + 2 files changed, 2 insertions(+) diff --git a/include/drm/i2c/ch7006.h b/include/drm/i2c/ch7006.h index 8390b437a1f8..

[PATCH 14/22] drm/suballoc: fix drm_suballoc.h kernel-doc

2024-03-06 Thread Jani Nikula
Rename dma_fence to fence to match code. Signed-off-by: Jani Nikula --- include/drm/drm_suballoc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_suballoc.h b/include/drm/drm_suballoc.h index c2188bb0b157..7ba72a81a808 100644 --- a/include/drm/drm_suballoc.h

[PATCH 15/22] drm/i915: fix i915_gsc_proxy_mei_interface.h kernel-doc

2024-03-06 Thread Jani Nikula
There's no proper way to document function pointer members, but at least silence the warnings. Signed-off-by: Jani Nikula --- include/drm/i915_gsc_proxy_mei_interface.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/i915_gsc_proxy_mei_interface.h b/include/d

[PATCH 16/22] drm/i915/hdcp: fix i915_hdcp_interface.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
Make the documentation match code. Signed-off-by: Jani Nikula --- include/drm/i915_hdcp_interface.h | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/include/drm/i915_hdcp_interface.h b/include/drm/i915_hdcp_interface.h index 4c9c8167c2d5..a9f2ee576de8 1006

[PATCH 17/22] drm/i915/pxp: fix i915_pxp_tee_interface.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
Make documentation match code. Signed-off-by: Jani Nikula --- include/drm/i915_pxp_tee_interface.h | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/include/drm/i915_pxp_tee_interface.h b/include/drm/i915_pxp_tee_interface.h index 7d96985f2d05..653e85d6e32

[PATCH 18/22] drm/ttm: fix ttm_bo.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
Some renames, some formatting fixes, add some as FIXME. Signed-off-by: Jani Nikula --- include/drm/ttm/ttm_bo.h | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/include/drm/ttm/ttm_bo.h b/include/drm/ttm/ttm_bo.h index 0223a41a64b2..8b1eb6828f0a 100644 ---

[PATCH 19/22] drm/ttm: make ttm_caching.h self-contained

2024-03-06 Thread Jani Nikula
Include for pgprot_t. Signed-off-by: Jani Nikula --- include/drm/ttm/ttm_caching.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/ttm/ttm_caching.h b/include/drm/ttm/ttm_caching.h index 235a743d90e1..a18f43e93aba 100644 --- a/include/drm/ttm/ttm_caching.h +++ b/include/drm/tt

[PATCH 21/22] drm/ttm: fix ttm_kmap_iter.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
There's no proper way to document function pointer members, but at least silence the warnings. Signed-off-by: Jani Nikula --- include/drm/ttm/ttm_kmap_iter.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/ttm/ttm_kmap_iter.h b/include/drm/ttm/ttm_kmap_iter.h

[PATCH 20/22] drm/ttm: fix ttm_execbuf_util.h kernel-doc warnings

2024-03-06 Thread Jani Nikula
Fix some formatting errors and excess documentation. Signed-off-by: Jani Nikula --- include/drm/ttm/ttm_execbuf_util.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/include/drm/ttm/ttm_execbuf_util.h b/include/drm/ttm/ttm_execbuf_util.h index 03aca29d3ce4..fac1e3e57

[PATCH 22/22] drm: ensure drm headers are self-contained and pass kernel-doc

2024-03-06 Thread Jani Nikula
Ensure drm headers build, are self-contained, have header guards, and have no kernel-doc warnings, when CONFIG_DRM_HEADER_TEST=y. The mechanism follows similar patters used in i915, xe, and usr/include. To cover include/drm, we need to recurse there using the top level Kbuild and the new include/

✓ Fi.CI.BAT: success for drm/i915/dp: Enable AUX based backlight for HDR (rev2)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915/dp: Enable AUX based backlight for HDR (rev2) URL : https://patchwork.freedesktop.org/series/130729/ State : success == Summary == CI Bug Log - changes from CI_DRM_14398 -> Patchwork_130729v2 Summary --

✗ Fi.CI.CHECKPATCH: warning for Disable automatic load CCS load balancing (rev6)

2024-03-06 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing (rev6) URL : https://patchwork.freedesktop.org/series/129951/ State : warning == Summary == Error: dim checkpatch failed c4061a06af34 drm/i915/gt: Disable HW load balancing for CCS cb3a146b7a46 drm/i915/gt: Refactor uabi en

[PATCH 3/5] drm/i915: Update IP_VER(12, 50)

2024-03-06 Thread Lucas De Marchi
With no platform declaring graphics/media IP_VER(12, 50), replace the checks throughout the code with IP_VER(12, 55) so the code makes sense by itself with no additional explanation of previous baggage. The info override for the various _info is then changed so the version definition is clearer wi

[PATCH 0/5] drm/i915: cleanup dead code

2024-03-06 Thread Lucas De Marchi
Remove platforms that never had their PCI IDs added to the driver and are of course marked with requiring force_probe. Note that most of the code for those platforms is actually used by subsequent ones, so it's not a huge amount of code being removed. drivers/gpu/drm/xe/compat-i915-headers/i915_dr

[PATCH 2/5] drm/i915: Drop dead code for xehpsdv

2024-03-06 Thread Lucas De Marchi
PCI IDs for XEHPSDV were never added and platform always marked with force_probe. Drop what's not used and rename some places to either be xehp or dg2, depending on the platform/IP checks. The registers not used anymore are also removed. Signed-off-by: Lucas De Marchi --- Potential problem here

[PATCH 1/5] drm/i915: Drop WA 16015675438

2024-03-06 Thread Lucas De Marchi
With dynamic load-balancing disabled on the compute side, there's no reason left to enable WA 16015675438. Drop it from both PVC and DG2. Note that this can be done because now the driver always set a fixed partition of EUs during initialization via the ccs_mode configuration. The flag to GuC is s

[PATCH 4/5] drm/i915: Drop dead code for pvc

2024-03-06 Thread Lucas De Marchi
PCI IDs for PVC were never added and platform always marked with force_probe. Drop what's not used and rename some places as needed. The registers not used anymore are also removed. Signed-off-by: Lucas De Marchi --- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 +- drivers/gpu/drm/i915/g

[PATCH 5/5] drm/i915: Remove special handling for !RCS_MASK()

2024-03-06 Thread Lucas De Marchi
With both XEHPSDV and PVC removed (as platforms, most of their code remain used by others), there's no need to handle !RCS_MASK() as other platforms don't ever have fused-off render. Remove those code paths and the special WA flag when initializing GuC. Signed-off-by: Lucas De Marchi --- drivers

✗ Fi.CI.BAT: failure for Disable automatic load CCS load balancing (rev6)

2024-03-06 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing (rev6) URL : https://patchwork.freedesktop.org/series/129951/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14398 -> Patchwork_129951v6 Summary ---

✗ Fi.CI.CHECKPATCH: warning for ALPM AUX-Less (rev3)

2024-03-06 Thread Patchwork
== Series Details == Series: ALPM AUX-Less (rev3) URL : https://patchwork.freedesktop.org/series/129938/ State : warning == Summary == Error: dim checkpatch failed 0b6310df18cc drm/display: Add missing aux less alpm wake related bits 46f774b6bd3b drm/i915/psr: Add missing ALPM AUX-Less registe

✗ Fi.CI.SPARSE: warning for ALPM AUX-Less (rev3)

2024-03-06 Thread Patchwork
== Series Details == Series: ALPM AUX-Less (rev3) URL : https://patchwork.freedesktop.org/series/129938/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for ALPM AUX-Less (rev3)

2024-03-06 Thread Patchwork
== Series Details == Series: ALPM AUX-Less (rev3) URL : https://patchwork.freedesktop.org/series/129938/ State : success == Summary == CI Bug Log - changes from CI_DRM_14398 -> Patchwork_129938v3 Summary --- **SUCCESS** No regress

✗ Fi.CI.SPARSE: warning for drm/i915: Fix VMA UAF on destroy against deactivate race (rev6)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Fix VMA UAF on destroy against deactivate race (rev6) URL : https://patchwork.freedesktop.org/series/129026/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86

✗ Fi.CI.BAT: failure for drm/i915: Fix VMA UAF on destroy against deactivate race (rev6)

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: Fix VMA UAF on destroy against deactivate race (rev6) URL : https://patchwork.freedesktop.org/series/129026/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14398 -> Patchwork_129026v6 S

✗ Fi.CI.CHECKPATCH: warning for drm/i915: better high level abstraction for display

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: better high level abstraction for display URL : https://patchwork.freedesktop.org/series/130805/ State : warning == Summary == Error: dim checkpatch failed 3000e528f9db drm/i915/display: ideas for further separating display code from the rest ffc3bd209f4

✗ Fi.CI.SPARSE: warning for drm/i915: better high level abstraction for display

2024-03-06 Thread Patchwork
== Series Details == Series: drm/i915: better high level abstraction for display URL : https://patchwork.freedesktop.org/series/130805/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

  1   2   >