On 8/7/2023 7:33 PM, Kandpal, Suraj wrote:
On 8/3/2023 6:33 PM, Suraj Kandpal wrote:
Add function to read any PPS register based on the intel_dsc_pps enum
provided. Add a function which will call the new pps read function and
place it in crtc state. Only PPS0 and
PPS1 are readout the rest of
Hi Suraj
The patch is tested without problem. Thank you.
Tested-by: William Tseng
The patch is tested and the issue is resolved. Thank you.
Tested-by: William Tseng
-Original Message-
From: Kandpal, Suraj
Sent: Monday, August 7, 2023 10:28 PM
To: intel-gfx@lists.freedesktop.org
Cc: Nautiyal, Ankit K ; Tseng, William
; Heikkila, Juha-pekka
; Kandpal, Suraj
Subject
LGTM.
Perhaps we can have shorter name for the helper and variable.
something like intel_dsc_get_vdsc_per_pipe, vdsc_instanances_per_pipe?
With that fixed, this is:
Reviewed-by: Ankit Nautiyal
On 8/3/2023 6:33 PM, Suraj Kandpal wrote:
We have a function that gets us the total of the vdsc e
Up until now we only verified one or two of the dsc pps
params like bits_per_component and bits_per_pixel this
patch series aim to readout almost all PPS param and get
them compared.
Along with that some work on making a common function to
read and write PPS param regiters is also done.
--v2
-Remo
In intel_vdsc_get_config we only read the primary dsc engine register
and not take into account if the other dsc engine is in use and if
both registers have the same value or not this patche fixes that by
adding a check.
--v3
-Remove superfluos new line [Jani]
-Fix register naming [Jani]
--v5
-pp
This patch refactors dsc register related macros that prepares
the values to be written in the register. The current bit shifting
looks bad and going forward will not serve our purpose to readout
dsc register field values the change was suggested by Jani Nikula.
Cc: Jani Nikula
Signed-off-by: Sur
We have a function that gets us the total of the vdsc engines being
used but not the no. of vdsc instances being used by each pipe.
--v6
-Change function to static
--v7
-Shorten name to intel_dsc_get_vdsc_per_pipe
Signed-off-by: Suraj Kandpal
Reviewed-by: Ankit Nautiyal
---
drivers/gpu/drm/i9
Add function to read any PPS register based on the
intel_dsc_pps enum provided. Add a function which will call the
new pps read function and place it in crtc state. Only PPS0 and
PPS1 are readout the rest of the registers will be read in upcoming
patches.
--v2
-Changes in read function as PPS enum
Now that we have macros that can fetch dsc register values based
on pipe and pps parameters we can go ahead and remove all the
unused register.
Signed-off-by: Suraj Kandpal
---
.../gpu/drm/i915/display/intel_vdsc_regs.h| 259 ++
1 file changed, 24 insertions(+), 235 deletions
We have setup both the read and write functions so we can
move ahead and fill in all the readout state from PPS register
into the crtc_state so we can send it for comparision.
--v2
-Shorten comment to just PPSX rather than having the whole
"Readout PPSX register" [Jani]
-Remove pps_temp reinitiali
Now that we have a function that reads any PPS register based
on intel_dsc_pps enum provided lets create a function that can
write on any PPS.
--v2
-Changes need as PPS enum was dropped
-Remove duplicated code in intel_dsc_write_pps_reg [Jani]
--v3
-Use dsc_split instead of num_vdsc_instances [An
With the dsc config being readout and filled in crtc_state add
macros and use them to compare current and previous PPS param in
DSC.
--v2
-Remove version check [Jani]
-Remove dupe macro for dsc pipe compare and use the existing ones
[Jani]
Signed-off-by: Suraj Kandpal
Reviewed-by: Ankit Nautiyal
== Series Details ==
Series: drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI (rev2)
URL : https://patchwork.freedesktop.org/series/122108/
State : warning
== Summary ==
Error: dim checkpatch failed
/home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such
== Series Details ==
Series: drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI (rev2)
URL : https://patchwork.freedesktop.org/series/122108/
State : warning
== Summary ==
Error: dim sparse failed
/home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such
file
== Series Details ==
Series: drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI (rev2)
URL : https://patchwork.freedesktop.org/series/122108/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13489 -> Patchwork_122108v2
== Series Details ==
Series: Add DSC PPS readout (rev7)
URL : https://patchwork.freedesktop.org/series/120456/
State : warning
== Summary ==
Error: dim checkpatch failed
/home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No
such file or directory
== Series Details ==
Series: Add DSC PPS readout (rev7)
URL : https://patchwork.freedesktop.org/series/120456/
State : warning
== Summary ==
Error: dim sparse failed
/home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No
such file or directory
== Series Details ==
Series: Add DSC PPS readout (rev7)
URL : https://patchwork.freedesktop.org/series/120456/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13489 -> Patchwork_120456v7
Summary
---
**SUCCESS**
No r
== Series Details ==
Series: Test conflict fix for "Fix Wa_22016122933 implementation" (rev2)
URL : https://patchwork.freedesktop.org/series/122099/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13488_full -> Patchwork_122099v2_full
Separate out functions for getting maximum and minimum input BPC based
on platforms, when DSC is used.
v2: Use HAS_DSC macro instead of platform check while getting min input
bpc. (Stan)
Signed-off-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_dp.c | 35 +++--
1
== Series Details ==
Series: DSC misc fixes (rev6)
URL : https://patchwork.freedesktop.org/series/117662/
State : warning
== Summary ==
Error: dim checkpatch failed
/home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such
file or directory
== Series Details ==
Series: DSC misc fixes (rev6)
URL : https://patchwork.freedesktop.org/series/117662/
State : warning
== Summary ==
Error: dim sparse failed
/home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such
file or directory
> -Original Message-
> From: Sousa, Gustavo
> Sent: Thursday, August 3, 2023 5:03 PM
> To: Taylor, Clinton A ;
> intel-gfx@lists.freedesktop.org
> Cc: Sripada, Radhakrishna ; Kahola, Mika
>
> Subject: Re: [PATCH 1/4] drm/i915/cx0: Add intel_cx0_get_owned_lane_mask()
>
> Quoting Taylor,
== Series Details ==
Series: DSC misc fixes (rev6)
URL : https://patchwork.freedesktop.org/series/117662/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13489 -> Patchwork_117662v6
Summary
---
**SUCCESS**
No regres
== Series Details ==
Series: drm/i915/dp: Fix LT debug print in SDP CRC enable (rev2)
URL : https://patchwork.freedesktop.org/series/120719/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13489_full -> Patchwork_120719v2_full
On Fri, 04 Aug 2023, Vinod Govindapillai wrote:
> Optimize DP 2 SDP split config update so that DP-MST code
> path can be supported as well.
What's the optimization?
>
> Signed-off-by: Vinod Govindapillai
> ---
> drivers/gpu/drm/i915/display/intel_audio.c | 6 +++---
> drivers/gpu/drm/i915/
On Thu, 2023-06-22 at 12:09 +, Coelho, Luciano wrote:
> On Thu, 2023-06-22 at 10:08 +, Kandpal, Suraj wrote:
> > > On Tue, 2023-06-20 at 10:30 +, Kandpal, Suraj wrote:
> > > > > When intel_display_device_probe() (and, subsequently,
> > > > > probe_gmdid_display()) returns, the caller ex
Am 28.07.23 um 16:22 schrieb Simon Ser:
On Thursday, July 27th, 2023 at 14:01, Christian König
wrote:
We do need patches to stop trying to infer the node type from the minor
in libdrm, though. Emil has suggested using sysfs, which we already do
in a few places in libdrm.
That sounds like a r
On Thu, 13 Apr 2023, Radhakrishna Sripada
wrote:
> From: Mika Kahola
>
> PICA is used for DP alt mode and TBT modes. Hotplug interruption is routed
> from PICA chip to south display engine and from there to north display
> engine. This patch adds functionality to enable hotplug detection for
> a
I would like if these kernel patches are accepted by everyone, If yes,
when they can be upstream.
I have a MR for libdrm to support drm nodes type up to 2^MINORBITS
nodes which can work with these patches,
https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/305
Thanks!
James
On 2023-
== Series Details ==
Series: drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI (rev2)
URL : https://patchwork.freedesktop.org/series/122108/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13489_full -> Patchwork_122108v2_full
==
Cleanups that should additionally help xe&i915 display integration.
Jani Nikula (4):
drm/i915/irq: add dedicated intel_display_irq_init()
drm/i915/irq: add dg1_de_irq_postinstall()
drm/i915/irq: add ilk_de_irq_postinstall()
drm/i915/irq: move all PCH irq postinstall calls to display code
Continue splitting display from the rest.
Signed-off-by: Jani Nikula
---
.../gpu/drm/i915/display/intel_display_driver.c | 2 ++
.../gpu/drm/i915/display/intel_display_irq.c| 17 +
.../gpu/drm/i915/display/intel_display_irq.h| 2 ++
drivers/gpu/drm/i915/i915_irq.c
Add a dedicated de postinstall function.
Signed-off-by: Jani Nikula
---
.../gpu/drm/i915/display/intel_display_irq.c| 17 -
.../gpu/drm/i915/display/intel_display_irq.h| 2 +-
drivers/gpu/drm/i915/i915_irq.c | 11 +--
3 files changed, 18 insertion
Add a dedicated de postinstall function.
Signed-off-by: Jani Nikula
---
.../gpu/drm/i915/display/intel_display_irq.c | 41 +++
.../gpu/drm/i915/display/intel_display_irq.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 38 +
3 files changed, 43 insertio
Unify on making the calls from display code. Need to add an if ladder in
gen8_de_irq_postinstall() for now, but the function looks like it could
be overall be better split by platform. Something for the future.
The display version check for mtp seems a bit suspect, but this matches
current code.
== Series Details ==
Series: Add DSC PPS readout (rev7)
URL : https://patchwork.freedesktop.org/series/120456/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13489_full -> Patchwork_120456v7_full
Summary
---
**FAILURE
== Series Details ==
Series: DSC misc fixes (rev6)
URL : https://patchwork.freedesktop.org/series/117662/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13489_full -> Patchwork_117662v6_full
Summary
---
**SUCCESS**
Cybernet T10C cannot be dimmed without the backlight strobing. Create a
new quirk to lock the minimum brightness to the highest supported value.
This aligns the device with its behavior on Windows, which will not
lower the brightness below maximum.
Signed-off-by: Allen Ballway
---
V2 -> V3: Fix t
== Series Details ==
Series: Test conflict fix for "Fix Wa_22016122933 implementation" (rev3)
URL : https://patchwork.freedesktop.org/series/122099/
State : warning
== Summary ==
Error: dim checkpatch failed
/home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such
file o
== Series Details ==
Series: Test conflict fix for "Fix Wa_22016122933 implementation" (rev3)
URL : https://patchwork.freedesktop.org/series/122099/
State : warning
== Summary ==
Error: dim sparse failed
/home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No
such file or
== Series Details ==
Series: Test conflict fix for "Fix Wa_22016122933 implementation" (rev3)
URL : https://patchwork.freedesktop.org/series/122099/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13492 -> Patchwork_122099v3
== Series Details ==
Series: drm/i915/irq: cleanups
URL : https://patchwork.freedesktop.org/series/122165/
State : warning
== Summary ==
Error: dim checkpatch failed
/home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No
such file or directory
== Series Details ==
Series: drm/i915/irq: cleanups
URL : https://patchwork.freedesktop.org/series/122165/
State : warning
== Summary ==
Error: dim sparse failed
/home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such
file or directory
== Series Details ==
Series: drm/i915/irq: cleanups
URL : https://patchwork.freedesktop.org/series/122165/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13492 -> Patchwork_122165v1
Summary
---
**SUCCESS**
No regre
== Series Details ==
Series: drm/i915/quirk: Add quirk for devices that cannot be dimmed (rev4)
URL : https://patchwork.freedesktop.org/series/118971/
State : warning
== Summary ==
Error: dim checkpatch failed
/home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No
such fi
== Series Details ==
Series: drm/i915/quirk: Add quirk for devices that cannot be dimmed (rev4)
URL : https://patchwork.freedesktop.org/series/118971/
State : warning
== Summary ==
Error: dim sparse failed
/home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No
such file o
== Series Details ==
Series: drm/i915/quirk: Add quirk for devices that cannot be dimmed (rev4)
URL : https://patchwork.freedesktop.org/series/118971/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13492 -> Patchwork_118971v4
On Tue, Aug 08, 2023 at 06:53:28PM +0300, Jani Nikula wrote:
> Continue splitting display from the rest.
>
> Signed-off-by: Jani Nikula
> ---
> .../gpu/drm/i915/display/intel_display_driver.c | 2 ++
> .../gpu/drm/i915/display/intel_display_irq.c| 17 +
> .../gpu/drm/i915/di
On Tue, Aug 08, 2023 at 06:53:29PM +0300, Jani Nikula wrote:
> Add a dedicated de postinstall function.
>
> Signed-off-by: Jani Nikula
> ---
> .../gpu/drm/i915/display/intel_display_irq.c| 17 -
> .../gpu/drm/i915/display/intel_display_irq.h| 2 +-
> drivers/gpu/drm/i915
On Tue, Aug 08, 2023 at 06:53:30PM +0300, Jani Nikula wrote:
> Add a dedicated de postinstall function.
>
> Signed-off-by: Jani Nikula
> ---
> .../gpu/drm/i915/display/intel_display_irq.c | 41 +++
> .../gpu/drm/i915/display/intel_display_irq.h | 1 +
> drivers/gpu/drm/i915/i9
On Tue, Aug 08, 2023 at 06:53:31PM +0300, Jani Nikula wrote:
> Unify on making the calls from display code. Need to add an if ladder in
> gen8_de_irq_postinstall() for now, but the function looks like it could
> be overall be better split by platform. Something for the future.
>
> The display vers
Hi Andi,
On 2023-08-03 8:36 a.m., Andi Shyti wrote:
Hi Zhanjun,
On Thu, Jul 27, 2023 at 01:13:23PM -0700, Zhanjun Dong wrote:
This attempts to avoid circular locking dependency between flush delayed work
and intel_gt_reset.
Switched from cancel_delayed_work_sync to cancel_delayed_work, the n
Hi Daniel,
On 2023-08-03 9:03 a.m., Daniel Vetter wrote:
On Thu, 27 Jul 2023 at 22:13, Zhanjun Dong wrote:
This attempts to avoid circular locking dependency between flush delayed work
and intel_gt_reset.
Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync
version f
== Series Details ==
Series: Test conflict fix for "Fix Wa_22016122933 implementation" (rev4)
URL : https://patchwork.freedesktop.org/series/122099/
State : warning
== Summary ==
Error: dim checkpatch failed
/home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such
file o
== Series Details ==
Series: Test conflict fix for "Fix Wa_22016122933 implementation" (rev4)
URL : https://patchwork.freedesktop.org/series/122099/
State : warning
== Summary ==
Error: dim sparse failed
/home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such
file or di
== Series Details ==
Series: Test conflict fix for "Fix Wa_22016122933 implementation" (rev4)
URL : https://patchwork.freedesktop.org/series/122099/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13492 -> Patchwork_122099v4
Hi all,
Today's linux-next merge of the fbdev tree got a conflict in:
drivers/video/fbdev/Kconfig
between commit:
8c47895b70a2 ("fbdev/mx3fb: Use fbdev I/O helpers")
from the drm-misc tree and commit:
87ac8777d424 ("fbdev: mx3fb: Remove the driver")
from the fbdev tree.
I fixed it up
Register read for requested_freq can return 0 when system is
in runtime_pm. Make allowance for this case.
Link: https://gitlab.freedesktop.org/drm/intel/issues/8736
Link: https://gitlab.freedesktop.org/drm/intel/issues/8989
Signed-off-by: Vinay Belgaumkar
---
tests/i915/i915_pm_freq_api.c | 18
On Mon, Aug 07, 2023 at 10:19:07AM -0700, Sean Christopherson wrote:
> On Mon, Aug 07, 2023, Like Xu wrote:
> > On 23/12/2022 8:57 am, Sean Christopherson wrote:
> > > +static inline void kvm_page_track_write(struct kvm_vcpu *vcpu, gpa_t gpa,
> > > + const u8 *new, i
On 03-08-2023 14:19, Tvrtko Ursulin wrote:
>
> On 03/08/2023 06:15, Iddamsetty, Aravind wrote:
>> On 27-07-2023 15:43, Tvrtko Ursulin wrote:
>>> From: Tvrtko Ursulin
>>>
>>> Use the newly added drm_print_memory_stats helper to show memory
>>> utilisation of our objects in drm/driver specific f
== Series Details ==
Series: drm/i915/irq: cleanups
URL : https://patchwork.freedesktop.org/series/122165/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13492_full -> Patchwork_122165v1_full
Summary
---
**FAILURE**
== Series Details ==
Series: drm/i915/quirk: Add quirk for devices that cannot be dimmed (rev4)
URL : https://patchwork.freedesktop.org/series/118971/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13492_full -> Patchwork_118971v4_full
==
Workaround for disabling round to nearest even in the SF unit.
BSpec: 45818
Signed-off-by: Shekhar Chauhan
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
b/drivers/gpu/drm/i915/gt/intel_workaroun
65 matches
Mail list logo
