> From: Alex Williamson
> Sent: Friday, May 26, 2023 12:00 AM
>
> On Thu, 25 May 2023 03:03:54 +
> "Liu, Yi L" wrote:
>
> > > From: Alex Williamson
> > > Sent: Wednesday, May 24, 2023 11:32 PM
> > >
> > > On Wed, 24 May 2023 02:12:14 +
> > > "Liu, Yi L" wrote:
> > >
> > > > > From: Al
== Series Details ==
Series: drm/i915: Allow user to set cache at BO creation (rev13)
URL : https://patchwork.freedesktop.org/series/116870/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13188_full -> Patchwork_116870v13_full
===
On Wed, 24 May 2023, Nick Desaulniers wrote:
> On Wed, May 24, 2023 at 8:38 AM Nathan Chancellor wrote:
>>
>> Clang warns:
>>
>> drivers/gpu/drm/i915/display/intel_display.c:6012:3: error: unannotated
>> fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
>> c
On Tue, 23 May 2023, Jani Nikula wrote:
> On Tue, 23 May 2023, Tom Rix wrote:
>> clang with W=1 reports
>> drivers/gpu/drm/i915/display/intel_display.c:6012:3: error: unannotated
>> fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
>> case I915_FORMAT_MOD_X_TIL
On Thu, 25 May 2023, "Ceraolo Spurio, Daniele"
wrote:
> On 5/25/2023 2:49 AM, Jani Nikula wrote:
>> Use <> instead of "" for including headers from include/.
>>
>> Fixes: 8a9bf29546a1 ("drm/i915/gsc: add initial support for GSC proxy")
>> Cc: Daniele Ceraolo Spurio
>> Cc: Alan Previn
>> Signed-
[ I don't know why I'm getting weird new warnings today... Did
something change in the Kconfig? -dan ]
Hello Tvrtko Ursulin,
The patch 6407cf533217: "drm/i915/selftests: Stop using
kthread_stop()" from Oct 20, 2022, leads to the following Smatch
static checker warning:
drivers/gpu/dr
On Wed, 24 May 2023, Luca Coelho wrote:
> Currently a pointer to an intel_runtime_pm structure is stored in the
> wake reference structures so the runtime data can be accessed. We can
> save the entire device information (drm_i915_private) instead, since
> we'll need to reference the new workqueu
On Thu, 25 May 2023, "Shankar, Uma" wrote:
>> -Original Message-
>> From: Intel-gfx On Behalf Of Ville
>> Syrjala
>> Sent: Thursday, April 13, 2023 10:19 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: dri-de...@lists.freedesktop.org
>> Subject: [Intel-gfx] [PATCH v2 6/7] drm/i915: No 1
Daniel,
On 4/28/23 14:52, Thomas Hellström wrote:
Condsider the following call sequence:
/* Upper layer */
dma_fence_begin_signalling();
lock(tainted_shared_lock);
/* Driver callback */
dma_fence_begin_signalling();
...
The driver might here use a utility that is annotated as intended for the
== Series Details ==
Series: drm/i915: use localized __diag_ignore_all() instead of per file
URL : https://patchwork.freedesktop.org/series/118395/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13188_full -> Patchwork_118395v1_full
=
On Wed, 24 May 2023, Tvrtko Ursulin wrote:
> On 24/05/2023 10:05, Luca Coelho wrote:
>> In order to avoid flush_scheduled_work() usage, add a dedicated
>> workqueue in the drm_i915_private structure. In this way, we don't
>> need to use the system queue anymore.
>>
>> This change is mostly mecha
Hello Chris Wilson,
The patch eb5c10cbbc2f: "drm/i915: Remove I915_USER_PRIORITY_SHIFT"
from Jan 20, 2021, leads to the following Smatch static checker
warning:
drivers/gpu/drm/i915/gt/selftest_execlists.c:1544 live_busywait_preempt()
error: 'ctx_hi' dereferencing possible ERR_PTR()
drivers/gpu/
Return the error code if i915_gem_object_create_internal() fails,
instead of returning success.
Fixes: cf586021642d ("drm/i915/gt: Pipelined page migration")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gt/selftest_migrate.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
Hello Matt Roper,
The patch 12e6f6dc78e4: "drm/i915/display: Handle GMD_ID
identification in display code" from May 23, 2023, leads to the
following Smatch static checker warning:
drivers/gpu/drm/i915/i915_driver.c:850 i915_driver_probe()
error: 'i915' dereferencing possible ERR_P
Hello Matthew Brost,
The patch 4e6835466771: "drm/i915/selftests: Add a cancel request
selftest that triggers a reset" from Jan 13, 2022, leads to the
following Smatch static checker warning:
drivers/gpu/drm/i915/selftests/i915_request.c:863 __cancel_reset()
warn: NEW missing erro
Hi
Am 24.05.23 um 22:57 schrieb Sui Jingfeng:
Hi,
we love your patch:
On 2023/5/24 17:21, Thomas Zimmermann wrote:
For framebuffers in I/O and system memory, add macros that set
struct fb_ops to the respective callback functions.
For deferred I/O, add macros that generate callback function
kernel_context() returns an error pointer. Use pointer-error
conversion functions to evaluate its return value, rather than
checking for a '0' return.
Fixes: eb5c10cbbc2f ("drm/i915: Remove I915_USER_PRIORITY_SHIFT")
Reported-by: Dan Carpenter
Signed-off-by: Andi Shyti
Cc: Chris Wilson < ch...@c
Hi
Am 24.05.23 um 22:23 schrieb Sui Jingfeng:
Tested-by: Sui Jingfeng
This version works fine, I have tested it On LoongArch with
drm/loongson(v14) as it is most handy for me.
Also because it using fbdev-generic. fbdev of IGT report no error. Then
I run fbtest from geert[1],
Before app
AGV configuration support for MTL
v2: added one missing patch in the previous version
v3: chekcpatch warning fixes
update index handling for the icl/tgl QGV point handling
program pmdemand code simplified
v4: update to debufs and pipe values pmdemand regiters
removed the macro usage
Follow the values from bspec for the percentage overhead for
efficiency in MTL BW calculations.
Bspec: 64631
Signed-off-by: Vinod Govindapillai
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/display/intel_bw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/dr
>From MTL onwwards, pcode locks the QGV point based on peak BW of
the intended QGV point passed by the driver. So the peak BW
calculation must match the value expected by the pcode. Update
the calculations as per the Bspec.
v2: use DIV_ROUND_* macro for the calculations (Ville)
v3: Use only DIV_R
In MTL onwards, pcode locks the GV point based on the peak BW
of a QGV point. So store the peak BW of all the QGV points.
v2: use DIV_ROUND_CLOSEST() for the peakBW calculation
Bspec: 64636
Signed-off-by: Vinod Govindapillai
Reviewed-by: Stanislav Lisovskiy
---
drivers/gpu/drm/i915/display/in
Extract intel_bw_check_qgv_points() from intel_bw_atomic_check
to facilitate future platform variations in handling SAGV
configurations.
Signed-off-by: Vinod Govindapillai
Reviewed-by: Stanislav Lisovskiy
---
drivers/gpu/drm/i915/display/intel_bw.c | 235 +---
1 file changed
MTL uses the peak BW of a QGV point to lock the required QGV
point instead of the QGV index. Instead of passing the deratedbw
of the selected bw_info, return the index to the selected
bw_info so that either deratedbw or peakbw can be used based on
the platform.
v2: use idx to store index returned
>From MTL onwards, we need to find the best QGV point based on
the required data rate and pass the peak BW of that point to
the punit to lock the corresponding QGV point.
Bspec: 64636
Signed-off-by: Vinod Govindapillai
Reviewed-by: Stanislav Lisovskiy
---
drivers/gpu/drm/i915/display/intel_bw.
From: Mika Kahola
MTL introduces a new way to instruct the PUnit with
power and bandwidth requirements of DE. Add the functionality
to program the registers and handle waits using interrupts.
The current wait time for timeouts is programmed for 10 msecs to
factor in the worst case scenarios. Chan
Hi Dan,
On Fri, May 26, 2023 at 02:59:31PM +0300, Dan Carpenter wrote:
> Return the error code if i915_gem_object_create_internal() fails,
> instead of returning success.
>
> Fixes: cf586021642d ("drm/i915/gt: Pipelined page migration")
> Signed-off-by: Dan Carpenter
> ---
> drivers/gpu/drm/i91
Hello
Thanks for the reviews and comments
I updated the patchsets regarding the styling issues
I still think port_clock changes should catch any active phys changes.
IMO, this is being going on for a while and could be optimized later as well if
needed!
But lets see if someone can comment on t
On Fri, May 26, 2023 at 02:58:01PM +0200, Andi Shyti wrote:
> Hi Dan,
>
> On Fri, May 26, 2023 at 02:59:31PM +0300, Dan Carpenter wrote:
> > Return the error code if i915_gem_object_create_internal() fails,
> > instead of returning success.
> >
> > Fixes: cf586021642d ("drm/i915/gt: Pipelined pag
On Thu, May 25, 2023 at 08:55:08PM +, Shankar, Uma wrote:
>
>
> > -Original Message-
> > From: dri-devel On Behalf Of
> > Ville Syrjala
> > Sent: Thursday, April 13, 2023 10:19 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: dri-de...@lists.freedesktop.org
> > Subject: [PATCH v2
On Thu, May 25, 2023 at 09:25:46PM +, Shankar, Uma wrote:
>
>
> > -Original Message-
> > From: Intel-gfx On Behalf Of
> > Ville Syrjala
> > Sent: Thursday, April 13, 2023 10:19 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: dri-de...@lists.freedesktop.org
> > Subject: [Intel-gfx
== Series Details ==
Series: drm/i915/selftests: fix an error code in copy()
URL : https://patchwork.freedesktop.org/series/118427/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13195 -> Patchwork_118427v1
Summary
---
Hi Dan,
On Fri, May 26, 2023 at 04:14:25PM +0300, Dan Carpenter wrote:
> On Fri, May 26, 2023 at 02:58:01PM +0200, Andi Shyti wrote:
> > Hi Dan,
> >
> > On Fri, May 26, 2023 at 02:59:31PM +0300, Dan Carpenter wrote:
> > > Return the error code if i915_gem_object_create_internal() fails,
> > > ins
== Series Details ==
Series: drm/i915/gt: Use the correct error value when kernel_context() fails
URL : https://patchwork.freedesktop.org/series/118429/
State : warning
== Summary ==
Error: dim checkpatch failed
73a5046dfd9e drm/i915/gt: Use the correct error value when kernel_context()
fails
== Series Details ==
Series: drm/i915/gt: Use the correct error value when kernel_context() fails
URL : https://patchwork.freedesktop.org/series/118429/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13195 -> Patchwork_118429v1
==
Bring back -Wunused-but-set-variable both in W=1 build as well as
locally for CI and development. This already found dubious code.
Jani Nikula (15):
drm/i915/plane: warn on non-zero plane offset
drm/i915/ddi: drop unused but set variable intel_dp
drm/i915/dsi: drop unused but set variable da
We assume the plane offset is 0. Warn if it's not. This also fixes a
warn on unused but set variable offset.
Suggested-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/i9xx_plane.c | 2 ++
drivers/gpu/drm/i915/display/skl_universal_plane.c | 1 +
2 files ch
Prepare for re-enabling -Wunused-but-set-variable.
The intel_dp variable has been unused since commit ef79fafe9dae
("drm/i915: Eliminate intel_dp.regs.dp_tp_{ctl,status}").
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_ddi.c | 4
1 file changed, 4 deletions(-)
diff --g
Prepare for re-enabling -Wunused-but-set-variable.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/vlv_dsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c
b/drivers/gpu/drm/i915/display/vlv_dsi.c
index cd90a30e04d8..aecd
Prepare for re-enabling -Wunused-but-set-variable.
The vbp is not used for anything in the readout, as we get
e.g. crtc_vtotal from BXT_MIPI_TRANS_VTOTAL.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/vlv_dsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/
Prepare for re-enabling -Wunused-but-set-variable.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dpll.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dpll.c
b/drivers/gpu/drm/i915/display/intel_dpll.c
index 824be7f0
Prepare for re-enabling -Wunused-but-set-variable.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_irq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c
b/drivers/gpu/drm/i915/display/intel_displa
Prepare for re-enabling -Wunused-but-set-variable.
Apparently sseu is leftover from commit 9a92732f040a ("drm/i915/gt: Add
general DSS steering iterator to intel_gt_mcr").
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c | 2 --
1 file changed, 2 deletions(-)
diff
Prepare for re-enabling -Wunused-but-set-variable.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_fb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fb.c
b/drivers/gpu/drm/i915/display/intel_fb.c
index 0d27a98dcbbe..4
Prepare for re-enabling -Wunused-but-set-variable.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
Prepare for re-enabling -Wunused-but-set-variable.
The variable 'c' appears unused, but I'm not sure what should be done
with it. Annotate it with __maybe_unused.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Prepare for re-enabling -Wunused-but-set-variable.
The variable is indeed 'unused' as the name suggests, but we can't just
drop it because i915_vma_unbind_unlocked() is annotated
__must_check. Apparently the selftest does not really need to check the
value.
Signed-off-by: Jani Nikula
---
driver
Prepare for re-enabling -Wunused-but-set-variable.
for_each_new_intel_plane_in_state() requires passing in a struct
intel_plane_state pointer, which it uses, but in many places this leads
to warning about unused but set variables. Annotate them with
__maybe_unused.
Signed-off-by: Jani Nikula
---
Prepare for re-enabling -Wunused-but-set-variable.
for_each_new_intel_crtc_in_state() requires passing in a struct
intel_crtc_state pointer, which it uses, but in a few places this leads
to warning about unused but set variables. Annotate them with
__maybe_unused.
Signed-off-by: Jani Nikula
---
Prepare for re-enabling -Wunused-but-set-variable.
Lacking a better idea, annotate the gma_bottom variables with
__maybe_unused.
Cc: Zhenyu Wang
Cc: Zhi Wang
Cc: intel-gvt-...@lists.freedesktop.org
Signed-off-by: Jani Nikula
---
Frankly I'm not sure what to do with these. Maybe the variables
W=1 enables -Wunused-but-set-variable. We disabled it locally in i915
Makefile as we were hitting a bunch of warnings. See commit 6a05d2900464
("drm/i915: Disable unused-but-set compiler warning").
With the issues fixed or annotated with __maybe_unused, re-enable the
warning not only in W=1 but al
On Fri, May 26, 2023 at 07:37:54PM +0300, Jani Nikula wrote:
> We assume the plane offset is 0. Warn if it's not. This also fixes a
> warn on unused but set variable offset.
>
> Suggested-by: Ville Syrjälä
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/i9xx_plane.c |
On Thu, May 25, 2023 at 1:30 PM Matthieu Baerts
wrote:
>
> Hi Nick,
>
> On 24/05/2023 20:56, Nick Desaulniers wrote:
> > On Wed, May 24, 2023 at 11:41 AM Nathan Chancellor
> > wrote:
> >>
> >> On Wed, May 24, 2023 at 11:32:32AM -0700, Nick Desaulniers wrote:
> >>> On Wed, May 24, 2023 at 8:38 AM
We assume the plane offset is 0. Warn if it's not. This also fixes a
warn on unused but set variable offset.
v2: initialize offset on the gen2/3 path (Ville)
Suggested-by: Ville Syrjälä
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/i9xx_plane.c
On Fri, 26 May 2023, Ville Syrjälä wrote:
> On Fri, May 26, 2023 at 07:37:54PM +0300, Jani Nikula wrote:
>> We assume the plane offset is 0. Warn if it's not. This also fixes a
>> warn on unused but set variable offset.
>>
>> Suggested-by: Ville Syrjälä
>> Signed-off-by: Jani Nikula
>> ---
>>
From: Fei Yang
[ Just resending this patch to in order to have the results from the igt's
written for this patch ]
This series introduce a new extension for GEM_CREATE,
1. end support for set caching ioctl [PATCH 1/2]
2. add set_pat extension for gem_create [PATCH 2/2]
v2: drop one patch that w
From: Fei Yang
To comply with the design that buffer objects shall have immutable
cache setting through out their life cycle, {set, get}_caching ioctl's
are no longer supported from MTL onward. With that change caching
policy can only be set at object creation time. The current code
applies a def
Hi Jani,
On Fri, May 26, 2023 at 07:38:02PM +0300, Jani Nikula wrote:
> Prepare for re-enabling -Wunused-but-set-variable.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gp
Hi Jani,
On Fri, May 26, 2023 at 07:38:03PM +0300, Jani Nikula wrote:
> Prepare for re-enabling -Wunused-but-set-variable.
>
> The variable 'c' appears unused, but I'm not sure what should be done
> with it. Annotate it with __maybe_unused.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/dr
Hi Jani,
On Fri, May 26, 2023 at 07:38:01PM +0300, Jani Nikula wrote:
> Prepare for re-enabling -Wunused-but-set-variable.
>
> Apparently sseu is leftover from commit 9a92732f040a ("drm/i915/gt: Add
> general DSS steering iterator to intel_gt_mcr").
>
> Signed-off-by: Jani Nikula
> ---
> drive
== Series Details ==
Series: mtl: add support for pmdemand (rev9)
URL : https://patchwork.freedesktop.org/series/116949/
State : warning
== Summary ==
Error: dim checkpatch failed
46ebac6b36e6 drm/i915: fix the derating percentage for MTL
e38d851823c0 drm/i915: update the QGV point frequency c
== Series Details ==
Series: mtl: add support for pmdemand (rev9)
URL : https://patchwork.freedesktop.org/series/116949/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: mtl: add support for pmdemand (rev9)
URL : https://patchwork.freedesktop.org/series/116949/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13196 -> Patchwork_116949v9
Summary
---
**SUCCESS
== Series Details ==
Series: drm/i915: re-enable -Wunused-but-set-variable (rev2)
URL : https://patchwork.freedesktop.org/series/118439/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: re-enable -Wunused-but-set-variable (rev2)
URL : https://patchwork.freedesktop.org/series/118439/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13196 -> Patchwork_118439v2
Summary
== Series Details ==
Series: drm/i915: Allow user to set cache at BO creation (rev14)
URL : https://patchwork.freedesktop.org/series/116870/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Allow user to set cache at BO creation (rev14)
URL : https://patchwork.freedesktop.org/series/116870/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13196 -> Patchwork_116870v14
Summary
On Fri, 2023-05-05 at 09:04 -0700, Ceraolo Spurio, Daniele wrote:
> Add a new debugfs to dump information about the GSC. This includes:
alan:snip
Actually everything looks good except for a couple of questions + asks - hope
we can close on this patch in next rev.
>
> - the FW path and SW trackin
== Series Details ==
Series: drm/i915: re-enable -Wunused-but-set-variable (rev3)
URL : https://patchwork.freedesktop.org/series/118439/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: re-enable -Wunused-but-set-variable (rev3)
URL : https://patchwork.freedesktop.org/series/118439/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13196 -> Patchwork_118439v3
Summary
The following changes since commit d11ae98478d52548172918511f949aa92193f2c6:
brcm: Add symlinks from Pine64 devices to AW-CM256SM.txt (2023-05-25 08:26:29
-0400)
are available in the Git repository at:
git://anongit.freedesktop.org/drm/drm-firmware mtl_huc_8.5.0
for you to fetch changes up
From: Michal Wajdeczko
In addition to the already defined REQUEST HXG message format,
which is used when sender expects some confirmation or data,
HXG protocol includes definition of the FAST REQUEST message,
that may be used when sender does not expect any useful data
to be returned.
Using this
From: John Harrison
The GuC interface supports a mechanism for returning errors against
non-blocking H2G calls. This is called FAST_REQUEST. Given that the
call is asynchronous, matching the returned error up is difficult.
However, getting any error at all back is better than no error.
If any su
From: Michal Wajdeczko
Instead of printing message fence twice, include HXG header of the
unexpected message and its len.
Signed-off-by: Michal Wajdeczko
Signed-off-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff
From: Michal Wajdeczko
For easier debug of any unexpected error responses from GuC that
might be related to non-blocking fast requests, track action code (and
stack if under DEBUG_GUC config) for every H2G request.
Signed-off-by: Michal Wajdeczko
Signed-off-by: John Harrison
---
drivers/gpu/d
== Series Details ==
Series: Use FAST_REQUEST mechanism for non-blocking H2G calls
URL : https://patchwork.freedesktop.org/series/118450/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
patch link:
https://lore.kernel.org/r/0988d237e56c56568f035053da8e2e2308a17d3a.1685119007.git.jani.nikula%40intel.com
patch subject: [Intel-gfx] [PATCH 01/15] drm/i915/plane: warn on non-zero plane
offset
config: x86_64-randconfig-x056-20230526
(https://download.01.org/0day-ci/archive/20230527
== Series Details ==
Series: Use FAST_REQUEST mechanism for non-blocking H2G calls
URL : https://patchwork.freedesktop.org/series/118450/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13196 -> Patchwork_118450v1
Summary
---
The HuC loading and authentication flow is once again changing and a new
"clear-media only" authentication step is introduced. The flow is as
follows:
1) The HuC is loaded via DMA - same as all non-GSC HuC binaries.
2) The HuC is authenticated by the GuC - this is the same step as
performed for a
Now that each FW has its own reserved area, we can keep them always
pinned and skip the pin/unpin dance on reset. This will make things
easier for the 2-step HuC authentication, which requires the FW to be
pinned in GGTT after the xfer is completed.
Since the vma is now valid for a long time and no
On MTL, for obvious reasons, HuC is only available on the media tile.
We already disable SW support for HuC on the root gt due to the
absence of VCS engines, but we also need to update the getparam to point
to the HuC struct in the media GT.
Signed-off-by: Daniele Ceraolo Spurio
Cc: John Harrison
Before we add the second step of the MTL HuC auth (via GSC), we need to
have the ability to differentiate between them. To do so, the huc
authentication check is duplicated for GuC and GSC auth, with meu
binaries being considered fully authenticated only after the GSC auth
step.
To report the diff
In the previous patch we extracted the offset of the legacy-style HuC
binary located within the GSC-enabled blob, so now we can use that to
load the HuC via DMA if the fuse is set that way.
Note that we now need to differentiate between "GSC-enabled binary" and
"loaded by GSC", so the former case h
The new binaries that support the 2-step authentication contain the
legacy-style binary, which we can use for loading the HuC via DMA. To
find out where this is located in the image, we need to parse the
manifest of the GSC-enabled HuC binary. The manifest consist of a
partition header followed by
The full authentication via the GSC requires an heci packet submission
to the GSC FW via the GSC CS. The GSC has new PXP command for this
(literally called NEW_HUC_AUTH).
The intel_huc_auth fuction is also updated to handle both authentication
types.
v2: check that the GuC auth for clear media has
Follow the same logic as DG2, so just a meu binary with no version number.
Signed-off-by: Daniele Ceraolo Spurio
Cc: Alan Previn
Reviewed-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
== Series Details ==
Series: drm/i915: HuC loading and authentication for MTL (rev5)
URL : https://patchwork.freedesktop.org/series/117080/
State : warning
== Summary ==
Error: dim checkpatch failed
a945d853fdb8 drm/i915/uc: perma-pin firmwares
-:123: ERROR:SPACING: space prohibited before tha
== Series Details ==
Series: drm/i915: HuC loading and authentication for MTL (rev5)
URL : https://patchwork.freedesktop.org/series/117080/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h
b/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h
index d55a66202576..8bce2b8aed84 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h
+++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_meu_headers.h
alan:snip
+struct
== Series Details ==
Series: drm/i915: HuC loading and authentication for MTL (rev5)
URL : https://patchwork.freedesktop.org/series/117080/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13196 -> Patchwork_117080v5
Summary
-
-tip
patch link:
https://lore.kernel.org/r/0988d237e56c56568f035053da8e2e2308a17d3a.1685119007.git.jani.nikula%40intel.com
patch subject: [Intel-gfx] [PATCH 01/15] drm/i915/plane: warn on non-zero plane
offset
config: i386-randconfig-i076-20230526
(https://download.01.org/0day-ci/archive/20230527
91 matches
Mail list logo
