[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DSC misc fixes

2023-05-12 Thread Patchwork
== Series Details == Series: DSC misc fixes URL : https://patchwork.freedesktop.org/series/117662/ State : warning == Summary == Error: dim checkpatch failed 8b7dfbf8e8be drm/i915/dp: Consider output_format while computing dsc bpp e7726119c13a drm/i915/dp_mst: Use output_format to get the fina

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DSC misc fixes

2023-05-12 Thread Patchwork
== Series Details == Series: DSC misc fixes URL : https://patchwork.freedesktop.org/series/117662/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: drop dependency on VLV_DISPLAY_BASE

2023-05-12 Thread Jani Nikula
On Thu, 11 May 2023, Ville Syrjälä wrote: > On Thu, May 11, 2023 at 06:21:53PM +0300, Jani Nikula wrote: >> CHV_FUSE_GT (0x182168) is purely about GT fuses, therefore belongs in >> intel_gt_regs.h, is in the gcfgmmio unit, but is technically in the VLV >> display base area. >> >> Add VLV_GUNIT_BA

Re: [Intel-gfx] [PATCH v2] drm/i915/ttm: fix i915_ttm_to_gem() kernel-doc

2023-05-12 Thread Jani Nikula
On Thu, 04 May 2023, "Das, Nirmoy" wrote: > On 5/4/2023 11:23 AM, Jani Nikula wrote: >> drivers/gpu/drm/i915/gem/i915_gem_ttm.h:50: warning: Function parameter or >> member 'bo' not described in 'i915_ttm_to_gem' >> >> v2: Fix return value documentation while at it (Rodrigo) >> >> Signed-off-by:

[Intel-gfx] ✗ Fi.CI.BAT: failure for DSC misc fixes

2023-05-12 Thread Patchwork
== Series Details == Series: DSC misc fixes URL : https://patchwork.freedesktop.org/series/117662/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13140 -> Patchwork_117662v1 Summary --- **FAILURE** Serious unknown

Re: [Intel-gfx] [PATCH] drm/i915/gt: Add workaround 14016712196

2023-05-12 Thread kernel test robot
Hi Tejas, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Tejas-Upadhyay/drm-i915-gt-Add-workaround-14016712196/20230512-132314 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip

Re: [Intel-gfx] [PATCH] drm/i915/gt: Add workaround 14016712196

2023-05-12 Thread kernel test robot
Hi Tejas, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Tejas-Upadhyay/drm-i915-gt-Add-workaround-14016712196/20230512-132314 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip

Re: [Intel-gfx] [PATCH v10 05/22] kvm/vfio: Accept vfio device file from userspace

2023-05-12 Thread Liu, Yi L
> From: Cédric Le Goater > Sent: Thursday, May 11, 2023 3:11 PM > > On 4/26/23 17:03, Yi Liu wrote: > > This defines KVM_DEV_VFIO_FILE* and make alias with KVM_DEV_VFIO_GROUP*. > > Old userspace uses KVM_DEV_VFIO_GROUP* works as well. > > > > diff --git a/virt/kvm/vfio.c b/virt/kvm/vfio.c > > ind

Re: [Intel-gfx] [PATCH] drm/i915/gt: Add workaround 14016712196

2023-05-12 Thread kernel test robot
Hi Tejas, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Tejas-Upadhyay/drm-i915-gt-Add-workaround-14016712196/20230512-132314 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip

[Intel-gfx] [PATCH 00/11] drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-12 Thread Thomas Zimmermann
DRM provides a number of wrappers around fbdev cfb_() sys_(), fb_io_() and fb_sys_() helpers. The DRM functions don't provide any additional functionality for most DRM drivers. So remove them and call the fbdev I/O helpers directly. The DRM fbdev I/O wrappers were originally added because does no

[Intel-gfx] [PATCH 03/11] drm/gma500: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Gma500 does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_GMA500_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend

[Intel-gfx] [PATCH 05/11] drm/fbdev-dma: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Fbdev-dma does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_FBDEV_DMA_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend

[Intel-gfx] [PATCH 07/11] drm/omapdrm: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Omapdrm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_OMAP_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend o

[Intel-gfx] [PATCH 10/11] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. Fbdev-generic was the only caller of the DRM helpers, so remove them from the helper module. Add CONFIG_DRM_FBDEV_GENERIC_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depe

[Intel-gfx] [PATCH 02/11] drm/exynos: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Exynos does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_EXYNOS_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend

[Intel-gfx] [PATCH 04/11] drm/radeon: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Radeon does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_RADEON_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend

[Intel-gfx] [PATCH 09/11] drm/fb-helper: Export helpers for marking damage areas

2023-05-12 Thread Thomas Zimmermann
Export drm_fb_helper_damage() and drm_fb_helper_damage_range(), which handle damage areas for fbdev emulation. This is a temporary export that allows to move the DRM I/O helpers for fbdev into drivers. Only fbdev-generic and i915 need them. Both will be updated to implement damage handling by thems

[Intel-gfx] [PATCH 08/11] drm/tegra: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Tegra does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_TEGRA_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend on

[Intel-gfx] [PATCH 01/11] drm/armada: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Armada does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_ARMADA_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend

[Intel-gfx] [PATCH 06/11] drm/msm: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Msm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_MSM_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend on the

[Intel-gfx] [PATCH 11/11] drm/i915: Implement dedicated fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. i915 was the only caller of the DRM helpers, so remove them from the helper module. Add CONFIG_DRM_I915_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend on the ne

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Turn off the timer to sample frequencies when GT is parked

2023-05-12 Thread Tvrtko Ursulin
On 12/05/2023 02:53, Ashutosh Dixit wrote: pmu_needs_timer() keeps the timer running even when GT is parked, ostensibly to sample requested/actual frequencies. However frequency_sample() has the following: /* Report 0/0 (actual/requested) frequency while parked. */ if (!intel_g

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: create workqueue dedicated to wake references

2023-05-12 Thread Tvrtko Ursulin
On 11/05/2023 09:20, Luca Coelho wrote: Add a work queue in the intel_wakeref structure to be used exclusively by the wake reference mechanism. This is needed in order to avoid using the system workqueue and relying on flush_scheduled_work(). Cc: Tetsuo Handa Cc: Tvrtko Ursulin Cc: Jani Nik

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Fix confused register capture list creation

2023-05-12 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix confused register capture list creation URL : https://patchwork.freedesktop.org/series/117655/ State : success == Summary == CI Bug Log - changes from CI_DRM_13140_full -> Patchwork_117655v1_full ===

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: create workqueue dedicated to wake references

2023-05-12 Thread Coelho, Luciano
On Fri, 2023-05-12 at 10:04 +0100, Tvrtko Ursulin wrote: > On 11/05/2023 09:20, Luca Coelho wrote: > > Add a work queue in the intel_wakeref structure to be used exclusively > > by the wake reference mechanism. This is needed in order to avoid > > using the system workqueue and relying on flush_sc

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-12 Thread Patchwork
== Series Details == Series: drm/fbdev: Remove DRM's helpers for fbdev I/O URL : https://patchwork.freedesktop.org/series/117671/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitop

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: create workqueue dedicated to wake references

2023-05-12 Thread Tvrtko Ursulin
On 12/05/2023 10:10, Coelho, Luciano wrote: On Fri, 2023-05-12 at 10:04 +0100, Tvrtko Ursulin wrote: On 11/05/2023 09:20, Luca Coelho wrote: Add a work queue in the intel_wakeref structure to be used exclusively by the wake reference mechanism. This is needed in order to avoid using the syst

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Silence UBSAN uninitialized bool variable warning

2023-05-12 Thread Andi Shyti
Hi Ashutosh, On Thu, May 11, 2023 at 10:43:30AM -0700, Dixit, Ashutosh wrote: > On Wed, 10 May 2023 11:36:06 -0700, Ashutosh Dixit wrote: > > > > Loading i915 on UBSAN enabled kernels (CONFIG_UBSAN/CONFIG_UBSAN_BOOL) > > causes the following warning: > > > > UBSAN: invalid-load in drivers/gpu/dr

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-12 Thread Patchwork
== Series Details == Series: drm/fbdev: Remove DRM's helpers for fbdev I/O URL : https://patchwork.freedesktop.org/series/117671/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13141 -> Patchwork_117671v1 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Silence UBSAN uninitialized bool variable warning

2023-05-12 Thread Andrzej Hajda
On 10.05.2023 20:36, Ashutosh Dixit wrote: Loading i915 on UBSAN enabled kernels (CONFIG_UBSAN/CONFIG_UBSAN_BOOL) causes the following warning: UBSAN: invalid-load in drivers/gpu/drm/i915/gt/uc/intel_uc.c:558:2 load of value 255 is not a valid value for type '_Bool' Call Trace: dump

Re: [Intel-gfx] [PATCH 06/11] drm/msm: Use regular fbdev I/O helpers

2023-05-12 Thread Dmitry Baryshkov
On Fri, 12 May 2023 at 11:41, Thomas Zimmermann wrote: > > Use the regular fbdev helpers for framebuffer I/O instead of DRM's > helpers. Msm does not use damage handling, so DRM's fbdev helpers > are mere wrappers around the fbdev code. > > Add CONFIG_DRM_MSM_FBDEV_EMULATION to select the necessar

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pmu: Turn off the timer to sample frequencies when GT is parked

2023-05-12 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Turn off the timer to sample frequencies when GT is parked URL : https://patchwork.freedesktop.org/series/117658/ State : success == Summary == CI Bug Log - changes from CI_DRM_13140_full -> Patchwork_117658v1_full

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: create workqueue dedicated to wake references

2023-05-12 Thread Coelho, Luciano
On Fri, 2023-05-12 at 10:32 +0100, Tvrtko Ursulin wrote: > On 12/05/2023 10:10, Coelho, Luciano wrote: > > On Fri, 2023-05-12 at 10:04 +0100, Tvrtko Ursulin wrote: > > > On 11/05/2023 09:20, Luca Coelho wrote: > > > > Add a work queue in the intel_wakeref structure to be used exclusively > > > > by

Re: [Intel-gfx] [PATCH] drm/i1915/guc: Fix probe injection CI failures after recent change

2023-05-12 Thread Andi Shyti
Hi John, On Wed, May 10, 2023 at 01:55:56PM -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > A recent change bumped a 'notice' message up to 'error' level for > debug builds to help trap incorrect configurations in CI systems. > Unfortunaetly, tha error condition in question is

[Intel-gfx] [PATCH 1/3] drm/i915/irq: convert gen8_de_irq_handler() to void

2023-05-12 Thread Jani Nikula
The return value is not used for anything. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_irq.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 02b6cbb832e9..64cc52538206 100644 ---

[Intel-gfx] [PATCH 2/3] drm/i915/irq: split out hotplug irq handling

2023-05-12 Thread Jani Nikula
Split hotplug irq handling out of i915_irq.[ch] into display/intel_hotplug_irq.[ch]. The line between the new intel_hotplug_irq.[ch] and the existing intel_hotplug.[ch] needs further clarification, but the first step is to move the stuff out of i915_irq.[ch]. Reviewed-by: Rodrigo Vivi Signed-off

[Intel-gfx] [PATCH 3/3] drm/i915/irq: split out display irq handling

2023-05-12 Thread Jani Nikula
Split (non-hotplug) display irq handling out of i915_irq.[ch] into display/intel_display_irq.[ch]. v2: - Rebase - Preserve [I915_MAX_PIPES] in functions (kernel test robot) Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile |1 + drivers/gpu/drm/i915/display/i9xx_p

Re: [Intel-gfx] [PATCH 00/11] drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-12 Thread Sam Ravnborg
Hi Thomas, On Fri, May 12, 2023 at 10:41:41AM +0200, Thomas Zimmermann wrote: > DRM provides a number of wrappers around fbdev cfb_() sys_(), fb_io_() > and fb_sys_() helpers. The DRM functions don't provide any additional > functionality for most DRM drivers. So remove them and call the fbdev > I

Re: [Intel-gfx] [PATCH 5/6] drm/i915/pmu: Prepare for multi-tile non-engine counters

2023-05-12 Thread Tvrtko Ursulin
On 12/05/2023 02:08, Dixit, Ashutosh wrote: On Fri, 05 May 2023 17:58:15 -0700, Umesh Nerlige Ramappa wrote: From: Tvrtko Ursulin Reserve some bits in the counter config namespace which will carry the tile id and prepare the code to handle this. No per tile counters have been added yet. v

Re: [Intel-gfx] [PATCH 6/6] drm/i915/pmu: Export counters from all tiles

2023-05-12 Thread Tvrtko Ursulin
On 11/05/2023 19:57, Dixit, Ashutosh wrote: On Fri, 05 May 2023 17:58:16 -0700, Umesh Nerlige Ramappa wrote: One drive-by comment: diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c index 12b2f3169abf..284e5c5b97bb 100644 --- a/drivers/gpu/drm/i915/i915_pmu.c +

[Intel-gfx] [PATCH 1/4] drm/i915/dpll: drop a useless I915_STATE_WARN_ON()

2023-05-12 Thread Jani Nikula
In general, we don't do assertions that a function gets called on the right platforms, and if we did, it should not be a state warn. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/inte

[Intel-gfx] [PATCH 2/4] drm/i915/crtc: replace I915_STATE_WARN_ON() with I915_STATE_WARN()

2023-05-12 Thread Jani Nikula
Describe the assertion better. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_crtc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c b/drivers/gpu/drm/i915/display/intel_crtc.c index df7d05f1e14b..1e3f88d00609 1

[Intel-gfx] [PATCH 3/4] drm/i915/display: remove I915_STATE_WARN_ON()

2023-05-12 Thread Jani Nikula
Remove the unused macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.h | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h index ac95961f68ba

[Intel-gfx] [PATCH 4/4] drm/i915/display: add i915 parameter to I915_STATE_WARN()

2023-05-12 Thread Jani Nikula
Add i915 parameter to I915_STATE_WARN() and use device based logging. Done using cocci + hand edited where there was no i915 local variable ready. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/g4x_dp.c | 4 +- drivers/gpu/drm/i915/display/intel_crtc.c | 4 +- drivers

Re: [Intel-gfx] [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-05-12 Thread Andy Shevchenko
On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: > Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to create > masks for fixed-width types and also the corresponding BIT_U32(), > BIT_U16() and BIT_U8(). Why? > All of those depend on a new "U" suffix added to the integer

[Intel-gfx] [PATCH] drm/i915/bios: add helper for reading SPI

2023-05-12 Thread Jani Nikula
Add helper for reading SPI to not duplicate the write&read combo everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_bios.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers

Re: [Intel-gfx] [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-05-12 Thread Jani Nikula
On Fri, 12 May 2023, Andy Shevchenko wrote: > On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: >> Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to create >> masks for fixed-width types and also the corresponding BIT_U32(), >> BIT_U16() and BIT_U8(). > > Why? The main r

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/hdcp: Fix modeset locking issue in hdcp mst

2023-05-12 Thread Nautiyal, Ankit K
On 5/11/2023 3:26 PM, Suraj Kandpal wrote: Since topology state is being added to drm_atomic_state now all drm_modeset_lock required are being taken from core this raises an issue when we try to loop over connector and assign vcpi id to our streams as we did not have atomic state to derive acqu

Re: [Intel-gfx] [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-05-12 Thread Andy Shevchenko
On Fri, May 12, 2023 at 02:25:18PM +0300, Jani Nikula wrote: > On Fri, 12 May 2023, Andy Shevchenko > wrote: > > On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: > >> Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to create > >> masks for fixed-width types and also the

Re: [Intel-gfx] [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-05-12 Thread Jani Nikula
On Fri, 12 May 2023, Andy Shevchenko wrote: > On Fri, May 12, 2023 at 02:25:18PM +0300, Jani Nikula wrote: >> On Fri, 12 May 2023, Andy Shevchenko >> wrote: >> > On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: >> >> Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to cr

Re: [Intel-gfx] [PATCH 00/11] drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-12 Thread Thomas Zimmermann
Hi Sam Am 12.05.23 um 12:29 schrieb Sam Ravnborg: Hi Thomas, On Fri, May 12, 2023 at 10:41:41AM +0200, Thomas Zimmermann wrote: DRM provides a number of wrappers around fbdev cfb_() sys_(), fb_io_() and fb_sys_() helpers. The DRM functions don't provide any additional functionality for most DR

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/irq: convert gen8_de_irq_handler() to void

2023-05-12 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/irq: convert gen8_de_irq_handler() to void URL : https://patchwork.freedesktop.org/series/117682/ State : warning == Summary == Error: dim checkpatch failed 6066890538dc drm/i915/irq: convert gen8_de_irq_handler() to void 3bfbcd

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/irq: convert gen8_de_irq_handler() to void

2023-05-12 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/irq: convert gen8_de_irq_handler() to void URL : https://patchwork.freedesktop.org/series/117682/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separat

[Intel-gfx] [PATCH] drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling

2023-05-12 Thread Mika Kahola
While disabling Thunderbolt PLL, we request PLL to be stopped and wait for ACK bit to be cleared. The expected value should be '0' instead of '~XELPDP_TBT_CLOCK_ACK' or otherwise we incorrectly receive dmesg warn "PHY PLL not unlocked in 10us". Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/irq: convert gen8_de_irq_handler() to void

2023-05-12 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/irq: convert gen8_de_irq_handler() to void URL : https://patchwork.freedesktop.org/series/117682/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13141 -> Patchwork_117682v1 ===

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: create workqueue dedicated to wake references

2023-05-12 Thread Tvrtko Ursulin
On 12/05/2023 10:54, Coelho, Luciano wrote: On Fri, 2023-05-12 at 10:32 +0100, Tvrtko Ursulin wrote: On 12/05/2023 10:10, Coelho, Luciano wrote: On Fri, 2023-05-12 at 10:04 +0100, Tvrtko Ursulin wrote: On 11/05/2023 09:20, Luca Coelho wrote: Add a work queue in the intel_wakeref structure t

Re: [Intel-gfx] [PATCH 1/3] drm/i915: add a dedicated workqueue inside drm_i915_private

2023-05-12 Thread Tvrtko Ursulin
On 11/05/2023 09:20, Luca Coelho wrote: In order to avoid flush_scheduled_work() usage, add a dedicated workqueue in the drm_i915_private structure. In this way, we don't need to use the system queue anymore. This change is mostly mechanical and based on Tetsuo's original patch[1]. Link: htt

Re: [Intel-gfx] [PATCH 1/3] drm/i915/irq: convert gen8_de_irq_handler() to void

2023-05-12 Thread Gustavo Sousa
Quoting Jani Nikula (2023-05-12 07:23:08) >The return value is not used for anything. > >Signed-off-by: Jani Nikula Reviewed-by: Gustavo Sousa >--- > drivers/gpu/drm/i915/i915_irq.c | 12 +--- > 1 file changed, 1 insertion(+), 11 deletions(-) > >diff --git a/drivers/gpu/drm/i915/i915_irq

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/dpll: drop a useless I915_STATE_WARN_ON()

2023-05-12 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/dpll: drop a useless I915_STATE_WARN_ON() URL : https://patchwork.freedesktop.org/series/117685/ State : warning == Summary == Error: dim checkpatch failed 0069d0cb8670 drm/i915/dpll: drop a useless I915_STATE_WARN_ON() 36901f43

Re: [Intel-gfx] [PATCH 3/3] drm/i915/irq: split out display irq handling

2023-05-12 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20230512] [cannot apply to drm-intel/for-linux-next-fixes linus/master v6.4-rc1] [If your patch is applied to the wrong git tree, kindly drop us a

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/dpll: drop a useless I915_STATE_WARN_ON()

2023-05-12 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/dpll: drop a useless I915_STATE_WARN_ON() URL : https://patchwork.freedesktop.org/series/117685/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13142 -> Patchwork_117685v1

[Intel-gfx] [PATCH] drm/i915/gvt: fix typo in comment

2023-05-12 Thread Deming Wang
Spelling mistake (triple letters) in comment. Signed-off-by: Deming Wang --- drivers/gpu/drm/i915/gvt/gvt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/gvt.h b/drivers/gpu/drm/i915/gvt/gvt.h index 2d65800d8e93..c933e9a1c5ad 100644 --- a/drivers/gp

Re: [Intel-gfx] [PATCH v4 13/14] drm/i915/tc: Call TypeC port flush_work/cleanup without modeset locks held

2023-05-12 Thread Imre Deak
On Thu, May 11, 2023 at 08:40:58PM +0300, Ville Syrjälä wrote: > On Wed, May 10, 2023 at 05:10:22PM +0300, Imre Deak wrote: > > On Wed, May 10, 2023 at 05:03:17PM +0300, Ville Syrjälä wrote: > > > On Wed, May 10, 2023 at 01:31:30PM +0300, Imre Deak wrote: > > > > Call the TypeC port flush_work and

Re: [Intel-gfx] [PATCH 00/11] drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-12 Thread Sam Ravnborg
Hi Thomas, > > > > Nice cleanup. > > > > From one of the patches: > > > > > +config DRM_ARMADA_FBDEV_EMULATION > > > + bool > > > + depends on DRM_ARMADA > > > + select FB_CFB_COPYAREA > > > + select FB_CFB_FILLRECT > > > + select FB_CFB_IMAGEBLIT > > > > This seems like a

Re: [Intel-gfx] [PATCH 3/3] drm/i915/irq: split out display irq handling

2023-05-12 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on next-20230512] [cannot apply to drm-intel/for-linux-next-fixes linus/master v6.4-rc1] [If your patch is applied to the wrong git tree, kindly drop us

Re: [Intel-gfx] [PATCH v4 14/14] drm/i915/tc: Reset TypeC PHYs left enabled in DP-alt mode after the sink disconnects

2023-05-12 Thread Imre Deak
On Thu, May 11, 2023 at 10:21:26PM +0300, Ville Syrjälä wrote: > On Wed, May 10, 2023 at 01:31:31PM +0300, Imre Deak wrote: > > If the output on a DP-alt link with its sink disconnected is kept > > enabled for too long (about 20 sec), then some IOM/TCSS firmware timeout > > will cause havoc on the

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bios: add helper for reading SPI (rev2)

2023-05-12 Thread Patchwork
== Series Details == Series: drm/i915/bios: add helper for reading SPI (rev2) URL : https://patchwork.freedesktop.org/series/103480/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13142 -> Patchwork_103480v2 Summary ---

Re: [Intel-gfx] [PATCH 04/11] drm/radeon: Use regular fbdev I/O helpers

2023-05-12 Thread Deucher, Alexander
[Public] > -Original Message- > From: Thomas Zimmermann > Sent: Friday, May 12, 2023 4:42 AM > To: dan...@ffwll.ch; airl...@gmail.com; maarten.lankho...@linux.intel.com; > mrip...@kernel.org; javi...@redhat.com > Cc: dri-de...@lists.freedesktop.org; linux-arm-ker...@lists.infradead.org; >

Re: [Intel-gfx] [PATCH] drm/i915/bios: add helper for reading SPI

2023-05-12 Thread Rodrigo Vivi
On Fri, May 12, 2023 at 02:14:46PM +0300, Jani Nikula wrote: > Add helper for reading SPI to not duplicate the write&read combo > everywhere. > > Signed-off-by: Jani Nikula BAT failure is likely a false positive on crcs... this patch looks correct to me without any functional change. Reviewed-b

Re: [Intel-gfx] [PATCH 1/4] drm/i915/dpll: drop a useless I915_STATE_WARN_ON()

2023-05-12 Thread Rodrigo Vivi
On Fri, May 12, 2023 at 02:04:41PM +0300, Jani Nikula wrote: > In general, we don't do assertions that a function gets called on the > right platforms, and if we did, it should not be a state warn. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/in

Re: [Intel-gfx] [PATCH 3/4] drm/i915/display: remove I915_STATE_WARN_ON()

2023-05-12 Thread Rodrigo Vivi
On Fri, May 12, 2023 at 02:04:43PM +0300, Jani Nikula wrote: > Remove the unused macro. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/intel_display.h | 15 ++- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/driv

Re: [Intel-gfx] [PATCH 4/4] drm/i915/display: add i915 parameter to I915_STATE_WARN()

2023-05-12 Thread Rodrigo Vivi
On Fri, May 12, 2023 at 02:04:44PM +0300, Jani Nikula wrote: > Add i915 parameter to I915_STATE_WARN() and use device based logging. > > Done using cocci + hand edited where there was no i915 local variable > ready. > > Signed-off-by: Jani Nikula with a bit of trust in coccinelle + compiler (fo

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling

2023-05-12 Thread Imre Deak
On Fri, May 12, 2023 at 03:00:03PM +0300, Mika Kahola wrote: > While disabling Thunderbolt PLL, we request PLL to be stopped and > wait for ACK bit to be cleared. The expected value should be '0' > instead of '~XELPDP_TBT_CLOCK_ACK' or otherwise we incorrectly > receive dmesg warn "PHY PLL not unlo

Re: [Intel-gfx] [PATCH 2/4] drm/i915/crtc: replace I915_STATE_WARN_ON() with I915_STATE_WARN()

2023-05-12 Thread Rodrigo Vivi
On Fri, May 12, 2023 at 02:04:42PM +0300, Jani Nikula wrote: > Describe the assertion better. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/intel_crtc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 8/8] gputop: Basic vendor agnostic GPU top tool

2023-05-12 Thread Rob Clark
On Thu, Apr 6, 2023 at 7:33 AM Tvrtko Ursulin wrote: > > > On 06/04/2023 15:21, Rob Clark wrote: > > On Thu, Apr 6, 2023 at 4:08 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 05/04/2023 18:57, Rob Clark wrote: > >>> On Tue, Jan 31, 2023 at 3:33 AM Tvrtko Ursulin > >>> wrote: > > From:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling

2023-05-12 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling URL : https://patchwork.freedesktop.org/series/117690/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13142 -> Patchwork_117690v1

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: fix typo in comment

2023-05-12 Thread Patchwork
== Series Details == Series: drm/i915/gvt: fix typo in comment URL : https://patchwork.freedesktop.org/series/117693/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13142 -> Patchwork_117693v1 Summary --- **FAILURE**

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: add helper for reading SPI (rev3)

2023-05-12 Thread Patchwork
== Series Details == Series: drm/i915/bios: add helper for reading SPI (rev3) URL : https://patchwork.freedesktop.org/series/103480/ State : success == Summary == CI Bug Log - changes from CI_DRM_13142 -> Patchwork_103480v3 Summary ---

Re: [Intel-gfx] [PATCH 07/11] drm/omapdrm: Use regular fbdev I/O helpers

2023-05-12 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on 451e49cfbaa90720149e63f4fa9c7824013c783d] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-armada-Use-regular-fbdev-I-O-helpers/20230512-164432 base

Re: [Intel-gfx] [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-05-12 Thread Lucas De Marchi
On Fri, May 12, 2023 at 02:14:19PM +0300, Andy Shevchenko wrote: On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to create masks for fixed-width types and also the corresponding BIT_U32(), BIT_U16() and BIT_U8(). Why?

Re: [Intel-gfx] [PATCH 6/6] drm/i915/pmu: Export counters from all tiles

2023-05-12 Thread Dixit, Ashutosh
On Fri, 12 May 2023 03:57:35 -0700, Tvrtko Ursulin wrote: > > > On 11/05/2023 19:57, Dixit, Ashutosh wrote: > > On Fri, 05 May 2023 17:58:16 -0700, Umesh Nerlige Ramappa wrote: > >> > > > > One drive-by comment: > > > >> diff --git a/drivers/gpu/drm/i915/i915_pmu.c > >> b/drivers/gpu/drm/i915/i915

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling (rev2)

2023-05-12 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Fix expected reg value for Thunderbolt PLL disabling (rev2) URL : https://patchwork.freedesktop.org/series/117690/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13142 -> Patchwork_117690v2

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/bios: add helper for reading SPI (rev3)

2023-05-12 Thread Patchwork
== Series Details == Series: drm/i915/bios: add helper for reading SPI (rev3) URL : https://patchwork.freedesktop.org/series/103480/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13142_full -> Patchwork_103480v3_full Summar

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i1915/guc: Fix probe injection CI failures after recent change

2023-05-12 Thread John Harrison
On 5/10/2023 21:39, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* drm/i1915/guc: Fix probe injection CI failures after recent change *URL:* https://patchwork.freedesktop.org/series/117600/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patch

[Intel-gfx] [PATCH v2] drm/i915/display: add i915 parameter to I915_STATE_WARN()

2023-05-12 Thread Jani Nikula
Add i915 parameter to I915_STATE_WARN() and use device based logging. Done using cocci + hand edited where there was no i915 local variable ready. v2: avoid null deref in verify_connector_state() Reviewed-by: Rodrigo Vivi Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/g4x_dp.c

Re: [Intel-gfx] [PATCH 4/4] drm/i915/display: add i915 parameter to I915_STATE_WARN()

2023-05-12 Thread Jani Nikula
On Fri, 12 May 2023, Rodrigo Vivi wrote: > On Fri, May 12, 2023 at 02:04:44PM +0300, Jani Nikula wrote: >> Add i915 parameter to I915_STATE_WARN() and use device based logging. >> >> Done using cocci + hand edited where there was no i915 local variable >> ready. >> >> Signed-off-by: Jani Nikula

Re: [Intel-gfx] [PATCH 3/3] drm/i915/irq: split out display irq handling

2023-05-12 Thread Jani Nikula
On Fri, 12 May 2023, Gustavo Sousa wrote: > Quoting Jani Nikula (2023-05-12 07:23:10) >>Split (non-hotplug) display irq handling out of i915_irq.[ch] into >>display/intel_display_irq.[ch]. >> >>v2: >>- Rebase >>- Preserve [I915_MAX_PIPES] in functions (kernel test robot) >> >>Signed-off-by: Jani N

Re: [Intel-gfx] [PATCH 6/6] drm/i915/pmu: Export counters from all tiles

2023-05-12 Thread Umesh Nerlige Ramappa
On Fri, May 12, 2023 at 10:08:58AM -0700, Dixit, Ashutosh wrote: On Fri, 12 May 2023 03:57:35 -0700, Tvrtko Ursulin wrote: On 11/05/2023 19:57, Dixit, Ashutosh wrote: > On Fri, 05 May 2023 17:58:16 -0700, Umesh Nerlige Ramappa wrote: >> > > One drive-by comment: > >> diff --git a/drivers/gpu/d

Re: [Intel-gfx] [PATCH v7 4/4] drm/i915: Allow user to set cache at BO creation

2023-05-12 Thread Jordan Justen
On 2023-05-10 15:14:16, Andi Shyti wrote: > Hi, > > On Tue, May 09, 2023 at 09:59:42AM -0700, fei.y...@intel.com wrote: > > From: Fei Yang > > > > To comply with the design that buffer objects shall have immutable > > cache setting through out their life cycle, {set, get}_caching ioctl's > > are

[Intel-gfx] [PATCH v5 13/14] drm/i915/tc: Call TypeC port flush_work/cleanup without modeset locks held

2023-05-12 Thread Imre Deak
Call the TypeC port flush_work and cleanup handlers without the modeset locks held. These don't require the locks, as the work takes - as it should be able to at any point in time - any locks it needs and by the time cleanup is called and after cleanup returns the encoder is not in use. This is re

[Intel-gfx] [PATCH v5 14/14] drm/i915/tc: Reset TypeC PHYs left enabled in DP-alt mode after the sink disconnects

2023-05-12 Thread Imre Deak
If the output on a DP-alt link with its sink disconnected is kept enabled for too long (about 20 sec), then some IOM/TCSS firmware timeout will cause havoc on the PCI bus, at least for other GFX devices on it which will stop powering up. Since user space is not guaranteed to do a disabling modeset

Re: [Intel-gfx] [PATCH 6/6] drm/i915/pmu: Export counters from all tiles

2023-05-12 Thread Dixit, Ashutosh
On Fri, 12 May 2023 11:53:32 -0700, Umesh Nerlige Ramappa wrote: > > On Fri, May 12, 2023 at 10:08:58AM -0700, Dixit, Ashutosh wrote: > > On Fri, 12 May 2023 03:57:35 -0700, Tvrtko Ursulin wrote: > >> > >> > >> On 11/05/2023 19:57, Dixit, Ashutosh wrote: > >> > On Fri, 05 May 2023 17:58:16 -0700, U

[Intel-gfx] [PATCH v2] drm/i915/hwmon: Silence UBSAN uninitialized bool variable warning

2023-05-12 Thread Ashutosh Dixit
Loading i915 on UBSAN enabled kernels (CONFIG_UBSAN/CONFIG_UBSAN_BOOL) causes the following warning: UBSAN: invalid-load in drivers/gpu/drm/i915/gt/uc/intel_uc.c:558:2 load of value 255 is not a valid value for type '_Bool' Call Trace: dump_stack_lvl+0x57/0x7d ubsan_epilogue+0x5/0x40

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Silence UBSAN uninitialized bool variable warning

2023-05-12 Thread Dixit, Ashutosh
On Fri, 12 May 2023 02:33:33 -0700, Andi Shyti wrote: > Hi Andi, > > On Thu, May 11, 2023 at 10:43:30AM -0700, Dixit, Ashutosh wrote: > > On Wed, 10 May 2023 11:36:06 -0700, Ashutosh Dixit wrote: > > > > > > Loading i915 on UBSAN enabled kernels (CONFIG_UBSAN/CONFIG_UBSAN_BOOL) > > > causes the fol

Re: [Intel-gfx] [PATCH v3 7/8] drm/i915/mtl: Add support for PM DEMAND

2023-05-12 Thread Gustavo Sousa
Quoting Govindapillai, Vinod (2023-05-11 20:24:55) >Hello > >Thanks for the comments. Pls see some inline replies.. > >On Thu, 2023-04-27 at 17:24 -0300, Gustavo Sousa wrote: >> Quoting Vinod Govindapillai (2023-04-27 12:00:15) >> > From: Mika Kahola >> > >> > Display14 introduces a new way to in

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/dpll: drop a useless I915_STATE_WARN_ON() (rev2)

2023-05-12 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/dpll: drop a useless I915_STATE_WARN_ON() (rev2) URL : https://patchwork.freedesktop.org/series/117685/ State : warning == Summary == Error: dim checkpatch failed c7e4ac68951f drm/i915/dpll: drop a useless I915_STATE_WARN_ON() 8

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/dpll: drop a useless I915_STATE_WARN_ON() (rev2)

2023-05-12 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/dpll: drop a useless I915_STATE_WARN_ON() (rev2) URL : https://patchwork.freedesktop.org/series/117685/ State : success == Summary == CI Bug Log - changes from CI_DRM_13143 -> Patchwork_117685v2 =

Re: [Intel-gfx] [PATCH 5/6] drm/i915/pmu: Prepare for multi-tile non-engine counters

2023-05-12 Thread Umesh Nerlige Ramappa
On Fri, May 12, 2023 at 11:56:18AM +0100, Tvrtko Ursulin wrote: On 12/05/2023 02:08, Dixit, Ashutosh wrote: On Fri, 05 May 2023 17:58:15 -0700, Umesh Nerlige Ramappa wrote: From: Tvrtko Ursulin Reserve some bits in the counter config namespace which will carry the tile id and prepare the co

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tc: Add a workaround for an IOM/TCSS firmware hang issue (rev13)

2023-05-12 Thread Patchwork
== Series Details == Series: drm/i915/tc: Add a workaround for an IOM/TCSS firmware hang issue (rev13) URL : https://patchwork.freedesktop.org/series/117004/ State : warning == Summary == Error: dim checkpatch failed 60bf22a36d66 drm/i915: Fix PIPEDMC disabling for a bigjoiner configuration 2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/tc: Add a workaround for an IOM/TCSS firmware hang issue (rev13)

2023-05-12 Thread Patchwork
== Series Details == Series: drm/i915/tc: Add a workaround for an IOM/TCSS firmware hang issue (rev13) URL : https://patchwork.freedesktop.org/series/117004/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

  1   2   >