Re: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout for Type-C

2023-04-17 Thread Murthy, Arun R
> -Original Message- > From: Kandpal, Suraj > Sent: Monday, April 17, 2023 12:21 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org > Cc: Sharma, Swati2 > Subject: RE: [PATCH v2] drm/i915/display: Increase AUX timeout for Type-C > > : RE: [PATCH v2] drm/i915/display: Increase

Re: [Intel-gfx] [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-17 Thread Thomas Hellström
Hi On 4/14/23 12:11, Christian König wrote: Am 13.04.23 um 15:13 schrieb Daniel Vetter: On Thu, 13 Apr 2023 at 11:46, Christian König wrote: Am 13.04.23 um 10:48 schrieb Daniel Vetter: On Wed, 12 Apr 2023 at 16:18, Christian König wrote: Am 12.04.23 um 11:08 schrieb Daniel Vetter: On Tue,

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout for Type-C

2023-04-17 Thread Jani Nikula
On Wed, 05 Apr 2023, Suraj Kandpal wrote: > Type-C PHYs are taking longer than expected for Aux IO Power Enabling. > Workaround: Increase the timeout. > > WA_14017248603: adlp > Bspec: 55480 > > ---v2 > -change style on how we mention WA [Ankit] > -fix bat error > > Signed-off-by: Suraj Kandpal >

[Intel-gfx] [PATCH] drm/i915/pps: use intel_de_rmw() for panel unlock

2023-04-17 Thread Jani Nikula
Use rmw where needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_pps.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c index 7f9926672a6a..4f0b0cca03cc 100644

Re: [Intel-gfx] [PATCH] drm/i915/pps: use intel_de_rmw() for panel unlock

2023-04-17 Thread Andi Shyti
Hi Jani, On Mon, Apr 17, 2023 at 11:57:42AM +0300, Jani Nikula wrote: > Use rmw where needed. > > Signed-off-by: Jani Nikula Reviewed-by: Andi Shyti Andi

Re: [Intel-gfx] [PATCH v2 00/10] drm/i915/display: split out high level display entry points

2023-04-17 Thread Jani Nikula
On Fri, 14 Apr 2023, Jani Nikula wrote: > v2 of https://patchwork.freedesktop.org/series/116431/ with the minor > review comments addressed. Thanks for the reviews, pushed to drm-intel-next. BR, Jani. > > BR, > Jani. > > Jani Nikula (10): > drm/i915/display: remove intel_display_commit_duplic

[Intel-gfx] [PATCH] drm/i915/display/dp: 128/132b LT requirement

2023-04-17 Thread Arun R Murthy
For 128b/132b LT prior to LT DPTX should set power state, DP channel coding and then link rate. Signed-off-by: Arun R Murthy --- .../drm/i915/display/intel_dp_link_training.c | 52 +-- 1 file changed, 35 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/i915/display/in

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout for Type-C

2023-04-17 Thread Kandpal, Suraj
> On Wed, 05 Apr 2023, Suraj Kandpal wrote: > > Type-C PHYs are taking longer than expected for Aux IO Power Enabling. > > Workaround: Increase the timeout. > > > > WA_14017248603: adlp > > Bspec: 55480 > > > > ---v2 > > -change style on how we mention WA [Ankit] -fix bat error > > > > Signed-off-

Re: [Intel-gfx] [PATCH] drm/i915/display/dp: 128/132b LT requirement

2023-04-17 Thread Jani Nikula
On Mon, 17 Apr 2023, Arun R Murthy wrote: > For 128b/132b LT prior to LT DPTX should set power state, DP channel > coding and then link rate. > > Signed-off-by: Arun R Murthy > --- > .../drm/i915/display/intel_dp_link_training.c | 52 +-- > 1 file changed, 35 insertions(+), 17 de

Re: [Intel-gfx] [PATCH] drm/i915/display/dp: 128/132b LT requirement

2023-04-17 Thread Jani Nikula
On Mon, 17 Apr 2023, Jani Nikula wrote: > On Mon, 17 Apr 2023, Arun R Murthy wrote: >> For 128b/132b LT prior to LT DPTX should set power state, DP channel >> coding and then link rate. >> >> Signed-off-by: Arun R Murthy >> --- >> .../drm/i915/display/intel_dp_link_training.c | 52 +

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout for Type-C

2023-04-17 Thread Jani Nikula
On Mon, 17 Apr 2023, "Kandpal, Suraj" wrote: >> On Wed, 05 Apr 2023, Suraj Kandpal wrote: >> > Type-C PHYs are taking longer than expected for Aux IO Power Enabling. >> > Workaround: Increase the timeout. >> > >> > WA_14017248603: adlp >> > Bspec: 55480 >> > >> > ---v2 >> > -change style on how w

[Intel-gfx] [PATCH v2 0/3] drm/i915: Replace kmap() with kmap_local_page()

2023-04-17 Thread Fabio M. De Francesco
kmap() has been deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it migh

[Intel-gfx] [PATCH v2 1/3] drm/i915: Replace kmap() with kmap_local_page()

2023-04-17 Thread Fabio M. De Francesco
kmap() has been deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it migh

[Intel-gfx] [PATCH v2 3/3] drm/i915/gem: Replace kmap() with kmap_local_page()

2023-04-17 Thread Fabio M. De Francesco
kmap() s been deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it might

[Intel-gfx] [PATCH v2 2/3] drm/i915/gt: Replace kmap() with kmap_local_page()

2023-04-17 Thread Fabio M. De Francesco
kmap() s been deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it might

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout for Type-C

2023-04-17 Thread Kandpal, Suraj
> -Original Message- > From: Jani Nikula > Sent: Monday, April 17, 2023 4:04 PM > To: Kandpal, Suraj ; intel- > g...@lists.freedesktop.org > Subject: RE: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout > for Type-C > > On Mon, 17 Apr 2023, "Kandpal, Suraj" wrote: > >> On

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout for Type-C

2023-04-17 Thread Jani Nikula
On Mon, 17 Apr 2023, "Kandpal, Suraj" wrote: >> -Original Message- >> From: Jani Nikula >> Sent: Monday, April 17, 2023 4:04 PM >> To: Kandpal, Suraj ; intel- >> g...@lists.freedesktop.org >> Subject: RE: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout >> for Type-C >> >> O

[Intel-gfx] [PATCHv2] drm/i915/display/dp: 128/132b LT requirement

2023-04-17 Thread Arun R Murthy
For 128b/132b LT prior to LT DPTX should set power state, DP channel coding and then link rate. v2: added separate function to avoid code duplication(Jani N) Signed-off-by: Arun R Murthy --- .../drm/i915/display/intel_dp_link_training.c | 62 +-- 1 file changed, 44 insertions(+)

[Intel-gfx] [PATCH i-g-t v5 0/8] Vendor agnostic gputop

2023-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This is a pile of patches which implements a rudimentary vendor agnostic gputop tool based of the new DRM spec as documented in Documentation/gpu/drm-usage-stats.rst. First part of the series is code refactoring which should be reasonably stable. I've tested it all while wor

[Intel-gfx] [PATCH i-g-t 1/8] lib: Extract igt_drm_clients from intel_gpu_top

2023-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Extract some code into a new library to prepare for further work towards making a vendor agnostic gputop tool. Signed-off-by: Tvrtko Ursulin --- lib/igt_drm_clients.c | 471 +++ lib/igt_drm_clients.h | 89 +++ lib/meson.build |

[Intel-gfx] [PATCH i-g-t 3/8] lib/igt_drm_clients: Record client drm minor

2023-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Prepare for supporting clients belonging to multiple DRM cards by storing the DRM minor in the client record. Signed-off-by: Tvrtko Ursulin --- lib/igt_drm_clients.c | 22 ++ lib/igt_drm_clients.h | 1 + 2 files changed, 15 insertions(+), 8 deletions(-

[Intel-gfx] [PATCH i-g-t 2/8] lib: Allow specifying custom engine map

2023-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Instead of hard coding the engine names, allow a map of names to indices to either be passed in or it gets auto-detected (less efficient) while parsing. --- lib/igt_drm_clients.c | 18 --- lib/igt_drm_clients.h | 3 ++- lib/igt_drm_fdinfo.c| 51 +

[Intel-gfx] [PATCH i-g-t 4/8] lib/igt_drm_clients: Support multiple DRM cards

2023-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Require DRM minor match during client lookup. Signed-off-by: Tvrtko Ursulin --- lib/igt_drm_clients.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/igt_drm_clients.c b/lib/igt_drm_clients.c index b837450301dc..06b66fe95b62 100644 --

[Intel-gfx] [PATCH i-g-t 7/8] lib/igt_drm_clients: Enforce client status sort order in the library

2023-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Some libdrmclient operations require that inactive clients are last in the list. Rather than relying on callers of the library sort routine to implement their comparison callbacks correctly, enforce this order directly in the library and let callers comparison callbacks conce

[Intel-gfx] [PATCH i-g-t 6/8] lib/igt_drm_clients: Decouple hardcoded engine assumptions

2023-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Intel_gpu_top gets it's main engine configuration data via PMU probe and uses that for per client view as well. Furthemore code so far assumed only clients belonging from a single DRM card would be tracked in a single clients list. Break this inter-dependency by moving the e

[Intel-gfx] [PATCH i-g-t 8/8] gputop: Basic vendor agnostic GPU top tool

2023-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Rudimentary vendor agnostic example of how lib_igt_drm_clients can be used to display a sorted by card and usage list of processes using GPUs. Borrows a bit of code from intel_gpu_top but for now omits the fancy features like interactive functionality, card selection, client

[Intel-gfx] [PATCH i-g-t 5/8] lib/igt_drm_fdinfo: Track largest engine index

2023-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Prep code for incoming work. Signed-off-by: Tvrtko Ursulin --- lib/igt_drm_fdinfo.c | 2 ++ lib/igt_drm_fdinfo.h | 1 + 2 files changed, 3 insertions(+) diff --git a/lib/igt_drm_fdinfo.c b/lib/igt_drm_fdinfo.c index 3f4f0e88b0d8..b5f8a8679a71 100644 --- a/lib/igt_drm_fdin

Re: [Intel-gfx] [PATCH i-g-t 3/3] intel_gpu_top: Show non-normalized client usage in numeric mode

2023-04-17 Thread Tvrtko Ursulin
Hi Kamil, On 14/04/2023 16:28, Kamil Konieczny wrote: On 2023-03-28 at 13:54:29 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When numeric display is selected in the interactive mode it is more descriptive to show client's non-normalized (by number of engines per class) usage. Rendering

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout for Type-C

2023-04-17 Thread Kandpal, Suraj
drm/i915/display: Increase AUX timeout > for Type-C > > On Mon, 17 Apr 2023, "Kandpal, Suraj" wrote: > >> -Original Message- > >> From: Jani Nikula > >> Sent: Monday, April 17, 2023 4:04 PM > >> To: Kandpal, Suraj ; intel- > >> g...@lists.freedesktop.org > >> Subject: RE: [Intel-gfx] [

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout for Type-C

2023-04-17 Thread Jani Nikula
On Mon, 17 Apr 2023, "Kandpal, Suraj" wrote: > drm/i915/display: Increase AUX timeout >> for Type-C >> >> On Mon, 17 Apr 2023, "Kandpal, Suraj" wrote: >> >> -Original Message- >> >> From: Jani Nikula >> >> Sent: Monday, April 17, 2023 4:04 PM >> >> To: Kandpal, Suraj ; intel- >> >> g...

Re: [Intel-gfx] [PATCH v2 9/9] drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c

2023-04-17 Thread Tvrtko Ursulin
On 14/04/2023 11:45, Zhao Liu wrote: Hi Tvrtko, On Wed, Apr 12, 2023 at 04:45:13PM +0100, Tvrtko Ursulin wrote: [snip] [snip] However I am unsure if disabling pagefaulting is needed or not. Thomas, Matt, being the last to touch this area, perhaps you could have a look? Because I notice we

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout for Type-C

2023-04-17 Thread Imre Deak
On Mon, Apr 17, 2023 at 01:56:12PM +0300, Jani Nikula wrote: > On Mon, 17 Apr 2023, "Kandpal, Suraj" wrote: > >> -Original Message- > >> From: Jani Nikula > >> Sent: Monday, April 17, 2023 4:04 PM > >> To: Kandpal, Suraj ; intel- > >> g...@lists.freedesktop.org > >> Subject: RE: [Intel-gf

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-17 Thread Mark Brown
On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > Note there was a ppc compile fail, which is why we pushed the ttm revert. > That /should/ be fixed now, but would be good if you can confirm? I don't have any PowerPC toolchains set up - I guess one of the community builders might h

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout for Type-C

2023-04-17 Thread Kandpal, Suraj
> > On Mon, Apr 17, 2023 at 01:56:12PM +0300, Jani Nikula wrote: > > On Mon, 17 Apr 2023, "Kandpal, Suraj" wrote: > > >> -Original Message- > > >> From: Jani Nikula > > >> Sent: Monday, April 17, 2023 4:04 PM > > >> To: Kandpal, Suraj ; intel- > > >> g...@lists.freedesktop.org > > >> Sub

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout for Type-C

2023-04-17 Thread Kandpal, Suraj
> -Original Message- > From: Deak, Imre > Sent: Monday, April 17, 2023 4:58 PM > To: Jani Nikula > Cc: Kandpal, Suraj ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout > for Type-C > > On Mon, Apr 17, 2023 at 01:56:12PM

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout for Type-C

2023-04-17 Thread Imre Deak
On Mon, Apr 17, 2023 at 02:43:25PM +0300, Kandpal, Suraj wrote: > > [...] > > Adding a non-default enable_timeout to the power well descriptor would > > avoid adding more platform checks: > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display_power_map.c > > b/drivers/gpu/drm/i915/display/

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Define MOCS and PAT tables for MTL (rev5)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Define MOCS and PAT tables for MTL (rev5) URL : https://patchwork.freedesktop.org/series/115980/ State : warning == Summary == Error: dim checkpatch failed 04d4f946f5f0 drm/i915/mtl: Set has_llc=0 f44a8a034a83 drm/i915/mtl: Define MOCS and PAT tables

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: Define MOCS and PAT tables for MTL (rev5)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Define MOCS and PAT tables for MTL (rev5) URL : https://patchwork.freedesktop.org/series/115980/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/mtl: Define MOCS and PAT tables for MTL (rev5)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Define MOCS and PAT tables for MTL (rev5) URL : https://patchwork.freedesktop.org/series/115980/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13020 -> Patchwork_115980v5 Summary -

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout for Type-C

2023-04-17 Thread Kandpal, Suraj
> > On Mon, Apr 17, 2023 at 02:43:25PM +0300, Kandpal, Suraj wrote: > > > [...] > > > Adding a non-default enable_timeout to the power well descriptor > > > would avoid adding more platform checks: > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display_power_map.c > > > b/drivers/gpu/

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Increase AUX timeout for Type-C

2023-04-17 Thread Imre Deak
On Mon, Apr 17, 2023 at 03:25:34PM +0300, Kandpal, Suraj wrote: > > > > On Mon, Apr 17, 2023 at 02:43:25PM +0300, Kandpal, Suraj wrote: > > > > [...] > > > > Adding a non-default enable_timeout to the power well descriptor > > > > would avoid adding more platform checks: > > > > > > > > diff --git

Re: [Intel-gfx] 2023 X.Org Foundation Membership deadline for voting in the election

2023-04-17 Thread Laurent Pinchart
Hi Ricardo, On Mon, Mar 13, 2023 at 04:22:54PM +0100, Ricardo Garcia wrote: > This is a reminder that the deadline for new memberships and renewals > finishes in a couple of weeks. Original email follows. > > Thanks for your attention. I don't know if I'm the only one affected by this issue, but

[Intel-gfx] [PATCH v2 0/4] drm/i915: Check HPD during eDP probe

2023-04-17 Thread Ville Syrjala
From: Ville Syrjälä Remainder of the eDP HPD check series, now rebased on top of MTL HPD stuff. Ville Syrjälä (4): drm/i915: Introduce _hotplug_mask() drm/i915: Introduce intel_hpd_enable_detection() drm/i915: Check HPD live state during eDP probe drm/i915: Reuse _hotplug_mask() in .hpd_

[Intel-gfx] [PATCH v2 1/4] drm/i915: Introduce _hotplug_mask()

2023-04-17 Thread Ville Syrjala
From: Ville Syrjälä Pair each _hotplug_enables() function with a corresponding _hotplug_mask() function so that we can determine right bits to clear on a per hpd_pin basis. We'll need this for turning on HPD sense for a specific encoder rather than just all of them. v2: Drop the unused 'i915' pa

[Intel-gfx] [PATCH v2 2/4] drm/i915: Introduce intel_hpd_enable_detection()

2023-04-17 Thread Ville Syrjala
From: Ville Syrjälä Add a mechanism by which we can enable the HPD sense for individual encoders. This will be used during eDP probing to figure out if anything is actually connected. The normal intel_hpd_irq_setup() thing doesn't work since we only do that after probing the outputs, and we only

[Intel-gfx] [PATCH v2 3/4] drm/i915: Check HPD live state during eDP probe

2023-04-17 Thread Ville Syrjala
From: Ville Syrjälä We need to untangle the mess where some SKL machines (at least) declare both DDI A and DDI E to be present in their VBT, and both using AUX A. DDI A is a ghost eDP, wheres DDI E may be a real DP->VGA converter. Currently that is handled by checking the VBT child devices for c

[Intel-gfx] [PATCH v2 4/4] drm/i915: Reuse _hotplug_mask() in .hpd_detection_setup()

2023-04-17 Thread Ville Syrjala
From: Ville Syrjälä Replace the hardcoded masks with just a loop over all hpd pins using the _hotplug_mask() functions. v2: Deal with mtp Reviewed-by: Vinod Govindapillai a #v1 Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_irq.c | 65 - 1 file chan

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Make IRQ reset and postinstall multi-gt aware (rev4)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915: Make IRQ reset and postinstall multi-gt aware (rev4) URL : https://patchwork.freedesktop.org/series/115465/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13020 -> Patchwork_115465v4 Su

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-17 Thread Jason Gunthorpe
On Fri, Apr 14, 2023 at 09:11:30AM +, Tian, Kevin wrote: > The only corner case with this option is when a user mixes group > and cdev usages. iirc you mentioned it's a valid usage to be supported. > In that case the kernel doesn't have sufficient knowledge to judge > 'resettable' as it doesn'

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pps: use intel_de_rmw() for panel unlock

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915/pps: use intel_de_rmw() for panel unlock URL : https://patchwork.freedesktop.org/series/116560/ State : success == Summary == CI Bug Log - changes from CI_DRM_13020 -> Patchwork_116560v1 Summary ---

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-17 Thread Jason Gunthorpe
On Thu, Apr 13, 2023 at 12:07:12PM -0600, Alex Williamson wrote: > IIUC, the semantics we're proposing is that an INFO2 ioctl would return > success or failure indicating whether the user has sufficient ownership > of the affected devices, Or a flag, but yes > and in the success case returns an

Re: [Intel-gfx] [PATCH v9 10/10] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2023-04-17 Thread kernel test robot
onfig-r015-20230417 (https://download.01.org/0day-ci/archive/20230417/202304172130.pxi8pggx-...@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Replace kmap() with kmap_local_page() (rev3)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915: Replace kmap() with kmap_local_page() (rev3) URL : https://patchwork.freedesktop.org/series/107277/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915/pps: use intel_de_rmw() for panel unlock

2023-04-17 Thread Andrzej Hajda
On 17.04.2023 10:57, Jani Nikula wrote: Use rmw where needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_pps.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pp

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Replace kmap() with kmap_local_page() (rev3)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915: Replace kmap() with kmap_local_page() (rev3) URL : https://patchwork.freedesktop.org/series/107277/ State : success == Summary == CI Bug Log - changes from CI_DRM_13020 -> Patchwork_107277v3 Summary --

Re: [Intel-gfx] [PATCH v2 9/9] drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c

2023-04-17 Thread Rodrigo Vivi
On Mon, Apr 17, 2023 at 12:24:45PM +0100, Tvrtko Ursulin wrote: > > On 14/04/2023 11:45, Zhao Liu wrote: > > Hi Tvrtko, > > > > On Wed, Apr 12, 2023 at 04:45:13PM +0100, Tvrtko Ursulin wrote: > > > > [snip] > > > > > > > > > > [snip] > > > > > However I am unsure if disabling pagefaulting is n

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/dp: 128/132b LT requirement (rev2)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915/display/dp: 128/132b LT requirement (rev2) URL : https://patchwork.freedesktop.org/series/116562/ State : success == Summary == CI Bug Log - changes from CI_DRM_13020 -> Patchwork_116562v2 Summary -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Increase AUX timeout for Type-C (rev3)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915/display: Increase AUX timeout for Type-C (rev3) URL : https://patchwork.freedesktop.org/series/116010/ State : warning == Summary == Error: dim checkpatch failed d7a532aae02a drm/i915/display: Increase AUX timeout for Type-C -:13: WARNING:COMMIT_LOG_LONG_L

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Increase AUX timeout for Type-C (rev3)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915/display: Increase AUX timeout for Type-C (rev3) URL : https://patchwork.freedesktop.org/series/116010/ State : success == Summary == CI Bug Log - changes from CI_DRM_13020 -> Patchwork_116010v3 Summary

[Intel-gfx] [PATCH 1/2] drm/i915/display: split out load detect to a separate file

2023-04-17 Thread Jani Nikula
Load detect is shared between tv and crt but otherwise isolated in intel_display.c. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_crt.c | 5 +- drivers/gpu/drm/i915/display/intel_display.c | 215

[Intel-gfx] [PATCH 2/2] drm/i915/display: throw out struct intel_load_detect_pipe

2023-04-17 Thread Jani Nikula
An error-valued pointer can handle all in one without the wrapper struct. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_crt.c | 18 - .../gpu/drm/i915/display/intel_load_detect.c | 20 --- .../gpu/drm/i915/display/intel_load_detect.h | 1

[Intel-gfx] [RFC 0/6] fdinfo alternative memory stats proposal

2023-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As discussed in the Rob's thread here is a slightly alternative idea on what to expose and how. DRM core is still defining a list of common memory categories but it is now up to drivers to fill in the data and opt into the feature. There is also no aggregated category and m

[Intel-gfx] [RFC 2/6] drm/i915: Use the fdinfo helper

2023-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the common fdinfo helper for printing the basics. Remove now unused client id allocation code. Signed-off-by: Tvrtko Ursulin Cc: Rob Clark --- drivers/gpu/drm/i915/i915_driver.c | 6 +-- drivers/gpu/drm/i915/i915_drm_client.c | 65 -- driv

[Intel-gfx] [RFC 5/6] drm/msm: Add basic memory stats

2023-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use DRM helpers for implementing basic memory stats. Signed-off-by: Tvrtko Ursulin Cc: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 060c7689a739..766

[Intel-gfx] [RFC 1/6] drm: Add common fdinfo helper

2023-04-17 Thread Tvrtko Ursulin
From: Rob Clark Handle a bit of the boiler-plate in a single case, and make it easier to add some core tracked stats. v2: Update drm-usage-stats.rst, 64b client-id, rename drm_show_fdinfo Reviewed-by: Daniel Vetter Signed-off-by: Rob Clark --- Documentation/gpu/drm-usage-stats.rst | 10 +

[Intel-gfx] [RFC 4/6] drm: Add simple fdinfo memory helpers

2023-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin For drivers who only wish to show one memory region called 'system, and only account the GEM buffer object handles under it. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/drm_file.c | 45 ++ include/drm/drm_file.h | 6 + 2 f

[Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add support to dump GEM stats to fdinfo. Signed-off-by: Tvrtko Ursulin --- Documentation/gpu/drm-usage-stats.rst | 12 +++ drivers/gpu/drm/drm_file.c| 52 +++ include/drm/drm_drv.h | 7 include/drm/drm_file.h

[Intel-gfx] [RFC 6/6] drm/i915: Implement fdinfo memory stats printing

2023-04-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Show how more driver specific set of memory stats could be shown, more specifically where object can reside in multiple regions, showing all the supported stats, and where there is more to show than just user visible objects. WIP... Signed-off-by: Tvrtko Ursulin --- drive

[Intel-gfx] [PATCH v3] drm/i915: Initialize dkl_phy spin lock from display code path

2023-04-17 Thread José Roberto de Souza
Start to move the initialization of display locks from i915_driver_early_probe(), this way it is also executed when running Xe kmd. This will fix a warning in Xe kmd: [ 201.894839] xe :00:02.0: [drm] [ENCODER:235:DDI A/PHY A] failed to retrieve link info, disabling eDP [ 202.136336] xe 000

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-17 Thread Christian König
Am 17.04.23 um 17:56 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Add support to dump GEM stats to fdinfo. Signed-off-by: Tvrtko Ursulin --- Documentation/gpu/drm-usage-stats.rst | 12 +++ drivers/gpu/drm/drm_file.c| 52 +++ include/drm/drm_drv.h

Re: [Intel-gfx] [Nouveau] XDC 2023: Registration & Call for Proposals now open!

2023-04-17 Thread Luna Jernberg
Signed up will only attend virtually Online however just fyi On Mon, Apr 17, 2023 at 1:41 PM Samuel Iglesias Gonsálvez wrote: > > Hello! > > Registration & Call for Proposals are now open for XDC 2023, which will > take place on October 17-19, 2023. > > https://xdc2023.x.org > > As usual, the con

[Intel-gfx] Invitation: XDC 2023 A Corunha Spain @ Tue Oct 17 - Thu Oct 19, 2023 (intel-gfx@lists.freedesktop.org)

2023-04-17 Thread mario . kleiner . de
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VEVENT DTSTART;VALUE=DATE:20231017 DTEND;VALUE=DATE:20231020 DTSTAMP:20230417T170311Z ORGANIZER;CN=mario.kleiner...@gmail.com:mailto:mario.kleiner...@gmail.com UID:65qeuuc9e0gll25tq

[Intel-gfx] Canceled event: XDC 2023 A Corunha Spain @ Tue Oct 17 - Thu Oct 19, 2023 (intel-gfx@lists.freedesktop.org)

2023-04-17 Thread mario . kleiner . de
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:CANCEL BEGIN:VEVENT DTSTART;VALUE=DATE:20231017 DTEND;VALUE=DATE:20231020 DTSTAMP:20230417T170848Z ORGANIZER;CN=mario.kleiner...@gmail.com:mailto:mario.kleiner...@gmail.com UID:65qeuuc9e0gll25tq5

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check HPD during eDP probe (rev6)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915: Check HPD during eDP probe (rev6) URL : https://patchwork.freedesktop.org/series/114577/ State : warning == Summary == Error: dim checkpatch failed 8c0b522203ba drm/i915: Introduce _hotplug_mask() 7131b5b152ca drm/i915: Introduce intel_hpd_enable_detectio

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Check HPD during eDP probe (rev6)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915: Check HPD during eDP probe (rev6) URL : https://patchwork.freedesktop.org/series/114577/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Check HPD during eDP probe (rev6)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915: Check HPD during eDP probe (rev6) URL : https://patchwork.freedesktop.org/series/114577/ State : success == Summary == CI Bug Log - changes from CI_DRM_13021 -> Patchwork_114577v6 Summary --- **

Re: [Intel-gfx] [PATCH v7 3/8] drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC

2023-04-17 Thread Teres Alexis, Alan Previn
On Mon, 2023-04-10 at 09:10 -0700, Ceraolo Spurio, Daniele wrote: > alan:snip > > +int > > +intel_gsc_uc_heci_cmd_submit_nonpriv(struct intel_gsc_uc *gsc, > > +struct intel_context *ce, > > +struct intel_gsc_heci_non_priv_pkt *pkt, >

Re: [Intel-gfx] [PATCH v7 4/8] drm/i915/pxp: Add GSC-CS backend to send GSC fw messages

2023-04-17 Thread Teres Alexis, Alan Previn
On Mon, 2023-04-10 at 09:28 -0700, Ceraolo Spurio, Daniele wrote: > alan:snip > > #define GSC_OUTFLAG_MSG_PENDING 1 > > +#define GSC_INFLAG_MSG_CLEANUP BIT(1) > > For consistency those should all be BIT() defines alan: will do. > > With the define fixed: > > Reviewed-by: Daniele Ceraolo Spuri

Re: [Intel-gfx] [PATCH] drm/i915/gt: Consider multi-gt at all places

2023-04-17 Thread Upadhyay, Tejas
> -Original Message- > From: Tvrtko Ursulin > Sent: Wednesday, April 5, 2023 2:01 PM > To: Upadhyay, Tejas ; Intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Consider multi-gt at all places > > > On 05/04/2023 07:56, Upadhyay, Tejas wrote: > >>> -int

Re: [Intel-gfx] [PATCH v7 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-04-17 Thread Teres Alexis, Alan Previn
On Mon, 2023-04-10 at 10:14 -0700, Ceraolo Spurio, Daniele wrote: > > > alan:snip > > @@ -354,8 +368,14 @@ int intel_pxp_start(struct intel_pxp *pxp) > > if (!intel_pxp_is_enabled(pxp)) > > return -ENODEV; > > > > - if (wait_for(pxp_component_bound(pxp), 250)) > > -

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-17 Thread Alex Williamson
On Mon, 17 Apr 2023 04:20:27 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Saturday, April 15, 2023 1:11 AM > > > > On Fri, 14 Apr 2023 11:38:24 + > > "Liu, Yi L" wrote: > > > > > > From: Tian, Kevin > > > > Sent: Friday, April 14, 2023 5:12 PM > > > > > > > > > From:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make IRQ reset and postinstall multi-gt aware (rev5)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915: Make IRQ reset and postinstall multi-gt aware (rev5) URL : https://patchwork.freedesktop.org/series/115465/ State : success == Summary == CI Bug Log - changes from CI_DRM_13022 -> Patchwork_115465v5 Su

Re: [Intel-gfx] [PATCH v7 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-04-17 Thread Ceraolo Spurio, Daniele
On 4/17/2023 11:21 AM, Teres Alexis, Alan Previn wrote: On Mon, 2023-04-10 at 10:14 -0700, Ceraolo Spurio, Daniele wrote: alan:snip @@ -354,8 +368,14 @@ int intel_pxp_start(struct intel_pxp *pxp) if (!intel_pxp_is_enabled(pxp)) return -ENODEV; - if (wait_for(p

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/display: split out load detect to a separate file

2023-04-17 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: split out load detect to a separate file URL : https://patchwork.freedesktop.org/series/116579/ State : warning == Summary == Error: dim checkpatch failed 5ea7255afab9 drm/i915/display: split out load detect to a separa

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/display: split out load detect to a separate file

2023-04-17 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: split out load detect to a separate file URL : https://patchwork.freedesktop.org/series/116579/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

Re: [Intel-gfx] [PATCH v7 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-04-17 Thread Teres Alexis, Alan Previn
On Mon, 2023-04-17 at 12:15 -0700, Ceraolo Spurio, Daniele wrote: > On 4/17/2023 11:21 AM, Teres Alexis, Alan Previn wrote: > > On Mon, 2023-04-10 at 10:14 -0700, Ceraolo Spurio, Daniele wrote: > > > > @@ -354,8 +368,14 @@ int intel_pxp_start(struct intel_pxp *pxp) > > > > if (!intel_pxp_is

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-17 Thread Jason Gunthorpe
On Mon, Apr 17, 2023 at 01:01:40PM -0600, Alex Williamson wrote: > Yes, it's not trivial, but Jason is now proposing that we consider > mixing groups, cdevs, and multiple iommufd_ctxs as invalid. I think > this means that regardless of which device calls INFO, there's only one > answer (assuming s

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/display: split out load detect to a separate file

2023-04-17 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: split out load detect to a separate file URL : https://patchwork.freedesktop.org/series/116579/ State : success == Summary == CI Bug Log - changes from CI_DRM_13022 -> Patchwork_116579v1

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-17 Thread Rob Clark
On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Add support to dump GEM stats to fdinfo. > > Signed-off-by: Tvrtko Ursulin > --- > Documentation/gpu/drm-usage-stats.rst | 12 +++ > drivers/gpu/drm/drm_file.c| 52 +++ > i

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for fdinfo alternative memory stats proposal

2023-04-17 Thread Patchwork
== Series Details == Series: fdinfo alternative memory stats proposal URL : https://patchwork.freedesktop.org/series/116581/ State : warning == Summary == Error: dim checkpatch failed 92bb2d834df8 drm: Add common fdinfo helper 1e36b9258ec6 drm/i915: Use the fdinfo helper 368bec1f61d6 drm: Add

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for fdinfo alternative memory stats proposal

2023-04-17 Thread Patchwork
== Series Details == Series: fdinfo alternative memory stats proposal URL : https://patchwork.freedesktop.org/series/116581/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for fdinfo alternative memory stats proposal

2023-04-17 Thread Patchwork
== Series Details == Series: fdinfo alternative memory stats proposal URL : https://patchwork.freedesktop.org/series/116581/ State : success == Summary == CI Bug Log - changes from CI_DRM_13022 -> Patchwork_116581v1 Summary --- **SUC

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-17 Thread Alex Williamson
On Mon, 17 Apr 2023 16:31:56 -0300 Jason Gunthorpe wrote: > On Mon, Apr 17, 2023 at 01:01:40PM -0600, Alex Williamson wrote: > > Yes, it's not trivial, but Jason is now proposing that we consider > > mixing groups, cdevs, and multiple iommufd_ctxs as invalid. I think > > this means that regardle

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pps: use intel_de_rmw() for panel unlock

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915/pps: use intel_de_rmw() for panel unlock URL : https://patchwork.freedesktop.org/series/116560/ State : success == Summary == CI Bug Log - changes from CI_DRM_13020_full -> Patchwork_116560v1_full Summa

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gt: Consider multi-gt at all places (rev3)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915/gt: Consider multi-gt at all places (rev3) URL : https://patchwork.freedesktop.org/series/115302/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/115302/revisions/3/mbox/ not applied Applying: drm/i915/gt: Cons

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Initialize dkl_phy spin lock from display code path (rev2)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915: Initialize dkl_phy spin lock from display code path (rev2) URL : https://patchwork.freedesktop.org/series/116325/ State : success == Summary == CI Bug Log - changes from CI_DRM_13022 -> Patchwork_116325v2 ==

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Replace kmap() with kmap_local_page() (rev3)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915: Replace kmap() with kmap_local_page() (rev3) URL : https://patchwork.freedesktop.org/series/107277/ State : success == Summary == CI Bug Log - changes from CI_DRM_13020_full -> Patchwork_107277v3_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display/dp: 128/132b LT requirement (rev2)

2023-04-17 Thread Patchwork
== Series Details == Series: drm/i915/display/dp: 128/132b LT requirement (rev2) URL : https://patchwork.freedesktop.org/series/116562/ State : success == Summary == CI Bug Log - changes from CI_DRM_13020_full -> Patchwork_116562v2_full Sum

[Intel-gfx] [PATCH v4] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-17 Thread Andi Shyti
In multi-gt systems IRQs need to be reset and enabled per GT. This might add some redundancy when handling interrupts for engines that might not exist in every tile, but helps to keep the code cleaner and more understandable. Signed-off-by: Andi Shyti Cc: Tvrtko Ursulin --- Hi, The rsults of t

Re: [Intel-gfx] [PATCH] drm/i915/display: Return correct err code for bpc < 0

2023-04-17 Thread Manasi Navare
Hi Ville, Could you suggest how to handle the intel_dp_link_compute_config() when the max_bpp is returned as 0, currently it just exits the loop and returns a -EINVAL and this triggers the DSC path. While we should be completely failing the modeset and encoder_config in this case instead of trying

  1   2   >