Re: [Intel-gfx] [PATCH][next] drm/i915/uapi: Replace fake flex-array with flexible-array member

2023-03-31 Thread Jani Nikula
On Thu, 30 Mar 2023, "Gustavo A. R. Silva" wrote: > Friendly ping: who can take this, please? 😄 It's in drm-intel-gt-next. commit 02abecdeebfcd3848b26b70778dd7f6eb0db65e1 Author: Gustavo A. R. Silva AuthorDate: Fri Mar 17 12:18:01 2023 -0600 Commit: Tvrtko Ursulin CommitDate: Tue Mar 2

Re: [Intel-gfx] [PATCH] drm/i915: disable sampler indirect state in bindless heap

2023-03-31 Thread Kalvala, Haridhar
On 3/30/2023 10:49 PM, Lionel Landwerlin wrote: On 29/03/2023 01:49, Matt Atwood wrote: On Tue, Mar 28, 2023 at 04:14:33PM +0530, Kalvala, Haridhar wrote: On 3/9/2023 8:56 PM, Lionel Landwerlin wrote: By default the indirect state sampler data (border colors) are stored in the same heap as t

Re: [Intel-gfx] [PATCH 0/4] log2: make is_power_of_2() more generic

2023-03-31 Thread David Laight
From: Andrew Morton > Sent: 30 March 2023 23:19 > > On Thu, 30 Mar 2023 21:53:03 + David Laight > wrote: > > > > But wouldn't all these issues be addressed by simply doing > > > > > > #define is_power_of_2(n) (n != 0 && ((n & (n - 1)) == 0)) > > > > > > ? > > > > > > (With suitable tweaks t

Re: [Intel-gfx] [PATCH v2 6/9] drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_context.c

2023-03-31 Thread Tvrtko Ursulin
On 31/03/2023 04:33, Ira Weiny wrote: Zhao Liu wrote: From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1], and this patch converts the call from kmap_atomic() to kmap_local_page(). The main difference between atomic and local mappings is that local m

Re: [Intel-gfx] [PATCH v3 2/6] iommufd: Create access in vfio_iommufd_emulated_bind()

2023-03-31 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Thursday, March 30, 2023 4:00 AM > > On Mon, Mar 27, 2023 at 02:33:47AM -0700, Yi Liu wrote: > > @@ -494,6 +479,30 @@ void iommufd_access_destroy(struct > iommufd_access *access) > > } > > EXPORT_SYMBOL_NS_GPL(iommufd_access_destroy, IOMMUFD); > > > > +int iommuf

Re: [Intel-gfx] [PATCH 5/9] drm/i915/pmu: Prepare for multi-tile non-engine counters

2023-03-31 Thread Tvrtko Ursulin
On 30/03/2023 23:28, Dixit, Ashutosh wrote: On Thu, 30 Mar 2023 05:39:04 -0700, Tvrtko Ursulin wrote: Hi Tvrtko, diff --git a/drivers/gpu/drm/i915/i915_pmu.h b/drivers/gpu/drm/i915/i915_pmu.h index 1b04c79907e8..a708e44a227e 100644 --- a/drivers/gpu/drm/i915/i915_pmu.h +++ b/drivers/gpu/d

Re: [Intel-gfx] [PATCH 0/4] log2: make is_power_of_2() more generic

2023-03-31 Thread Jani Nikula
On Thu, 30 Mar 2023, Andrew Morton wrote: > On Thu, 30 Mar 2023 21:53:03 + David Laight > wrote: > >> > But wouldn't all these issues be addressed by simply doing >> > >> > #define is_power_of_2(n) (n != 0 && ((n & (n - 1)) == 0)) >> > >> > ? >> > >> > (With suitable tweaks to avoid evalu

Re: [Intel-gfx] [PATCH] drm/i915: Fix context runtime accounting

2023-03-31 Thread Tvrtko Ursulin
On 31/03/2023 07:25, Matthew Auld wrote: On Mon, 20 Mar 2023 at 15:14, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When considering whether to mark one context as stopped and another as started we need to look at whether the previous and new _contexts_ are different and not just requests. O

Re: [Intel-gfx] [PATCH 04/12] drm/radeon: remove radeon_connector_edid() and stop using edid_blob_ptr

2023-03-31 Thread Jani Nikula
On Thu, 30 Mar 2023, Jani Nikula wrote: > radeon_connector_edid() copies the EDID from edid_blob_ptr as a side > effect if radeon_connector->edid isn't initialized. However, everywhere > that the returned EDID is used, the EDID should have been set > beforehands. > > Only the EDID code and sysfs s

Re: [Intel-gfx] [PATCH 6/9] drm/i915/pmu: Export counters from all tiles

2023-03-31 Thread Tvrtko Ursulin
On 30/03/2023 18:33, Umesh Nerlige Ramappa wrote: On Thu, Mar 30, 2023 at 02:01:42PM +0100, Tvrtko Ursulin wrote: On 30/03/2023 01:41, Umesh Nerlige Ramappa wrote: From: Tvrtko Ursulin Start exporting frequency and RC6 counters from all tiles. Existing counters keep their names and config

[Intel-gfx] [PATCH 1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2

2023-03-31 Thread Christian König
We want to remove per minor debugfs directories. Start by stopping drivers from adding anything inside of those in the mid layer callback. v2: drop it for the accel node as well Signed-off-by: Christian König --- drivers/accel/drm_accel.c | 3 --- drivers/gpu/drm/drm_debugfs.c | 2 +- 2 fil

[Intel-gfx] [PATCH 4/5] drm/debugfs: rework drm_debugfs_create_files implementation

2023-03-31 Thread Christian König
Use managed memory allocation for this. That allows us to not keep track of all the files any more. Signed-off-by: Christian König --- drivers/accel/drm_accel.c | 2 - drivers/gpu/drm/drm_debugfs.c | 75 +- drivers/gpu/drm/drm_drv.c | 2 - drivers/gpu

[Intel-gfx] [PATCH 2/5] drm/debugfs: rework debugfs directory creation v3

2023-03-31 Thread Christian König
Instead of the per minor directories only create a single debugfs directory for the whole device directly when the device is initialized. For DRM devices each minor gets a symlink to the per device directory for now until we can be sure that this isn't useful any more in any way. Accel devices cr

[Intel-gfx] [PATCH 5/5] drm/debugfs: remove debugfs_root pointer from minor

2023-03-31 Thread Christian König
We only keept that around for API compatibility with drivers. Clean all this up and use the per device debugfs directory. Signed-off-by: Christian König --- drivers/accel/drm_accel.c | 2 -- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c| 4 ++-- drivers/gpu/drm/amd/amdgp

[Intel-gfx] [PATCH 3/5] drm/debugfs: remove dev->debugfs_list and debugfs_mutex v2

2023-03-31 Thread Christian König
The mutex was completely pointless in the first place since any parallel adding of files to this list would result in random behavior since the list is filled and consumed multiple times. Completely drop that approach and just create the files directly but return -ENODEV while opening the file whe

[Intel-gfx] [PATCH 1/2] drm/i915/wm: split out SKL+ watermark regs to a separate file

2023-03-31 Thread Jani Nikula
Clean up i915_reg.h by splitting out SKL+ watermark regs to display/skl_watermark_regs.h. v2: Rebased Cc: Ville Syrjälä Reviewed-by: Nirmoy Das # v1 Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_display_power.c| 1 + drivers/gpu/drm/i915/display/skl_watermark.c | 1 + ...

[Intel-gfx] [PATCH 2/2] drm/i915/psr: split out PSR regs to a separate file

2023-03-31 Thread Jani Nikula
Clean up i915_reg.h by splitting out PSR regs to display/intel_psr_regs.h. Cc: Ville Syrjälä Reviewed-by: Nirmoy Das Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_display_debugfs.c | 1 + drivers/gpu/drm/i915/display/intel_psr.c | 1 + drivers/gpu/drm/i915/display/intel_p

[Intel-gfx] [PATCH] drm/i915: enable kernel-doc warnings for CONFIG_DRM_I915_WERROR=y

2023-03-31 Thread Jani Nikula
Increase awareness of kernel-doc issues by enabling doc check locally when W= is *not* specified on the make command-line, but CONFIG_DRM_I915_WERROR=y is enabled. Once the warnings have been fixed, we can pass -Werror to kernel-doc locally, and fail the build when there are kernel-doc warnings in

[Intel-gfx] [PATCH 00/13] Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes

2023-03-31 Thread Ankit Nautiyal
This series fixes issues faced when an HDMI2.1 sink that does not support DSC is connected via HDMI2.1PCON. It also includes other minor HDMI2.1 PCON fixes/refactoring. Patch 1-2 Have minor fixes/cleanups. Patch 3-6 Pull the decision making to use DFP conversion capabilities for every mode during

[Intel-gfx] [PATCH 01/13] drm/i915/display: Add new member to configure PCON color conversion

2023-03-31 Thread Ankit Nautiyal
The decision to use DFP output format conversion capabilities should be during compute_config phase. This patch adds new member to crtc_state to represent the final output_format to the sink. In case of a DFP this can be different than the output_format, as per the format conversion done via the P

[Intel-gfx] [PATCH 05/13] drm/i915/display: Use sink_format instead of ycbcr420_output flag

2023-03-31 Thread Ankit Nautiyal
Start passing the sink_format, to all functions that take a bool ycbcr420_output as parameter. This will make the functions generic, and will serve as a slight step towards 4:2:2 support later. v2: Rebased. v3: Correct the checks in places concerned with pipe output. (Ville) Other minor styling a

[Intel-gfx] [PATCH 02/13] drm/i915/display: Add new member in intel_dp to store ycbcr420 passthrough cap

2023-03-31 Thread Ankit Nautiyal
New member to store the YCBCR20 Pass through capability of the DP sink. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/inte

[Intel-gfx] [PATCH 04/13] drm/i915/dp: Configure PCON for conversion of output_format to YCbCr444

2023-03-31 Thread Ankit Nautiyal
Handle the case with DP to HDMI PCON, where sink_format is set to YCbCr444. In that case PCON is required to be configured to convert from given output_format to YCbCR444. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 16 1 file changed, 16 insertio

[Intel-gfx] [PATCH 06/13] drm/i915/dp: Add helper to get sink_format

2023-03-31 Thread Ankit Nautiyal
Common function to get the sink format for a given mode for DP. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 30 - 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i91

[Intel-gfx] [PATCH 11/13] drm/i915/dp: Fix FRL BW check for HDMI2.1 DFP

2023-03-31 Thread Ankit Nautiyal
During FRL bandwidth check for downstream HDMI2.1 sink, the min BPC supported is incorrectly taken for DP, and the check does not consider ybcr420 only modes. This patch fixes the bandwidth calculation similar to the TMDS case, by taking min 8Bpc and considering Ycbcr420 only modes. v2: Rebase S

[Intel-gfx] [PATCH 09/13] drm/i915/dp_mst: Use output_format to get the final link bpp

2023-03-31 Thread Ankit Nautiyal
The final link bpp used to calculate the m_n values depend on the output_format. Though the output_format is set to RGB for MST case and the link bpp will be same as the pipe bpp, for the sake of semantics, lets calculate the m_n values with the link bpp, instead of pipe_bpp. Signed-off-by: Ankit

[Intel-gfx] [PATCH 07/13] drm/i915/dp: Rearrange check for illegal mode and comments in mode_valid

2023-03-31 Thread Ankit Nautiyal
Check for MODE_H_ILLEGAL before calculating max rates, lanes etc. Move comments about compressed bpp U6.4 format closer to where it is used. Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 14 +++--- 1 file changed, 7 insertions(+),

[Intel-gfx] [PATCH 13/13] drm/i915/dp: Use consistent name for link bpp and compressed bpp

2023-03-31 Thread Ankit Nautiyal
Currently there are many places where we use output_bpp for link bpp and compressed bpp. Lets use consistent naming: output_bpp : The intermediate value taking into account the output_format chroma subsampling. compressed_bpp : target bpp for the DSC encoder. link_bpp : final bpp used in the link.

[Intel-gfx] [PATCH 08/13] drm/i915/dp: Consider output_format while computing dsc bpp

2023-03-31 Thread Ankit Nautiyal
While using DSC the compressed bpp is computed assuming RGB output format. Consider the output_format and compute the compressed bpp during mode valid and compute config steps. For DP-MST we currently use RGB output format only, so continue using RGB while computing compressed bpp for MST case. S

[Intel-gfx] [PATCH 10/13] drm/i915/dp: Handle BPP where HDMI2.1 DFP doesn't support DSC

2023-03-31 Thread Ankit Nautiyal
Currently we use the highest input BPC supported by DP sink while using DSC.In cases where PCON with HDMI2.1 as branch device, if PCON supports DSC but HDMI2.1 sink does not supports DSC, The PCON tries to use same input BPC that is used between Source and the PCON without DSC, which might not work

[Intel-gfx] [PATCH 03/13] drm/i915/dp: Replace intel_dp.dfp members with the new crtc_state sink_format

2023-03-31 Thread Ankit Nautiyal
The decision to use DFP output format conversion capabilities should be during compute_config phase. This patch uses the members of intel_dp->dfp to only store the format conversion capabilities of the DP device and uses the crtc_state sink_format member, to program the protocol-converter for colo

[Intel-gfx] [PATCH 12/13] drm/i915/dp: Add a wrapper to check frl/tmds downstream constraints

2023-03-31 Thread Ankit Nautiyal
Add a wrapper function to check dp_downstream clock/bandwidth constraints. Based on whether the sink supports FRL/TMDS the wrapper calls the appropriate FRL/TMDS functions. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 43 +++-- 1 file changed, 1

Re: [Intel-gfx] [PATCH] drm/i915: enable kernel-doc warnings for CONFIG_DRM_I915_WERROR=y

2023-03-31 Thread Jani Nikula
On Fri, 31 Mar 2023, Jani Nikula wrote: > Increase awareness of kernel-doc issues by enabling doc check locally > when W= is *not* specified on the make command-line, but > CONFIG_DRM_I915_WERROR=y is enabled. > > Once the warnings have been fixed, we can pass -Werror to kernel-doc > locally, and

Re: [Intel-gfx] [PATCH v2] drm/i915/hwmon: Use 0 to designate disabled PL1 power limit

2023-03-31 Thread Tvrtko Ursulin
On 31/03/2023 03:26, Ashutosh Dixit wrote: On ATSM the PL1 limit is disabled at power up. The previous uapi assumed that the PL1 limit is always enabled and therefore did not have a notion of a disabled PL1 limit. This results in erroneous PL1 limit values when the PL1 limit is disabled. For ex

[Intel-gfx] [PATCH 3/6] drm/i915: Fix comparison in intel_dram.

2023-03-31 Thread Maarten Lankhorst
Gen13 should probably be the same as gen12, not gen11. Signed-off-by: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/soc/intel_dram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/soc/intel_dram.c b/drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Define cursor chicken reg

2023-03-31 Thread Imre Deak
On Wed, Mar 29, 2023 at 10:04:45PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Define CUR_CHICKEN so we don't have to remember the offset. > Looks like it's getting introduced in mtl. > > Signed-off-by: Ville Syrjälä On the patchset: Reviewed-by: Imre Deak > --- > drivers/gpu/drm/

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Explain the magic numbers for AUX SYNC/precharge length

2023-03-31 Thread Hogander, Jouni
On Thu, 2023-03-30 at 07:22 +, Hogander, Jouni wrote: > On Wed, 2023-03-29 at 20:24 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Replace the hardcoded final numbers in the AUX SYNC/precharge > > setup, and derive those from numbers from the (e)DP specs. > > > > The new functio

Re: [Intel-gfx] [PATCH v2 9/9] drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c

2023-03-31 Thread Tvrtko Ursulin
On 31/03/2023 05:18, Ira Weiny wrote: Zhao Liu wrote: From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1], and this patch converts the calls from kmap_atomic() to kmap_local_page(). The main difference between atomic and local mappings is that local

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2

2023-03-31 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2 URL : https://patchwork.freedesktop.org/series/115920/ State : warning == Summary == Error: dim checkpatch failed 812a5adda093 drm/debugfs: drop debugfs_init() for the ren

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2

2023-03-31 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2 URL : https://patchwork.freedesktop.org/series/115920/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be c

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2

2023-03-31 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2 URL : https://patchwork.freedesktop.org/series/115920/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12950 -> Patchwork_115920v1 =

[Intel-gfx] ✓ Fi.CI.IGT: success for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3)

2023-03-31 Thread Patchwork
== Series Details == Series: PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3) URL : https://patchwork.freedesktop.org/series/115466/ State : success == Summary == CI Bug Log - changes from CI_DRM_12940_full -> Patchwork_115466v3_full

[Intel-gfx] [PATCH 15/19] drm/i915/gt/uc/intel_guc_hwconfig: Demote a few non-conforming kerneldoc headers

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:112: warning: Function parameter or member 'gt' not described in 'guc_hwconfig_init' drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:112: warning: expecting prototype for intel_guc_hwconfig_init().

[Intel-gfx] [PATCH 09/19] drm/i915/gem/i915_gem_ttm_pm: Provide a couple of missing descriptions for 'flags' and remove some superfluous ones

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:156: warning: Function parameter or member 'flags' not described in 'i915_ttm_backup_region' drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:156: warning: Excess function parameter 'allow_gpu' description in

[Intel-gfx] [PATCH 04/19] drm/i915/display/intel_display_debugfs: Fix incorrect param naming for 'intel_connector'

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/display/intel_display_debugfs.c:1668: warning: Function parameter or member 'intel_connector' not described in 'intel_connector_debugfs_add' drivers/gpu/drm/i915/display/intel_display_debugfs.c:1668: warning: Excess functio

[Intel-gfx] [PATCH 10/19] drm/i915/gem/i915_gem_ttm: Demote half-filled kerneldoc

2023-03-31 Thread Lee Jones
Hopefully someone knowledgable will follow-up to complete it. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_ttm.c:1292: warning: Function parameter or member 'offset' not described in '__i915_gem_ttm_object_init' drivers/gpu/drm/i915/gem/i915_gem_ttm.c:1292

[Intel-gfx] [PATCH 16/19] drm/i915/i915_vma: Provide one missing param and demote another non-kerneldoc header

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/i915_vma.c:756: warning: Function parameter or member 'ww' not described in 'i915_vma_insert' drivers/gpu/drm/i915/i915_vma.c:1744: warning: Function parameter or member 'vma' not described in 'i915_vma_destroy_locked' Cc:

[Intel-gfx] [PATCH 13/19] drm/i915/gem/i915_gem_object: Demote non-kerneldoc header with no param descriptions

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_object.c:887: warning: Function parameter or member 'obj' not described in 'i915_gem_object_has_unknown_state' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Dan

[Intel-gfx] [PATCH 11/19] drm/i915/gem/i915_gem_ttm_move: Provide a couple of missing descriptions for 'num_pages' and 'ctx'

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c:272: warning: Function parameter or member 'num_pages' not described in 'i915_ttm_memcpy_arg' drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c:569: warning: Function parameter or member 'ctx' not describe

[Intel-gfx] [PATCH 05/19] drm/i915/gt/intel_engine_cs: Fix a couple of incorrectly named functions

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gt/intel_engine_cs.c:1324: warning: expecting prototype for intel_engines_init_common(). Prototype was for engine_init_common() instead drivers/gpu/drm/i915/gt/intel_engine_cs.c:1406: warning: expecting prototype for intel_e

[Intel-gfx] [PATCH 08/19] drm/i915/gem/i915_gem_domain: Provide function names to complete proper kerneldoc

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_domain.c:119: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/i915/gem/i915_gem_domain.c:180: warning: This comment starts w

[Intel-gfx] [PATCH 01/19] drm/i915/i915_scatterlist: Fix kerneldoc formatting issue - missing '@'

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/i915_scatterlist.c:62: warning: Function parameter or member 'size' not described in 'i915_refct_sgt_init' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: i

[Intel-gfx] [PATCH 14/19] drm/i915/i915_gem: Provide function names to complete the expected kerneldoc format

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/i915_gem.c:447: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/i915/i915_gem.c:536: warning: This comment starts with '/**', but isn't a

[Intel-gfx] [PATCH 19/19] drm/i915/display/intel_wm: Fix a little doc-rot in intel_update_watermarks()

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/display/intel_wm.c:46: warning: Function parameter or member 'i915' not described in 'intel_update_watermarks' drivers/gpu/drm/i915/display/intel_wm.c:46: warning: Excess function parameter 'dev_priv' description in 'intel_u

[Intel-gfx] [PATCH 17/19] drm/i915/display/intel_display_power: Fix incorrectly documented function __intel_display_power_put_async()

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/display/intel_display_power.c:712: warning: expecting prototype for intel_display_power_put_async(). Prototype was for __intel_display_power_put_async() instead Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvr

[Intel-gfx] [PATCH 06/19] drm/i915/gt/intel_rps: Demote a kerneldoc abuse for ips_ping_for_i915_load()

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gt/intel_rps.c:2646: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David

[Intel-gfx] [PATCH 02/19] drm/i915/intel_region_ttm: Provide missing description for 'offset' param

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/intel_region_ttm.c:201: warning: Function parameter or member 'offset' not described in 'intel_region_ttm_resource_alloc' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Danie

[Intel-gfx] [PATCH 07/19] drm/i915/gem/i915_gem_create: Provide the function names for proper kerneldoc headers

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_create.c:147: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/i915/gem/i915_gem_create.c:218: warning: This comment starts w

[Intel-gfx] [PATCH 12/19] drm/i915/gem/i915_gem_wait: Provide function name to validate the kerneldoc header

2023-03-31 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_wait.c:164: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: D

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/wm: split out SKL+ watermark regs to a separate file

2023-03-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/wm: split out SKL+ watermark regs to a separate file URL : https://patchwork.freedesktop.org/series/115921/ State : warning == Summary == Error: dim checkpatch failed e5197a49e7e5 drm/i915/wm: split out SKL+ watermark regs to a

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/wm: split out SKL+ watermark regs to a separate file

2023-03-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/wm: split out SKL+ watermark regs to a separate file URL : https://patchwork.freedesktop.org/series/115921/ State : success == Summary == CI Bug Log - changes from CI_DRM_12950 -> Patchwork_115921v1 =

Re: [Intel-gfx] [PATCH v6 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-03-31 Thread Tvrtko Ursulin
On 30/03/2023 20:44, Teres Alexis, Alan Previn wrote: On Thu, 2023-03-30 at 13:25 +0100, Tvrtko Ursulin wrote: On 30/03/2023 01:10, Teres Alexis, Alan Previn wrote: On Wed, 2023-03-29 at 08:43 +0100, Tvrtko Ursulin wrote: On 28/03/2023 18:52, Rodrigo Vivi wrote: On Tue, Mar 28, 2023 at 05:0

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Hold a wakeref for the active VM

2023-03-31 Thread Patchwork
== Series Details == Series: drm/i915/gt: Hold a wakeref for the active VM URL : https://patchwork.freedesktop.org/series/115873/ State : success == Summary == CI Bug Log - changes from CI_DRM_12940_full -> Patchwork_115873v1_full Summary -

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/color: Fix typo for Plane CSC indexes

2023-03-31 Thread Patchwork
== Series Details == Series: drm/i915/color: Fix typo for Plane CSC indexes URL : https://patchwork.freedesktop.org/series/115874/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12941 -> Patchwork_115874v1 Summary ---

Re: [Intel-gfx] [PATCH 9/9] drm/i915/pmu: Enable legacy PMU events for MTL

2023-03-31 Thread Tvrtko Ursulin
On 30/03/2023 19:31, Umesh Nerlige Ramappa wrote: + Joonas for comments on this On Thu, Mar 30, 2023 at 02:38:03PM +0100, Tvrtko Ursulin wrote: On 30/03/2023 01:41, Umesh Nerlige Ramappa wrote: MTL introduces separate GTs for render and media. This complicates the definition of frequency an

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/color: Fix typo for Plane CSC indexes

2023-03-31 Thread Patchwork
== Series Details == Series: drm/i915/color: Fix typo for Plane CSC indexes URL : https://patchwork.freedesktop.org/series/115874/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12941 -> Patchwork_115874v1 Summary ---

Re: [Intel-gfx] [PATCH v2 00/10] Introduce new methods for verifying ownership in vfio PCI hot reset

2023-03-31 Thread Alex Williamson
On Fri, 31 Mar 2023 03:14:23 + "Jiang, Yanting" wrote: > > > > VFIO_DEVICE_PCI_HOT_RESET requires user to pass an array of group fds to > > prove that it owns all devices affected by resetting the calling device. > > This series > > introduces several extensions to allow the ownership check

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/color: Fix typo for Plane CSC indexes

2023-03-31 Thread Patchwork
== Series Details == Series: drm/i915/color: Fix typo for Plane CSC indexes URL : https://patchwork.freedesktop.org/series/115874/ State : success == Summary == CI Bug Log - changes from CI_DRM_12941 -> Patchwork_115874v1 Summary ---

[Intel-gfx] [PATCH v2] drm/i915/gt: Hold a wakeref for the active VM

2023-03-31 Thread Andrzej Hajda
From: Chris Wilson There may be a disconnect between the GT used by the engine and the GT used for the VM, requiring us to hold a wakeref on both while the GPU is active with this request. v2: added explanation to __queue_and_release_pm Signed-off-by: Chris Wilson [ahajda: removed not-yet-upst

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Hold a wakeref for the active VM

2023-03-31 Thread Tvrtko Ursulin
On 31/03/2023 15:16, Andrzej Hajda wrote: From: Chris Wilson There may be a disconnect between the GT used by the engine and the GT used for the VM, requiring us to hold a wakeref on both while the GPU is active with this request. v2: added explanation to __queue_and_release_pm Signed-off-b

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: enable kernel-doc warnings for CONFIG_DRM_I915_WERROR=y

2023-03-31 Thread Patchwork
== Series Details == Series: drm/i915: enable kernel-doc warnings for CONFIG_DRM_I915_WERROR=y URL : https://patchwork.freedesktop.org/series/115928/ State : success == Summary == CI Bug Log - changes from CI_DRM_12951 -> Patchwork_115928v1

[Intel-gfx] [CI] PR for new GuC v70.6.5 for MTL

2023-03-31 Thread John . C . Harrison
The following changes since commit bcdcfbcf0a8f24a914b8c163906e6ce93d7f8897: linux-firmware: Update firmware file for Intel Bluetooth AX101 (2023-03-20 08:34:27 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware mtl_guc_70.6.5 for you to fetch cha

Re: [Intel-gfx] [PATCH 07/19] drm/i915/gem/i915_gem_create: Provide the function names for proper kerneldoc headers

2023-03-31 Thread kernel test robot
Hi Lee, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-misc/drm-misc-next next-20230331] [cannot apply to drm-intel/for-linux-next-fixes lee-leds/for-leds-next linus/master v6.3-rc4] [If your patch is

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/color: Fix typo for Plane CSC indexes

2023-03-31 Thread Patchwork
== Series Details == Series: drm/i915/color: Fix typo for Plane CSC indexes URL : https://patchwork.freedesktop.org/series/115874/ State : success == Summary == CI Bug Log - changes from CI_DRM_12941_full -> Patchwork_115874v1_full Summary

Re: [Intel-gfx] [PATCH v2 9/9] drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c

2023-03-31 Thread Fabio M. De Francesco
On venerdì 31 marzo 2023 13:30:20 CEST Tvrtko Ursulin wrote: > On 31/03/2023 05:18, Ira Weiny wrote: > > Zhao Liu wrote: > >> From: Zhao Liu > >> > >> The use of kmap_atomic() is being deprecated in favor of > >> kmap_local_page()[1], and this patch converts the calls from > >> kmap_atomic() to k

[Intel-gfx] [PULL] drm-misc-next

2023-03-31 Thread Maarten Lankhorst
Hi Dave, Daniel, Small update. Slow week. Felt like sending a pull request regardless. drm-misc-next-2023-03-31: drm-misc-next for v6.4-rc1: Cross-subsystem Changes: - DT bindings update for adding Mali MT81xx devices. - Assorted DT binding updates. Core Changes: - Documentation update to sche

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev13)

2023-03-31 Thread Patchwork
== Series Details == Series: Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev13) URL : https://patchwork.freedesktop.org/series/107550/ State : warning == Summary == Error: dim checkpatch failed c710c347a560 drm/i915/display: Add new member to configure PCON color conversio

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev13)

2023-03-31 Thread Patchwork
== Series Details == Series: Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev13) URL : https://patchwork.freedesktop.org/series/107550/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./

[Intel-gfx] ✓ Fi.CI.BAT: success for Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev13)

2023-03-31 Thread Patchwork
== Series Details == Series: Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev13) URL : https://patchwork.freedesktop.org/series/107550/ State : success == Summary == CI Bug Log - changes from CI_DRM_12951 -> Patchwork_107550v13 ==

Re: [Intel-gfx] [PATCH v3 2/6] iommufd: Create access in vfio_iommufd_emulated_bind()

2023-03-31 Thread Jason Gunthorpe
On Fri, Mar 31, 2023 at 08:16:16AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Thursday, March 30, 2023 4:00 AM > > > > On Mon, Mar 27, 2023 at 02:33:47AM -0700, Yi Liu wrote: > > > @@ -494,6 +479,30 @@ void iommufd_access_destroy(struct > > iommufd_access *access) > > > } > >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Hold a wakeref for the active VM (rev2)

2023-03-31 Thread Patchwork
== Series Details == Series: drm/i915/gt: Hold a wakeref for the active VM (rev2) URL : https://patchwork.freedesktop.org/series/115873/ State : warning == Summary == Error: dim checkpatch failed a5998f00a5a9 drm/i915/gt: Hold a wakeref for the active VM -:71: WARNING:AVOID_BUG: Do not crash t

Re: [Intel-gfx] [PATCH v2 00/10] Introduce new methods for verifying ownership in vfio PCI hot reset

2023-03-31 Thread Xu, Terrence
> -Original Message- > From: Liu, Yi L > Sent: Monday, March 27, 2023 5:35 PM > > VFIO_DEVICE_PCI_HOT_RESET requires user to pass an array of group fds to > prove that it owns all devices affected by resetting the calling device. This > series introduces several extensions to allow the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Hold a wakeref for the active VM (rev2)

2023-03-31 Thread Patchwork
== Series Details == Series: drm/i915/gt: Hold a wakeref for the active VM (rev2) URL : https://patchwork.freedesktop.org/series/115873/ State : success == Summary == CI Bug Log - changes from CI_DRM_12951 -> Patchwork_115873v2 Summary

Re: [Intel-gfx] [PATCH v2 00/10] Introduce new methods for verifying ownership in vfio PCI hot reset

2023-03-31 Thread Alex Williamson
On Fri, 31 Mar 2023 17:27:27 + "Xu, Terrence" wrote: > > -Original Message- > > From: Liu, Yi L > > Sent: Monday, March 27, 2023 5:35 PM > > > > VFIO_DEVICE_PCI_HOT_RESET requires user to pass an array of group fds to > > prove that it owns all devices affected by resetting the call

Re: [Intel-gfx] [PATCH 14/19] drm/i915/i915_gem: Provide function names to complete the expected kerneldoc format

2023-03-31 Thread kernel test robot
Hi Lee, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-misc/drm-misc-next next-20230331] [cannot apply to drm-intel/for-linux-next-fixes lee-leds/for-leds-next linus/master v6.3-rc4] [If your patch is

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: reduce drm_detect_monitor_audio/drm_detect_hdmi_monitor/edid_blob_ptr usage

2023-03-31 Thread Patchwork
== Series Details == Series: drm: reduce drm_detect_monitor_audio/drm_detect_hdmi_monitor/edid_blob_ptr usage URL : https://patchwork.freedesktop.org/series/115878/ State : success == Summary == CI Bug Log - changes from CI_DRM_12944_full -> Patchwork_115878v1_full ===

Re: [Intel-gfx] [PATCH] [i915] avoid infinite retries in GuC/HuC loading

2023-03-31 Thread John Harrison
On 3/26/2023 02:46, Alexandre Oliva wrote: Hello, John, On Mar 24, 2023, John Harrison wrote: On 3/12/2023 12:56, Alexandre Oliva wrote: If two or more suitable entries with the same filename are found in __uc_fw_auto_select's fw_blobs, and that filename fails to load in the first attempt an

[Intel-gfx] [PATCH] drm/i915/fdinfo: Enable fdinfo for GuC backends

2023-03-31 Thread Umesh Nerlige Ramappa
The underlying mechanism used to provide the client specific utilization in fdinfo is context busyness. When a context switches out, the HW records the runtime in the specific context field. This information is accumulated in fdinfo. This information is independent of the scheduling backend as long

[Intel-gfx] [PATCH] drm/i915/fdinfo: Enable fdinfo for GuC backends

2023-03-31 Thread Umesh Nerlige Ramappa
The underlying mechanism used to provide the client specific utilization in fdinfo is context busyness. When a context switches out, the HW records the runtime in the specific context field. This information is accumulated in fdinfo. This information is independent of the scheduling backend as long

Re: [Intel-gfx] [PATCH v10 11/15] drm/atomic-helper: Set fence deadline for vblank

2023-03-31 Thread Nathan Chancellor
--[ end trace ]--- If there is any additional information that I can provide or patches I can test, I am more than happy to do so. Cheers, Nathan # bad: [4b0f4525dc4fe8af17b3daefe585f0c2eb0fe0a5] Add linux-next specific files for 20230331 # good: [b2bc47e9b2011a183f9d3d345

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/fdinfo: Enable fdinfo for GuC backends (rev2)

2023-03-31 Thread Patchwork
== Series Details == Series: drm/i915/fdinfo: Enable fdinfo for GuC backends (rev2) URL : https://patchwork.freedesktop.org/series/115958/ State : warning == Summary == Error: dim checkpatch failed 5e2ea7ebd7e8 drm/i915/fdinfo: Enable fdinfo for GuC backends -:22: WARNING:COMMIT_LOG_LONG_LINE:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fdinfo: Enable fdinfo for GuC backends (rev2)

2023-03-31 Thread Patchwork
== Series Details == Series: drm/i915/fdinfo: Enable fdinfo for GuC backends (rev2) URL : https://patchwork.freedesktop.org/series/115958/ State : success == Summary == CI Bug Log - changes from CI_DRM_12952 -> Patchwork_115958v2 Summary --

[Intel-gfx] [PATCH v8 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2023-03-31 Thread Mark Yacoub
Hi all, This is v7 of the HDCP patches. The patches are authored by Sean Paul. I rebased and addressed the review comments in v6-v8. Patches 1-4 focus on moving the common HDCP helpers to common DRM. This introduces a slight change in the original intel flow as it splits the unique driver protoc

[Intel-gfx] [PATCH v8 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2023-03-31 Thread Mark Yacoub
From: Sean Paul Move the hdcp atomic check from i915 to drm_hdcp so other drivers can use it. No functional changes, just cleaned up some of the code when moving it over. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Reviewed-by: Dmitry Baryshkov Signed-off-by: Sean Paul Signed-off-by: Mar

[Intel-gfx] [PATCH v8 03/10] drm/hdcp: Update property value on content type and user changes

2023-03-31 Thread Mark Yacoub
From: Sean Paul Update the connector's property value in 2 cases which were previously missed: 1- Content type changes. The value should revert back to DESIRED from ENABLED in case the driver must re-authenticate the link due to the new content type. 2- Userspace sets value to DESIRED whi

[Intel-gfx] [PATCH v8 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2023-03-31 Thread Mark Yacoub
From: Sean Paul Now that all of the HDCP 1.x logic has been migrated to the central HDCP helpers, use it in the i915 driver. The majority of the driver code for HDCP 1.x will live in intel_hdcp.c, however there are a few helper hooks which are connector-specific and need to be partially or fully

[Intel-gfx] [PATCH v8 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-03-31 Thread Mark Yacoub
From: Sean Paul The shim functions return error codes, but they are discarded in intel_hdcp.c. This patch plumbs the return codes through so they are properly handled. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub --- Changes in v2: -Non

[Intel-gfx] [PATCH v8 08/10] dt-bindings: msm/dp: Add bindings for HDCP registers

2023-03-31 Thread Mark Yacoub
From: Sean Paul Add the bindings for the MSM DisplayPort HDCP registers which are required to write the HDCP key into the display controller as well as the registers to enable HDCP authentication/key exchange/encryption. Cc: Rob Herring Cc: Stephen Boyd Reviewed-by: Rob Herring Reviewed-by: D

[Intel-gfx] [PATCH v8 04/10] drm/hdcp: Expand HDCP helper library for enable/disable/check

2023-03-31 Thread Mark Yacoub
From: Sean Paul Expand upon the HDCP helper library to manage HDCP enable, disable, and check. Previous to this patch, the majority of the state management and sink interaction is tucked inside the Intel driver with the understanding that once a new platform supported HDCP we could make good dec

[Intel-gfx] [PATCH v8 10/10] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2023-03-31 Thread Mark Yacoub
From: Sean Paul Add HDCP 1.x support to msm DP bridges using the new HDCP helpers. Cc: Stephen Boyd Reviewed-by: Stephen Boyd Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub --- Changes in v2: -Squash [1] into this patch with the following changes (Stephen) -Update the sc7180 dtsi fi

  1   2   >