Re: [Intel-gfx] [PATCH v8 21/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-03-30 Thread Liu, Yi L
> From: Alex Williamson > Sent: Thursday, March 30, 2023 5:01 AM > > On Mon, 27 Mar 2023 02:40:44 -0700 > Yi Liu wrote: > > > This adds ioctl for userspace to bind device cdev fd to iommufd. > > > > VFIO_DEVICE_BIND_IOMMUFD: bind device to an iommufd, hence gain DMA > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Explain the magic numbers for AUX SYNC/precharge length

2023-03-30 Thread Hogander, Jouni
On Wed, 2023-03-29 at 20:24 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the hardcoded final numbers in the AUX SYNC/precharge > setup, and derive those from numbers from the (e)DP specs. > > The new functions can serve as the single point of truth for > the number of SYNC pulse

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix fast wake AUX sync len

2023-03-30 Thread Hogander, Jouni
On Wed, 2023-03-29 at 20:24 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Fast wake should use 8 SYNC pulses for the preamble > and 10-16 SYNC pulses for the precharge. Recuce our > fast wake SYNC count to match the maximum value. > We also use the maximum precharge length for normal > AU

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: Add Support for C10 chips (rev2)

2023-03-30 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add Support for C10 chips (rev2) URL : https://patchwork.freedesktop.org/series/115664/ State : success == Summary == CI Bug Log - changes from CI_DRM_12936_full -> Patchwork_115664v2_full Summary

Re: [Intel-gfx] [PATCH] drm/scdc-helper: Pimp SCDC debugs

2023-03-30 Thread Maxime Ripard
Hi, On Wed, Mar 29, 2023 at 08:14:02PM +0300, Ville Syrjala wrote: > diff --git a/drivers/gpu/drm/display/drm_scdc_helper.c > b/drivers/gpu/drm/display/drm_scdc_helper.c > index c3ad4ab2b456..2b124152384c 100644 > --- a/drivers/gpu/drm/display/drm_scdc_helper.c > +++ b/drivers/gpu/drm/display/drm

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Make utility pin asserts more accurate (rev2)

2023-03-30 Thread Patchwork
== Series Details == Series: drm/i915: Make utility pin asserts more accurate (rev2) URL : https://patchwork.freedesktop.org/series/115741/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12936_full -> Patchwork_115741v2_full

Re: [Intel-gfx] [RFC][PATCH v2 1/3] drm: Introduce plane SIZE_HINTS property

2023-03-30 Thread Pekka Paalanen
On Tue, 21 Mar 2023 16:36:41 +0200 Ville Syrjala wrote: > From: Ville Syrjälä > > Add a new immutable plane property by which a plane can advertise > a handful of recommended plane sizes. This would be mostly exposed > by cursor planes as a slightly more capable replacement for > the DRM_CAP_CU

[Intel-gfx] [PATCH 0/4] log2: make is_power_of_2() more generic

2023-03-30 Thread Jani Nikula
is_power_of_2() only works for types <= sizeof(unsigned long) and it's also not a constant expression. There are a number of places in kernel where is_power_of_2() is called on u64, which fails on 32-bit builds. Try to remedy that. While at it, make it a constant expression when possible. I admit

[Intel-gfx] [PATCH 1/4] log2: add helper __IS_POWER_OF_2()

2023-03-30 Thread Jani Nikula
Add a helper to avoid duplication in the subsequent changes. Cc: Andrew Morton Cc: Christian König Cc: David Gow Signed-off-by: Jani Nikula --- include/linux/log2.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/linux/log2.h b/include/linux/log2.h index 9f30d08

[Intel-gfx] [PATCH 2/4] log2: have is_power_of_2() support bigger types than unsigned long

2023-03-30 Thread Jani Nikula
is_power_of_2() does not work properly for e.g. u64 in 32-bit builds. Choose an unsigned long long version if the argument is bigger than unsigned long. Cc: Andrew Morton Cc: Christian König Cc: David Gow Link: https://lore.kernel.org/r/20230329065532.2122295-2-david...@google.com Signed-off-by

[Intel-gfx] [PATCH 4/4] drm/i915/reg: use is_power_of_2() from log2.h

2023-03-30 Thread Jani Nikula
Now that log2.h is_power_of_2() supports constant expressions, use it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg_defs.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg_defs.h b/drivers/gpu/drm/i915/i915_reg_defs.h index

[Intel-gfx] [PATCH 3/4] log2: allow use of is_power_of_2() in constant expressions

2023-03-30 Thread Jani Nikula
Even though the static inline functions are __attribute__((const)) you can't use them in constant expressions. Make is_power_of_2() a constant expression if possible. Cc: Andrew Morton Cc: Christian König Cc: David Gow Signed-off-by: Jani Nikula --- include/linux/log2.h | 8 +--- 1 file c

Re: [Intel-gfx] [PATCH 0/4] log2: make is_power_of_2() more generic

2023-03-30 Thread Christian König
Am 30.03.23 um 12:42 schrieb Jani Nikula: is_power_of_2() only works for types <= sizeof(unsigned long) and it's also not a constant expression. There are a number of places in kernel where is_power_of_2() is called on u64, which fails on 32-bit builds. Try to remedy that. While at it, make it a

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add CSC state readout/check

2023-03-30 Thread Patchwork
== Series Details == Series: drm/i915: Add CSC state readout/check URL : https://patchwork.freedesktop.org/series/115794/ State : success == Summary == CI Bug Log - changes from CI_DRM_12936_full -> Patchwork_115794v1_full Summary ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: Use current cdclk for DSC Bigjoiner BW check

2023-03-30 Thread Nautiyal, Ankit K
On 3/29/2023 7:14 PM, Lisovskiy, Stanislav wrote: On Wed, Mar 29, 2023 at 02:35:38PM +0300, Ville Syrjälä wrote: On Wed, Mar 29, 2023 at 05:00:55PM +0530, Nautiyal, Ankit K wrote: On 3/29/2023 4:23 PM, Ville Syrjälä wrote: On Wed, Mar 29, 2023 at 04:06:21PM +0530, Nautiyal, Ankit K wrote: O

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for log2: make is_power_of_2() more generic

2023-03-30 Thread Patchwork
== Series Details == Series: log2: make is_power_of_2() more generic URL : https://patchwork.freedesktop.org/series/115863/ State : warning == Summary == Error: dim checkpatch failed 5c5c2de058cb log2: add helper __IS_POWER_OF_2() -:24: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possibl

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for log2: make is_power_of_2() more generic

2023-03-30 Thread Patchwork
== Series Details == Series: log2: make is_power_of_2() more generic URL : https://patchwork.freedesktop.org/series/115863/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: Use current cdclk for DSC Bigjoiner BW check

2023-03-30 Thread Nautiyal, Ankit K
On 3/29/2023 5:05 PM, Ville Syrjälä wrote: On Wed, Mar 29, 2023 at 05:00:55PM +0530, Nautiyal, Ankit K wrote: On 3/29/2023 4:23 PM, Ville Syrjälä wrote: On Wed, Mar 29, 2023 at 04:06:21PM +0530, Nautiyal, Ankit K wrote: On 3/29/2023 3:27 PM, Ville Syrjälä wrote: On Wed, Mar 29, 2023 at 02:1

[Intel-gfx] ✓ Fi.CI.BAT: success for log2: make is_power_of_2() more generic

2023-03-30 Thread Patchwork
== Series Details == Series: log2: make is_power_of_2() more generic URL : https://patchwork.freedesktop.org/series/115863/ State : success == Summary == CI Bug Log - changes from CI_DRM_12939 -> Patchwork_115863v1 Summary --- **SUCC

[Intel-gfx] [PULL] drm-intel-fixes

2023-03-30 Thread Jani Nikula
Hi Dave & Daniel - drm-intel-fixes-2023-03-30: drm/i915 fixes for v6.3-rc5: - Fix PMU support by reusing functions with sysfs - Fix a number of issues related to color, PSR and arm/noarm - Fix state check related to ICL PHY ownership check in TC-cold state - Flush lmem contents after constructio

Re: [Intel-gfx] [PATCH] drm/scdc-helper: Pimp SCDC debugs

2023-03-30 Thread Ville Syrjälä
On Thu, Mar 30, 2023 at 10:44:04AM +0200, Maxime Ripard wrote: > Hi, > > On Wed, Mar 29, 2023 at 08:14:02PM +0300, Ville Syrjala wrote: > > diff --git a/drivers/gpu/drm/display/drm_scdc_helper.c > > b/drivers/gpu/drm/display/drm_scdc_helper.c > > index c3ad4ab2b456..2b124152384c 100644 > > --- a/

Re: [Intel-gfx] [PATCH v8 21/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-03-30 Thread Jason Gunthorpe
On Thu, Mar 30, 2023 at 07:09:31AM +, Liu, Yi L wrote: > > > +long vfio_device_ioctl_bind_iommufd(struct vfio_device_file *df, > > > + struct vfio_device_bind_iommufd __user *arg) > > > +{ > > > + struct vfio_device *device = df->device; > > > + struct vfio_device_b

[Intel-gfx] ✓ Fi.CI.IGT: success for High refresh rate PSR fixes (rev7)

2023-03-30 Thread Patchwork
== Series Details == Series: High refresh rate PSR fixes (rev7) URL : https://patchwork.freedesktop.org/series/115109/ State : success == Summary == CI Bug Log - changes from CI_DRM_12936_full -> Patchwork_115109v7_full Summary --- *

[Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock

2023-03-30 Thread Swati Sharma
From: "David E. Box" The VMD driver calls pci_enabled_link_state as a callback from pci_bus_walk. Both will acquire the pci_bus_sem lock leading to a lockdep warning. Add an argument to pci_enable_link_state to set whether the lock should be acquired. In the VMD driver, set the argument to false

Re: [Intel-gfx] [PATCH v7 0/6] High refresh rate PSR fixes

2023-03-30 Thread Ville Syrjälä
On Wed, Mar 29, 2023 at 06:06:57PM +0300, Jouni Högander wrote: > Fix/adjust Wa_16013835468 and implement Wa_14015648006. Implement Wa_1136 and > check for vblank being long enough for psr2. > > v7: > - Apply Wa_14015648006 for display version 12 only > - Disable WM optimization in pre plane ho

Re: [Intel-gfx] [PATCH v6 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-03-30 Thread Tvrtko Ursulin
On 30/03/2023 01:10, Teres Alexis, Alan Previn wrote: On Wed, 2023-03-29 at 08:43 +0100, Tvrtko Ursulin wrote: On 28/03/2023 18:52, Rodrigo Vivi wrote: On Tue, Mar 28, 2023 at 05:01:36PM +, Teres Alexis, Alan Previn wrote: On Mon, 2023-03-27 at 17:15 +0100, Tvrtko Ursulin wrote: alan:

Re: [Intel-gfx] [PATCH 1/9] drm/i915/pmu: Support PMU for all engines

2023-03-30 Thread Tvrtko Ursulin
On 30/03/2023 01:40, Umesh Nerlige Ramappa wrote: From: Tvrtko Ursulin Given how the metrics are already exported, we also need to run sampling over engines from all GTs. Problem of GT frequencies is left for later. Signed-off-by: Tvrtko Ursulin Just a reminder to add your s-o-b while mo

Re: [Intel-gfx] [PATCH 5/9] drm/i915/pmu: Prepare for multi-tile non-engine counters

2023-03-30 Thread Tvrtko Ursulin
On 30/03/2023 01:40, Umesh Nerlige Ramappa wrote: From: Tvrtko Ursulin Reserve some bits in the counter config namespace which will carry the tile id and prepare the code to handle this. No per tile counters have been added yet. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915

Re: [Intel-gfx] [PATCH v2 10/10] vfio/pci: Add VFIO_DEVICE_GET_PCI_HOT_RESET_GROUP_INFO

2023-03-30 Thread Liu, Yi L
> From: Alex Williamson > Sent: Wednesday, March 29, 2023 11:50 PM > > On Wed, 29 Mar 2023 09:41:26 + > "Tian, Kevin" wrote: > > > > From: Liu, Yi L > > > Sent: Wednesday, March 29, 2023 11:14 AM > > > > > > > From: Alex Williamson > > > > Sent: Wednesday, March 29, 2023 12:00 AM > > > >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2)

2023-03-30 Thread Patchwork
== Series Details == Series: PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2) URL : https://patchwork.freedesktop.org/series/115466/ State : warning == Summary == Error: dim checkpatch failed d7993ebfc2b0 PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2)

2023-03-30 Thread Patchwork
== Series Details == Series: PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2) URL : https://patchwork.freedesktop.org/series/115466/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v8 21/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-03-30 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Thursday, March 30, 2023 7:52 PM > > On Thu, Mar 30, 2023 at 07:09:31AM +, Liu, Yi L wrote: > > > > > +long vfio_device_ioctl_bind_iommufd(struct vfio_device_file *df, > > > > + struct vfio_device_bind_iommufd > > > > __user

Re: [Intel-gfx] [PATCH v8 21/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-03-30 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Thursday, March 30, 2023 7:22 AM > > On Wed, Mar 29, 2023 at 03:00:55PM -0600, Alex Williamson wrote: > > > > + * The user should provide a device cookie when calling this ioctl. The > > > + * cookie is carried only in event e.g. I/O fault reported to userspace >

Re: [Intel-gfx] [PATCH v2 10/10] vfio/pci: Add VFIO_DEVICE_GET_PCI_HOT_RESET_GROUP_INFO

2023-03-30 Thread Liu, Yi L
> From: Liu, Yi L > Sent: Thursday, March 30, 2023 8:48 PM > if (fill->cur == fill->max) > return -EAGAIN; /* Something changed, try again */ > @@ -791,7 +812,24 @@ static int vfio_pci_fill_devs(struct pci_dev *pdev, void > *data) > if (!iommu_group) > ret

Re: [Intel-gfx] [PATCH v8 21/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-03-30 Thread Jason Gunthorpe
On Thu, Mar 30, 2023 at 12:52:39PM +, Liu, Yi L wrote: > > > "Use a negative value for no-iommu, where supported", or better, should > > > we define this explicitly as -1, or why not use a flag bit to specify > > > no-iommu? Maybe minsz is only through flags for the noiommu use case. > > > >

Re: [Intel-gfx] [PATCH 6/9] drm/i915/pmu: Export counters from all tiles

2023-03-30 Thread Tvrtko Ursulin
On 30/03/2023 01:41, Umesh Nerlige Ramappa wrote: From: Tvrtko Ursulin Start exporting frequency and RC6 counters from all tiles. Existing counters keep their names and config values and new one use the namespace added in the previous patch, with the "-gtN" added to their names. The part a

Re: [Intel-gfx] [PATCH v8 22/24] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT

2023-03-30 Thread Liu, Yi L
> From: Alex Williamson > Sent: Thursday, March 30, 2023 5:19 AM > > > Nit, ATDETACH? [AT|DE]TACH? [AT|DE]TACH 😊 > On Mon, 27 Mar 2023 02:40:45 -0700 > Yi Liu wrote: > > > This adds ioctl for userspace to attach device cdev fd to and detach > > from IOAS/hw_pagetable managed by iommufd. > >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add support for MTL GSC SW Proxy

2023-03-30 Thread Patchwork
== Series Details == Series: drm/i915: Add support for MTL GSC SW Proxy URL : https://patchwork.freedesktop.org/series/115806/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12936_full -> Patchwork_115806v1_full Summary

Re: [Intel-gfx] [PATCH v8 23/24] vfio: Compile group optionally

2023-03-30 Thread Liu, Yi L
> From: Alex Williamson > Sent: Thursday, March 30, 2023 5:51 AM > > On Mon, 27 Mar 2023 02:40:46 -0700 > Yi Liu wrote: > > > group code is not needed for vfio device cdev, so with vfio device cdev > > introduced, the group infrastructures can be compiled out if only cdev > > is needed. > > > >

[Intel-gfx] ✗ Fi.CI.BAT: failure for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2)

2023-03-30 Thread Patchwork
== Series Details == Series: PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev2) URL : https://patchwork.freedesktop.org/series/115466/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12939 -> Patchwork_115466v2 ==

Re: [Intel-gfx] [PATCH 7/9] drm/i915/pmu: Use a helper to convert to MHz

2023-03-30 Thread Tvrtko Ursulin
On 30/03/2023 01:41, Umesh Nerlige Ramappa wrote: Use a helper to convert frequency values to MHz. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_pmu.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/

Re: [Intel-gfx] [PATCH v8 24/24] docs: vfio: Add vfio device cdev description

2023-03-30 Thread Liu, Yi L
> From: Alex Williamson > Sent: Thursday, March 30, 2023 6:48 AM > > On Mon, 27 Mar 2023 02:40:47 -0700 > Yi Liu wrote: > > > This gives notes for userspace applications on device cdev usage. > > > > Reviewed-by: Kevin Tian > > Signed-off-by: Yi Liu > > --- > > Documentation/driver-api/vfio.

Re: [Intel-gfx] [PATCH 8/9] drm/i915/pmu: Split reading engine and other events into helpers

2023-03-30 Thread Tvrtko Ursulin
On 30/03/2023 01:41, Umesh Nerlige Ramappa wrote: Split the event reading function into engine and other helpers. What, why and how please, third bit not being needed in this case. :) Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_pmu.c | 93 ++

Re: [Intel-gfx] [PATCH 9/9] drm/i915/pmu: Enable legacy PMU events for MTL

2023-03-30 Thread Tvrtko Ursulin
On 30/03/2023 01:41, Umesh Nerlige Ramappa wrote: MTL introduces separate GTs for render and media. This complicates the definition of frequency and rc6 counters for the GPU as a whole since each GT has an independent counter. The best way to support this change is to deprecate the GPU-specific

[Intel-gfx] [PULL] drm-misc-fixes

2023-03-30 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the weekly PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2023-03-30: Short summary of fixes pull: * various ivpu fixes * fix nouveau backlight registration * fix buddy allocator in 32-bit systems The following changes since commit 1a70ca89d59c7c8af006d2

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Fix fast wake AUX sync len

2023-03-30 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix fast wake AUX sync len URL : https://patchwork.freedesktop.org/series/115810/ State : success == Summary == CI Bug Log - changes from CI_DRM_12937_full -> Patchwork_115810v1_full =

[Intel-gfx] [PATCH] drm/i915/gt: Hold a wakeref for the active VM

2023-03-30 Thread Andrzej Hajda
t;context->active_count != 1); + __intel_gt_pm_get(engine->gt); + /* * We have to serialise all potential retirement paths with our * submission, as we don't want to underflow either the --- base-commit: 3385d6482cd60f2a0bbb0fa97b70ae7dbba4f95c change-id: 20230330-hold_wakeref_for_active_vm-7f013a449ef3 Best regards, -- Andrzej Hajda

Re: [Intel-gfx] [PATCH] [topic/core-for-CI] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock

2023-03-30 Thread Rodrigo Vivi
On Thu, Mar 30, 2023 at 05:41:35PM +0530, Swati Sharma wrote: > From: "David E. Box" > > The VMD driver calls pci_enabled_link_state as a callback from > pci_bus_walk. Both will acquire the pci_bus_sem lock leading to a lockdep > warning. Add an argument to pci_enable_link_state to set whether th

[Intel-gfx] [PATCH] drm/i915/color: Fix typo for Plane CSC indexes

2023-03-30 Thread Chaitanya Kumar Borah
Replace _PLANE_INPUT_CSC_RY_GY_2_* with _PLANE_CSC_RY_GY_2_* for Plane CSC Fixes: 6eba56f64d5d ("drm/i915/pxp: black pixels on pxp disabled") Cc: Signed-off-by: Chaitanya Kumar Borah --- drivers/gpu/drm/i915/i915_reg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dr

Re: [Intel-gfx] [PATCH] drm/i915/gt: Hold a wakeref for the active VM

2023-03-30 Thread Rodrigo Vivi
ue_and_release_pm(struct i915_request *rq, > > ENGINE_TRACE(engine, "parking\n"); > > + GEM_BUG_ON(rq->context->active_count != 1); why do you need this here? should it be a separated patch with separated explanation? > + __intel_gt_pm_get(engine-&g

Re: [Intel-gfx] [PATCH] drm/i915/gt: Hold a wakeref for the active VM

2023-03-30 Thread Tvrtko Ursulin
where? Regards, Tvrtko /* * We have to serialise all potential retirement paths with our * submission, as we don't want to underflow either the --- base-commit: 3385d6482cd60f2a0bbb0fa97b70ae7dbba4f95c change-id: 20230330-hold_wakeref_for_active_vm-7f013a449ef3 Best regards,

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: (mostly) PSR related register cleanups (rev2)

2023-03-30 Thread Patchwork
== Series Details == Series: drm/i915: (mostly) PSR related register cleanups (rev2) URL : https://patchwork.freedesktop.org/series/115708/ State : success == Summary == CI Bug Log - changes from CI_DRM_12937_full -> Patchwork_115708v2_full

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Introduce new methods for verifying ownership in vfio PCI hot reset (rev3)

2023-03-30 Thread Patchwork
== Series Details == Series: Introduce new methods for verifying ownership in vfio PCI hot reset (rev3) URL : https://patchwork.freedesktop.org/series/115264/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/115264/revisions/3/mbox/ not applied App

[Intel-gfx] [PATCH 00/12] drm: reduce drm_detect_monitor_audio/drm_detect_hdmi_monitor/edid_blob_ptr usage

2023-03-30 Thread Jani Nikula
THIS IS UNTESTED for anything other than i915. Use previously parsed EDID where possible for display audio/hdmi detection. This in turn reduces edid_blob_ptr usage in a number of places. Further reduce edid_blob_ptr usage, and document that it should not be used by drivers directly. BR, Jani. C

[Intel-gfx] [PATCH 04/12] drm/radeon: remove radeon_connector_edid() and stop using edid_blob_ptr

2023-03-30 Thread Jani Nikula
radeon_connector_edid() copies the EDID from edid_blob_ptr as a side effect if radeon_connector->edid isn't initialized. However, everywhere that the returned EDID is used, the EDID should have been set beforehands. Only the EDID code and sysfs should look at the EDID property, anyway, so stop usi

[Intel-gfx] [PATCH 01/12] drm/edid: parse display info has_audio similar to is_hdmi

2023-03-30 Thread Jani Nikula
Since we already iterate everything that's needed for determining audio, reduce the need to call drm_detect_monitor_audio() by storing has_audio to connector info. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 6 ++ include/drm/drm_connector.h | 8 2 files changed, 14

[Intel-gfx] [PATCH 02/12] drm/nouveau: convert to using is_hdmi and has_audio from display info

2023-03-30 Thread Jani Nikula
Prefer the parsed results for is_hdmi and has_audio in display info over calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(), respectively. Conveniently, this also removes the need to use edid_blob_ptr. Cc: Ben Skeggs Cc: Karol Herbst Cc: Lyude Paul Cc: nouv...@lists.freedesktop.o

[Intel-gfx] [PATCH 03/12] drm/radeon: convert to using is_hdmi and has_audio from display info

2023-03-30 Thread Jani Nikula
Prefer the parsed results for is_hdmi and has_audio in display info over calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(), respectively. Cc: Alex Deucher Cc: Christian König Cc: Pan, Xinhui Cc: amd-...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/radeon

[Intel-gfx] [PATCH 06/12] drm/i915/debugfs: stop using edid_blob_ptr

2023-03-30 Thread Jani Nikula
Only the EDID code and sysfs should look at the EDID property. Stop using it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b

[Intel-gfx] [PATCH 05/12] drm/amdgpu: remove amdgpu_connector_edid() and stop using edid_blob_ptr

2023-03-30 Thread Jani Nikula
amdgpu_connector_edid() copies the EDID from edid_blob_ptr as a side effect if amdgpu_connector->edid isn't initialized. However, everywhere that the returned EDID is used, the EDID should have been set beforehands. Only the EDID code and sysfs should look at the EDID property, anyway, so stop usi

[Intel-gfx] [PATCH 07/12] drm/exynos: fix is_hdmi usage

2023-03-30 Thread Jani Nikula
drm_connector_update_edid_property() must have been called before to ensure is_hdmi has been populated. Cc: Inki Dae Cc: Seung-Woo Kim Cc: Kyungmin Park Signed-off-by: Jani Nikula --- drivers/gpu/drm/exynos/exynos_hdmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dr

[Intel-gfx] [PATCH 08/12] drm/i2c/tda998x: convert to using has_audio from display_info

2023-03-30 Thread Jani Nikula
Prefer the parsed results for has_audio in display info over calling drm_detect_monitor_audio(). Cc: Russell King Signed-off-by: Jani Nikula --- drivers/gpu/drm/i2c/tda998x_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu

[Intel-gfx] [PATCH 09/12] drm/sti/sti_hdmi: convert to using is_hdmi from display info

2023-03-30 Thread Jani Nikula
Prefer the parsed results for is_hdmi in display info over calling drm_detect_hdmi_monitor(). Remove the now redundant hdmi_monitor member from struct sti_hdmi. Cc: Alain Volmat Signed-off-by: Jani Nikula --- drivers/gpu/drm/sti/sti_hdmi.c | 11 ++- drivers/gpu/drm/sti/sti_hdmi.h | 2 -

[Intel-gfx] [PATCH 11/12] drm/rockchip: convert to using has_audio from display_info

2023-03-30 Thread Jani Nikula
Prefer the parsed results for has_audio in display info over calling drm_detect_monitor_audio(). Cc: Sandy Huang Cc: Heiko Stübner Signed-off-by: Jani Nikula --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 ++-- drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++- 2 files changed, 4 insertions(+), 3

[Intel-gfx] [PATCH 10/12] drm/rockchip: cdn-dp: call drm_connector_update_edid_property() unconditionally

2023-03-30 Thread Jani Nikula
Calling drm_connector_update_edid_property() should be done unconditionally instead of depending on the number of modes added. Also match the call order in inno_hdmi and rk3066_hdmi. Cc: Sandy Huang Cc: Heiko Stübner Signed-off-by: Jani Nikula --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 5 ++-

[Intel-gfx] [PATCH 12/12] drm/connector: update edid_blob_ptr documentation

2023-03-30 Thread Jani Nikula
Accessing the EDID via edid_blob_ptr causes chicken-and-egg problems. Keep edid_blob_ptr as the userspace interface that should be updated via dedicated functions. Signed-off-by: Jani Nikula --- include/drm/drm_connector.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Use 0 to designate disabled PL1 power limit

2023-03-30 Thread Rodrigo Vivi
On Wed, Mar 29, 2023 at 10:50:09PM -0700, Dixit, Ashutosh wrote: > On Tue, 28 Mar 2023 16:35:43 -0700, Ashutosh Dixit wrote: > > > > On ATSM the PL1 limit is disabled at power up. The previous uapi assumed > > that the PL1 limit is always enabled and therefore did not have a notion of > > a disable

Re: [Intel-gfx] [PATCH v2 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

2023-03-30 Thread Zhao Liu
Hi Fabio, On Wed, Mar 29, 2023 at 06:03:38PM +0200, Fabio M. De Francesco wrote: > Date: Wed, 29 Mar 2023 18:03:38 +0200 > From: "Fabio M. De Francesco" > Subject: Re: [PATCH v2 0/9] drm/i915: Replace kmap_atomic() with > kmap_local_page() > > On mercoledì 29 marzo 2023 09:32:11 CEST Zhao Liu w

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3)

2023-03-30 Thread Patchwork
== Series Details == Series: PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3) URL : https://patchwork.freedesktop.org/series/115466/ State : warning == Summary == Error: dim checkpatch failed ca06d5b4038a PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3)

2023-03-30 Thread Patchwork
== Series Details == Series: PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3) URL : https://patchwork.freedesktop.org/series/115466/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3)

2023-03-30 Thread Patchwork
== Series Details == Series: PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock (rev3) URL : https://patchwork.freedesktop.org/series/115466/ State : success == Summary == CI Bug Log - changes from CI_DRM_12940 -> Patchwork_115466v3 ==

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Skip cursor when writing PLANE_CHICKEN

2023-03-30 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Skip cursor when writing PLANE_CHICKEN URL : https://patchwork.freedesktop.org/series/115815/ State : success == Summary == CI Bug Log - changes from CI_DRM_12937_full -> Patchwork_115815v1_full

[Intel-gfx] [PATCH v2 26/29] drm/i915: Move shared DPLL disabling into CRTC disable hook

2023-03-30 Thread Imre Deak
The spec requires disabling the PLL on TC ports before disconnecting the port's PHY. Prepare for that by moving the PLL disabling to the CRTC disable hook, while disconnecting the PHY will be moved to the post_pll_disable() encoder hook in the next patch. v2: Move the call from intel_crtc_disable_

Re: [Intel-gfx] [PULL] drm-intel-fixes

2023-03-30 Thread Daniel Vetter
On Thu, Mar 30, 2023 at 02:30:29PM +0300, Jani Nikula wrote: > > Hi Dave & Daniel - > > drm-intel-fixes-2023-03-30: > drm/i915 fixes for v6.3-rc5: > - Fix PMU support by reusing functions with sysfs > - Fix a number of issues related to color, PSR and arm/noarm > - Fix state check related to ICL

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Hold a wakeref for the active VM

2023-03-30 Thread Patchwork
== Series Details == Series: drm/i915/gt: Hold a wakeref for the active VM URL : https://patchwork.freedesktop.org/series/115873/ State : warning == Summary == Error: dim checkpatch failed 9c965a96d5ee drm/i915/gt: Hold a wakeref for the active VM -:62: WARNING:AVOID_BUG: Do not crash the kern

Re: [Intel-gfx] [PATCH 0/7] drm/i915/regs: split display regs by function

2023-03-30 Thread Jani Nikula
On Thu, 16 Mar 2023, "Das, Nirmoy" wrote: > On 3/16/2023 2:29 PM, Jani Nikula wrote: >> Shave off 1.2k lines from i915_reg.h. >> >> Jani Nikula (7): >>drm/i915/pps: split out PPS regs to a separate file >>drm/i915/tv: split out TV regs to a separate file >>drm/i915/aux: split out DP AU

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Hold a wakeref for the active VM

2023-03-30 Thread Patchwork
== Series Details == Series: drm/i915/gt: Hold a wakeref for the active VM URL : https://patchwork.freedesktop.org/series/115873/ State : success == Summary == CI Bug Log - changes from CI_DRM_12940 -> Patchwork_115873v1 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: disable sampler indirect state in bindless heap

2023-03-30 Thread Lionel Landwerlin
On 29/03/2023 01:49, Matt Atwood wrote: On Tue, Mar 28, 2023 at 04:14:33PM +0530, Kalvala, Haridhar wrote: On 3/9/2023 8:56 PM, Lionel Landwerlin wrote: By default the indirect state sampler data (border colors) are stored in the same heap as the SAMPLER_STATE structure. For userspace drivers t

Re: [Intel-gfx] [PATCH 11/12] drm/rockchip: convert to using has_audio from display_info

2023-03-30 Thread Heiko Stübner
Am Donnerstag, 30. März 2023, 17:39:48 CEST schrieb Jani Nikula: > Prefer the parsed results for has_audio in display info over calling > drm_detect_monitor_audio(). > > Cc: Sandy Huang > Cc: Heiko Stübner > Signed-off-by: Jani Nikula Acked-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchi

Re: [Intel-gfx] [PATCH 10/12] drm/rockchip: cdn-dp: call drm_connector_update_edid_property() unconditionally

2023-03-30 Thread Heiko Stübner
Am Donnerstag, 30. März 2023, 17:39:47 CEST schrieb Jani Nikula: > Calling drm_connector_update_edid_property() should be done > unconditionally instead of depending on the number of modes added. Also > match the call order in inno_hdmi and rk3066_hdmi. > > Cc: Sandy Huang > Cc: Heiko Stübner >

Re: [Intel-gfx] [PATCH 6/9] drm/i915/pmu: Export counters from all tiles

2023-03-30 Thread Umesh Nerlige Ramappa
On Thu, Mar 30, 2023 at 02:01:42PM +0100, Tvrtko Ursulin wrote: On 30/03/2023 01:41, Umesh Nerlige Ramappa wrote: From: Tvrtko Ursulin Start exporting frequency and RC6 counters from all tiles. Existing counters keep their names and config values and new one use the namespace added in the pr

[Intel-gfx] [v2] drm/i915: disable sampler indirect state in bindless heap

2023-03-30 Thread Lionel Landwerlin
By default the indirect state sampler data (border colors) are stored in the same heap as the SAMPLER_STATE structure. For userspace drivers that can be 2 different heaps (dynamic state heap & bindless sampler state heap). This means that border colors have to copied in 2 different places so that t

Re: [Intel-gfx] [PULL] drm-misc-fixes

2023-03-30 Thread Daniel Vetter
On Thu, Mar 30, 2023 at 04:10:06PM +0200, Thomas Zimmermann wrote: > Hi Dave and Daniel, > > here's the weekly PR for drm-misc-fixes. > > Best regards > Thomas > > drm-misc-fixes-2023-03-30: > Short summary of fixes pull: > > * various ivpu fixes > * fix nouveau backlight registration > * fi

[Intel-gfx] ✓ Fi.CI.IGT: success for Add MTL Wa_14017066071, Wa_14017654203 and Wa_22015279794 (rev2)

2023-03-30 Thread Patchwork
== Series Details == Series: Add MTL Wa_14017066071, Wa_14017654203 and Wa_22015279794 (rev2) URL : https://patchwork.freedesktop.org/series/115821/ State : success == Summary == CI Bug Log - changes from CI_DRM_12937_full -> Patchwork_115821v2_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/color: Fix typo for Plane CSC indexes

2023-03-30 Thread Patchwork
== Series Details == Series: drm/i915/color: Fix typo for Plane CSC indexes URL : https://patchwork.freedesktop.org/series/115874/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12941 -> Patchwork_115874v1 Summary ---

Re: [Intel-gfx] [PATCH v7 08/10] dt-bindings: msm/dp: Add bindings for HDCP registers

2023-03-30 Thread Doug Anderson
Hi, On Fri, Mar 24, 2023 at 12:56 PM Mark Yacoub wrote: > > From: Sean Paul > > Add the bindings for the MSM DisplayPort HDCP registers > which are required to write the HDCP key into the display controller as > well as the registers to enable HDCP authentication/key > exchange/encryption. > > C

Re: [Intel-gfx] [PATCH v7 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2023-03-30 Thread Doug Anderson
Hi, On Fri, Mar 24, 2023 at 12:56 PM Mark Yacoub wrote: > > From: Sean Paul > > Add the register ranges required for HDCP key injection and > HDCP TrustZone interaction as described in the dt-bindings for the > sc7180 dp controller. > > Signed-off-by: Sean Paul > Signed-off-by: Mark Yacoub > >

Re: [Intel-gfx] [PATCH 9/9] drm/i915/pmu: Enable legacy PMU events for MTL

2023-03-30 Thread Umesh Nerlige Ramappa
+ Joonas for comments on this On Thu, Mar 30, 2023 at 02:38:03PM +0100, Tvrtko Ursulin wrote: On 30/03/2023 01:41, Umesh Nerlige Ramappa wrote: MTL introduces separate GTs for render and media. This complicates the definition of frequency and rc6 counters for the GPU as a whole since each GT h

Re: [Intel-gfx] [PATCH v3 0/6] vfio: Make emulated devices prepared for vfio device cdev

2023-03-30 Thread Alex Williamson
On Wed, 29 Mar 2023 16:47:39 -0300 Jason Gunthorpe wrote: > On Mon, Mar 27, 2023 at 02:33:45AM -0700, Yi Liu wrote: > > Nicolin Chen (1): > > iommufd: Create access in vfio_iommufd_emulated_bind() > > > > Yi Liu (5): > > iommu/iommufd: Pass iommufd_ctx pointer in iommufd_get_ioas() > > vfi

Re: [Intel-gfx] [v2] drm/i915: disable sampler indirect state in bindless heap

2023-03-30 Thread Matt Atwood
On Thu, Mar 30, 2023 at 08:47:40PM +0300, Lionel Landwerlin wrote: > By default the indirect state sampler data (border colors) are stored > in the same heap as the SAMPLER_STATE structure. For userspace drivers > that can be 2 different heaps (dynamic state heap & bindless sampler > state heap). T

Re: [Intel-gfx] [v2] drm/i915: disable sampler indirect state in bindless heap

2023-03-30 Thread Matt Atwood
On Thu, Mar 30, 2023 at 12:27:33PM -0700, Matt Atwood wrote: > On Thu, Mar 30, 2023 at 08:47:40PM +0300, Lionel Landwerlin wrote: > > By default the indirect state sampler data (border colors) are stored > > in the same heap as the SAMPLER_STATE structure. For userspace drivers > > that can be 2 di

Re: [Intel-gfx] [PATCH v6 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-03-30 Thread Teres Alexis, Alan Previn
On Thu, 2023-03-30 at 13:25 +0100, Tvrtko Ursulin wrote: > On 30/03/2023 01:10, Teres Alexis, Alan Previn wrote: > > On Wed, 2023-03-29 at 08:43 +0100, Tvrtko Ursulin wrote: > > > On 28/03/2023 18:52, Rodrigo Vivi wrote: > > > > On Tue, Mar 28, 2023 at 05:01:36PM +, Teres Alexis, Alan Previn >

[Intel-gfx] ✓ Fi.CI.IGT: success for Add MTL PMU support for multi-gt

2023-03-30 Thread Patchwork
== Series Details == Series: Add MTL PMU support for multi-gt URL : https://patchwork.freedesktop.org/series/115836/ State : success == Summary == CI Bug Log - changes from CI_DRM_12937_full -> Patchwork_115836v1_full Summary --- **S

Re: [Intel-gfx] [PATCH 0/4] log2: make is_power_of_2() more generic

2023-03-30 Thread Andrew Morton
On Thu, 30 Mar 2023 13:42:39 +0300 Jani Nikula wrote: > is_power_of_2() only works for types <= sizeof(unsigned long) and it's > also not a constant expression. There are a number of places in kernel > where is_power_of_2() is called on u64, which fails on 32-bit > builds. Try to remedy that. Whi

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for Add MTL Wa_14017066071, Wa_14017654203 and Wa_22015279794 (rev2)

2023-03-30 Thread Matt Roper
On Thu, Mar 30, 2023 at 06:04:13PM -, Patchwork wrote: > == Series Details == > > Series: Add MTL Wa_14017066071, Wa_14017654203 and Wa_22015279794 (rev2) > URL : https://patchwork.freedesktop.org/series/115821/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_12937

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: reduce drm_detect_monitor_audio/drm_detect_hdmi_monitor/edid_blob_ptr usage

2023-03-30 Thread Patchwork
== Series Details == Series: drm: reduce drm_detect_monitor_audio/drm_detect_hdmi_monitor/edid_blob_ptr usage URL : https://patchwork.freedesktop.org/series/115878/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separ

Re: [Intel-gfx] [PATCH 04/12] drm/radeon: remove radeon_connector_edid() and stop using edid_blob_ptr

2023-03-30 Thread kernel test robot
Hi Jani, I love your patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-exynos/exynos-drm-next linus/master v6.3-rc4 next-20230330] [If your patch is applied to the wrong git

Re: [Intel-gfx] [PATCH 04/12] drm/radeon: remove radeon_connector_edid() and stop using edid_blob_ptr

2023-03-30 Thread kernel test robot
Hi Jani, I love your patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-exynos/exynos-drm-next linus/master v6.3-rc4 next-20230330] [If your patch is applied to the wrong git

Re: [Intel-gfx] [PATCH] drm/i915/color: Fix typo for Plane CSC indexes

2023-03-30 Thread Shankar, Uma
> -Original Message- > From: Borah, Chaitanya Kumar > Sent: Thursday, March 30, 2023 8:31 PM > To: intel-gfx@lists.freedesktop.org > Cc: Shankar, Uma ; Borah, Chaitanya Kumar > ; sta...@vger.kernel.org > Subject: [PATCH] drm/i915/color: Fix typo for Plane CSC indexes > > Replace _PLANE

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: reduce drm_detect_monitor_audio/drm_detect_hdmi_monitor/edid_blob_ptr usage

2023-03-30 Thread Patchwork
== Series Details == Series: drm: reduce drm_detect_monitor_audio/drm_detect_hdmi_monitor/edid_blob_ptr usage URL : https://patchwork.freedesktop.org/series/115878/ State : success == Summary == CI Bug Log - changes from CI_DRM_12944 -> Patchwork_115878v1 =

  1   2   >