[Intel-gfx] [RESEND PATCHv2 1/2] drm: Add SDP Error Detection Configuration Register

2023-03-02 Thread Arun R Murthy
DP2.0 E11 defines a new register to facilitate SDP error detection by a 128B/132B capable DPRX device. v2: Update the macro name to reflect the DP spec(Harry) Signed-off-by: Arun R Murthy Reviewed-by: Harry Wentland --- include/drm/display/drm_dp.h | 3 +++ 1 file changed, 3 insertions(+) dif

[Intel-gfx] [PATCHv3 0/2] DP2.0 SDP CRC16 for 128/132b link layer

2023-03-02 Thread Arun R Murthy
*** BLURB HERE *** Arun R Murthy (2): drm: Add SDP Error Detection Configuration Register i915/display/dp: SDP CRC16 for 128b132b link layer .../gpu/drm/i915/display/intel_dp_link_training.c| 12 include/drm/display/drm_dp.h | 3 +++ 2 files changed,

[Intel-gfx] [PATCHv4 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer

2023-03-02 Thread Arun R Murthy
Enable SDP error detection configuration, this will set CRC16 in 128b/132b link layer. For Display version 13 a hardware bit31 in register VIDEO_DIP_CTL is added to enable/disable SDP CRC applicable for DP2.0 only, but the default value of this bit will enable CRC16 in 128b/132b hence skipping this

[Intel-gfx] [PATCH RESEND] drm/tests: Suballocator test

2023-03-02 Thread Thomas Hellström
Add a suballocator test to get some test coverage for the new drm suballocator, and perform some basic timing (elapsed time). Signed-off-by: Thomas Hellström --- drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/tests/Makefile| 3 +- drivers/gpu/drm/tests/drm_subal

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DP2.0 SDP CRC16 for 128/132b link layer (rev3)

2023-03-02 Thread Patchwork
== Series Details == Series: DP2.0 SDP CRC16 for 128/132b link layer (rev3) URL : https://patchwork.freedesktop.org/series/113134/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/113134/revisions/3/mbox/ not found

Re: [Intel-gfx] [PATCH v4 07/22] drm/i915/mtl: Add support for PM DEMAND

2023-03-02 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Mika > Kahola > Sent: Friday, February 24, 2023 3:44 PM > To: intel-gfx@lists.freedesktop.org > Cc: De Marchi, Lucas ; Roper, Matthew D > > Subject: [Intel-gfx] [PATCH v4 07/22] drm/i915/mtl: Add support for PM > DEMAND > > Display14 in

[Intel-gfx] ✗ Fi.CI.BAT: failure for DP2.0 SDP CRC16 for 128/132b link layer (rev3)

2023-03-02 Thread Patchwork
== Series Details == Series: DP2.0 SDP CRC16 for 128/132b link layer (rev3) URL : https://patchwork.freedesktop.org/series/113134/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12800 -> Patchwork_113134v3 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/tests: Suballocator test (rev2)

2023-03-02 Thread Patchwork
== Series Details == Series: drm/tests: Suballocator test (rev2) URL : https://patchwork.freedesktop.org/series/114410/ State : warning == Summary == Error: dim checkpatch failed 6ee63db5189b drm/tests: Suballocator test Traceback (most recent call last): File "scripts/spdxcheck.py", line 6,

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/tests: Suballocator test (rev2)

2023-03-02 Thread Patchwork
== Series Details == Series: drm/tests: Suballocator test (rev2) URL : https://patchwork.freedesktop.org/series/114410/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12800 -> Patchwork_114410v2 Summary --- **FAILURE*

Re: [Intel-gfx] [PATCH v4 07/22] drm/i915/mtl: Add support for PM DEMAND

2023-03-02 Thread Kahola, Mika
> -Original Message- > From: Murthy, Arun R > Sent: Thursday, March 2, 2023 10:50 AM > To: Kahola, Mika ; intel-gfx@lists.freedesktop.org > Cc: De Marchi, Lucas ; Roper, Matthew D > > Subject: RE: [Intel-gfx] [PATCH v4 07/22] drm/i915/mtl: Add support for PM > DEMAND > > > -Original

Re: [Intel-gfx] [PATCH v5 09/19] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-02 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 2, 2023 2:07 PM > > > - if (!vfio_dev_in_groups(cur_vma, groups)) { > > + if (cur_vma->vdev.open_count && > > + !vfio_dev_in_groups(cur_vma, groups) && > > + !vfio_dev_in_iommufd_ctx(cur_vma, iommufd_ctx)) {

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-03-02 Thread Matthew Auld
On 28/02/2023 14:08, Matthew Auld wrote: On 27/02/2023 17:19, Jonathan Cavitt wrote: Convert the igt_mock_ppgtt_huge_fill and igt_mock_ppgtt_64K mock selftests into live selftests as their requirements have recently become platform-dependent. Additionally, apply necessary platform dependency c

Re: [Intel-gfx] [PATCH v4] drm/i915: add guard page to ggtt->error_capture

2023-03-02 Thread Tvrtko Ursulin
On 08/02/2023 10:51, Andrzej Hajda wrote: Write-combining memory allows speculative reads by CPU. ggtt->error_capture is WC mapped to CPU, so CPU/MMU can try to prefetch memory beyond the error_capture, ie it tries to read memory pointed by next PTE in GGTT. If this PTE points to invalid addres

Re: [Intel-gfx] [PATCH v4] drm/i915: add guard page to ggtt->error_capture

2023-03-02 Thread Andrzej Hajda
On 02.03.2023 11:43, Tvrtko Ursulin wrote: On 08/02/2023 10:51, Andrzej Hajda wrote: Write-combining memory allows speculative reads by CPU. ggtt->error_capture is WC mapped to CPU, so CPU/MMU can try to prefetch memory beyond the error_capture, ie it tries to read memory pointed by next PTE

Re: [Intel-gfx] [PATCH v4 5/5] drm/i915/dmc: mass rename dev_priv to i915

2023-03-02 Thread Imre Deak
On Wed, Mar 01, 2023 at 02:29:44PM +0200, Jani Nikula wrote: > Follow the contemporary convention for struct drm_i915_private * naming. > > Cc: Imre Deak > Signed-off-by: Jani Nikula Looks ok to me, on the patchset: Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_dmc.c | 16

Re: [Intel-gfx] [PATCH v2] drm/i915/active: Fix misuse of non-idle barriers as fence trackers

2023-03-02 Thread Janusz Krzysztofik
Hi Andy, Thanks for review. On Thursday, 2 March 2023 01:42:05 CET Andi Shyti wrote: > Hi Janusz, > > On Sat, Feb 25, 2023 at 11:12:18PM +0100, Janusz Krzysztofik wrote: > > Users reported oopses on list corruptions when using i915 perf with a > > number of concurrently running graphics applicat

[Intel-gfx] [PATCH v3] drm/i915/active: Fix misuse of non-idle barriers as fence trackers

2023-03-02 Thread Janusz Krzysztofik
Users reported oopses on list corruptions when using i915 perf with a number of concurrently running graphics applications. Root cause analysis pointed at an issue in barrier processing code -- a race among perf open / close replacing active barriers with perf requests on kernel context and concur

Re: [Intel-gfx] [PATCH v5 09/19] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-02 Thread Jason Gunthorpe
On Thu, Mar 02, 2023 at 09:55:46AM +, Tian, Kevin wrote: > > From: Liu, Yi L > > Sent: Thursday, March 2, 2023 2:07 PM > > > > > - if (!vfio_dev_in_groups(cur_vma, groups)) { > > > + if (cur_vma->vdev.open_count && > > > + !vfio_dev_in_groups(cur_vma, groups) && >

Re: [Intel-gfx] [PATCH RESEND] drm/tests: Suballocator test

2023-03-02 Thread Christian König
Am 02.03.23 um 09:34 schrieb Thomas Hellström: Add a suballocator test to get some test coverage for the new drm suballocator, and perform some basic timing (elapsed time). Signed-off-by: Thomas Hellström Nice, I haven't had time to go over it in all detail but it looks pretty sophisticated.

Re: [Intel-gfx] [PATCH v5 09/19] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-02 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Thursday, March 2, 2023 8:35 PM > > On Thu, Mar 02, 2023 at 09:55:46AM +, Tian, Kevin wrote: > > > From: Liu, Yi L > > > Sent: Thursday, March 2, 2023 2:07 PM > > > > > > > - if (!vfio_dev_in_groups(cur_vma, groups)) { > > > > + if

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-03-02 Thread Cavitt, Jonathan
-Original Message- From: Auld, Matthew Sent: Thursday, March 2, 2023 2:36 AM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Dutt, Sudeep ; thomas.hellst...@linux.intel.com; maarten.lankho...@linux.intel.com; Vetter, Daniel ; De Marchi, Lucas ; chris.p.wil...@linux.intel.com

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v5,1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live (rev2)

2023-03-02 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live (rev2) URL : https://patchwork.freedesktop.org/series/114432/ State : warning == Summary == Error: dim checkpatch failed bf643697763a drm/i915: Migrate platform-depe

Re: [Intel-gfx] [PATCH v3] drm/i915/active: Fix misuse of non-idle barriers as fence trackers

2023-03-02 Thread Andi Shyti
Hi Janusz, On Thu, Mar 02, 2023 at 01:08:20PM +0100, Janusz Krzysztofik wrote: > Users reported oopses on list corruptions when using i915 perf with a > number of concurrently running graphics applications. Root cause analysis > pointed at an issue in barrier processing code -- a race among perf

[Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on MTL

2023-03-02 Thread Gustavo Sousa
From: Madhumitha Tolakanahalli Pradeep Add support to load DMC on MTL. Signed-off-by: Madhumitha Tolakanahalli Pradeep Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/display/intel_dmc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/d

[Intel-gfx] [PATCH 0/7] drm/i915: Check HPD during eDP probe

2023-03-02 Thread Ville Syrjala
From: Ville Syrjälä Carved out the HPD changes from by big DDI probe series to get it tested separately. Also tweaked a few things Jani pointed out during earlier review, and tossed in one extra refactoring patch on top. Ville Syrjälä (7): drm/i915: Populate dig_port->connected() before conne

[Intel-gfx] [PATCH 2/7] drm/i915: Fix SKL DDI A digital port .connected()

2023-03-02 Thread Ville Syrjala
From: Ville Syrjälä SKL doesn't have any north DE hotplug stuff. Currently we're trying to read DDI A live state from the BDW north DE bit, instead of the approproate south DE bit. Fix it. And for good measure clear the pointer to the north hpd pin array, so that we'll actually notice if some ot

[Intel-gfx] [PATCH 1/7] drm/i915: Populate dig_port->connected() before connector init

2023-03-02 Thread Ville Syrjala
From: Ville Syrjälä We'll need dig_port->connected() to be there for a HPD live state check during eDP connector probing. Reorder intel_ddi_init() accordingly. g4x_dp_init() is already fine. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 4

[Intel-gfx] [PATCH 3/7] drm/i915: Get rid of the gm45 HPD live state nonsense

2023-03-02 Thread Ville Syrjala
From: Ville Syrjälä The idea that ctg uses different HPD live state bits is total nonsense, at least on my machine (Dell Latitude E5400). The only reason DP-B even works on my ctg is that DP-D live state is stuck high, even though there is no physical DP-D port. So when the detect checks DP-B li

[Intel-gfx] [PATCH 4/7] drm/i915: Introduce _hotplug_mask()

2023-03-02 Thread Ville Syrjala
From: Ville Syrjälä Pair each _hotplug_enables() function with a corresponding _hotplug_mask() function so that we can determine right bits to clear on a per hpd_pin basis. We'll need this for turning on HPD sense for a specific encoder rather than just all of them. v2: Drop the unused 'i915' pa

[Intel-gfx] [PATCH 5/7] drm/i915: Introduce intel_hpd_enable_detection()

2023-03-02 Thread Ville Syrjala
From: Ville Syrjälä Add a mechanism by which we can enable the HPD sense for individual encoders. This will be used during eDP probing to figure out if anything is actually connected. The normal intel_hpd_irq_setup() thing doesn't work since we only do that after probing the outputs, and we only

[Intel-gfx] [PATCH 6/7] drm/i915: Check HPD live state during eDP probe

2023-03-02 Thread Ville Syrjala
From: Ville Syrjälä We need to untangle the mess where some SKL machines (at least) declare both DDI A and DDI E to be present in their VBT, and both using AUX A. DDI A is a ghost eDP, wheres DDI E may be a real DP->VGA converter. Currently that is handled by checking the VBT child devices for c

[Intel-gfx] [PATCH 7/7] drm/i915: Reuse _hotplug_mask() in .hpd_detection_setup()

2023-03-02 Thread Ville Syrjala
From: Ville Syrjälä Replace the hardcoded masks with just a loop over all hpd pins using the _hotplug_mask() functions. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_irq.c | 57 + 1 file changed, 22 insertions(+), 35 deletions(-) diff --git a/drive

[Intel-gfx] [PATCH] drm/i915/debugfs: move IPS debugfs to hsw_ips.c

2023-03-02 Thread Jani Nikula
Follow the style of placing debugfs next to the implementation. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/hsw_ips.c| 37 +++ drivers/gpu/drm/i915/display/hsw_ips.h| 2 + .../drm/i915/display/intel_display_debugfs.c | 30 +-- 3 files

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check HPD during eDP probe

2023-03-02 Thread Patchwork
== Series Details == Series: drm/i915: Check HPD during eDP probe URL : https://patchwork.freedesktop.org/series/114577/ State : warning == Summary == Error: dim checkpatch failed c5a6c0899fb8 drm/i915: Populate dig_port->connected() before connector init -:60: WARNING:BLOCK_COMMENT_STYLE: Blo

Re: [Intel-gfx] [PATCH RESEND] drm/tests: Suballocator test

2023-03-02 Thread kernel test robot
Hi Thomas, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Hellstr-m/drm-tests-Suballocator-test/20230302-163704 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: move IPS debugfs to hsw_ips.c

2023-03-02 Thread Ville Syrjälä
On Thu, Mar 02, 2023 at 06:16:17PM +0200, Jani Nikula wrote: > Follow the style of placing debugfs next to the implementation. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä Some ideas for future enhancements: - only register when IPS is actually supported - make it per-crtc since I

[Intel-gfx] [PATCH] drm/i915/rps: split out display rps parts to a separate file

2023-03-02 Thread Jani Nikula
Split out the RPS parts so they can be conditionally compiled out later. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 1 + .../gpu/drm/i915/display/intel_atomic_plane.c | 79 ++ .../gpu/drm/i915/display/intel_display_rps.c | 81

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: move IPS debugfs to hsw_ips.c

2023-03-02 Thread Jani Nikula
On Thu, 02 Mar 2023, Ville Syrjälä wrote: > On Thu, Mar 02, 2023 at 06:16:17PM +0200, Jani Nikula wrote: >> Follow the style of placing debugfs next to the implementation. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Ville Syrjälä Thanks! > Some ideas for future enhancements: > - only re

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/rps: split out display rps parts to a separate file

2023-03-02 Thread Patchwork
== Series Details == Series: drm/i915/rps: split out display rps parts to a separate file URL : https://patchwork.freedesktop.org/series/114581/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/in

Re: [Intel-gfx] [PATCH RESEND] drm/tests: Suballocator test

2023-03-02 Thread kernel test robot
Hi Thomas, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Hellstr-m/drm-tests-Suballocator-test/20230302-163704 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link

Re: [Intel-gfx] [PATCH] drm/i915/rps: split out display rps parts to a separate file

2023-03-02 Thread Ville Syrjälä
On Thu, Mar 02, 2023 at 06:49:36PM +0200, Jani Nikula wrote: > Split out the RPS parts so they can be conditionally compiled out later. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/Makefile | 1 + > .../gpu/drm/i915/display/intel_atom

Re: [Intel-gfx] [PATCH v4 07/22] drm/i915/mtl: Add support for PM DEMAND

2023-03-02 Thread Sripada, Radhakrishna
> -Original Message- > From: Intel-gfx On Behalf Of Kahola, > Mika > Sent: Thursday, March 2, 2023 1:40 AM > To: Murthy, Arun R ; intel-gfx@lists.freedesktop.org > Cc: Roper, Matthew D ; De Marchi, Lucas > > Subject: Re: [Intel-gfx] [PATCH v4 07/22] drm/i915/mtl: Add support for PM > DE

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on MTL

2023-03-02 Thread Rodrigo Vivi
On Thu, Mar 02, 2023 at 12:05:50PM -0300, Gustavo Sousa wrote: > From: Madhumitha Tolakanahalli Pradeep > > > Add support to load DMC on MTL. > > Signed-off-by: Madhumitha Tolakanahalli Pradeep > > Signed-off-by: Gustavo Sousa > --- > drivers/gpu/drm/i915/display/intel_dmc.c | 9 - >

Re: [Intel-gfx] [PATCH 1/6] drm/i915/wm: remove display/ prefix from include

2023-03-02 Thread Rodrigo Vivi
On Wed, Mar 01, 2023 at 03:54:15PM +0200, Jani Nikula wrote: > Remove the leftover from moving and renaming the file from driver top > level. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/intel_wm_types.h | 2 +- > 1 file changed, 1 insertion(+),

Re: [Intel-gfx] [PATCH 2/6] drm/i915/pm: drop intel_pm_setup()

2023-03-02 Thread Rodrigo Vivi
On Wed, Mar 01, 2023 at 03:54:16PM +0200, Jani Nikula wrote: > All the init in intel_pm_setup() is related to runtime pm. Move them to > intel_runtime_pm_init_early(), and remove intel_pm_setup(). > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_drive

Re: [Intel-gfx] [PATCH 3/6] drm/i915/pm: drop intel_suspend_hw()

2023-03-02 Thread Rodrigo Vivi
On Wed, Mar 01, 2023 at 03:54:17PM +0200, Jani Nikula wrote: > All intel_suspend_hw() does is clear PCH_LP_PARTITION_LEVEL_DISABLE bit > in SOUTH_DSPCLK_GATE_D for LPT LP. intel_suspend_hw() gets called from > i915_drm_suspend(). > > However, i915_drm_suspend_late() calls > intel_display_power_sus

Re: [Intel-gfx] [PATCH 4/6] drm/i915: remove unnecessary intel_pm.h includes

2023-03-02 Thread Rodrigo Vivi
On Wed, Mar 01, 2023 at 03:54:18PM +0200, Jani Nikula wrote: > As intel_pm.[ch] used to contain much more, intel_pm.h was included in a > lot of places. Many of them are now unnecessary. Remove. > > Signed-off-by: Jani Nikula trusting the compiler: Reviewed-by: Rodrigo Vivi > --- > drivers/

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on MTL

2023-03-02 Thread Matt Roper
On Thu, Mar 02, 2023 at 12:05:50PM -0300, Gustavo Sousa wrote: > From: Madhumitha Tolakanahalli Pradeep > > > Add support to load DMC on MTL. > > Signed-off-by: Madhumitha Tolakanahalli Pradeep > > Signed-off-by: Gustavo Sousa > --- > drivers/gpu/drm/i915/display/intel_dmc.c | 9 - >

Re: [Intel-gfx] [PATCH 5/6] drm/i915: rename intel_pm.[ch] to intel_clock_gating.[ch]

2023-03-02 Thread Rodrigo Vivi
On Wed, Mar 01, 2023 at 03:54:19PM +0200, Jani Nikula wrote: > Observe that intel_pm.[ch] is now purely about clock gating, so rename > them to intel_clock_gating.[ch]. Rename the functions to > intel_clock_gating_*() to follow coding conventions. > > Signed-off-by: Jani Nikula Reviewed-by: Rodr

Re: [Intel-gfx] [PATCH 6/6] drm/i915/clock: mass rename dev_priv to i915

2023-03-02 Thread Rodrigo Vivi
On Wed, Mar 01, 2023 at 03:54:20PM +0200, Jani Nikula wrote: > Follow the contemporary naming style. Include some indentation fixes > while at it on the affected statements. > > One function needs to keep using dev_priv due to implicit dev_priv usage > in a macro. > > Signed-off-by: Jani Nikula

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Don't switch to TPS1 when disabling DP_TP_CTL

2023-03-02 Thread Imre Deak
On Tue, Feb 14, 2023 at 03:43:46PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > AFAICS Bspec has never asked us to switch to TPS1 when *disabling* > DP_TP_CTL. Let's stop doing that in case it confuses something. > We do have to switch before we *enable* DP_TP_CTL, but that > is already

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Don't send idle pattern after DP2.0 link training

2023-03-02 Thread Imre Deak
On Tue, Feb 14, 2023 at 03:43:47PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Bspec calls us to select pattern 2 after link training for > DP 2.0. Let's do that... by doing nothing because we will > be transmitting pattern 2 at the end of the link training > already. > > Signed-off-by

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix idle pattern enabling

2023-03-02 Thread Imre Deak
On Tue, Feb 14, 2023 at 03:43:48PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we are always switching to the idle pattern after the > link training, but we don't always wait for the minimum number > of idle patterns sent. That doesn't look to be what Bspec > asks of us. > >

Re: [Intel-gfx] [PATCH v3 06/22] drm/i915/mtl: Add vswing programming for C10 phys

2023-03-02 Thread Sripada, Radhakrishna
Hi Mika, > -Original Message- > From: Kahola, Mika > Sent: Thursday, February 23, 2023 5:40 AM > To: intel-gfx@lists.freedesktop.org > Cc: Sripada, Radhakrishna ; Deak, Imre > ; Shankar, Uma ; Taylor, > Clinton A ; Kahola, Mika > Subject: [PATCH v3 06/22] drm/i915/mtl: Add vswing program

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/mtl: Apply Wa_14017073508 for MTL Media Step (rev2)

2023-03-02 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Apply Wa_14017073508 for MTL Media Step (rev2) URL : https://patchwork.freedesktop.org/series/114508/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12800 -> Patchwork_114508v2 Summ

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/active: Fix misuse of non-idle barriers as fence trackers (rev7)

2023-03-02 Thread Patchwork
== Series Details == Series: drm/i915/active: Fix misuse of non-idle barriers as fence trackers (rev7) URL : https://patchwork.freedesktop.org/series/113950/ State : success == Summary == CI Bug Log - changes from CI_DRM_12801 -> Patchwork_113950v7

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v5,1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live (rev2)

2023-03-02 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live (rev2) URL : https://patchwork.freedesktop.org/series/114432/ State : success == Summary == CI Bug Log - changes from CI_DRM_12801 -> Patchwork_114432v2

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Load DMC on MTL

2023-03-02 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Load DMC on MTL URL : https://patchwork.freedesktop.org/series/114576/ State : success == Summary == CI Bug Log - changes from CI_DRM_12801 -> Patchwork_114576v1 Summary --- **SUCCESS** N

Re: [Intel-gfx] [PATCH v5 09/19] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-02 Thread Alex Williamson
On Thu, 2 Mar 2023 06:07:04 + "Liu, Yi L" wrote: > > From: Liu, Yi L > > Sent: Monday, February 27, 2023 7:11 PM > [...] > > @@ -2392,13 +2416,25 @@ static int > > vfio_pci_dev_set_pm_runtime_get(struct vfio_device_set *dev_set) > > return ret; > > } > > > > +static bool vfio_dev_in_

Re: [Intel-gfx] [PATCH v3 9/9] drm/i915/perf: Add support for OA media units

2023-03-02 Thread Dixit, Ashutosh
On Mon, 27 Feb 2023 18:23:29 -0800, Umesh Nerlige Ramappa wrote: > Hi Umesh, > @@ -1632,11 +1647,28 @@ free_noa_wait(struct i915_perf_stream *stream) > i915_vma_unpin_and_release(&stream->noa_wait, 0); > } > > +/* > + * intel_engine_lookup_user ensures that most of engine specific checks a

Re: [Intel-gfx] [PATCH v4 04/22] drm/i915/mtl: Add Support for C10 PHY message bus and pll programming

2023-03-02 Thread Sripada, Radhakrishna
Hi Mika, > -Original Message- > From: Kahola, Mika > Sent: Friday, February 24, 2023 2:14 AM > To: intel-gfx@lists.freedesktop.org > Cc: Sripada, Radhakrishna ; Deak, Imre > ; Shankar, Uma ; Kahola, > Mika > Subject: [PATCH v4 04/22] drm/i915/mtl: Add Support for C10 PHY message bus > an

[Intel-gfx] [PATCH] drm/i915: Set wedged if enable guc communication failed

2023-03-02 Thread Zhanjun Dong
Add err code check for enable_communication on resume path. When resume failed, we can no longer use the GPU, marking the GPU as wedged. Signed-off-by: Zhanjun Dong --- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 7 ++- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 9 +++-- 2 files changed, 13 in

Re: [Intel-gfx] [PATCH] drm/i915: Set wedged if enable guc communication failed

2023-03-02 Thread Dong, Zhanjun
Thanks Jani. Updated patch sent, let me know if you have any comments. Regards, Zhanjun > -Original Message- > From: Jani Nikula > Sent: February 27, 2023 6:30 AM > To: Dong, Zhanjun ; intel- > g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Cc: Dong, Zhanjun > Subject: Re

Re: [Intel-gfx] [PATCH v5 00/19] Add vfio_device cdev for iommufd support

2023-03-02 Thread Nicolin Chen
On Thu, Mar 02, 2023 at 09:43:00AM +, Shameerali Kolothum Thodi wrote: > Hi Nicolin, > > Thanks for the latest ARM64 branch. Do you have a working Qemu branch > corresponding to the > above one? > > I tried the > https://github.com/nicolinc/qemu/tree/wip/iommufd_rfcv3%2Bnesting%2Bsmmuv3 >

[Intel-gfx] [PATCH v9 00/15] dma-fence: Deadline awareness

2023-03-02 Thread Rob Clark
From: Rob Clark This series adds a deadline hint to fences, so realtime deadlines such as vblank can be communicated to the fence signaller for power/ frequency management decisions. This is partially inspired by a trick i915 does, but implemented via dma-fence for a couple of reasons: 1) To co

[Intel-gfx] [PATCH v9 15/15] drm/i915: Add deadline based boost support

2023-03-02 Thread Rob Clark
From: Rob Clark v2: rebase Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/i915_request.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 7503dcb9043b..44491e7e214c 100644 --- a/drivers

Re: [Intel-gfx] [PATCH v3 8/9] drm/i915/perf: Add engine class instance parameters to perf

2023-03-02 Thread Umesh Nerlige Ramappa
On Wed, Mar 01, 2023 at 01:59:10PM -0800, Dixit, Ashutosh wrote: On Mon, 27 Feb 2023 18:23:28 -0800, Umesh Nerlige Ramappa wrote: Hi Umesh, diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h index 8df261c5ab9b..8ce20004a9dd 100644 --- a/include/uapi/drm/i915_drm.h +++ b/

Re: [Intel-gfx] [PATCH v6 3/8] drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC

2023-03-02 Thread Teres Alexis, Alan Previn
On Mon, 2023-02-27 at 18:21 -0800, Teres Alexis, Alan Previn wrote: > Add helper functions into a new file for heci-packet-submission. > The helpers will handle generating the MTL GSC-CS Memory-Header > and submission of the Heci-Cmd-Packet instructions to the engine. > > alan:snip > +int > +int

Re: [Intel-gfx] [PATCH v9 15/15] drm/i915: Add deadline based boost support

2023-03-02 Thread Rodrigo Vivi
On Thu, Mar 02, 2023 at 03:53:37PM -0800, Rob Clark wrote: > From: Rob Clark > missing some wording here... > v2: rebase > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/i915/i915_request.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/drivers/gpu/drm/i91

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Check HPD during eDP probe

2023-03-02 Thread Patchwork
== Series Details == Series: drm/i915: Check HPD during eDP probe URL : https://patchwork.freedesktop.org/series/114577/ State : success == Summary == CI Bug Log - changes from CI_DRM_12801 -> Patchwork_114577v1 Summary --- **SUCCESS

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rps: split out display rps parts to a separate file

2023-03-02 Thread Patchwork
== Series Details == Series: drm/i915/rps: split out display rps parts to a separate file URL : https://patchwork.freedesktop.org/series/114581/ State : success == Summary == CI Bug Log - changes from CI_DRM_12801 -> Patchwork_114581v1 Summ

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Set wedged if enable guc communication failed (rev2)

2023-03-02 Thread Patchwork
== Series Details == Series: drm/i915: Set wedged if enable guc communication failed (rev2) URL : https://patchwork.freedesktop.org/series/114366/ State : success == Summary == CI Bug Log - changes from CI_DRM_12803 -> Patchwork_114366v2 Su

[Intel-gfx] [PATCH v2 5/7] drm/i915/display: Fill in native_420 field

2023-03-02 Thread Suraj Kandpal
Now that we have laid the groundwork for YUV420 Enablement we fill up native_420 field in vdsc_cfg and add appropriate checks wherever required. ---v2 -adding native_422 field as 0 [Vandita] -filling in second_line_bpg_offset, second_line_offset_adj and nsl_bpg_offset in vds_cfg when native_420 is

Re: [Intel-gfx] [PATCH v5 09/19] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-02 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Thursday, March 2, 2023 10:20 PM > > > From: Jason Gunthorpe > > Sent: Thursday, March 2, 2023 8:35 PM > > > > On Thu, Mar 02, 2023 at 09:55:46AM +, Tian, Kevin wrote: > > > > From: Liu, Yi L > > > > Sent: Thursday, March 2, 2023 2:07 PM > > > > > > > > > -

Re: [Intel-gfx] [PATCH v5 16/19] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-03-02 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Thursday, March 2, 2023 1:47 AM > > On Wed, Mar 01, 2023 at 09:19:07AM +, Liu, Yi L wrote: > > > From: Liu, Yi L > > > Sent: Monday, February 27, 2023 7:12 PM > > [...] > > > +long vfio_device_ioctl_bind_iommufd(struct vfio_device_file *df, > > > +

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Add vfio_device cdev for iommufd support (rev7)

2023-03-02 Thread Patchwork
== Series Details == Series: Add vfio_device cdev for iommufd support (rev7) URL : https://patchwork.freedesktop.org/series/113696/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/113696/revisions/7/mbox/ not applied Applying: vfio: Allocate per de

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Make use of idr_find and idr_for_each_entry in dmabuf

2023-03-02 Thread Zhenyu Wang
On 2023.03.02 19:53:18 +0800, Cai Huoqing wrote: > This patch uses the already existing IDR mechanism to simplify > and improve the dmabuf code. > > Using 'vgpu.object_idr' directly instead of 'dmabuf_obj_list_head' > or 'dmabuf.list', because the dmabuf_obj can be found by 'idr_find' > or 'idr_fo

[Intel-gfx] [PATCH] Change the meaning of the fields in the ttm_place structure from pfn to bytes

2023-03-02 Thread Somalapuram Amaranath
Change the ttm_place structure member fpfn, lpfn, mem_type to res_start, res_end, res_type. Change the unsigned to u64. Fix the dependence in all the DRM drivers and clean up PAGE_SHIFT operation. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 11 +- dr

Re: [Intel-gfx] [PATCH v5 16/19] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-03-02 Thread Liu, Yi L
> From: Liu, Yi L > Sent: Friday, March 3, 2023 2:58 PM > > > From: Jason Gunthorpe > > Sent: Thursday, March 2, 2023 1:47 AM > > > > On Wed, Mar 01, 2023 at 09:19:07AM +, Liu, Yi L wrote: > > > > From: Liu, Yi L > > > > Sent: Monday, February 27, 2023 7:12 PM > > > [...] > > > > +long vfio

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Change the meaning of the fields in the ttm_place structure from pfn to bytes

2023-03-02 Thread Patchwork
== Series Details == Series: Change the meaning of the fields in the ttm_place structure from pfn to bytes URL : https://patchwork.freedesktop.org/series/114603/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/114603/revisions/1/mbox/ not applied