[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hwmon: Accept writes of value 0 to power1_max_interval

2023-02-28 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: Accept writes of value 0 to power1_max_interval URL : https://patchwork.freedesktop.org/series/114459/ State : success == Summary == CI Bug Log - changes from CI_DRM_12789_full -> Patchwork_114459v1_full =

[Intel-gfx] [PULL] drm-misc-next-fixes

2023-02-28 Thread Thomas Zimmermann
Hi Dave and Daniel, here are 3 more patches from drm-misc-next-fixes. In case there's no drm-next PR before -rc1, I'll cherrypick these changes into drm-misc-fixes later. Best regards Thomas drm-misc-next-fixes-2023-02-28: Short summary of fixes pull: Fixes uninitialized variables in fbdev erro

Re: [Intel-gfx] [RFC 0/2] Add new CDCLK step for RPL-U

2023-02-28 Thread Borah, Chaitanya Kumar
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, February 28, 2023 6:06 AM > To: Borah, Chaitanya Kumar > Cc: intel-gfx@lists.freedesktop.org; jani.nik...@linux.intel.com; Shankar, > Uma ; Syrjala, Ville ; > Srivatsa, Anusha ; Atwood, Matthew S > > Subject: Re: [RFC 0/2] Ad

[Intel-gfx] [PATCH 00/10] drm/i915: move DSC RC tables to drm_dsc_helper.c

2023-02-28 Thread Dmitry Baryshkov
Other platforms (msm) will benefit from sharing the DSC config setup functions. This series moves parts of static DSC config data from the i915 driver to the common helpers to be used by other drivers. Note: the RC parameters were cross-checked against config files found in DSC model 2021062, 2016

[Intel-gfx] [PATCH 01/10] drm/i915/dsc: change DSC param tables to follow the DSC model

2023-02-28 Thread Dmitry Baryshkov
After cross-checking DSC models (20150914, 20161212, 20210623) change values in rc_parameters tables to follow config files present inside the DSC model. Handle two places, where i915 tables diverged from the model, by patching the rc values in the code. Note: I left one case uncorrected, 8bpp/10b

[Intel-gfx] [PATCH 05/10] drm/display/dsc: use flat array for rc_parameters lookup

2023-02-28 Thread Dmitry Baryshkov
Next commits are going to add support for additional RC parameter lookup tables. These tables are going to use different bpp/bpc combinations, thus it makes little sense to keep the 2d array for RC parameters. Switch to using the flat array. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/di

[Intel-gfx] [PATCH 02/10] drm/i915/dsc: move rc_buf_thresh values to common helper

2023-02-28 Thread Dmitry Baryshkov
The rc_buf_thresh values are common to all DSC implementations. Move them to the common helper together with the code to propagage them to the drm_dsc_config. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 37 +++ drivers/gpu/drm/i915/display/

[Intel-gfx] [PATCH 03/10] drm/i915/dsc: move DSC tables to DRM DSC helper

2023-02-28 Thread Dmitry Baryshkov
This moves DSC RC tables to DRM DSC helper. No additional code changes and/or cleanups are a part of this commit, it will be cleaned up in the followup commits. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 364 ++ drivers/gpu/drm/i915/displa

[Intel-gfx] [PATCH 04/10] drm/i915/dsc: stop using interim structure for calculated params

2023-02-28 Thread Dmitry Baryshkov
Stop using an interim structure rc_parameters for storing calculated params and then setting drm_dsc_config using that structure. Instead put calculated params into the struct drm_dsc_config directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/i915/display/intel_vdsc.c | 89 +---

[Intel-gfx] [PATCH 07/10] drm/display/dsc: include the rest of pre-SCR parameters

2023-02-28 Thread Dmitry Baryshkov
DSC model contains pre-SCR RC parameters for other bpp/bpc combinations, include them here for completeness. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 72 1 file changed, 72 insertions(+) diff --git a/drivers/gpu/drm/display/drm_dsc_

[Intel-gfx] [PATCH 06/10] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-02-28 Thread Dmitry Baryshkov
The array of rc_parameters contains a mixture of parameters from DSC 1.1 and DSC 1.2 standards. Split these tow configuration arrays in preparation to adding more configuration data. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 127 ++ drive

[Intel-gfx] [PATCH 08/10] drm/display/dsc: add YCbCr 4:2:2 and 4:2:0 RC parameters

2023-02-28 Thread Dmitry Baryshkov
Include RC parameters for YCbCr 4:2:2 and 4:2:0 configurations. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 438 +++ include/drm/display/drm_dsc_helper.h | 2 + 2 files changed, 440 insertions(+) diff --git a/drivers/gpu/drm/display/d

[Intel-gfx] [PATCH 09/10] drm/display/dsc: add helper to set semi-const parameters

2023-02-28 Thread Dmitry Baryshkov
Add a helper setting config values which are typically constant across operating modes (table E-4 of the standard) and mux_word_size (which is a const according to 3.5.2). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 21 + include/drm/display

[Intel-gfx] [PATCH 10/10] drm/msm/dsi: use new helpers for DSC setup

2023-02-28 Thread Dmitry Baryshkov
Use new DRM DSC helpers to setup DSI DSC configuration. The initial_scale_value needs to be adjusted according to the standard, but this is a separate change. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_host.c | 61 -- 1 file changed, 8 insertions(

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: move DSC RC tables to drm_dsc_helper.c

2023-02-28 Thread Patchwork
== Series Details == Series: drm/i915: move DSC RC tables to drm_dsc_helper.c URL : https://patchwork.freedesktop.org/series/114473/ State : success == Summary == CI Bug Log - changes from CI_DRM_12790 -> Patchwork_114473v1 Summary ---

Re: [Intel-gfx] [PATCH 02/10] drm/i915/dsc: move rc_buf_thresh values to common helper

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > The rc_buf_thresh values are common to all DSC implementations. Move > them to the common helper together with the code to propagage them to > the drm_dsc_config. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dsc_helper.c

Re: [Intel-gfx] [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace

2023-02-28 Thread Jason Gunthorpe
On Tue, Feb 28, 2023 at 02:35:25AM +, Liu, Yi L wrote: > > And the commit message is sort of out of sync with the patch, more like: > > > > vfio: Pass the pt_id as an argument to vfio_iommufd_bind() > > > > To support binding the cdev the pt_id must come from userspace instead > > of being f

Re: [Intel-gfx] [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace

2023-02-28 Thread Jason Gunthorpe
On Tue, Feb 28, 2023 at 06:58:38AM +, Liu, Yi L wrote: > Seems like pt_id is no more needed in the vfio_iommufd_bind() > since it can get compat_ioas_id in the function itself. Cdev path > never passes a pt_id to vfio_iommufd_bind() as its attach is done > by separate ATTACH ioctl. Can we use

Re: [Intel-gfx] [PATCH v5 17/19] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT

2023-02-28 Thread Jason Gunthorpe
On Tue, Feb 28, 2023 at 02:51:28AM +, Liu, Yi L wrote: > > This seems strange. no iommu mode should have a NULL dev->iommufctx. > > Why do we have a df->noiommu at all? > > This is due to the vfio_device_first_open(). Detail as below comment (part of > patch 0016). > > + /* > + * For

Re: [Intel-gfx] [PATCH v5 11/19] vfio-iommufd: Add detach_ioas support for physical VFIO devices

2023-02-28 Thread Jason Gunthorpe
On Tue, Feb 28, 2023 at 02:57:42AM +, Liu, Yi L wrote: > > From: Jason Gunthorpe > > Sent: Tuesday, February 28, 2023 2:45 AM > > > > On Mon, Feb 27, 2023 at 03:11:27AM -0800, Yi Liu wrote: > > > diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc.c b/drivers/vfio/fsl- > > mc/vfio_fsl_mc.c > > > ind

Re: [Intel-gfx] [PATCH v5 14/19] vfio: Make vfio_device_open() single open for device cdev path

2023-02-28 Thread Jason Gunthorpe
On Tue, Feb 28, 2023 at 03:11:34AM +, Liu, Yi L wrote: > > From: Jason Gunthorpe > > Sent: Tuesday, February 28, 2023 2:52 AM > > > > On Mon, Feb 27, 2023 at 03:11:30AM -0800, Yi Liu wrote: > > > @@ -535,7 +542,8 @@ static int vfio_device_fops_release(struct inode > > *inode, struct file *fil

Re: [Intel-gfx] [PATCH 02/10] drm/i915/dsc: move rc_buf_thresh values to common helper

2023-02-28 Thread Dmitry Baryshkov
On Tue, 28 Feb 2023 at 14:25, Jani Nikula wrote: > > On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > > The rc_buf_thresh values are common to all DSC implementations. Move > > them to the common helper together with the code to propagage them to > > the drm_dsc_config. > > > > Signed-off-by: Dmitr

Re: [Intel-gfx] [PATCH v5 18/19] vfio: Compile group optionally

2023-02-28 Thread Jason Gunthorpe
On Tue, Feb 28, 2023 at 06:00:09AM +, Liu, Yi L wrote: > > From: Liu, Yi L > > Sent: Monday, February 27, 2023 7:12 PM > > > > group code is not needed for vfio device cdev, so with vfio device cdev > > introduced, the group infrastructures can be compiled out if only cdev > > is needed. > >

Re: [Intel-gfx] [PATCH v3 05/22] drm/i915: Introduce intel_hpd_detection()

2023-02-28 Thread Jani Nikula
On Wed, 22 Feb 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Add a mechanism by which we can toggle the HPD sense for > individual encoders. > > This will be used during eDP probing to figure out if > anything is actually connected. The normal intel_hpd_irq_setup() > thing doesn't work sin

Re: [Intel-gfx] [PATCH v5 17/19] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT

2023-02-28 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 8:32 PM > > On Tue, Feb 28, 2023 at 02:51:28AM +, Liu, Yi L wrote: > > > This seems strange. no iommu mode should have a NULL dev- > >iommufctx. > > > Why do we have a df->noiommu at all? > > > > This is due to the vfio_device_first_o

Re: [Intel-gfx] [PATCH v7 00/15] dma-fence: Deadline awareness

2023-02-28 Thread Bagas Sanjaya
On Mon, Feb 27, 2023 at 11:35:06AM -0800, Rob Clark wrote: > From: Rob Clark > > This series adds a deadline hint to fences, so realtime deadlines > such as vblank can be communicated to the fence signaller for power/ > frequency management decisions. > > This is partially inspired by a trick i9

Re: [Intel-gfx] [PATCH v5 11/19] vfio-iommufd: Add detach_ioas support for physical VFIO devices

2023-02-28 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 8:33 PM > > On Tue, Feb 28, 2023 at 02:57:42AM +, Liu, Yi L wrote: > > > From: Jason Gunthorpe > > > Sent: Tuesday, February 28, 2023 2:45 AM > > > > > > On Mon, Feb 27, 2023 at 03:11:27AM -0800, Yi Liu wrote: > > > > diff --git a/dri

Re: [Intel-gfx] [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace

2023-02-28 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 8:31 PM > > On Tue, Feb 28, 2023 at 06:58:38AM +, Liu, Yi L wrote: > > > Seems like pt_id is no more needed in the vfio_iommufd_bind() > > since it can get compat_ioas_id in the function itself. Cdev path > > never passes a pt_id to

Re: [Intel-gfx] [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace

2023-02-28 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 8:30 PM > > On Tue, Feb 28, 2023 at 02:35:25AM +, Liu, Yi L wrote: > > > > And the commit message is sort of out of sync with the patch, more like: > > > > > > vfio: Pass the pt_id as an argument to vfio_iommufd_bind() > > > > > > To

Re: [Intel-gfx] [PATCH 02/10] drm/i915/dsc: move rc_buf_thresh values to common helper

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > On Tue, 28 Feb 2023 at 14:25, Jani Nikula wrote: >> >> On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: >> > The rc_buf_thresh values are common to all DSC implementations. Move >> > them to the common helper together with the code to propagage them to

Re: [Intel-gfx] [PATCH v3 05/22] drm/i915: Introduce intel_hpd_detection()

2023-02-28 Thread Ville Syrjälä
On Tue, Feb 28, 2023 at 02:40:20PM +0200, Jani Nikula wrote: > On Wed, 22 Feb 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Add a mechanism by which we can toggle the HPD sense for > > individual encoders. > > > > This will be used during eDP probing to figure out if > > anything is

Re: [Intel-gfx] [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace

2023-02-28 Thread Jason Gunthorpe
On Tue, Feb 28, 2023 at 12:45:47PM +, Liu, Yi L wrote: > > From: Jason Gunthorpe > > Sent: Tuesday, February 28, 2023 8:31 PM > > > > On Tue, Feb 28, 2023 at 06:58:38AM +, Liu, Yi L wrote: > > > > > Seems like pt_id is no more needed in the vfio_iommufd_bind() > > > since it can get comp

Re: [Intel-gfx] [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace

2023-02-28 Thread Jason Gunthorpe
On Tue, Feb 28, 2023 at 12:48:23PM +, Liu, Yi L wrote: > > From: Jason Gunthorpe > > Sent: Tuesday, February 28, 2023 8:30 PM > > > > On Tue, Feb 28, 2023 at 02:35:25AM +, Liu, Yi L wrote: > > > > > > And the commit message is sort of out of sync with the patch, more like: > > > > > > >

Re: [Intel-gfx] [PATCH v5 17/19] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT

2023-02-28 Thread Jason Gunthorpe
On Tue, Feb 28, 2023 at 12:42:31PM +, Liu, Yi L wrote: > > From: Jason Gunthorpe > > Sent: Tuesday, February 28, 2023 8:32 PM > > > > On Tue, Feb 28, 2023 at 02:51:28AM +, Liu, Yi L wrote: > > > > This seems strange. no iommu mode should have a NULL dev- > > >iommufctx. > > > > Why do we

Re: [Intel-gfx] [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace

2023-02-28 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 8:52 PM > > On Tue, Feb 28, 2023 at 12:45:47PM +, Liu, Yi L wrote: > > > From: Jason Gunthorpe > > > Sent: Tuesday, February 28, 2023 8:31 PM > > > > > > On Tue, Feb 28, 2023 at 06:58:38AM +, Liu, Yi L wrote: > > > > > > > Seems

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: move DSC RC tables to drm_dsc_helper.c

2023-02-28 Thread Patchwork
== Series Details == Series: drm/i915: move DSC RC tables to drm_dsc_helper.c URL : https://patchwork.freedesktop.org/series/114473/ State : success == Summary == CI Bug Log - changes from CI_DRM_12790_full -> Patchwork_114473v1_full Summar

Re: [Intel-gfx] [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace

2023-02-28 Thread Jason Gunthorpe
On Tue, Feb 28, 2023 at 12:56:11PM +, Liu, Yi L wrote: > > From: Jason Gunthorpe > > Sent: Tuesday, February 28, 2023 8:52 PM > > > > On Tue, Feb 28, 2023 at 12:45:47PM +, Liu, Yi L wrote: > > > > From: Jason Gunthorpe > > > > Sent: Tuesday, February 28, 2023 8:31 PM > > > > > > > > On T

Re: [Intel-gfx] [PATCH 02/10] drm/i915/dsc: move rc_buf_thresh values to common helper

2023-02-28 Thread Dmitry Baryshkov
On 28/02/2023 14:49, Jani Nikula wrote: On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: On Tue, 28 Feb 2023 at 14:25, Jani Nikula wrote: On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: The rc_buf_thresh values are common to all DSC implementations. Move them to the common helper together with th

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Apply Wa_14017073508 for MTL SoC Step

2023-02-28 Thread Nilawar, Badal
Hi Matt, On 24-02-2023 02:43, Matt Roper wrote: On Thu, Feb 23, 2023 at 03:20:28PM -0500, Rodrigo Vivi wrote: On Fri, Feb 24, 2023 at 12:11:40AM +0530, Badal Nilawar wrote: Apply Wa_14017073508 for MTL SoC die A step instead of graphics step. To get the SoC die stepping there is no direct inte

Re: [Intel-gfx] [PATCH v5 17/19] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT

2023-02-28 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 8:54 PM > > On Tue, Feb 28, 2023 at 12:42:31PM +, Liu, Yi L wrote: > > > From: Jason Gunthorpe > > > Sent: Tuesday, February 28, 2023 8:32 PM > > > > > > On Tue, Feb 28, 2023 at 02:51:28AM +, Liu, Yi L wrote: > > > > > This seems

Re: [Intel-gfx] [PATCH] drm/shmem-helper: Fix compile error

2023-02-28 Thread Andi Shyti
Hi Dmitry, On Tue, Feb 28, 2023 at 04:15:28PM +0300, Dmitry Osipenko wrote: > Hi, > > On 2/28/23 15:50, Andi Shyti wrote: > > Commit 67b7836d4458 ("drm/shmem-helper: Switch to reservation > > lock") removes the drm_gem_shmem_get_pages_locked() and > > drm_gem_shmem_put_pages_locked(). > > > > Bu

Re: [Intel-gfx] [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace

2023-02-28 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 8:53 PM > > On Tue, Feb 28, 2023 at 12:48:23PM +, Liu, Yi L wrote: > > > From: Jason Gunthorpe > > > Sent: Tuesday, February 28, 2023 8:30 PM > > > > > > On Tue, Feb 28, 2023 at 02:35:25AM +, Liu, Yi L wrote: > > > > > > > > And

Re: [Intel-gfx] [PATCH v4 03/22] drm/i915/mtl: Create separate reg file for PICA registers

2023-02-28 Thread Kahola, Mika
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, February 28, 2023 2:17 AM > To: Kahola, Mika > Cc: intel-gfx@lists.freedesktop.org; Sripada, Radhakrishna > ; Sousa, Gustavo > Subject: Re: [Intel-gfx] [PATCH v4 03/22] drm/i915/mtl: Create separate reg > file > for PICA reg

Re: [Intel-gfx] [PATCH v5 17/19] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT

2023-02-28 Thread Jason Gunthorpe
On Tue, Feb 28, 2023 at 01:22:50PM +, Liu, Yi L wrote: > > A null iommufd pointer and a bound df flag is sufficient to see that > > it is compat mode. > > Hope df->is_cdev_device suits your expectation.:-) The code will look > like below: Yes, this is better.. However I'd suggest 'uses_conta

Re: [Intel-gfx] [PATCH v5 17/19] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT

2023-02-28 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 9:26 PM > > On Tue, Feb 28, 2023 at 01:22:50PM +, Liu, Yi L wrote: > > > > A null iommufd pointer and a bound df flag is sufficient to see that > > > it is compat mode. > > > > Hope df->is_cdev_device suits your expectation.:-) The c

Re: [Intel-gfx] [PATCH v5 17/19] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT

2023-02-28 Thread Jason Gunthorpe
On Tue, Feb 28, 2023 at 01:36:24PM +, Liu, Yi L wrote: > > From: Jason Gunthorpe > > Sent: Tuesday, February 28, 2023 9:26 PM > > > > On Tue, Feb 28, 2023 at 01:22:50PM +, Liu, Yi L wrote: > > > > > > A null iommufd pointer and a bound df flag is sufficient to see that > > > > it is comp

Re: [Intel-gfx] [PATCH v5 17/19] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT

2023-02-28 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, February 28, 2023 9:44 PM > > On Tue, Feb 28, 2023 at 01:36:24PM +, Liu, Yi L wrote: > > > From: Jason Gunthorpe > > > Sent: Tuesday, February 28, 2023 9:26 PM > > > > > > On Tue, Feb 28, 2023 at 01:22:50PM +, Liu, Yi L wrote: > > > > > > > > A nu

Re: [Intel-gfx] [PATCH] drm/shmem-helper: Fix compile error

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Andi Shyti wrote: > Hi Dmitry, > > On Tue, Feb 28, 2023 at 04:15:28PM +0300, Dmitry Osipenko wrote: >> Hi, >> >> On 2/28/23 15:50, Andi Shyti wrote: >> > Commit 67b7836d4458 ("drm/shmem-helper: Switch to reservation >> > lock") removes the drm_gem_shmem_get_pages_locked() and

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-02-28 Thread Matthew Auld
On 27/02/2023 17:19, Jonathan Cavitt wrote: Convert the igt_mock_ppgtt_huge_fill and igt_mock_ppgtt_64K mock selftests into live selftests as their requirements have recently become platform-dependent. Additionally, apply necessary platform dependency checks to these tests. v2: Reorder Signed-o

Re: [Intel-gfx] [PATCH] drm/shmem-helper: Fix compile error

2023-02-28 Thread Andi Shyti
Hi, > >> > Commit 67b7836d4458 ("drm/shmem-helper: Switch to reservation > >> > lock") removes the drm_gem_shmem_get_pages_locked() and > >> > drm_gem_shmem_put_pages_locked(). > >> > > >> > But then commit edaa0db9 ("drm/shmem-helper: Fix locking for > >> > drm_gem_shmem_get_pages_sgt()") re

Re: [Intel-gfx] [PATCH v5 17/19] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT

2023-02-28 Thread Jason Gunthorpe
On Tue, Feb 28, 2023 at 02:01:36PM +, Liu, Yi L wrote: > > From: Jason Gunthorpe > > Sent: Tuesday, February 28, 2023 9:44 PM > > > > On Tue, Feb 28, 2023 at 01:36:24PM +, Liu, Yi L wrote: > > > > From: Jason Gunthorpe > > > > Sent: Tuesday, February 28, 2023 9:26 PM > > > > > > > > On T

Re: [Intel-gfx] [PATCH] drm/shmem-helper: Fix compile error

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Andi Shyti wrote: > Hi, > >> >> > Commit 67b7836d4458 ("drm/shmem-helper: Switch to reservation >> >> > lock") removes the drm_gem_shmem_get_pages_locked() and >> >> > drm_gem_shmem_put_pages_locked(). >> >> > >> >> > But then commit edaa0db9 ("drm/shmem-helper: Fix locki

Re: [Intel-gfx] [PATCH 03/10] drm/i915/dsc: move DSC tables to DRM DSC helper

2023-02-28 Thread kernel test robot
Hi Dmitry, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm/drm-next linus/master v6.2 next-20230228] [If your patch is applied to the wrong git tree

Re: [Intel-gfx] [PATCH] drm/shmem-helper: Fix compile error

2023-02-28 Thread Saarinen, Jani
Hi, > -Original Message- > From: Nikula, Jani > Sent: tiistai 28. helmikuuta 2023 16.40 > To: Andi Shyti > Cc: Andi Shyti ; Dmitry Osipenko > ; dri-de...@lists.freedesktop.org; Maarten > Lankhorst ; Maxime Ripard > ; Thomas Zimmermann ; David > Airlie ; Daniel Vetter ; Javier Martinez >

Re: [Intel-gfx] [PATCH] drm/shmem-helper: Fix compile error

2023-02-28 Thread Dmitry Osipenko
On 2/28/23 17:40, Jani Nikula wrote: ... >>> And the build is indeed currently broken. >>> >>> Moreover, when the build was fine for a while, apparently the changes in >>> shmem broke a bunch of machines in Intel CI. And due to this, we aren't >>> getting any CI results for incoming patches right n

Re: [Intel-gfx] [PATCH] drm/shmem-helper: Fix compile error

2023-02-28 Thread Andi Shyti
Hi, > > >> >> > Commit 67b7836d4458 ("drm/shmem-helper: Switch to reservation > > >> >> > lock") removes the drm_gem_shmem_get_pages_locked() and > > >> >> > drm_gem_shmem_put_pages_locked(). > > >> >> > > > >> >> > But then commit edaa0db9 ("drm/shmem-helper: Fix locking for > > >> >> > drm_g

Re: [Intel-gfx] [PATCH 03/10] drm/i915/dsc: move DSC tables to DRM DSC helper

2023-02-28 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Baryshkov/drm-i915-dsc-change-DSC-param-tables-to-follow-the-DSC-model/20230228-193505 b

[Intel-gfx] [PATCH] Revert "drm/shmem-helper: Switch to reservation lock"

2023-02-28 Thread Thomas Zimmermann
This reverts commit 67b7836d4458790f1261e31fe0ce3250989784f0. The locking appears incomplete. A caller of SHMEM helper's pin function never acquires the dma-buf reservation lock. So we get WARNING: CPU: 3 PID: 967 at drivers/gpu/drm/drm_gem_shmem_helper.c:243 drm_gem_shmem_pin+0x42/0x90 [drm_s

Re: [Intel-gfx] [PATCH] Revert "drm/shmem-helper: Switch to reservation lock"

2023-02-28 Thread Dmitry Osipenko
On 2/28/23 18:26, Thomas Zimmermann wrote: > This reverts commit 67b7836d4458790f1261e31fe0ce3250989784f0. > > The locking appears incomplete. A caller of SHMEM helper's pin > function never acquires the dma-buf reservation lock. So we get > > WARNING: CPU: 3 PID: 967 at drivers/gpu/drm/drm_gem

Re: [Intel-gfx] [PATCH v7 00/15] dma-fence: Deadline awareness

2023-02-28 Thread Rob Clark
On Tue, Feb 28, 2023 at 4:43 AM Bagas Sanjaya wrote: > > On Mon, Feb 27, 2023 at 11:35:06AM -0800, Rob Clark wrote: > > From: Rob Clark > > > > This series adds a deadline hint to fences, so realtime deadlines > > such as vblank can be communicated to the fence signaller for power/ > > frequency

Re: [Intel-gfx] [PATCH] Revert "drm/shmem-helper: Switch to reservation lock"

2023-02-28 Thread Thomas Zimmermann
Hi Am 28.02.23 um 16:28 schrieb Dmitry Osipenko: On 2/28/23 18:26, Thomas Zimmermann wrote: This reverts commit 67b7836d4458790f1261e31fe0ce3250989784f0. The locking appears incomplete. A caller of SHMEM helper's pin function never acquires the dma-buf reservation lock. So we get WARNING:

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/shmem-helper: Switch to reservation lock"

2023-02-28 Thread Patchwork
== Series Details == Series: Revert "drm/shmem-helper: Switch to reservation lock" URL : https://patchwork.freedesktop.org/series/114478/ State : success == Summary == CI Bug Log - changes from CI_DRM_12790 -> Patchwork_114478v1 Summary ---

Re: [Intel-gfx] [PATCH 01/10] drm/i915/dsc: change DSC param tables to follow the DSC model

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > After cross-checking DSC models (20150914, 20161212, 20210623) change > values in rc_parameters tables to follow config files present inside > the DSC model. Handle two places, where i915 tables diverged from the > model, by patching the rc values in

Re: [Intel-gfx] [PATCH] Revert "drm/shmem-helper: Switch to reservation lock"

2023-02-28 Thread Saarinen, Jani
> -Original Message- > From: Intel-gfx On Behalf Of Thomas > Zimmermann > Sent: tiistai 28. helmikuuta 2023 17.46 > To: Dmitry Osipenko ; > maarten.lankho...@linux.intel.com; airl...@gmail.com; dan...@ffwll.ch; Nikula, > Jani > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freede

Re: [Intel-gfx] [PATCH 02/10] drm/i915/dsc: move rc_buf_thresh values to common helper

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > The rc_buf_thresh values are common to all DSC implementations. Move > them to the common helper together with the code to propagage them to > the drm_dsc_config. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dsc_helper.c

Re: [Intel-gfx] [PATCH 01/10] drm/i915/dsc: change DSC param tables to follow the DSC model

2023-02-28 Thread Dmitry Baryshkov
On 28/02/2023 17:56, Jani Nikula wrote: On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: After cross-checking DSC models (20150914, 20161212, 20210623) change values in rc_parameters tables to follow config files present inside the DSC model. Handle two places, where i915 tables diverged from the m

Re: [Intel-gfx] [PATCH 03/10] drm/i915/dsc: move DSC tables to DRM DSC helper

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > This moves DSC RC tables to DRM DSC helper. No additional code changes > and/or cleanups are a part of this commit, it will be cleaned up in the > followup commits. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dsc_helper.c

Re: [Intel-gfx] [PATCH 04/10] drm/i915/dsc: stop using interim structure for calculated params

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > Stop using an interim structure rc_parameters for storing calculated > params and then setting drm_dsc_config using that structure. Instead put > calculated params into the struct drm_dsc_config directly. > > Signed-off-by: Dmitry Baryshkov > --- >

Re: [Intel-gfx] [PATCH 05/10] drm/display/dsc: use flat array for rc_parameters lookup

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > Next commits are going to add support for additional RC parameter lookup > tables. These tables are going to use different bpp/bpc combinations, > thus it makes little sense to keep the 2d array for RC parameters. > Switch to using the flat array. > >

Re: [Intel-gfx] [PATCH 07/10] drm/display/dsc: include the rest of pre-SCR parameters

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > DSC model contains pre-SCR RC parameters for other bpp/bpc combinations, > include them here for completeness. Need to run now, note to self: Does i915 use the arrays to limit the bpp/bpc combos supported by hardware? Do we need to add separate limi

Re: [Intel-gfx] [PATCH 06/10] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-02-28 Thread Jani Nikula
On Tue, 28 Feb 2023, Dmitry Baryshkov wrote: > The array of rc_parameters contains a mixture of parameters from DSC 1.1 > and DSC 1.2 standards. Split these tow configuration arrays in > preparation to adding more configuration data. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/di

Re: [Intel-gfx] [PATCH v5 00/19] Add vfio_device cdev for iommufd support

2023-02-28 Thread Xu, Terrence
> From: Liu, Yi L > Sent: Tuesday, February 28, 2023 11:03 AM > > From: Jason Gunthorpe > > Sent: Tuesday, February 28, 2023 3:21 AM > > > > On Mon, Feb 27, 2023 at 03:11:16AM -0800, Yi Liu wrote: > > > Existing VFIO provides group-centric user APIs for userspace. > > > Userspace opens the /dev/v

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert "drm/shmem-helper: Switch to reservation lock"

2023-02-28 Thread Patchwork
== Series Details == Series: Revert "drm/shmem-helper: Switch to reservation lock" URL : https://patchwork.freedesktop.org/series/114478/ State : success == Summary == CI Bug Log - changes from CI_DRM_12790_full -> Patchwork_114478v1_full S

Re: [Intel-gfx] [PATCH v3 01/22] drm/i915: Populate dig_port->connected() before connector init

2023-02-28 Thread Jani Nikula
On Wed, 22 Feb 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > We'll need dig_port->connected() to be there for a HPD live > state check during eDP connector probing. Reorder intel_ddi_init() > accordingly. g4x_dp_init() is already fine. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani N

Re: [Intel-gfx] [PATCH v3 02/22] drm/i915: Fix SKL DDI A digital port .connected()

2023-02-28 Thread Jani Nikula
On Wed, 22 Feb 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > SKL doesn't have any north DE hotplug stuff. Currently we're > trying to read DDI A live state from the BDW north DE bit, > instead of the approproate south DE bit. Fix it. > > And for good measure clear the pointer to the north

Re: [Intel-gfx] [PATCH v3 03/22] drm/i915: Get rid of the gm45 HPD live state nonsense

2023-02-28 Thread Jani Nikula
On Wed, 22 Feb 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > The idea that ctg uses different HPD live state bits is > total nonsense, at least on my machine (Dell Latitude > E5400). > > The only reason DP-B even works on my ctg is that DP-D > live state is stuck high, even though there is

Re: [Intel-gfx] [PATCH v3 04/22] drm/i915: Introduce _hotplug_mask()

2023-02-28 Thread Jani Nikula
On Wed, 22 Feb 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Pair each _hotplug_enables() function with > a corresponding _hotplug_mask() function so that > we can determine right bits to clear on a per hpd_pin basis. > We'll need this for turning on HPD sense for a specific > encoder rath

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Whitelist COMMON_SLICE_CHICKEN3 for UMD access

2023-02-28 Thread Gustavo Sousa
On Thu, Feb 23, 2023 at 04:22:59PM -0800, Matt Roper wrote: > A recommended tuning setting for both gen12 and Xe_HP platforms requires > that we grant userspace r/w access to the COMMON_SLICE_CHICKEN3 > register. > > Bspec: 73993, 73994, 31870, 68331 > Cc: Dongwon Kim > Signed-off-by: Matt Roper

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Stop whitelisting CS_CTX_TIMESTAMP on Xe_HP platforms

2023-02-28 Thread Gustavo Sousa
On Thu, Feb 23, 2023 at 04:23:00PM -0800, Matt Roper wrote: > Xe_HP architecture already makes the CS_CTX_TIMESTAMP readable by > userspace on all engines; there's no longer a need to add it to the > software-managed whitelist for the non-RCS engines. > > Bspec: 45545 > Signed-off-by: Matt Roper

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Whitelist COMMON_SLICE_CHICKEN3 for UMD access

2023-02-28 Thread Gustavo Sousa
On Tue, Feb 28, 2023 at 04:42:43PM -0300, Gustavo Sousa wrote: > On Thu, Feb 23, 2023 at 04:22:59PM -0800, Matt Roper wrote: > > A recommended tuning setting for both gen12 and Xe_HP platforms requires > > that we grant userspace r/w access to the COMMON_SLICE_CHICKEN3 > > register. > > > > Bspec:

Re: [Intel-gfx] [PATCH v3 04/22] drm/i915: Introduce _hotplug_mask()

2023-02-28 Thread Ville Syrjälä
On Tue, Feb 28, 2023 at 08:36:16PM +0200, Jani Nikula wrote: > On Wed, 22 Feb 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Pair each _hotplug_enables() function with > > a corresponding _hotplug_mask() function so that > > we can determine right bits to clear on a per hpd_pin basis.

Re: [Intel-gfx] [PATCH] drm/edid: Fix csync detailed mode parsing

2023-02-28 Thread Jani Nikula
On Mon, 27 Feb 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Remove the bogus csync check and replace it with something that: > - triggers for all forms of csync, not just the basic analog variant > - actually populates the mode csync flags so that drivers can > decide what to do with th

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Whitelist COMMON_SLICE_CHICKEN3 for UMD access

2023-02-28 Thread Matt Roper
On Fri, Feb 24, 2023 at 07:27:09AM +, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] drm/i915: Whitelist COMMON_SLICE_CHICKEN3 > for UMD access > URL : https://patchwork.freedesktop.org/series/114317/ > State : success > > == Summary == > > CI Bug Log - cha

Re: [Intel-gfx] [PATCH] drm/edid: Fix csync detailed mode parsing

2023-02-28 Thread Ville Syrjälä
On Tue, Feb 28, 2023 at 10:10:26PM +0200, Jani Nikula wrote: > On Mon, 27 Feb 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Remove the bogus csync check and replace it with something that: > > - triggers for all forms of csync, not just the basic analog variant > > - actually populat

Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2023-02-28 Thread Dixit, Ashutosh
On Fri, 12 Aug 2022 11:06:58 -0700, Guenter Roeck wrote: > Hi Guenter/linux-hwmon, > On 8/12/22 10:37, Badal Nilawar wrote: > > From: Dale B Stimson > > > > Use i915 HWMON to display/modify dGfx power PL1 limit and TDP setting. > > /snip/ > > Acked-by: Guenter Roeck > > > --- > > .../ABI/t

[Intel-gfx] [PATCH v2] drm/edid: Fix csync detailed mode parsing

2023-02-28 Thread Ville Syrjala
From: Ville Syrjälä Remove the bogus csync check and replace it with something that: - triggers for all forms of csync, not just the basic analog variant - actually populates the mode csync flags so that drivers can decide what to do with the mode Originally the code tried to outright reject c

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/sseu: fix max_subslices array-index-out-of-bounds access (rev4)

2023-02-28 Thread Patchwork
== Series Details == Series: drm/i915/sseu: fix max_subslices array-index-out-of-bounds access (rev4) URL : https://patchwork.freedesktop.org/series/114199/ State : warning == Summary == Error: dim checkpatch failed ae91b70fbe2e drm/i915/sseu: fix max_subslices array-index-out-of-bounds access

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/sseu: fix max_subslices array-index-out-of-bounds access (rev4)

2023-02-28 Thread Patchwork
== Series Details == Series: drm/i915/sseu: fix max_subslices array-index-out-of-bounds access (rev4) URL : https://patchwork.freedesktop.org/series/114199/ State : success == Summary == CI Bug Log - changes from CI_DRM_12794 -> Patchwork_114199v4 ==

Re: [Intel-gfx] [PATCH v3 7/9] drm/i915/perf: Handle non-power-of-2 reports

2023-02-28 Thread Dixit, Ashutosh
On Mon, 27 Feb 2023 18:23:27 -0800, Umesh Nerlige Ramappa wrote: > > Some of the newer OA formats are not powers of 2. For those formats, > adjust the hw_tail accordingly when checking for new reports. > > v2: (Ashutosh) > - Switch to OA_TAKEN for diff calculation > - Use OA_BUFFER_SIZE instead of

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid: Fix csync detailed mode parsing (rev2)

2023-02-28 Thread Patchwork
== Series Details == Series: drm/edid: Fix csync detailed mode parsing (rev2) URL : https://patchwork.freedesktop.org/series/114424/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v8 00/16] dma-fence: Deadline awareness

2023-02-28 Thread Rob Clark
From: Rob Clark This series adds a deadline hint to fences, so realtime deadlines such as vblank can be communicated to the fence signaller for power/ frequency management decisions. This is partially inspired by a trick i915 does, but implemented via dma-fence for a couple of reasons: 1) To co

[Intel-gfx] [PATCH v8 16/16] drm/i915: Add deadline based boost support

2023-02-28 Thread Rob Clark
From: Rob Clark v2: rebase Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/i915_request.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 7503dcb9043b..44491e7e214c 100644 --- a/drivers

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: Fix csync detailed mode parsing (rev2)

2023-02-28 Thread Patchwork
== Series Details == Series: drm/edid: Fix csync detailed mode parsing (rev2) URL : https://patchwork.freedesktop.org/series/114424/ State : success == Summary == CI Bug Log - changes from CI_DRM_12794 -> Patchwork_114424v2 Summary ---

Re: [Intel-gfx] [PATCH v4 03/22] drm/i915/mtl: Create separate reg file for PICA registers

2023-02-28 Thread Lucas De Marchi
On Fri, Feb 24, 2023 at 12:13:37PM +0200, Mika Kahola wrote: Create a separate file to store registers for PICA chips C10 and C20. v2: Rename file (Jani) Signed-off-by: Radhakrishna Sripada Signed-off-by: Mika Kahola --- .../gpu/drm/i915/display/intel_cx0_phy_regs.h | 136 ++ 1

[Intel-gfx] [PATCH] drm/i915/gt: Create per-tile debugfs files

2023-02-28 Thread Andi Shyti
To support multi-GT configurations, we need to generate independent debug files for each GT. To achieve this create a separate directory for each GT under the debugfs directory. For instance, in a system with four tiles, the debugfs structure would look like this: /sys/kernel/debug/dri

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/sseu: fix max_subslices array-index-out-of-bounds access (rev4)

2023-02-28 Thread Patchwork
== Series Details == Series: drm/i915/sseu: fix max_subslices array-index-out-of-bounds access (rev4) URL : https://patchwork.freedesktop.org/series/114199/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12794_full -> Patchwork_114199v4_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: Create per-tile debugfs files

2023-02-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Create per-tile debugfs files URL : https://patchwork.freedesktop.org/series/114495/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Create per-tile debugfs files

2023-02-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Create per-tile debugfs files URL : https://patchwork.freedesktop.org/series/114495/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12794 -> Patchwork_114495v1 Summary --- **F

Re: [Intel-gfx] [PATCH v5 00/19] Add vfio_device cdev for iommufd support

2023-02-28 Thread Nicolin Chen
On Tue, Feb 28, 2023 at 04:58:06PM +, Xu, Terrence wrote: > Verified this series by "Intel GVT-g GPU device mediated passthrough" and > "Intel GVT-d GPU device direct passthrough" technologies. > Both passed VFIO legacy mode / compat mode / cdev mode, including negative > tests. > > Tested-

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/edid: Fix csync detailed mode parsing (rev2)

2023-02-28 Thread Patchwork
== Series Details == Series: drm/edid: Fix csync detailed mode parsing (rev2) URL : https://patchwork.freedesktop.org/series/114424/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12794_full -> Patchwork_114424v2_full Summar

  1   2   >