Re: [Intel-gfx] [PATCH] drm/i915: Add missing check and destroy for alloc_workqueue

On Fri, Jan 06, 2023 at 05:09:34PM +0800, Jiasheng Jiang wrote: > Add checks for the return value of alloc_workqueue and > alloc_ordered_workqueue as they may return NULL pointer and cause NULL > pointer dereference. > Moreover, destroy them when fails later in order to avoid memory leak. > Because

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix potential context UAFs (rev2)

== Series Details == Series: drm/i915: Fix potential context UAFs (rev2) URL : https://patchwork.freedesktop.org/series/112383/ State : success == Summary == CI Bug Log - changes from CI_DRM_12546_full -> Patchwork_112383v2_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Fix potential context UAFs

On 05/01/2023 16:00, Tvrtko Ursulin wrote: On 05/01/2023 15:52, Andi Shyti wrote: Hi Rob, On Tue, Jan 03, 2023 at 03:49:46PM -0800, Rob Clark wrote: From: Rob Clark gem_context_register() makes the context visible to userspace, and which point a separate thread can trigger the I915_GEM_CO

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Display clamped PL1 limit

On 12/16/2022 12:47 AM, Ashutosh Dixit wrote: HW allows arbitrary PL1 limits to be set but silently clamps these values to "typical but not guaranteed" min/max values in pkg_power_sku register. Follow the same pattern for sysfs, allow arbitrary PL1 limits to be set but display clamped values w

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/fbdev: Implement fb_dirty for intel custom fb helper (rev3)

== Series Details == Series: drm/i915/fbdev: Implement fb_dirty for intel custom fb helper (rev3) URL : https://patchwork.freedesktop.org/series/111433/ State : success == Summary == CI Bug Log - changes from CI_DRM_12548_full -> Patchwork_111433v3_full

[Intel-gfx] [PATCH v2] drm/i915: Do not cover all future platforms in TLB invalidation

From: Tvrtko Ursulin Revert to the original explicit approach and document the reasoning behind it. v2: * DG2 needs to be covered too. (Matt) Signed-off-by: Tvrtko Ursulin Cc: Matt Roper Cc: Balasubramani Vivekanandan Cc: Andrzej Hajda Reviewed-by: Andrzej Hajda # v1 --- Matt, does DG1 ne

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hwmon: Display clamped PL1 limit (rev2)

On 12/16/2022 8:46 PM, Patchwork wrote: *Patch Details* *Series:* drm/i915/hwmon: Display clamped PL1 limit (rev2) *URL:* https://patchwork.freedesktop.org/series/111981/ *State:*success *Details:* https://intel-gfx-ci.01.org/t

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Update docs in intel_wakeref.h

== Series Details == Series: drm/i915: Update docs in intel_wakeref.h URL : https://patchwork.freedesktop.org/series/112454/ State : success == Summary == CI Bug Log - changes from CI_DRM_12550_full -> Patchwork_112454v1_full Summary --

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: Add initial gt workarounds (rev2)

== Series Details == Series: drm/i915/mtl: Add initial gt workarounds (rev2) URL : https://patchwork.freedesktop.org/series/111994/ State : success == Summary == CI Bug Log - changes from CI_DRM_12550_full -> Patchwork_111994v2_full Summary

Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Add initial gt workarounds

On Thu, Jan 05, 2023 at 03:44:08PM -0800, Matt Atwood wrote: > From: Matt Roper > > This patch introduces initial gt workarounds for the MTL platform. > > v2: drop redundant/stale comments specifying wa platforms affected > (Lucas). > v3: drop additional redundant stale comments (MattR) > > Bsp

Re: [Intel-gfx] [PATCH] drm/i915: Update docs in intel_wakeref.h

On Thu, Jan 05, 2023 at 12:46:17PM -0800, Dixit, Ashutosh wrote: 11;rgb://> On Thu, 05 Jan 2023 12:38:43 -0800, Nirmoy Das wrote: > > > > Fix docs for __intel_wakeref_put() and intel_wakeref_get() to > > reflect current behaviour. > > Reviewed-by: Ashutosh Dixit pushed, thanks for th

Re: [Intel-gfx] [PATCH v3 11/11] drm/i915: replace Intel internal tracker with kernel core ref_tracker

Hi Andrzej, On 2/22/2022 12:25 AM, Andrzej Hajda wrote: Beside reusing existing code, the main advantage of ref_tracker is tracking per instance of wakeref. It allows also to catch double put. On the other side we lose information about the first acquire and the last release, but the advantages

Re: [Intel-gfx] [PATCH v3 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM

On Thu, Jan 05, 2023 at 08:03:32PM -0500, Matthew Rosato wrote: > On 1/5/23 7:32 PM, Jason Gunthorpe wrote: > > On Thu, Jan 05, 2023 at 07:16:37PM -0500, Matthew Rosato wrote: > > > >> Yeah, this is also what I was thinking, replace the direct > >> kvm_put_kvm calls with, say, schedule_delayed_wor

Re: [Intel-gfx] [PATCH v2 4/9] drm/i915/display/phys: use intel_de_rmw if possible

On Thu, Jan 05, 2023 at 02:10:41PM +0100, Andrzej Hajda wrote: > The helper makes the code more compact and readable. > > Signed-off-by: Andrzej Hajda Reviewed-by: Rodrigo Vivi > --- > .../gpu/drm/i915/display/intel_combo_phy.c| 43 +--- > drivers/gpu/drm/i915/display/intel_dpi

Re: [Intel-gfx] [PATCH v2 5/9] drm/i915/display/pch: use intel_de_rmw if possible

On Thu, Jan 05, 2023 at 02:10:42PM +0100, Andrzej Hajda wrote: > The helper makes the code more compact and readable. > > Signed-off-by: Andrzej Hajda Reviewed-by: Rodrigo Vivi > --- > .../gpu/drm/i915/display/intel_pch_display.c | 41 +-- > .../gpu/drm/i915/display/intel_pch_

Re: [Intel-gfx] [PATCH v2 6/9] drm/i915/display/hdmi: use intel_de_rmw if possible

On Thu, Jan 05, 2023 at 02:10:43PM +0100, Andrzej Hajda wrote: > The helper makes the code more compact and readable. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/i915/display/g4x_hdmi.c | 8 ++--- > drivers/gpu/drm/i915/display/intel_hdcp.c | 15 - > drivers/gpu/drm/i915/

[Intel-gfx] ✓ Fi.CI.BAT: success for Defeature Interlace modes for Display >= 12 (rev4)

== Series Details == Series: Defeature Interlace modes for Display >= 12 (rev4) URL : https://patchwork.freedesktop.org/series/109773/ State : success == Summary == CI Bug Log - changes from CI_DRM_12553 -> Patchwork_109773v4 Summary --

Re: [Intel-gfx] [PATCH v2] drm/i915: Do not cover all future platforms in TLB invalidation

On Fri, Jan 06, 2023 at 10:38:35AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Revert to the original explicit approach and document the reasoning > behind it. > > v2: > * DG2 needs to be covered too. (Matt) > > Signed-off-by: Tvrtko Ursulin > Cc: Matt Roper > Cc: Balasubramani V

Re: [Intel-gfx] [PULL] drm-intel-fixes

On Thu, Jan 05, 2023 at 03:02:20PM -0500, Rodrigo Vivi wrote: > Hi Dave and Daniel, > > Only GVT related fixes for this round. > > I have another fix queued for i915_vma_unbind_async from Nirmoy that will > target stable 5.18, but I figured it out late so I didn't run CI on that yet. > So I'm hol

[Intel-gfx] ✓ Fi.CI.IGT: success for Defeature Interlace modes for Display >= 12 (rev4)

== Series Details == Series: Defeature Interlace modes for Display >= 12 (rev4) URL : https://patchwork.freedesktop.org/series/109773/ State : success == Summary == CI Bug Log - changes from CI_DRM_12553_full -> Patchwork_109773v4_full Summ

Re: [Intel-gfx] [PATCH] drm/i915: Add missing check and destroy for alloc_workqueue

On Fri, Jan 06, 2023 at 05:09:34PM +0800, Jiasheng Jiang wrote: > Add checks for the return value of alloc_workqueue and > alloc_ordered_workqueue as they may return NULL pointer and cause NULL > pointer dereference. > Moreover, destroy them when fails later in order to avoid memory leak. > Because

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers

On 12/6/2022 03:06, Tvrtko Ursulin wrote: On 05/12/2022 18:44, Michal Wajdeczko wrote: On 05.12.2022 14:16, Tvrtko Ursulin wrote: On 02/12/2022 20:14, John Harrison wrote: [snip] Random meaningless (to me) message that is apparently a display thing: drm_dbg_kms(&dev_priv->drm, "disabling %s\n

Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Add initial gt workarounds

Pushed with the nit's fixed. Thanks for the patch and review. - Radhakrishna(RK) Sripada > -Original Message- > From: Intel-gfx On Behalf Of Rodrigo > Vivi > Sent: Friday, January 6, 2023 5:04 AM > To: Atwood, Matthew S > Cc: intel-gfx@lists.freedesktop.org; De Marchi, Lucas > > Subjec

Re: [Intel-gfx] [PATCH v3] drm/i915/mtl: Add initial gt workarounds

On Fri, 2023-01-06 at 19:33 +, Sripada, Radhakrishna wrote: Pushed with the nit's fixed. Thanks for the patch and review. Next time please modify, resend and wait the BAT. We had seen cases in the past where the modification ended in a bad code that broken compilation and everyone else. Small

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/mtl: Add initial gt workarounds (rev4)

== Series Details == Series: drm/i915/mtl: Add initial gt workarounds (rev4) URL : https://patchwork.freedesktop.org/series/111994/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/111994/revisions/4/mbox/ not applied Applying: drm/i915/mtl: Add ini

Re: [Intel-gfx] [PATCH 03/27] drm/i915/gvt: Incorporate KVM memslot info into check for 2MiB GTT entry

On Fri, Jan 06, 2023, Yan Zhao wrote: > On Thu, Jan 05, 2023 at 05:40:32PM +, Sean Christopherson wrote: > > On Thu, Jan 05, 2023, Yan Zhao wrote: > > I'm totally fine if KVMGT's ABI is that VFIO is the source of truth for > > mappings > > and permissions, and that the only requirement for KVM

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On Thu, Jan 05, 2023 at 09:43:41PM +, Matthew Brost wrote: > On Tue, Jan 03, 2023 at 01:02:15PM +, Tvrtko Ursulin wrote: > > > > On 02/01/2023 07:30, Boris Brezillon wrote: > > > On Fri, 30 Dec 2022 12:55:08 +0100 > > > Boris Brezillon wrote: > > > > > > > On Fri, 30 Dec 2022 11:20:42 +0

Re: [Intel-gfx] [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

On Thu, Jan 05, 2023 at 01:35:52PM +, Tvrtko Ursulin wrote: > > Okay to sum it up below with some final notes.. > > On 04/01/2023 19:34, Matt Roper wrote: > > On Wed, Jan 04, 2023 at 09:58:13AM +, Tvrtko Ursulin wrote: > > > > > > On 23/12/2022 18:28, Lucas De Marchi wrote: > > > > On Fr

[Intel-gfx] [RFC 0/2] Add new CDCLK step for RPL-U

A new step of 480MHz has been added on SKUs that have an RPL-U device id. This particular step is to support 120Hz panels more efficiently. This patchset adds a new table to include this new CDCLK step. Details can be found in BSpec entry 55409. Create a new sub-platform to identify RPL-U which w

[Intel-gfx] [RFC 1/2] drm/i915: Add rplu sub platform

Adding RPL-U as a sub platform. In RPL-U a new CDCLK step has been added so we need to make a distinction between RPL-P and RPL-U while CDCLK initialization. Adding a sub-platform, enables us to make this differentiation in the code. Signed-off-by: Chaitanya Kumar Borah --- arch/x86/kernel/earl

[Intel-gfx] [RFC 2/2] drm/i915/display: Add 480 MHz CDCLK steps for RPL-U

A new step of 480MHz has been added on SKUs that have a RPL-U device id to support 120Hz displays more efficiently. Use a new quirk to identify the machine for which this change needs to be applied. BSpec: 55409 Signed-off-by: Chaitanya Kumar Borah --- drivers/gpu/drm/i915/display/intel_cdclk.c

Re: [Intel-gfx] [RFC 1/4] drm/i915/quirks: Add quirk for 480MHz CDCLK step

Hello Jani, > -Original Message- > From: Jani Nikula > Sent: Monday, January 2, 2023 3:34 PM > To: Borah, Chaitanya Kumar ; intel- > g...@lists.freedesktop.org > Cc: Deak, Imre ; Kahola, Mika > ; Shankar, Uma ; > Syrjala, Ville ; Srivatsa, Anusha > ; Borah, Chaitanya Kumar > > Subject: R

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add new CDCLK step for RPL-U (rev3)

== Series Details == Series: Add new CDCLK step for RPL-U (rev3) URL : https://patchwork.freedesktop.org/series/111472/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.