Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Use "%zu" to format size_t

2023-01-03 Thread Gwan-gyeong Mun
This fix has nothing to do with IGT Possible regression. This fixes the code that raised build warnings in 32-bit environments. And this patch has been merged. On 12/30/22 9:37 PM, Patchwork wrote: *Patch Details* *Series:* drm/i915: Use "%zu" to format size_t *URL:* https://patchwork.fr

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Use "%zu" to format size_t

2023-01-03 Thread Das, Nirmoy
Yes makes sense, thanks, G.G. On 1/3/2023 9:11 AM, Gwan-gyeong Mun wrote: This fix has nothing to do with IGT Possible regression. This fixes the code that raised build warnings in 32-bit environments. And this patch has been merged. On 12/30/22 9:37 PM, Patchwork wrote: *Patch Details* *Ser

Re: [Intel-gfx] [PATCH v2] drm/i915: dell wyse 3040 shutdown fix

2023-01-03 Thread Jani Nikula
On Mon, 02 Jan 2023, Alexey Lukyachuk wrote: > Regarding to your question about fdo gitlab, I went to do it. What's the URL for the issue? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH v2] drm/i915: dell wyse 3040 shutdown fix

2023-01-03 Thread Alexey Lukyachuk
On Tue, 03 Jan 2023 12:14:02 +0200 Jani Nikula wrote: > On Mon, 02 Jan 2023, Alexey Lukyachuk wrote: > > Regarding to your question about fdo gitlab, I went to do it. > > What's the URL for the issue? > > BR, > Jani. > I have not submited issue in bug tracker because I found solution in git.

Re: [Intel-gfx] [PATCH] drm/i915/display: Check source height is > 0

2023-01-03 Thread Juha-Pekka Heikkila
Hi Drew, this is good find. I went looking where the problem is in and saw what you probably also saw earlier. I was wondering if diff below would be better fix? I assume this would end up with einval or erange in your case but code flow otherwise would stay as is while fixing all future cal

[Intel-gfx] [PULL] drm-misc-next

2023-01-03 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the first PR for drm-misc-next for the upcomming version v6.3 of the Linux kernel. Overall, it's fairly small; due to holidays, I guess. Noteworthy changes are in connector TV-mode handling, KUnit tests and MIPI helpers. Best regards Thomas drm-misc-next-2023-01-03: dr

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/display: Check source height is > 0 (rev2)

2023-01-03 Thread Patchwork
== Series Details == Series: drm/i915/display: Check source height is > 0 (rev2) URL : https://patchwork.freedesktop.org/series/112237/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/112237/revisions/2/mbox/ not applied Applying: drm/i915/display:

Re: [Intel-gfx] [cache coherency bug] i915 and PAT attributes

2023-01-03 Thread Demi Marie Obenour
On Mon, Jan 02, 2023 at 12:24:54AM +0100, Marek Marczykowski-Górecki wrote: > On Thu, Dec 22, 2022 at 10:29:57AM +0200, Ville Syrjälä wrote: > > On Fri, Dec 16, 2022 at 03:30:13PM +, Andrew Cooper wrote: > > > On 08/12/2022 1:55 pm, Marek Marczykowski-Górecki wrote: > > > > Hi, > > > > > > > >

Re: [Intel-gfx] [cache coherency bug] i915 and PAT attributes

2023-01-03 Thread Demi Marie Obenour
On Mon, Jan 02, 2023 at 02:00:51AM +0100, Marek Marczykowski-Górecki wrote: > On Sun, Jan 01, 2023 at 07:03:18PM -0500, Demi Marie Obenour wrote: > > On Mon, Jan 02, 2023 at 12:24:54AM +0100, Marek Marczykowski-Górecki wrote: > > > On Thu, Dec 22, 2022 at 10:29:57AM +0200, Ville Syrjälä wrote: > >

Re: [Intel-gfx] [cache coherency bug] i915 and PAT attributes

2023-01-03 Thread Demi Marie Obenour
On Sun, Jan 01, 2023 at 08:17:52PM -0500, Demi Marie Obenour wrote: > On Mon, Jan 02, 2023 at 02:00:51AM +0100, Marek Marczykowski-Górecki wrote: > > On Sun, Jan 01, 2023 at 07:03:18PM -0500, Demi Marie Obenour wrote: > > > On Mon, Jan 02, 2023 at 12:24:54AM +0100, Marek Marczykowski-Górecki > > >

Re: [Intel-gfx] [PATCH v3] arch: rename all internal names __xchg to __arch_xchg

2023-01-03 Thread Heiko Carstens
On Fri, Dec 30, 2022 at 03:15:52PM +0100, Andrzej Hajda wrote: > __xchg will be used for non-atomic xchg macro. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Arnd Bergmann > --- > v2: squashed all arch patches into one > v3: fixed alpha/xchg_local, thx to l...@intel.com > --- ... > arch/s390/

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-01-03 Thread Tvrtko Ursulin
On 22/12/2022 22:21, Matthew Brost wrote: Hello, This is a submission for Xe, a new driver for Intel GPUs that supports both integrated and discrete platforms starting with Tiger Lake (first platform with Intel Xe Architecture). The intention of this new driver is to have a fresh base to work

Re: [Intel-gfx] [PATCH v2] drm/i915: dell wyse 3040 shutdown fix

2023-01-03 Thread Rodrigo Vivi
On Mon, Jan 02, 2023 at 04:56:49PM +0300, Alexey Lukyachuk wrote: > On Tue, 27 Dec 2022 20:40:03 +0300 > Alexey Lukyachuk wrote: > > > On Tue, 27 Dec 2022 11:39:25 -0500 > > Rodrigo Vivi wrote: > > > > > On Sun, Dec 25, 2022 at 09:55:08PM +0300, Alexey Lukyanchuk wrote: > > > > dell wyse 3040 d

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-03 Thread Tvrtko Ursulin
On 02/01/2023 07:30, Boris Brezillon wrote: On Fri, 30 Dec 2022 12:55:08 +0100 Boris Brezillon wrote: On Fri, 30 Dec 2022 11:20:42 +0100 Boris Brezillon wrote: Hello Matthew, On Thu, 22 Dec 2022 14:21:11 -0800 Matthew Brost wrote: In XE, the new Intel GPU driver, a choice has made

Re: [Intel-gfx] [PATCH v2] drm/i915: dell wyse 3040 shutdown fix

2023-01-03 Thread Jani Nikula
On Tue, 03 Jan 2023, Rodrigo Vivi wrote: > On Mon, Jan 02, 2023 at 04:56:49PM +0300, Alexey Lukyachuk wrote: >> On Tue, 27 Dec 2022 20:40:03 +0300 >> Alexey Lukyachuk wrote: >> >> > On Tue, 27 Dec 2022 11:39:25 -0500 >> > Rodrigo Vivi wrote: >> > >> > > On Sun, Dec 25, 2022 at 09:55:08PM +0300

Re: [Intel-gfx] [PATCH 09/18] vfio-mdev/mdpy-fb: Do not set struct fb_info.apertures

2023-01-03 Thread Thomas Zimmermann
Am 20.12.22 um 10:32 schrieb Javier Martinez Canillas: [adding Kirti Wankhede and k...@vger.kernel.org to Cc list] On 12/19/22 17:05, Thomas Zimmermann wrote: Generic fbdev drivers use the apertures field in struct fb_info to control ownership of the framebuffer memory and graphics device. Do

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-01-03 Thread Boris Brezillon
Hi, On Mon, 02 Jan 2023 13:42:46 +0200 Jani Nikula wrote: > On Mon, 02 Jan 2023, Thomas Zimmermann wrote: > > Hi > > > > Am 22.12.22 um 23:21 schrieb Matthew Brost: > >> Hello, > >> > >> This is a submission for Xe, a new driver for Intel GPUs that supports both > >> integrated and discrete

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-03 Thread Boris Brezillon
Hi, On Tue, 3 Jan 2023 13:02:15 + Tvrtko Ursulin wrote: > On 02/01/2023 07:30, Boris Brezillon wrote: > > On Fri, 30 Dec 2022 12:55:08 +0100 > > Boris Brezillon wrote: > > > >> On Fri, 30 Dec 2022 11:20:42 +0100 > >> Boris Brezillon wrote: > >> > >>> Hello Matthew, > >>> > >>> On Thu,

[Intel-gfx] [PULL] drm-misc-next-fixes

2023-01-03 Thread Maxime Ripard
Hi Daniel, Dave, Here's the drm-misc-next-fixes leftovers. Maxime drm-misc-next-fixes-2023-01-03: The drm-misc-next-fixes leftovers. It addresses a bug in drm/scheduler ending up causing a lockup, and reduces the stack usage of some drm/mm kunit tests. The following changes since commit b02897e5

Re: [Intel-gfx] [PATCH] drm/i915: Enable a PIPEDMC whenever its corresponding pipe is enabled

2023-01-03 Thread Rodrigo Vivi
On Mon, Jan 02, 2023 at 08:33:24PM +0200, Imre Deak wrote: > Make sure that PIPEDMCs are enabled whenever the corresponding pipe is > enabled. > > This is required at least by the latest ADLP v2.18 firmware, which adds > a new handler enabled by default and running whenever the pipe is > enabled a

Re: [Intel-gfx] [PATCH v2] drm/i915: dell wyse 3040 shutdown fix

2023-01-03 Thread Alexey Lukyachuk
On Tue, 3 Jan 2023 07:46:40 -0500 Rodrigo Vivi wrote: > On Mon, Jan 02, 2023 at 04:56:49PM +0300, Alexey Lukyachuk wrote: > > On Tue, 27 Dec 2022 20:40:03 +0300 > > Alexey Lukyachuk wrote: > > > > > On Tue, 27 Dec 2022 11:39:25 -0500 > > > Rodrigo Vivi wrote: > > > > > > > On Sun, Dec 25, 202

Re: [Intel-gfx] [PATCH] drm/i915: Fix timeslots argument for DP DSC SST case

2023-01-03 Thread Rodrigo Vivi
On Mon, Jan 02, 2023 at 03:23:06PM +0200, Stanislav Lisovskiy wrote: > We now accept timeslots param exactly how the variable > sounds: amount of timeslots, but not ratio timeslots/64. > So for SST case(when we have all timeslots for use), it > should be 64, but not 1. I noticed that at intel_dp_d

Re: [Intel-gfx] [PATCH v2] drm/i915: dell wyse 3040 shutdown fix

2023-01-03 Thread Rodrigo Vivi
On Tue, Jan 03, 2023 at 07:09:20PM +0300, Alexey Lukyachuk wrote: > On Tue, 3 Jan 2023 07:46:40 -0500 > Rodrigo Vivi wrote: > > > On Mon, Jan 02, 2023 at 04:56:49PM +0300, Alexey Lukyachuk wrote: > > > On Tue, 27 Dec 2022 20:40:03 +0300 > > > Alexey Lukyachuk wrote: > > > > > > > On Tue, 27 Dec

Re: [Intel-gfx] [PATCH] drm/i915: Implement workaround for DP2 UHBR bandwidth check

2023-01-03 Thread Rodrigo Vivi
on the subject: This is not a hw workaround. Please remove the workaround from the subject and the wrong comment. "The HSD given is a 'feature' rather than 'bugeco' so no workaround details are present here." On Mon, Jan 02, 2023 at 01:39:37PM +0200, Stanislav Lisovskiy wrote: > According to s

Re: [Intel-gfx] [PATCH v4 1/1] drm/i915/dmc: Do not require specific versions

2023-01-03 Thread Rodrigo Vivi
On Fri, Dec 30, 2022 at 03:24:22PM -0300, Gustavo Sousa wrote: > Currently, i915 interacts with the Hardware and not with any DMC > ABI/API, so the API is fixed within the platform, hence no need to get > this so-tied version requirement. > > v2: > - Use link to firmware guide from kernel docume

Re: [Intel-gfx] [PATCH v4 1/1] drm/i915/dmc: Do not require specific versions

2023-01-03 Thread Gustavo Sousa
On Tue, Jan 03, 2023 at 11:34:23AM -0500, Rodrigo Vivi wrote: > On Fri, Dec 30, 2022 at 03:24:22PM -0300, Gustavo Sousa wrote: > > Currently, i915 interacts with the Hardware and not with any DMC > > ABI/API, so the API is fixed within the platform, hence no need to get > > this so-tied version req

Re: [Intel-gfx] [PATCH] drm/i915: Enable a PIPEDMC whenever its corresponding pipe is enabled

2023-01-03 Thread Imre Deak
On Tue, Jan 03, 2023 at 11:01:55AM -0500, Rodrigo Vivi wrote: > On Mon, Jan 02, 2023 at 08:33:24PM +0200, Imre Deak wrote: > > Make sure that PIPEDMCs are enabled whenever the corresponding pipe is > > enabled. > > > > This is required at least by the latest ADLP v2.18 firmware, which adds > > a n

Re: [Intel-gfx] [PATCH] drm/i915: Fix timeslots argument for DP DSC SST case

2023-01-03 Thread Navare, Manasi
On Mon, Jan 02, 2023 at 03:23:06PM +0200, Stanislav Lisovskiy wrote: > We now accept timeslots param exactly how the variable > sounds: amount of timeslots, but not ratio timeslots/64. > So for SST case(when we have all timeslots for use), it > should be 64, but not 1. > This caused some issues in

[Intel-gfx] [PATCH] drm/i915: Expand force_probe to block probe of devices as well.

2023-01-03 Thread Rodrigo Vivi
There are new cases where we want to block i915 probe, such as when experimenting or developing the new Xe driver. But also, with the new hibrid cards, users or developers might want to use i915 only on integrated and fully block the probe of the i915 for the discrete. Or vice versa. Oh, and ther

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow

2023-01-03 Thread Matt Roper
On Mon, Dec 19, 2022 at 05:10:02PM +0100, Andrzej Hajda wrote: > On 19.12.2022 11:13, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > As the logic for selecting the register and corresponsing values grew, the > > corresponding > > > code become a bit unsightly. Consolidate by storing the

Re: [Intel-gfx] [PULL] drm-misc-next-fixes

2023-01-03 Thread Daniel Vetter
On Tue, Jan 03, 2023 at 03:49:26PM +0100, Maxime Ripard wrote: > Hi Daniel, Dave, > > Here's the drm-misc-next-fixes leftovers. > > Maxime > > drm-misc-next-fixes-2023-01-03: > The drm-misc-next-fixes leftovers. It addresses a bug in drm/scheduler > ending up causing a lockup, and reduces the st

Re: [Intel-gfx] [PATCH 09/27] drm/i915/gvt: Protect gfn hash table with dedicated mutex

2023-01-03 Thread Sean Christopherson
On Wed, Dec 28, 2022, Yan Zhao wrote: > On Fri, Dec 23, 2022 at 12:57:21AM +, Sean Christopherson wrote: > > Add and use a new mutex, gfn_lock, to protect accesses to the hash table > > used to track which gfns are write-protected when shadowing the guest's > > GTT. This fixes a bug where kvmg

Re: [Intel-gfx] [PATCH 03/27] drm/i915/gvt: Incorporate KVM memslot info into check for 2MiB GTT entry

2023-01-03 Thread Sean Christopherson
On Wed, Dec 28, 2022, Yan Zhao wrote: > On Fri, Dec 23, 2022 at 12:57:15AM +, Sean Christopherson wrote: > > Honor KVM's max allowed page size when determining whether or not a 2MiB > > GTT shadow page can be created for the guest. Querying KVM's max allowed > > size is somewhat odd as there's

Re: [Intel-gfx] [PATCH 26/27] KVM: x86/mmu: Add page-track API to query if a gfn is valid

2023-01-03 Thread Sean Christopherson
On Wed, Dec 28, 2022, Yan Zhao wrote: > On Fri, Dec 23, 2022 at 12:57:38AM +, Sean Christopherson wrote: > > +bool kvm_page_track_is_valid_gfn(struct kvm *kvm, gfn_t gfn) > > +{ > > + bool ret; > > + int idx; > > + > > + idx = srcu_read_lock(&kvm->srcu); > > + ret = kvm_is_visible_gfn(k

Re: [Intel-gfx] [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2023-01-03 Thread Matt Roper
On Fri, Dec 23, 2022 at 10:28:07AM -0800, Lucas De Marchi wrote: > On Fri, Dec 23, 2022 at 09:02:35AM +, Tvrtko Ursulin wrote: > > > > On 22/12/2022 15:55, Lucas De Marchi wrote: > > > On Thu, Dec 22, 2022 at 10:27:00AM +, Tvrtko Ursulin wrote: > > > > > > > > On 22/12/2022 08:25, Lucas D

[Intel-gfx] [PATCH] drm/i915: Fix potential context UAFs

2023-01-03 Thread Rob Clark
From: Rob Clark gem_context_register() makes the context visible to userspace, and which point a separate thread can trigger the I915_GEM_CONTEXT_DESTROY ioctl. So we need to ensure that nothing uses the ctx ptr after this. And we need to ensure that adding the ctx to the xarray is the *last* th

Re: [Intel-gfx] [PATCH v2] drm/i915/mtl: Add initial gt workarounds

2023-01-03 Thread Matt Roper
On Thu, Dec 15, 2022 at 03:30:55PM -0800, Matt Atwood wrote: > From: Matt Roper > > This patch introduces initial gt workarounds for the MTL platform. > > v2: drop redundant/stale comments specifying wa platforms affected This is being discussed on the other thread, but it also doesn't look lik

Re: [Intel-gfx] [PATCH] drm/i915/display: Implement Wa_14015648006

2023-01-03 Thread Matt Roper
On Wed, Dec 21, 2022 at 03:21:18PM +0200, Jouni Högander wrote: > Add 4th pipe and extend TGL Wa_16013835468 to support ADLP, MTL and > DG2 and all TGL steppings. > > BSpec: 54369, 55378, 66624 > > Cc: Matt Roper > Cc: José Roberto de Souza > Cc: Stanislav Lisovskiy > > Signed-off-by: Mika Ka

Re: [Intel-gfx] [PATCH 19/27] KVM: x86/mmu: Use page-track notifiers iff there are external users

2023-01-03 Thread Sean Christopherson
On Wed, Dec 28, 2022, Yan Zhao wrote: > On Fri, Dec 23, 2022 at 12:57:31AM +, Sean Christopherson wrote: > > diff --git a/arch/x86/kvm/mmu/page_track.c b/arch/x86/kvm/mmu/page_track.c > > index 2b302fd2c5dd..f932909aa9b5 100644 > > --- a/arch/x86/kvm/mmu/page_track.c > > +++ b/arch/x86/kvm/mmu/

Re: [Intel-gfx] [PATCH 00/27] drm/i915/gvt: KVM: KVMGT fixes and page-track cleanups

2023-01-03 Thread Sean Christopherson
On Fri, Dec 23, 2022, Yan Zhao wrote: > On Fri, Dec 23, 2022 at 12:57:12AM +, Sean Christopherson wrote: > > Fix a variety of found-by-inspection bugs in KVMGT, and overhaul KVM's > > page-track APIs to provide a leaner and cleaner interface. The motivation > > for this series is to (significa

Re: [Intel-gfx] [PATCH 04/13] drm/i915/dsb: Fix DSB command buffer size checks

2023-01-03 Thread Manna, Animesh
Hi, > -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Friday, December 16, 2022 6:08 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 04/13] drm/i915/dsb: Fix DSB command buffer > size checks > > From: Ville Syrjälä > > free_pos is in dwo

[Intel-gfx] Recall: [PATCH 04/13] drm/i915/dsb: Fix DSB command buffer size checks

2023-01-03 Thread Manna, Animesh
Manna, Animesh would like to recall the message, "[Intel-gfx] [PATCH 04/13] drm/i915/dsb: Fix DSB command buffer size checks".

[Intel-gfx] Recall: [PATCH 04/13] drm/i915/dsb: Fix DSB command buffer size checks

2023-01-03 Thread Manna, Animesh
Manna, Animesh would like to recall the message, "[Intel-gfx] [PATCH 04/13] drm/i915/dsb: Fix DSB command buffer size checks".

Re: [Intel-gfx] [PATCH 04/13] drm/i915/dsb: Fix DSB command buffer size checks

2023-01-03 Thread Manna, Animesh
> -Original Message- > From: Manna, Animesh > Sent: Wednesday, January 4, 2023 12:28 PM > To: Ville Syrjala ; intel- > g...@lists.freedesktop.org > Subject: RE: [Intel-gfx] [PATCH 04/13] drm/i915/dsb: Fix DSB command > buffer size checks > > Hi, > > > -Original Message- > > From

Re: [Intel-gfx] [PATCH 01/13] drm/i915/dsb: Stop with the RMW

2023-01-03 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Friday, December 16, 2022 6:08 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 01/13] drm/i915/dsb: Stop with the RMW > > From: Ville Syrjälä > > We don't want to keep random bits set in