Re: [Intel-gfx] [PATCH v4 6/7] drm/i915/mtl: Add function to send command to GSC CS

2022-12-23 Thread Teres Alexis, Alan Previn
Most of it looks good - but I have two issues: 1. I believe there are some reuse efficiency gaps depending on the frequency of these hdcp-gsc messages... but it might not be an issue depending on the answers to the questions i have below. 2. Missing the session-cleanup request ...alan On Thu

Re: [Intel-gfx] [PATCH v4 1/7] drm/i915/gsc: Create GSC request submission mechanism

2022-12-23 Thread Teres Alexis, Alan Previn
LGTM: Reviewed-by: Alan Previn On Thu, 2022-12-22 at 12:13 +0530, Kandpal, Suraj wrote: > HDCP and PXP will require a common function to allow it to > submit commands to the gsc cs. Also adding the gsc mtl header > that needs to be added on to the existing payloads of HDCP > and PXP. > > --v4 >

Re: [Intel-gfx] [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2022-12-23 Thread Tvrtko Ursulin
On 22/12/2022 15:55, Lucas De Marchi wrote: On Thu, Dec 22, 2022 at 10:27:00AM +, Tvrtko Ursulin wrote: On 22/12/2022 08:25, Lucas De Marchi wrote: The comments are redundant to the checks being done to apply the workarounds and very often get outdated as workarounds need to be extended

Re: [Intel-gfx] [PATCH v4 6/7] drm/i915/mtl: Add function to send command to GSC CS

2022-12-23 Thread Kandpal, Suraj
> > Most of it looks good - but I have two issues: > 1. I believe there are some reuse efficiency gaps depending on the frequency > of > these hdcp-gsc messages... but it might not be an issue depending on the > answers to the questions i have below. > 2. Missing the session-cleanup request >

[Intel-gfx] [PATCH] drm/i915: Reserve enough fence slot for i915_vma_unbind_async

2022-12-23 Thread Nirmoy Das
A nested dma_resv_reserve_fences(1) will not reserve slot from the 2nd call onwards and folowing dma_resv_add_fence() might hit the "BUG_ON(fobj->num_fences >= fobj->max_fences)" check. I915 hit above nested dma_resv case in ttm_bo_handle_move_mem() with async unbind: dma_resv_reserve_fences() fr

Re: [Intel-gfx] [PATCH 00/27] drm/i915/gvt: KVM: KVMGT fixes and page-track cleanups

2022-12-23 Thread Yan Zhao
On Fri, Dec 23, 2022 at 12:57:12AM +, Sean Christopherson wrote: > Fix a variety of found-by-inspection bugs in KVMGT, and overhaul KVM's > page-track APIs to provide a leaner and cleaner interface. The motivation > for this series is to (significantly) reduce the number of KVM APIs that > KVM

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reserve enough fence slot for i915_vma_unbind_async

2022-12-23 Thread Patchwork
== Series Details == Series: drm/i915: Reserve enough fence slot for i915_vma_unbind_async URL : https://patchwork.freedesktop.org/series/112205/ State : success == Summary == CI Bug Log - changes from CI_DRM_12524 -> Patchwork_112205v1 Sum

Re: [Intel-gfx] [RFC PATCH 11/20] drm/i915: Remove gem and overlay frontbuffer tracking

2022-12-23 Thread Tvrtko Ursulin
On 22/12/2022 22:21, Matthew Brost wrote: From: Maarten Lankhorst Frontbuffer update handling should be done explicitly by using dirtyfb calls only. A bit terse - questions around if this breaks something, and if it does what and why it is okay, were left hanging in the air in the previous

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned firmware paths

2022-12-23 Thread Gustavo Sousa
On Thu, Dec 22, 2022 at 04:52:21PM -0800, Lucas De Marchi wrote: > On Thu, Dec 22, 2022 at 07:12:08PM -0300, Gustavo Sousa wrote: > > On Wed, Dec 21, 2022 at 04:23:45PM -0800, Lucas De Marchi wrote: > > > On Wed, Dec 21, 2022 at 12:26:26PM +0200, Jani Nikula wrote: > > > > On Tue, 20 Dec 2022, Gust

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Reserve enough fence slot for i915_vma_unbind_async

2022-12-23 Thread Patchwork
== Series Details == Series: drm/i915: Reserve enough fence slot for i915_vma_unbind_async URL : https://patchwork.freedesktop.org/series/112205/ State : success == Summary == CI Bug Log - changes from CI_DRM_12524_full -> Patchwork_112205v1_full ===

Re: [Intel-gfx] [PATCH v6 1/2] drm/i915/mtl: limit second scaler vertical scaling in ver >= 14

2022-12-23 Thread Coelho, Luciano
On Tue, 2022-12-20 at 23:00 +0200, Ville Syrjälä wrote: > On Tue, Dec 20, 2022 at 02:07:23PM +0200, Luca Coelho wrote: > > In newer hardware versions (i.e. display version >= 14), the second > > scaler doesn't support vertical scaling. > > > > The current implementation of the scaling limits is si

Re: [Intel-gfx] LOOKS GOOD: Possible regression in drm/i915 driver: memleak

2022-12-23 Thread Tvrtko Ursulin
On 22/12/2022 15:21, Mirsad Goran Todorovac wrote: On 12/22/2022 09:04, Tvrtko Ursulin wrote: On 22/12/2022 00:12, Mirsad Goran Todorovac wrote: On 20. 12. 2022. 20:34, Mirsad Todorovac wrote: As I hear no reply from Tvrtko, and there is already 1d5h uptime with no leaks (but the kworker wi

[Intel-gfx] [PATCH] drm/i915/gt: Retry RING_HEAD reset until it sticks

2022-12-23 Thread Andi Shyti
From: Chris Wilson On Haswell, in particular, we see an issue where resets fails because the engine resumes from an incorrect RING_HEAD. Since the RING_HEAD doesn't point to the remaining requests to re-run, but may instead point into the uninitialised portion of the ring, the GPU may be then fed

Re: [Intel-gfx] [PATCH v6 2/2] drm/i915/mtl: Limit scaler input to 4k in plane scaling

2022-12-23 Thread Coelho, Luciano
On Tue, 2022-12-20 at 23:10 +0200, Ville Syrjälä wrote: > On Tue, Dec 20, 2022 at 02:07:24PM +0200, Luca Coelho wrote: > > From: Animesh Manna > > > > As part of die area reduction max input source modified to 4096 > > for MTL so modified range check logic of scaler. > > > > Signed-off-by: Jos?

[Intel-gfx] [PATCH v7 0/2] drm/i915/mtl: handle some MTL scaler limitations

2022-12-23 Thread Luca Coelho
Hi, Here's an updated version of the patches after Ville's last comments. The versioning history is in the patches themselves. Please review. Cheers, Luca. Animesh Manna (1): drm/i915/mtl: update scaler source and destination limits for MTL Luca Coelho (1): drm/i915/mtl: limit second scal

[Intel-gfx] [PATCH v7 1/2] drm/i915/mtl: limit second scaler vertical scaling in ver >= 14

2022-12-23 Thread Luca Coelho
In newer hardware versions (i.e. display version >= 14), the second scaler doesn't support vertical scaling. The current implementation of the scaling limits is simplified and only occurs when the planes are created, so we don't know which scaler is being used. In order to handle separate scaling

[Intel-gfx] [PATCH v7 2/2] drm/i915/mtl: update scaler source and destination limits for MTL

2022-12-23 Thread Luca Coelho
From: Animesh Manna The max source and destination limits for scalers in MTL have changed. Use the new values accordingly. Signed-off-by: José Roberto de Souza Signed-off-by: Animesh Manna Signed-off-by: Luca Coelho --- In v2: * No changes; In v3: * Removed stray reviewed-by tag; *

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Retry RING_HEAD reset until it sticks (rev2)

2022-12-23 Thread Patchwork
== Series Details == Series: drm/i915/gt: Retry RING_HEAD reset until it sticks (rev2) URL : https://patchwork.freedesktop.org/series/106377/ State : success == Summary == CI Bug Log - changes from CI_DRM_12524 -> Patchwork_106377v2 Summary

Re: [Intel-gfx] [PATCH] drm/i915/gt: Retry RING_HEAD reset until it sticks

2022-12-23 Thread Tvrtko Ursulin
On 23/12/2022 12:18, Andi Shyti wrote: From: Chris Wilson On Haswell, in particular, we see an issue where resets fails because the engine resumes from an incorrect RING_HEAD. Since the RING_HEAD doesn't point to the remaining requests to re-run, but may instead point into the uninitialised p

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: handle some MTL scaler limitations

2022-12-23 Thread Patchwork
== Series Details == Series: drm/i915/mtl: handle some MTL scaler limitations URL : https://patchwork.freedesktop.org/series/112211/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: handle some MTL scaler limitations

2022-12-23 Thread Patchwork
== Series Details == Series: drm/i915/mtl: handle some MTL scaler limitations URL : https://patchwork.freedesktop.org/series/112211/ State : success == Summary == CI Bug Log - changes from CI_DRM_12524 -> Patchwork_112211v1 Summary ---

Re: [Intel-gfx] [PATCH v7 2/2] drm/i915/mtl: update scaler source and destination limits for MTL

2022-12-23 Thread Nautiyal, Ankit K
On 12/23/2022 6:35 PM, Luca Coelho wrote: From: Animesh Manna The max source and destination limits for scalers in MTL have changed. Use the new values accordingly. Signed-off-by: José Roberto de Souza Signed-off-by: Animesh Manna Signed-off-by: Luca Coelho --- In v2: * No changes;

Re: [Intel-gfx] [PATCH v7 2/2] drm/i915/mtl: update scaler source and destination limits for MTL

2022-12-23 Thread Nautiyal, Ankit K
On 12/23/2022 7:37 PM, Nautiyal, Ankit K wrote: On 12/23/2022 6:35 PM, Luca Coelho wrote: From: Animesh Manna The max source and destination limits for scalers in MTL have changed. Use the new values accordingly. Signed-off-by: José Roberto de Souza Signed-off-by: Animesh Manna Signed-of

Re: [Intel-gfx] [PATCH 00/19] Introduce __xchg, non-atomic xchg

2022-12-23 Thread Alexander Lobakin
From: Andrew Morton Date: Thu, 22 Dec 2022 09:21:47 -0800 > On Thu, 22 Dec 2022 12:46:16 +0100 Andrzej Hajda > wrote: > > > Hi all, > > > > I hope there will be place for such tiny helper in kernel. > > Quick cocci analyze shows there is probably few thousands places > > where it could be use

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Retry RING_HEAD reset until it sticks (rev2)

2022-12-23 Thread Patchwork
== Series Details == Series: drm/i915/gt: Retry RING_HEAD reset until it sticks (rev2) URL : https://patchwork.freedesktop.org/series/106377/ State : success == Summary == CI Bug Log - changes from CI_DRM_12524_full -> Patchwork_106377v2_full ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: handle some MTL scaler limitations

2022-12-23 Thread Patchwork
== Series Details == Series: drm/i915/mtl: handle some MTL scaler limitations URL : https://patchwork.freedesktop.org/series/112211/ State : success == Summary == CI Bug Log - changes from CI_DRM_12524_full -> Patchwork_112211v1_full Summar

Re: [Intel-gfx] [PATCH 0/2] drm/i915: Remove frontbuffer tracking from gem.

2022-12-23 Thread Rodrigo Vivi
On Fri, Dec 2, 2022 at 4:17 AM Tvrtko Ursulin < tvrtko.ursu...@linux.intel.com> wrote: For some reason I has missed this. Thanks Tvrtko for pointing this out. > On 01/12/2022 22:03, Zanoni, Paulo R wrote: > > Hi > > > > I was given a link to https://patchwork.freedesktop.org/series/111494/ > > b

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned firmware paths

2022-12-23 Thread Rodrigo Vivi
On Fri, Dec 23, 2022 at 08:51:59AM -0300, Gustavo Sousa wrote: > On Thu, Dec 22, 2022 at 04:52:21PM -0800, Lucas De Marchi wrote: > > On Thu, Dec 22, 2022 at 07:12:08PM -0300, Gustavo Sousa wrote: > > > On Wed, Dec 21, 2022 at 04:23:45PM -0800, Lucas De Marchi wrote: > > > > On Wed, Dec 21, 2022 at

Re: [Intel-gfx] [PATCH] treewide: Convert del_timer*() to timer_shutdown*()

2022-12-23 Thread Steven Rostedt
On Tue, 20 Dec 2022 13:45:19 -0500 Steven Rostedt wrote: > [ > Linus, > > I ran the script against your latest master branch: > commit b6bb9676f2165d518b35ba3bea5f1fcfc0d969bf > > As the timer_shutdown*() code is now in your tree, I figured > we can start doing the conversions

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2022-12-23 Thread Rob Clark
On Thu, Dec 22, 2022 at 2:29 PM Matthew Brost wrote: > > In XE, the new Intel GPU driver, a choice has made to have a 1 to 1 > mapping between a drm_gpu_scheduler and drm_sched_entity. At first this > seems a bit odd but let us explain the reasoning below. > > 1. In XE the submission order from mu

Re: [Intel-gfx] [PATCH v7 2/2] drm/i915/mtl: update scaler source and destination limits for MTL

2022-12-23 Thread Coelho, Luciano
On Fri, 2022-12-23 at 19:42 +0530, Nautiyal, Ankit K wrote: > On 12/23/2022 7:37 PM, Nautiyal, Ankit K wrote: > > > > On 12/23/2022 6:35 PM, Luca Coelho wrote: > > > From: Animesh Manna > > > > > > The max source and destination limits for scalers in MTL have changed. > > > Use the new values ac

Re: [Intel-gfx] [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2022-12-23 Thread Lucas De Marchi
On Fri, Dec 23, 2022 at 09:02:35AM +, Tvrtko Ursulin wrote: On 22/12/2022 15:55, Lucas De Marchi wrote: On Thu, Dec 22, 2022 at 10:27:00AM +, Tvrtko Ursulin wrote: On 22/12/2022 08:25, Lucas De Marchi wrote: The comments are redundant to the checks being done to apply the workarounds

[Intel-gfx] [PATCH] drm/i915: update src and dst scaler limits for display ver 12 and 13

2022-12-23 Thread Luca Coelho
The bspec has been updated and now display versions 12 and 13 support source width up to 5120 pixels, source height up to 8192 lines, destination width up to 8192 and destination height up to 8192. Update the code accordingly. Signed-off-by: Luca Coelho --- drivers/gpu/drm/i915/display/skl_scal

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: update src and dst scaler limits for display ver 12 and 13

2022-12-23 Thread Patchwork
== Series Details == Series: drm/i915: update src and dst scaler limits for display ver 12 and 13 URL : https://patchwork.freedesktop.org/series/112213/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/112213/revisions/1/mbox/ not applied Applying: