[Intel-gfx] [PATCH 11/12] drm/i915/tc: switch to intel_de_* register accessors in display code

2022-11-23 Thread Jani Nikula
Avoid direct uncore use in display code. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_tc.c | 55 - 1 file changed, 18 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/d

[Intel-gfx] [PATCH 07/12] drm/i915/dp-aux: switch to intel_de_* register accessors in display code

2022-11-23 Thread Jani Nikula
Avoid direct uncore use in display code. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i9

[Intel-gfx] [PATCH 06/12] drm/i915/dmc: switch to intel_de_* register accessors in display code

2022-11-23 Thread Jani Nikula
Avoid direct uncore use in display code. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c i

[Intel-gfx] [PATCH 12/12] drm/i915/fbc: switch to intel_de_* register accessors in display code

2022-11-23 Thread Jani Nikula
Avoid direct uncore use in display code. Use the new intel_de_rewrite_fw(). Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fbc.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/dr

[Intel-gfx] [PATCH 10/12] drm/i915/snps: switch to intel_de_* register accessors in display code

2022-11-23 Thread Jani Nikula
Avoid direct uncore use in display code. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_snps_phy.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c b/drivers/gpu/drm/i915/d

[Intel-gfx] [PATCH 08/12] drm/i915/gmbus: switch to intel_de_* register accessors in display code

2022-11-23 Thread Jani Nikula
Avoid direct uncore use in display code. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_gmbus.c | 46 -- 1 file changed, 17 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i91

[Intel-gfx] [PATCH 09/12] drm/i915/wm: switch to intel_de_* register accessors in display code

2022-11-23 Thread Jani Nikula
Avoid direct uncore use in display code. Cc: Maarten Lankhorst Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/skl_watermark.c | 42 +--- 1 file changed, 18 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add module oriented dmesg output (rev2)

2022-11-23 Thread Patchwork
== Series Details == Series: Add module oriented dmesg output (rev2) URL : https://patchwork.freedesktop.org/series/111050/ State : warning == Summary == Error: dim checkpatch failed 60fd35ea849f drm/i915/gt: Start adding module oriented dmesg output Traceback (most recent call last): File "

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Add module oriented dmesg output (rev2)

2022-11-23 Thread Patchwork
== Series Details == Series: Add module oriented dmesg output (rev2) URL : https://patchwork.freedesktop.org/series/111050/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for intel_gt_mcr_wait_for

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add module oriented dmesg output (rev2)

2022-11-23 Thread Patchwork
== Series Details == Series: Add module oriented dmesg output (rev2) URL : https://patchwork.freedesktop.org/series/111050/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:11

[Intel-gfx] [PATCH v4] drm/i915/display: Don't disable DDI/Transcoder when setting phy test pattern

2022-11-23 Thread Khaled Almahallawy
Bspecs has updated recently to remove the restriction to disable DDI/Transcoder before setting PHY test pattern. This update is to address PHY compliance test failures observed on a port with LTTPR. The issue is that when Transc. is disabled, the main link signals fed to LTTPR will be dropped inval

[Intel-gfx] ✓ Fi.CI.BAT: success for Add module oriented dmesg output (rev2)

2022-11-23 Thread Patchwork
== Series Details == Series: Add module oriented dmesg output (rev2) URL : https://patchwork.freedesktop.org/series/111050/ State : success == Summary == CI Bug Log - changes from CI_DRM_12425 -> Patchwork_111050v2 Summary --- **SUCC

[Intel-gfx] [PATCH v2 1/3] drm/i915/uc: Rationalise delimiters in filename macros

2022-11-23 Thread John . C . Harrison
From: John Harrison The way delimiters (underscores and dots) were added to the UC filenames was different for different types of delimiter. Rationalise them to all be done the same way - implicitly in the concatenation macro rather than explicitly in the file name prefix. Signed-off-by: John Ha

[Intel-gfx] [PATCH v2 3/3] drm/i915/guc: Use GuC submission API version number

2022-11-23 Thread John . C . Harrison
From: John Harrison The GuC firmware includes an extra version number to specify the submission API level. So use that rather than the main firmware version number for submission related checks. Also, while it is guaranteed that GuC version number components are only 8-bits in size, other firmwa

[Intel-gfx] [PATCH v2 0/3] More GuC firmware version improvements

2022-11-23 Thread John . C . Harrison
From: John Harrison Start using the 'submission API version' for deciding which GuC API to use in the submission code. Correct version number manipulation code to support full 32bit major/minor/patch components, except for GuC which is guaranteed to be 8bit safe. Other minor code clean ups arou

[Intel-gfx] [PATCH v2 2/3] drm/i915/uc: More refactoring of UC version numbers

2022-11-23 Thread John . C . Harrison
From: John Harrison As a precursor to a coming change (for adding a GuC submission API version), abstract the UC version number into its own private structure separate to the firmware filename. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/int

[Intel-gfx] [RFC 1/7] HAX: drm/i915/pxp: Prepare intel_pxp entry points for MTL

2022-11-23 Thread Alan Previn
Squash of all the patches from the series: https://patchwork.freedesktop.org/series/109429/ Above series is not a prerequisite to showcase the design changes being proposed in the next set of patches but will be in the same order dependency as here. NOTE: that series will be going through a major

[Intel-gfx] [RFC 2/7] drm/i915/pxp: Refactor mei-teelink checks at init/fini

2022-11-23 Thread Alan Previn
In preparation of MTL-pxp support, add helper functions to determine if teelink is required and to determine the type of teelink for the current gt-pxp subsystem. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 6 +++--- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 26 ++

[Intel-gfx] [RFC 0/7] drm/i915/pxp: Create a backend abstraction layer for pxp-tee-link

2022-11-23 Thread Alan Previn
PXP is a feature allowing workloads executing on engines to operate with encrypted buffers (via specific state instructions). On the other hand, PXP controls for operations like arbitration session creation and global teardown of PXP sessions require communicating with the security firmware. The

[Intel-gfx] [RFC 3/7] drm/i915/pxp: Abstract mei-teelink function access via backend ptrs

2022-11-23 Thread Alan Previn
Abstract mei-teelink function access via backend ptrs Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp_huc.c | 9 +- drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 2 +- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 107 ++- drivers/gpu/drm/i915/pxp/inte

[Intel-gfx] [RFC 5/7] drm/i915/pxp: move mei-pxp and mei-gsc resources to be backend-private

2022-11-23 Thread Alan Previn
drm/i915/pxp: move mei-pxp and mei-gsc resources to be backend-private Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 14 +- drivers/gpu/drm/i915/pxp/intel_pxp_huc.c | 4 +- drivers/gpu/drm/i915/pxp/intel_pxp_pm.c | 3 +- drivers/gpu/drm/i915/pxp/inte

[Intel-gfx] [RFC 6/7] drm/i915/pxp: Add PXP gsccs tee-link backend stubs

2022-11-23 Thread Alan Previn
Add PXP gsccs tee-link backend using empty stubs for now. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c | 46 ++ drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.h | 13 ++ drivers/gpu/drm/i915/pxp/in

[Intel-gfx] [RFC 7/7] drm/i915/pxp: Better hierarchy readibility - move backends to a backend folder

2022-11-23 Thread Alan Previn
Move the mei and gsccs backend implementation files into a backend folder This would provide clearer readibility of file hiearchy with regards to this backend vs front end thus encouraging better code location selcection for future changes. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/Mak

[Intel-gfx] [RFC 4/7] drm/i915/pxp: Separate tee-link front end interfaces from backend implementation

2022-11-23 Thread Alan Previn
Separate tee-link front end interfaces from backend implementation. Duplicate intel_pxp_tee to intel_pxp_tee_mei keep the front end side (like populating the backend hooks) in the former while keeping the mei backend (like send_message) in the _mei variant. Signed-off-by: Alan Previn --- drivers

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: A check on mode->clock, if it exceeds max_dot_clock

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/display: A check on mode->clock, if it exceeds max_dot_clock URL : https://patchwork.freedesktop.org/series/111240/ State : success == Summary == CI Bug Log - changes from CI_DRM_12419_full -> Patchwork_111240v1_full ===

Re: [Intel-gfx] [PATCH] drm/i915/gt: Manage uncore->lock while waiting on MCR register

2022-11-23 Thread John Harrison
On 11/17/2022 09:33, Matt Roper wrote: ... diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c index 830edffe88cc..d9a8ff9e5e57 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c +++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c @@ -730,17 +730,19 @@ void in

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/perf: Do not parse context image for HSW (rev2)

2022-11-23 Thread Umesh Nerlige Ramappa
On Wed, Nov 23, 2022 at 07:22:56PM +, Patchwork wrote: Patch Details Series: drm/i915/perf: Do not parse context image for HSW (rev2) URL: [1]https://patchwork.freedesktop.org/series/111231/ State: failure Details: [2]https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111231v2/inde

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: switch to intel_de_* register accessors

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/display: switch to intel_de_* register accessors URL : https://patchwork.freedesktop.org/series/111281/ State : success == Summary == CI Bug Log - changes from CI_DRM_12425 -> Patchwork_111281v1 Summary

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display: Don't disable DDI/Transcoder when setting phy test pattern (rev5)

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/display: Don't disable DDI/Transcoder when setting phy test pattern (rev5) URL : https://patchwork.freedesktop.org/series/108636/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: e

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915/pxp: Make gt and pxp init/fini aware of PXP-owning-GT

2022-11-23 Thread Teres Alexis, Alan Previn
typo correction... On Tue, 2022-11-22 at 12:13 -0800, Alan Previn Teres Alexis wrote: > After a more comprehensive offline discussion with Daniele and Rodrigo, > design direction was made to go with Option2 > where we elevate pxp to a global subsystem and within it it establish a > pointer to th

Re: [Intel-gfx] [PATCH 1/2] drm/i915/pxp: Invalidate all PXP fw sessions during teardown

2022-11-23 Thread Teres Alexis, Alan Previn
On Mon, 2022-11-21 at 16:14 -0800, Juston Li wrote: > On Thu, 2022-11-17 at 16:36 -0800, Alan Previn wrote: > > Alan: [snip] > > +void intel_pxp_tee_end_all_fw_sessions(struct intel_pxp *pxp, u32 > > sessions_mask) > > +{ > > +   int n; > > + > > +   for (n = 0; n < INTEL_PXP_MAX_HWDRM_S

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Don't disable DDI/Transcoder when setting phy test pattern (rev5)

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/display: Don't disable DDI/Transcoder when setting phy test pattern (rev5) URL : https://patchwork.freedesktop.org/series/108636/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12425 -> Patchwork_108636v5 ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More GuC firmware version improvements (rev2)

2022-11-23 Thread Patchwork
== Series Details == Series: More GuC firmware version improvements (rev2) URL : https://patchwork.freedesktop.org/series/111218/ State : warning == Summary == Error: dim checkpatch failed 230524ea4d08 drm/i915/uc: Rationalise delimiters in filename macros 1a05b91ce526 drm/i915/uc: More refact

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for More GuC firmware version improvements (rev2)

2022-11-23 Thread Patchwork
== Series Details == Series: More GuC firmware version improvements (rev2) URL : https://patchwork.freedesktop.org/series/111218/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH] drm/i915/huc: always init the delayed load fence

2022-11-23 Thread Daniele Ceraolo Spurio
The fence is only tracking if the HuC load is in progress or not and doesn't distinguish between already loaded, not supported or disabled, so we can always initialize it to completed, no matter the actual support. We already do that for most platforms, but we skip it on GTs that lack VCS engines (

[Intel-gfx] [PATCH v3] drm/i915/perf: Do not parse context image for HSW

2022-11-23 Thread Umesh Nerlige Ramappa
An earlier commit introduced a mechanism to parse the context image to find the OA context control offset. This resulted in an NPD on haswell when gem_context was passed into i915_perf_open_ioctl params. Haswell does not support logical ring contexts, so ensure that the context image is parsed only

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pxp: Trigger the global teardown for before suspending

2022-11-23 Thread Teres Alexis, Alan Previn
On Mon, 2022-11-21 at 14:14 -0800, Juston Li wrote: > > Alan:[snip] > > > > > > +void intel_pxp_end(struct intel_pxp *pxp) > > > > +{ > > > > +   struct drm_i915_private *i915 = pxp_to_gt(pxp)->i915; > > > > +   intel_wakeref_t wakeref; > > > > + > > > > +   if (!intel_pxp_is_enabled

Re: [Intel-gfx] [PATCH] drm/i915/gt: Manage uncore->lock while waiting on MCR register

2022-11-23 Thread Matt Roper
On Wed, Nov 23, 2022 at 02:46:18PM -0800, John Harrison wrote: > On 11/17/2022 09:33, Matt Roper wrote: > > ... > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > > b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > > index 830edffe88cc..d9a8ff9e5e57 100644 > > --- a/drivers/gpu/drm/i915/gt/in

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp: Create a backend abstraction layer for pxp-tee-link

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/pxp: Create a backend abstraction layer for pxp-tee-link URL : https://patchwork.freedesktop.org/series/111287/ State : warning == Summary == Error: dim checkpatch failed 11ceb24c80fb HAX: drm/i915/pxp: Prepare intel_pxp entry points for MTL 362d4558aeaa d

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/pxp: Create a backend abstraction layer for pxp-tee-link

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/pxp: Create a backend abstraction layer for pxp-tee-link URL : https://patchwork.freedesktop.org/series/111287/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/huc: always init the delayed load fence

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/huc: always init the delayed load fence URL : https://patchwork.freedesktop.org/series/111288/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for intel_gt_mcr

[Intel-gfx] ✓ Fi.CI.BAT: success for More GuC firmware version improvements (rev2)

2022-11-23 Thread Patchwork
== Series Details == Series: More GuC firmware version improvements (rev2) URL : https://patchwork.freedesktop.org/series/111218/ State : success == Summary == CI Bug Log - changes from CI_DRM_12425 -> Patchwork_111218v2 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pxp: Create a backend abstraction layer for pxp-tee-link

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/pxp: Create a backend abstraction layer for pxp-tee-link URL : https://patchwork.freedesktop.org/series/111287/ State : success == Summary == CI Bug Log - changes from CI_DRM_12425 -> Patchwork_111287v1

[Intel-gfx] [PATCH v2 0/3] drm/i915/pxp: Add missing cleanup steps for PXP global-teardown

2022-11-23 Thread Alan Previn
A customer issue was recently discovered and in the process a gap in i915's PXP interaction with HW+FW architecure was also realized. This series adds those missing pieces. The patches explain the details. Changes from prior revs: v1: - Dont need to teardown non arbitration sessions (Juston).

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/huc: always init the delayed load fence

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/huc: always init the delayed load fence URL : https://patchwork.freedesktop.org/series/111288/ State : success == Summary == CI Bug Log - changes from CI_DRM_12425 -> Patchwork_111288v1 Summary ---

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/perf: Do not parse context image for HSW (rev3)

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/perf: Do not parse context image for HSW (rev3) URL : https://patchwork.freedesktop.org/series/111231/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for inte

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Do not parse context image for HSW (rev3)

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/perf: Do not parse context image for HSW (rev3) URL : https://patchwork.freedesktop.org/series/111231/ State : success == Summary == CI Bug Log - changes from CI_DRM_12426 -> Patchwork_111231v3 Summary

[Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry include sw delay

2022-11-23 Thread Arun R Murthy
AUX HW timeout is being set to max(4000ms), consider AUX SW timeout to be 200ms more to avoid AUX boundary read//write. HSDES: 1409498780 Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dp: wait on timeout before retry include sw delay

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/dp: wait on timeout before retry include sw delay URL : https://patchwork.freedesktop.org/series/111303/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for in

[Intel-gfx] [PULL] drm-misc-next

2022-11-23 Thread Maxime Ripard
Hi Daniel, Dave, We might be fairly late for a drm-misc-next PR by now, but I chose to send it anyway because we might have an -rc8, and this is almost exclusively fixes that should go in anyway. This will be the last drm-misc-next PR for this cycle Maxime drm-misc-next-2022-11-24: drm-misc-next

Re: [Intel-gfx] [PATCH] dma-buf: Require VM_PFNMAP vma for mmap

2022-11-23 Thread Thomas Zimmermann
Hi Am 22.11.22 um 18:08 schrieb Daniel Vetter: tldr; DMA buffers aren't normal memory, expecting that you can use them like that (like calling get_user_pages works, or that they're accounting like any other normal memory) cannot be guaranteed. Since some userspace only runs on integrated device

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: A check on mode->clock, if it exceeds max_dot_clock

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/display: A check on mode->clock, if it exceeds max_dot_clock URL : https://patchwork.freedesktop.org/series/111240/ State : warning == Summary == Error: dim checkpatch failed abeb32d368e6 drm/i915/display: A check on mode->clock, if it exceeds max_dot_clo

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2022-11-23 Thread Thomas Zimmermann
Hi Am 23.11.22 um 06:35 schrieb David Airlie: On Wed, Nov 23, 2022 at 3:21 PM Stephen Rothwell wrote: Hi all, On Thu, 17 Nov 2022 18:32:14 +1100 Stephen Rothwell wrote: After merging the drm-misc tree, today's linux-next build (powerpc ppc44x_defconfig) failed like this: ld: drivers/vid

Re: [Intel-gfx] [PATCH] dma-buf: Require VM_PFNMAP vma for mmap

2022-11-23 Thread Christian König
Am 22.11.22 um 20:50 schrieb Daniel Vetter: On Tue, 22 Nov 2022 at 20:34, Jason Gunthorpe wrote: On Tue, Nov 22, 2022 at 08:29:05PM +0100, Daniel Vetter wrote: You nuke all the ptes. Drivers that move have slightly more than a bare struct file, they also have a struct address_space so that inv

Re: [Intel-gfx] [MAINTAINER TOOLS] docs: updated rules for topic/core-for-CI commit management

2022-11-23 Thread Jani Nikula
On Tue, 22 Nov 2022, Lucas De Marchi wrote: > On Tue, Nov 22, 2022 at 03:17:14PM +0200, Jani Nikula wrote: >>Introduce stricter rules for topic/core-for-CI management. Way too many >>commits have been added over the years, with insufficient rationale >>recorded in the commit message, and insuffici

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/mtl: limit second scaler vertical scaling in ver >= 14

2022-11-23 Thread Coelho, Luciano
On Wed, 2022-11-23 at 08:47 +0200, Ville Syrjälä wrote: > On Tue, Nov 22, 2022 at 12:23:43PM +0200, Luca Coelho wrote: > > In newer hardware versions (i.e. display version >= 14), the second > > scaler doesn't support vertical scaling. > > > > The current implementation of the scaling limits is si

Re: [Intel-gfx] [PATCH] drm/i915/hti: avoid theoretically possible negative shift

2022-11-23 Thread Jani Nikula
On Tue, 22 Nov 2022, Kees Cook wrote: > On Tue, Nov 22, 2022 at 02:09:48PM +0200, Jani Nikula wrote: >> If phy is PHY_NONE, the shift to register bits becomes negative. Check >> and warn about this. >> >> Reported-by: coverity-bot >> References: https://lore.kernel.org/r/202211180848.D39006C@kee

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Never return 0 if not all requests retired

2022-11-23 Thread Janusz Krzysztofik
Hi Tvrtko, Thanks for your comments. On Tuesday, 22 November 2022 11:50:38 CET Tvrtko Ursulin wrote: > > On 21/11/2022 14:56, Janusz Krzysztofik wrote: > > Users of intel_gt_retire_requests_timeout() expect 0 return value on > > success. However, we have no protection from passing back 0 potent

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: A check on mode->clock, if it exceeds max_dot_clock

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/display: A check on mode->clock, if it exceeds max_dot_clock URL : https://patchwork.freedesktop.org/series/111240/ State : success == Summary == CI Bug Log - changes from CI_DRM_12419 -> Patchwork_111240v1 =

Re: [Intel-gfx] [PATCH] dma-buf: Require VM_PFNMAP vma for mmap

2022-11-23 Thread Daniel Vetter
On Wed, 23 Nov 2022 at 10:06, Christian König wrote: > Am 22.11.22 um 20:50 schrieb Daniel Vetter: > > On Tue, 22 Nov 2022 at 20:34, Jason Gunthorpe wrote: > >> On Tue, Nov 22, 2022 at 08:29:05PM +0100, Daniel Vetter wrote: > >>> You nuke all the ptes. Drivers that move have slightly more than a

Re: [Intel-gfx] [PATCH] dma-buf: Require VM_PFNMAP vma for mmap

2022-11-23 Thread Daniel Vetter
On Wed, 23 Nov 2022 at 09:07, Thomas Zimmermann wrote: > > Hi > > Am 22.11.22 um 18:08 schrieb Daniel Vetter: > > tldr; DMA buffers aren't normal memory, expecting that you can use > > them like that (like calling get_user_pages works, or that they're > > accounting like any other normal memory) c

Re: [Intel-gfx] [Linaro-mm-sig] Re: [PATCH] dma-buf: Require VM_PFNMAP vma for mmap

2022-11-23 Thread Christian König
Am 23.11.22 um 10:30 schrieb Daniel Vetter: On Wed, 23 Nov 2022 at 10:06, Christian König wrote: Am 22.11.22 um 20:50 schrieb Daniel Vetter: On Tue, 22 Nov 2022 at 20:34, Jason Gunthorpe wrote: On Tue, Nov 22, 2022 at 08:29:05PM +0100, Daniel Vetter wrote: You nuke all the ptes. Drivers tha

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: Wrap all access to i915_vma.node.start|size

2022-11-23 Thread Tvrtko Ursulin
On 22/11/2022 18:57, Andi Shyti wrote: From: Chris Wilson We already wrap i915_vma.node.start for use with the GGTT, as there we can perform additional sanity checks that the node belongs to the GGTT and fits within the 32b registers. In the next couple of patches, we will introduce guard pag

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/mtl: limit second scaler vertical scaling in ver >= 14

2022-11-23 Thread Ville Syrjälä
On Wed, Nov 23, 2022 at 09:16:42AM +, Coelho, Luciano wrote: > On Wed, 2022-11-23 at 08:47 +0200, Ville Syrjälä wrote: > > On Tue, Nov 22, 2022 at 12:23:43PM +0200, Luca Coelho wrote: > > > In newer hardware versions (i.e. display version >= 14), the second > > > scaler doesn't support vertical

[Intel-gfx] ✗ Fi.CI.IGT: failure for dma-buf: Require VM_PFNMAP vma for mmap

2022-11-23 Thread Patchwork
== Series Details == Series: dma-buf: Require VM_PFNMAP vma for mmap URL : https://patchwork.freedesktop.org/series/111210/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12418_full -> Patchwork_111210v1_full Summary ---

[Intel-gfx] [PATCH 5/6] drm/i915: Extract VESA DSC bpp alignment to separate function

2022-11-23 Thread Stanislav Lisovskiy
We might to use that function separately from intel_dp_dsc_compute_config for DP DSC over MST case, because allocating bandwidth in that case can be a bit more tricky. So in order to avoid code copy-pasta lets extract this to separate function and reuse it for both SST and MST cases. v2: Removed m

Re: [Intel-gfx] [Linaro-mm-sig] Re: [PATCH] dma-buf: Require VM_PFNMAP vma for mmap

2022-11-23 Thread Daniel Vetter
On Wed, 23 Nov 2022 at 10:39, Christian König wrote: > > Am 23.11.22 um 10:30 schrieb Daniel Vetter: > > On Wed, 23 Nov 2022 at 10:06, Christian König > > wrote: > >> Am 22.11.22 um 20:50 schrieb Daniel Vetter: > >>> On Tue, 22 Nov 2022 at 20:34, Jason Gunthorpe wrote: > On Tue, Nov 22, 20

[Intel-gfx] [PATCH 6/6] drm/i915: Bpp/timeslot calculation fixes for DP MST DSC

2022-11-23 Thread Stanislav Lisovskiy
Fix intel_dp_dsc_compute_config, previously timeslots parameter was used in fact not as a timeslots, but more like a ratio timeslots/64, which of course didn't have any effect for SST DSC, but causes now issues for MST DSC. Secondly we need to calculate pipe_bpp using intel_dp_dsc_compute_bpp only

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/mtl: limit second scaler vertical scaling in ver >= 14

2022-11-23 Thread Coelho, Luciano
On Wed, 2022-11-23 at 11:57 +0200, Ville Syrjälä wrote: > On Wed, Nov 23, 2022 at 09:16:42AM +, Coelho, Luciano wrote: > > On Wed, 2022-11-23 at 08:47 +0200, Ville Syrjälä wrote: > > > On Tue, Nov 22, 2022 at 12:23:43PM +0200, Luca Coelho wrote: > > > > In newer hardware versions (i.e. display

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add DP MST DSC support to i915 (rev18)

2022-11-23 Thread Patchwork
== Series Details == Series: Add DP MST DSC support to i915 (rev18) URL : https://patchwork.freedesktop.org/series/101492/ State : warning == Summary == Error: dim checkpatch failed dff236bab4de drm: Add missing DP DSC extended capability definitions. c17c70fbc92f drm/i915: Fix intel_dp_mst_co

[Intel-gfx] ✓ Fi.CI.BAT: success for Add DP MST DSC support to i915 (rev18)

2022-11-23 Thread Patchwork
== Series Details == Series: Add DP MST DSC support to i915 (rev18) URL : https://patchwork.freedesktop.org/series/101492/ State : success == Summary == CI Bug Log - changes from CI_DRM_12421 -> Patchwork_101492v18 Summary --- **SUCC

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: Introduce guard pages to i915_vma

2022-11-23 Thread Tvrtko Ursulin
On 22/11/2022 18:57, Andi Shyti wrote: From: Chris Wilson Introduce the concept of padding the i915_vma with guard pages before and after. The major consequence is that all ordinary uses of i915_vma must use i915_vma_offset/i915_vma_size and not i915_vma.node.start/size directly, as the drm_m

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dsc: Refactor dsc gen checks (rev2)

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/dsc: Refactor dsc gen checks (rev2) URL : https://patchwork.freedesktop.org/series/110744/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915/display: A check on mode->clock, if it exceeds max_dot_clock

2022-11-23 Thread Jani Nikula
Although the change isn't needed as Ville points out, I'll take the opportunity to comment on other things here, with hopes it'll improve future contributions. On Wed, 23 Nov 2022, Nischal Varide wrote: > Making sure that the mode-clock is not greater than the > max_dot_clock freq.This patch w

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Fix negative value passed as remaining time

2022-11-23 Thread Janusz Krzysztofik
On Tuesday, 22 November 2022 11:41:29 CET Tvrtko Ursulin wrote: > > On 21/11/2022 23:19, Janusz Krzysztofik wrote: > > Hi Andrzej, > > > > Thanks for providing your R-b. > > > > On Monday, 21 November 2022 18:40:51 CET Andrzej Hajda wrote: > >> On 21.11.2022 15:56, Janusz Krzysztofik wrote: > >>

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsc: Refactor dsc gen checks (rev2)

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/dsc: Refactor dsc gen checks (rev2) URL : https://patchwork.freedesktop.org/series/110744/ State : success == Summary == CI Bug Log - changes from CI_DRM_12421 -> Patchwork_110744v2 Summary --- *

Re: [Intel-gfx] [PATCH v7 20/20] drm/i915/vm_bind: Async vm_unbind support

2022-11-23 Thread Matthew Auld
On 16/11/2022 00:37, Niranjana Vishwanathapura wrote: On Tue, Nov 15, 2022 at 03:15:03PM -0800, Niranjana Vishwanathapura wrote: On Tue, Nov 15, 2022 at 08:33:47AM -0800, Niranjana Vishwanathapura wrote: On Tue, Nov 15, 2022 at 04:20:54PM +, Matthew Auld wrote: On 15/11/2022 16:15, Niranja

Re: [Intel-gfx] [PATCH] drm/i915/guc: make default_lists const data

2022-11-23 Thread Jani Nikula
On Tue, 22 Nov 2022, Lucas De Marchi wrote: > On Tue, Nov 22, 2022 at 04:16:16PM +0200, Jani Nikula wrote: >>The default_lists array should be in rodata. >> >>Fixes: dce2bd542337 ("drm/i915/guc: Add Gen9 registers for GuC error state >>capture.") >>Cc: Alan Previn >>Cc: Umesh Nerlige Ramappa >>

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gvt: use sysfs_streq() instead of strncmp()

2022-11-23 Thread Patchwork
== Series Details == Series: drm/i915/gvt: use sysfs_streq() instead of strncmp() URL : https://patchwork.freedesktop.org/series/111212/ State : success == Summary == CI Bug Log - changes from CI_DRM_12418_full -> Patchwork_111212v1_full Su

Re: [Intel-gfx] i915 Updates: MTL DMC v2.10

2022-11-23 Thread Josh Boyer
On Mon, Nov 21, 2022 at 3:18 PM Tolakanahalli Pradeep, Madhumitha wrote: > > The following changes since commit daff40492bd0cd071c7f5521b339e12e4de718c1: > > linux-firmware: update firmware for MT7986 (2022-11-16 08:53:28 -0500) > > are available in the Git repository at: > > git://anongit.fre

[Intel-gfx] ✓ Fi.CI.IGT: success for add guard padding around i915_vma (rev2)

2022-11-23 Thread Patchwork
== Series Details == Series: add guard padding around i915_vma (rev2) URL : https://patchwork.freedesktop.org/series/110720/ State : success == Summary == CI Bug Log - changes from CI_DRM_12418_full -> Patchwork_110720v2_full Summary --

Re: [Intel-gfx] [Linaro-mm-sig] Re: [PATCH] dma-buf: Require VM_PFNMAP vma for mmap

2022-11-23 Thread Christian König
Am 23.11.22 um 13:46 schrieb Jason Gunthorpe: On Wed, Nov 23, 2022 at 11:06:55AM +0100, Daniel Vetter wrote: Maybe a GFP flag to set the page reference count to zero or something like this? Hm yeah that might work. I'm not sure what it will all break though? And we'd need to make sure that und

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Never return 0 if not all requests retired

2022-11-23 Thread Tvrtko Ursulin
On 23/11/2022 09:28, Janusz Krzysztofik wrote: Hi Tvrtko, Thanks for your comments. On Tuesday, 22 November 2022 11:50:38 CET Tvrtko Ursulin wrote: On 21/11/2022 14:56, Janusz Krzysztofik wrote: Users of intel_gt_retire_requests_timeout() expect 0 return value on success. However, we have

[Intel-gfx] [PATCH] drm/audio: make drm_audio_component.h self-contained

2022-11-23 Thread Jani Nikula
The file uses bool and struct completion, include the relevant headers. Signed-off-by: Jani Nikula --- include/drm/drm_audio_component.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/drm_audio_component.h b/include/drm/drm_audio_component.h index 0d36bfd1a4cd..5a4cd1fa8e2a

Re: [Intel-gfx] [Linaro-mm-sig] Re: [PATCH] dma-buf: Require VM_PFNMAP vma for mmap

2022-11-23 Thread Christian König
Am 23.11.22 um 13:53 schrieb Jason Gunthorpe: On Wed, Nov 23, 2022 at 01:49:41PM +0100, Christian König wrote: Am 23.11.22 um 13:46 schrieb Jason Gunthorpe: On Wed, Nov 23, 2022 at 11:06:55AM +0100, Daniel Vetter wrote: Maybe a GFP flag to set the page reference count to zero or something lik

[Intel-gfx] ✗ Fi.CI.IGT: failure for More GuC firmware version improvements

2022-11-23 Thread Patchwork
== Series Details == Series: More GuC firmware version improvements URL : https://patchwork.freedesktop.org/series/111218/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12418_full -> Patchwork_111218v1_full Summary ---

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dmc: Update DG2 DMC version to v2.08 (rev2)

2022-11-23 Thread Gustavo Sousa
On Wed, Nov 23, 2022 at 05:58:38AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dmc: Update DG2 DMC version to v2.08 (rev2) > URL : https://patchwork.freedesktop.org/series/64/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_12418_full -> Pat

Re: [Intel-gfx] [PATCH] drm/audio: make drm_audio_component.h self-contained

2022-11-23 Thread Ville Syrjälä
On Wed, Nov 23, 2022 at 03:09:32PM +0200, Jani Nikula wrote: > The file uses bool and struct completion, include the relevant headers. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > include/drm/drm_audio_component.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

[Intel-gfx] PR for DG2 DMC v2.08

2022-11-23 Thread Gustavo Sousa
The following changes since commit 391fb47caabaae8719fb72ba4891d1fc27ca1923: amdgpu: update green sardine DMCUB firmware (2022-11-17 10:42:59 -0500) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware dg2_dmc_v2.8 for you to fetch changes up to 7f6279b3dd7

Re: [Intel-gfx] [Linaro-mm-sig] Re: [PATCH] dma-buf: Require VM_PFNMAP vma for mmap

2022-11-23 Thread Daniel Vetter
On Wed, 23 Nov 2022 at 14:28, Jason Gunthorpe wrote: > > On Wed, Nov 23, 2022 at 02:12:25PM +0100, Christian König wrote: > > Am 23.11.22 um 13:53 schrieb Jason Gunthorpe: > > > On Wed, Nov 23, 2022 at 01:49:41PM +0100, Christian König wrote: > > > > Am 23.11.22 um 13:46 schrieb Jason Gunthorpe: >

Re: [Intel-gfx] [PATCH v3 4/4] xhci: Convert to use list_count()

2022-11-23 Thread Mathias Nyman
On 22.11.2022 17.35, Andy Shevchenko wrote: The list API now provides the list_count() to help with counting existing nodes in the list. Utilise it. Signed-off-by: Andy Shevchenko --- v3: no change v2: no change drivers/usb/host/xhci-ring.c | 7 ++- 1 file changed, 2 insertions(+), 5 del

Re: [Intel-gfx] [Linaro-mm-sig] Re: [PATCH] dma-buf: Require VM_PFNMAP vma for mmap

2022-11-23 Thread Daniel Vetter
On Wed, 23 Nov 2022 at 14:28, Jason Gunthorpe wrote: > > On Wed, Nov 23, 2022 at 02:12:25PM +0100, Christian König wrote: > > Am 23.11.22 um 13:53 schrieb Jason Gunthorpe: > > > On Wed, Nov 23, 2022 at 01:49:41PM +0100, Christian König wrote: > > > > Am 23.11.22 um 13:46 schrieb Jason Gunthorpe: >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/audio: make drm_audio_component.h self-contained

2022-11-23 Thread Patchwork
== Series Details == Series: drm/audio: make drm_audio_component.h self-contained URL : https://patchwork.freedesktop.org/series/111254/ State : success == Summary == CI Bug Log - changes from CI_DRM_12422 -> Patchwork_111254v1 Summary

[Intel-gfx] [PATCH v4 4/4] xhci: Convert to use list_count()

2022-11-23 Thread Andy Shevchenko
The list API now provides the list_count() to help with counting existing nodes in the list. Utilise it. Signed-off-by: Andy Shevchenko Acked-by: Mathias Nyman --- v4: added tag (Mathias) v3: no change v2: no change drivers/usb/host/xhci-ring.c | 7 ++- 1 file changed, 2 insertions(+), 5 de

[Intel-gfx] [PATCH v4 1/4] i915: Move list_count() to list.h for broader use

2022-11-23 Thread Andy Shevchenko
Some of the existing users, and definitely will be new ones, want to count existing nodes in the list. Provide a generic API for that by moving code from i915 to list.h. Signed-off-by: Andy Shevchenko Acked-by: Jani Nikula --- v4: fixed prototype when converting to static inline v3: added tag (J

[Intel-gfx] [PATCH v4 2/4] usb: gadget: hid: Convert to use list_count()

2022-11-23 Thread Andy Shevchenko
The list API now provides the list_count() to help with counting existing nodes in the list. Utilise it. Signed-off-by: Andy Shevchenko --- v4: no change v3: fixed typo in the commit message (Fabio) v2: no change drivers/usb/gadget/legacy/hid.c | 7 ++- 1 file changed, 2 insertions(+), 5 del

[Intel-gfx] [PATCH v4 3/4] usb: gadget: udc: bcm63xx: Convert to use list_count()

2022-11-23 Thread Andy Shevchenko
The list API now provides the list_count() to help with counting existing nodes in the list. Utilise it. Signed-off-by: Andy Shevchenko --- v4: no change v3: no change v2: no change drivers/usb/gadget/udc/bcm63xx_udc.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git

Re: [Intel-gfx] [PATCH 01/10] drm/i915/dvo/ch7xxx: Fix suspend/resume

2022-11-23 Thread Ville Syrjälä
On Tue, Nov 22, 2022 at 02:31:55PM +0200, Jani Nikula wrote: > On Tue, 22 Nov 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Poke a few more bits into the ch7xxx to make > > it output a picture after being reset during S3. > > > > In particular we need to set the input buffer select (

Re: [Intel-gfx] [PATCH v4 1/4] i915: Move list_count() to list.h for broader use

2022-11-23 Thread Lucas De Marchi
On Wed, Nov 23, 2022 at 04:48:58PM +0200, Andy Shevchenko wrote: Some of the existing users, and definitely will be new ones, want to count existing nodes in the list. Provide a generic API for that by moving code from i915 to list.h. Signed-off-by: Andy Shevchenko Acked-by: Jani Nikula Rev

Re: [Intel-gfx] [Linaro-mm-sig] Re: [PATCH] dma-buf: Require VM_PFNMAP vma for mmap

2022-11-23 Thread Christian König
Am 23.11.22 um 16:08 schrieb Jason Gunthorpe: On Wed, Nov 23, 2022 at 03:34:54PM +0100, Daniel Vetter wrote: diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 1376a47fedeedb..4161241fc3228c 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -2598,6 +2598,19 @@ static int hv

  1   2   >