[Intel-gfx] ✗ Fi.CI.BAT: failure for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev2)

== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev2) URL : https://patchwork.freedesktop.org/series/110413/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12333 -> Patchwork_11

Re: [Intel-gfx] [PATCH 06/11] drm/i915: Deconfuse the ilk+ 12.4 LUT entry functions

LGTM. Reviewed-by: Ankit Nautiyal On 10/26/2022 5:09 PM, Ville Syrjala wrote: From: Ville Syrjälä s/icl_lut_multi_seg_pack/ilk_lut_12p4_pack/ since that's what it is and group the corresponding "unpack" functions next to it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/i

[Intel-gfx] [PULL] drm-intel-gt-next

Hi Dave & Daniel, This amends the previous PR that did cause a build error with clang: https://lists.freedesktop.org/archives/dri-devel/2022-October/377713.html Quite naturally, it includes a fix to the hwmon code tested with Clang version 14.0.5 and GCC 12.2.1. Additionally there is a screen f

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsc: Add is_dsc_supported()

== Series Details == Series: drm/i915/dsc: Add is_dsc_supported() URL : https://patchwork.freedesktop.org/series/110469/ State : success == Summary == CI Bug Log - changes from CI_DRM_12333 -> Patchwork_110469v1 Summary --- **SUCCESS

Re: [Intel-gfx] [PATCH 3/7] drm/i915/tgl+: Enable display DC power states on all eDP ports

On Wed, Nov 02, 2022 at 09:07:19PM +0200, Ville Syrjälä wrote: > On Wed, Nov 02, 2022 at 08:34:48PM +0200, Imre Deak wrote: > > On Wed, Nov 02, 2022 at 07:35:17PM +0200, Ville Syrjälä wrote: > > > On Wed, Nov 02, 2022 at 07:15:26PM +0200, Imre Deak wrote: > > > > Starting with TGL eDP is supported

[Intel-gfx] [PULL] drm-misc-next

Hi Dave, Daniel, Here's this week drm-misc-next PR Maxime drm-misc-next-2022-11-03: drm-misc-next for 6.2: UAPI Changes: Cross-subsystem Changes: - dma-buf: locking improvements - firmware: New API in the RaspberryPi firmware driver used by vc4 Core Changes: - client: Null pointer dereference

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Reduce oversaturation of request smoketesting

On 11/2/2022 4:57 PM, Nirmoy Das wrote: From: Chris Wilson The goal in launching the request smoketest is to have sufficient tasks running across the system such that we are likely to detect concurrency issues. We aim to have 2 tasks using the same engine, gt, device (each level of locking ar

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Reduce oversaturation of request smoketesting

On 11/3/2022 12:38 AM, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* drm/i915/selftests: Reduce oversaturation of request smoketesting *URL:* https://patchwork.freedesktop.org/series/110426/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Pa

[Intel-gfx] [PULL] drm-intel-fixes

Hi Dave, Daniel, A few fixes for 6.1. On the display side fixed a race condition in accessing DKL PHY registers (TGL+), fixed LVDS EDID fixed mode setup and fixed SDVO invalid mode filtering. On the GEM side fix running under Xen and use DMA API directly instead of special casing for SWIOTLB only

Re: [Intel-gfx] [PATCH] drm/i915/guc: don't hardcode BCS0 in guc_hang selftest

LGTM Acked-by: Nirmoy Das On 11/2/2022 10:43 PM, Daniele Ceraolo Spurio wrote: On MTL there are no BCS engines on the media GT, so we can't always use BCS0 in the test. There is no actual reason to use a BCS engine over an engine of a different class, so switch to using any available engine. S

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

On 03/11/2022 01:33, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote: On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the end of each test, IGT does a drop caches call via sysfs with sysfs? Sorry, that was

Re: [Intel-gfx] [PATCH 04/11] drm/i915: s/icl_load_gcmax/ivb_load_lut_max/

On Thu, Nov 03, 2022 at 11:49:20AM +0530, Nautiyal, Ankit K wrote: > Seems the offset is same since IVB. > > The Gamma correction max seem to be defined since IVB, but this doesnt > seem to be used during ivb_load_luts, but only for multi-segmented gamma. It would be used for the 12.4 interpolat

Re: [Intel-gfx] [PATCH 06/11] drm/i915: Deconfuse the ilk+ 12.4 LUT entry functions

On Wed, Oct 26, 2022 at 02:39:01PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > s/icl_lut_multi_seg_pack/ilk_lut_12p4_pack/ since that's what it is > and group the corresponding "unpack" functions next to it. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

On 03/11/2022 09:18, Tvrtko Ursulin wrote: On 03/11/2022 01:33, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote: On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the end of each test, IGT does a drop caches

Re: [Intel-gfx] [PATCH v14 1/7] overflow: Introduce overflows_type() and castable_to_type()

This patch has merged to linux-next. On 11/2/22 4:53 PM, Gwan-gyeong Mun wrote: From: Kees Cook Implement a robust overflows_type() macro to test if a variable or constant value would overflow another variable or type. This can be used as a constant expression for static_assert() (which requir

Re: [Intel-gfx] [PATCH 07/11] drm/i915: Pass limited_range explicitly to ilk_csc_convert_ctm()

Looks good to me. Reviewed-by: Ankit Nautiyal On 10/26/2022 5:09 PM, Ville Syrjala wrote: From: Ville Syrjälä Since pre-icl vs. icl+ handle the limited range output stuff a bit differently it's probably less confusing if we just pass that information explicitly into ilk_csc_convert_ctm(). S

Re: [Intel-gfx] [PATCH 08/11] drm/i915: Reuse ilk_gamma_mode() on ivb+

Makes sense. LGTM. Reviewed-by: Ankit Nautiyal On 10/26/2022 5:09 PM, Ville Syrjala wrote: From: Ville Syrjälä Apart from the split gamma mode ivb+ LUTs work just like ilk+ LUTs. So let's handle the special case, and then just fall back to ilk_gamma_mode() to avoid having to duplicate the sa

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Reject YCbCr output with degamma+gamma on pre-icl

LGTM. Reviewed-by: Ankit Nautiyal On 10/26/2022 5:09 PM, Ville Syrjala wrote: From: Ville Syrjälä Since the pipe CSC sits between the degamma and gamma LUTs there is no way to make us it for RGB->YCbCr conversion when both LUTs are also active. Simply reject such combos. Signed-off-by: Vill

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Reduce oversaturation of request smoketesting

Hi Nirmoy, On Wed, Nov 02, 2022 at 04:57:09PM +0100, Nirmoy Das wrote: > From: Chris Wilson > > The goal in launching the request smoketest is to have sufficient tasks > running across the system such that we are likely to detect concurrency > issues. We aim to have 2 tasks using the same engine

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev2)

On 11/3/22 9:07 AM, Patchwork wrote: *Patch Details* *Series:* Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev2) *URL:* https://patchwork.freedesktop.org/series/110413/

Re: [Intel-gfx] [PATCH 10/11] drm/i915: Share {csc, gamma}_enable calculation for ilk/snb vs. ivb+

LGTM. Reviewed-by: Ankit Nautiyal On 10/26/2022 5:09 PM, Ville Syrjala wrote: From: Ville Syrjälä ilk/snb vs. ivb+ hardware is mostly identical except for the addition of the split gamma mode on ivb. Thus we can share the csc_enable and gamma_enable calculation for both variants. Pull that s

Re: [Intel-gfx] [PATCH 04/11] drm/i915: s/icl_load_gcmax/ivb_load_lut_max/

On 11/3/2022 3:04 PM, Ville Syrjälä wrote: On Thu, Nov 03, 2022 at 11:49:20AM +0530, Nautiyal, Ankit K wrote: Seems the offset is same since IVB. The Gamma correction max seem to be defined since IVB, but this doesnt seem to be used during ivb_load_luts, but only for multi-segmented gamma. I

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: don't hardcode BCS0 in guc_hang selftest

== Series Details == Series: drm/i915/guc: don't hardcode BCS0 in guc_hang selftest URL : https://patchwork.freedesktop.org/series/110448/ State : success == Summary == CI Bug Log - changes from CI_DRM_12333_full -> Patchwork_110448v1_full

Re: [Intel-gfx] [PATCH v14 3/7] drm/i915: Check for integer truncation on scatterlist creation

On 11/2/22 4:53 PM, Gwan-gyeong Mun wrote: From: Chris Wilson There is an impedance mismatch between the scatterlist API using unsigned int and our memory/page accounting in unsigned long. That is we may try to create a scatterlist for a large object that overflows returning a small table int

Re: [Intel-gfx] [PATCH] drm/i915: rename intel_gsc to intel_heci_gsc

> > Starting on MTL, the GSC FW is loaded at runtime and will be managed > directly by i915. This means we now have a naming clash around the GSC, as > we have 2 different aspects of it that we need to handle: the HECI interfaces > we export pre-mtl and the new full FW loading and support we have

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

On Wed, 02 Nov 2022, John Harrison wrote: > On 11/2/2022 07:20, Tvrtko Ursulin wrote: >> On 02/11/2022 12:12, Jani Nikula wrote: >>> On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the end of each test, IGT does a drop caches call via sysfs with >>> >>>

Re: [Intel-gfx] [PATCH v14 3/7] drm/i915: Check for integer truncation on scatterlist creation

On Thu, 03 Nov 2022, Gwan-gyeong Mun wrote: > On 11/2/22 4:53 PM, Gwan-gyeong Mun wrote: >> From: Chris Wilson >> >> There is an impedance mismatch between the scatterlist API using unsigned >> int and our memory/page accounting in unsigned long. That is we may try >> to create a scatterlist for

Re: [Intel-gfx] [v3] drm/i915/pps: improve eDP power on flow

On Thu, 03 Nov 2022, Lee Shawn C wrote: > After i915 dirver initialized, a panel power off cycle delay > always append before turn eDP on. If eDP display did not > power on before. With this change, power off duration might > longer than power cycle delay. So driver can save power cycle > delay to

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/i915/module_load: restore gem_sanitycheck for discrete

Reviewed-by: nirmoy@intel.com On 11/2/2022 4:05 PM, Matthew Auld wrote: This looks to be recently broken in: 5389b3f3 ("tests/i915/i915_module_load: Use GEM_BUSY instead of SET_CACHE for sanity check"). Which fails on discrete platforms, since we switched over to the gem_busy ioctl, from th

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/i915/module_load: restore gem_sanitycheck for discrete

Reviewed-by: Nirmoy Das On 11/3/2022 12:10 PM, Das, Nirmoy wrote: Reviewed-by: nirmoy@intel.com On 11/2/2022 4:05 PM, Matthew Auld wrote: This looks to be recently broken in: 5389b3f3 ("tests/i915/i915_module_load: Use GEM_BUSY instead of SET_CACHE for sanity check"). Which fails on disc

Re: [Intel-gfx] [v3] drm/i915/pps: improve eDP power on flow

On Thursday, November 3, 2022 7:00 PM, Jani Nikula wrote: >On Thu, 03 Nov 2022, Lee Shawn C wrote: >> After i915 dirver initialized, a panel power off cycle delay always >> append before turn eDP on. If eDP display did not power on before. >> With this change, power off duration might longer t

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset

On 02/11/2022 19:21, john.c.harri...@intel.com wrote: From: John Harrison The engine busyness stats has a worker function to do things like 64bit extend the 32bit hardware counters. The GuC's reset prepare function flushes out this worker function to ensure no corruption happens during the re

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Allocate power domain set wakerefs dynamically

On Wed, Nov 02, 2022 at 08:57:21PM +0200, Jani Nikula wrote: > On Wed, 02 Nov 2022, Imre Deak wrote: > > Since the intel_display_power_domain_set struct, currently its current > > size close 1kB, can be allocated on the stack, it's better to allocate > > the per-domain wakeref pointer array - used

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Factor out function to get/put AUX_IO power for main link

On Wed, Nov 02, 2022 at 09:02:41PM +0200, Jani Nikula wrote: > On Wed, 02 Nov 2022, Imre Deak wrote: > > Factor out functions to get/put the AUX_IO power domain for the main > > link on DDI ports. > > > > While at it clarify the corresponding code comment. > > > > No functional change. > > > > Sig

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftest: Bump up sample period for busy stats selftest

== Series Details == Series: drm/i915/selftest: Bump up sample period for busy stats selftest URL : https://patchwork.freedesktop.org/series/110454/ State : success == Summary == CI Bug Log - changes from CI_DRM_12333_full -> Patchwork_110454v1_full

Re: [Intel-gfx] [PATCH] drm/i915/selftest: Bump up sample period for busy stats selftest

On 03/11/2022 00:11, Umesh Nerlige Ramappa wrote: Engine busyness samples around a 10ms period is failing with busyness ranging approx. from 87% to 115%. The expected range is +/- 5% of the sample period. When determining busyness of active engine, the GuC based engine busyness implementation

[Intel-gfx] [PATCH 5/6] drm/i915: Extract VESA DSC bpp alignment to separate function

We might to use that function separately from intel_dp_dsc_compute_config for DP DSC over MST case, because allocating bandwidth in that case can be a bit more tricky. So in order to avoid code copy-pasta lets extract this to separate function and reuse it for both SST and MST cases. v2: Removed m

[Intel-gfx] [PATCH 6/6] drm/i915: Bpp/timeslot calculation fixes for DP MST DSC

Fix intel_dp_dsc_compute_config, previously timeslots parameter was used in fact not as a timeslots, but more like a ratio timeslots/64, which of course didn't have any effect for SST DSC, but causes now issues for MST DSC. Secondly we need to calculate pipe_bpp using intel_dp_dsc_compute_bpp only

[Intel-gfx] [PATCH v1] drm/i915/gt: Add sysfs RAPL PL1 interface

Adding the rapl_pl1_freq_mhz sysfs attribute. Signed-off-by: Sujaritha Sundaresan Cc: Ashutosh Dixit --- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 20 ++ drivers/gpu/drm/i915/gt/intel_rps.c | 44 + drivers/gpu/drm/i915/gt/intel_rps.h | 3 ++ driv

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pps: improve eDP power on flow. (rev3)

== Series Details == Series: drm/i915/pps: improve eDP power on flow. (rev3) URL : https://patchwork.freedesktop.org/series/110038/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12333_full -> Patchwork_110038v3_full Summary

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Add DP MST DSC support to i915 (rev16)

== Series Details == Series: Add DP MST DSC support to i915 (rev16) URL : https://patchwork.freedesktop.org/series/101492/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/i915_perf_types.h:319: warning: Function parameter or member 'lock' not descri

[Intel-gfx] [PATCH RFC v2 6/8] drm/i915: add perf selftests to KUnit

Now that i915 KUnit has PCI support, add perf tests as well. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH RFC v2 0/8] at: https://lore.kernel.org/all/cover.1667486144.git.mche...@kernel.org/ dr

[Intel-gfx] [PATCH RFC v2 5/8] drm/i915: add live selftests to KUnit

Now that i915 KUnit has PCI support, add live tests as well. NOTE: currently, some tests are failing when excecuting via KUnit. I'll do a further investigation to check why, and if this patch can be safely merged or not. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large n

[Intel-gfx] [PATCH RFC v2 3/8] drm/i915: allow running mock selftests via Kunit

The mock selftests don't require any hardware to run. They can easily run via kunit with qemu or bare metal. Add support for it. With this change, mock selftest can now run in qemu with: $ ./tools/testing/kunit/kunit.py run --arch=x86_64 \ --kunitconfig=drivers/gpu/drm/i9

[Intel-gfx] [PATCH RFC v2 7/8] drm/i915: now that all functions are used, remove __maybe_unused

The PCI-specific KUnit tests that run in bare metal got added, so we can remove the __maybe_unused from such functions. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH RFC v2 0/8] at: https://lore.k

[Intel-gfx] [PATCH RFC v2 1/8] drm/i915: export all selftest functions

In order to prepare for a new KUnit module that will run selftests, export all selftest functions to I915_SELFTEST namespace. No functional changes. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH R

[Intel-gfx] [PATCH RFC v2 4/8] drm/i915: add support to run KUnit tests on bare metal

Add a logic to seek for PCI devices and to run tests on them, if the tests are willing to run on physical hardware, instead of using Qemu. Later patches will add the KUnit tests. So, for now, mark such functions with __maybe_unused, to avoid build issues with WERROR. Signed-off-by: Mauro Carvalho

[Intel-gfx] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

The mmap tests require mm in order to work. Failing to do that will cause a crash: [ 316.820722] BUG: kernel NULL pointer dereference, address: 00e8 [ 316.822517] #PF: supervisor write access in kernel mode [ 316.823430] #PF: error_code(0x0002) - not-present page [ 316.824390] PGD

[Intel-gfx] [PATCH RFC v2 2/8] drm/i915: place selftest preparation on a separate function

The selftest preparation logic should also be used by KUnit. So, place it on a separate function and export it. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH RFC v2 0/8] at: https://lore.kernel.or

[Intel-gfx] [PATCH RFC v2 0/8] Add KUnit support for i915 driver

This RFC patch series implement KUnit support for i915 driver, using the already-existing tests inside i915 selftests. On this version, mock selftest can now run in qemu with: $ ./tools/testing/kunit/kunit.py run --arch=x86_64 \ --kunitconfig=drivers/gpu/drm/i915/selftests

[Intel-gfx] ✓ Fi.CI.BAT: success for Add DP MST DSC support to i915 (rev16)

== Series Details == Series: Add DP MST DSC support to i915 (rev16) URL : https://patchwork.freedesktop.org/series/101492/ State : success == Summary == CI Bug Log - changes from CI_DRM_12337 -> Patchwork_101492v16 Summary --- **SUCC

[Intel-gfx] [PATCH v3 00/23] drm/fb-helper: Untangle fbdev emulation and helpers

Separate generic fbdev emulation from the helper code that is shared among the various fbdev implementations within DRM. Affects many drivers. It has become apparent that our fully generic fbdev emulation will never produce optimal results for all drivers. In its current form, it is also hard to m

[Intel-gfx] [PATCH v3 05/23] drm/imx/dcss: Don't set struct drm_driver.output_poll_changed

Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as DCSS uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm_pr

[Intel-gfx] [PATCH v3 01/23] drm/komeda: Don't set struct drm_driver.lastclose

Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as komeda uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann Reviewed-by: Ja

[Intel-gfx] [PATCH v3 02/23] drm/mcde: Don't set struct drm_driver.lastclose

Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as mcde uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann Reviewed-by: Javi

[Intel-gfx] [PATCH v3 04/23] drm/amdgpu: Don't set struct drm_driver.output_poll_changed

Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as amdgpu uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm_

[Intel-gfx] [PATCH v3 07/23] drm/logicvc: Don't set struct drm_driver.output_poll_changed

Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as logicvc uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm

[Intel-gfx] [PATCH v3 03/23] drm/vboxvideo: Don't set struct drm_driver.lastclose

Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as vboxvideo uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann Reviewed-by:

[Intel-gfx] [PATCH v3 09/23] drm/panel-ili9341: Include

Include for devm_of_find_backlight(). Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-i

[Intel-gfx] [PATCH v3 10/23] drm/tve200: Include

Include for of_match_ptr(). Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/tve200/tve200_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c index 04db72e3fa9c2..611785e

[Intel-gfx] [PATCH v3 06/23] drm/ingenic: Don't set struct drm_driver.output_poll_changed

Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as ingenic uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm

[Intel-gfx] [PATCH v3 08/23] drm/rockchip: Don't set struct drm_driver.output_poll_changed

Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as rockchip uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in dr

[Intel-gfx] [PATCH v3 11/23] drm/fb-helper: Cleanup include statements in header file

Only include what we have to. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- include/drm/drm_fb_helper.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index fddd0d1af6891..e92308952

[Intel-gfx] [PATCH v3 13/23] drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix

Rename drm_fb_helper_alloc_fbi() to drm_fb_helper_alloc_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm

[Intel-gfx] [PATCH v3 20/23] drm/fb-helper: Set flag in struct drm_fb_helper for leaking physical addresses

Uncouple the parameter drm_leak_fbdev_smem from the implementation by setting a flag in struct drm_fb_helper. This will help to move the generic fbdev emulation into its own source file, while keeping the parameter in drm_fb_helper.c. No functional changes. Signed-off-by: Thomas Zimmermann --- d

[Intel-gfx] [PATCH v3 21/23] drm/fb-helper: Move generic fbdev emulation into separate source file

Move the generic fbdev implementation into its own source and header file. Adapt drivers. No functional changes, but some of the internal helpers have been renamed to fit into the drm_fbdev_ naming scheme. v3: * rename drm_fbdev.{c,h} to drm_fbdev_generic.{c,h} * rebase onto vmwgfx

[Intel-gfx] [PATCH v3 23/23] drm/fb-helper: Clarify use of last_close and output_poll_changed

Clarify documentation in the use of struct drm_driver.last_close and struct drm_mode_config_funcs.output_poll_changed. Those callbacks should not be said for fbdev implementations on top of struct drm_client_funcs. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 6 --

[Intel-gfx] [PATCH v3 19/23] drm/fb-helper: Always initialize generic fbdev emulation

Initialize the generic fbdev emulation even if it has been disabled on the kernel command line. The hotplug and mode initialization will fail accordingly. The kernel parameter can still be changed at runtime and the emulation will initialize after hotplugging the connector. Signed-off-by: Thomas

[Intel-gfx] [PATCH v3 12/23] drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper

Rename struct drm_fb_helper.fbdev to info. The current name is misleading as it overlaps with generic fbdev naming conventions. Adapt to the usual naming in fbdev drivers by calling the field 'info'. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --

[Intel-gfx] [PATCH v3 14/23] drm/fb-helper: Rename drm_fb_helper_unregister_fbi() to use _info postfix

Rename drm_fb_helper_unregister_fbi() to drm_fb_helper_unregister_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drive

[Intel-gfx] [PATCH v3 22/23] drm/fb-helper: Remove unnecessary include statements

Remove include statements for where it is not required (i.e., most of them). In a few places include other header files that are required by the source code. v3: * fix amdgpu include statements * fix rockchip include statements Signed-off-by: Thomas Zimmermann Reviewed-by: Javie

[Intel-gfx] [PATCH v3 17/23] drm/fb-helper: Perform all fbdev I/O with the same implementation

Implement the fbdev's read/write helpers with the same functions. Use the generic fbdev's code as template. Convert all drivers. DRM's fb helpers must implement regular I/O functionality in struct fb_ops and possibly perform a damage update. Handle all this in the same functions and convert driver

[Intel-gfx] [PATCH v3 15/23] drm/fb-helper: Disconnect damage worker from update logic

The fbdev helpers implement a damage worker that forwards fbdev updates to the DRM driver. The worker's update logic depends on the generic fbdev emulation. Separate the two via function pointer. The generic fbdev emulation sets struct drm_fb_helper_funcs.fb_dirty, a new callback that hides the up

[Intel-gfx] [PATCH v3 16/23] drm/fb-helper: Call fb_sync in I/O functions

Call struct fb_ops.fb_sync in drm_fbdev_{read,write}() to mimic the behavior of fbdev. Fbdev implementations of fb_read and fb_write in struct fb_ops invoke fb_sync to synchronize with outstanding operations before I/O. Doing the same in DRM implementations will allow us to use them throughout DRM

[Intel-gfx] [PATCH v3 18/23] drm/fb_helper: Minimize damage-helper overhead

Pull the test for fb_dirty into the caller to avoid extra work if no callback has been set. In this case no damage handling is required and no damage area needs to be computed. Print a warning if the damage worker runs without getting an fb_dirty callback. Signed-off-by: Thomas Zimmermann Reviewe

[Intel-gfx] KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

Hi, I'm facing a couple of issues when testing KUnit with the i915 driver. The DRM subsystem and the i915 driver has, for a long time, his own way to do unit tests, which seems to be added before KUnit. I'm now checking if it is worth start using KUnit at i915. So, I wrote a RFC with some patche

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Don't wait forever in drop_caches (rev2)

== Series Details == Series: drm/i915: Don't wait forever in drop_caches (rev2) URL : https://patchwork.freedesktop.org/series/110395/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12333_full -> Patchwork_110395v2_full Summ

[Intel-gfx] [PATCH] mei: add timeout to send

When driver wakes up the firmware from the low power stand, it is sending a memory ready message. The send is done via synchronous/blocking function to ensure that firmware is in ready state. However firmware might be in unstable state and send might be block forever. To address this issue a timeou

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Use kmap_local_page() in gem/i915_gem_shmem.c

On Mon, Oct 17, 2022 at 05:37:19PM +0800, Zhao Liu wrote: > From: Zhao Liu > > The use of kmap_atomic() is being deprecated in favor of > kmap_local_page()[1]. > > The main difference between atomic and local mappings is that local > mappings doesn't disable page faults or preemption. > > In dr

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Use kmap_local_page() in gem/i915_gem_object.c

On Sat, Oct 29, 2022 at 01:17:03PM +0200, Fabio M. De Francesco wrote: > On lunedì 17 ottobre 2022 11:37:17 CEST Zhao Liu wrote: > > From: Zhao Liu > > > > The use of kmap_atomic() is being deprecated in favor of > > kmap_local_page()[1]. > > > > The main difference between atomic and local mapp

Re: [Intel-gfx] [PATCH] drm/i915/selftest: Bump up sample period for busy stats selftest

On Wed, 02 Nov 2022 17:11:49 -0700, Umesh Nerlige Ramappa wrote: > > Engine busyness samples around a 10ms period is failing with busyness > ranging approx. from 87% to 115%. The expected range is +/- 5% of the > sample period. > > When determining busyness of active engine, the GuC based engine >

[Intel-gfx] [PATCH] i915/pmu: Use a faster read for 2x32 mmio reads

PMU reads the GT timestamp as a 2x32 mmio read and since upper and lower 32 bit registers are read in a loop, there is a latency involved in getting the GT timestamp. To reduce the latency, define another version of the helper that requires caller to acquire uncore->spinlock and necessary forcewake

Re: [Intel-gfx] [PATCH] drm/i915/selftest: Bump up sample period for busy stats selftest

On Thu, Nov 03, 2022 at 12:28:46PM +, Tvrtko Ursulin wrote: On 03/11/2022 00:11, Umesh Nerlige Ramappa wrote: Engine busyness samples around a 10ms period is failing with busyness ranging approx. from 87% to 115%. The expected range is +/- 5% of the sample period. When determining busyness

Re: [Intel-gfx] [PATCH] i915/pmu: Use a faster read for 2x32 mmio reads

On Thu, Nov 03, 2022 at 11:07:05AM -0700, Umesh Nerlige Ramappa wrote: PMU reads the GT timestamp as a 2x32 mmio read and since upper and lower 32 bit registers are read in a loop, there is a latency involved in getting the GT timestamp. To reduce the latency, define another version of the helper

Re: [Intel-gfx] [PATCH] drm/i915/selftest: Bump up sample period for busy stats selftest

On Thu, Nov 03, 2022 at 10:01:11AM -0700, Dixit, Ashutosh wrote: On Wed, 02 Nov 2022 17:11:49 -0700, Umesh Nerlige Ramappa wrote: Engine busyness samples around a 10ms period is failing with busyness ranging approx. from 87% to 115%. The expected range is +/- 5% of the sample period. When dete

[Intel-gfx] [PATCH v2] drm/i915/mtl: Add Wa_14017073508 for SAMedia

This workaround is added for Media tile of MTL A step. It is to help pcode workaround which handles the hardware issue seen during package C2/C3 transitions due to RC6 entry/exit transitions on Media tile. As a part of workaround pcode expect kmd to send mailbox message "media busy" when components

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset

On 11/3/2022 04:31, Tvrtko Ursulin wrote: On 02/11/2022 19:21, john.c.harri...@intel.com wrote: From: John Harrison The engine busyness stats has a worker function to do things like 64bit extend the 32bit hardware counters. The GuC's reset prepare function flushes out this worker function to e

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset

On Thu, Nov 03, 2022 at 11:45:57AM -0700, John Harrison wrote: On 11/3/2022 04:31, Tvrtko Ursulin wrote: On 02/11/2022 19:21, john.c.harri...@intel.com wrote: From: John Harrison The engine busyness stats has a worker function to do things like 64bit extend the 32bit hardware counters. The Gu

Re: [Intel-gfx] [PATCH] drm/i915/guc: Remove excessive line feeds in state dumps

On Mon, Oct 31, 2022 at 03:00:07PM -0700, john.c.harri...@intel.com wrote: From: John Harrison Some of the GuC state dump messages were adding extra line feeds. When printing via a DRM printer to dmesg, for example, that messes up the log formatting as it loses any prefixing from the printer. G

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Use memcpy_from_page() in gt/uc/intel_uc_fw.c

On Mon, Oct 17, 2022 at 05:37:23PM +0800, Zhao Liu wrote: > From: Zhao Liu > > The use of kmap_atomic() is being deprecated in favor of > kmap_local_page()[1]. > > The main difference between atomic and local mappings is that local > mappings doesn't disable page faults or preemption. > > In dr

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

On 11/3/2022 02:38, Tvrtko Ursulin wrote: On 03/11/2022 09:18, Tvrtko Ursulin wrote: On 03/11/2022 01:33, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote: On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gt: Add sysfs RAPL PL1 interface

== Series Details == Series: drm/i915/gt: Add sysfs RAPL PL1 interface URL : https://patchwork.freedesktop.org/series/110476/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/110476/revisions/1/mbox/ not applied Applying: drm/i915/gt: Add sysfs RAPL

Re: [Intel-gfx] [PATCH] drm/i915/dsc: Add is_dsc_supported()

On Thu, Nov 03, 2022 at 11:32:22AM +0530, Swati Sharma wrote: > Lets use RUNTIME_INFO->has_dsc since platforms supporting dsc has this > flag enabled. > > This is done based on the review comments received on > https://patchwork.freedesktop.org/patch/509393/ > > Signed-off-by: Swati Sharma > ---

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Use kmap_local_page() in gem/i915_gem_object.c

On giovedì 3 novembre 2022 17:51:23 CET Ira Weiny wrote: > On Sat, Oct 29, 2022 at 01:17:03PM +0200, Fabio M. De Francesco wrote: > > On lunedì 17 ottobre 2022 11:37:17 CEST Zhao Liu wrote: > > > From: Zhao Liu > > > > > > The use of kmap_atomic() is being deprecated in favor of > > > kmap_local_

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsc: Add is_dsc_supported()

== Series Details == Series: drm/i915/dsc: Add is_dsc_supported() URL : https://patchwork.freedesktop.org/series/110469/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12333_full -> Patchwork_110469v1_full Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add KUnit support for i915 driver

== Series Details == Series: Add KUnit support for i915 driver URL : https://patchwork.freedesktop.org/series/110483/ State : warning == Summary == Error: dim checkpatch failed 1c12427bb8a0 drm/i915: export all selftest functions 100f0a51abe8 drm/i915: place selftest preparation on a separate

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add KUnit support for i915 driver

== Series Details == Series: Add KUnit support for i915 driver URL : https://patchwork.freedesktop.org/series/110483/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

On 11/3/2022 02:18, Tvrtko Ursulin wrote: On 03/11/2022 01:33, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote: On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the end of each test, IGT does a drop caches cal

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

On 11/3/2022 03:45, Jani Nikula wrote: On Wed, 02 Nov 2022, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula wrote: On Tue, 01 Nov 2022, john.c.harri...@intel.com wrote: From: John Harrison At the end of each test, IGT does a drop caches ca

[Intel-gfx] ✓ Fi.CI.BAT: success for Add KUnit support for i915 driver

== Series Details == Series: Add KUnit support for i915 driver URL : https://patchwork.freedesktop.org/series/110483/ State : success == Summary == CI Bug Log - changes from CI_DRM_12339 -> Patchwork_110483v1 Summary --- **SUCCESS**

  1   2   >