Re: [Intel-gfx] [PATCH 06/20] drm/i915/mtl: Add vswing programming for C10 phys

From: Taylor, Clinton A Sent: Monday, October 31, 2022 10:29 PM To: Kahola, Mika ; intel-gfx@lists.freedesktop.org Cc: Sripada, Radhakrishna ; Deak, Imre ; Shankar, Uma Subject: Re: [PATCH 06/20] drm/i915/mtl: Add vswing programming for C10 phys to fix the FIXME in intel_cx0_phy_set_signal_leve

Re: [Intel-gfx] [PATCH 01/10] vfio: Move vfio_device driver open/close code to a function

> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:17 AM > > This error unwind is getting complicated. Move all the code into two > pair'd function. The functions should be called when the open_count == 1 > after incrementing/before decrementing. > > Signed-off-by: Jason Gunthorpe R

Re: [Intel-gfx] [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()

> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:17 AM > > +err_container: > + vfio_device_unassign_container(device); > err_module_put: > device->kvm = NULL; err_module_put should be moved after nullifying device->kvm. otherwise it looks good to me: Reviewed-by: Kevin

Re: [Intel-gfx] [PATCH 03/10] vfio: Rename vfio_device_assign/unassign_container()

> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:17 AM > > These functions don't really assign anything anymore, they just increment > some refcounts and do a sanity check. Call them > vfio_group_[un]use_container() > > Signed-off-by: Jason Gunthorpe Reviewed-by: Kevin Tian

Re: [Intel-gfx] [PATCH 05/10] vfio: Use IOMMU_CAP_ENFORCE_CACHE_COHERENCY for vfio_file_enforced_coherent()

> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:17 AM > > iommufd doesn't establish the iommu_domains until after the device FD is > opened, even if the container has been set. This design is part of moving > away from the group centric iommu APIs. > > This is fine, except that the

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/mtl: Add C10 and C20 phy support (rev3)

== Series Details == Series: drm/i915/mtl: Add C10 and C20 phy support (rev3) URL : https://patchwork.freedesktop.org/series/109714/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/109714/revisions/3/mbox/ not applied warning: quoted CRLF detected

[Intel-gfx] [PATCH] drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11

i915 driver supports DSC from DISPLAY_VER >= 11. Fix it. Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/display/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 7400d6

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dg2: Introduce Wa_18017747507 (rev2)

== Series Details == Series: drm/i915/dg2: Introduce Wa_18017747507 (rev2) URL : https://patchwork.freedesktop.org/series/110323/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12325_full -> Patchwork_110323v2_full Summary -

Re: [Intel-gfx] [PATCH 06/10] vfio-iommufd: Allow iommufd to be used in place of a container fd

> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:51 AM > > menuconfig VFIO > tristate "VFIO Non-Privileged userspace driver framework" > select IOMMU_API > + depends on IOMMUFD || !IOMMUFD Out of curiosity. What is the meaning of this dependency claim? > @@ -717,12

Re: [Intel-gfx] [PATCH 07/10] vfio-iommufd: Support iommufd for physical VFIO devices

> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:51 AM > > +int vfio_iommufd_bind(struct vfio_device *vdev, struct iommufd_ctx *ictx) > +{ > + u32 ioas_id; > + u32 device_id; > + int ret; > + > + lockdep_assert_held(&vdev->dev_set->lock); > + > + /* > + * If

[Intel-gfx] [PATCH v2] i915: use surface size for bios fb size check

Lenovo laptop BIOS (possibly other vendors too) provide a framebuffer with the size of the primary display. The BIOS selects the primary display to be the internal display (lid open) or external display (lid closed). Thus, if the external display supports higher resolution than the internal one, a

Re: [Intel-gfx] [PATCH 08/10] vfio-iommufd: Support iommufd for emulated VFIO devices

> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:51 AM > > Emulated VFIO devices are calling vfio_register_emulated_iommu_dev() and > consist of all the mdev drivers. > > Like the physical drivers, support for iommufd is provided by the driver > supplying the correct correct standar

Re: [Intel-gfx] [PATCH 09/10] vfio: Make vfio_container optionally compiled

> From: Jason Gunthorpe > Sent: Wednesday, October 26, 2022 2:51 AM > > if VFIO > +config VFIO_CONTAINER > + bool "Support for the VFIO container /dev/vfio/vfio" > + select VFIO_IOMMU_TYPE1 if MMU && (X86 || S390 || ARM || > ARM64) > + default y > + help > + The VFIO contai

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11

== Series Details == Series: drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11 URL : https://patchwork.freedesktop.org/series/110353/ State : success == Summary == CI Bug Log - changes from CI_DRM_12325 -> Patchwork_110353v1 Summary

Re: [Intel-gfx] [PATCH v7 0/9] dyndbg: drm.debug adaptation

On Mon, Oct 31, 2022 at 08:20:54PM -0400, Jason Baron wrote: > > > On 10/31/22 6:11 PM, jim.cro...@gmail.com wrote: > > On Mon, Oct 31, 2022 at 7:07 AM Ville Syrjälä > > wrote: > >> On Sun, Oct 30, 2022 at 08:42:52AM -0600, jim.cro...@gmail.com wrote: > >>> On Thu, Oct 27, 2022 at 2:10 PM Ville

[Intel-gfx] ✗ Fi.CI.DOCS: warning for i915: use surface size for bios fb size check (rev2)

== Series Details == Series: i915: use surface size for bios fb size check (rev2) URL : https://patchwork.freedesktop.org/series/109114/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/i915_perf_types.h:319: warning: Function parameter or member 'lo

Re: [Intel-gfx] [PATCH v1 4/7] vfio/ccw: move private to mdev lifecycle

> From: Eric Farman > Sent: Thursday, October 20, 2022 12:22 AM > > @@ -101,15 +101,20 @@ static int vfio_ccw_mdev_probe(struct > mdev_device *mdev) > { > struct subchannel *sch = to_subchannel(mdev->dev.parent); > struct vfio_ccw_parent *parent = dev_get_drvdata(&sch->dev); > -

Re: [Intel-gfx] [PATCH v1 5/7] vfio/ccw: remove release completion

> From: Eric Farman > Sent: Thursday, October 20, 2022 12:22 AM > > There's enough separation between the parent and private structs now, > that it is fine to remove the release completion hack. > > Signed-off-by: Eric Farman Reviewed-by: Kevin Tian

Re: [Intel-gfx] [PATCH v1 6/7] vfio/ccw: replace vfio_init_device with _alloc_

> From: Eric Farman > Sent: Thursday, October 20, 2022 12:22 AM > > Now that we have a reasonable separation of structs that follow > the subchannel and mdev lifecycles, there's no reason we can't > call the official vfio_alloc_device routine for our private data, > and behave like everyone else.

Re: [Intel-gfx] [PATCH v1 7/7] vfio: Remove vfio_free_device

> From: Eric Farman > Sent: Thursday, October 20, 2022 12:22 AM > > With the "mess" sorted out, we should be able to inline the > vfio_free_device call introduced by commit cb9ff3f3b84c > ("vfio: Add helpers for unifying vfio_device life cycle") > and remove them from driver release callbacks. >

Re: [Intel-gfx] [PATCH 06/10] vfio-iommufd: Allow iommufd to be used in place of a container fd

On Tue, Nov 01, 2022 at 08:09:52AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > menuconfig VFIO > > tristate "VFIO Non-Privileged userspace driver framework" > > select IOMMU_API > > + depends on IOMMUFD || !IOMMUFD >

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: use surface size for bios fb size check (rev2)

== Series Details == Series: i915: use surface size for bios fb size check (rev2) URL : https://patchwork.freedesktop.org/series/109114/ State : success == Summary == CI Bug Log - changes from CI_DRM_12325 -> Patchwork_109114v2 Summary

[Intel-gfx] [PATCH 1/6] drm: Add missing DP DSC extended capability definitions.

Adding DP DSC register definitions, we might need for further DSC implementation, supporting MST and DP branch pass-through mode. v2: - Fixed checkpatch comment warning v3: - Removed function which is not yet used(Jani Nikula) Reviewed-by: Vinod Govindapillai Signed-off-by: Stanislav Lisovskiy

[Intel-gfx] [PATCH 0/6] Add DP MST DSC support to i915

Currently we have only DSC support for DP SST. Stanislav Lisovskiy (6): drm: Add missing DP DSC extended capability definitions. drm/i915: Fix intel_dp_mst_compute_link_config drm/i915: Extract drm_dp_atomic_find_vcpi_slots cycle to separate function drm/i915: Add DSC support to MST pa

[Intel-gfx] [PATCH 2/6] drm/i915: Fix intel_dp_mst_compute_link_config

We currently always exit that bpp loop because drm_dp_atomic_find_vcpi_slots doesn't care if we actually can fit those or not. I think that wasn't the initial intention here, especially when we keep trying with lower bpps, we are supposed to keep trying until we actually find some _working_ configu

[Intel-gfx] [PATCH 3/6] drm/i915: Extract drm_dp_atomic_find_vcpi_slots cycle to separate function

We would be using almost same code to loop through bpps while calling drm_dp_atomic_find_vcpi_slots - lets remove this duplication by introducing a new function intel_dp_mst_find_vcpi_slots_for_bpp v2: Fix pbn_div calculation - shouldn't matter if its DSC or not. v3: FIx rebase conflict, constant_

[Intel-gfx] [PATCH 4/6] drm/i915: Add DSC support to MST path

Whenever we are not able to get enough timeslots for required PBN, let's try to allocate those using DSC, just same way as we do for SST. v2: Removed intel_dp_mst_dsc_compute_config and refactored intel_dp_dsc_compute_config to support timeslots as a parameter(Ville Syrjälä) v3: - Rebased

[Intel-gfx] [PATCH 6/6] drm/i915: Bpp/timeslot calculation fixes for DP MST DSC

Fix intel_dp_dsc_compute_config, previously timeslots parameter was used in fact not as a timeslots, but more like a ratio timeslots/64, which of course didn't have any effect for SST DSC, but causes now issues for MST DSC. Secondly we need to calculate pipe_bpp using intel_dp_dsc_compute_bpp only

[Intel-gfx] [PATCH 5/6] drm/i915: Extract VESA DSC bpp alignment to separate function

We might to use that function separately from intel_dp_dsc_compute_config for DP DSC over MST case, because allocating bandwidth in that case can be a bit more tricky. So in order to avoid code copy-pasta lets extract this to separate function and reuse it for both SST and MST cases. Signed-off-by

Re: [Intel-gfx] [v2] drm/i915/pps: improve eDP power on flow

On Mon, 24 Oct 2022, Lee Shawn C wrote: > A panel power off cycle delay always append before turn eDP on. > Driver should check last_power_on and last_backlight_off before > insert this delay. If these values are the same, it means eDP > was off until now and driver can bypass power off cycle dela

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset

On 31/10/2022 18:30, John Harrison wrote: On 10/31/2022 05:51, Tvrtko Ursulin wrote: On 31/10/2022 10:09, Tvrtko Ursulin wrote: On 28/10/2022 20:46, john.c.harri...@intel.com wrote: From: John Harrison The engine busyness stats has a worker function to do things like 64bit extend the 32bit

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use intel_crtc_needs_modeset() more

On Mon, 31 Oct 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Prefer our own intel_crtc_needs_modeset() wrapper to > drm_atomic_crtc_needs_modeset() whenever we are dealing > with the intel_ types instead of drm_ types. Makes things > a bit neater in general. > > Signed-off-by: Ville Syrjäl

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11

== Series Details == Series: drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11 URL : https://patchwork.freedesktop.org/series/110353/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12325_full -> Patchwork_110353v1_full

Re: [Intel-gfx] [PATCH v2] drm/i915/hwmon: Fix a build error used with clang compiler

On Mon, 31 Oct 2022, "Dixit, Ashutosh" wrote: > On Sun, 30 Oct 2022 23:37:59 -0700, Gwan-gyeong Mun wrote: >> > > Hi GG, > >> On 10/31/22 7:19 AM, Dixit, Ashutosh wrote: >> > On Fri, 28 Oct 2022 21:42:30 -0700, Gwan-gyeong Mun wrote: >> >> >> >> diff --git a/drivers/gpu/drm/i915/i915_hwmon.c >> >

Re: [Intel-gfx] [v2] drm/i915/pps: improve eDP power on flow

On Tuesday, November 1, 2022 5:53 PM, Jani Nikula wrote: >On Mon, 24 Oct 2022, Lee Shawn C wrote: >> A panel power off cycle delay always append before turn eDP on. >> Driver should check last_power_on and last_backlight_off before insert >> this delay. If these values are the same, it means

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Switch intel_connector_needs_modeset() to drm types

On Mon, 31 Oct 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > intel_connector_needs_modeset() currently uses a mix of drm_ > and intel_ types. But it doesn't actually need anything from > the intel_ stuff, so seems better to switch the whole thing > over to the drm_ types. Should help anyon

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Don't use FIELD_PREP

On Mon, 31 Oct 2022, Ashutosh Dixit wrote: > FIELD_PREP and REG_FIELD_PREP have checks requiring a compile time constant > mask. When the mask comes in as the argument of a function these checks can > can fail depending on the compiler (gcc vs clang), optimization level, > etc. Use a simpler versi

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix up and test RING_TIMESTAMP on gen4-6 (rev3)

== Series Details == Series: drm/i915: Fix up and test RING_TIMESTAMP on gen4-6 (rev3) URL : https://patchwork.freedesktop.org/series/110326/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./arch/x86/inc

[Intel-gfx] [PATCH v2] drm/i915: Enable SDP split for DP2.0

Enable the SDP split configuration for DP2.0. v2: Move the register handling out of compute config function (JaniN) v3: Patch styling and register access based on platform support (JaniN) v4: Rebased Bspec: 67768 Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_audio.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix up and test RING_TIMESTAMP on gen4-6 (rev3)

== Series Details == Series: drm/i915: Fix up and test RING_TIMESTAMP on gen4-6 (rev3) URL : https://patchwork.freedesktop.org/series/110326/ State : success == Summary == CI Bug Log - changes from CI_DRM_12325 -> Patchwork_110326v3 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915: use surface size for bios fb size check (rev2)

== Series Details == Series: i915: use surface size for bios fb size check (rev2) URL : https://patchwork.freedesktop.org/series/109114/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12325_full -> Patchwork_109114v2_full Su

Re: [Intel-gfx] [PATCH 00/10] Connect VFIO to IOMMUFD

On Tue, Nov 01, 2022 at 11:04:38AM +0800, Yi Liu wrote: > On 2022/11/1 07:24, Jason Gunthorpe wrote: > > On Mon, Oct 31, 2022 at 08:25:39PM +0800, Yi Liu wrote: > > > > There is something wrong with the test suite that it isn't covering > > > > the above, I'm going to look into that today. > > > >

Re: [Intel-gfx] [PATCH 06/10] vfio-iommufd: Allow iommufd to be used in place of a container fd

On Tue, Nov 01, 2022 at 02:19:04AM -0700, Nicolin Chen wrote: > On Tue, Nov 01, 2022 at 08:09:52AM +, Tian, Kevin wrote: > > > > From: Jason Gunthorpe > > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > > > menuconfig VFIO > > > tristate "VFIO Non-Privileged userspace driver framew

[Intel-gfx] [PATCH] drm/i915/mtl: Fix PSR2_MAN_TRK_CTL bit getter functions for MTL

MTL shares PSR2_MAN_TRK_CTL bits with ADL. Currently some bit getter functions are incorrect for MTL. This patch fixes those. Bspec: 49274 Cc: José Roberto de Souza Cc: Mika Kahola Cc: Radhakrishna Sripada Fixes: 47d4ae2192cb ("drm/i915/mtl: Extend PSR support") Signed-off-by: Jouni Högander

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add DP MST DSC support to i915 (rev14)

== Series Details == Series: Add DP MST DSC support to i915 (rev14) URL : https://patchwork.freedesktop.org/series/101492/ State : warning == Summary == Error: dim checkpatch failed a682457fad34 drm: Add missing DP DSC extended capability definitions. b9b9c7187c42 drm/i915: Fix intel_dp_mst_co

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add DP MST DSC support to i915 (rev14)

== Series Details == Series: Add DP MST DSC support to i915 (rev14) URL : https://patchwork.freedesktop.org/series/101492/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117

Re: [Intel-gfx] [PATCH 01/10] vfio: Move vfio_device driver open/close code to a function

On Tue, Nov 01, 2022 at 07:33:30AM +, Tian, Kevin wrote: > > + /* > > +* Here we pass the KVM pointer with the group under the read lock. > > Now the read lock is replaced by mutex. Let's correct it when moving this > piece of code. Done, thanks Jason

Re: [Intel-gfx] [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()

On Tue, Nov 01, 2022 at 07:38:47AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:17 AM > > > > +err_container: > > + vfio_device_unassign_container(device); > > err_module_put: > > device->kvm = NULL; > > err_module_put should be moved after n

Re: [Intel-gfx] [PATCH 05/10] vfio: Use IOMMU_CAP_ENFORCE_CACHE_COHERENCY for vfio_file_enforced_coherent()

On Tue, Nov 01, 2022 at 07:52:23AM +, Tian, Kevin wrote: > > IOMMU_CAP_ENFORCE_CACHE_COHERENCY we know what the > > iommu_domain will be > > capable of without having to create it. Use this to compute > > it's worth noting that the prerequisite is that vfio always enforces > cache coherency on

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add DP MST DSC support to i915 (rev14)

== Series Details == Series: Add DP MST DSC support to i915 (rev14) URL : https://patchwork.freedesktop.org/series/101492/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12325 -> Patchwork_101492v14 Summary --- **FAIL

Re: [Intel-gfx] [PATCH 06/10] vfio-iommufd: Allow iommufd to be used in place of a container fd

On Tue, Nov 01, 2022 at 08:09:52AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > menuconfig VFIO > > tristate "VFIO Non-Privileged userspace driver framework" > > select IOMMU_API > > + depends on IOMMUFD || !IOMMUFD > > Out o

Re: [Intel-gfx] [PATCH 08/10] vfio-iommufd: Support iommufd for emulated VFIO devices

On Tue, Nov 01, 2022 at 08:37:39AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > Emulated VFIO devices are calling vfio_register_emulated_iommu_dev() and > > consist of all the mdev drivers. > > > > Like the physical drivers, support fo

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Fix PSR2_MAN_TRK_CTL bit getter functions for MTL

On Tue, 2022-11-01 at 13:53 +0200, Jouni Högander wrote: > MTL shares PSR2_MAN_TRK_CTL bits with ADL. Currently some bit > getter functions are incorrect for MTL. This patch fixes those. > > Bspec: 49274 Reviewed-by: José Roberto de Souza > > Cc: José Roberto de Souza > Cc: Mika Kahola > Cc:

Re: [Intel-gfx] [PATCH 00/10] Connect VFIO to IOMMUFD

On 2022/11/1 12:21, Nicolin Chen wrote: On Tue, Nov 01, 2022 at 11:04:38AM +0800, Yi Liu wrote: On 2022/11/1 07:24, Jason Gunthorpe wrote: On Mon, Oct 31, 2022 at 08:25:39PM +0800, Yi Liu wrote: There is something wrong with the test suite that it isn't covering the above, I'm going to look in

Re: [Intel-gfx] [PATCH 00/10] Connect VFIO to IOMMUFD

On 2022/11/1 19:41, Jason Gunthorpe wrote: On Tue, Nov 01, 2022 at 11:04:38AM +0800, Yi Liu wrote: On 2022/11/1 07:24, Jason Gunthorpe wrote: On Mon, Oct 31, 2022 at 08:25:39PM +0800, Yi Liu wrote: There is something wrong with the test suite that it isn't covering the above, I'm going to look

Re: [Intel-gfx] [PATCH 09/10] vfio: Make vfio_container optionally compiled

On Tue, Nov 01, 2022 at 08:41:56AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > if VFIO > > +config VFIO_CONTAINER > > + bool "Support for the VFIO container /dev/vfio/vfio" > > + select VFIO_IOMMU_TYPE1 if MMU && (X86 || S390 || A

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable SDP split for DP2.0 (rev2)

== Series Details == Series: drm/i915: Enable SDP split for DP2.0 (rev2) URL : https://patchwork.freedesktop.org/series/109395/ State : success == Summary == CI Bug Log - changes from CI_DRM_12325 -> Patchwork_109395v2 Summary --- **

Re: [Intel-gfx] [PATCH v7 0/9] dyndbg: drm.debug adaptation

On Tue, Nov 1, 2022 at 2:52 AM Ville Syrjälä wrote: > > On Mon, Oct 31, 2022 at 08:20:54PM -0400, Jason Baron wrote: > > > > > > On 10/31/22 6:11 PM, jim.cro...@gmail.com wrote: > > > On Mon, Oct 31, 2022 at 7:07 AM Ville Syrjälä > > > wrote: > > >> On Sun, Oct 30, 2022 at 08:42:52AM -0600, jim.c

Re: [Intel-gfx] [PATCH] drm/i915: update DSC feature flag handling during device init

On Tue, Oct 11, 2022 at 12:30:48PM +0300, Vinod Govindapillai wrote: > DSC feature information is no longer part of the DFSM register in > some display generations. Reviewed-by: Stanislav Lisovskiy > > Bspec:50075 > Signed-off-by: Vinod Govindapillai > --- > drivers/gpu/drm/i915/intel_device_

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/psr: Send update also on invalidate (rev2)

I checked possible regressions informed by CI and can't see them being related to my patch. BR, Jouni Högander On Sat, 2022-10-29 at 08:37 +, Patchwork wrote: Patch Details Series: drm/i915/psr: Send update also on invalidate (rev2) URL:https://patchwork.freedesktop.org/series/110037/ S

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Fix PSR2_MAN_TRK_CTL bit getter functions for MTL

== Series Details == Series: drm/i915/mtl: Fix PSR2_MAN_TRK_CTL bit getter functions for MTL URL : https://patchwork.freedesktop.org/series/110375/ State : success == Summary == CI Bug Log - changes from CI_DRM_12325 -> Patchwork_110375v1 S

Re: [Intel-gfx] [v2] drm/i915/pps: improve eDP power on flow

On Tue, 01 Nov 2022, "Lee, Shawn C" wrote: > On Tuesday, November 1, 2022 5:53 PM, Jani Nikula > wrote: >>On Mon, 24 Oct 2022, Lee Shawn C wrote: >>> A panel power off cycle delay always append before turn eDP on. >>> Driver should check last_power_on and last_backlight_off before insert >>> t

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Bpp/timeslot calculation fixes for DP MST DSC

Hi Stanislav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on drm/drm-next linus/master v6.1-rc3 next-20221101] [cannot apply to drm-intel/for-linux-next] [If your patch is applied to the wrong git tree, kindly drop

Re: [Intel-gfx] [PATCH v1 4/7] vfio/ccw: move private to mdev lifecycle

On Tue, 2022-11-01 at 09:08 +, Tian, Kevin wrote: > > From: Eric Farman > > Sent: Thursday, October 20, 2022 12:22 AM > > > > @@ -101,15 +101,20 @@ static int vfio_ccw_mdev_probe(struct > > mdev_device *mdev) > >  { > > struct subchannel *sch = to_subchannel(mdev->dev.parent); > >    

Re: [Intel-gfx] [PATCH 01/10] vfio: Move vfio_device driver open/close code to a function

On 2022/10/26 02:17, Jason Gunthorpe wrote: This error unwind is getting complicated. Move all the code into two pair'd function. The functions should be called when the open_count == 1 after incrementing/before decrementing. Signed-off-by: Jason Gunthorpe --- drivers/vfio/vfio_main.c | 95 ++

Re: [Intel-gfx] [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()

On 2022/10/26 02:17, Jason Gunthorpe wrote: The only thing this function does is assert the group has an assigned container and incrs refcounts. The overall model we have is that once a conatiner_users refcount is typo. s/conatiner_users/container_users incremented it cannot be de-assigned

Re: [Intel-gfx] [PATCH 03/10] vfio: Rename vfio_device_assign/unassign_container()

On 2022/10/26 02:17, Jason Gunthorpe wrote: These functions don't really assign anything anymore, they just increment some refcounts and do a sanity check. Call them vfio_group_[un]use_container() Signed-off-by: Jason Gunthorpe --- drivers/vfio/container.c | 14 ++ drivers/vfio/v

Re: [Intel-gfx] [v2] drm/i915/pps: improve eDP power on flow

On Tue, Nov. 1, 2022, 1:43 p.m, Jani Nikula wrote: >On Tue, 01 Nov 2022, "Lee, Shawn C" wrote: >> On Tuesday, November 1, 2022 5:53 PM, Jani Nikula >> wrote: >>>On Mon, 24 Oct 2022, Lee Shawn C wrote: A panel power off cycle delay always append before turn eDP on. Driver should check

Re: [Intel-gfx] [v2] drm/i915/pps: improve eDP power on flow

On Tue, Nov. 1, 2022, 1:43 p.m, Jani Nikula wrote: >On Tue, 01 Nov 2022, "Lee, Shawn C" wrote: >> On Tuesday, November 1, 2022 5:53 PM, Jani Nikula >> wrote: >>>On Mon, 24 Oct 2022, Lee Shawn C wrote: A panel power off cycle delay always append before turn eDP on. Driver should check

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Add MC6 Wa_14017210380 for SAMedia

On Sat, Oct 29, 2022 at 12:59:35AM +0530, Badal Nilawar wrote: > This workaround is added for Media Tile of MTL A step. It is to help > pcode workaround which handles the hardware bug seen on CXL splitter > during package C2/C3 transitins due to MC6 entry/exit. As a part of > workaround pcode expec

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/sysfs: Update timeslice/preemption for new range limits

On Mon, 31 Oct 2022 15:24:40 -0700, john.c.harri...@intel.com wrote: > > From: John Harrison > > Guc submission imposes new range limits on certain scheduling > parameters. The idempotent sections of the timeslice duration and > pre-emption timeout tests was exceeding those limits and so would fai

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix up and test RING_TIMESTAMP on gen4-6 (rev3)

== Series Details == Series: drm/i915: Fix up and test RING_TIMESTAMP on gen4-6 (rev3) URL : https://patchwork.freedesktop.org/series/110326/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12325_full -> Patchwork_110326v3_full ===

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/sysfs: Update timeslice/preemption for new range limits

On 11/1/2022 08:27, Dixit, Ashutosh wrote: On Mon, 31 Oct 2022 15:24:40 -0700, john.c.harri...@intel.com wrote: From: John Harrison Guc submission imposes new range limits on certain scheduling parameters. The idempotent sections of the timeslice duration and pre-emption timeout tests was exce

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Add MC6 Wa_14017210380 for SAMedia

Hi Matt, On 01-11-2022 20:47, Matt Roper wrote: On Sat, Oct 29, 2022 at 12:59:35AM +0530, Badal Nilawar wrote: This workaround is added for Media Tile of MTL A step. It is to help pcode workaround which handles the hardware bug seen on CXL splitter during package C2/C3 transitins due to MC6 e

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/sysfs: Update timeslice/preemption for new range limits

On Tue, 01 Nov 2022 09:22:11 -0700, John Harrison wrote: > > On 11/1/2022 08:27, Dixit, Ashutosh wrote: > > On Mon, 31 Oct 2022 15:24:40 -0700, john.c.harri...@intel.com wrote: > >> From: John Harrison > >> > >> Guc submission imposes new range limits on certain scheduling > >> parameters. The ide

[Intel-gfx] [PATCH RFC] drm/i915: allow running mock selftests via Kunit

The mock selftests don't require any hardware to run. They can easily run via kunit with qemu or bare metal. Add support for it. With this change, mock selftest can now run in qemu with: $ ./tools/testing/kunit/kunit.py run --arch=x86_64 \ --kunitconfig=drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset

On 11/1/2022 02:58, Tvrtko Ursulin wrote: On 31/10/2022 18:30, John Harrison wrote: On 10/31/2022 05:51, Tvrtko Ursulin wrote: On 31/10/2022 10:09, Tvrtko Ursulin wrote: On 28/10/2022 20:46, john.c.harri...@intel.com wrote: From: John Harrison The engine busyness stats has a worker function

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Send update also on invalidate (rev2)

== Series Details == Series: drm/i915/psr: Send update also on invalidate (rev2) URL : https://patchwork.freedesktop.org/series/110037/ State : success == Summary == CI Bug Log - changes from CI_DRM_12311_full -> Patchwork_110037v2_full Sum

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Enable SDP split for DP2.0 (rev2)

== Series Details == Series: drm/i915: Enable SDP split for DP2.0 (rev2) URL : https://patchwork.freedesktop.org/series/109395/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12325_full -> Patchwork_109395v2_full Summary ---

Re: [Intel-gfx] [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()

On Tue, Nov 01, 2022 at 10:37:14PM +0800, Yi Liu wrote: > > @@ -784,12 +791,6 @@ static struct file *vfio_device_open(struct > > vfio_device *device) > > struct file *filep; > > int ret; > > - mutex_lock(&device->group->group_lock); > > - ret = vfio_device_assign_container(device); >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Send update also on invalidate (rev2)

== Series Details == Series: drm/i915/psr: Send update also on invalidate (rev2) URL : https://patchwork.freedesktop.org/series/110037/ State : success == Summary == CI Bug Log - changes from CI_DRM_12311_full -> Patchwork_110037v2_full Sum

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/mtl: Fix PSR2_MAN_TRK_CTL bit getter functions for MTL

== Series Details == Series: drm/i915/mtl: Fix PSR2_MAN_TRK_CTL bit getter functions for MTL URL : https://patchwork.freedesktop.org/series/110375/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12325_full -> Patchwork_110375v1_full =

Re: [Intel-gfx] [PULL] drm-intel-gt-next

On Mon, 31 Oct 2022 at 21:07, Joonas Lahtinen wrote: > > Hi Dave & Daniel, > > Here goes first drm-intel-gt-next pull req towards 6.2. > > We have a fix for #6222 (kernel memory corruption issue) and fix for > display regression after resume. A missing W/A for Gen12 iGPUs and > extension of comput

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/mtl: Fix PSR2_MAN_TRK_CTL bit getter functions for MTL

I checked possible new issues found by CI and I'm sure they are not related to my patch. BR, Jouni Högander On Tue, 2022-11-01 at 18:34 +, Patchwork wrote: Patch Details Series: drm/i915/mtl: Fix PSR2_MAN_TRK_CTL bit getter functions for MTL URL:https://patchwork.freedesktop.org/series/

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dg2: Introduce Wa_18017747507

On 10/31/22 3:44 PM, Patchwork wrote: > *Patch Details* > *Series:* drm/i915/dg2: Introduce Wa_18017747507 > *URL:*https://patchwork.freedesktop.org/series/110323/ > > *State:* failure > *Details:* > https://intel-gfx-ci.01.org/

Re: [Intel-gfx] [PATCH] drm/i915/psr: Remove inappropriate DSC slice alignment warning

On Fri, 2022-10-21 at 08:49 +0300, Jouni Högander wrote: > Selective update area is now aligned with DSC slice height when > DSC is enabled. Remove inappropriate warning about missing DSC > alignment. > > Cc: José Roberto de Souza > Cc: Mika Kahola > > Fixes: 47d4ae2192cb ("drm/i915/mtl: Extend

Re: [Intel-gfx] [PATCH] drm/i915/psr: Remove inappropriate DSC slice alignment warning

On Tue, 2022-11-01 at 20:00 +, Souza, Jose wrote: > On Fri, 2022-10-21 at 08:49 +0300, Jouni Högander wrote: > > Selective update area is now aligned with DSC slice height when > > DSC is enabled. Remove inappropriate warning about missing DSC > > alignment. > > > > Cc: José Roberto de Souza

Re: [Intel-gfx] [PATCH] drm/i915/psr: Remove inappropriate DSC slice alignment warning

On Tue, 2022-11-01 at 20:55 +, Hogander, Jouni wrote: > On Tue, 2022-11-01 at 20:00 +, Souza, Jose wrote: > > On Fri, 2022-10-21 at 08:49 +0300, Jouni Högander wrote: > > > Selective update area is now aligned with DSC slice height when > > > DSC is enabled. Remove inappropriate warning abo

Re: [Intel-gfx] [PATCH] drm/i915/dsc: Source supports DSC from DISPLAY_VER >= 11

On Tue, Nov 01, 2022 at 01:29:27PM +0530, Swati Sharma wrote: > i915 driver supports DSC from DISPLAY_VER >= 11. Fix it. Bspec 19713 indicates that GLK (i.e., our only display version 10 platform) does support DSC. Are you saying that there's other GLK enablement missing in the driver right now t

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: allow running mock selftests via Kunit

== Series Details == Series: drm/i915: allow running mock selftests via Kunit URL : https://patchwork.freedesktop.org/series/110383/ State : warning == Summary == Error: dim checkpatch failed a4f3a5c88a10 drm/i915: allow running mock selftests via Kunit Traceback (most recent call last): Fil

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Introduce Wa_18017747507

On Mon, Oct 31, 2022 at 06:15:09AM -0700, Wayne Boyer wrote: > WA 18017747507 applies to all DG2 skus. > > BSpec: 56035, 46121, 68173 > > Signed-off-by: Wayne Boyer > --- > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +++ > drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ > 2 files chan

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Replace kmap() with kmap_local_page() (rev2)

On lunedì 17 ottobre 2022 22:34:44 CET Patchwork wrote: > == Series Details == > > Series: drm/i915: Replace kmap() with kmap_local_page() (rev2) > URL : https://patchwork.freedesktop.org/series/107277/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_12252 -> Patchwork

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Replace kmap() with kmap_local_page() (rev2)

On lunedì 17 ottobre 2022 22:23:30 CET Patchwork wrote: > == Series Details == > > Series: drm/i915: Replace kmap() with kmap_local_page() (rev2) > URL : https://patchwork.freedesktop.org/series/107277/ > State : warning > > == Summary == > > Error: dim sparse failed > Sparse version: v0.6.2 >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: allow running mock selftests via Kunit

== Series Details == Series: drm/i915: allow running mock selftests via Kunit URL : https://patchwork.freedesktop.org/series/110383/ State : success == Summary == CI Bug Log - changes from CI_DRM_12328 -> Patchwork_110383v1 Summary ---

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Set PROBE_PREFER_ASYNCHRONOUS

On Fri, Oct 28, 2022 at 5:24 PM Patchwork wrote: > > Patch Details > Series:drm/i915: Set PROBE_PREFER_ASYNCHRONOUS > URL:https://patchwork.freedesktop.org/series/110277/ > State:failure > Details:https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110277v1/index.html > > CI Bug Log - changes from

Re: [Intel-gfx] [PULL] drm-intel-next

On Sat, 2022-10-29 at 02:41 +0300, Ville Syrjälä wrote: > On Fri, Oct 28, 2022 at 02:22:33PM -0400, Rodrigo Vivi wrote: > > Hi Dave and Daniel, > > > > Here goes the first chunk of drm-intel-next targeting 6.2 > > > > The highlight goes to Ville with many display related clean-up > > and improvem

Re: [Intel-gfx] [PATCH v5] overflow: Introduce overflows_type() and castable_to_type()

On Sat, Oct 29, 2022 at 11:01:38AM +0300, Gwan-gyeong Mun wrote: > > > On 10/29/22 10:32 AM, Kees Cook wrote: > > On Sat, Oct 29, 2022 at 08:55:43AM +0300, Gwan-gyeong Mun wrote: > > > Hi Kees, > > > > Hi! :) > > > > > I've updated to v5 with the last comment of Nathan. > > > Could you please k

Re: [Intel-gfx] [PATCH 1/1] drm/i915/pxp: Separate PXP FW interface structures for both v42 and 43

On 10/24/2022 11:40 AM, Alan Previn wrote: Previously, we only used PXP FW interface version-42 structures for PXP arbitration session on ADL/TGL products and version-43 for HuC authentication on DG2. That worked fine despite not differentiating such versioning of the PXP firmware interaction

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Replace kmap() with kmap_local_page() (rev2)

On lunedì 17 ottobre 2022 22:23:30 CET Patchwork wrote: > == Series Details == > > Series: drm/i915: Replace kmap() with kmap_local_page() (rev2) > URL : https://patchwork.freedesktop.org/series/107277/ > State : warning > > == Summary == > > Error: dim sparse failed > Sparse version: v0.6.2 >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/display: Do both crawl and squash when changing cdclk (rev2)

== Series Details == Series: series starting with [1/2] drm/i915/display: Do both crawl and squash when changing cdclk (rev2) URL : https://patchwork.freedesktop.org/series/110347/ State : success == Summary == CI Bug Log - changes from CI_DRM_12329 -> Patchwork_110347v2 =

  1   2   >