[Intel-gfx] [PATCH v5 10/19] drm/i915/vm_bind: Abstract out common execbuf functions

The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Abstract out the common execbuf functionalities into a separate file where possible, thus allowing code sharing. Reviewed-by: Andi Shyti Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanatha

[Intel-gfx] [PATCH v5 11/19] drm/i915/vm_bind: Use common execbuf functions in execbuf path

Update the execbuf path to use common execbuf functions to reduce code duplication with the newer execbuf3 path. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 507 ++ 1 file changed, 38 insertions(+), 469 d

[Intel-gfx] [PATCH v5 12/19] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

Implement new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mode only works with this new execbuf3 ioctl. The new execbuf3 ioctl will not have any list of objects to validate bind as all required objects binding would have been requested by the userspace befor

[Intel-gfx] [PATCH v5 15/19] drm/i915/vm_bind: Handle persistent vmas in execbuf3

Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. v2: Ensure requests wait for bindings to complete. v3: Remove short term pinning with PIN_VALIDATE flag. Individualize fences before adding to dma_resv obj. v4: Fix bind completion check, use PIN_NOEVICT,

[Intel-gfx] [PATCH v5 18/19] drm/i915/vm_bind: Add uapi for user to enable vm_bind_mode

Add getparam support for VM_BIND capability version. Add VM creation time flag to enable vm_bind_mode for the VM. v2: update kernel-doc v3: create vm->root_obj only upon I915_VM_CREATE_FLAGS_USE_VM_BIND v4: replace vm->vm_bind_mode check with i915_gem_vm_is_vm_bind_mode() Reviewed-by: Matthew Aul

[Intel-gfx] [PATCH v5 13/19] drm/i915/vm_bind: Update i915_vma_verify_bind_complete()

Ensure i915_vma_verify_bind_complete() handles case where bind is not initiated. Also make it non static, add documentation and move it out of CONFIG_DRM_I915_DEBUG_GEM. v2: Fix fence leak Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers

[Intel-gfx] [PATCH v5 14/19] drm/i915/vm_bind: Expose i915_request_await_bind()

Rename __i915_request_await_bind() as i915_request_await_bind() and make it non-static as it will be used in execbuf3 ioctl path. v2: add documentation Reviewed-by: Matthew Auld Reviewed-by: Andi Shyti Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/i915_vma.c | 8 +---

[Intel-gfx] [PATCH v5 16/19] drm/i915/vm_bind: userptr dma-resv changes

For persistent (vm_bind) vmas of userptr BOs, handle the user page pinning by using the i915_gem_object_userptr_submit_init() /done() functions v2: Do not double add vma to vm->userptr_invalidated_list Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- .../gpu/drm/i915/gem/

[Intel-gfx] [PATCH v5 19/19] drm/i915/vm_bind: Render VM_BIND documentation

Update i915 documentation to include VM_BIND changes and render all VM_BIND related documentation. Signed-off-by: Niranjana Vishwanathapura --- Documentation/gpu/i915.rst | 78 -- 1 file changed, 59 insertions(+), 19 deletions(-) diff --git a/Documentation/gp

[Intel-gfx] [PATCH v5 17/19] drm/i915/vm_bind: Limit vm_bind mode to non-recoverable contexts

Only support vm_bind mode with non-recoverable contexts. With new vm_bind mode with eb3 submission path, we need not support older recoverable contexts. Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 ++ 1 file changed, 6 insertions(+) diff --gi

Re: [Intel-gfx] [PATCH] Revert "drm/i915/uapi: expose GTT alignment"

On 10/24/2022 12:19 PM, Matthew Auld wrote: The process for merging uAPI is to have UMD side ready and reviewed and merged before merging. Revert for now until that is ready. This reverts commit d54576a074a29d4901d0a693cd84e1a89057f694. Reported-by: Joonas Lahtinen Signed-off-by: Matthew Aul

Re: [Intel-gfx] mm/huge_memory: do not clobber swp_entry_t during THP split

On 24/10/2022 15:23, Mel Gorman wrote: On Mon, Oct 24, 2022 at 02:04:50PM +0100, Tvrtko Ursulin wrote: Hi Mel, mm experts, With 6.1-rc2 we started hitting the WARN_ON added in 71e2d666ef85 ("mm/huge_memory: do not clobber swp_entry_t during THP split") in i915 automated CI: Thanks for th

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/vm_bind: Add VM_BIND functionality (rev8)

== Series Details == Series: drm/i915/vm_bind: Add VM_BIND functionality (rev8) URL : https://patchwork.freedesktop.org/series/105879/ State : warning == Summary == Error: dim checkpatch failed f90c61132e40 drm/i915/vm_bind: Expose vm lookup function ce0a50fbd695 drm/i915/vm_bind: Add __i915_s

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/vm_bind: Add VM_BIND functionality (rev8)

== Series Details == Series: drm/i915/vm_bind: Add VM_BIND functionality (rev8) URL : https://patchwork.freedesktop.org/series/105879/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "drm/i915/uapi: expose GTT alignment"

On 24/10/2022 12:55, Patchwork wrote: *Patch Details* *Series:* Revert "drm/i915/uapi: expose GTT alignment" *URL:* https://patchwork.freedesktop.org/series/110041/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Fix a build error used with clang compiler

On Tue, Oct 25, 2022 at 12:09:53AM +0300, Gwan-gyeong Mun wrote: > If a non-constant variable is used as the first argument of the FIELD_PREP > macro, a build error occurs when using the clang compiler. good catch! FIELD_PREP wants indeed a constant as a first paramenter, also for gcc. Reviewed-b

[Intel-gfx] [PATCH] i915/i915_gem_context: Remove debug message in i915_gem_context_create_ioctl

We know that as long as GEM context create ioctl succeeds, a context was created. There is no need to write about it, especially when such a message heavily pollutes dmesg and makes debugging actual errors harder. Suggested-by: Chris Wilson Signed-off-by: Karolina Drobnik Cc: Andi Shyti --- dr

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/vm_bind: Add VM_BIND functionality (rev8)

== Series Details == Series: drm/i915/vm_bind: Add VM_BIND functionality (rev8) URL : https://patchwork.freedesktop.org/series/105879/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12290 -> Patchwork_105879v8 Summary --

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Fix a build error used with clang compiler

Hi Ashutosh, > > drivers/gpu/drm/i915/i915_hwmon.c:115:16: error: result of comparison of > > constant 18446744073709551615 with expression of type 'typeof > > (_Generic((field_msk), char: (unsigned char)0, unsigned char: (unsigned > > char)0, signed char: (unsigned char)0, unsigned short: (uns

Re: [Intel-gfx] [PATCH] i915/i915_gem_context: Remove debug message in i915_gem_context_create_ioctl

> We know that as long as GEM context create ioctl succeeds, a context was > created. There is no need to write about it, especially when such a message > heavily pollutes dmesg and makes debugging actual errors harder. > > Suggested-by: Chris Wilson > Signed-off-by: Karolina Drobnik > Cc: Andi

Re: [Intel-gfx] mm/huge_memory: do not clobber swp_entry_t during THP split

Cc'ing Andrew for awareness. Andrew, this bug report is almost identical to the one Hugh already reported and fixed in "[PATCH] mm: prep_compound_tail() clear page->private". Nothing wrong with the patch AFAIK and only the last paragraph is relevant to you. On Tue, Oct 25, 2022 at 09:50:14AM +0100

[Intel-gfx] ✓ Fi.CI.BAT: success for i915/i915_gem_context: Remove debug message in i915_gem_context_create_ioctl

== Series Details == Series: i915/i915_gem_context: Remove debug message in i915_gem_context_create_ioctl URL : https://patchwork.freedesktop.org/series/110116/ State : success == Summary == CI Bug Log - changes from CI_DRM_12290 -> Patchwork_110116v1 =

[Intel-gfx] [PATCH v3 0/4] drm/i915/tgl+: Fix race conditions during DKL PHY accesses

This is v3 of [1] fixing checkpatch issues and adding the Acked-bys. [1] https://lore.kernel.org/intel-gfx/20221020160022.1823365-1-imre.d...@intel.com/T/#md92b51e5698295844f5436b479fdd473bf430882 Cc: Jani Nikula Cc: Ville Syrjälä Imre Deak (4): drm/i915/tgl+: Add locking around DKL PHY reg

[Intel-gfx] [PATCH v3 1/4] drm/i915/tgl+: Add locking around DKL PHY register accesses

Accessing the TypeC DKL PHY registers during modeset-commit, -verification, DP link-retraining and AUX power well toggling is racy due to these code paths being concurrent and the PHY register bank selection register (HIP_INDEX_REG) being shared between PHY instances (aka TC ports) and the bank sel

[Intel-gfx] [PATCH v3 2/4] drm/i915: Rename intel_tc_phy_regs.h to intel_mg_phy_regs.h

An upcoming patch moves the DKL PHY register definitions to intel_dkl_phy_regs.h, so for consistency rename intel_tc_phy_regs.h containing only MG PHY register definitions to intel_mg_phy_regs.h. Suggested-by: Jani Nikula Cc: Jani Nikula Acked-by: Jani Nikula Signed-off-by: Imre Deak --- driv

[Intel-gfx] [PATCH v3 4/4] drm/i915/tgl+: Sanitize DKL PHY register definitions

Not all Dekel PHY registers have a lane instance, so having to specify this when using them is awkward. It makes more sense to define each PHY register with its full internal PHY offset where bits 15:12 is the lane for lane-instanced PHY registers and just a register bank index for other PHY regist

[Intel-gfx] [PATCH v3 3/4] drm/i915/tgl+: Move DKL PHY register definitions to intel_dkl_phy_regs.h

Move the TypeC DKL PHY register definitions to intel_dkl_phy_regs.h. No functional changes. v2: - Move the definitions to a new intel_dkl_phy_regs.h file. (Jani). Cc: Jani Nikula Acked-by: Jani Nikula Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + .../i91

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

On Tue, Oct 25, 2022 at 07:52:07AM +0300, Ville Syrjälä wrote: > On Fri, Oct 21, 2022 at 08:22:41PM +0300, Ville Syrjälä wrote: > > On Mon, Aug 22, 2022 at 01:18:22PM +0200, Peter Zijlstra wrote: > > > +#ifdef CONFIG_LOCKDEP > > > + /* > > > + * It's dangerous to freeze with locks held; there be d

[Intel-gfx] [PATCH v4 1/4] drm/i915/tgl+: Add locking around DKL PHY register accesses

Accessing the TypeC DKL PHY registers during modeset-commit, -verification, DP link-retraining and AUX power well toggling is racy due to these code paths being concurrent and the PHY register bank selection register (HIP_INDEX_REG) being shared between PHY instances (aka TC ports) and the bank sel

[Intel-gfx] [PATCH v4 3/4] drm/i915/tgl+: Move DKL PHY register definitions to intel_dkl_phy_regs.h

Move the TypeC DKL PHY register definitions to intel_dkl_phy_regs.h. No functional changes. v2: - Move the definitions to a new intel_dkl_phy_regs.h file. (Jani). v3: - Rebase on latest patchset version. Cc: Jani Nikula Acked-by: Jani Nikula Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/

[Intel-gfx] [PATCH v4 4/4] drm/i915/tgl+: Sanitize DKL PHY register definitions

Not all Dekel PHY registers have a lane instance, so having to specify this when using them is awkward. It makes more sense to define each PHY register with its full internal PHY offset where bits 15:12 is the lane for lane-instanced PHY registers and just a register bank index for other PHY regist

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: stop abusing swiotlb_max_segment (rev5)

== Series Details == Series: drm/i915: stop abusing swiotlb_max_segment (rev5) URL : https://patchwork.freedesktop.org/series/109946/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v5 05/19] drm/i915/vm_bind: Implement bind and unbind of object

Hi Niranjana, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Niranjana-Vishwanathapura/drm-i915-vm_bind-Add-VM_BIND-functionality/20221025-150246 base: git://anongit.freedesktop.org/drm/drm

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915/i915_gem_context: Remove debug message in i915_gem_context_create_ioctl

== Series Details == Series: i915/i915_gem_context: Remove debug message in i915_gem_context_create_ioctl URL : https://patchwork.freedesktop.org/series/110116/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12290_full -> Patchwork_110116v1_full ===

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: stop abusing swiotlb_max_segment (rev5)

== Series Details == Series: drm/i915: stop abusing swiotlb_max_segment (rev5) URL : https://patchwork.freedesktop.org/series/109946/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12293 -> Patchwork_109946v5 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: EDID override refactoring and fixes (rev3)

== Series Details == Series: drm/edid: EDID override refactoring and fixes (rev3) URL : https://patchwork.freedesktop.org/series/109579/ State : warning == Summary == Error: dim checkpatch failed 8153ed33254a drm/i915/hdmi: do dual mode detect only if connected 25b066dd561d drm/i915/hdmi: stop

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: EDID override refactoring and fixes (rev3)

== Series Details == Series: drm/edid: EDID override refactoring and fixes (rev3) URL : https://patchwork.freedesktop.org/series/109579/ State : success == Summary == CI Bug Log - changes from CI_DRM_12293 -> Patchwork_109579v3 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl+: Fix race conditions during DKL PHY accesses (rev5)

== Series Details == Series: drm/i915/tgl+: Fix race conditions during DKL PHY accesses (rev5) URL : https://patchwork.freedesktop.org/series/109963/ State : warning == Summary == Error: dim checkpatch failed 15062ed1404b drm/i915/tgl+: Add locking around DKL PHY register accesses Traceback (m

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/tgl+: Fix race conditions during DKL PHY accesses (rev5)

== Series Details == Series: drm/i915/tgl+: Fix race conditions during DKL PHY accesses (rev5) URL : https://patchwork.freedesktop.org/series/109963/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl+: Fix race conditions during DKL PHY accesses (rev5)

== Series Details == Series: drm/i915/tgl+: Fix race conditions during DKL PHY accesses (rev5) URL : https://patchwork.freedesktop.org/series/109963/ State : success == Summary == CI Bug Log - changes from CI_DRM_12293 -> Patchwork_109963v5

Re: [Intel-gfx] [PATCH 09/22] platform/x86: fujitsu-laptop: Use acpi_video_get_backlight_types()

On Mon, Oct 24, 2022 at 08:35:00PM +0900, Akihiko Odaki wrote: > acpi_video_get_backlight_type() is now deprecated. The practical impact of this patch series on fujitsu-laptop is obviously very minor assuming the new acpi_video_get_backlight_types() function functions as advertised. Accordingly,

Re: [Intel-gfx] [linus:master] [i915] f683b9d613: igt.gem_userptr_blits.probe.fail

* kernel test robot [221024 01:06]: > > Greeting, > > FYI, we noticed igt.gem_userptr_blits.probe.fail due to commit (built with > gcc-11): > > commit: f683b9d613193362ceb954c216f663a43c027302 ("i915: use the VMA > iterator") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git m

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Fix a build error used with clang compiler

On Tue, 25 Oct 2022, Gwan-gyeong Mun wrote: > If a non-constant variable is used as the first argument of the FIELD_PREP > macro, a build error occurs when using the clang compiler. > > Fix the following build error used with clang compiler: > > drivers/gpu/drm/i915/i915_hwmon.c:115:16: error: res

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Fix a build error used with clang compiler

On Tue, 25 Oct 2022, Jani Nikula wrote: > On Tue, 25 Oct 2022, Gwan-gyeong Mun wrote: >> If a non-constant variable is used as the first argument of the FIELD_PREP >> macro, a build error occurs when using the clang compiler. >> >> Fix the following build error used with clang compiler: >> >> dri

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Prep work for finishing (de)gamma readout (rev3)

== Series Details == Series: drm/i915: Prep work for finishing (de)gamma readout (rev3) URL : https://patchwork.freedesktop.org/series/109229/ State : success == Summary == CI Bug Log - changes from CI_DRM_12293 -> Patchwork_109229v3 Summar

Re: [Intel-gfx] [PATCH v4] drm/i915/slpc: Use platform limits for min/max frequency

On Mon, 24 Oct 2022 15:54:53 -0700, Vinay Belgaumkar wrote: > > GuC will set the min/max frequencies to theoretical max on > ATS-M. This will break kernel ABI, so limit min/max frequency > to RP0(platform max) instead. > > Also modify the SLPC selftest to update the min frequency > when we have a s

Re: [Intel-gfx] mm/huge_memory: do not clobber swp_entry_t during THP split

On Tue, 25 Oct 2022, Mel Gorman wrote: > Cc'ing Andrew for awareness. Andrew, this bug report is almost identical to > the one Hugh already reported and fixed in "[PATCH] mm: prep_compound_tail() > clear page->private". Nothing wrong with the patch AFAIK and only the last > paragraph is relevant t

[Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "drm/i915/uapi: expose GTT alignment"

== Series Details == Series: Revert "drm/i915/uapi: expose GTT alignment" URL : https://patchwork.freedesktop.org/series/110041/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12284 -> Patchwork_110041v1 Summary --- *

Re: [Intel-gfx] [PATCH] drm/i915/userptr: restore probe_range behaviour

On 24/10/2022 18:21, Matthew Auld wrote: The conversion looks harmless, however the addr value is updated inside the loop with the previous vm_end, which then incorrectly leads to for_each_vma_range() iterating over stuff outside the range we care about. Fix this by storing the end value separa

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: stop abusing swiotlb_max_segment (rev6)

== Series Details == Series: drm/i915: stop abusing swiotlb_max_segment (rev6) URL : https://patchwork.freedesktop.org/series/109946/ State : success == Summary == CI Bug Log - changes from CI_DRM_12293 -> Patchwork_109946v6 Summary ---

[Intel-gfx] [PATCH v2] drm/ttm: rework on ttm_resource to use size_t type

Change ttm_resource structure from num_pages to size_t size in bytes. v1 -> v2: change PFN_UP(dst_mem->size) to ttm->num_pages v1 -> v2: change bo->resource->size to bo->base.size at some places v1 -> v2: remove the local variable v1 -> v2: cleanup cmp_size_smaller_first() Signed-off-by: Somalapur

Re: [Intel-gfx] [PATCH] drm/i915/userptr: restore probe_range behaviour

On Tue, Oct 25, 2022 at 04:40:23PM +0100, Tvrtko Ursulin wrote: > > On 24/10/2022 18:21, Matthew Auld wrote: > > The conversion looks harmless, however the addr value is updated inside > > the loop with the previous vm_end, which then incorrectly leads to > > for_each_vma_range() iterating over st

Re: [Intel-gfx] [PATCH] drm/i915/userptr: restore probe_range behaviour

On 25/10/2022 16:54, Matthew Wilcox wrote: On Tue, Oct 25, 2022 at 04:40:23PM +0100, Tvrtko Ursulin wrote: On 24/10/2022 18:21, Matthew Auld wrote: The conversion looks harmless, however the addr value is updated inside the loop with the previous vm_end, which then incorrectly leads to for_e

[Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "drm/i915/uapi: expose GTT alignment"

== Series Details == Series: Revert "drm/i915/uapi: expose GTT alignment" URL : https://patchwork.freedesktop.org/series/110041/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12284 -> Patchwork_110041v1 Summary --- *

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/ttm: rework on ttm_resource to use size_t type

== Series Details == Series: drm/ttm: rework on ttm_resource to use size_t type URL : https://patchwork.freedesktop.org/series/110129/ State : warning == Summary == Error: dim checkpatch failed 5d3feb81e845 drm/ttm: rework on ttm_resource to use size_t type -:57: WARNING:AVOID_BUG: Do not cras

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/ttm: rework on ttm_resource to use size_t type

== Series Details == Series: drm/ttm: rework on ttm_resource to use size_t type URL : https://patchwork.freedesktop.org/series/110129/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/ttm: rework on ttm_resource to use size_t type

== Series Details == Series: drm/ttm: rework on ttm_resource to use size_t type URL : https://patchwork.freedesktop.org/series/110129/ State : success == Summary == CI Bug Log - changes from CI_DRM_12293 -> Patchwork_110129v1 Summary --

Re: [Intel-gfx] [PATCH v2] drm/ttm: rework on ttm_resource to use size_t type

Am 25.10.22 um 17:50 schrieb Somalapuram Amaranath: Change ttm_resource structure from num_pages to size_t size in bytes. v1 -> v2: change PFN_UP(dst_mem->size) to ttm->num_pages v1 -> v2: change bo->resource->size to bo->base.size at some places v1 -> v2: remove the local variable v1 -> v2: clea

[Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "drm/i915/uapi: expose GTT alignment"

== Series Details == Series: Revert "drm/i915/uapi: expose GTT alignment" URL : https://patchwork.freedesktop.org/series/110041/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12284 -> Patchwork_110041v1 Summary --- *

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Fix a build error used with clang compiler

Start of lore thread for context: https://lore.kernel.org/intel-gfx/20221024210953.1572998-1-gwan-gyeong@intel.com/ On Tue, Oct 25, 2022 at 2:25 AM Andi Shyti wrote: > > Hi Ashutosh, > > > > drivers/gpu/drm/i915/i915_hwmon.c:115:16: error: result of comparison of > > > constant 1844674407370

Re: [Intel-gfx] [PATCH v2] drm/ttm: rework on ttm_resource to use size_t type

On Tue, 25 Oct 2022 at 16:51, Somalapuram Amaranath wrote: > > Change ttm_resource structure from num_pages to size_t size in bytes. > v1 -> v2: change PFN_UP(dst_mem->size) to ttm->num_pages > v1 -> v2: change bo->resource->size to bo->base.size at some places > v1 -> v2: remove the local variabl

[Intel-gfx] [PATCH] drm/i915/sdvo: Fallback to current output timings for LVDS fixed mode

From: Ville Syrjälä If we can't dig out a fixed mode for LVDS from the VBT or EDID let's fall back to using the current output timings. This should work as long as the BIOS has (somehow) enabled the output. In this case we are dealing with the some kind of BLB based POS machine (Toshiba SurePOS

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/slpc: Use platform limits for min/max frequency (rev5)

== Series Details == Series: drm/i915/slpc: Use platform limits for min/max frequency (rev5) URL : https://patchwork.freedesktop.org/series/109632/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "drm/i915/uapi: expose GTT alignment"

On 25/10/2022 17:37, Patchwork wrote: *Patch Details* *Series:* Revert "drm/i915/uapi: expose GTT alignment" *URL:* https://patchwork.freedesktop.org/series/110041/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-

[Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "drm/i915/uapi: expose GTT alignment"

== Series Details == Series: Revert "drm/i915/uapi: expose GTT alignment" URL : https://patchwork.freedesktop.org/series/110041/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12284 -> Patchwork_110041v1 Summary --- *

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for i915: CAGF and RC6 changes for MTL (rev11)

On Mon, 24 Oct 2022 18:25:06 -0700, Patchwork wrote: > Hi Lakshmi, The below failures are unrelated to this series. Thanks. -- Ashutosh > Patch Details > > Series: i915: CAGF and RC6 changes for MTL (rev11) > URL: https://patchwork.freedesktop.org/series/108156/ > State: failure > Detail

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/slpc: Use platform limits for min/max frequency (rev5)

== Series Details == Series: drm/i915/slpc: Use platform limits for min/max frequency (rev5) URL : https://patchwork.freedesktop.org/series/109632/ State : success == Summary == CI Bug Log - changes from CI_DRM_12293 -> Patchwork_109632v5 S

Re: [Intel-gfx] [PATCH 1/4] drm/i915/display: Change terminology for cdclk actions

On 21.10.2022 14:39, Anusha Srivatsa wrote: > No functional changes. Changing terminolgy in some > print statements. s/has_cdclk_squasher/has_cdclk_squash, > s/crawler/crawl and s/squasher/squash. > > Cc: Balasubramani Vivekanandan > Cc: Ville Syrjälä > Signed-off-by: Anusha Srivatsa > --- > d

Re: [Intel-gfx] [PATCH 2/4] drm/i915/display: Introduce HAS_CDCLK_SQUASH macro

On 21.10.2022 14:39, Anusha Srivatsa wrote: > Driver had discrepancy in how cdclk squash and crawl support > were checked. Like crawl, add squash as a 1 bit feature flag > to the display section of DG2. > > Cc: Balasubramani Vivekanandan > Cc: Ville Syrjälä > Signed-off-by: Anusha Srivatsa > --

Re: [Intel-gfx] [PATCH 3/4] drm/i915/display: Move chunks of code out of bxt_set_cdclk()

On 21.10.2022 14:39, Anusha Srivatsa wrote: > No functional change. Moving segments out to simplify > bxt_set_cdlck() > > v2: s/bxt_cdclk_pll/bxt_cdclk_pll_update (Jani) > > Cc: Jani Nikula > Cc: Balasubramani Vivekanandan > Cc: Ville Syrjälä > Signed-off-by: Anusha Srivatsa > --- > drivers/

Re: [Intel-gfx] [PATCH 4/4] drm/i915/display: Move squash_ctl register programming to its own function

On 21.10.2022 14:39, Anusha Srivatsa wrote: > No functional change. Introduce dg2_cdclk_squash_program and > move squash_ctl register programming bits to this. > > v2: s/dg2_cdclk_squash_programming/dg2_cdclk_squash_program (Jani) > > Cc: Jani Nikula > Cc: Balasubramani Vivekanandan > Cc: Ville

Re: [Intel-gfx] [PATCH] drm/i915/sdvo: Fallback to current output timings for LVDS fixed mode

On Tue, 25 Oct 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > If we can't dig out a fixed mode for LVDS from the VBT or EDID > let's fall back to using the current output timings. This should > work as long as the BIOS has (somehow) enabled the output. > > In this case we are dealing with t

[Intel-gfx] [PATCH 2/2] drm/i915/dg2: Introduce Wa_18019271663

Wa_18019271663 applies to all DG2 steppings and skus. Bspec:45809 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 7 --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/i

[Intel-gfx] [PATCH 1/2] drm/i915/dg2: Introduce Wa_18018764978

Wa_18018764978 applies to specific steppings of DG2 (G11 C0+, G11 and G12 A0+). Bspec: 66622 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +++ drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/

[Intel-gfx] [PATCH 05/10] vfio: Use IOMMU_CAP_ENFORCE_CACHE_COHERENCY for vfio_file_enforced_coherent()

iommufd doesn't establish the iommu_domains until after the device FD is opened, even if the container has been set. This design is part of moving away from the group centric iommu APIs. This is fine, except that the normal sequence of establishing the kvm wbindv won't work: group = open("/dev

[Intel-gfx] [PATCH 03/10] vfio: Rename vfio_device_assign/unassign_container()

These functions don't really assign anything anymore, they just increment some refcounts and do a sanity check. Call them vfio_group_[un]use_container() Signed-off-by: Jason Gunthorpe --- drivers/vfio/container.c | 14 ++ drivers/vfio/vfio.h | 4 ++-- drivers/vfio/vfio_main.c |

[Intel-gfx] [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()

The only thing this function does is assert the group has an assigned container and incrs refcounts. The overall model we have is that once a conatiner_users refcount is incremented it cannot be de-assigned from the group - vfio_group_ioctl_unset_container() will fail and the group FD cannot be cl

[Intel-gfx] [PATCH 04/10] vfio: Move storage of allow_unsafe_interrupts to vfio_main.c

This legacy module knob has become uAPI, when set on the vfio_iommu_type1 it disables some security protections in the iommu drivers. Move the storage for this knob to vfio_main.c so that iommufd can access it too. Signed-off-by: Jason Gunthorpe --- drivers/vfio/vfio.h | 2 ++ driver

[Intel-gfx] [PATCH 00/10] Connect VFIO to IOMMUFD

This series provides an alternative container layer for VFIO implemented using iommufd. This is optional, if CONFIG_IOMMUFD is not set then it will not be compiled in. At this point iommufd can be injected by passing in a iommfd FD to VFIO_GROUP_SET_CONTAINER which will use the VFIO compat layer i

[Intel-gfx] [PATCH 01/10] vfio: Move vfio_device driver open/close code to a function

This error unwind is getting complicated. Move all the code into two pair'd function. The functions should be called when the open_count == 1 after incrementing/before decrementing. Signed-off-by: Jason Gunthorpe --- drivers/vfio/vfio_main.c | 95 ++-- 1 file

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/edid: EDID override refactoring and fixes (rev3)

== Series Details == Series: drm/edid: EDID override refactoring and fixes (rev3) URL : https://patchwork.freedesktop.org/series/109579/ State : success == Summary == CI Bug Log - changes from CI_DRM_12293_full -> Patchwork_109579v3_full Su

[Intel-gfx] [PATCH 3/4] drm/i915/display: Move chunks of code out of bxt_set_cdclk()

No functional change. Moving segments out to simplify bxt_set_cdlck() v2: s/bxt_cdclk_pll/bxt_cdclk_pll_update (Jani) Cc: Jani Nikula Cc: Balasubramani Vivekanandan Cc: Ville Syrjälä Signed-off-by: Anusha Srivatsa Reviewed-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/inte

[Intel-gfx] [PATCH 1/4] drm/i915/display: Change terminology for cdclk actions

No functional changes. Changing terminology in some print statements. s/has_cdclk_squasher/has_cdclk_squash, s/crawler/crawl and s/squasher/squash. Cc: Balasubramani Vivekanandan Cc: Ville Syrjälä Signed-off-by: Anusha Srivatsa Reviewed-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 2/4] drm/i915/display: Introduce HAS_CDCLK_SQUASH macro

Driver had discrepancy in how cdclk squash and crawl support were checked. Like crawl, add squash as a 1 bit feature flag to the display section of DG2. Cc: Balasubramani Vivekanandan Cc: Ville Syrjälä Signed-off-by: Anusha Srivatsa Reviewed-by: Balasubramani Vivekanandan --- drivers/gpu/drm/

[Intel-gfx] [PATCH 4/4] drm/i915/display: Move squash_ctl register programming to its own function

No functional change. Introduce dg2_cdclk_squash_program and move squash_ctl register programming bits to this. v2: s/dg2_cdclk_squash_programming/dg2_cdclk_squash_program (Jani) Cc: Jani Nikula Cc: Balasubramani Vivekanandan Cc: Ville Syrjälä Signed-off-by: Anusha Srivatsa Reviewed-by: Balas

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/sdvo: Fallback to current output timings for LVDS fixed mode

== Series Details == Series: drm/i915/sdvo: Fallback to current output timings for LVDS fixed mode URL : https://patchwork.freedesktop.org/series/110130/ State : success == Summary == CI Bug Log - changes from CI_DRM_12294 -> Patchwork_110130v1 =

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915/uapi: expose GTT alignment"

== Series Details == Series: Revert "drm/i915/uapi: expose GTT alignment" URL : https://patchwork.freedesktop.org/series/110041/ State : success == Summary == CI Bug Log - changes from CI_DRM_12284 -> Patchwork_110041v1 Summary --- *

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Fix a build error used with clang compiler

On Tue, 25 Oct 2022 02:25:06 -0700, Andi Shyti wrote: > > Hi Ashutosh, Hi Andi :) > > > If a non-constant variable is used as the first argument of the FIELD_PREP > > > macro, a build error occurs when using the clang compiler. A "non-constant variable" does not seem to be the cause of the compi

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Fix a build error used with clang compiler

On Tue, 25 Oct 2022 07:30:49 -0700, Jani Nikula wrote: > > On Tue, 25 Oct 2022, Jani Nikula wrote: > > On Tue, 25 Oct 2022, Gwan-gyeong Mun wrote: > >> If a non-constant variable is used as the first argument of the FIELD_PREP > >> macro, a build error occurs when using the clang compiler. > >> >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/dg2: Introduce Wa_18018764978

== Series Details == Series: series starting with [1/2] drm/i915/dg2: Introduce Wa_18018764978 URL : https://patchwork.freedesktop.org/series/110131/ State : warning == Summary == Error: dim checkpatch failed c5d85fb8644b drm/i915/dg2: Introduce Wa_18018764978 -:37: CHECK:PARENTHESIS_ALIGNMENT

[Intel-gfx] [PATCH 10/10] iommufd: Allow iommufd to supply /dev/vfio/vfio

If the VFIO container is compiled out, give a kconfig option for iommufd to provide the miscdev node with the same name and permissions as vfio uses. The compatibility node supports the same ioctls as VFIO and automatically enables the VFIO compatible pinned page accounting mode. Signed-off-by: J

[Intel-gfx] [PATCH 08/10] vfio-iommufd: Support iommufd for emulated VFIO devices

Emulated VFIO devices are calling vfio_register_emulated_iommu_dev() and consist of all the mdev drivers. Like the physical drivers, support for iommufd is provided by the driver supplying the correct correct standard ops. Provide ops from the core that duplicate what vfio_register_emulated_iommu_

[Intel-gfx] [PATCH 07/10] vfio-iommufd: Support iommufd for physical VFIO devices

This creates the iommufd_device for the physical VFIO drivers. These are all the drivers that are calling vfio_register_group_dev() and expect the type1 code to setup a real iommu_domain against their parent struct device. The design gives the driver a choice in how it gets connected to iommufd by

[Intel-gfx] [PATCH 06/10] vfio-iommufd: Allow iommufd to be used in place of a container fd

This makes VFIO_GROUP_SET_CONTAINER accept both a vfio container FD and an iommufd. In iommufd mode an IOAS will exist after the SET_CONTAINER, but it will not be attached to any groups. >From a VFIO perspective this means that the VFIO_GROUP_GET_STATUS and VFIO_GROUP_FLAGS_VIABLE works subtly di

[Intel-gfx] [PATCH 09/10] vfio: Make vfio_container optionally compiled

Add a kconfig CONFIG_VFIO_CONTAINER that controls compiling the container code. If 'n' then only iommufd will provide the container service. All the support for vfio iommu drivers, including type1, will not be built. This allows a compilation check that no inappropriate dependencies between the de

Re: [Intel-gfx] [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

Hi, On 10/24/22 22:30, Matthew Garrett wrote: > On Tue, Sep 27, 2022 at 01:04:52PM +0200, Hans de Goede wrote: > >> So to fix this we need to make acpi_video_get_backlight_type() >> return native on the Acer Chromebook Spin 713. > > Isn't the issue broader than that? Unless the platform is Windo

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/dg2: Introduce Wa_18018764978

== Series Details == Series: series starting with [1/2] drm/i915/dg2: Introduce Wa_18018764978 URL : https://patchwork.freedesktop.org/series/110131/ State : success == Summary == CI Bug Log - changes from CI_DRM_12294 -> Patchwork_110131v1

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "drm/i915/uapi: expose GTT alignment"

Regression failures are related to https://gitlab.freedesktop.org/drm/intel/-/issues/7311 Re-reported. Lakshmi. -Original Message- From: Auld, Matthew Sent: Tuesday, October 25, 2022 2:09 AM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana Subject: Re: ✗ Fi.CI.BAT: failure

Re: [Intel-gfx] [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

On Tue, Oct 25, 2022 at 08:50:54PM +0200, Hans de Goede wrote: > That is a valid point, but keep in mind that this is only used on ACPI > platforms and then only on devices with a builtin LCD panel and then > only by GPU drivers which actually call acpi_video_get_backlight_type(), > so e.g. not by

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/slpc: Optmize waitboost for SLPC (rev6)

== Series Details == Series: drm/i915/slpc: Optmize waitboost for SLPC (rev6) URL : https://patchwork.freedesktop.org/series/109840/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12294 -> Patchwork_109840v6 Summary ---

  1   2   >