[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/psr: Send update also on invalidate

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915/psr: Send update also on invalidate URL : https://patchwork.freedesktop.org/series/110037/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12280 -> Patchwork_110037v1 Summary --- *

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: use intel_uncore_rmw when appropriate

2022-10-24 Thread Andrzej Hajda
Hi, Thx for review. On 21.10.2022 20:31, Andi Shyti wrote: Hi Andrzej, On Wed, Oct 19, 2022 at 04:38:17PM +0200, Andrzej Hajda wrote: This patch replaces all occurences of the form intel_uncore_write(reg, intel_uncore_read(reg) OP val) with intel_uncore_rmw. Signed-off-by: Andrzej Hajda Re

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/pps: improve eDP power on flow.

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915/pps: improve eDP power on flow. URL : https://patchwork.freedesktop.org/series/110038/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12280 -> Patchwork_110038v1 Summary --- **FAI

Re: [Intel-gfx] [PATCH] drm/i915/psr: Send update also on invalidate

2022-10-24 Thread Kahola, Mika
> -Original Message- > From: Hogander, Jouni > Sent: Monday, October 24, 2022 8:47 AM > To: intel-gfx@lists.freedesktop.org > Cc: Hogander, Jouni ; Souza, Jose > ; Ville Syrjälä ; Kahola, > Mika ; Brian J . Tarricone > Subject: [PATCH] drm/i915/psr: Send update also on invalidate > > Cur

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload

2022-10-24 Thread Das, Nirmoy
On 10/21/2022 6:34 PM, Ville Syrjälä wrote: On Fri, Sep 23, 2022 at 09:35:14AM +0200, Nirmoy Das wrote: i915_gem_drain_freed_objects() might not be enough to free all the objects and RCU delayed work might get scheduled after the i915 device struct gets freed. Call i915_gem_drain_workqueue()

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: use intel_uncore_rmw when appropriate

2022-10-24 Thread Jani Nikula
On Mon, 24 Oct 2022, Andrzej Hajda wrote: > Hi, > > Thx for review. > > On 21.10.2022 20:31, Andi Shyti wrote: >> Hi Andrzej, >> >> On Wed, Oct 19, 2022 at 04:38:17PM +0200, Andrzej Hajda wrote: >>> This patch replaces all occurences of the form >>> intel_uncore_write(reg, intel_uncore_read(reg) O

Re: [Intel-gfx] [PATCH v7 14/21] media: tegra-vde: Prepare to dynamic dma-buf locking specification

2022-10-24 Thread Hans Verkuil
On 10/17/22 19:22, Dmitry Osipenko wrote: > Prepare Tegra video decoder driver to the common dynamic dma-buf > locking convention by starting to use the unlocked versions of dma-buf > API functions. > > Acked-by: Christian König Acked-by: Hans Verkuil Thanks! Hans > Signed-off-by:

Re: [Intel-gfx] [PATCH v7 13/21] media: videobuf2: Prepare to dynamic dma-buf locking specification

2022-10-24 Thread Hans Verkuil
On 10/17/22 19:22, Dmitry Osipenko wrote: > Prepare V4L2 memory allocators to the common dynamic dma-buf locking > convention by starting to use the unlocked versions of dma-buf API > functions. > > Acked-by: Tomasz Figa Acked-by: Hans Verkuil Thanks! Hans > Acked-by: Christian Kö

Re: [Intel-gfx] [PATCH] drm/i915/hdmi: SPD infoframe updated for discrete

2022-10-24 Thread Jani Nikula
On Fri, 21 Oct 2022, Jani Nikula wrote: > On Wed, 19 Oct 2022, "Taylor, Clinton A" wrote: >> +struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); > > Always struct drm_i915_private *i915 for new code please. Also for v2. -- Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: use intel_uncore_rmw when appropriate

2022-10-24 Thread Andi Shyti
Hi, > >>> This patch replaces all occurences of the form > >>> intel_uncore_write(reg, intel_uncore_read(reg) OP val) > >>> with intel_uncore_rmw. > >>> > >>> Signed-off-by: Andrzej Hajda > >> Reviewed-by: Andi Shyti > >> > >> There are some lines that go over 80 characters... do you mind if I f

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: use intel_uncore_rmw when appropriate

2022-10-24 Thread Jani Nikula
On Mon, 24 Oct 2022, Andi Shyti wrote: > PS Hard habits are hard to die: I still like the 80 characters > because they force programmers to write cleaner code and, as a > tiling wm user, I find it more convenient. I generally try to fit everything in 80 columns too, but I also don't like to split

[Intel-gfx] [PATCH] Revert "drm/i915/uapi: expose GTT alignment"

2022-10-24 Thread Matthew Auld
The process for merging uAPI is to have UMD side ready and reviewed and merged before merging. Revert for now until that is ready. This reverts commit d54576a074a29d4901d0a693cd84e1a89057f694. Reported-by: Joonas Lahtinen Signed-off-by: Matthew Auld Cc: Lionel Landwerlin Cc: Michal Mrozek Cc:

[Intel-gfx] [PATCH v2 01/21] drm/komeda: Don't set struct drm_driver.lastclose

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as komeda uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/gp

[Intel-gfx] [PATCH v2 03/21] drm/vboxvideo: Don't set struct drm_driver.lastclose

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as vboxvideo uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers

[Intel-gfx] [PATCH v2 00/21] drm/fb-helper: Untangle fbdev emulation and helpers

2022-10-24 Thread Thomas Zimmermann
Separate generic fbdev emulation from the helper code that is shared among the various fbdev implementations within DRM. Affects many drivers. It has become apparent that our fully generic fbdev emulation will never produce optimal results for all drivers. In its current form, it is also hard to m

[Intel-gfx] [PATCH v2 02/21] drm/mcde: Don't set struct drm_driver.lastclose

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.lastclose. It's used to restore the fbdev console. But as mcde uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the call to drm_client_dev_restore() in drm_lastclose(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/

[Intel-gfx] [PATCH v2 07/21] drm/logicvc: Don't set struct drm_driver.output_poll_changed

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as logicvc uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm

[Intel-gfx] [PATCH v2 09/21] drm/panel-ili9341: Include

2022-10-24 Thread Thomas Zimmermann
Include for devm_of_find_backlight(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c index 39dc40cf681f0..b59472c29

[Intel-gfx] [PATCH v2 05/21] drm/imx/dcss: Don't set struct drm_driver.output_poll_changed

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as DCSS uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm_pr

[Intel-gfx] [PATCH v2 04/21] drm/amdgpu: Don't set struct drm_driver.output_poll_changed

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as amdgpu uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm_

[Intel-gfx] [PATCH v2 10/21] drm/tve200: Include

2022-10-24 Thread Thomas Zimmermann
Include for of_match_ptr(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tve200/tve200_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c index 04db72e3fa9c2..611785e097576 100644 --- a/drivers/gpu/drm/tve

[Intel-gfx] [PATCH v2 11/21] drm/fb-helper: Cleanup include statements in header file

2022-10-24 Thread Thomas Zimmermann
Only include what we have to. Signed-off-by: Thomas Zimmermann --- include/drm/drm_fb_helper.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index fddd0d1af6891..e923089522896 100644 --- a/include/drm/drm_fb_he

[Intel-gfx] [PATCH v2 08/21] drm/rockchip: Don't set struct drm_driver.output_poll_changed

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as rockchip uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in dr

[Intel-gfx] [PATCH v2 06/21] drm/ingenic: Don't set struct drm_driver.output_poll_changed

2022-10-24 Thread Thomas Zimmermann
Don't set struct drm_driver.output_poll_changed. It's used to restore the fbdev console. But as ingenic uses generic fbdev emulation, the console is being restored by the DRM client helpers already. See the functions drm_kms_helper_hotplug_event() and drm_kms_helper_connector_hotplug_event() in drm

[Intel-gfx] [PATCH v2 15/21] drm/fb-helper: Disconnect damage worker from update logic

2022-10-24 Thread Thomas Zimmermann
The fbdev helpers implement a damage worker that forwards fbdev updates to the DRM driver. The worker's update logic depends on the generic fbdev emulation. Separate the two via function pointer. The generic fbdev emulation sets struct drm_fb_helper_funcs.fb_dirty, a new callback that hides the up

[Intel-gfx] [PATCH v2 17/21] drm/fb-helper: Perform all fbdev I/O with the same implementation

2022-10-24 Thread Thomas Zimmermann
Implement the fbdev's read/write helpers with the same functions. Use the generic fbdev's code as template. Convert all drivers. DRM's fb helpers must implement regular I/O functionality in struct fb_ops and possibly perform a damage update. Handle all this in the same functions and convert driver

[Intel-gfx] [PATCH v2 21/21] drm/fb-helper: Remove unnecessary include statements

2022-10-24 Thread Thomas Zimmermann
Remove include statements for where it is not required (i.e., most of them). In a few places include other header files that are required by the source code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_display.c

[Intel-gfx] [PATCH v2 13/21] drm/fb-helper: Rename drm_fb_helper_alloc_fbi() to use _info postfix

2022-10-24 Thread Thomas Zimmermann
Rename drm_fb_helper_alloc_fbi() to drm_fb_helper_alloc_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm/drm_fb_helper.c| 8 ---

[Intel-gfx] [PATCH v2 18/21] drm/fb_helper: Minimize damage-helper overhead

2022-10-24 Thread Thomas Zimmermann
Pull the test for fb_dirty into the caller to avoid extra work if no callback has been set. In this case no damage handling is required and no damage area needs to be computed. Print a warning if the damage worker runs without getting an fb_dirty callback. Signed-off-by: Thomas Zimmermann --- dr

[Intel-gfx] [PATCH v2 20/21] drm/fb-helper: Move generic fbdev emulation into separate source file

2022-10-24 Thread Thomas Zimmermann
Move the generic fbdev implementation into its own source and header file. Adapt drivers. No functonal changes, but some of the internal helpers have been renamed to fit into the drm_fbdev_ naming scheme. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Makefile | 2 +-

[Intel-gfx] [PATCH v2 12/21] drm/fb_helper: Rename field fbdev to info in struct drm_fb_helper

2022-10-24 Thread Thomas Zimmermann
Rename struct drm_fb_helper.fbdev to info. The current name is misleading as it overlaps with generic fbdev naming conventions. Adapt to the usual naming in fbdev drivers by calling the field 'info'. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c

[Intel-gfx] [PATCH v2 14/21] drm/fb-helper: Rename drm_fb_helper_unregister_fbi() to use _info postfix

2022-10-24 Thread Thomas Zimmermann
Rename drm_fb_helper_unregister_fbi() to drm_fb_helper_unregister_info() as part of unifying the naming within fbdev helpers. Adapt drivers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm/drm_fb_helper.c|

[Intel-gfx] [PATCH v2 19/21] drm/fb-helper: Always initialize generic fbdev emulation

2022-10-24 Thread Thomas Zimmermann
Initialize the generic fbdev emulation even if it has been disabled on the kernel command line. The hotplug and mode initialization will fail accordingly. The kernel parameter can still be changed at runtime and the emulation will initialize after hotplugging the connector. Signed-off-by: Thomas

[Intel-gfx] [PATCH v2 16/21] drm/fb-helper: Call fb_sync in I/O functions

2022-10-24 Thread Thomas Zimmermann
Call struct fb_ops.fb_sync in drm_fbdev_{read,write}() to mimic the behavior of fbdev. Fbdev implementations of fb_read and fb_write in struct fb_ops invoke fb_sync to synchronize with outstanding operations before I/O. Doing the same in DRM implementations will allow us to use them throughout DRM

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: stop abusing swiotlb_max_segment (rev3)

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915: stop abusing swiotlb_max_segment (rev3) URL : https://patchwork.freedesktop.org/series/109946/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12284 -> Patchwork_109946v3 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Revert "drm/i915/uapi: expose GTT alignment"

2022-10-24 Thread Patchwork
== Series Details == Series: Revert "drm/i915/uapi: expose GTT alignment" URL : https://patchwork.freedesktop.org/series/110041/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Jani Nikula
On Mon, 24 Oct 2022, Akihiko Odaki wrote: > Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() > helper") and following commits made native backlight unavailable if > CONFIG_ACPI_VIDEO is set and the backlight feature of ACPI video is > unavailable, which broke the backlight

Re: [Intel-gfx] [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Hans de Goede
Hi Akihiko, On 10/24/22 13:34, Akihiko Odaki wrote: > Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() > helper") and following commits made native backlight unavailable if > CONFIG_ACPI_VIDEO is set and the backlight feature of ACPI video is > unavailable, which broke the

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/fb-helper: Untangle fbdev emulation and helpers (rev2)

2022-10-24 Thread Patchwork
== Series Details == Series: drm/fb-helper: Untangle fbdev emulation and helpers (rev2) URL : https://patchwork.freedesktop.org/series/109942/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o

[Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "drm/i915/uapi: expose GTT alignment"

2022-10-24 Thread Patchwork
== Series Details == Series: Revert "drm/i915/uapi: expose GTT alignment" URL : https://patchwork.freedesktop.org/series/110041/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12284 -> Patchwork_110041v1 Summary --- *

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/fb-helper: Untangle fbdev emulation and helpers (rev2)

2022-10-24 Thread Thomas Zimmermann
Am 24.10.22 um 13:53 schrieb Patchwork: == Series Details == Series: drm/fb-helper: Untangle fbdev emulation and helpers (rev2) URL : https://patchwork.freedesktop.org/series/109942/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool

Re: [Intel-gfx] [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Hans de Goede
Hi, On 10/24/22 13:56, Akihiko Odaki wrote: > On 2022/10/24 20:48, Jani Nikula wrote: >> On Mon, 24 Oct 2022, Akihiko Odaki wrote: >>> Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() >>> helper") and following commits made native backlight unavailable if >>> CONFIG_ACPI_V

[Intel-gfx] [PATCH v2 01/16] drm/i915/hdmi: do dual mode detect only if connected

2022-10-24 Thread Jani Nikula
For normal connector detect, there's really no point in trying dual mode detect if the connector is disconnected. We can simplify the detect sequence by skipping it. Since intel_hdmi_dp_dual_mode_detect() is only called when EDID is present, we can drop the has_edid parameter. The functional effec

[Intel-gfx] [PATCH v2 00/16] drm/edid: EDID override refactoring and fixes

2022-10-24 Thread Jani Nikula
v2 of drm/edid: EDID override refactoring and fixes Address review comments, add patch 15. BR, Jani. Jani Nikula (16): drm/i915/hdmi: do dual mode detect only if connected drm/i915/hdmi: stop using connector->override_edid drm/amd/display: stop using connector->override_edid drm/edid: d

[Intel-gfx] [PATCH v2 02/16] drm/i915/hdmi: stop using connector->override_edid

2022-10-24 Thread Jani Nikula
The connector->override_edid flag is strictly for EDID override debugfs management, and drivers have no business using it. The check for override_edid was added in commit 301906290553 ("drm/i915: Ignore TMDS clock limit for DP++ when EDID override is set") to facilitate mode list cross-checking ag

[Intel-gfx] [PATCH v2 05/16] drm/edid: abstract debugfs override EDID show better

2022-10-24 Thread Jani Nikula
Add a function to dump the override EDID in debugfs. This hides the override EDID management better in drm_edid.c. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_crtc_internal.h | 4 +++- drivers/gpu/drm/drm_debugfs.c | 8 +--- drivers/gpu/drm/drm_edid

[Intel-gfx] [PATCH v2 04/16] drm/edid: debug log EDID override set/reset

2022-10-24 Thread Jani Nikula
It's useful debugging information to know if and when an override EDID was set or reset. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 4

[Intel-gfx] [PATCH v2 03/16] drm/amd/display: stop using connector->override_edid

2022-10-24 Thread Jani Nikula
The connector->override_edid flag is strictly for EDID override debugfs management, and drivers have no business using it. Cc: Alex Deucher Cc: Christian König Cc: Xinhui Pan Cc: amd-...@lists.freedesktop.org Signed-off-by: Jani Nikula Reviewed-by: Harry Wentland Acked-by: Alex Deucher ---

[Intel-gfx] [PATCH v2 06/16] drm/edid: rename drm_add_override_edid_modes() to drm_edid_override_connector_update()

2022-10-24 Thread Jani Nikula
Follow the naming of both EDID override functions as well as drm_edid_connector_update(). This also matches better what the function does; a combination of EDID property update and add modes. Indeed it should later be converted to call drm_edid_connector_update(). Signed-off-by: Jani Nikula Revie

[Intel-gfx] [PATCH v2 08/16] drm/edid: add function for checking drm_edid validity

2022-10-24 Thread Jani Nikula
We've lacked a function for immutable validity check on drm_edid. Add one. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 30 ++ include/drm/drm_edid.h | 1 + 2 files changed, 31 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v2 07/16] drm/edid: split drm_edid block count helper

2022-10-24 Thread Jani Nikula
Split the drm_edid block count helper to a base version that reports the block count indicated by EDID contents, and another on top that limits the block count based on size allocated for the EDID. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 15 +++

[Intel-gfx] [PATCH v2 10/16] drm/edid/firmware: drop redundant connector_name variable/parameter

2022-10-24 Thread Jani Nikula
Stop passing around something that's readily available in connector->name. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid_load.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_edid_load.c b/drivers/gpu

[Intel-gfx] [PATCH v2 12/16] drm/edid: use struct drm_edid for override/firmware EDID

2022-10-24 Thread Jani Nikula
There's a lot going on here, but the main thing is switching the firmware EDID loader to use struct drm_edid. Unfortunately, it's difficult to reasonably split to smaller pieces. Convert the EDID loader to struct drm_edid. There's a functional change in validation; it no longer tries to fix errors

[Intel-gfx] [PATCH v2 09/16] drm/edid: detach debugfs EDID override from EDID property update

2022-10-24 Thread Jani Nikula
Having the EDID override debugfs directly update the EDID property is problematic. The update is partial only. The driver has no way of knowing it's been updated. Mode list is not updated. It's an inconsistent state. Detach debugfs EDID override from the property update completely. Only set and re

[Intel-gfx] [PATCH v2 11/16] drm/edid/firmware: rename drm_load_edid_firmware() to drm_edid_load_firmware()

2022-10-24 Thread Jani Nikula
Follow the usual naming convention by file name. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 10 +- drivers/gpu/drm/drm_edid_load.c | 2 +- include/drm/drm_edid.h | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff

[Intel-gfx] [PATCH v2 16/16] drm/edid: convert to device specific logging

2022-10-24 Thread Jani Nikula
Convert to drm_kms_dbg/drm_err where possible, and reference the connector using [CONNECTOR:%d:%s]. Pass connectors around a bit more to enable this. Where this is not possible, unify the rest of the debugs to DRM_DEBUG_KMS. Rewrite tile debug logging to one line while at it. v2: - Use [CONNECTOR

[Intel-gfx] [PATCH v2 14/16] drm/edid/firmware: convert to drm device specific logging

2022-10-24 Thread Jani Nikula
Conform to device specific logging. v2: Include [CONNECTOR:%d:%s] (Ville) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid_load.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid_load.c b/drivers/gpu/drm/drm_edid_load.c index 882ca

[Intel-gfx] [PATCH v2 15/16] drm/edid: add [CONNECTOR:%d:%s] to debug logging

2022-10-24 Thread Jani Nikula
Reference the connector using [CONNECTOR:%d:%s] in existing device based debug logging. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 38 +- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/

[Intel-gfx] [PATCH v2 13/16] drm/edid: move edid load declarations to internal header

2022-10-24 Thread Jani Nikula
The EDID loader is internal to drm, not for drivers. Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_crtc_internal.h | 11 +++ drivers/gpu/drm/drm_edid_load.c | 5 +++-- include/drm/drm_edid.h | 7 --- 3 files changed, 14 insertions(+

Re: [Intel-gfx] mm/huge_memory: do not clobber swp_entry_t during THP split

2022-10-24 Thread Tvrtko Ursulin
Hi Mel, mm experts, With 6.1-rc2 we started hitting the WARN_ON added in 71e2d666ef85 ("mm/huge_memory: do not clobber swp_entry_t during THP split") in i915 automated CI: It looks like this: <4> [259.367534] page:ea000885 refcount:0 mapcount:0 mapping:88811a756a00 index:0x0 pfn

Re: [Intel-gfx] [PATCH] drm/i915/pps: improve eDP power on flow.

2022-10-24 Thread Ville Syrjälä
On Mon, Oct 24, 2022 at 02:40:04PM +0800, Lee Shawn C wrote: > Driver always apply panel power off cycle delay before eDP enable. > If eDP display was enabled at pre-os stage, driver would always > trigger modeset to optimize cdclk setting after boot into kernel. > So last_power_on and last_backlig

Re: [Intel-gfx] [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Hans de Goede
Hi, On 10/24/22 14:58, Akihiko Odaki wrote: > On 2022/10/24 20:53, Hans de Goede wrote: >> Hi Akihiko, >> >> On 10/24/22 13:34, Akihiko Odaki wrote: >>> Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() >>> helper") and following commits made native backlight unavailable if

Re: [Intel-gfx] [PATCH] drm/i915/psr: Send update also on invalidate

2022-10-24 Thread Souza, Jose
On Mon, 2022-10-24 at 08:46 +0300, Jouni Högander wrote: > Currently we are observing mouse cursor stuttering when using > xrandr --scaling=1.2x1.2. X scaling/transformation seems to be > doing fronbuffer rendering. When moving mouse cursor X seems to > perform several invalidates and only one Dirt

[Intel-gfx] [PATCH 20/22] platform/x86: intel_oaktrail: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/intel/oaktrail.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel/oaktrail.c b/drivers/platform/x86/intel/oaktrail.c index 7c5c623630c1..f44a51d

[Intel-gfx] [PATCH 06/22] platform/x86: asus-wmi: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/asus-wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index 6e8e093f96b3..55cca068f783 100644 --

[Intel-gfx] [PATCH 03/22] LoongArch: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/loongarch/loongson-laptop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/loongarch/loongson-laptop.c b/drivers/platform/loongarch/loongson-laptop.c in

Re: [Intel-gfx] i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify swiotlb_max_segment"

2022-10-24 Thread Jan Beulich
On 18.10.2022 10:24, Christoph Hellwig wrote: > @@ -127,19 +128,22 @@ static inline unsigned int i915_sg_dma_sizes(struct > scatterlist *sg) > return page_sizes; > } > > -static inline unsigned int i915_sg_segment_size(void) > +static inline unsigned int i915_sg_segment_size(struct device

Re: [Intel-gfx] [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Pali Rohár
On Monday 24 October 2022 21:58:57 Akihiko Odaki wrote: > Regarding the second limitation, I don't even understand the difference > between vendor and native. My guess is that a vendor backlight device uses > vendor-specific ACPI interface, and a native one directly uses hardware > registers. If my

[Intel-gfx] [PATCH 09/22] platform/x86: fujitsu-laptop: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/fujitsu-laptop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index b543d117b12c..e82

[Intel-gfx] [PATCH 13/22] platform/x86: nvidia-wmi-ec-backlight: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/nvidia-wmi-ec-backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/nvidia-wmi-ec-backlight.c b/drivers/platform/x86/nvidia-wmi-ec-backlight.c

[Intel-gfx] [PATCH 22/22] ACPI: video: Fallback to native backlight

2022-10-24 Thread Akihiko Odaki
Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper") and following commits made native backlight unavailable if CONFIG_ACPI_VIDEO is set and the backlight feature of ACPI video is unavailable, which broke the backlight functionality on Lenovo ThinkPad C13 Yoga Chromeboo

[Intel-gfx] [PATCH 01/22] drm/i915/opregion: Improve backlight request condition

2022-10-24 Thread Akihiko Odaki
asle_set_backlight() needs to accept backlight request only if the firmware controls the backlight. It used the following expression for this purpose: acpi_video_get_backlight_type() == acpi_backlight_native This expression works well in practice, but has two semantic problems. One is that it actu

Re: [Intel-gfx] [PATCH 03/21] drm/ingenic: Don't set struct drm_driver.lastclose

2022-10-24 Thread Sergey Shtylyov
Hello! On 10/20/22 1:37 PM, Thomas Zimmermann wrote: > Don't set struct drm_mode_config.output_poll_changed. It's used to > inform the fbdev console about conncetor changes. But as ingenic Connector. :-) > uses generic fbdev emulation, the console is being informed by the > DRM client helper

[Intel-gfx] [PATCH 05/22] platform/x86: asus-laptop: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/asus-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index 47b2f8bb6fb5..fb7f9e8ca6c4 100

[Intel-gfx] [PATCH 3/6] drm/i915: fix’s on ttm_resource rework to use size_t type

2022-10-24 Thread Somalapuram Amaranath
Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- drivers/gpu/drm/i915/i915_scatterlist.c | 4 ++-- drivers/gpu/drm/i915/i915_ttm_buddy_manager.c | 12 ++-- drivers/gpu/drm/i915/intel

Re: [Intel-gfx] [RFC 13/17] cgroup/drm: Ability to periodically scan cgroups for over budget GPU usage

2022-10-24 Thread T.J. Mercier
On Wed, Oct 19, 2022 at 10:34 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Add a scanning worker, which if enabled, periodically queries the cgroup > for GPU usage and if over budget (as configured by it's relative weight > share) notifies the drm core about the fact. > > This is off by

[Intel-gfx] [PATCH 07/22] platform/x86: compal-laptop: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/compal-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/compal-laptop.c b/drivers/platform/x86/compal-laptop.c index e10d2f64dfad..16ced03fa1

[Intel-gfx] [PATCH 5/6] drm/radeon: fix’s on ttm_resource rework to use size_t type

2022-10-24 Thread Somalapuram Amaranath
Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/radeon/radeon_cs.c | 4 ++-- drivers/gpu/drm/radeon/radeon_object.c | 4 ++-- drivers/gpu/drm/radeon/radeon_trace.h | 2 +- drivers/gpu/drm/radeon/radeon_ttm.c| 4 ++-- 4 files c

[Intel-gfx] [PATCH 2/6] drm/amd: fix’s on ttm_resource rework to use size_t type

2022-10-24 Thread Somalapuram Amaranath
Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_t

[Intel-gfx] [PATCH 4/6] drm/nouveau: fix’s on ttm_resource rework to use size_t type

2022-10-24 Thread Somalapuram Amaranath
Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ++-- drivers/gpu/drm/nouveau/nouveau_bo0039.c | 4 ++-- drivers/gpu/drm/nouveau/nouveau_bo5039.c | 2 +- drivers/gpu/drm/nouveau/nouveau_bo74c1.c | 2 +- dri

[Intel-gfx] [PATCH 6/6] drm/vmwgfx: fix’s on ttm_resource rework to use size_t type

2022-10-24 Thread Somalapuram Amaranath
Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c| 6 +++--- drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_execb

[Intel-gfx] [PATCH 19/22] platform/x86: dell-laptop: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/dell/dell-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell/dell-laptop.c b/drivers/platform/x86/dell/dell-laptop.c index e92c3ad06d69..9

[Intel-gfx] [PATCH 17/22] platform/x86: thinkpad_acpi: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/thinkpad_acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 6a823b850a77..d756d2

[Intel-gfx] [PATCH 14/22] platform/x86: panasonic-laptop: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/panasonic-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/panasonic-laptop.c b/drivers/platform/x86/panasonic-laptop.c index ad3083f9946d..e

[Intel-gfx] [PATCH 16/22] platform/x86: sony-laptop: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/sony-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c index 765fcaba4d12..987942719ba6 100

[Intel-gfx] [PATCH 11/22] platform/x86: msi-laptop: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/msi-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c index 6b18ec543ac3..19e2f164181f 100644

[Intel-gfx] [PATCH 1/6] drm/ttm: rework on ttm_resource to use size_t type

2022-10-24 Thread Somalapuram Amaranath
Change ttm_resource structure from num_pages to size_t size in bytes. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/ttm/ttm_bo.c| 4 ++-- drivers/gpu/drm/ttm/ttm_bo_util.c | 6 +++--- drivers/gpu/drm/ttm/ttm_bo_vm.c | 4 ++-- drivers/gpu/drm/ttm/ttm_range_man

[Intel-gfx] [PATCH 02/22] ACPI: video: Introduce acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
This deprecates acpi_video_get_backlight_type(). Signed-off-by: Akihiko Odaki --- drivers/acpi/acpi_video.c | 2 +- drivers/acpi/video_detect.c | 6 +++--- include/acpi/video.h| 12 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/acpi_video.c

[Intel-gfx] [PATCH] i915/display: fix repeated words in comments

2022-10-24 Thread wangjianli
Delete the redundant word 'the'. Signed-off-by: wangjianli --- drivers/gpu/drm/i915/display/intel_crt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c index 6a3893c8ff22..fead011c87b5 100644

Re: [Intel-gfx] [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Akihiko Odaki
On 2022/10/24 20:53, Hans de Goede wrote: Hi Akihiko, On 10/24/22 13:34, Akihiko Odaki wrote: Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper") and following commits made native backlight unavailable if CONFIG_ACPI_VIDEO is set and the backlight feature of ACPI v

[Intel-gfx] [PATCH 10/22] platform/x86: ideapad-laptop: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/ideapad-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index abd0c81d62c4..befd5dc

[Intel-gfx] [PATCH] drm/i915: fix repeated words in comments

2022-10-24 Thread wangjianli
Delete the redundant word 'the'. Signed-off-by: wangjianli --- drivers/gpu/drm/i915/i915_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 73d5195146b0..9caf99a13c61 100644 --- a/drivers/

Re: [Intel-gfx] i915 "GPU HANG", bisected to a2daa27c0c61 "swiotlb: simplify swiotlb_max_segment"

2022-10-24 Thread Jan Beulich
On 18.10.2022 13:02, Christoph Hellwig wrote: > On Tue, Oct 18, 2022 at 10:57:37AM +0200, Jan Beulich wrote: >> Shouldn't this then be xen_pv_domain() that you use here, and - if you >> really want IS_ENABLED() in addition - CONFIG_XEN_PV? > > I'll need help from people that understand Xen better

[Intel-gfx] [PATCH 18/22] platform/x86: toshiba_acpi: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/toshiba_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 160abd3b3af8..3d747a901ad8

[Intel-gfx] [PATCH 08/22] platform/x86: eeepc-laptop: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/eeepc-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c index a388a28b6f2a..91dea49f7c3d

[Intel-gfx] [PATCH] drm/i915: fix repeated words in comments

2022-10-24 Thread wangjianli
Delete the redundant word 'the'. Signed-off-by: wangjianli --- drivers/gpu/drm/i915/gvt/gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c index b4f69364f9a1..7b29ef36941a 100644 --- a/drivers/gpu/drm/i915/gvt

[Intel-gfx] [PATCH 04/22] platform/x86: acer-wmi: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/acer-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c index 18224f9a5bc0..10d0819e48ff 100644 --- a/

[Intel-gfx] [PATCH 15/22] platform/x86: samsung-laptop: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/samsung-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c index b4aa8ba35d2d..8ba377d

[Intel-gfx] [PATCH 12/22] platform/x86: msi-wmi: Use acpi_video_get_backlight_types()

2022-10-24 Thread Akihiko Odaki
acpi_video_get_backlight_type() is now deprecated. Signed-off-by: Akihiko Odaki --- drivers/platform/x86/msi-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c index fd318cdfe313..3a74f0135fae 100644 --- a/dri

Re: [Intel-gfx] [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Akihiko Odaki
On 2022/10/24 20:48, Jani Nikula wrote: On Mon, 24 Oct 2022, Akihiko Odaki wrote: Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native() helper") and following commits made native backlight unavailable if CONFIG_ACPI_VIDEO is set and the backlight feature of ACPI video is unav

  1   2   3   >