[Intel-gfx] ✓ Fi.CI.IGT: success for drm/display: Don't assume dual mode adaptors support i2c sub-addressing (rev3)

2022-10-07 Thread Patchwork
== Series Details == Series: drm/display: Don't assume dual mode adaptors support i2c sub-addressing (rev3) URL : https://patchwork.freedesktop.org/series/109049/ State : success == Summary == CI Bug Log - changes from CI_DRM_12223_full -> Patchwork_109049v3_full =

Re: [Intel-gfx] [PATCH v5 3/4] drm/i915: Make the heartbeat play nice with long pre-emption timeouts

2022-10-07 Thread Tvrtko Ursulin
On 06/10/2022 22:38, john.c.harri...@intel.com wrote: From: John Harrison Compute workloads are inherently not pre-emptible for long periods on current hardware. As a workaround for this, the pre-emption timeout for compute capable engines was disabled. This is undesirable with GuC submission

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/edid/firmware: stop using throwaway platform device

2022-10-07 Thread Patchwork
== Series Details == Series: drm/edid/firmware: stop using throwaway platform device URL : https://patchwork.freedesktop.org/series/109464/ State : success == Summary == CI Bug Log - changes from CI_DRM_12223_full -> Patchwork_109464v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Allow panel fixed modes to have differing sync polarities

2022-10-07 Thread Patchwork
== Series Details == Series: drm/i915: Allow panel fixed modes to have differing sync polarities URL : https://patchwork.freedesktop.org/series/109467/ State : success == Summary == CI Bug Log - changes from CI_DRM_12223_full -> Patchwork_109467v1_full =

[Intel-gfx] [PATCH 0/2] Provision to ignore long HPDs in CI systems

2022-10-07 Thread Vinod Govindapillai
As some faulty displays generate long HPD even while connected to ports, can cause CI execution issues. Add a provision to ignore such long HPDs in such systems with control through debugfs Vinod Govindapillai (2): drm/i915/display: ignore long HPDs based on a flag drm/i915: debugfs entry to

[Intel-gfx] [PATCH 1/2] drm/i915/display: ignore long HPDs based on a flag

2022-10-07 Thread Vinod Govindapillai
Some panels generate long HPD events even while connected to the port. This cause some unexpected CI execution issues. A new flag is added to track if such spurious long HPDs can be ignored and are not processed further if the flag is set. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i

[Intel-gfx] [PATCH 2/2] drm/i915: debugfs entry to control ignore long hpd flag

2022-10-07 Thread Vinod Govindapillai
Knob to control ignoring the long hpds. Set this to true will start ignoring the long HPDs generated by the displays. Useful for use cases like CI systems where we dont expect to disconnect the panels. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_hotplug.c | 25 +

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Provision to ignore long HPDs in CI systems

2022-10-07 Thread Patchwork
== Series Details == Series: Provision to ignore long HPDs in CI systems URL : https://patchwork.freedesktop.org/series/109475/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Suspend/resume encoders during GPU reset

2022-10-07 Thread Imre Deak
On Thu, Oct 06, 2022 at 10:24:45PM +0300, Ville Syrjälä wrote: > On Thu, Oct 06, 2022 at 12:01:17AM +0300, Imre Deak wrote: > > On Wed, Oct 05, 2022 at 10:14:43PM +0300, Ville Syrjälä wrote: > > > On Wed, Oct 05, 2022 at 08:52:51PM +0300, Imre Deak wrote: > > > > The GPU reset involves a display su

[Intel-gfx] ✓ Fi.CI.BAT: success for Provision to ignore long HPDs in CI systems

2022-10-07 Thread Patchwork
== Series Details == Series: Provision to ignore long HPDs in CI systems URL : https://patchwork.freedesktop.org/series/109475/ State : success == Summary == CI Bug Log - changes from CI_DRM_12225 -> Patchwork_109475v1 Summary --- **

[Intel-gfx] [PATCH] drm/i915: Fix simulated GPU reset wrt. encoder HW readout

2022-10-07 Thread Imre Deak
The GPU reset involves a display suspend/resume sequence, but this is done without suspending/resuming the encoders. The encoder HW readout code during resume however assumes that the encoders were suspended/resumed, at least on TypeC platforms where the TC PHYs must be left in a disconnected state

Re: [Intel-gfx] [PATCH] drm/i915: Fix simulated GPU reset wrt. encoder HW readout

2022-10-07 Thread Ville Syrjälä
On Fri, Oct 07, 2022 at 04:33:07PM +0300, Imre Deak wrote: > The GPU reset involves a display suspend/resume sequence, but this is > done without suspending/resuming the encoders. The encoder HW readout > code during resume however assumes that the encoders were > suspended/resumed, at least on Typ

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix simulated GPU reset wrt. encoder HW readout

2022-10-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix simulated GPU reset wrt. encoder HW readout URL : https://patchwork.freedesktop.org/series/109480/ State : warning == Summary == Error: dim checkpatch failed 68c8da49030d drm/i915: Fix simulated GPU reset wrt. encoder HW readout -:23: WARNING:COMMIT_L

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix simulated GPU reset wrt. encoder HW readout

2022-10-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix simulated GPU reset wrt. encoder HW readout URL : https://patchwork.freedesktop.org/series/109480/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12225 -> Patchwork_109480v1 Summary

Re: [Intel-gfx] [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation

2022-10-07 Thread Gwan-gyeong Mun
On 9/28/22 11:51 AM, Jani Nikula wrote: On Wed, 28 Sep 2022, Gwan-gyeong Mun wrote: diff --git a/drivers/gpu/drm/i915/i915_scatterlist.h b/drivers/gpu/drm/i915/i915_scatterlist.h index 9ddb3e743a3e..1d1802beb42b 100644 --- a/drivers/gpu/drm/i915/i915_scatterlist.h +++ b/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation

2022-10-07 Thread Gwan-gyeong Mun
Linus and Kees, I also understood that I should not make and use the macro that performs assignment and checking at the same time, and I will drop it and update it. Kees, the overflows_type() macro had several updates as input from you and the community, and there is an advantage when moving t

Re: [Intel-gfx] [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation

2022-10-07 Thread Gwan-gyeong Mun
On 9/28/22 8:09 PM, Linus Torvalds wrote: On Wed, Sep 28, 2022 at 1:15 AM Gwan-gyeong Mun wrote: + if (check_assign(obj->base.size >> PAGE_SHIFT, &npages)) + return -E2BIG; I have to say, I find that new "check_assign()" macro use to be disgusting. It's one thing to c

[Intel-gfx] ✓ Fi.CI.IGT: success for Provision to ignore long HPDs in CI systems

2022-10-07 Thread Patchwork
== Series Details == Series: Provision to ignore long HPDs in CI systems URL : https://patchwork.freedesktop.org/series/109475/ State : success == Summary == CI Bug Log - changes from CI_DRM_12225_full -> Patchwork_109475v1_full Summary ---

[Intel-gfx] [PATCH] drm/i915/display: Add DC5 counter and DMC debugfs entries for MTL

2022-10-07 Thread Anusha Srivatsa
MTL and dgfx use the same DC5 counter. While at it, this patch also adds the corresponding debugfs entries. Some cleanup wrt dc3co register which makes the code more readable. Driver loads all firmware that it finds in the firmware binary but platform doesn't *need* all of them. Cleaning the prev

[Intel-gfx] [PATCH] drm/i915/gem: remove redundant assignments to variable ret

2022-10-07 Thread Colin Ian King
The variable ret is being assigned with a value that is never read both before and after a while-loop. The variable is being re-assigned inside the while-loop and afterwards on the call to the function i915_gem_object_lock_interruptible. Remove the redundants assignments. Cleans up clang scan-buil

[Intel-gfx] [PATCH] drm/i915/perf: remove redundant variable 'taken'

2022-10-07 Thread Colin Ian King
The assignment to variable taken is redundant and so it can be removed as well as the variable too. Cleans up clang-scan build warnings: warning: Although the value stored to 'taken' is used in the enclosing expression, the value is never actually read from 'taken' [deadcode.DeadStores] Signed-of

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Add DC5 counter and DMC debugfs entries for MTL

2022-10-07 Thread Patchwork
== Series Details == Series: drm/i915/display: Add DC5 counter and DMC debugfs entries for MTL URL : https://patchwork.freedesktop.org/series/109488/ State : success == Summary == CI Bug Log - changes from CI_DRM_12226 -> Patchwork_109488v1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: remove redundant assignments to variable ret

2022-10-07 Thread Patchwork
== Series Details == Series: drm/i915/gem: remove redundant assignments to variable ret URL : https://patchwork.freedesktop.org/series/109490/ State : success == Summary == CI Bug Log - changes from CI_DRM_12226 -> Patchwork_109490v1 Summar

Re: [Intel-gfx] [PATCH] drm/i915/display: Add DC5 counter and DMC debugfs entries for MTL

2022-10-07 Thread Lucas De Marchi
On Fri, Oct 07, 2022 at 12:42:03PM -0700, Anusha Srivatsa wrote: MTL and dgfx use the same DC5 counter. While at it, this patch also adds the corresponding debugfs entries. Some cleanup wrt dc3co register which makes the code more readable. Driver loads all firmware that it finds in the firmwar

[Intel-gfx] [PATCH 1/2] drm/i915: Do the DRIVER_ATOMIC feature disable later

2022-10-07 Thread Ville Syrjala
From: Ville Syrjälä Currently we do the DRIVER_ATOMIC disable as almost the first thing during pci probe. That involves the use of DISPLAY_VER() which is perhaps a bit sketchy now that we may need to read that out from the hardware itself. Looks like we do populate a default value for it anyway s

[Intel-gfx] [PATCH 2/2] drm/i915: Enable atomic by default on ctg/elk

2022-10-07 Thread Ville Syrjala
From: Ville Syrjälä The watermark code for ctg/elk has been atomic ready for a long time so let's just flip the switch now that some of the last CxSR issues have been sorted out (which granted was a problem for vlv/chv as well despite them already having atomic enabled by default). v2: Rebase S

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: remove redundant variable 'taken'

2022-10-07 Thread Patchwork
== Series Details == Series: drm/i915/perf: remove redundant variable 'taken' URL : https://patchwork.freedesktop.org/series/109491/ State : success == Summary == CI Bug Log - changes from CI_DRM_12226 -> Patchwork_109491v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Do the DRIVER_ATOMIC feature disable later

2022-10-07 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Do the DRIVER_ATOMIC feature disable later URL : https://patchwork.freedesktop.org/series/109497/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separa

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Do the DRIVER_ATOMIC feature disable later

2022-10-07 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Do the DRIVER_ATOMIC feature disable later URL : https://patchwork.freedesktop.org/series/109497/ State : success == Summary == CI Bug Log - changes from CI_DRM_12226 -> Patchwork_109497v1 ==

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Add DC5 counter and DMC debugfs entries for MTL

2022-10-07 Thread Patchwork
== Series Details == Series: drm/i915/display: Add DC5 counter and DMC debugfs entries for MTL URL : https://patchwork.freedesktop.org/series/109488/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12226_full -> Patchwork_109488v1_full ===

Re: [Intel-gfx] [PATCH v2 04/15] drm/i915/perf: Determine gen12 oa ctx offset at runtime

2022-10-07 Thread Umesh Nerlige Ramappa
On Fri, Sep 30, 2022 at 04:09:36PM -0700, Dixit, Ashutosh wrote: On Fri, 30 Sep 2022 14:42:07 -0700, Umesh Nerlige Ramappa wrote: >> +static int __set_oa_ctx_ctrl_offset(struct intel_context *ce) > > I have seen people complain about unnecessary double underscores in front > of function names ;

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: remove redundant assignments to variable ret

2022-10-07 Thread Patchwork
== Series Details == Series: drm/i915/gem: remove redundant assignments to variable ret URL : https://patchwork.freedesktop.org/series/109490/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12226_full -> Patchwork_109490v1_full ==

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/perf: remove redundant variable 'taken'

2022-10-07 Thread Patchwork
== Series Details == Series: drm/i915/perf: remove redundant variable 'taken' URL : https://patchwork.freedesktop.org/series/109491/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12226_full -> Patchwork_109491v1_full Summar

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Do the DRIVER_ATOMIC feature disable later

2022-10-07 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Do the DRIVER_ATOMIC feature disable later URL : https://patchwork.freedesktop.org/series/109497/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12226_full -> Patchwork_109497v1_full