Re: [Intel-gfx] [PATCH v7 12/15] mei: gsc: add transition to PXP mode in resume flow

2022-09-01 Thread Ceraolo Spurio, Daniele
On 8/6/2022 5:26 AM, Tomas Winkler wrote: From: Vitaly Lubart Added transition to PXP mode in resume flow. CC: Daniele Ceraolo Spurio Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin Reviewed-by: Daniele Ceraolo Spurio Daniele --- driver

Re: [Intel-gfx] [PATCH v7 13/15] mei: debugfs: add pxp mode to devstate in debugfs

2022-09-01 Thread Ceraolo Spurio, Daniele
On 8/6/2022 5:26 AM, Tomas Winkler wrote: Add pxp mode devstate to debugfs to monitor pxp state machine progress. This is useful to debug issues in scenarios in which the pxp state needs to be re-initialized, like during power transitions such as suspend/resume. With this debugfs the state cou

Re: [Intel-gfx] [PATCH v3 02/11] drm/i915: Read graphics/media/display arch version from hw

2022-09-01 Thread Sripada, Radhakrishna
Hi Jani, > -Original Message- > From: Jani Nikula > Sent: Thursday, September 1, 2022 12:58 AM > To: Sripada, Radhakrishna ; intel- > g...@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v3 02/11] drm/i915: Read > graphics/media/display > arc

Re: [Intel-gfx] [PATCH 6/8] drm/i915/xelpmp: Expose media as another GT

2022-09-01 Thread Ceraolo Spurio, Daniele
On 8/29/2022 10:02 AM, Matt Roper wrote: Xe_LPM+ platforms have "standalone media." I.e., the media unit is designed as an additional GT with its own engine list, GuC, forcewake, etc. Let's allow platforms to include media GTs in their device info. Cc: Aravind Iddamsetty Signed-off-by: Mat

Re: [Intel-gfx] [PATCH 7/8] drm/i915/mtl: Use primary GT's irq lock for media GT

2022-09-01 Thread Ceraolo Spurio, Daniele
On 8/29/2022 10:02 AM, Matt Roper wrote: When we hook up interrupts (in the next patch), interrupts for the media GT are still processed as part of the primary GT's interrupt flow. As such, we should share the same IRQ lock with the primary GT. Let's convert gt->irq_lock into a pointer and j

Re: [Intel-gfx] [PATCH 8/8] drm/i915/mtl: Hook up interrupts for standalone media

2022-09-01 Thread Ceraolo Spurio, Daniele
On 8/29/2022 10:02 AM, Matt Roper wrote: Top-level handling of standalone media interrupts will be processed as part of the primary GT's interrupt handler (since primary and media GTs share an MMIO space, unlike remote tile setups). When we get down to the point of handling engine interrupts,

[Intel-gfx] [RFC PATCH v2 2/2] Fix per client busyness locking

2022-09-01 Thread Ashutosh Dixit
1. Do all ce->stats updates and reads under guc->timestamp.lock 2. Pin context image before reading 3. Merge __guc_context_update_clks and guc_context_update_stats into a single function 4. Call lrc_update_runtime() unconditionally in guc_context_update_stats 5. Seems no need to update ce->stats

[Intel-gfx] [PATCH 1/2] i915/pmu: Wire GuC backend to per-client busyness

2022-09-01 Thread Ashutosh Dixit
From: John Harrison GuC provides engine_id and last_switch_in ticks for an active context in the pphwsp. The context image provides a 32 bit total ticks which is the accumulated by the context (a.k.a. context[CTX_TIMESTAMP]). This information is used to calculate the context busyness as follows:

Re: [Intel-gfx] [RFC PATCH 2/2] Fix per client busyness locking

2022-09-01 Thread Dixit, Ashutosh
On Wed, 31 Aug 2022 15:45:49 -0700, Umesh Nerlige Ramappa wrote: > Hi Umesh, I have updated my RFC patch based on your feedback so we can discuss again. > On Wed, Aug 31, 2022 at 12:33:55PM -0700, Ashutosh Dixit wrote: > > 1. Do all ce->stats updates and reads under guc->timestamp.lock > > Other

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] i915/pmu: Wire GuC backend to per-client busyness

2022-09-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] i915/pmu: Wire GuC backend to per-client busyness URL : https://patchwork.freedesktop.org/series/108053/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESC

[Intel-gfx] ✓ Fi.CI.IGT: success for Tidy up vfio_device life cycle (rev4)

2022-09-01 Thread Patchwork
== Series Details == Series: Tidy up vfio_device life cycle (rev4) URL : https://patchwork.freedesktop.org/series/107838/ State : success == Summary == CI Bug Log - changes from CI_DRM_12058_full -> Patchwork_107838v4_full Summary ---

[Intel-gfx] [PATCH 0/7] i915: Prep work for explicit MCR handling

2022-09-01 Thread Matt Roper
Steering of multicast/replicated registers becomes a bit more complicated on Meteor Lake. Whereas previously the control register we used to manage the steering was only used by our driver[*], software's control of steering has now been consolidated with the controls for various other hardware/fir

[Intel-gfx] [PATCH 2/7] drm/i915/xehp: Create separate reg definitions for new MCR registers

2022-09-01 Thread Matt Roper
Starting in Xe_HP, several registers our driver works with have been converted from singleton registers into replicated registers with multicast behavior. Although the registers are still located at the same MMIO offsets as on previous platforms, let's duplicate the register definitions in prepara

[Intel-gfx] [PATCH 1/7] drm/i915/gen8: Create separate reg definitions for new MCR registers

2022-09-01 Thread Matt Roper
Gen8 was the first time our hardware had multicast registers (or at least the first time the multicast nature was exposed and MMIO accesses could be steered). There are some registers that transitioned from singleton behavior to multicast during the gen7 -> gen8 transition; let's duplicate the reg

[Intel-gfx] [PATCH 3/7] drm/i915/gt: Drop a few unused register definitions

2022-09-01 Thread Matt Roper
Let's drop a few register definitions that are unused anywhere in the driver today. Since the referenced offsets are part of what is now considered a multicast register region, the current definitions would not be correct for use on any future platform. Signed-off-by: Matt Roper --- drivers/gpu

[Intel-gfx] [PATCH 7/7] drm/i915/gt: Add MCR-specific workaround initializers

2022-09-01 Thread Matt Roper
Let's be more explicit about which of our workarounds are updating MCR registers. This will also allow us to record whether a workaround register has MCR behavior or not so that we'll only need to do a steering lookup for the registers that truly need it. Signed-off-by: Matt Roper --- drivers/g

[Intel-gfx] [PATCH 5/7] drm/i915: Define MCR registers explicitly

2022-09-01 Thread Matt Roper
Rather than using the same _MMIO() macro to define MCR registers as singleton registers, let's use a new MCR_REG() macro to make it clear that these registers are special and should be handled accordingly. For now MCR_REG() will still generate an i915_reg_t with the given offset, but we'll change

[Intel-gfx] [PATCH 6/7] drm/i915/gt: Always use MCR functions on multicast registers

2022-09-01 Thread Matt Roper
Rather than relying on the implicit behavior of intel_uncore_*() functions, let's always use the intel_gt_mcr_*() functions to operate on multicast/replicated registers. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 4 +- drivers/gpu/drm/i915/gt/intel_gtt.c | 4

[Intel-gfx] [PATCH 4/7] drm/i915/gt: Correct prefix on a few registers

2022-09-01 Thread Matt Roper
We have a few registers that have existed for several hardware generations, but are only used by the driver on Xe_HP and beyond. In cases where the Xe_HP version of the register is now replicated and uses multicast behavior, but earlier generations were singleton, let's change the register prefix

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Prep work for explicit MCR handling

2022-09-01 Thread Patchwork
== Series Details == Series: i915: Prep work for explicit MCR handling URL : https://patchwork.freedesktop.org/series/108054/ State : warning == Summary == Error: dim checkpatch failed 3ce98ef46d9b drm/i915/gen8: Create separate reg definitions for new MCR registers -:266: WARNING:LONG_LINE:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Prep work for explicit MCR handling

2022-09-01 Thread Patchwork
== Series Details == Series: i915: Prep work for explicit MCR handling URL : https://patchwork.freedesktop.org/series/108054/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915: Prep work for explicit MCR handling

2022-09-01 Thread Patchwork
== Series Details == Series: i915: Prep work for explicit MCR handling URL : https://patchwork.freedesktop.org/series/108054/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12063 -> Patchwork_108054v1 Summary --- **FA

Re: [Intel-gfx] [RFC PATCH v3 10/17] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-09-01 Thread Niranjana Vishwanathapura
On Thu, Sep 01, 2022 at 08:58:57AM +0100, Tvrtko Ursulin wrote: On 01/09/2022 06:09, Niranjana Vishwanathapura wrote: On Wed, Aug 31, 2022 at 08:38:48AM +0100, Tvrtko Ursulin wrote: On 27/08/2022 20:43, Andi Shyti wrote: From: Niranjana Vishwanathapura Implement new execbuf3 ioctl (I915_G

Re: [Intel-gfx] [PATCH v3 04/17] drm/i915/dsi: Extract {vlv, bxt}_get_pclk()

2022-09-01 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Monday, June 20, 2022 8:52 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v3 04/17] drm/i915/dsi: Extract {vlv, > bxt}_get_pclk() > > From: Ville Syrjälä > > Extract the state->freq comp

[Intel-gfx] [PATCH v4 02/11] drm/i915: Read graphics/media/display arch version from hw

2022-09-01 Thread Radhakrishna Sripada
From: Matt Roper Going forward, the hardware teams no longer consider new platforms to have a "generation" in the way we've defined it for past platforms. Instead, each IP block (graphics, media, display) will have their own architecture major.minor versions and stepping ID's which should be read

[Intel-gfx] [PATCH v4 00/11] Initial Meteorlake Support

2022-09-01 Thread Radhakrishna Sripada
The PCI Id's and platform definition are posted earlier. This series adds handful of early enablement patches including support for display power wells, VBT and AUX Channel mapping, PCH and gmbus support, dbus, mbus, sagv and memory bandwidth support. This series also add the support for a new way

[Intel-gfx] [PATCH v4 03/11] drm/i915: Parse and set stepping for platforms with GMD

2022-09-01 Thread Radhakrishna Sripada
From: José Roberto de Souza The GMD step field do not properly match the current stepping convention that we use(STEP_A0, STEP_A1, STEP_B0...). One platform could have { arch = 12, rel = 70, step = 1 } and the actual stepping is STEP_B0 but without the translation of the step field would mean ST

[Intel-gfx] [PATCH v4 05/11] drm/i915/mtl: Add gmbus and gpio support

2022-09-01 Thread Radhakrishna Sripada
Add tables to map the GMBUS pin pairs to GPIO registers and port to DDC. >From spec we have registers GPIO_CTL[1-5] mapped to native display phys and GPIO_CTL[9-12] are mapped to TC ports. v2: - Drop unused GPIO pins(MattR) BSpec: 49306 Cc: Matt Roper Original Author: Brian J Lovin Signed-off-

[Intel-gfx] [PATCH v4 01/11] drm/i915: Move display and media IP version to runtime info

2022-09-01 Thread Radhakrishna Sripada
Future platforms can read the IP version from a register and the IP version numbers need not be hard coded in device info. Move the ip version for media and display to runtime info. On platforms where hard coding of IP version is required, update the IP version in __runtime under device_info. v2:

[Intel-gfx] [PATCH v4 11/11] drm/i915/mtl: Do not update GV point, mask value

2022-09-01 Thread Radhakrishna Sripada
Display 14 and future platforms do not directly communicate to Pcode via mailbox the SAGV bandwidth information. PM Demand registers are used to communicate display power requirements to the PUnit which would include GV point and mask value. Skip programming GV point and mask values through legacy

[Intel-gfx] [PATCH v4 04/11] drm/i915/mtl: Define engine context layouts

2022-09-01 Thread Radhakrishna Sripada
From: Matt Roper The part of the media and blitter engine contexts that we care about for setting up an initial state are the same on MTL as they were on DG2 (and PVC), so we need to update the driver conditions to re-use the DG2 context table. For render/compute engines, the part of the context

[Intel-gfx] [PATCH v4 06/11] drm/i915/mtl: Add display power wells

2022-09-01 Thread Radhakrishna Sripada
From: Imre Deak Add support for display power wells on MTL. The differences from XE_LPD: - The AUX HW block is moved to the PICA block, where the registers are on an always-on power well and the functionality needs to be powered on/off via the AUX_CH_CTL register: [1], [2] - The DDI IO power

[Intel-gfx] [PATCH v4 09/11] drm/i915/mtl: Update MBUS_DBOX credits

2022-09-01 Thread Radhakrishna Sripada
Display version 14 platforms have different credits values compared to ADL-P. Update the credits based on pipe usage. v2: Simplify DBOX BW Credit definition(MattR) Bspec: 49213 Cc: Jose Roberto de Souza Cc: Matt Roper Original Author: Caz Yokoyama Signed-off-by: José Roberto de Souza Signed-o

[Intel-gfx] [PATCH v4 10/11] drm/i915/mtl: Update CHICKEN_TRANS* register addresses

2022-09-01 Thread Radhakrishna Sripada
From: Madhumitha Tolakanahalli Pradeep In Display version 14, Transcoder Chicken Registers have updated address. This patch performs checks to use the right register when required. v2: Omit display version check in i915_reg.h(Jani) Bspec: 34387, 50054 Cc: Jani Nikula Signed-off-by: Madhumitha

[Intel-gfx] [PATCH v4 08/11] drm/i915/mtl: Obtain SAGV values from MMIO instead of GT pcode mailbox

2022-09-01 Thread Radhakrishna Sripada
>From Meteorlake, Latency Level, SAGV bloack time are read from LATENCY_SAGV register instead of the GT driver pcode mailbox. DDR type and QGV information are also to be read from Mem SS registers. v2: - Simplify MTL_MEM_SS_INFO_QGV_POINT macro(MattR) - Nit: Rearrange the bit def's from higher t

[Intel-gfx] [PATCH v4 07/11] drm/i915/mtl: Add DP AUX support on TypeC ports

2022-09-01 Thread Radhakrishna Sripada
From: Imre Deak On MTL TypeC ports the AUX_CH_CTL and AUX_CH_DATA addresses have changed wrt. previous platforms, adjust the code accordingly. Signed-off-by: Imre Deak Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 45 - drivers/gpu/d

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Initial Meteorlake Support (rev5)

2022-09-01 Thread Patchwork
== Series Details == Series: Initial Meteorlake Support (rev5) URL : https://patchwork.freedesktop.org/series/106786/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/comp

[Intel-gfx] ✓ Fi.CI.IGT: success for Add DP MST DSC support to i915 (rev11)

2022-09-01 Thread Patchwork
== Series Details == Series: Add DP MST DSC support to i915 (rev11) URL : https://patchwork.freedesktop.org/series/101492/ State : success == Summary == CI Bug Log - changes from CI_DRM_12058_full -> Patchwork_101492v11_full Summary ---

<    1   2