[Intel-gfx] [PATCH v2 00/15] Tidy up vfio_device life cycle

2022-09-01 Thread Kevin Tian
The idea is to let vfio core manage the vfio_device life cycle instead of duplicating the logic cross drivers. Besides cleaner code in driver side this also allows adding struct device to vfio_device as the first step toward adding cdev uAPI in the future. Another benefit is that user can now look

[Intel-gfx] [PATCH v2 01/15] vfio: Add helpers for unifying vfio_device life cycle

2022-09-01 Thread Kevin Tian
The idea is to let vfio core manage the vfio_device life cycle instead of duplicating the logic cross drivers. This is also a preparatory step for adding struct device into vfio_device. New pair of helpers together with a kref in vfio_device: - vfio_alloc_device() - vfio_put_device() Drivers c

[Intel-gfx] [PATCH v2 02/15] vfio/pci: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu Also introduce two pci core helpers as @init/@release for pci drivers: - vfio_pci_core_init_dev() - vfio_pci_core_release_dev() Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/pci/vfio_pci.c | 20 +- drivers/v

[Intel-gfx] [PATCH v2 03/15] vfio/mlx5: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu mlx5 has its own @init/@release for handling migration cap. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/pci/mlx5/main.c | 49 ++-- 1 file changed, 36 insertions(+), 13 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH v2 04/15] vfio/hisi_acc: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu Tidy up @probe so all migration specific initialization logic is moved to migration specific @init callback. Remove vfio_pci_core_{un}init_device() given no user now. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe Reviewed-by: Shameer Kolothum ---

[Intel-gfx] [PATCH v2 05/15] vfio/mdpy: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu and manage mdpy_count inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- samples/vfio-mdev/mdpy.c | 81 +++- 1 file changed, 47 insertions(+), 34 deletions(-) diff --git a/samples/vfio-mdev

[Intel-gfx] [PATCH v2 06/15] vfio/mtty: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu and manage available ports inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- samples/vfio-mdev/mtty.c | 67 +++- 1 file changed, 39 insertions(+), 28 deletions(-) diff --git a/samples/vfio

[Intel-gfx] [PATCH v2 07/15] vfio/mbochs: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu and manage avail_mbytes inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- samples/vfio-mdev/mbochs.c | 73 -- 1 file changed, 46 insertions(+), 27 deletions(-) diff --git a/samples/vfio-md

[Intel-gfx] [PATCH v2 08/15] drm/i915/gvt: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
Move vfio_device to the start of intel_vgpu as required by the new helpers. Change intel_gvt_create_vgpu() to use intel_vgpu as the first param as other vgpu helpers do. Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/gpu/drm/i915/gvt/gvt.h | 5 ++- drivers/gpu/drm/i915/g

[Intel-gfx] [PATCH v2 09/15] vfio/ap: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu and manage available_instances inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Tony Krowiak Reviewed-by: Jason Gunthorpe --- drivers/s390/crypto/vfio_ap_ops.c | 50 ++- 1 file changed, 29 insertions(+), 21 deletion

[Intel-gfx] [PATCH v2 10/15] vfio/fsl-mc: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
From: Yi Liu Also add a comment to mark that vfio core releases device_set if @init fails. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/fsl-mc/vfio_fsl_mc.c | 85 ++- 1 file changed, 49 insertions(+), 36 deletions(-

[Intel-gfx] [PATCH v2 12/15] vfio/amba: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
Implement amba's own vfio_device_ops. Remove vfio_platform_probe/remove_common() given no user now. Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/platform/vfio_amba.c | 72 ++- drivers/vfio/platform/vfio_platform_common.c | 60

[Intel-gfx] [PATCH v2 11/15] vfio/platform: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
Move vfio_device_ops from platform core to platform drivers so device specific init/cleanup can be added. Introduce two new helpers vfio_platform_init/release_common() for the use in driver @init/@release. vfio_platform_probe/remove_common() will be deprecated. Signed-off-by: Kevin Tian Reviewe

[Intel-gfx] [PATCH v2 13/15] vfio/ccw: Use the new device life cycle helpers

2022-09-01 Thread Kevin Tian
ccw is the only exception which cannot use vfio_alloc_device() because its private device structure is designed to serve both mdev and parent. Life cycle of the parent is managed by css_driver so vfio_ccw_private must be allocated/freed in css_driver probe/remove path instead of conforming to vfio

[Intel-gfx] [PATCH v2 14/15] vfio: Rename vfio_device_put() and vfio_device_try_get()

2022-09-01 Thread Kevin Tian
With the addition of vfio_put_device() now the names become confusing. vfio_put_device() is clear from object life cycle p.o.v given kref. vfio_device_put()/vfio_device_try_get() are helpers for tracking users on a registered device. Now rename them: - vfio_device_put() -> vfio_device_put_regi

[Intel-gfx] [PATCH v2 15/15] vfio: Add struct device to vfio_device

2022-09-01 Thread Kevin Tian
From: Yi Liu and replace kref. With it a 'vfio-dev/vfioX' node is created under the sysfs path of the parent, indicating the device is bound to a vfio driver, e.g.: /sys/devices/pci\:6f/\:6f\:01.0/vfio-dev/vfio0 It is also a preparatory step toward adding cdev for supporting future devi

Re: [Intel-gfx] [PATCH v2 12/15] vfio/amba: Use the new device life cycle helpers

2022-09-01 Thread Tian, Kevin
> From: Tian, Kevin > Sent: Thursday, September 1, 2022 10:38 PM > > +static const struct vfio_device_ops vfio_amba_ops= { Above missed a space after vfio_amba_ops.

Re: [Intel-gfx] [PATCH v2 15/15] vfio: Add struct device to vfio_device

2022-09-01 Thread Tian, Kevin
> From: Tian, Kevin > Sent: Thursday, September 1, 2022 10:38 PM > > diff --git a/Documentation/ABI/testing/sysfs-devices-vfio-dev > b/Documentation/ABI/testing/sysfs-devices-vfio-dev > new file mode 100644 > index ..e21424fd9666 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs

Re: [Intel-gfx] [PATCH v3 01/11] drm/i915: Move display and media IP version to runtime info

2022-09-01 Thread Jani Nikula
On Wed, 31 Aug 2022, Radhakrishna Sripada wrote: > Future platforms can read the IP version from a register and the > IP version numbers need not be hard coded in device info. Move the > ip version for media and display to runtime info. > > On platforms where hard coding of IP version is required

Re: [Intel-gfx] [PATCH v3 02/11] drm/i915: Read graphics/media/display arch version from hw

2022-09-01 Thread Jani Nikula
On Wed, 31 Aug 2022, Radhakrishna Sripada wrote: > From: Matt Roper > > Going forward, the hardware teams no longer consider new platforms to > have a "generation" in the way we've defined it for past platforms. > Instead, each IP block (graphics, media, display) will have their own > architectu

Re: [Intel-gfx] [RFC PATCH v3 10/17] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-09-01 Thread Tvrtko Ursulin
On 01/09/2022 06:09, Niranjana Vishwanathapura wrote: On Wed, Aug 31, 2022 at 08:38:48AM +0100, Tvrtko Ursulin wrote: On 27/08/2022 20:43, Andi Shyti wrote: From: Niranjana Vishwanathapura Implement new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mo

Re: [Intel-gfx] [PATCH 1/1] drm/i915/display: convert dsc debugfs entry from output_bpp to input_bpc

2022-09-01 Thread Jani Nikula
On Wed, 31 Aug 2022, Swati Sharma wrote: > With this patch, converting DSC debugfs entry from output_bpp to input_bpc. Please drop phrases like "With this patch", and just use imperative mood, "Convert DSC debugfs ...". Once it's committed and you look at git log, it's no longer a patch. The sub

Re: [Intel-gfx] [PATCH v3 15/17] drm/i915: Allow M/N change during fastset on bdw+

2022-09-01 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Monday, June 20, 2022 8:52 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v3 15/17] drm/i915: Allow M/N change during > fastset on bdw+ > > From: Ville Syrjälä > > On BDW+ M/N are double

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Tidy up vfio_device life cycle (rev4)

2022-09-01 Thread Patchwork
== Series Details == Series: Tidy up vfio_device life cycle (rev4) URL : https://patchwork.freedesktop.org/series/107838/ State : warning == Summary == Error: dim checkpatch failed 69f04751cb9f vfio: Add helpers for unifying vfio_device life cycle -:191: CHECK:MACRO_ARG_REUSE: Macro argument r

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Tidy up vfio_device life cycle (rev4)

2022-09-01 Thread Patchwork
== Series Details == Series: Tidy up vfio_device life cycle (rev4) URL : https://patchwork.freedesktop.org/series/107838/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./arch/x86/include/asm/bitops.h:11

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/3] drm/i915: audit bo->resource usage (rev2)

2022-09-01 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: audit bo->resource usage (rev2) URL : https://patchwork.freedesktop.org/series/107680/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/107680/revisions/2/mbox/ not applied Applying:

[Intel-gfx] ✓ Fi.CI.BAT: success for Tidy up vfio_device life cycle (rev4)

2022-09-01 Thread Patchwork
== Series Details == Series: Tidy up vfio_device life cycle (rev4) URL : https://patchwork.freedesktop.org/series/107838/ State : success == Summary == CI Bug Log - changes from CI_DRM_12058 -> Patchwork_107838v4 Summary --- **SUCCES

Re: [Intel-gfx] [PATCH v3 01/11] drm/i915: Move display and media IP version to runtime info

2022-09-01 Thread Michal Wajdeczko
On 01.09.2022 09:45, Jani Nikula wrote: > On Wed, 31 Aug 2022, Radhakrishna Sripada > wrote: ... >> struct ip_version graphics; >> +struct ip_version media; >> +struct ip_version display; > > The runtime display info is now in an unnamed struct under struct > intel_runtime_info

Re: [Intel-gfx] [PATCH 01/12] drm/i915: Unify VBT version number comments

2022-09-01 Thread Ville Syrjälä
On Tue, Jul 19, 2022 at 06:25:20AM -0400, Rodrigo Vivi wrote: > On Fri, Jul 15, 2022 at 11:20:33PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Use a more standard form for the VT version number comments. > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/drm/i915/disp

Re: [Intel-gfx] [PATCH 11/12] drm/i915: WARN if a port should use VBT provided vswing tables

2022-09-01 Thread Ville Syrjälä
On Tue, Jul 19, 2022 at 06:31:11AM -0400, Rodrigo Vivi wrote: > On Fri, Jul 15, 2022 at 11:20:43PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We don't parse the VBT vswing/preemphassis tables at all currently. > > Let's WARN if a port wants to use them so we get a heads up that >

Re: [Intel-gfx] [PATCH 12/12] drm/i915: Parse DP/eDP max lane count from VBT

2022-09-01 Thread Ville Syrjälä
On Tue, Jul 19, 2022 at 06:39:29AM -0400, Rodrigo Vivi wrote: > On Fri, Jul 15, 2022 at 11:20:44PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Limit the DP lane count based on the new VBT DP/eDP max > > lane count field. > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/

Re: [Intel-gfx] [PATCH v3 01/11] drm/i915: Move display and media IP version to runtime info

2022-09-01 Thread Jani Nikula
On Thu, 01 Sep 2022, Michal Wajdeczko wrote: > On 01.09.2022 09:45, Jani Nikula wrote: >> On Wed, 31 Aug 2022, Radhakrishna Sripada >> wrote: > > ... > >>> struct ip_version graphics; >>> + struct ip_version media; >>> + struct ip_version display; >> >> The runtime display info is now i

[Intel-gfx] [PATCH 0/4] Add DP MST DSC support to i915

2022-09-01 Thread Stanislav Lisovskiy
Currently we have only DSC support for DP SST. Stanislav Lisovskiy (4): drm: Add missing DP DSC extended capability definitions. drm/i915: Fix intel_dp_mst_compute_link_config drm/i915: Extract drm_dp_atomic_find_vcpi_slots cycle to separate function drm/i915: Add DSC support to MST pa

[Intel-gfx] [PATCH 1/4] drm: Add missing DP DSC extended capability definitions.

2022-09-01 Thread Stanislav Lisovskiy
Adding DP DSC register definitions, we might need for further DSC implementation, supporting MST and DP branch pass-through mode. v2: - Fixed checkpatch comment warning v3: - Removed function which is not yet used(Jani Nikula) Reviewed-by: Vinod Govindapillai Signed-off-by: Stanislav Lisovskiy

[Intel-gfx] [PATCH 2/4] drm/i915: Fix intel_dp_mst_compute_link_config

2022-09-01 Thread Stanislav Lisovskiy
We currently always exit that bpp loop because drm_dp_atomic_find_vcpi_slots doesn't care if we actually can fit those or not. I think that wasn't the initial intention here, especially when we keep trying with lower bpps, we are supposed to keep trying until we actually find some _working_ configu

[Intel-gfx] [PATCH 3/4] drm/i915: Extract drm_dp_atomic_find_vcpi_slots cycle to separate function

2022-09-01 Thread Stanislav Lisovskiy
We would be using almost same code to loop through bpps while calling drm_dp_atomic_find_vcpi_slots - lets remove this duplication by introducing a new function intel_dp_mst_find_vcpi_slots_for_bpp v2: Fix pbn_div calculation - shouldn't matter if its DSC or not. Signed-off-by: Stanislav Lisovski

[Intel-gfx] [PATCH 4/4] drm/i915: Add DSC support to MST path

2022-09-01 Thread Stanislav Lisovskiy
Whenever we are not able to get enough timeslots for required PBN, let's try to allocate those using DSC, just same way as we do for SST. v2: Removed intel_dp_mst_dsc_compute_config and refactored intel_dp_dsc_compute_config to support timeslots as a parameter(Ville Syrjälä) v3: - Rebased

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add DP MST DSC support to i915 (rev11)

2022-09-01 Thread Patchwork
== Series Details == Series: Add DP MST DSC support to i915 (rev11) URL : https://patchwork.freedesktop.org/series/101492/ State : warning == Summary == Error: dim checkpatch failed f0211d697f3c drm: Add missing DP DSC extended capability definitions. 2ac1d5da72af drm/i915: Fix intel_dp_mst_co

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add DP MST DSC support to i915 (rev11)

2022-09-01 Thread Patchwork
== Series Details == Series: Add DP MST DSC support to i915 (rev11) URL : https://patchwork.freedesktop.org/series/101492/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117

[Intel-gfx] ✓ Fi.CI.BAT: success for Add DP MST DSC support to i915 (rev11)

2022-09-01 Thread Patchwork
== Series Details == Series: Add DP MST DSC support to i915 (rev11) URL : https://patchwork.freedesktop.org/series/101492/ State : success == Summary == CI Bug Log - changes from CI_DRM_12058 -> Patchwork_101492v11 Summary --- **SUCC

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix warning callstack for imbalance wakeref (rev7)

2022-09-01 Thread Imre Deak
On Wed, Aug 31, 2022 at 03:02:10PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/display: Fix warning callstack for imbalance wakeref (rev7) > URL : https://patchwork.freedesktop.org/series/107211/ > State : success Thanks for the patch, pushed to drm-intel-next. > > ==

[Intel-gfx] ✓ Fi.CI.IGT: success for Modify debugfs entry from dsc compressed bpp to input bpc

2022-09-01 Thread Patchwork
== Series Details == Series: Modify debugfs entry from dsc compressed bpp to input bpc URL : https://patchwork.freedesktop.org/series/107972/ State : success == Summary == CI Bug Log - changes from CI_DRM_12057_full -> Patchwork_107972v1_full ===

[Intel-gfx] [PATCH] drm/i915: Start using REG_BIT* macros

2022-09-01 Thread Stanislav Lisovskiy
Lets start to use REG_BIT* macros, instead of (x << 0) like expressions. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/i915_reg.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_r

Re: [Intel-gfx] [PATCH] drm/i915: Start using REG_BIT* macros

2022-09-01 Thread Jani Nikula
On Thu, 01 Sep 2022, Stanislav Lisovskiy wrote: > Lets start to use REG_BIT* macros, instead of (x << 0) like expressions. Please be more specific in the commit subject, it's not like we haven't started using REG_BIT in general, ever since we introduced it! ;) So refer to CDCLK_CTL. Please just

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ttm: Abort suspend on i915_ttm_backup failure (rev2)

2022-09-01 Thread Patchwork
== Series Details == Series: drm/i915/ttm: Abort suspend on i915_ttm_backup failure (rev2) URL : https://patchwork.freedesktop.org/series/107877/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12057_full -> Patchwork_107877v2_full ===

[Intel-gfx] [PATCH 0/9] drm: convert to using is_hdmi and has_audio from display info

2022-09-01 Thread Jani Nikula
The low-hanging fruit of the drm todo item "Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi", with has_audio changes on top. I'm afraid not all of these have been even build tested, let alone actually tested. BR, Jani. Cc: Laurent Pinchart Cc: Sandy Huang Cc: Heiko Stübner

[Intel-gfx] [PATCH 1/9] drm/edid: parse display info has_audio similar to is_hdmi

2022-09-01 Thread Jani Nikula
Since we already iterate everything that's needed for determining audio, reduce the need to call drm_detect_monitor_audio() by storing has_audio to connector info. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 6 ++ include/drm/drm_connector.h | 8 2 files changed, 14

[Intel-gfx] [PATCH 2/9] drm/nouveau: convert to using is_hdmi and has_audio from display info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for is_hdmi and has_audio in display info over calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(), respectively. Cc: Ben Skeggs Cc: Karol Herbst Cc: Lyude Paul Cc: nouv...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/nouveau/disp

[Intel-gfx] [PATCH 3/9] drm/radeon: convert to using is_hdmi and has_audio from display info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for is_hdmi and has_audio in display info over calling drm_detect_hdmi_monitor() and drm_detect_monitor_audio(), respectively. Cc: Alex Deucher Cc: Christian König Cc: "Pan, Xinhui" Cc: amd-...@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/rade

[Intel-gfx] [PATCH 4/9] drm/tegra: convert to using is_hdmi from display info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for is_hdmi in display info over calling drm_detect_hdmi_monitor(). Cc: Thierry Reding Cc: linux-te...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/tegra/hdmi.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/dr

[Intel-gfx] [PATCH 5/9] drm/exynos: convert to using is_hdmi from display info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for is_hdmi in display info over calling drm_detect_hdmi_monitor(). Cc: Inki Dae Cc: Seung-Woo Kim Cc: Kyungmin Park Signed-off-by: Jani Nikula --- drivers/gpu/drm/exynos/exynos_hdmi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/g

[Intel-gfx] [PATCH 6/9] drm/i2c/tda998x: convert to using has_audio from display_info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for has_audio in display info over calling drm_detect_monitor_audio(). Cc: Russell King Signed-off-by: Jani Nikula --- drivers/gpu/drm/i2c/tda998x_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu

[Intel-gfx] [PATCH 7/9] drm/sti/sti_hdmi: convert to using is_hdmi from display info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for is_hdmi in display info over calling drm_detect_hdmi_monitor(). Remove the now redundant hdmi_monitor member from struct sti_hdmi. Cc: Alain Volmat Signed-off-by: Jani Nikula --- drivers/gpu/drm/sti/sti_hdmi.c | 11 ++- drivers/gpu/drm/sti/sti_hdmi.h | 2 -

[Intel-gfx] [PATCH 8/9] drm/rockchip: cdn-dp: call drm_connector_update_edid_property() unconditionally

2022-09-01 Thread Jani Nikula
Calling drm_connector_update_edid_property() should be done unconditionally instead of depending on the number of modes added. Also match the call order in inno_hdmi and rk3066_hdmi. Cc: Sandy Huang Cc: Heiko Stübner Signed-off-by: Jani Nikula --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 5 ++-

[Intel-gfx] [PATCH 9/9] drm/rockchip: convert to using has_audio from display_info

2022-09-01 Thread Jani Nikula
Prefer the parsed results for has_audio in display info over calling drm_detect_monitor_audio(). Cc: Sandy Huang Cc: Heiko Stübner Signed-off-by: Jani Nikula --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 ++-- drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++- 2 files changed, 4 insertions(+), 3

Re: [Intel-gfx] [PATCH 1/3] drm/i915: audit bo->resource usage

2022-09-01 Thread Matthew Auld
On 01/09/2022 09:00, Christian König wrote: Am 31.08.22 um 18:32 schrieb Matthew Auld: On 31/08/2022 15:53, Matthew Auld wrote: On 31/08/2022 14:34, Christian König wrote: Am 31.08.22 um 14:50 schrieb Matthew Auld: On 31/08/2022 13:35, Christian König wrote: Am 31.08.22 um 14:06 schrieb Matt

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Start using REG_BIT* macros

2022-09-01 Thread Patchwork
== Series Details == Series: drm/i915: Start using REG_BIT* macros URL : https://patchwork.freedesktop.org/series/108021/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Start using REG_BIT* macros

2022-09-01 Thread Patchwork
== Series Details == Series: drm/i915: Start using REG_BIT* macros URL : https://patchwork.freedesktop.org/series/108021/ State : success == Summary == CI Bug Log - changes from CI_DRM_12061 -> Patchwork_108021v1 Summary --- **SUCCES

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: convert to using is_hdmi and has_audio from display info

2022-09-01 Thread Patchwork
== Series Details == Series: drm: convert to using is_hdmi and has_audio from display info URL : https://patchwork.freedesktop.org/series/108024/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PULL] drm-intel-fixes

2022-09-01 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2022-09-01: - GVT fixes including fix for a CommetLake regression in mmio table and misc doc and typo fixes (Julia, Jiapeng, Colin, Alex) - Fix CCS handling (Matt) - Fix for guc requests after reset (Daniele) - Display DSI related fixes (Jani) - Dis

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: convert to using is_hdmi and has_audio from display info

2022-09-01 Thread Patchwork
== Series Details == Series: drm: convert to using is_hdmi and has_audio from display info URL : https://patchwork.freedesktop.org/series/108024/ State : success == Summary == CI Bug Log - changes from CI_DRM_12061 -> Patchwork_108024v1 Sum

Re: [Intel-gfx] [PATCH v4 06/21] drm/i915: Prepare to dynamic dma-buf locking specification

2022-09-01 Thread Ruhl, Michael J
>-Original Message- >From: Dmitry Osipenko >Sent: Wednesday, August 31, 2022 11:38 AM >To: David Airlie ; Gerd Hoffmann ; >Gurchetan Singh ; Chia-I Wu >; Daniel Vetter ; Daniel Almeida >; Gert Wollny ; >Gustavo Padovan ; Daniel Stone >; Tomeu Vizoso ; >Maarten Lankhorst ; Maxime Ripard >;

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ttm: Abort suspend on i915_ttm_backup failure (rev2)

2022-09-01 Thread Das, Nirmoy
On 9/1/2022 2:29 PM, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* drm/i915/ttm: Abort suspend on i915_ttm_backup failure (rev2) *URL:* https://patchwork.freedesktop.org/series/107877/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patch

Re: [Intel-gfx] [PATCH v3 02/15] mei: add support to GSC extended header

2022-09-01 Thread Greg Kroah-Hartman
On Fri, Aug 19, 2022 at 03:53:22PM -0700, Daniele Ceraolo Spurio wrote: > --- a/drivers/misc/mei/hw-me.c > +++ b/drivers/misc/mei/hw-me.c > @@ -590,7 +590,10 @@ static int mei_me_hbuf_write(struct mei_device *dev, > u32 dw_cnt; > int empty_slots; > > - if (WARN_ON(!hdr || !data ||

Re: [Intel-gfx] [PATCH v7 10/15] mei: mkhi: add memory ready command

2022-09-01 Thread Greg Kroah-Hartman
On Sat, Aug 06, 2022 at 03:26:31PM +0300, Tomas Winkler wrote: > Add GSC memory ready command. > The command indicates to the firmware that extend operation > memory was setup and the firmware may enter PXP mode. > > CC: Daniele Ceraolo Spurio > Signed-off-by: Tomas Winkler > Signed-off-by: Alex

Re: [Intel-gfx] [PATCH v7 00/15] GSC support for XeHP SDV and DG2

2022-09-01 Thread Greg Kroah-Hartman
On Sat, Aug 06, 2022 at 03:26:21PM +0300, Tomas Winkler wrote: > Add GSC support for XeHP SDV and DG2 platforms. > > The series includes changes for the mei driver: > - add ability to use polling instead of interrupts > - add ability to use extended timeouts > - setup extended operational memory f

Re: [Intel-gfx] [PATCH v7 02/15] mei: add kdoc for struct mei_aux_device

2022-09-01 Thread Ceraolo Spurio, Daniele
On 8/6/2022 5:26 AM, Tomas Winkler wrote: struct mei_aux_device is an interface structure requires proper documenation. Signed-off-by: Tomas Winkler Reviewed-by: Daniele Ceraolo Spurio Daniele --- include/linux/mei_aux.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/incl

Re: [Intel-gfx] [PATCH v7 05/15] drm/i915/gsc: add GSC XeHP SDV platform definition

2022-09-01 Thread Ceraolo Spurio, Daniele
On 8/6/2022 5:26 AM, Tomas Winkler wrote: From: Alexander Usyskin Define GSC on XeHP SDV (Intel(R) dGPU without display) XeHP SDV uses the same hardware settings as DG1, but uses polling instead of interrupts and runs the firmware in slow pace due to hardware limitations. Signed-off-by: Vi

[Intel-gfx] [PATCH] drm/i915: prevent integer overflow in query_engine_info()

2022-09-01 Thread Dan Carpenter
This code uses struct_size() but it stores the result in an int so the integer overflow checks are not effective. Record the types as size_t to prevent the size from being truncated. Fixes: bf3c50837506 ("drm/i915/query: Use struct_size() helper") Signed-off-by: Dan Carpenter --- I do not know i

Re: [Intel-gfx] [PATCH] Revert "drm/i915/guc: Add delay to disable scheduling after pin count goes to zero"

2022-09-01 Thread Teres Alexis, Alan Previn
I think i found the problem - will trybot next before reposting a new rev. was a terribly careless typo when rebasing from internal for drmtip: guc_context_sched_disable called do_sched_disable which was supposed to call __guc_context_sched_disable (if the context was really meant to be finally d

Re: [Intel-gfx] [PATCH] drm/i915/ttm: Abort suspend on i915_ttm_backup failure

2022-09-01 Thread Andrzej Hajda
On 31.08.2022 18:18, Nirmoy Das wrote: On system suspend when system memory is low then i915_gem_obj_copy_ttm() could fail trying to backup a lmem obj. GEM_WARN_ON() is not enough, suspend shouldn't continue if i915_ttm_backup() throws an error. References: https://gitlab.freedesktop.org/drm/int

Re: [Intel-gfx] [PATCH v7 06/15] mei: gsc: use polling instead of interrupts

2022-09-01 Thread Ceraolo Spurio, Daniele
On 8/6/2022 5:26 AM, Tomas Winkler wrote: A work-around for a HW issue in XEHPSDV that manifests itself when SW reads a gsc register when gsc is sending an interrupt. The work-around is to disable interrupts and to use polling instead. Cc: James Ausmus Signed-off-by: Vitaly Lubart Signed-of

Re: [Intel-gfx] [PATCH v7 07/15] mei: gsc: wait for reset thread on stop

2022-09-01 Thread Ceraolo Spurio, Daniele
On 8/6/2022 5:26 AM, Tomas Winkler wrote: From: Alexander Usyskin Wait for reset work to complete before initiating stop reset flow sequence. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Reviewed-by: Daniele Ceraolo Spurio Daniele --- drivers/misc/mei/init.c | 2 +

[Intel-gfx] [PATCH] drm/i915/dp_mst: Fix mst_mgr lookup during atomic check

2022-09-01 Thread Imre Deak
If an MST connector was disabled in the old state during a commit, the connector's best_encoder will be NULL, so we can't look up mst_mgr via it. Do the lookup instead via intel_connector->mst_port which always points to the primary encoder. This fixes the following: [ 58.922866] BUG: kernel NUL

Re: [Intel-gfx] [PATCH v7 14/15] drm/i915/gsc: allocate extended operational memory in LMEM

2022-09-01 Thread Teres Alexis, Alan Previn
This patch hasnt changed since v5 and i already provided the R-b then so re-posting rb so patchworks can pick it up: Reviewed-by: Alan Previn On Sat, 2022-08-06 at 15:26 +0300, Winkler, Tomas wrote: > GSC requires more operational memory than available on chip. > Reserve 4M of LMEM for GSC ope

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: prevent integer overflow in query_engine_info()

2022-09-01 Thread Patchwork
== Series Details == Series: drm/i915: prevent integer overflow in query_engine_info() URL : https://patchwork.freedesktop.org/series/108038/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12061 -> Patchwork_108038v1 Summary

Re: [Intel-gfx] [PATCH] drm/i915/slpc: Let's fix the PCODE min freq table setup for SLPC

2022-09-01 Thread Rodrigo Vivi
On Wed, Aug 31, 2022 at 03:17:26PM -0700, Dixit, Ashutosh wrote: > On Wed, 31 Aug 2022 14:45:38 -0700, Rodrigo Vivi wrote: > > > > Hi Rodrigo, > > > We need to inform PCODE of a desired ring frequencies so PCODE update > > the memory frequencies to us. rps->min_freq and rps->max_freq are the > >

Re: [Intel-gfx] [PATCH v7 08/15] mei: extend timeouts on slow devices.

2022-09-01 Thread Ceraolo Spurio, Daniele
@@ -990,7 +991,6 @@ static int mei_me_d0i3_enter(struct mei_device *dev) static int mei_me_d0i3_exit_sync(struct mei_device *dev) { struct mei_me_hw *hw = to_me_hw(dev); - unsigned long timeout = mei_secs_to_jiffies(MEI_D0I3_TIMEOUT); int ret; u32 reg; @@ -1

Re: [Intel-gfx] [PATCH] drm/i915: prevent integer overflow in query_engine_info()

2022-09-01 Thread Andrzej Hajda
On 01.09.2022 17:38, Dan Carpenter wrote: This code uses struct_size() but it stores the result in an int so the integer overflow checks are not effective. Record the types as size_t to prevent the size from being truncated. Fixes: bf3c50837506 ("drm/i915/query: Use struct_size() helper") Signe

[Intel-gfx] [PATCH v3] drm/i915/ttm: Abort suspend on i915_ttm_backup failure

2022-09-01 Thread Nirmoy Das
On system suspend when system memory is low then i915_gem_obj_copy_ttm() could fail trying to backup a lmem obj. GEM_WARN_ON() is not enough, suspend shouldn't continue if i915_ttm_backup() throws an error. v2: Keep the fdo issue till we have a igt test(Matt). v3: Use %pe(Andrzej) References: htt

Re: [Intel-gfx] [PATCH] drm/i915/ttm: Abort suspend on i915_ttm_backup failure

2022-09-01 Thread Das, Nirmoy
On 9/1/2022 5:57 PM, Andrzej Hajda wrote: On 31.08.2022 18:18, Nirmoy Das wrote: On system suspend when system memory is low then i915_gem_obj_copy_ttm() could fail trying to backup a lmem obj. GEM_WARN_ON() is not enough, suspend shouldn't continue if i915_ttm_backup() throws an error. Refer

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp_mst: Fix mst_mgr lookup during atomic check

2022-09-01 Thread Patchwork
== Series Details == Series: drm/i915/dp_mst: Fix mst_mgr lookup during atomic check URL : https://patchwork.freedesktop.org/series/108040/ State : success == Summary == CI Bug Log - changes from CI_DRM_12061 -> Patchwork_108040v1 Summary -

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/slpc: Set rps' min and max frequencies even with SLPC. (rev7)

2022-09-01 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Set rps' min and max frequencies even with SLPC. (rev7) URL : https://patchwork.freedesktop.org/series/107766/ State : success == Summary == CI Bug Log - changes from CI_DRM_12058_full -> Patchwork_107766v7_full ==

Re: [Intel-gfx] [PATCH 1/3] drm/i915: audit bo->resource usage

2022-09-01 Thread Thomas Hellström
On Wed, 2022-08-31 at 15:34 +0200, Christian König wrote: > Am 31.08.22 um 14:50 schrieb Matthew Auld: > > On 31/08/2022 13:35, Christian König wrote: > > > Am 31.08.22 um 14:06 schrieb Matthew Auld: > > > > On 31/08/2022 12:03, Christian König wrote: > > > > > Am 31.08.22 um 12:37 schrieb Matthew

Re: [Intel-gfx] [PATCH] drm/i915/dp_mst: Fix mst_mgr lookup during atomic check

2022-09-01 Thread Lyude Paul
Reviewed-by: Lyude Paul Thanks for catching this! On Thu, 2022-09-01 at 19:19 +0300, Imre Deak wrote: > If an MST connector was disabled in the old state during a commit, the > connector's best_encoder will be NULL, so we can't look up mst_mgr via > it. Do the lookup instead via intel_connector-

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ttm: Abort suspend on i915_ttm_backup failure (rev3)

2022-09-01 Thread Patchwork
== Series Details == Series: drm/i915/ttm: Abort suspend on i915_ttm_backup failure (rev3) URL : https://patchwork.freedesktop.org/series/107877/ State : success == Summary == CI Bug Log - changes from CI_DRM_12061 -> Patchwork_107877v3 Sum

[Intel-gfx] [PATCH] drm/i915: Rename ggtt_view as gtt_view

2022-09-01 Thread Niranjana Vishwanathapura
So far, different views (normal, partial, rotated and remapped) into the same object are only supported for GGTT mappings. But with the upcoming VM_BIND feature, PPGTT will also use the partial view mapping. Hence rename ggtt_view to more generic gtt_view. Signed-off-by: Niranjana Vishwanathapura

[Intel-gfx] [PATCH 1/2] drm/i915: Move some of the request decisions out of rps_boost function.

2022-09-01 Thread Rodrigo Vivi
Ideally all the decisions should be made before calling the boost function. And rps functions only receiving the rps struct. At least lets move most of the decisions to the request component, but still leave the test and set of the fence flag boost inside the rps because that might be time sensitiv

[Intel-gfx] [PATCH 2/2] drm/i915: Don't try to disable host RPS when this was never enabled.

2022-09-01 Thread Rodrigo Vivi
Specially in GT reset case this could be triggered and try to disable things that had never been enabled. Let's add some protection here. Cc: Ashutosh Dixit Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_rps.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Rename ggtt_view as gtt_view

2022-09-01 Thread Patchwork
== Series Details == Series: drm/i915: Rename ggtt_view as gtt_view URL : https://patchwork.freedesktop.org/series/108045/ State : warning == Summary == Error: dim checkpatch failed 62ab50381b9f drm/i915: Rename ggtt_view as gtt_view -:831: WARNING:DEEP_INDENTATION: Too many leading tabs - con

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Rename ggtt_view as gtt_view

2022-09-01 Thread Patchwork
== Series Details == Series: drm/i915: Rename ggtt_view as gtt_view URL : https://patchwork.freedesktop.org/series/108045/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [RFC PATCH v3 04/17] drm/i915: Implement bind and unbind of object

2022-09-01 Thread Niranjana Vishwanathapura
On Thu, Sep 01, 2022 at 03:31:13PM +1000, Dave Airlie wrote: On Sun, 28 Aug 2022 at 05:45, Andi Shyti wrote: From: Niranjana Vishwanathapura Implement the bind and unbind of an object at the specified GPU virtual addresses. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Prathap Ku

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Rename ggtt_view as gtt_view

2022-09-01 Thread Patchwork
== Series Details == Series: drm/i915: Rename ggtt_view as gtt_view URL : https://patchwork.freedesktop.org/series/108045/ State : success == Summary == CI Bug Log - changes from CI_DRM_12062 -> Patchwork_108045v1 Summary --- **SUCCE

[Intel-gfx] ✓ Fi.CI.IGT: success for Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev2)

2022-09-01 Thread Patchwork
== Series Details == Series: Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes (rev2) URL : https://patchwork.freedesktop.org/series/107550/ State : success == Summary == CI Bug Log - changes from CI_DRM_12058_full -> Patchwork_107550v2_full ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Move some of the request decisions out of rps_boost function.

2022-09-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move some of the request decisions out of rps_boost function. URL : https://patchwork.freedesktop.org/series/108048/ State : warning == Summary == Error: dim checkpatch failed a285a0d0be8a drm/i915: Move some of the request dec

Re: [Intel-gfx] [PATCH 2/9] drm/nouveau: convert to using is_hdmi and has_audio from display info

2022-09-01 Thread Lyude Paul
Reviewed-by: Lyude Paul Also, went ahead and tested this for you on one of my machines: Tested-by: Lyude Paul On Thu, 2022-09-01 at 15:47 +0300, Jani Nikula wrote: > Prefer the parsed results for is_hdmi and has_audio in display info over > calling drm_detect_hdmi_monitor() and drm_detect_moni

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Move some of the request decisions out of rps_boost function.

2022-09-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move some of the request decisions out of rps_boost function. URL : https://patchwork.freedesktop.org/series/108048/ State : success == Summary == CI Bug Log - changes from CI_DRM_12062 -> Patchwork_108048v1 ===

Re: [Intel-gfx] [PATCH v7 09/15] mei: bus: export common mkhi definitions into a separate header

2022-09-01 Thread Ceraolo Spurio, Daniele
On 8/6/2022 5:26 AM, Tomas Winkler wrote: From: Vitaly Lubart Exported common mkhi definitions from bus-fixup.c into a separate header file mkhi.h for other driver usage. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/bus

Re: [Intel-gfx] [PATCH v7 10/15] mei: mkhi: add memory ready command

2022-09-01 Thread Ceraolo Spurio, Daniele
On 8/6/2022 5:26 AM, Tomas Winkler wrote: Add GSC memory ready command. The command indicates to the firmware that extend operation memory was setup and the firmware may enter PXP mode. CC: Daniele Ceraolo Spurio Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin Copyright dat

Re: [Intel-gfx] [PATCH v7 11/15] mei: gsc: setup gsc extended operational memory

2022-09-01 Thread Ceraolo Spurio, Daniele
On 8/6/2022 5:26 AM, Tomas Winkler wrote: 1. Retrieve extended operational memory physical pointers from the auxiliary device info. 2. Setup memory registers. 3. Notify firmware that the memory is ready by sending the memory ready command. 4. Disable PXP device if GSC is not in PXP mod

  1   2   >