Re: [Intel-gfx] [RFC PATCH v3 04/17] drm/i915: Implement bind and unbind of object

2022-08-31 Thread Tvrtko Ursulin
On 30/08/2022 19:19, Matthew Auld wrote: On 27/08/2022 20:43, Andi Shyti wrote: From: Niranjana Vishwanathapura Implement the bind and unbind of an object at the specified GPU virtual addresses. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Prathap Kumar Valsan Signed-off-by:

Re: [Intel-gfx] [RFC PATCH v3 00/17] drm/i915/vm_bind: Add VM_BIND functionality

2022-08-31 Thread Tvrtko Ursulin
On 27/08/2022 20:43, Andi Shyti wrote: Hi, just sending the original Niranjana's patch as an RFC. It's v3 as the v2 has been reviewed offline with Ramalingam. I'm still keeping most of the structure even though some further discussion can be done starting from here. Copy pasting Niranjana's

Re: [Intel-gfx] [RFC PATCH v3 10/17] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-08-31 Thread Tvrtko Ursulin
On 27/08/2022 20:43, Andi Shyti wrote: From: Niranjana Vishwanathapura Implement new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mode only works with this new execbuf3 ioctl. The new execbuf3 ioctl will not have any list of objects to validate bind as

Re: [Intel-gfx] [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-08-31 Thread Geert Uytterhoeven
Hi Mateusz, On Wed, Aug 31, 2022 at 3:44 AM Mateusz Kwiatkowski wrote: > Wow. That's an enormous amount of effort put into this patch. > > But I'm tempted to say that this is actually overengineered quite a bit :D > Considering that there's no way to access all these calculations from user > spac

[Intel-gfx] ✓ Fi.CI.IGT: success for i915/gvt: fix repeated words in comments

2022-08-31 Thread Patchwork
== Series Details == Series: i915/gvt: fix repeated words in comments URL : https://patchwork.freedesktop.org/series/107883/ State : success == Summary == CI Bug Log - changes from CI_DRM_12044_full -> Patchwork_107883v1_full Summary --

[Intel-gfx] ✓ Fi.CI.IGT: success for i915/display: fix repeated words in comments

2022-08-31 Thread Patchwork
== Series Details == Series: i915/display: fix repeated words in comments URL : https://patchwork.freedesktop.org/series/107887/ State : success == Summary == CI Bug Log - changes from CI_DRM_12044_full -> Patchwork_107887v1_full Summary --

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: fix repeated words in comments (rev3)

2022-08-31 Thread Patchwork
== Series Details == Series: drm/i915: fix repeated words in comments (rev3) URL : https://patchwork.freedesktop.org/series/107885/ State : success == Summary == CI Bug Log - changes from CI_DRM_12044_full -> Patchwork_107885v3_full Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for Move all drivers to a common dma-buf locking convention

2022-08-31 Thread Patchwork
== Series Details == Series: Move all drivers to a common dma-buf locking convention URL : https://patchwork.freedesktop.org/series/107884/ State : success == Summary == CI Bug Log - changes from CI_DRM_12044_full -> Patchwork_107884v1_full

Re: [Intel-gfx] [PATCH 1/3] drm/i915: audit bo->resource usage

2022-08-31 Thread Matthew Auld
On 31/08/2022 09:16, Christian König wrote: Hi Matthew, Am 30.08.22 um 12:45 schrieb Matthew Auld: Hi, On 30/08/2022 08:33, Christian König wrote: Hi guys, can we get an rb/acked-by for this i915 change? Basically we are just making sure that the driver doesn't crash when bo->resource is N

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: add display sub-struct to drm_i915_private (rev3)

2022-08-31 Thread Patchwork
== Series Details == Series: drm/i915: add display sub-struct to drm_i915_private (rev3) URL : https://patchwork.freedesktop.org/series/107170/ State : success == Summary == CI Bug Log - changes from CI_DRM_12044_full -> Patchwork_107170v3_full =

[Intel-gfx] [PATCH 1/3] drm/i915: audit bo->resource usage v2

2022-08-31 Thread Christian König
Make sure we can at least move and alloc TT objects without backing store. v2: clear the tt object even when no resource is allocated. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 6 ++ drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 2 +- 2 files changed

[Intel-gfx] [PATCH 2/3] drm/ttm: stop allocating dummy resources during BO creation

2022-08-31 Thread Christian König
That should not be necessary any more when drivers should at least be able to handle the move without a resource. Signed-off-by: Christian König Reviewed-by: Michael J. Ruhl --- drivers/gpu/drm/ttm/ttm_bo.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b

[Intel-gfx] [PATCH 3/3] drm/ttm: stop allocating a dummy resource for pipelined gutting

2022-08-31 Thread Christian König
That should not be necessary any more when drivers should at least be able to handle a move without a resource. Signed-off-by: Christian König Reviewed-by: Michael J. Ruhl --- drivers/gpu/drm/ttm/ttm_bo_util.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/

[Intel-gfx] ✓ Fi.CI.IGT: success for Add DP MST DSC support to i915 (rev10)

2022-08-31 Thread Patchwork
== Series Details == Series: Add DP MST DSC support to i915 (rev10) URL : https://patchwork.freedesktop.org/series/101492/ State : success == Summary == CI Bug Log - changes from CI_DRM_12044_full -> Patchwork_101492v10_full Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: audit bo->resource usage v2

2022-08-31 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: audit bo->resource usage v2 URL : https://patchwork.freedesktop.org/series/107962/ State : warning == Summary == Error: dim checkpatch failed 4aa8cb1151d4 drm/i915: audit bo->resource usage v2 -:35: CHECK:PARENTHESIS_ALIGNMENT:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915: audit bo->resource usage v2

2022-08-31 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: audit bo->resource usage v2 URL : https://patchwork.freedesktop.org/series/107962/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x8

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix warning callstack for imbalance wakeref (rev6)

2022-08-31 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix warning callstack for imbalance wakeref (rev6) URL : https://patchwork.freedesktop.org/series/107211/ State : success == Summary == CI Bug Log - changes from CI_DRM_12044_full -> Patchwork_107211v6_full

Re: [Intel-gfx] [PATCH v3 1/9] dma-buf: Add _unlocked postfix to function names

2022-08-31 Thread Tomasz Figa
On Wed, Aug 24, 2022 at 01:22:40PM +0300, Dmitry Osipenko wrote: > Add _unlocked postfix to the dma-buf API function names in a preparation > to move all non-dynamic dma-buf users over to the dynamic locking > specification. This patch only renames API functions, preparing drivers > to the common l

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: audit bo->resource usage v2

2022-08-31 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: audit bo->resource usage v2 URL : https://patchwork.freedesktop.org/series/107962/ State : success == Summary == CI Bug Log - changes from CI_DRM_12052 -> Patchwork_107962v1

[Intel-gfx] ✓ Fi.CI.IGT: success for i915: Add "standalone media" support for MTL (rev2)

2022-08-31 Thread Patchwork
== Series Details == Series: i915: Add "standalone media" support for MTL (rev2) URL : https://patchwork.freedesktop.org/series/107908/ State : success == Summary == CI Bug Log - changes from CI_DRM_12044_full -> Patchwork_107908v2_full Sum

Re: [Intel-gfx] [PATCH 1/3] drm/i915: audit bo->resource usage

2022-08-31 Thread Matthew Auld
On 31/08/2022 10:38, Christian König wrote: Am 31.08.22 um 11:26 schrieb Matthew Auld: On 31/08/2022 09:16, Christian König wrote: Hi Matthew, Am 30.08.22 um 12:45 schrieb Matthew Auld: Hi, On 30/08/2022 08:33, Christian König wrote: Hi guys, can we get an rb/acked-by for this i915 change?

[Intel-gfx] [PATCH] drm/i915/display: refine eDP power off sequence

2022-08-31 Thread Lee Shawn C
The current eDP disable sequence like this. disable plane > disable backlight (include T9, the delay from backlight disable to end of valid video data) > disalbe transcoder/pipe > disable eDP power Found abnormal pixel output after plane off sometimes. It did not cause any issue but impact user e

Re: [Intel-gfx] [PATCH] drm/i915/display: refine eDP power off sequence

2022-08-31 Thread Ville Syrjälä
On Wed, Aug 31, 2022 at 06:37:24PM +0800, Lee Shawn C wrote: > The current eDP disable sequence like this. > > disable plane > disable backlight (include T9, the delay > from backlight disable to end of valid video data) > > disalbe transcoder/pipe > disable eDP power > > Found abnormal pixel out

Re: [Intel-gfx] [PATCH] drm/i915: Allow more varied alternate fixed modes for panels

2022-08-31 Thread Jani Nikula
On Wed, 31 Aug 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > On some systems the panel reports alternate modes with > different blanking periods. If the EDID reports them and VBT > doesn't tell us otherwise then I can't really see why they > should be rejected. So allow their use for the p

Re: [Intel-gfx] [PATCH] drm/i915/display: refine eDP power off sequence

2022-08-31 Thread Lee, Shawn C
On Wed, Aug 31, 2022 at 06:49, Ville Syrjälä wrote: >On Wed, Aug 31, 2022 at 06:37:24PM +0800, Lee Shawn C wrote: >> The current eDP disable sequence like this. >> >> disable plane > disable backlight (include T9, the delay from >> backlight disable to end of valid video data) > disalbe >> trans

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: refine eDP power off sequence

2022-08-31 Thread Patchwork
== Series Details == Series: drm/i915/display: refine eDP power off sequence URL : https://patchwork.freedesktop.org/series/107965/ State : success == Summary == CI Bug Log - changes from CI_DRM_12052 -> Patchwork_107965v1 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/bios: Copy the whole MIPI sequence block (rev2)

2022-08-31 Thread Patchwork
== Series Details == Series: drm/i915/bios: Copy the whole MIPI sequence block (rev2) URL : https://patchwork.freedesktop.org/series/107896/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12046_full -> Patchwork_107896v2_full

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref

2022-08-31 Thread Imre Deak
On Tue, Aug 30, 2022 at 02:21:58PM +0530, Mitul Golani wrote: > While executing i915_selftest, wakeref imbalance warning is seen > with i915_selftest failure. > > Currently when Driver is suspended, while doing unregister > it is taking wakeref without resuming the device. > This patch is resuming

Re: [Intel-gfx] [PATCH 1/3] drm/i915: audit bo->resource usage

2022-08-31 Thread Matthew Auld
On 31/08/2022 12:03, Christian König wrote: Am 31.08.22 um 12:37 schrieb Matthew Auld: [SNIP] That hopefully just leaves i915_ttm_shrink(), which is swapping out shmem ttm_tt and is calling ttm_bo_validate() with empty placements to force the pipeline-gutting path, which importantly unpopula

Re: [Intel-gfx] [PATCH] drm/i915/display: clear plane color control register when turn plane off

2022-08-31 Thread Ville Syrjälä
On Mon, Aug 01, 2022 at 11:16:16PM +0800, Lee Shawn C wrote: > Customer report abnormal display output while switch eDP off sometimes. > In current display disable flow, plane will be off at first. Then turn > eDP off and disable HW pipe line. We found the abnormal pixel comes > after turn plane of

Re: [Intel-gfx] [PATCH 1/3] drm/i915: audit bo->resource usage

2022-08-31 Thread Matthew Auld
On 31/08/2022 13:35, Christian König wrote: Am 31.08.22 um 14:06 schrieb Matthew Auld: On 31/08/2022 12:03, Christian König wrote: Am 31.08.22 um 12:37 schrieb Matthew Auld: [SNIP] That hopefully just leaves i915_ttm_shrink(), which is swapping out shmem ttm_tt and is calling ttm_bo_validat

Re: [Intel-gfx] [PATCH] drm/i915/display: clear plane color control register when turn plane off

2022-08-31 Thread Lee, Shawn C
On Wed, August 31, 2022 8:33 PM, Ville Syrjälä wrote: >On Mon, Aug 01, 2022 at 11:16:16PM +0800, Lee Shawn C wrote: >> Customer report abnormal display output while switch eDP off sometimes. >> In current display disable flow, plane will be off at first. Then turn >> eDP off and disable HW pipe li

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/5] drm/i915/crt: remove BUG_ON()

2022-08-31 Thread Patchwork
== Series Details == Series: series starting with [v2,1/5] drm/i915/crt: remove BUG_ON() URL : https://patchwork.freedesktop.org/series/107929/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12048_full -> Patchwork_107929v1_full =

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gmbus: stop using implicit dev_priv

2022-08-31 Thread Patchwork
== Series Details == Series: drm/i915/gmbus: stop using implicit dev_priv URL : https://patchwork.freedesktop.org/series/107930/ State : success == Summary == CI Bug Log - changes from CI_DRM_12048_full -> Patchwork_107930v1_full Summary --

Re: [Intel-gfx] [PATCH] drm/i915/display: clear plane color control register when turn plane off

2022-08-31 Thread Ville Syrjälä
On Wed, Aug 31, 2022 at 01:27:24PM +, Lee, Shawn C wrote: > On Wed, August 31, 2022 8:33 PM, Ville Syrjälä wrote: > >On Mon, Aug 01, 2022 at 11:16:16PM +0800, Lee Shawn C wrote: > >> Customer report abnormal display output while switch eDP off sometimes. > >> In current display disable flow, pl

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915/crt: remove BUG_ON()

2022-08-31 Thread Ville Syrjälä
On Tue, Aug 30, 2022 at 12:34:07PM +0300, Jani Nikula wrote: > Avoid BUG_ON(). We don't have such checks on output type anywhere else > either, so just remove. > > Suggested-by: Ville Syrjälä > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_c

Re: [Intel-gfx] [PATCH v3 00/18] drm/i915: add display sub-struct to drm_i915_private

2022-08-31 Thread Jani Nikula
On Mon, 29 Aug 2022, Jani Nikula wrote: > v3 of https://patchwork.freedesktop.org/series/107170/ > > Dropped already merged patches, rebased the rest. And pushed the lot to drm-intel-next. Thanks for the review. BR, Jani. > > Jani Nikula (18): > drm/i915: move and group hdcp under display.hdc

Re: [Intel-gfx] [PATCH 1/3] drm/i915: audit bo->resource usage

2022-08-31 Thread Matthew Auld
On 31/08/2022 14:34, Christian König wrote: Am 31.08.22 um 14:50 schrieb Matthew Auld: On 31/08/2022 13:35, Christian König wrote: Am 31.08.22 um 14:06 schrieb Matthew Auld: On 31/08/2022 12:03, Christian König wrote: Am 31.08.22 um 12:37 schrieb Matthew Auld: [SNIP] That hopefully just le

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix warning callstack for imbalance wakeref (rev7)

2022-08-31 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix warning callstack for imbalance wakeref (rev7) URL : https://patchwork.freedesktop.org/series/107211/ State : success == Summary == CI Bug Log - changes from CI_DRM_12050_full -> Patchwork_107211v7_full

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warning callstack for imbalance wakeref

2022-08-31 Thread Andrzej Hajda
On 30.08.2022 10:51, Mitul Golani wrote: While executing i915_selftest, wakeref imbalance warning is seen with i915_selftest failure. Currently when Driver is suspended, while doing unregister it is taking wakeref without resuming the device. This patch is resuming the device, if driver is alrea

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915/crt: remove BUG_ON()

2022-08-31 Thread Andrzej Hajda
On 30.08.2022 11:34, Jani Nikula wrote: Avoid BUG_ON(). We don't have such checks on output type anywhere else either, so just remove. Suggested-by: Ville Syrjälä Signed-off-by: Jani Nikula --- Reviewed-by: Andrzej Hajda Regards Andrzej

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/slpc: Set rps' min and max frequencies even with SLPC. (rev6)

2022-08-31 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Set rps' min and max frequencies even with SLPC. (rev6) URL : https://patchwork.freedesktop.org/series/107766/ State : success == Summary == CI Bug Log - changes from CI_DRM_12050_full -> Patchwork_107766v6_full ==

Re: [Intel-gfx] [PATCH v2 1/5] drm/i915/crt: remove BUG_ON()

2022-08-31 Thread Jani Nikula
On Wed, 31 Aug 2022, Andrzej Hajda wrote: > On 30.08.2022 11:34, Jani Nikula wrote: >> Avoid BUG_ON(). We don't have such checks on output type anywhere else >> either, so just remove. >> >> Suggested-by: Ville Syrjälä >> Signed-off-by: Jani Nikula >> --- > Reviewed-by: Andrzej Hajda Thanks f

Re: [Intel-gfx] [PATCH 0/6] drm/i915/gmbus: stop using implicit dev_priv

2022-08-31 Thread Jani Nikula
On Tue, 30 Aug 2022, Jani Nikula wrote: > On Tue, 30 Aug 2022, Ville Syrjälä wrote: >> On Tue, Aug 30, 2022 at 01:27:56PM +0300, Jani Nikula wrote: >>> The register macros are the last holdout for implicit dev_priv local >>> variable. Try out what it would mean to stop using it, and require >>> p

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915/dpll: replace BUG_ON() with drm_WARN_ON()

2022-08-31 Thread Andrzej Hajda
On 30.08.2022 11:34, Jani Nikula wrote: Avoid BUG_ON(). Actually check the dpll count and bail out loudly with drm_WARN_ON() from the loop before overflowing i915->dpll.shared_dplls[]. v2: Rebase Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/pch: replace BUG_ON() with drm_WARN_ON()

2022-08-31 Thread Andrzej Hajda
On 30.08.2022 11:34, Jani Nikula wrote: Avoid BUG_ON(). Replace with drm_WARN_ON(). Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [Intel-gfx] [PATCH] drm/i915/ttm: Abort suspend on i915_ttm_backup failure

2022-08-31 Thread Matthew Auld
On 29/08/2022 13:04, Nirmoy Das wrote: On system suspend when system memory is low then i915_gem_obj_copy_ttm() could fail trying to backup a lmem obj. GEM_WARN_ON() is not enough, suspend shouldn't continue if i915_ttm_backup() throws an error. Closes: https://gitlab.freedesktop.org/drm/intel/-

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915/dpll: replace BUG_ON() with drm_WARN_ON()

2022-08-31 Thread Jani Nikula
On Wed, 31 Aug 2022, Andrzej Hajda wrote: > On 30.08.2022 11:34, Jani Nikula wrote: >> Avoid BUG_ON(). Actually check the dpll count and bail out loudly with >> drm_WARN_ON() from the loop before overflowing >> i915->dpll.shared_dplls[]. >> >> v2: Rebase >> >> Reviewed-by: Ville Syrjälä >> Sign

[Intel-gfx] [PATCH 0/1] Modify debugfs entry from dsc compressed bpp to input bpc

2022-08-31 Thread Swati Sharma
In this patch, output dsc compressed bpp debufs entry is changed to input bpc dsc. Also, corresponding changes done in kms_dsc i-g-t. Test-with: 20220831120849.28883-1-swati2.sha...@intel.com Swati Sharma (1): drm/i915/display: convert dsc debugfs entry from output_bpp to input_bpc .../dr

[Intel-gfx] [PATCH 1/1] drm/i915/display: convert dsc debugfs entry from output_bpp to input_bpc

2022-08-31 Thread Swati Sharma
With this patch, converting DSC debugfs entry from output_bpp to input_bpc. Corresponding changes are done in i-g-t to validate DSC with different input bpc supported per platform. Signed-off-by: Swati Sharma --- .../drm/i915/display/intel_display_debugfs.c | 26 +-- .../drm/i91

Re: [Intel-gfx] [PATCH] drm/i915/ttm: Abort suspend on i915_ttm_backup failure

2022-08-31 Thread Das, Nirmoy
On 8/31/2022 5:50 PM, Matthew Auld wrote: On 29/08/2022 13:04, Nirmoy Das wrote: On system suspend when system memory is low then i915_gem_obj_copy_ttm() could fail trying to backup a lmem obj. GEM_WARN_ON() is not enough, suspend shouldn't continue if i915_ttm_backup() throws an error. Close

[Intel-gfx] [PATCH] drm/i915/ttm: Abort suspend on i915_ttm_backup failure

2022-08-31 Thread Nirmoy Das
On system suspend when system memory is low then i915_gem_obj_copy_ttm() could fail trying to backup a lmem obj. GEM_WARN_ON() is not enough, suspend shouldn't continue if i915_ttm_backup() throws an error. References: https://gitlab.freedesktop.org/drm/intel/-/issues/6529 Reviewed-by: Matthew Aul

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/slpc: Fix inconsistent locked return (rev2)

2022-08-31 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Fix inconsistent locked return (rev2) URL : https://patchwork.freedesktop.org/series/107938/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12051_full -> Patchwork_107938v2_full Su

Re: [Intel-gfx] [PATCH 1/3] drm/i915: audit bo->resource usage

2022-08-31 Thread Matthew Auld
On 31/08/2022 15:53, Matthew Auld wrote: On 31/08/2022 14:34, Christian König wrote: Am 31.08.22 um 14:50 schrieb Matthew Auld: On 31/08/2022 13:35, Christian König wrote: Am 31.08.22 um 14:06 schrieb Matthew Auld: On 31/08/2022 12:03, Christian König wrote: Am 31.08.22 um 12:37 schrieb Matt

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Allow more varied alternate fixed modes for panels

2022-08-31 Thread Patchwork
== Series Details == Series: drm/i915: Allow more varied alternate fixed modes for panels URL : https://patchwork.freedesktop.org/series/107953/ State : success == Summary == CI Bug Log - changes from CI_DRM_12051_full -> Patchwork_107953v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for Tidy up vfio_device life cycle (rev2)

2022-08-31 Thread Patchwork
== Series Details == Series: Tidy up vfio_device life cycle (rev2) URL : https://patchwork.freedesktop.org/series/107838/ State : success == Summary == CI Bug Log - changes from CI_DRM_12051_full -> Patchwork_107838v2_full Summary ---

Re: [Intel-gfx] [PATCH 15/15] vfio: Add struct device to vfio_device

2022-08-31 Thread Alex Williamson
On Wed, 31 Aug 2022 06:10:51 + "Tian, Kevin" wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, August 31, 2022 7:53 AM > > > > On Tue, Aug 30, 2022 at 04:18:38PM -0600, Alex Williamson wrote: > > > On Sun, 28 Aug 2022 01:10:37 +0800 > > > Kevin Tian wrote: > > > > > > > From: Yi Li

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915: audit bo->resource usage v2

2022-08-31 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: audit bo->resource usage v2 URL : https://patchwork.freedesktop.org/series/107962/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12052_full -> Patchwork_107962v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: refine eDP power off sequence

2022-08-31 Thread Patchwork
== Series Details == Series: drm/i915/display: refine eDP power off sequence URL : https://patchwork.freedesktop.org/series/107965/ State : success == Summary == CI Bug Log - changes from CI_DRM_12052_full -> Patchwork_107965v1_full Summary

[Intel-gfx] [PULL] drm-misc-fixes

2022-08-31 Thread Thomas Zimmermann
Hi Dave and Daniel, only a single fix from drm-misc this week. Best regards Thomas drm-misc-fixes-2022-08-31: Short summary of fixes pull: * dma-buf/dma-resv: Fence-handling fix The following changes since commit 6b04ce966a738ecdd9294c9593e48513c0dc90aa: nouveau: explicitly wait on the fenc

[Intel-gfx] ✓ Fi.CI.BAT: success for Modify debugfs entry from dsc compressed bpp to input bpc

2022-08-31 Thread Patchwork
== Series Details == Series: Modify debugfs entry from dsc compressed bpp to input bpc URL : https://patchwork.freedesktop.org/series/107972/ State : success == Summary == CI Bug Log - changes from CI_DRM_12057 -> Patchwork_107972v1 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ttm: Abort suspend on i915_ttm_backup failure (rev2)

2022-08-31 Thread Patchwork
== Series Details == Series: drm/i915/ttm: Abort suspend on i915_ttm_backup failure (rev2) URL : https://patchwork.freedesktop.org/series/107877/ State : success == Summary == CI Bug Log - changes from CI_DRM_12057 -> Patchwork_107877v2 Sum

[Intel-gfx] [RFC PATCH 2/2] Fix per client busyness locking

2022-08-31 Thread Ashutosh Dixit
1. Do all ce->stats updates and reads under guc->timestamp.lock 2. Pin context image before reading 3. Merge __guc_context_update_clks and guc_context_update_stats into a single function 4. Call lrc_update_runtime() unconditionally in guc_context_update_stats 5. Seems no need to update ce->stats

[Intel-gfx] [PATCH 1/2] i915/pmu: Wire GuC backend to per-client busyness

2022-08-31 Thread Ashutosh Dixit
From: John Harrison GuC provides engine_id and last_switch_in ticks for an active context in the pphwsp. The context image provides a 32 bit total ticks which is the accumulated by the context (a.k.a. context[CTX_TIMESTAMP]). This information is used to calculate the context busyness as follows:

Re: [Intel-gfx] [PATCH] drm/i915/slpc: Let's fix the PCODE min freq table setup for SLPC

2022-08-31 Thread Vivi, Rodrigo
On Tue, 2022-08-30 at 17:45 -0700, Dixit, Ashutosh wrote: > On Tue, 30 Aug 2022 12:16:20 -0700, Rodrigo Vivi wrote: > > > > Hi Rodrigo, > > > @@ -65,13 +63,8 @@ static bool get_ia_constants(struct intel_llc > > *llc, > > /* convert DDR frequency from units of 266.6MHz to > > bandwidth */

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] i915/pmu: Wire GuC backend to per-client busyness

2022-08-31 Thread Patchwork
== Series Details == Series: series starting with [1/2] i915/pmu: Wire GuC backend to per-client busyness URL : https://patchwork.freedesktop.org/series/107983/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESC

Re: [Intel-gfx] [PATCH] i915/pmu: Wire GuC backend to per-client busyness

2022-08-31 Thread Dixit, Ashutosh
On Fri, 26 Aug 2022 09:33:08 -0700, Umesh Nerlige Ramappa wrote: > Hi Umesh, Just to communicate my thoughts I have posted this patch on top of your patch: [1] https://patchwork.freedesktop.org/series/107983/ Could you please take a look at that and see if it makes sense. > On Thu, Aug 25, 202

[Intel-gfx] [PATCH] drm/i915/slpc: Let's fix the PCODE min freq table setup for SLPC

2022-08-31 Thread Rodrigo Vivi
We need to inform PCODE of a desired ring frequencies so PCODE update the memory frequencies to us. rps->min_freq and rps->max_freq are the frequencies used in that request. However they were unset when SLPC was enabled and PCODE never updated the memory freq. v2 (as Suggested by Ashutosh): if SLP

[Intel-gfx] [PATCH v3 00/11] Initial Meteorlake Support

2022-08-31 Thread Radhakrishna Sripada
The PCI Id's and platform definition are posted earlier. This series adds handful of early enablement patches including support for display power wells, VBT and AUX Channel mapping, PCH and gmbus support, dbus, mbus, sagv and memory bandwidth support. This series also add the support for a new way

[Intel-gfx] [PATCH v3 02/11] drm/i915: Read graphics/media/display arch version from hw

2022-08-31 Thread Radhakrishna Sripada
From: Matt Roper Going forward, the hardware teams no longer consider new platforms to have a "generation" in the way we've defined it for past platforms. Instead, each IP block (graphics, media, display) will have their own architecture major.minor versions and stepping ID's which should be read

[Intel-gfx] [PATCH v3 05/11] drm/i915/mtl: Add gmbus and gpio support

2022-08-31 Thread Radhakrishna Sripada
Add tables to map the GMBUS pin pairs to GPIO registers and port to DDC. >From spec we have registers GPIO_CTL[1-5] mapped to native display phys and GPIO_CTL[9-12] are mapped to TC ports. v2: - Drop unused GPIO pins(MattR) BSpec: 49306 Cc: Matt Roper Original Author: Brian J Lovin Signed-off-

[Intel-gfx] [PATCH v3 01/11] drm/i915: Move display and media IP version to runtime info

2022-08-31 Thread Radhakrishna Sripada
Future platforms can read the IP version from a register and the IP version numbers need not be hard coded in device info. Move the ip version for media and display to runtime info. On platforms where hard coding of IP version is required, update the IP version in __runtime under device_info. Sug

[Intel-gfx] [PATCH v3 08/11] drm/i915/mtl: Obtain SAGV values from MMIO instead of GT pcode mailbox

2022-08-31 Thread Radhakrishna Sripada
>From Meteorlake, Latency Level, SAGV bloack time are read from LATENCY_SAGV register instead of the GT driver pcode mailbox. DDR type and QGV information are also to be read from Mem SS registers. v2: - Simplify MTL_MEM_SS_INFO_QGV_POINT macro(MattR) - Nit: Rearrange the bit def's from higher t

[Intel-gfx] [PATCH v3 06/11] drm/i915/mtl: Add display power wells

2022-08-31 Thread Radhakrishna Sripada
From: Imre Deak Add support for display power wells on MTL. The differences from XE_LPD: - The AUX HW block is moved to the PICA block, where the registers are on an always-on power well and the functionality needs to be powered on/off via the AUX_CH_CTL register: [1], [2] - The DDI IO power

[Intel-gfx] [PATCH v3 10/11] drm/i915/mtl: Update CHICKEN_TRANS* register addresses

2022-08-31 Thread Radhakrishna Sripada
From: Madhumitha Tolakanahalli Pradeep In Display version 14, Transcoder Chicken Registers are moved from DPRZ to DRPOS to reduce register signal crossings for Unit Interface Optimization. This patch modifies the CHICKEN_TRANS macro to add a DISPLAY_VER check for calculating the correct platfor

[Intel-gfx] [PATCH v3 11/11] drm/i915/mtl: Do not update GV point, mask value

2022-08-31 Thread Radhakrishna Sripada
Display 14 and future platforms do not directly communicate to Pcode via mailbox the SAGV bandwidth information. PM Demand registers are used to communicate display power requirements to the PUnit which would include GV point and mask value. Skip programming GV point and mask values through legacy

[Intel-gfx] [PATCH v3 03/11] drm/i915: Parse and set stepping for platforms with GMD

2022-08-31 Thread Radhakrishna Sripada
From: José Roberto de Souza The GMD step field do not properly match the current stepping convention that we use(STEP_A0, STEP_A1, STEP_B0...). One platform could have { arch = 12, rel = 70, step = 1 } and the actual stepping is STEP_B0 but without the translation of the step field would mean ST

[Intel-gfx] [PATCH v3 07/11] drm/i915/mtl: Add DP AUX support on TypeC ports

2022-08-31 Thread Radhakrishna Sripada
From: Imre Deak On MTL TypeC ports the AUX_CH_CTL and AUX_CH_DATA addresses have changed wrt. previous platforms, adjust the code accordingly. Signed-off-by: Imre Deak Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 45 - drivers/gpu/d

[Intel-gfx] [PATCH v3 09/11] drm/i915/mtl: Update MBUS_DBOX credits

2022-08-31 Thread Radhakrishna Sripada
Display version 14 platforms have different credits values compared to ADL-P. Update the credits based on pipe usage. v2: Simplify DBOX BW Credit definition(MattR) Bspec: 49213 Cc: Jose Roberto de Souza Cc: Matt Roper Original Author: Caz Yokoyama Signed-off-by: José Roberto de Souza Signed-o

[Intel-gfx] [PATCH v3 04/11] drm/i915/mtl: Define engine context layouts

2022-08-31 Thread Radhakrishna Sripada
From: Matt Roper The part of the media and blitter engine contexts that we care about for setting up an initial state are the same on MTL as they were on DG2 (and PVC), so we need to update the driver conditions to re-use the DG2 context table. For render/compute engines, the part of the context

Re: [Intel-gfx] [PATCH] drm/i915/slpc: Let's fix the PCODE min freq table setup for SLPC

2022-08-31 Thread Dixit, Ashutosh
On Wed, 31 Aug 2022 14:45:38 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, > We need to inform PCODE of a desired ring frequencies so PCODE update > the memory frequencies to us. rps->min_freq and rps->max_freq are the > frequencies used in that request. However they were unset when SLPC was > enabled

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/slpc: Set rps' min and max frequencies even with SLPC. (rev7)

2022-08-31 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Set rps' min and max frequencies even with SLPC. (rev7) URL : https://patchwork.freedesktop.org/series/107766/ State : success == Summary == CI Bug Log - changes from CI_DRM_12058 -> Patchwork_107766v7

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Initial Meteorlake Support (rev4)

2022-08-31 Thread Patchwork
== Series Details == Series: Initial Meteorlake Support (rev4) URL : https://patchwork.freedesktop.org/series/106786/ State : warning == Summary == Error: dim checkpatch failed f0dff2f56c1d drm/i915: Move display and media IP version to runtime info -:29: CHECK:MACRO_ARG_REUSE: Macro argument

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Initial Meteorlake Support (rev4)

2022-08-31 Thread Patchwork
== Series Details == Series: Initial Meteorlake Support (rev4) URL : https://patchwork.freedesktop.org/series/106786/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [RFC PATCH 2/2] Fix per client busyness locking

2022-08-31 Thread Umesh Nerlige Ramappa
On Wed, Aug 31, 2022 at 12:33:55PM -0700, Ashutosh Dixit wrote: 1. Do all ce->stats updates and reads under guc->timestamp.lock Other than the question about READ_ONCE/WRITE_ONCE, I am not sure I understand what's broken in the locking logic here. Can you please add some description? thanks

Re: [Intel-gfx] [PATCH] i915/pmu: Wire GuC backend to per-client busyness

2022-08-31 Thread Umesh Nerlige Ramappa
On Wed, Aug 31, 2022 at 01:25:11PM -0700, Dixit, Ashutosh wrote: On Fri, 26 Aug 2022 09:33:08 -0700, Umesh Nerlige Ramappa wrote: Hi Umesh, Just to communicate my thoughts I have posted this patch on top of your patch: [1] https://patchwork.freedesktop.org/series/107983/ Could you please t

[Intel-gfx] ✗ Fi.CI.BAT: failure for Initial Meteorlake Support (rev4)

2022-08-31 Thread Patchwork
== Series Details == Series: Initial Meteorlake Support (rev4) URL : https://patchwork.freedesktop.org/series/106786/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12058 -> Patchwork_106786v4 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH 15/15] vfio: Add struct device to vfio_device

2022-08-31 Thread Tian, Kevin
> From: Alex Williamson > Sent: Thursday, September 1, 2022 1:15 AM > > On Wed, 31 Aug 2022 06:10:51 + > "Tian, Kevin" wrote: > > > > From: Jason Gunthorpe > > > Sent: Wednesday, August 31, 2022 7:53 AM > > > > > > On Tue, Aug 30, 2022 at 04:18:38PM -0600, Alex Williamson wrote: > > > > On

Re: [Intel-gfx] [PATCH 15/15] vfio: Add struct device to vfio_device

2022-08-31 Thread Alex Williamson
On Thu, 1 Sep 2022 00:46:51 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Thursday, September 1, 2022 1:15 AM > > > > On Wed, 31 Aug 2022 06:10:51 + > > "Tian, Kevin" wrote: > > > > > > From: Jason Gunthorpe > > > > Sent: Wednesday, August 31, 2022 7:53 AM > > > > > >

Re: [Intel-gfx] [RFC PATCH v3 10/17] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2022-08-31 Thread Niranjana Vishwanathapura
On Wed, Aug 31, 2022 at 08:38:48AM +0100, Tvrtko Ursulin wrote: On 27/08/2022 20:43, Andi Shyti wrote: From: Niranjana Vishwanathapura Implement new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mode only works with this new execbuf3 ioctl. The new execb

Re: [Intel-gfx] [RFC PATCH v3 04/17] drm/i915: Implement bind and unbind of object

2022-08-31 Thread Niranjana Vishwanathapura
On Tue, Aug 30, 2022 at 07:19:17PM +0100, Matthew Auld wrote: On 27/08/2022 20:43, Andi Shyti wrote: From: Niranjana Vishwanathapura Implement the bind and unbind of an object at the specified GPU virtual addresses. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Prathap Kumar Valsan

Re: [Intel-gfx] [RFC PATCH v3 04/17] drm/i915: Implement bind and unbind of object

2022-08-31 Thread Dave Airlie
On Sun, 28 Aug 2022 at 05:45, Andi Shyti wrote: > > From: Niranjana Vishwanathapura > > Implement the bind and unbind of an object at the specified GPU virtual > addresses. > > Signed-off-by: Niranjana Vishwanathapura > Signed-off-by: Prathap Kumar Valsan > Signed-off-by: Ramalingam C > Signed

[Intel-gfx] [PATCH v2 0/9] Handle BPC for HDMI2.1 PCON without DSC1.2 sink and other fixes

2022-08-31 Thread Ankit Nautiyal
This series fixes issues faced when an HDMI2.1 sink that does not support DSC is connected via HDMI2.1PCON. It also icludes other minor HDMI2.1 PCON fixes/refactoring. Patch 1-3 Have minor fixes/cleanups. Patch 4-7 Pull the decision making to use DFP conversion capabilities for every mode during c

[Intel-gfx] [PATCH v2 1/9] drm/i915/dp: Reset frl trained flag before restarting FRL training

2022-08-31 Thread Ankit Nautiyal
For cases where DP has HDMI2.1 sink and FRL Link issues are detected, reset the flag to state FRL trained status before restarting FRL training. Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery") Cc: Swati Sharma Cc: Ankit Nautiyal Cc: Uma Shankar (v2) Cc: Jani

[Intel-gfx] [PATCH v2 2/9] drm/i915/dp: Add RGB to YCBCR conversion case in is_dp_ycbcr420 helper

2022-08-31 Thread Ankit Nautiyal
Add the case for RGB444 to YCBCR444 conversion required by the DFP in the helper to check if output format is YCBCR420. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/driv

[Intel-gfx] [PATCH v2 3/9] drm/i915/dp: Remove whitespace at the end of function.

2022-08-31 Thread Ankit Nautiyal
Remove extraline left after intel_dp_configure_protocol_converter. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index a05b8b86e5c8..b

[Intel-gfx] [PATCH v2 4/9] drm/i915/display: Add new members to configure PCON color conversion

2022-08-31 Thread Ankit Nautiyal
The decision to use DFP output format conversion capabilities should be during compute_config phase. This patch adds new members to crtc_state to help configure the DFP output related conversions. Also adds a member to intel_dp to store ycbcr420 pass through capability. This will help to store on

[Intel-gfx] [PATCH v2 7/9] drm/i915/dp: Replace intel_dp.dfp members with the new crtc_state dp_dfp members

2022-08-31 Thread Ankit Nautiyal
The decision to use DFP output format conversion capabilities should be during compute_config phase. This patch uses the members of intel_dp->dfp to only store the format conversion capabilities of the DP device and uses the crtc_state dp_dfp members that are computed earlier, to program the proto

[Intel-gfx] [PATCH v2 6/9] drm/i915/dp: Use crtc_state members in dp_is_ycbcr420

2022-08-31 Thread Ankit Nautiyal
Use the new crtc_state members to check if DP DFP will use YCBCR420. The earlier intel_dp->dfp members are not required as decision to use color format conversion by the PCON is computed and stored in crtc_state. Also drop the intel_dp argument in the helper function. Signed-off-by: Ankit Nautiyal

[Intel-gfx] [PATCH v2 5/9] drm/i915/dp: Compute configuration for using PCON's color/format conversion

2022-08-31 Thread Ankit Nautiyal
Fill the crtc_state members to store the configuration required by PCONs for color/format conversion for a YCBCR420 mode and the computed output format. This will be later used during protocol_converter_config to program the PCON to use appropriate color/format conversion. Signed-off-by: Ankit Na

  1   2   >