[Intel-gfx] [PATCH 3/3] drm/i915/display: Use drm helper instead of own loop for damage clips

Use existing drm_atomic_helper_damage_merged from generic drm code instead of implementing own loop to iterate over damage_clips. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/driv

Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Disable PSR before disable pipe

On Fri, 2022-07-15 at 11:39 +0300, Lisovskiy, Stanislav wrote: > On Fri, Jul 15, 2022 at 08:33:43AM +0300, Hogander, Jouni wrote: > > On Thu, 2022-07-14 at 08:07 -0700, José Roberto de Souza wrote: > > > The issue here was on for_each_intel_encoder_mask_with_psr() over the > > > new_crtc_state enco

[Intel-gfx] [PATCH 2/3] drm/i915/display: Use original src in psr2 sel fetch area calculation

drm_plane_state->src is modified when offset is calculated: before calculation: src.x1 = 8192, src.y1 = 8192 after calculation (pitch = 65536, cpp = 4, alignment = 262144) src.x1 = 8192, src.y1 = 0, offset = 0x2000 Damage clips are relative to original coodrdinates provided by user-space. To

[Intel-gfx] [PATCH 1/3] drm: Use original src rect while initializing damage iterator

drm_plane_state->src might be modified by the driver. This is done e.g. in i915 driver when there is bigger framebuffer than the plane and there is some offset within framebuffer. I915 driver calculates separate offset and adjusts src rect coords to be relative to this offset. Damage clips are stil

[Intel-gfx] [PATCH 0/3] Fixes for damage clips handling

Currently damage clips handling is broken for planes when using big framebuffer + offset in case kms driver adjusts drm_plane_state.src coords. This is because damage clips are using coords relative to original coords from user-space. This patchset is fixing this by using original coords from user

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/kms: Stop registering multiple /sys/class/backlight devs for a single display (rev2)

On Tue, Jul 12, 2022 at 08:39:32PM -, Patchwork wrote: >Patch Details > >Series: drm/kms: Stop registering multiple /sys/class/backlight devs >for a single display (rev2) >URL: [1]https://patchwork.freedesktop.org/series/104084/ >State: failure >Details: >[2]https:/

Re: [Intel-gfx] [PATCH v2 16/29] ACPI: video: Add Nvidia WMI EC brightness control detection

Hi, On 7/15/22 17:32, Daniel Dadap wrote: > > >> On Jul 15, 2022, at 06:59, Hans de Goede wrote: >> >> Hi Daniel, >> >>> On 7/12/22 22:13, Daniel Dadap wrote: >>> Thanks, Hans: >>> On 7/12/22 14:38, Hans de Goede wrote: On some new laptop designs a new Nvidia specific WMI interface i

[Intel-gfx] [PATCH 02/12] drm/i915: Add some more VBT version number comments

From: Ville Syrjälä Document the VBT version dependency of several other fields. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 76 +-- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.

Re: [Intel-gfx] [PATCH v2 28/39] drm/i915: i915_deps: use a shorter title markup

On Wed, Jul 13, 2022 at 09:12:16AM +0100, Mauro Carvalho Chehab wrote: > The DOC: tag waits for a one-line short title for the doc > section. Using multiple lines will produce a weird output. > So, add a shorter description for the title, while keeping > the current content below it. > > Signed-of

[Intel-gfx] [PATCH 00/12] drm/i915: More VBT stuff

From: Ville Syrjälä Bunch of VBT work: - cleanup of version number comments - document more bits - rename a few misnamed things - warn if any port wants to use the VBT vswing tables - parse the new DP lane count limit Ville Syrjälä (12): drm/i915: Unify VBT version number comments drm/i915:

[Intel-gfx] [PATCH 09/12] drm/i915: Define all possible VBT device handles

From: Ville Syrjälä We already have LFP1 and LFP2 device handles define. Just add all the rest as well. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/d

Re: [Intel-gfx] [PATCH 07/12] drm/i915/guc: Route semaphores to GuC for Gen12+

On 7/12/2022 4:31 PM, john.c.harri...@intel.com wrote: From: Michał Winiarski Since we're going to use semaphores in selftests (and eventually in regular GuC submission), let's route semaphores to GuC. I'd specify that this interrupt is only relevant for semaphores that context switch out

Re: [Intel-gfx] [PATCH v2 20/39] drm/i915: i915_gem_wait.c: fix a kernel-doc markup

On Wed, Jul 13, 2022 at 09:12:08AM +0100, Mauro Carvalho Chehab wrote: > The return codes for i915_gem_wait_ioctl() have identation issues, > and will be displayed on a very confusing way. Use lists to improve > its output. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > -

Re: [Intel-gfx] [PATCH v2 24/39] drm/i915: dvo_sil164.c: use SPDX header

On Wed, Jul 13, 2022 at 09:12:12AM +0100, Mauro Carvalho Chehab wrote: > This file is licensed with MIT license. Change its license text > to use SPDX. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mai

[Intel-gfx] [PATCH 10/12] drm/i915: Rename some VBT bits

From: Ville Syrjälä The allow vs. block display switch bits are named rather inconsistently. Fix it up. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vbt_

[Intel-gfx] [PATCH 08/12] drm/i915: Define more VBT driver features block bits

From: Ville Syrjälä Define some additoonal bits in the driver features VBT block. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/

Re: [Intel-gfx] [PATCH v2 25/39] drm/i915: i915_vma_resource.c: fix some kernel-doc markups

On Wed, Jul 13, 2022 at 09:12:13AM +0100, Mauro Carvalho Chehab wrote: > Building docs currently produces two warnings: > > Documentation/foo/i915:71: > ./drivers/gpu/drm/i915/i915_vma_resource.c:286: WARNING: Inline strong > start-string without end-string. > Documentation/foo/i915:71:

Re: [Intel-gfx] [PATCH v2 14/39] drm/i915: document kernel-doc trivial issues

On Wed, Jul 13, 2022 at 09:12:02AM +0100, Mauro Carvalho Chehab wrote: > Fix those kernel-doc warnings: > drivers/gpu/drm/i915/intel_region_ttm.c:199: warning: Function > parameter or member 'offset' not described in > 'intel_region_ttm_resource_alloc' > drivers/gpu/drm/i915/i915_vma_

[Intel-gfx] [PATCH 03/12] drm/i915: Properly define the DP redriver VBT bits

From: Ville Syrjälä Split the DP redriver bytes into bitfields. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/

[Intel-gfx] [PATCH 04/12] drm/i915: Define VBT eDP/DP max lane count bits

From: Ville Syrjälä Since version 244 the VBT can llimt the eDP/DP max lane count. Add the bits. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/d

Re: [Intel-gfx] [PATCH v2 23/39] drm/i915: dvo_ch7xxx.c: use SPDX header

On Wed, Jul 13, 2022 at 09:12:11AM +0100, Mauro Carvalho Chehab wrote: > This file is licensed with MIT license. Change its license text > to use SPDX. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombing on a large number of people, only mailing l

[Intel-gfx] [PATCH 06/12] drm/i915: Define VBT max HDMI FRL rate bits

From: Ville Syrjälä The VBT gained some bits to inidicate the max FRL rate for HDMI 2.1, define them. These just outright replaced the slave_port bits for ganged eDP. Apparently that feature was never actually used so someone decided that reusing the bits is fine. Although the actual ganged eDP

Re: [Intel-gfx] [PATCH v2 24/39] drm/i915: dvo_sil164.c: use SPDX header

On Fri, 2022-07-15 at 17:35 -0400, Rodrigo Vivi wrote: > On Wed, Jul 13, 2022 at 09:12:12AM +0100, Mauro Carvalho Chehab wrote: > > This file is licensed with MIT license. Change its license text > > to use SPDX. > > > > Signed-off-by: Mauro Carvalho Chehab > > Reviewed-by: Rodrigo Vivi No

[Intel-gfx] [PATCH 07/12] drm/i915: Document the sets of bits in the driver features block

From: Ville Syrjälä Add a few comment documenting the sets of bits in the driver features block. Might make it a bit easier to check against the spec. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drive

[Intel-gfx] [PATCH 01/12] drm/i915: Unify VBT version number comments

From: Ville Syrjälä Use a more standard form for the VT version number comments. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 206 ++ 1 file changed, 110 insertions(+), 96 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs

Re: [Intel-gfx] [PATCH RFC] drm/i915/gt: Retry RING_HEAD reset until it sticks

On Fri, Jul 15, 2022 at 09:26:16AM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > On Haswell, in particular, we see an issue where resets fails because Can we then make this platform specific? Only because some older hw doesn't behave like expected we shouldn't make this a default

[Intel-gfx] [PATCH 05/12] drm/i915: Add the VBT LTTPR transparent vs. non-transparent bits

From: Ville Syrjälä VBT gained a bit to indicate whether LTTPRs should use transparent or non-transparent mode. Dunno if we should actually look at this... Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

[Intel-gfx] [PATCH] drm/i915/guc: Check for ct enabled while waiting for response

We are seeing error message of "No response for request". Some cases happened while waiting for response and reset/suspend action was triggered. In this case, no response is not an error, active requests will be cancelled. This patch will handle this condition and change the error message into deb

Re: [Intel-gfx] [PATCH v2 16/39] drm/i915: intel_fb: fix a kernel-doc issue with Sphinx

On Wed, Jul 13, 2022 at 09:12:04AM +0100, Mauro Carvalho Chehab wrote: > We can't use %foo[] as this produces a bad markup. > Use instead, the emphasis markup directly. > > Fix this issue: > Documentation/gpu/i915:136: > ./drivers/gpu/drm/i915/display/intel_fb.c:280: WARNING: Inline strong

Re: [Intel-gfx] [PATCH v2 13/39] drm/i915: i915_gpu_error.c: document dump_flags

On Wed, Jul 13, 2022 at 09:12:01AM +0100, Mauro Carvalho Chehab wrote: > Kernel-doc dump_flags parameter is missing at i915_capture_error_state(). > Document it. > > Fixes: a6f0f9cf330a ("drm/i915/guc: Plumb GuC-capture into gpu_coredump") Why the fix here and not in the i915_vma_destroy_locked o

Re: [Intel-gfx] [PATCH v2 21/39] drm/i915: fix i915_gem_ttm_move.c DOC: markup

On Wed, Jul 13, 2022 at 09:12:09AM +0100, Mauro Carvalho Chehab wrote: > The doc markup should not end with ":", as it would generate a > warning on Sphinx while generating the cross-reference tag. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Rodrigo Vivi > --- > > To avoid mailbombi

Re: [Intel-gfx] [PATCH v2 17/39] drm/i915: skl_scaler: fix return value kernel-doc markup

On Wed, Jul 13, 2022 at 09:12:05AM +0100, Mauro Carvalho Chehab wrote: > The way it is, it produces this warning: > > Documentation/gpu/i915:150: > ./drivers/gpu/drm/i915/display/skl_scaler.c:213: WARNING: Block quote ends > without a blank line; unexpected unindent. > > Use list markups

Re: [Intel-gfx] [PATCH v3 5/7] drm/i915: Check if the size is too big while creating shmem file

-creation/20220714-171019 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: i386-randconfig-a004 (https://download.01.org/0day-ci/archive/20220716/202207161058.dmozoqzg-...@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: stop HPD workers before display driver unregister (rev7)

== Series Details == Series: drm/i915/display: stop HPD workers before display driver unregister (rev7) URL : https://patchwork.freedesktop.org/series/105557/ State : success == Summary == CI Bug Log - changes from CI_DRM_11900 -> Patchwork_105557v7 ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: stop HPD workers before display driver unregister (rev7)

== Series Details == Series: drm/i915/display: stop HPD workers before display driver unregister (rev7) URL : https://patchwork.freedesktop.org/series/105557/ State : success == Summary == CI Bug Log - changes from CI_DRM_11900_full -> Patchwork_105557v7_full =

[Intel-gfx] [PATCH 12/12] drm/i915: Parse DP/eDP max lane count from VBT

From: Ville Syrjälä Limit the DP lane count based on the new VBT DP/eDP max lane count field. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bios.c | 16 drivers/gpu/drm/i915/display/intel_bios.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 13 +

[Intel-gfx] [PATCH 11/12] drm/i915: WARN if a port should use VBT provided vswing tables

From: Ville Syrjälä We don't parse the VBT vswing/preemphassis tables at all currently. Let's WARN if a port wants to use them so we get a heads up that whether we really need to implement this stuff or not. My current stash contains no VBTs with this bit set. Signed-off-by: Ville Syrjälä ---

Re: [Intel-gfx] [PATCH v2 26/39] drm/i915: i915_gem.c fix a kernel-doc issue

On Wed, Jul 13, 2022 at 09:12:14AM +0100, Mauro Carvalho Chehab wrote: > Prevent this Sphinx warning: > > Documentation/foo/i915:728: ./drivers/gpu/drm/i915/i915_gem.c:447: > WARNING: Inline emphasis start-string without end-string. > > By using @data to identify the data field, as expecte

Re: [Intel-gfx] [PATCH v2 27/39] drm/i915: i915_scatterlist.h: fix some kernel-doc markups

On Wed, Jul 13, 2022 at 09:12:15AM +0100, Mauro Carvalho Chehab wrote: > Building docs currently produces this warning: > > Documentation/foo/i915:159: > ./drivers/gpu/drm/i915/i915_scatterlist.h:73: WARNING: Inline strong > start-string without end-string. > > That's because @foo evaluat

Re: [Intel-gfx] [PATCH v2 22/39] drm/i915: stop using kernel-doc markups for something else

On Wed, Jul 13, 2022 at 09:12:10AM +0100, Mauro Carvalho Chehab wrote: > There are some occurrences of "/**" that aren't actually part of > a kernel-doc markup. Replace them by "/*", in order to make easier > to identify what i915 files contain kernel-doc markups. > > Signed-off-by: Mauro Carvalho

[Intel-gfx] [PATCH] drm/i915/guc: support v69 in parallel to v70

This patch re-introduces support for GuC v69 in parallel to v70. As this is a quick fix, v69 has been re-introduced as the single "fallback" guc version in case v70 is not available on disk. All v69 specific code has been labeled as such for easy identification, and the same was done for all v70 fu

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: stop HPD workers before display driver unregister (rev7)

== Series Details == Series: drm/i915/display: stop HPD workers before display driver unregister (rev7) URL : https://patchwork.freedesktop.org/series/105557/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes for damage clips handling

== Series Details == Series: Fixes for damage clips handling URL : https://patchwork.freedesktop.org/series/106388/ State : success == Summary == CI Bug Log - changes from CI_DRM_11900 -> Patchwork_106388v1 Summary --- **SUCCESS**

Re: [Intel-gfx] [v3] drm/i915/ttm: fix sg_table construction

On Mon, Jul 11, 2022 at 09:58:59AM +0100, Matthew Auld wrote: > If we encounter some monster sized local-memory page that exceeds the > maximum sg length (UINT32_MAX), ensure that don't end up with some > misaligned address in the entry that follows, leading to fireworks > later. Also ensure we hav

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Check for ct enabled while waiting for response (rev2)

== Series Details == Series: drm/i915/guc: Check for ct enabled while waiting for response (rev2) URL : https://patchwork.freedesktop.org/series/105258/ State : success == Summary == CI Bug Log - changes from CI_DRM_11900 -> Patchwork_105258v2 ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: More VBT stuff

== Series Details == Series: drm/i915: More VBT stuff URL : https://patchwork.freedesktop.org/series/106399/ State : success == Summary == CI Bug Log - changes from CI_DRM_11900 -> Patchwork_106399v1 Summary --- **SUCCESS** No reg

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: support v69 in parallel to v70

== Series Details == Series: drm/i915/guc: support v69 in parallel to v70 URL : https://patchwork.freedesktop.org/series/106406/ State : warning == Summary == Error: dim checkpatch failed ef841c4deadb drm/i915/guc: support v69 in parallel to v70 -:391: CHECK:PARENTHESIS_ALIGNMENT: Alignment sh

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/guc: support v69 in parallel to v70

== Series Details == Series: drm/i915/guc: support v69 in parallel to v70 URL : https://patchwork.freedesktop.org/series/106406/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: support v69 in parallel to v70

== Series Details == Series: drm/i915/guc: support v69 in parallel to v70 URL : https://patchwork.freedesktop.org/series/106406/ State : success == Summary == CI Bug Log - changes from CI_DRM_11900 -> Patchwork_106406v1 Summary --- *

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Check for ct enabled while waiting for response (rev2)

== Series Details == Series: drm/i915/guc: Check for ct enabled while waiting for response (rev2) URL : https://patchwork.freedesktop.org/series/105258/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11900_full -> Patchwork_105258v2_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: More VBT stuff

== Series Details == Series: drm/i915: More VBT stuff URL : https://patchwork.freedesktop.org/series/106399/ State : success == Summary == CI Bug Log - changes from CI_DRM_11900_full -> Patchwork_106399v1_full Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: support v69 in parallel to v70

== Series Details == Series: drm/i915/guc: support v69 in parallel to v70 URL : https://patchwork.freedesktop.org/series/106406/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11900_full -> Patchwork_106406v1_full Summary --