Re: [Intel-gfx] [PATCH 2/2] iosys-map: Add per-word write

2022-06-27 Thread Thomas Zimmermann
Hi Lucas Am 26.06.22 um 23:01 schrieb Lucas De Marchi: On Fri, Jun 17, 2022 at 01:52:04AM -0700, Lucas De Marchi wrote: Like was done for read, provide the equivalent for write. Even if current users are not in the hot path, this should future-proof it. v2:  - Remove default from _Generic() -

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend (rev3)

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend (rev3) URL : https://patchwork.freedesktop.org/series/103837/ State : success == Summary == CI Bug Log - changes from CI_DRM_11793_full -> Patchwork_103837v3_full

Re: [Intel-gfx] [PATCH] drm/i915: tweak the ordering in cpu_write_needs_clflush

2022-06-27 Thread Gwan-gyeong Mun
Thanks for fixing this issue. Looks good to me. Reviewed-by: Gwan-gyeong Mun On 6/22/22 6:59 PM, Matthew Auld wrote: For imported dma-buf objects we leave the object as cache_coherent = 0 across all platforms, which is reasonable given that have no clue what the memory underneath is, and its n

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-27 Thread Tvrtko Ursulin
On 24/06/2022 21:23, Zeng, Oak wrote: Let's compare "tlb invalidate at vm unbind" vs "tlb invalidate at backing storage": Correctness: consider this sequence of: 1. unbind va1 from pa1, 2. then bind va1 to pa2. //user space has the freedom to do this as it manages virtual address space 3. Su

Re: [Intel-gfx] [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-27 Thread Daniel Vetter
On Sat, Jun 25, 2022 at 12:02:19PM -0700, Niranjana Vishwanathapura wrote: > On Fri, Jun 24, 2022 at 10:07:26PM +0200, Daniel Vetter wrote: > > On Fri, Jun 24, 2022 at 10:49:36AM -0700, Niranjana Vishwanathapura wrote: > > > VM_BIND and related uapi definitions > > > > > > v2: Reduce the scope to

Re: [Intel-gfx] [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-27 Thread Daniel Vetter
On Sat, Jun 25, 2022 at 06:08:21PM -0700, Niranjana Vishwanathapura wrote: > On Sat, Jun 25, 2022 at 12:02:19PM -0700, Niranjana Vishwanathapura wrote: > > On Fri, Jun 24, 2022 at 10:07:26PM +0200, Daniel Vetter wrote: > > > On Fri, Jun 24, 2022 at 10:49:36AM -0700, Niranjana Vishwanathapura wrote:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: i915_irq - drop unexpected word "the" in the comments

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915: i915_irq - drop unexpected word "the" in the comments URL : https://patchwork.freedesktop.org/series/105477/ State : success == Summary == CI Bug Log - changes from CI_DRM_11794_full -> Patchwork_105477v1_full =

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsi: add payload receiving code (rev6)

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915/dsi: add payload receiving code (rev6) URL : https://patchwork.freedesktop.org/series/105096/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11794_full -> Patchwork_105096v6_full Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/edid: expand on struct drm_edid usage (rev4)

2022-06-27 Thread Patchwork
== Series Details == Series: drm/edid: expand on struct drm_edid usage (rev4) URL : https://patchwork.freedesktop.org/series/104309/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11794_full -> Patchwork_104309v4_full Summar

Re: [Intel-gfx] [PATCH v2 10/12] drm/i915/ttm: handle blitter failure on DG2

2022-06-27 Thread Matthew Auld
On Thu, 23 Jun 2022 at 16:31, Matthew Auld wrote: > > On 23/06/2022 15:52, Christian König wrote: > > Am 23.06.22 um 16:13 schrieb Matthew Auld: > >> [SNIP] > TTM_BO_VM_NUM_PREFAULT); > + /* > +* Ensure we check for any fatal errors if we had to >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Increase timeout for live_parallel_switch

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Increase timeout for live_parallel_switch URL : https://patchwork.freedesktop.org/series/105490/ State : success == Summary == CI Bug Log - changes from CI_DRM_11794_full -> Patchwork_105490v1_full ===

[Intel-gfx] [PATCH] drm/i915/dp: wait on timeout before retry

2022-06-27 Thread Arun R Murthy
On linktraining error/timeout before retry need to wait for 400usec as per the DP CTS spec1.2 The patch with commit id 74ebf294a1dd816bdc248ac733009a8915d59eb5 drm/i915: Add a delay in Displayport AUX transactions for compliance testing removes this delay mentioning the hardware already meets this

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: g4x/vlv/chv CxSR/wm fixes/cleanups (rev3)

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915: g4x/vlv/chv CxSR/wm fixes/cleanups (rev3) URL : https://patchwork.freedesktop.org/series/90164/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11794_full -> Patchwork_90164v3_full Summa

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: tweak the ordering in cpu_write_needs_clflush

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915: tweak the ordering in cpu_write_needs_clflush URL : https://patchwork.freedesktop.org/series/105503/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11795_full -> Patchwork_105503v1_full

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: tweak the ordering in cpu_write_needs_clflush

2022-06-27 Thread Matthew Auld
On Mon, 27 Jun 2022 at 12:49, Patchwork wrote: > > Patch Details > Series:drm/i915: tweak the ordering in cpu_write_needs_clflush > URL:https://patchwork.freedesktop.org/series/105503/ > State:failure > Details:https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105503v1/index.html > > CI Bug Log -

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dgfx: Disable d3cold Correctly (rev2)

2022-06-27 Thread Anshuman Gupta
On 2022-06-17 at 00:16:25 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dgfx: Disable d3cold Correctly (rev2) > URL : https://patchwork.freedesktop.org/series/104770/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11768_full -> Patchwork_104770v2

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dg2: Add performance workaround 18019455067

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add performance workaround 18019455067 URL : https://patchwork.freedesktop.org/series/105512/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11795_full -> Patchwork_105512v1_full Su

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc/slpc: Use non-blocking H2G for waitboost (rev3)

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Use non-blocking H2G for waitboost (rev3) URL : https://patchwork.freedesktop.org/series/103598/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11795_full -> Patchwork_103598v3_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Don't update engine busyness stats too frequently

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915/guc: Don't update engine busyness stats too frequently URL : https://patchwork.freedesktop.org/series/105525/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11795_full -> Patchwork_105525v1_full =

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Increase timeout for live_parallel_switch (rev2)

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Increase timeout for live_parallel_switch (rev2) URL : https://patchwork.freedesktop.org/series/105490/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11795_full -> Patchwork_105490v2_full

[Intel-gfx] [PATCH v2] drm/i915/dg2: Add performance workaround 18019455067

2022-06-27 Thread Lionel Landwerlin
The recommended number of stackIDs for Ray Tracing subsystem is 512 rather than 2048 (default HW programming). v2: Move the programming to dg2_ctx_gt_tuning_init() (Lucas) Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 4 drivers/gpu/drm/i915/gt/intel_wo

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/edid: expand on struct drm_edid usage (rev6)

2022-06-27 Thread Patchwork
== Series Details == Series: drm/edid: expand on struct drm_edid usage (rev6) URL : https://patchwork.freedesktop.org/series/104309/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11795_full -> Patchwork_104309v6_full Summar

Re: [Intel-gfx] [PATCH v3 13/14] mei: debugfs: add pxp mode to devstate in debugfs

2022-06-27 Thread Greg Kroah-Hartman
On Sun, Jun 19, 2022 at 04:37:20PM +0300, Alexander Usyskin wrote: > From: Tomas Winkler > > CC: Vitaly Lubart > Signed-off-by: Tomas Winkler We can not take patches without any changelog text, you know this :( > --- > drivers/misc/mei/debugfs.c | 17 + > 1 file changed, 17 i

Re: [Intel-gfx] [PATCH v3 00/14] GSC support for XeHP SDV and DG2 platforms

2022-06-27 Thread Greg Kroah-Hartman
On Sun, Jun 19, 2022 at 04:37:07PM +0300, Alexander Usyskin wrote: > Add GSC support for XeHP SDV and DG2 platforms. > > The series includes changes for the mei driver: > - add ability to use polling instead of interrupts > - add ability to use extended timeouts > - setup extended operational memo

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Display info cleanup

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915: Display info cleanup URL : https://patchwork.freedesktop.org/series/105544/ State : success == Summary == CI Bug Log - changes from CI_DRM_11797_full -> Patchwork_105544v1_full Summary --- **WAR

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/fourcc: Document the Intel CCS modifiers' CC plane expected pitch

2022-06-27 Thread Patchwork
== Series Details == Series: drm/fourcc: Document the Intel CCS modifiers' CC plane expected pitch URL : https://patchwork.freedesktop.org/series/105550/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11799_full -> Patchwork_105550v1_full ===

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: stop HPD workers before display driver unregister

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915/display: stop HPD workers before display driver unregister URL : https://patchwork.freedesktop.org/series/105557/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11799_full -> Patchwork_105557v1_full =

[Intel-gfx] [PATCH i-g-t 1/3] tests/i915/gem_eio: fix uaf

2022-06-27 Thread Matthew Auld
../tests/i915/gem_eio.c:277:20: warning: pointer ‘ctx’ used after ‘free’ [-Wuse-after-free] 277 | igt_assert(igt_sysfs_printf(ctx->debugfs, "i915_drop_caches", ../lib/igt_core.h:667:20: note: in definition of macro ‘igt_assert’ 667 | do { if (!(expr)) \ |

[Intel-gfx] [PATCH i-g-t 3/3] tests/i915: adapt __copy_ccs for discrete

2022-06-27 Thread Matthew Auld
We can't explicitly control the mmap caching type for discrete, but using mmap_device_coherent should be good enough here on such devices. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4842 Signed-off-by: Matthew Auld Cc: Gwan-gyeong Mun --- lib/intel_bufops.c | 15 ++-

[Intel-gfx] [PATCH i-g-t 2/3] tests/i915/kms_mmap_write_crc: handle missing gem_get_caching()

2022-06-27 Thread Matthew Auld
The kernel is meant to force the caching level for the object to CACHE_NONE or CACHE_WT when first scanning out the object, since the display engine is not coherent (assuming userspace hasn't already done this). On discrete we no longer support set/get_caching, but we can only do the scanout from l

Re: [Intel-gfx] [PATCH v6 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-27 Thread Daniel Vetter
On Sat, Jun 25, 2022 at 06:49:14PM -0700, Niranjana Vishwanathapura wrote: > VM_BIND design document with description of intended use cases. > > v2: Reduce the scope to simple Mesa use case. > v3: Expand documentation on dma-resv usage, TLB flushing and > execbuf3. > v4: Remove vm_bind tlb flu

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Don't update engine busyness stats too frequently

2022-06-27 Thread Teres Alexis, Alan Previn
WRT possible new issues below, the patches i made does not impact any display or even execution operation. Unfortunately, i cant seem to access the "possible regression" failure below. Additionally, GuC is not supported on SKL. thus we can safely ignore these. On Mon, 2022-06-27 at 12:47 +,

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen (rev5)

2022-06-27 Thread Robert Beckett
On 22/06/2022 10:05, Tvrtko Ursulin wrote: On 21/06/2022 20:11, Robert Beckett wrote: On 21/06/2022 18:37, Patchwork wrote: *Patch Details* *Series:*    drm/i915: ttm for stolen (rev5) *URL:*    https://patchwork.freedesktop.org/series/101396/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix a lockdep warning at error capture (rev2)

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915: Fix a lockdep warning at error capture (rev2) URL : https://patchwork.freedesktop.org/series/105291/ State : success == Summary == CI Bug Log - changes from CI_DRM_11803 -> Patchwork_105291v2 Summary -

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Do not access rq->engine without a reference

2022-06-27 Thread Matthew Brost
On Wed, Jun 15, 2022 at 12:13:46AM +0530, Ramalingam C wrote: > From: Niranjana Vishwanathapura > > In i915_fence_get_driver_name(), user may not hold a > reference to rq->engine. Hence do not access it. Instead, > store required device private pointer in 'rq->i915' and use it. > > Signed-off-by

Re: [Intel-gfx] [PATCH 2/3] Revert "drm/i915: Hold reference to intel_context over life of i915_request"

2022-06-27 Thread Matthew Brost
On Wed, Jun 15, 2022 at 12:13:47AM +0530, Ramalingam C wrote: > From: Niranjana Vishwanathapura > > This reverts commit 1e98d8c52ed5dfbaf273c4423c636525c2ce59e7. > > The problem with this patch is that it makes i915_request to hold a > reference to intel_context, which in turn holds a reference

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Do not use reserved requests for virtual engines

2022-06-27 Thread Matthew Brost
On Wed, Jun 15, 2022 at 12:13:48AM +0530, Ramalingam C wrote: > Do not use reserved requests for virtual engines as this is only > needed for kernel contexts. > > Signed-off-by: Ramalingam C > Suggested-by: Matthew Brost With the patch squashed into the previous patch: Reviewed-by: Matthew Bros

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: tweak the ordering in cpu_write_needs_clflush

2022-06-27 Thread Vudum, Lakshminarayana
Issue is related to https://gitlab.freedesktop.org/drm/intel/-/issues/2346 igt@kms_cursor_legacy@flip-vs-cursor - fail - Failed assertion: kmstest_get_vblank(display->drm_fd, pipe, 0) == vblank_start|Failed assertion: kmstest_get_vblank(display->drm_fd, pipe, 0) <= vblank_start + 1 Thanks, Laksh

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Do not use reserved requests for virtual engines

2022-06-27 Thread Ramalingam C
On 2022-06-27 at 10:18:59 -0700, Matthew Brost wrote: > On Wed, Jun 15, 2022 at 12:13:48AM +0530, Ramalingam C wrote: > > Do not use reserved requests for virtual engines as this is only > > needed for kernel contexts. > > > > Signed-off-by: Ramalingam C > > Suggested-by: Matthew Brost > > With

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/doc/rfc: i915 VM_BIND feature design + uapi

2022-06-27 Thread Patchwork
== Series Details == Series: drm/doc/rfc: i915 VM_BIND feature design + uapi URL : https://patchwork.freedesktop.org/series/105577/ State : success == Summary == CI Bug Log - changes from CI_DRM_11802_full -> Patchwork_105577v1_full Summary

[Intel-gfx] [PATCH] drm/i915/gt: handle null ptr at sg traversing

2022-06-27 Thread Ramalingam C
When calculating the starting address for ccs data in smem scatterlist, handle the NULL pointer returned from sg_next, incase of scatterlist less than required size.. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 13 ++--- 1 file changed, 10 insertions(+), 3 d

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix error code in icl_compute_combo_phy_dpll()

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915: Fix error code in icl_compute_combo_phy_dpll() URL : https://patchwork.freedesktop.org/series/105583/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11802_full -> Patchwork_105583v1_full

Re: [Intel-gfx] [PATCH][next] treewide: uapi: Replace zero-length arrays with flexible-array members

2022-06-27 Thread Daniel Borkmann
On 6/27/22 8:04 PM, Gustavo A. R. Silva wrote: There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-le

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-27 Thread Zeng, Oak
Thanks, Oak > -Original Message- > From: Tvrtko Ursulin > Sent: June 27, 2022 4:30 AM > To: Zeng, Oak ; Landwerlin, Lionel G > ; Vishwanathapura, Niranjana > > Cc: Zanoni, Paulo R ; intel- > g...@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Hellstrom, > Thomas ; Wilson, Chri

Re: [Intel-gfx] [PATCH][next] treewide: uapi: Replace zero-length arrays with flexible-array members

2022-06-27 Thread Stephen Hemminger
On Mon, 27 Jun 2022 20:04:32 +0200 "Gustavo A. R. Silva" wrote: > There is a regular need in the kernel to provide a way to declare > having a dynamically sized set of trailing elements in a structure. > Kernel code should always use “flexible array members”[1] for these > cases. The older style

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: fix subtraction overflow bug

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix subtraction overflow bug URL : https://patchwork.freedesktop.org/series/105597/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11803_full -> Patchwork_105597v1_full Summar

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: i915: fix a possible refcount leak in intel_dp_add_mst_connector()

2022-06-27 Thread Patchwork
== Series Details == Series: drm: i915: fix a possible refcount leak in intel_dp_add_mst_connector() URL : https://patchwork.freedesktop.org/series/105601/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11803_full -> Patchwork_105601v1_full =

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Correct duplicated/misplaced GT register definitions

2022-06-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Correct duplicated/misplaced GT register definitions URL : https://patchwork.freedesktop.org/series/105619/ State : success == Summary == CI Bug Log - changes from CI_DRM_11805_full -> Patchwork_105619v1_full ==

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/doc/rfc: i915 VM_BIND feature design + uapi

2022-06-27 Thread Patchwork
== Series Details == Series: drm/doc/rfc: i915 VM_BIND feature design + uapi URL : https://patchwork.freedesktop.org/series/105635/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11805_full -> Patchwork_105635v1_full Summary

Re: [Intel-gfx] [PATCH][next] treewide: uapi: Replace zero-length arrays with flexible-array members

2022-06-27 Thread Dan Williams
Gustavo A. R. Silva wrote: > There is a regular need in the kernel to provide a way to declare > having a dynamically sized set of trailing elements in a structure. > Kernel code should always use “flexible array members”[1] for these > cases. The older style of one-element or zero-length arrays sh

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: stop HPD workers before display driver unregister

2022-06-27 Thread Andrzej Hajda
On 27.06.2022 18:00, Patchwork wrote: *Patch Details* *Series:* drm/i915/display: stop HPD workers before display driver unregister *URL:* https://patchwork.freedesktop.org/series/105557/ *State:*failure *Details:* https://intel-gfx-c

[Intel-gfx] [CI 1/2] iosys-map: Add per-word read

2022-06-27 Thread Lucas De Marchi
Instead of always falling back to memcpy_fromio() for any size, prefer using read{b,w,l}(). When reading struct members it's common to read individual integer variables individually. Going through memcpy_fromio() for each of them poses a high penalty. Employ a similar trick as __seqprop() by using

[Intel-gfx] [CI 2/2] iosys-map: Add per-word write

2022-06-27 Thread Lucas De Marchi
Like was done for read, provide the equivalent for write. Even if current users are not in the hot path, this should future-proof it. v2: - Remove default from _Generic() - callers wanting to write more than u64 should use iosys_map_memcpy_to() - Add WRITE_ONCE() cases dereferencing the po

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-27 Thread Belgaumkar, Vinay
On 6/24/2022 8:59 PM, Dixit, Ashutosh wrote: On Thu, 23 Jun 2022 16:33:20 -0700, Vinay Belgaumkar wrote: +static int max_granted_freq(struct intel_guc_slpc *slpc, struct intel_rps *rps, u32 *max_act_freq) +{ + struct intel_gt *gt = rps_to_gt(rps); + u32 perf_limit_reasons; +

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-27 Thread Belgaumkar, Vinay
On 6/24/2022 8:59 PM, Dixit, Ashutosh wrote: On Thu, 23 Jun 2022 16:21:46 -0700, Belgaumkar, Vinay wrote: On 6/22/2022 1:32 PM, Dixit, Ashutosh wrote: On Fri, 10 Jun 2022 16:47:12 -0700, Vinay Belgaumkar wrote: This test will validate we can achieve actual frequency of RP0. Pcode grants freq

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-27 Thread Belgaumkar, Vinay
On 6/24/2022 8:59 PM, Dixit, Ashutosh wrote: On Thu, 23 Jun 2022 16:33:20 -0700, Vinay Belgaumkar wrote: +static int max_granted_freq(struct intel_guc_slpc *slpc, struct intel_rps *rps, u32 *max_act_freq) +{ + struct intel_gt *gt = rps_to_gt(rps); + u32 perf_limit_reasons; +

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-27 Thread Vinay Belgaumkar
This test will validate we can achieve actual frequency of RP0. Pcode grants frequencies based on what GuC is requesting. However, thermal throttling can limit what is being granted. Add a test to request for max, but don't fail the test if RP0 is not granted due to throttle reasons. Also optimize

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: tweak the ordering in cpu_write_needs_clflush

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915: tweak the ordering in cpu_write_needs_clflush URL : https://patchwork.freedesktop.org/series/105503/ State : success == Summary == CI Bug Log - changes from CI_DRM_11795_full -> Patchwork_105503v1_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: wait on timeout before retry

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915/dp: wait on timeout before retry URL : https://patchwork.freedesktop.org/series/105660/ State : warning == Summary == Error: dim checkpatch failed 642e16d10d1e drm/i915/dp: wait on timeout before retry -:9: ERROR:GIT_COMMIT_ID: Please use git commit descri

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915/dp: wait on timeout before retry URL : https://patchwork.freedesktop.org/series/105660/ State : success == Summary == CI Bug Log - changes from CI_DRM_11816 -> Patchwork_105660v1 Summary --- **SU

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg2: Add performance workaround 18019455067 (rev2)

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add performance workaround 18019455067 (rev2) URL : https://patchwork.freedesktop.org/series/105512/ State : success == Summary == CI Bug Log - changes from CI_DRM_11816 -> Patchwork_105512v2 Summa

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix a lockdep warning at error capture (rev2)

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915: Fix a lockdep warning at error capture (rev2) URL : https://patchwork.freedesktop.org/series/105291/ State : success == Summary == CI Bug Log - changes from CI_DRM_11803_full -> Patchwork_105291v2_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: handle null ptr at sg traversing

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915/gt: handle null ptr at sg traversing URL : https://patchwork.freedesktop.org/series/105683/ State : success == Summary == CI Bug Log - changes from CI_DRM_11816 -> Patchwork_105683v1 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: ADL-N should use the same GuC FW as ADL-S (rev2)

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915/guc: ADL-N should use the same GuC FW as ADL-S (rev2) URL : https://patchwork.freedesktop.org/series/105444/ State : success == Summary == CI Bug Log - changes from CI_DRM_11816 -> Patchwork_105444v2 Su

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] iosys-map: Add per-word read

2022-06-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] iosys-map: Add per-word read URL : https://patchwork.freedesktop.org/series/105692/ State : warning == Summary == Error: dim checkpatch failed e6ff19d2ffd3 iosys-map: Add per-word read -:88: ERROR:SPACING: spaces required around that '

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] iosys-map: Add per-word read

2022-06-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] iosys-map: Add per-word read URL : https://patchwork.freedesktop.org/series/105692/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] iosys-map: Add per-word read

2022-06-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] iosys-map: Add per-word read URL : https://patchwork.freedesktop.org/series/105692/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11816 -> Patchwork_105692v1 Summar

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-27 Thread Dixit, Ashutosh
On Mon, 27 Jun 2022 16:03:46 -0700, Vinay Belgaumkar wrote: > > /* Actual frequency should rise above min */ > - if (max_act_freq == slpc_min_freq) { > + if (max_act_freq <= slpc_min_freq) { > pr_err("Actual freq did not rise above min\n")

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc/slpc: Add a new SLPC selftest (rev4)

2022-06-27 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Add a new SLPC selftest (rev4) URL : https://patchwork.freedesktop.org/series/105005/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11816 -> Patchwork_105005v4 Summary ---

[Intel-gfx] [Intel-gfx 2/2] drm/i915/guc: Add delay to disable scheduling after pin count goes to zero

2022-06-27 Thread Alan Previn
From: Matthew Brost Add a delay, configurable via debugs (default 100ms), to disable scheduling of a context after the pin count goes to zero. Disable scheduling is somewhat costly operation so the idea is a delay allows the resubmit something before doing this operation. This delay is only done

[Intel-gfx] [Intel-gfx 1/2] drm/i915/selftests: Use correct selfest calls for live tests

2022-06-27 Thread Alan Previn
From: Matthew Brost This will help in an upcoming patch where the live selftest wrappers are extended to do more. Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c | 2 +- drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c| 2 +- drivers/gpu/drm/i91

[Intel-gfx] [Intel-gfx 0/2] Delay disabling scheduling on a context

2022-06-27 Thread Alan Previn
This is a revival of the same series posted by Matthew Brost back in October 2021 (https://patchwork.freedesktop.org/series/96167/). Additional real world measured metrics is included this time around that has proven the effectiveness of this series. This series adds a delay before disabling sched

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] iosys-map: Add per-word read (rev2)

2022-06-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] iosys-map: Add per-word read (rev2) URL : https://patchwork.freedesktop.org/series/105692/ State : warning == Summary == Error: dim checkpatch failed 40dfd8d9e7ab iosys-map: Add per-word read -:88: ERROR:SPACING: spaces required around

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] iosys-map: Add per-word read (rev2)

2022-06-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] iosys-map: Add per-word read (rev2) URL : https://patchwork.freedesktop.org/series/105692/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] iosys-map: Add per-word read (rev2)

2022-06-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] iosys-map: Add per-word read (rev2) URL : https://patchwork.freedesktop.org/series/105692/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11816 -> Patchwork_105692v2