Re: [Intel-gfx] [PATCH] drm/i915/gem: Flush TLBs for all the tiles

2022-05-11 Thread Tvrtko Ursulin
On 10/05/2022 21:33, Andi Shyti wrote: During object cleanup we invalidate the TLBs but we do it only for gt0. Invalidate the caches for all the tiles. Reported-by: Chris Wilson Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 11 --- 1 file changed, 8 ins

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dmc: Add MMIO range restrictions

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Add MMIO range restrictions URL : https://patchwork.freedesktop.org/series/103844/ State : success == Summary == CI Bug Log - changes from CI_DRM_11631_full -> Patchwork_103844v1_full Summary -

Re: [Intel-gfx] [PATCH 16/16] drm/i915: Drop display.has_fpga_db from device info

2022-05-11 Thread Tvrtko Ursulin
On 10/05/2022 08:41, Jani Nikula wrote: On Tue, 10 May 2022, Joonas Lahtinen wrote: Quoting Souza, Jose (2022-05-09 17:19:28) On Mon, 2022-05-09 at 15:38 +0300, Joonas Lahtinen wrote: Quoting José Roberto de Souza (2022-05-07 16:28:50) No need to have this parameter in intel_device_info st

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-05-11 Thread Tvrtko Ursulin
On 11/05/2022 06:26, Dixit, Ashutosh wrote: On Tue, 10 May 2022 00:43:29 -0700, Jani Nikula wrote: On Tue, 10 May 2022, Tvrtko Ursulin wrote: On 29/04/2022 20:56, Ashutosh Dixit wrote: diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c index 90b0ce5051af..

Re: [Intel-gfx] [PATCH v4 1/3] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-05-11 Thread Tvrtko Ursulin
On 11/05/2022 02:11, Andi Shyti wrote: From: Chris Wilson As an extension of the current skip TLB invalidations if the device is powered down, we recognised that prior to any engine activity, all the TLBs are explicitly invalidated. Thus anytime we know the engine is asleep, we can skip inval

[Intel-gfx] [PATCH] drm/i915/dg2: Support 4k@30 on HDMI

2022-05-11 Thread Ankit Nautiyal
From: Vandita Kulkarni This patch adds a fix to support 297MHz of dot clock by calculating the pll values using synopsis algorithm. This will help to support 4k@30 mode for HDMI monitors on DG2. Signed-off-by: Vandita Kulkarni Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/int

Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix use of static in macro mismatch

2022-05-11 Thread Jani Nikula
On Tue, 10 May 2022, Andi Shyti wrote: > The INTEL_GT_RPS_SYSFS_ATTR was creating to different structures > but. When called with the "static" keyword this is affecting only > the first structure, while the second is created as non static. > > Move the static keyword inside the macros to affect bo

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg2: Support 4k@30 on HDMI

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Support 4k@30 on HDMI URL : https://patchwork.freedesktop.org/series/103862/ State : success == Summary == CI Bug Log - changes from CI_DRM_11634 -> Patchwork_103862v1 Summary --- **SUCCESS*

[Intel-gfx] [PATCH v3] drm/edid: keep propagating drm_edid to display info

2022-05-11 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v3: Update comment to refer to update_display_info() (Ankit) v2: Use drm_edid_legacy_init() Signed-off-by: Jani Nikula Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/drm_edid.c | 50 +++--- 1 file changed, 30 insert

[Intel-gfx] [PATCH v3] drm/edid: propagate drm_edid to drm_edid_to_eld()

2022-05-11 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v3: Rebase Signed-off-by: Jani Nikula Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/drm_edid.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[Intel-gfx] [PATCH v3] drm/edid: convert drm_edid_connector_update() to drm_edid fully

2022-05-11 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v3: s/edid/drm_edid/ in comment too (Ankit) Signed-off-by: Jani Nikula Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/drm_edid.c | 97 ++ 1 file changed, 47 insertions(+), 50 deletions(-) diff --git a/drivers/gp

[Intel-gfx] [PATCH] drm/i915/uc: remove accidental static from a local variable

2022-05-11 Thread Jani Nikula
The arrays are static const, but the pointer shouldn't be static. Fixes: 3d832f370d16 ("drm/i915/uc: Allow platforms to have GuC but not HuC") Cc: John Harrison Cc: Lucas De Marchi Cc: Daniele Ceraolo Spurio Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 2 +- 1 fil

Re: [Intel-gfx] [PATCH 1/4] drm/i915: add gen6 ppgtt dummy creation function

2022-05-11 Thread Thomas Hellström
Hi, On Tue, 2022-05-03 at 19:13 +, Robert Beckett wrote: > Internal gem objects will soon just be volatile system memory region > objects. > To enable this, create a separate dummy object creation function > for gen6 ppgtt It's not clear from the commit message why we need a special case for

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid: introduce struct drm_edid (rev6)

2022-05-11 Thread Patchwork
== Series Details == Series: drm/edid: introduce struct drm_edid (rev6) URL : https://patchwork.freedesktop.org/series/103665/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./drivers/gpu/drm/amd/amdgpu/

[Intel-gfx] [RFC PATCH] drm/i915: don't treat small BAR as an error with CSS

2022-05-11 Thread Nirmoy Das
Determine lmem_size using ADDR_RANGE register so that module load on platfrom with small bar with css works. Signed-off-by: Nirmoy Das --- I once reserved a dg2 machine with small bar and module load failed on it. I can't find that machine anymore hence sending this as RFC. drivers/gpu/drm/i91

Re: [Intel-gfx] [RFC PATCH] drm/i915: don't treat small BAR as an error with CSS

2022-05-11 Thread Das, Nirmoy
+Ram (git send-email didn't add Ram to the cc list for some reason) On 5/11/2022 12:25 PM, Nirmoy Das wrote: Determine lmem_size using ADDR_RANGE register so that module load on platfrom with small bar with css works. Signed-off-by: Nirmoy Das --- I once reserved a dg2 machine with small bar

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: Add smem fallback allocation for dpt

2022-05-11 Thread Matthew Auld
On Fri, 6 May 2022 at 14:11, Juha-Pekka Heikkila wrote: > > Add fallback smem allocation for dpt if stolen memory allocation failed. > > Signed-off-by: Juha-Pekka Heikkila > --- > drivers/gpu/drm/i915/display/intel_dpt.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: introduce struct drm_edid (rev6)

2022-05-11 Thread Patchwork
== Series Details == Series: drm/edid: introduce struct drm_edid (rev6) URL : https://patchwork.freedesktop.org/series/103665/ State : success == Summary == CI Bug Log - changes from CI_DRM_11635 -> Patchwork_103665v6 Summary --- **S

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix i915_vma_pin_iomap()

2022-05-11 Thread Matthew Auld
On Fri, 6 May 2022 at 14:11, Juha-Pekka Heikkila wrote: > > From: CQ Tang > > Display might allocate a smem object and call > i915_vma_pin_iomap(), the existing code will fail. > > This fix was suggested by Chris P Wilson, that we pin > the smem with i915_gem_object_pin_map_unlocked(). > > Signed

Re: [Intel-gfx] [PATCH 2/4] drm/i915: setup ggtt scratch page after memory regions

2022-05-11 Thread Thomas Hellström
On Tue, 2022-05-03 at 19:13 +, Robert Beckett wrote: > reorder scratch page allocation so that memory regions are available Nit: s/reorder/Reorder/ Reviewed-by: Thomas Hellström > to allocate the buffers > > Signed-off-by: Robert Beckett > --- >  drivers/gpu/drm/i915/gt/intel_gt_gmch.c |

Re: [Intel-gfx] [RFC PATCH] drm/i915: don't treat small BAR as an error with CSS

2022-05-11 Thread Matthew Auld
On Wed, 11 May 2022 at 11:25, Nirmoy Das wrote: > > Determine lmem_size using ADDR_RANGE register so that module > load on platfrom with small bar with css works. > > Signed-off-by: Nirmoy Das > --- > I once reserved a dg2 machine with small bar and module load failed on > it. I can't find that

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/uc: remove accidental static from a local variable

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915/uc: remove accidental static from a local variable URL : https://patchwork.freedesktop.org/series/103866/ State : success == Summary == CI Bug Log - changes from CI_DRM_11635 -> Patchwork_103866v1 Summa

[Intel-gfx] [PATCH] drm/i915: Use i915_gem_object_ggtt_pin_ww for reloc_iomap

2022-05-11 Thread Maarten Lankhorst
Instead of its own path, use the common path when it doesn't result in evicting any vma. This fixes the case where we don't wait for binding. Fixes: b5cfe6f7a6e1 ("drm/i915: Remove short-term pins from execbuf, v6.") Cc: Matthew Auld Reported-by: Mateusz Jończyk Tested-by: Hans de Goede Signed-

[Intel-gfx] [PATCH i-g-t 0/8] Vendor agnostic gputop

2022-05-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This is a pile of patches which implements a rudimentary vendor agnostic gputop tool based of the new DRM spec as documented in Documentation/gpu/drm-usage-stats.rst. First part of the series is code refactoring which should be reasonably stable. I've tested it all while wor

[Intel-gfx] [PATCH i-g-t 1/8] lib: Extract igt_drm_clients from intel_gpu_top

2022-05-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Code movement with some improvements to prepare for further work in making a vendor agnostic gputop tool possible. Signed-off-by: Tvrtko Ursulin --- lib/igt_drm_clients.c | 426 ++ lib/igt_drm_clients.h | 85 +++ lib/meson.build |

[Intel-gfx] [PATCH i-g-t 2/8] libdrmfdinfo: Allow specifying custom engine map

2022-05-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Instead of hard coding the engine names, allow a map of names to indices to either be passed in or it gets auto-detected (less efficient) while parsing. Signed-off-by: Tvrtko Ursulin --- lib/igt_drm_clients.c | 18 +--- lib/igt_drm_clients.h | 3 ++- lib/i

[Intel-gfx] [PATCH i-g-t 3/8] libdrmclients: Record client drm minor

2022-05-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Prepare for supporting clients belonging to multiple DRM cards by storing the DRM minor in the client record. Signed-off-by: Tvrtko Ursulin --- lib/igt_drm_clients.c | 22 ++ lib/igt_drm_clients.h | 1 + 2 files changed, 15 insertions(+), 8 deletions(-

[Intel-gfx] [PATCH i-g-t 4/8] libdrmclient: Support multiple DRM cards

2022-05-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Require DRM minor match during client lookup. Signed-off-by: Tvrtko Ursulin --- lib/igt_drm_clients.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/igt_drm_clients.c b/lib/igt_drm_clients.c index 7defa464e76b..331e511b2f93 100644 --

[Intel-gfx] [PATCH i-g-t 6/8] libdrmclient/intel_gpu_top: Decouple hardcoded engine assumptions

2022-05-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Intel_gpu_top gets it's main engine configuration data via PMU probe and uses that for per client view as well. Furthemore code so far assumed only clients belonging from a single DRM card would be tracked in a single clients list. Break this inter-dependency by moving the e

[Intel-gfx] [PATCH i-g-t 5/8] libdrmfdinfo: Track largest engine index

2022-05-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Prep code for incoming work. Signed-off-by: Tvrtko Ursulin --- lib/igt_drm_fdinfo.c | 2 ++ lib/igt_drm_fdinfo.h | 1 + 2 files changed, 3 insertions(+) diff --git a/lib/igt_drm_fdinfo.c b/lib/igt_drm_fdinfo.c index 9b5c81a9b68d..f056b1a14b0e 100644 --- a/lib/igt_drm_fdin

[Intel-gfx] [PATCH i-g-t 8/8] gputop: Basic vendor agnostic GPU top tool

2022-05-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Rudimentary vendor agnostic example of how lib_igt_drm_clients can be used to display a sorted by card and usage list of processes using GPUs. Borrows a bit of code from intel_gpu_top but for now omits the fancy features like interactive functionality, card selection, client

[Intel-gfx] [PATCH i-g-t 7/8] libdrmclient: Enforce client status sort order in the library

2022-05-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Some libdrmclient operations require that inactive clients are last in the list. Rather than relying on callers of the library sort routine to implement their comparison callbacks correctly, enforce this order directly in the library and let callers comparison callbacks conce

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: don't treat small BAR as an error with CSS

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915: don't treat small BAR as an error with CSS URL : https://patchwork.freedesktop.org/series/103867/ State : warning == Summary == Error: dim checkpatch failed 580b5f7f0029 drm/i915: don't treat small BAR as an error with CSS -:7: WARNING:TYPO_SPELLING: 'pla

Re: [Intel-gfx] [RFC PATCH] drm/i915: don't treat small BAR as an error with CSS

2022-05-11 Thread Das, Nirmoy
On 5/11/2022 1:31 PM, Matthew Auld wrote: On Wed, 11 May 2022 at 11:25, Nirmoy Das wrote: Determine lmem_size using ADDR_RANGE register so that module load on platfrom with small bar with css works. Signed-off-by: Nirmoy Das --- I once reserved a dg2 machine with small bar and module load

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dg2: Support 4k@30 on HDMI

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Support 4k@30 on HDMI URL : https://patchwork.freedesktop.org/series/103862/ State : success == Summary == CI Bug Log - changes from CI_DRM_11634_full -> Patchwork_103862v1_full Summary ---

Re: [Intel-gfx] [PATCH 3/4] drm/i915: allow volatile buffers to use ttm pool allocator

2022-05-11 Thread Thomas Hellström
Hi, Bob, On Tue, 2022-05-03 at 19:13 +, Robert Beckett wrote: > internal buffers should be shmem backed. > if a volatile buffer is requested, allow ttm to use the pool > allocator > to provide volatile pages as backing > > Signed-off-by: Robert Beckett > --- >  drivers/gpu/drm/i915/gem/i915_

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: don't treat small BAR as an error with CSS

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915: don't treat small BAR as an error with CSS URL : https://patchwork.freedesktop.org/series/103867/ State : success == Summary == CI Bug Log - changes from CI_DRM_11635 -> Patchwork_103867v1 Summary

[Intel-gfx] [PATCH] drm/i915: Use drm_dbg for rpm logging

2022-05-11 Thread Anshuman Gupta
RPM suspend/resume also supported on gfx platforms which doesn't have kms support and even on platforms without any connected display panel. There is no good reason to log rpm suspend/resume debug message with drm_dbg_kms() therefore changing it to drm_dbg(). Signed-off-by: Anshuman Gupta --- dr

[Intel-gfx] [PATCH v5] drm/i915/display: disable HPD workers before display driver unregister

2022-05-11 Thread Andrzej Hajda
Handling HPD during driver removal is pointless, and can cause different use-after-free/concurrency issues: 1. Setup of deferred fbdev after fbdev unregistration. 2. Access to DP-AUX after DP-AUX removal. Below stacktraces of both cases observed on CI: [272.634530] general protection fault, proba

Re: [Intel-gfx] [PATCH 16/16] drm/i915: Drop display.has_fpga_db from device info

2022-05-11 Thread Souza, Jose
On Wed, 2022-05-11 at 08:39 +0100, Tvrtko Ursulin wrote: > On 10/05/2022 08:41, Jani Nikula wrote: > > On Tue, 10 May 2022, Joonas Lahtinen > > wrote: > > > Quoting Souza, Jose (2022-05-09 17:19:28) > > > > On Mon, 2022-05-09 at 15:38 +0300, Joonas Lahtinen wrote: > > > > > Quoting José Roberto d

Re: [Intel-gfx] [PATCH 4/4] drm/i915: internal buffers use ttm backend

2022-05-11 Thread Thomas Hellström
On Tue, 2022-05-03 at 19:13 +, Robert Beckett wrote: > refactor internal buffer backend to allocate volatile pages via > ttm pool allocator > > Signed-off-by: Robert Beckett > --- >  drivers/gpu/drm/i915/gem/i915_gem_internal.c | 264 - > -- >  drivers/gpu/drm/i915/gem/i915_gem

Re: [Intel-gfx] [RFC PATCH] drm/i915: don't treat small BAR as an error with CSS

2022-05-11 Thread Matthew Auld
On Wed, 11 May 2022 at 13:34, Das, Nirmoy wrote: > > > On 5/11/2022 1:31 PM, Matthew Auld wrote: > > On Wed, 11 May 2022 at 11:25, Nirmoy Das wrote: > >> Determine lmem_size using ADDR_RANGE register so that module > >> load on platfrom with small bar with css works. > >> > >> Signed-off-by: Nir

[Intel-gfx] [PATCH] drm/i915: Enable Tile4 tiling mode

2022-05-11 Thread Nirmoy Das
From: Bommu Krishnaiah Enable Tile4 tiling mode on platform that supports Tile4 but no TileY like DG2. Signed-off-by: Bommu Krishnaiah Co-developed-by: Nirmoy Das Signed-off-by: Nirmoy Das --- .../i915/gem/selftests/i915_gem_client_blt.c | 238 ++ drivers/gpu/drm/i915/gt/int

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use i915_gem_object_ggtt_pin_ww for reloc_iomap

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915: Use i915_gem_object_ggtt_pin_ww for reloc_iomap URL : https://patchwork.freedesktop.org/series/103874/ State : success == Summary == CI Bug Log - changes from CI_DRM_11636 -> Patchwork_103874v1 Summary

Re: [Intel-gfx] [PATCH] drm/i915: Enable Tile4 tiling mode

2022-05-11 Thread Das, Nirmoy
This also: Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5879 On 5/11/2022 4:22 PM, Nirmoy Das wrote: From: Bommu Krishnaiah Enable Tile4 tiling mode on platform that supports Tile4 but no TileY like DG2. Signed-off-by: Bommu Krishnaiah Co-developed-by: Nirmoy Das Signed-off-by

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/edid: introduce struct drm_edid (rev6)

2022-05-11 Thread Patchwork
== Series Details == Series: drm/edid: introduce struct drm_edid (rev6) URL : https://patchwork.freedesktop.org/series/103665/ State : success == Summary == CI Bug Log - changes from CI_DRM_11635_full -> Patchwork_103665v6_full Summary

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for i915: Introduce Ponte Vecchio (rev4)

2022-05-11 Thread Matt Roper
On Wed, May 11, 2022 at 06:56:16AM +, Patchwork wrote: > == Series Details == > > Series: i915: Introduce Ponte Vecchio (rev4) > URL : https://patchwork.freedesktop.org/series/103443/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11632 -> Patchwork_103443v4 > ===

Re: [Intel-gfx] [RFC PATCH] drm/i915: don't treat small BAR as an error with CSS

2022-05-11 Thread Das, Nirmoy
On 5/11/2022 4:14 PM, Matthew Auld wrote: On Wed, 11 May 2022 at 13:34, Das, Nirmoy wrote: On 5/11/2022 1:31 PM, Matthew Auld wrote: On Wed, 11 May 2022 at 11:25, Nirmoy Das wrote: Determine lmem_size using ADDR_RANGE register so that module load on platfrom with small bar with css works

Re: [Intel-gfx] [PATCH] drm/i915: Fix 'mixing different enum types' warnings in intel_display_power.c

2022-05-11 Thread Jani Nikula
On Tue, 10 May 2022, Imre Deak wrote: > Fix the following sparse warnings: > > drivers/gpu/drm/i915/display/intel_display_power.c:2431:34: warning: mixing > different enum types: > drivers/gpu/drm/i915/display/intel_display_power.c:2431:34:unsigned int > enum intel_display_power_domain > dri

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Convert slpc to iosys_map

2022-05-11 Thread Balasubramani Vivekanandan
On 09.05.2022 21:05, Mullati Siva wrote: > From: Siva Mullati > > Convert slpc shared data to use iosys_map rather than > plain pointer and save it in the intel_guc_slpc struct. > This will help with in read and update slpc shared data > after the slpc init by abstracting the IO vs system memory.

Re: [Intel-gfx] [PATCH i-g-t 8/8] gputop: Basic vendor agnostic GPU top tool

2022-05-11 Thread Tvrtko Ursulin
On 11/05/2022 15:42, Christian König wrote: Just two bugs I've found and you should probably handle: 1. On amdgpu we probably want to filter engines which are not used by an application. This confuses gputop in it's display. E.g. when you have one application using only gfx and the other onl

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Convert ct buffer to iosys_map

2022-05-11 Thread Balasubramani Vivekanandan
On 09.05.2022 12:19, Mullati Siva wrote: > From: Siva Mullati > > Convert CT commands and descriptors to use iosys_map rather > than plain pointer and save it in the intel_guc_ct_buffer struct. > This will help with ct_write and ct_read for cmd send and receive > after the initialization by abstr

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/uc: remove accidental static from a local variable

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915/uc: remove accidental static from a local variable URL : https://patchwork.freedesktop.org/series/103866/ State : success == Summary == CI Bug Log - changes from CI_DRM_11635_full -> Patchwork_103866v1_full =

Re: [Intel-gfx] [PATCH] drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend

2022-05-11 Thread Tvrtko Ursulin
On 10/05/2022 23:14, Nerlige Ramappa, Umesh wrote: From: Umesh Nerlige Ramappa For execlists backend, current implementation of Wa_22011802037 is to stop the CS before doing a reset of the engine. This WA was further extended to wait for any pending MI FORCE WAKEUPs before issuing a reset. Ad

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Introduce Ponte Vecchio (rev4)

2022-05-11 Thread Patchwork
== Series Details == Series: i915: Introduce Ponte Vecchio (rev4) URL : https://patchwork.freedesktop.org/series/103443/ State : success == Summary == CI Bug Log - changes from CI_DRM_11632 -> Patchwork_103443v4 Summary --- **SUCCESS

[Intel-gfx] [PATCH 1/3] drm/i915: return -EIO on lmem setup failure

2022-05-11 Thread Nirmoy Das
Caller of setup_lmem() ignores -ENODEV but failing to setup lmem on dGPU isn't ignorable error. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers

[Intel-gfx] [PATCH 3/3] drm/i915: error out on platform with small-bar and CCS

2022-05-11 Thread Nirmoy Das
Until we enable small-bar, we can't support CCS so error out gracefully on such platforms. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/i

[Intel-gfx] [PATCH 2/3] drm/i915: determine lmem_size properly

2022-05-11 Thread Nirmoy Das
Determine lmem_size using ADDR_RANGE register so that lmem_setup() works on platform with small-bar as well. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_region_lme

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use drm_dbg for rpm logging

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915: Use drm_dbg for rpm logging URL : https://patchwork.freedesktop.org/series/103879/ State : success == Summary == CI Bug Log - changes from CI_DRM_11636 -> Patchwork_103879v1 Summary --- **SUCCES

Re: [Intel-gfx] [PATCH 3/3] drm/i915: error out on platform with small-bar and CCS

2022-05-11 Thread Matthew Auld
On 11/05/2022 16:37, Nirmoy Das wrote: Until we enable small-bar, we can't support CCS so error out gracefully on such platforms. It's not so much CCS, but any platform that might end up with small-bar, which is so far only some DG2 boards. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/bios: PNPID->panel_type matching (rev2)

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915/bios: PNPID->panel_type matching (rev2) URL : https://patchwork.freedesktop.org/series/103799/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v4 5/7] drm/i915/gvt: Change from vfio_group_(un)pin_pages to vfio_(un)pin_pages

2022-05-11 Thread Wang, Zhi A
On 5/6/22 12:08 AM, Jason Gunthorpe wrote: > Use the existing vfio_device versions of vfio_(un)pin_pages(). There is no > reason to use a group interface here, kvmgt has easy access to a > vfio_device. > > Delete kvmgt_vdev::vfio_group since these calls were the last users. > > Reviewed-by: Kevin

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: don't treat small BAR as an error with CSS

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915: don't treat small BAR as an error with CSS URL : https://patchwork.freedesktop.org/series/103867/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11635_full -> Patchwork_103867v1_full Su

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: PNPID->panel_type matching (rev2)

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915/bios: PNPID->panel_type matching (rev2) URL : https://patchwork.freedesktop.org/series/103799/ State : success == Summary == CI Bug Log - changes from CI_DRM_11636 -> Patchwork_103799v2 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: disable HPD workers before display driver unregister (rev5)

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915/display: disable HPD workers before display driver unregister (rev5) URL : https://patchwork.freedesktop.org/series/103811/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11636 -> Patchwork_103811v5

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Enable Tile4 tiling mode

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915: Enable Tile4 tiling mode URL : https://patchwork.freedesktop.org/series/103881/ State : warning == Summary == Error: dim checkpatch failed aafe76362d88 drm/i915: Enable Tile4 tiling mode -:360: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'idx' may be bette

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable Tile4 tiling mode

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915: Enable Tile4 tiling mode URL : https://patchwork.freedesktop.org/series/103881/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11636 -> Patchwork_103881v1 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid: introduce struct drm_edid (rev7)

2022-05-11 Thread Patchwork
== Series Details == Series: drm/edid: introduce struct drm_edid (rev7) URL : https://patchwork.freedesktop.org/series/103665/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./drivers/gpu/drm/amd/amdgpu/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: introduce struct drm_edid (rev7)

2022-05-11 Thread Patchwork
== Series Details == Series: drm/edid: introduce struct drm_edid (rev7) URL : https://patchwork.freedesktop.org/series/103665/ State : success == Summary == CI Bug Log - changes from CI_DRM_11636 -> Patchwork_103665v7 Summary --- **S

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: return -EIO on lmem setup failure

2022-05-11 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: return -EIO on lmem setup failure URL : https://patchwork.freedesktop.org/series/103883/ State : warning == Summary == Error: dim checkpatch failed 9b39fe5f81cd drm/i915: return -EIO on lmem setup failure ceaf7af17c75 drm/i915:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Use i915_gem_object_ggtt_pin_ww for reloc_iomap

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915: Use i915_gem_object_ggtt_pin_ww for reloc_iomap URL : https://patchwork.freedesktop.org/series/103874/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11636_full -> Patchwork_103874v1_full ===

Re: [Intel-gfx] [PATCH] drm/i915: Use i915_gem_object_ggtt_pin_ww for reloc_iomap

2022-05-11 Thread Matthew Auld
On 11/05/2022 12:52, Maarten Lankhorst wrote: Instead of its own path, use the common path when it doesn't result in evicting any vma. This fixes the case where we don't wait for binding. https://gitlab.freedesktop.org/drm/intel/-/issues/5806 If I'm reading that correctly waiting for the bind

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: return -EIO on lmem setup failure

2022-05-11 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: return -EIO on lmem setup failure URL : https://patchwork.freedesktop.org/series/103883/ State : success == Summary == CI Bug Log - changes from CI_DRM_11636 -> Patchwork_103883v1

Re: [Intel-gfx] [PATCH] drm/i915: Use i915_gem_object_ggtt_pin_ww for reloc_iomap

2022-05-11 Thread Maarten Lankhorst
Op 11-05-2022 om 20:23 schreef Matthew Auld: > On 11/05/2022 12:52, Maarten Lankhorst wrote: >> Instead of its own path, use the common path when it doesn't result >> in evicting any vma. This fixes the case where we don't wait for >> binding. >> > > https://gitlab.freedesktop.org/drm/intel/-/issue

Re: [Intel-gfx] [PATCH v7 3/7] drm/i915: Prepare for multiple GTs

2022-05-11 Thread Ceraolo Spurio, Daniele
On 3/18/2022 4:39 PM, Andi Shyti wrote: From: Tvrtko Ursulin On a multi-tile platform, each tile has its own registers + GGTT space, and BAR 0 is extended to cover all of them. Up to four GTs are supported in i915->gt[], with slot zero shadowing the existing i915->gt0 to enable source compa

[Intel-gfx] [PATCH] drm/i915/d12+: Disable DMC firmware flip queue handlers

2022-05-11 Thread Imre Deak
Based on a bspec update the DMC firmware's flip queue handling events need to be disabled before enabling DC5/6. i915 doesn't use the flip queue feature atm, so disable it already after loading the firmware. This removes some overhead of the event handler which runs at a 1 kHz frequency. Bspec: 49

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/d12+: Disable DMC firmware flip queue handlers

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915/d12+: Disable DMC firmware flip queue handlers URL : https://patchwork.freedesktop.org/series/103888/ State : warning == Summary == Error: dim checkpatch failed c4133e6ab80d drm/i915/d12+: Disable DMC firmware flip queue handlers -:167: CHECK:MACRO_ARG_REU

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915: Introduce Ponte Vecchio (rev4)

2022-05-11 Thread Patchwork
== Series Details == Series: i915: Introduce Ponte Vecchio (rev4) URL : https://patchwork.freedesktop.org/series/103443/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11632_full -> Patchwork_103443v4_full Summary ---

Re: [Intel-gfx] [PATCH v6 4/4] ALSA: hda - identify when audio is provided by a video driver

2022-05-11 Thread Daniel Vetter
On Mon, May 09, 2022 at 06:23:39PM +0200, Mauro Carvalho Chehab wrote: > On some devices, the hda driver needs to hook into a video driver, > in order to be able to properly access the audio hardware and/or > the power management function. > > That's the case of several snd_hda_intel devices that

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/d12+: Disable DMC firmware flip queue handlers

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915/d12+: Disable DMC firmware flip queue handlers URL : https://patchwork.freedesktop.org/series/103888/ State : success == Summary == CI Bug Log - changes from CI_DRM_11637 -> Patchwork_103888v1 Summary -

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use drm_dbg for rpm logging

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915: Use drm_dbg for rpm logging URL : https://patchwork.freedesktop.org/series/103879/ State : success == Summary == CI Bug Log - changes from CI_DRM_11636_full -> Patchwork_103879v1_full Summary ---

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for i915: Introduce Ponte Vecchio (rev4)

2022-05-11 Thread Matt Roper
On Wed, May 11, 2022 at 07:45:28PM +, Patchwork wrote: > == Series Details == > > Series: i915: Introduce Ponte Vecchio (rev4) > URL : https://patchwork.freedesktop.org/series/103443/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11632_full -> Patchwork_103443v4_

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/bios: PNPID->panel_type matching (rev2)

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915/bios: PNPID->panel_type matching (rev2) URL : https://patchwork.freedesktop.org/series/103799/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11636_full -> Patchwork_103799v2_full Summar

Re: [Intel-gfx] [PATCH] drm/i915/d12+: Disable DMC firmware flip queue handlers

2022-05-11 Thread Srivatsa, Anusha
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Wednesday, May 11, 2022 12:19 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH] drm/i915/d12+: Disable DMC firmware flip queue > handlers > > Based on a bspec update the DMC firmware's flip qu

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Update GuC relay logging debugfs

2022-05-11 Thread Teres Alexis, Alan Previn
Looking through the log messages, all 4 failures below are not related to the GuC relay logging change of this series. They are all display related. Two of the failures were on SKL which doesn't have GuC enabled. Interestingly, all 4 cases, carries multiple different test or subtest failures but

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/edid: introduce struct drm_edid (rev7)

2022-05-11 Thread Patchwork
== Series Details == Series: drm/edid: introduce struct drm_edid (rev7) URL : https://patchwork.freedesktop.org/series/103665/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11636_full -> Patchwork_103665v7_full Summary

[Intel-gfx] [PATCH] drm/i915/display: Add a separate crtc_enable hook for SKL+

2022-05-11 Thread Manasi Navare
Currently we reuse hsw_crtc_enable for SKL+ platforms. But this has added a lot of platform checks for SKL+ platforms. So its time to move the code to a separate crtc_enable hook for SKL+ platforms. No functional changes here. Suggested-by: Jani Nikula Cc: Ville Syrjälä Cc: Jani Nikula Signed-

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: return -EIO on lmem setup failure

2022-05-11 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: return -EIO on lmem setup failure URL : https://patchwork.freedesktop.org/series/103883/ State : success == Summary == CI Bug Log - changes from CI_DRM_11636_full -> Patchwork_103883v1_full ==

Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-05-11 Thread Dixit, Ashutosh
On Tue, 10 May 2022 03:41:57 -0700, Andrzej Hajda wrote: > On 10.05.2022 11:48, Tvrtko Ursulin wrote: > > On 10/05/2022 10:39, Andrzej Hajda wrote: > >> On 10.05.2022 10:18, Tvrtko Ursulin wrote: > > > > Was there closure/agreement on the matter of whether or not there is > > a potentia

[Intel-gfx] ✓ Fi.CI.IGT: success for i915: Introduce Ponte Vecchio (rev4)

2022-05-11 Thread Patchwork
== Series Details == Series: i915: Introduce Ponte Vecchio (rev4) URL : https://patchwork.freedesktop.org/series/103443/ State : success == Summary == CI Bug Log - changes from CI_DRM_11632_full -> Patchwork_103443v4_full Summary ---

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for i915: Introduce Ponte Vecchio (rev4)

2022-05-11 Thread Vudum, Lakshminarayana
Correct, I have added GLK to this bug https://gitlab.freedesktop.org/drm/intel/-/issues/5753 Thanks, Lakshmi. -Original Message- From: Roper, Matthew D Sent: Wednesday, May 11, 2022 1:45 PM To: intel-gfx@lists.freedesktop.org Cc: Vudum, Lakshminarayana Subject: Re: ✗ Fi.CI.IGT: failure

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Add a separate crtc_enable hook for SKL+

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915/display: Add a separate crtc_enable hook for SKL+ URL : https://patchwork.freedesktop.org/series/103896/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11638 -> Patchwork_103896v1 Summar

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/d12+: Disable DMC firmware flip queue handlers

2022-05-11 Thread Patchwork
== Series Details == Series: drm/i915/d12+: Disable DMC firmware flip queue handlers URL : https://patchwork.freedesktop.org/series/103888/ State : success == Summary == CI Bug Log - changes from CI_DRM_11637_full -> Patchwork_103888v1_full

[Intel-gfx] [PATCH 1/7] drm/i915: Introduce has_media_ratio_mode

2022-05-11 Thread Ashutosh Dixit
Media ratio mode (the ability for media IP to work at a different frequency from the GT) is available for a subset of dGfx platforms supporting GuC/SLPC. Introduce 'has_media_ratio_mode' flag in intel_device_info to identify these platforms and set it for XEHPSDV and DG2/ATS-M. Signed-off-by: Ashu

[Intel-gfx] [PATCH 6/7] drm/i915/gt: Add media RP0/RPn to per-gt sysfs

2022-05-11 Thread Ashutosh Dixit
From: Dale B Stimson Retrieve RP0 and RPn freq for media IP from PCODE and display in per-gt sysfs. This patch adds the following files to gt/gtN sysfs: * media_RP0_freq_mhz * media_RPn_freq_mhz v2: Fixed commit author (Rodrigo) v3: Convert to new uncore interface for pcode functions v4: Adapt t

[Intel-gfx] [PATCH v5 0/7] drm/i915: Media freq factor and per-gt enhancements/fixes

2022-05-11 Thread Ashutosh Dixit
Some recent Intel dGfx platforms allow media IP to work at a different frequency from the base GT. This patch series exposes sysfs controls for this functionality in the new per-gt sysfs. Some enhancements and fixes to previous per-gt functionality are also included to complete the new functionalit

[Intel-gfx] [PATCH 2/7] drm/i915/gt: Add media freq factor to per-gt sysfs

2022-05-11 Thread Ashutosh Dixit
Expose new sysfs to program and retrieve media freq factor. Factor values of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point representation (corresponding to integer values of 0, 128 and 256 respectively). Media freq factor is converted to media_ratio_mode for GuC. It is programmed i

[Intel-gfx] [PATCH 4/7] drm/i915/pcode: Init pcode on different gt's

2022-05-11 Thread Ashutosh Dixit
Extend pcode initialization to pcode on different gt's. Cc: Tvrtko Ursulin Cc: Jani Nikula Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/i915_driver.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_driver.c b/driver

[Intel-gfx] [PATCH 5/7] drm/i915/pcode: Add a couple of pcode helpers

2022-05-11 Thread Ashutosh Dixit
From: Dale B Stimson Some dGfx pcode commands take additional sub-commands and parameters. Add a couple of helpers to help formatting these commands to improve code readability. v2: Fixed commit author (Rodrigo) v3: Function rename and convert to new uncore interface for pcode functions Remo

[Intel-gfx] [PATCH 7/7] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-05-11 Thread Ashutosh Dixit
All kmalloc'd kobjects need a kobject_put() to free memory. For example in previous code, kobj_gt_release() never gets called. The requirement of kobject_put() now results in a slightly different code organization. v2: s/gtn/gt/ (Andi) Fixes: b770bcfae9ad ("drm/i915/gt: create per-tile sysfs inte

  1   2   >