[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Communicate display configuration to pcode

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display configuration to pcode URL : https://patchwork.freedesktop.org/series/102678/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11498 -> Patchwork_102678v1 Summ

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes

2022-04-14 Thread Vudum, Lakshminarayana
Issue is related to https://gitlab.freedesktop.org/drm/intel/-/issues/5701 Re-reported. Lakshmi. -Original Message- From: Dixit, Ashutosh Sent: Wednesday, April 13, 2022 10:57 PM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana Subject: Re: ✗ Fi.CI.BAT: failure for drm/i915:

[Intel-gfx] [PULL] drm-misc-next

2022-04-14 Thread Maxime Ripard
Hi Daniel, Dave, Here's this week drm-misc-next PR Maxime drm-misc-next-2022-04-14: drm-misc-next for $kernel-version: UAPI Changes: Cross-subsystem Changes: - fbcon: various loading and locking cleanups Core Changes: - buddy: Check for page size alignment at allocation - dma-buf: Add d

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/edid: low level EDID block read refactoring etc. (rev7)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/edid: low level EDID block read refactoring etc. (rev7) URL : https://patchwork.freedesktop.org/series/102329/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497_full -> Patchwork_102329v7_full =

Re: [Intel-gfx] commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes white spots in console screens

2022-04-14 Thread Lisovskiy, Stanislav
On Thu, Apr 14, 2022 at 08:33:35AM +0200, François Valenduc wrote: > Le 14/04/22 à 08:31, Lisovskiy, Stanislav a écrit : > > On Wed, Apr 13, 2022 at 08:12:20PM +0300, Jani Nikula wrote: > > > On Wed, 13 Apr 2022, François Valenduc wrote: > > > > Commit 15512021eb3975a8c2366e3883337e252bb0eee5 > >

Re: [Intel-gfx] commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes white spots in console screens

2022-04-14 Thread Jani Nikula
On Thu, 14 Apr 2022, François Valenduc wrote: > Le 14/04/22 à 10:03, Lisovskiy, Stanislav a écrit : >> On Thu, Apr 14, 2022 at 08:33:35AM +0200, François Valenduc wrote: >>> Le 14/04/22 à 08:31, Lisovskiy, Stanislav a écrit : On Wed, Apr 13, 2022 at 08:12:20PM +0300, Jani Nikula wrote: >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes URL : https://patchwork.freedesktop.org/series/102665/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497_full -> Patchwork_102665v1_full ===

Re: [Intel-gfx] commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes white spots in console screens

2022-04-14 Thread Saarinen, Jani
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: torstai 14. huhtikuuta 2022 11.32 > To: François Valenduc ; Lisovskiy, Stanislav > > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Subject: Re: [Intel-gfx] commit 15512021eb3975a8c2366e388

Re: [Intel-gfx] [PATCH v3 1/2] drm/dp: Factor out a function to probe a DPCD address

2022-04-14 Thread Jani Nikula
On Mon, 11 Apr 2022, Imre Deak wrote: > Factor out from drm_dp_dpcd_read() a function to probe a DPCD address > with a 1-byte read access. This will be needed by the next patch doing a > read from an LTTPR address, which must happen without the preceding > wake-up read in drm_dp_dpcd_read(). > > W

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/dp: Add workaround for spurious AUX timeouts/hotplugs on LTTPR links

2022-04-14 Thread Jani Nikula
On Sat, 09 Apr 2022, Imre Deak wrote: > Some ADLP DP link configuration at least with multiple LTTPRs expects > the first DPCD access during the LTTPR/DPCD detection after hotplug to > be a read from the LTTPR range starting with > DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV. The side effe

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display/psr: Clear more PSR state during disable

2022-04-14 Thread Hogander, Jouni
On Wed, 2022-04-13 at 15:59 +, Souza, Jose wrote: > On Wed, 2022-04-13 at 07:27 +, Hogander, Jouni wrote: > > Hello Jose, > > > > See my comment below. > > > > On Tue, 2022-04-12 at 13:55 -0700, José Roberto de Souza wrote: > > > After commit 805f04d42a6b ("drm/i915/display/psr: Use conti

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/edid: low level EDID block read refactoring etc. (rev8)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/edid: low level EDID block read refactoring etc. (rev8) URL : https://patchwork.freedesktop.org/series/102329/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11499 -> Patchwork_102329v8 Summa

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/display/psr: Do not check for PSR2_MAN_TRK_CTL_ENABLE on alderlake-P

2022-04-14 Thread Hogander, Jouni
On Wed, 2022-04-13 at 09:43 -0700, José Roberto de Souza wrote: > Alderlake-P don't have PSR2_MAN_TRK_CTL_ENABLE bit, instead it have > ADLP_PSR2_MAN_TRK_CTL_SF_PARTIAL_FRAME_UPDATE in the same bit but > this > bit is clearead after each vblank so we can't count on having it > set after planes are

Re: [Intel-gfx] [PATCH] drm/i915: Check EDID before dpcd for possible HDR aux bl support

2022-04-14 Thread Hogander, Jouni
On Wed, 2022-04-13 at 17:08 -0400, Lyude Paul wrote: > On Wed, 2022-04-13 at 08:31 +, Hogander, Jouni wrote: > > Hello Lyude, > > > > See my respose below. > > > > On Tue, 2022-04-12 at 13:50 -0400, Lyude Paul wrote: > > > On Tue, 2022-04-12 at 08:25 +0300, Jouni Högander wrote: > > > > We ha

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Convert ct buffer to iosys_map

2022-04-14 Thread Balasubramani Vivekanandan
On 04.04.2022 15:01, Mullati Siva wrote: > From: Siva Mullati > > Convert CT commands and descriptors to use iosys_map rather > than plain pointer and save it in the intel_guc_ct_buffer struct. > This will help with ct_write and ct_read for cmd send and receive > after the initialization by abstr

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Wang, Zhi A
On 4/13/22 11:20 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 11:13:06PM +, Wang, Zhi A wrote: >> Hi folks: >> >> Thanks so much for the efforts. I prepared a branch which contains all our >> patches.The aim of the branch is for the VFIO maintainers to pull the whole >> bunch easily a

[Intel-gfx] [PATCH 0/1] add support for enum module parameters

2022-04-14 Thread Jani Nikula
Hey, I've sent this before, ages ago, but haven't really followed through with it. I still think it would be useful for many scenarios where a plain number is a clumsy interface for a module param. Thoughts? BR, Jani. Cc: Andrew Morton Cc: Greg Kroah-Hartman Cc: Lucas De Marchi Jani Nikula

[Intel-gfx] [PATCH 1/1] module: add enum module parameter type to map names to values

2022-04-14 Thread Jani Nikula
Add enum module parameter type that's internally an int and externally maps names to values. This makes the userspace interface more intuitive to use and somewhat easier to document, while also limiting the allowed values set by userspace to the defined set. For example, given this code to define

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display/psr: Clear more PSR state during disable

2022-04-14 Thread Souza, Jose
On Thu, 2022-04-14 at 11:08 +, Hogander, Jouni wrote: > On Wed, 2022-04-13 at 15:59 +, Souza, Jose wrote: > > On Wed, 2022-04-13 at 07:27 +, Hogander, Jouni wrote: > > > Hello Jose, > > > > > > See my comment below. > > > > > > On Tue, 2022-04-12 at 13:55 -0700, José Roberto de Souza

[Intel-gfx] [PATCH 4.19 051/338] drm/edid: check basic audio support on CEA extension block

2022-04-14 Thread Greg Kroah-Hartman
From: Cooper Chiou commit 5662abf6e21338be6d085d6375d3732ac6147fd2 upstream. Tag code stored in bit7:5 for CTA block byte[3] is not the same as CEA extension block definition. Only check CEA block has basic audio support. v3: update commit message. Cc: sta...@vger.kernel.org Cc: Jani Nikula C

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915: instantiate ttm ranger manager for stolen memory

2022-04-14 Thread Thomas Hellström
On 4/12/22 21:38, Robert Beckett wrote: prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett LGTM. Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/g

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-14 Thread Jani Nikula
On Wed, 13 Apr 2022, Ashutosh Dixit wrote: > Each gt contains an independent instance of pcode. Extend pcode functions > to interface with pcode on different gt's. Previous (GT0) pcode read/write > interfaces are preserved. The big problem here is that this hard couples display code to gt code, w

[Intel-gfx] [PATCH 5.4 066/475] drm/edid: check basic audio support on CEA extension block

2022-04-14 Thread Greg Kroah-Hartman
From: Cooper Chiou commit 5662abf6e21338be6d085d6375d3732ac6147fd2 upstream. Tag code stored in bit7:5 for CTA block byte[3] is not the same as CEA extension block definition. Only check CEA block has basic audio support. v3: update commit message. Cc: sta...@vger.kernel.org Cc: Jani Nikula C

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Wang, Zhi A
On 4/14/22 1:34 PM, Jason Gunthorpe wrote: > On Thu, Apr 14, 2022 at 12:20:42PM +, Wang, Zhi A wrote: >> On 4/13/22 11:20 PM, Jason Gunthorpe wrote: >>> On Wed, Apr 13, 2022 at 11:13:06PM +, Wang, Zhi A wrote: Hi folks: Thanks so much for the efforts. I prepared a branch whic

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Jani Nikula
On Thu, 14 Apr 2022, Jason Gunthorpe wrote: > On Thu, Apr 14, 2022 at 12:20:42PM +, Wang, Zhi A wrote: >> On 4/13/22 11:20 PM, Jason Gunthorpe wrote: >> > On Wed, Apr 13, 2022 at 11:13:06PM +, Wang, Zhi A wrote: >> >> Hi folks: >> >> >> >> Thanks so much for the efforts. I prepared a branc

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Jani Nikula
On Thu, 14 Apr 2022, Jason Gunthorpe wrote: > On Thu, Apr 14, 2022 at 01:39:11PM +, Wang, Zhi A wrote: >> This one belongs to i915, which has already been queued in drm-intel-next, >> but >> not yet reached to the top. When it is landed in -rc, I will rebase this >> branch >> on it, then we

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: low level EDID block read refactoring etc. (rev9)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/edid: low level EDID block read refactoring etc. (rev9) URL : https://patchwork.freedesktop.org/series/102329/ State : success == Summary == CI Bug Log - changes from CI_DRM_11499 -> Patchwork_102329v9 Summa

Re: [Intel-gfx] [PATCH] drm/i915/adl-n: Differentiate ADLP and ADLN steppings

2022-04-14 Thread Surendrakumar Upadhyay, TejaskumarX
Hello, Can anyone review please? Pre-merge failure is not related to the patch. Thanks, Tejas > -Original Message- > From: Surendrakumar Upadhyay, TejaskumarX > > Sent: 13 April 2022 16:28 > To: intel-gfx@lists.freedesktop.org > Cc: Surendrakumar Upadhyay, TejaskumarX > > Subject: [PAT

Re: [Intel-gfx] [PATCH 0/1] add support for enum module parameters

2022-04-14 Thread Greg Kroah-Hartman
On Thu, Apr 14, 2022 at 03:30:32PM +0300, Jani Nikula wrote: > Hey, I've sent this before, ages ago, but haven't really followed > through with it. I still think it would be useful for many scenarios > where a plain number is a clumsy interface for a module param. > > Thoughts? We should not be a

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for add support for enum module parameters

2022-04-14 Thread Patchwork
== Series Details == Series: add support for enum module parameters URL : https://patchwork.freedesktop.org/series/102695/ State : warning == Summary == Error: dim checkpatch failed 8c6849f919aa module: add enum module parameter type to map names to values -:73: ERROR:OPEN_BRACE: open brace '{

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for add support for enum module parameters

2022-04-14 Thread Patchwork
== Series Details == Series: add support for enum module parameters URL : https://patchwork.freedesktop.org/series/102695/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915: sanitize mem_flags for stolen buffers

2022-04-14 Thread Thomas Hellström
On Tue, 2022-04-12 at 15:18 +, Robert Beckett wrote: > stolen regions are not page backed or considered iomem. thus... A little more elaborate commit message please. > > Signed-off-by: Robert Beckett Reviewed-by: Thomas Hellström > --- >  drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c |

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: ttm move/clear logic fix

2022-04-14 Thread Thomas Hellström
On Tue, 2022-04-12 at 15:18 +, Robert Beckett wrote: > ttm managed buffers start off with system resource definitions and > ttm_tt > tracking structures allocated (though unpopulated). > currently this prevents clearing of buffers on first move to desired > placements. > > The desired behaviou

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915: ttm backend dont provide mmap_offset for kernel buffers

2022-04-14 Thread Thomas Hellström
On Tue, 2022-04-12 at 15:18 +, Robert Beckett wrote: > stolen/kernel buffers should not be mmapable by userland. > do not provide callbacks to facilitate this for these buffers. > > Signed-off-by: Robert Beckett > --- >  drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 32 +-- > -

Re: [Intel-gfx] [CI v3 00/12] drm/edid: low level EDID block read refactoring etc.

2022-04-14 Thread Jani Nikula
On Mon, 11 Apr 2022, Jani Nikula wrote: > v3 of [1] fixing the (!x == 0) mistake. Resending the entire thing with > hopes the test robot picks up the baseline better; I haven't had much > luck with --in-reply-to for that. There were some issues with our CI, but I'm pretty sure they were not cause

[Intel-gfx] [PATCH] drm/i915/rpl-p: Add PCI IDs

2022-04-14 Thread Tejas Upadhyay
From: Matt Atwood Adding initial PCI ids for RPL-P. RPL-P behaves identically to ADL-P from i915's point of view. Bspec: 55376 Signed-off-by: Matt Atwood Signed-off-by: Madhumitha Tolakanahalli Pradeep Signed-off-by: Tejas Upadhyay --- arch/x86/kernel/early-quirks.c | 1 + drivers

[Intel-gfx] ✓ Fi.CI.BAT: success for add support for enum module parameters

2022-04-14 Thread Patchwork
== Series Details == Series: add support for enum module parameters URL : https://patchwork.freedesktop.org/series/102695/ State : success == Summary == CI Bug Log - changes from CI_DRM_11499 -> Patchwork_102695v1 Summary --- **SUCCE

Re: [Intel-gfx] [PATCH 0/1] add support for enum module parameters

2022-04-14 Thread Jani Nikula
On Thu, 14 Apr 2022, Greg Kroah-Hartman wrote: > On Thu, Apr 14, 2022 at 03:30:32PM +0300, Jani Nikula wrote: >> Hey, I've sent this before, ages ago, but haven't really followed >> through with it. I still think it would be useful for many scenarios >> where a plain number is a clumsy interface f

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/edid: low level EDID block read refactoring etc. (rev8)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/edid: low level EDID block read refactoring etc. (rev8) URL : https://patchwork.freedesktop.org/series/102329/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11499_full -> Patchwork_102329v8_full =

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-14 Thread Wang, Zhi A
On 4/14/22 1:43 PM, Jason Gunthorpe wrote: > On Thu, Apr 14, 2022 at 04:40:11PM +0300, Jani Nikula wrote: > >> git clone https://github.com/intel/gvt-linux -b for-christoph > > There are alot of extra commits on there - is it possible to base this > straight on rc1 not on some kind

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/display/psr: Do not check for PSR2_MAN_TRK_CTL_ENABLE on alderlake-P

2022-04-14 Thread Souza, Jose
On Thu, 2022-04-14 at 11:13 +, Hogander, Jouni wrote: > On Wed, 2022-04-13 at 09:43 -0700, José Roberto de Souza wrote: > > Alderlake-P don't have PSR2_MAN_TRK_CTL_ENABLE bit, instead it have > > ADLP_PSR2_MAN_TRK_CTL_SF_PARTIAL_FRAME_UPDATE in the same bit but > > this > > bit is clearead afte

Re: [Intel-gfx] [PATCH 0/1] add support for enum module parameters

2022-04-14 Thread Greg Kroah-Hartman
On Thu, Apr 14, 2022 at 05:22:47PM +0300, Jani Nikula wrote: > On Thu, 14 Apr 2022, Greg Kroah-Hartman wrote: > > On Thu, Apr 14, 2022 at 03:30:32PM +0300, Jani Nikula wrote: > >> Hey, I've sent this before, ages ago, but haven't really followed > >> through with it. I still think it would be usef

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915: stolen memory use ttm backend

2022-04-14 Thread Thomas Hellström
Hi, On 4/12/22 21:38, Robert Beckett wrote: +struct ttm_resource * +i915_gem_stolen_reserve_range(struct drm_i915_private *i915, + resource_size_t size, + u64 start, u64 end) { - int ret; + struct intel_memory_region *mem = i

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/rpl-p: Add PCI IDs

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915/rpl-p: Add PCI IDs URL : https://patchwork.freedesktop.org/series/102701/ State : warning == Summary == Error: dim checkpatch failed c6b5a4897d53 drm/i915/rpl-p: Add PCI IDs -:107: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in pare

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/rpl-p: Add PCI IDs

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915/rpl-p: Add PCI IDs URL : https://patchwork.freedesktop.org/series/102701/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH 01/19] drm/edid: reset display info in drm_add_edid_modes() for NULL edid

2022-04-14 Thread Jani Nikula
If a NULL edid gets passed to drm_add_edid_modes(), we should probably also reset the display info. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 324ce

[Intel-gfx] [PATCH 02/19] drm/edid: check for HF-SCDB block

2022-04-14 Thread Jani Nikula
From: Lee Shawn C Find HF-SCDB information in CEA extensions block. And retrieve Max_TMDS_Character_Rate that support by sink device. v2: HF-SCDB and HF-VSDBS carry the same SCDS data. Reuse drm_parse_hdmi_forum_vsdb() to parse this packet. Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Naut

[Intel-gfx] [PATCH 00/19] drm/edid: CEA data block iterators, and more

2022-04-14 Thread Jani Nikula
Get back to the CEA data block iterator stuff now that a bunch of prep work has landed. My git repo at [1], branch edid-hfeeodb-2022-04-14, contains where this is all headed after this. [1] https://cgit.freedesktop.org/~jani/drm/log/?h=edid-hfeeodb-2022-04-14 Jani Nikula (18): drm/edid: reset

[Intel-gfx] [PATCH 03/19] drm/edid: clean up CTA data block tag definitions

2022-04-14 Thread Jani Nikula
Add prefixed names, group, sort, add references. v2: - Updated references to CTA-861-H - s/CEA/CTA/ in data block macros Cc: Ville Syrjälä Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 65 -- 1 file changed, 35 inser

[Intel-gfx] [PATCH 05/19] drm/edid: add iterator for CTA data blocks

2022-04-14 Thread Jani Nikula
Add an iterator for CTA Data Blocks across EDID CTA Extensions and DisplayID CTA Data Blocks. v2: Update references, note why we can trust displayid ranges (Ville) Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 202 ++--- 1 file ch

[Intel-gfx] [PATCH 06/19] drm/edid: clean up cea_db_is_*() functions

2022-04-14 Thread Jani Nikula
Abstract helpers for matching vendor data blocks and extended tags, and use them to simplify all the cea_db_is_*() functions. Take void pointer as parameter to allow transitional use for both u8 * and struct cea_db *. v2: Remove superfluous parens (Ville) Cc: Ville Syrjälä Signed-off-by: Jani N

[Intel-gfx] [PATCH 04/19] drm/edid: add iterator for EDID base and extension blocks

2022-04-14 Thread Jani Nikula
Add an iterator abstraction for going through all the EDID blocks. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c inde

[Intel-gfx] [PATCH 08/19] drm/edid: convert drm_edid_to_speaker_allocation() to use cea db iter

2022-04-14 Thread Jani Nikula
Use the cea db iterator for speaker allocation. We'll still stop at the first speaker data block, but not at the first CTA extension if that doesn't have the info. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 47 -- 1 file cha

[Intel-gfx] [PATCH 07/19] drm/edid: convert add_cea_modes() to use cea db iter

2022-04-14 Thread Jani Nikula
Iterate through all CTA EDID extension blocks and DisplayID CTA data blocks to add CEA modes. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 67 ++ 1 file changed, 31 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/

[Intel-gfx] [PATCH 10/19] drm/edid: convert drm_detect_hdmi_monitor() to use cea db iter

2022-04-14 Thread Jani Nikula
Iterate through all CTA data blocks, not just the first CTA extension. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edi

[Intel-gfx] [PATCH 11/19] drm/edid: convert drm_detect_monitor_audio() to use cea db iter

2022-04-14 Thread Jani Nikula
Iterate through all CEA data blocks. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index b1fac281fd85..e47bbcd103e6

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use i915_probe_error instead of drm_err

2022-04-14 Thread Belgaumkar, Vinay
On 4/13/2022 11:41 PM, Anshuman Gupta wrote: On 2022-04-13 at 04:18:52 +0530, Vinay Belgaumkar wrote: This will ensure we don't have false positives when we run error injection tests. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 42 ++---

[Intel-gfx] [PATCH 13/19] drm/edid: convert drm_edid_to_eld() to use cea db iter

2022-04-14 Thread Jani Nikula
Iterate through all CTA data blocks across all CTA extensions and DisplayID data blocks. This may gather more data than before, and if there's duplicated data, some is overwritten by whichever comes last. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 64 +

[Intel-gfx] [PATCH 09/19] drm/edid: convert drm_edid_to_sad() to use cea db iter

2022-04-14 Thread Jani Nikula
Use the cea db iterator for short audio descriptors. We'll still stop at the first audio data block, but not at the first CTA Extension if that doesn't have the info. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 34 +- 1 file chan

[Intel-gfx] [PATCH 14/19] drm/edid: sunset the old unused cea data block iterators

2022-04-14 Thread Jani Nikula
All CTA data block iteration has now been converted to the new cea db iterators. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 45 -- 1 file changed, 45 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/dr

[Intel-gfx] [PATCH 12/19] drm/edid: convert drm_parse_cea_ext() to use cea db iter

2022-04-14 Thread Jani Nikula
Iterate through all CTA data blocks across all CTA Extensions and DisplayID data blocks. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drive

[Intel-gfx] [PATCH 16/19] drm/edid: detect basic audio in all CEA extensions

2022-04-14 Thread Jani Nikula
Convert drm_find_cea_extension() to EDID block iterator in basic audio detection. Detect basic audio in all CEA extensions. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/g

[Intel-gfx] [PATCH 15/19] drm/edid: restore some type safety to cea_db_*() functions

2022-04-14 Thread Jani Nikula
During the transition, we accepted a void pointer for a poor C programmer's version of polymorphism. Switch the functions to use struct cea_db * to regain some more type safety. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 21 + 1 file change

[Intel-gfx] [PATCH 17/19] drm/edid: detect color formats and CTA revision in all CTA extensions

2022-04-14 Thread Jani Nikula
Convert drm_find_cea_extension() to EDID block iterator in color format and CTA revision detection. Detect them in all CTA extensions. Also parse CTA Data Blocks in DisplayID even if there's no CTA EDID extension. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 24

[Intel-gfx] [PATCH 18/19] drm/edid: skip CTA extension scan in drm_edid_to_eld() just for CTA rev

2022-04-14 Thread Jani Nikula
The DisplayID CTA data block version does not necessarily match the CTA revision. Simplify by postponing drm_edid_to_eld() slightly, and reusing the CTA revision extracted by drm_parse_cea_ext(). By not bailing out early in drm_edid_to_eld() we may end up filling meaningless data to the ELD. Howev

[Intel-gfx] [PATCH 19/19] drm/edid: sunset drm_find_cea_extension()

2022-04-14 Thread Jani Nikula
Convert drm_find_cea_extension() to a predicate function to check if the EDID has a CTA extension or a DisplayID CTA data block. This is mainly to avoid adding new users that only find the first CTA extension. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 19

[Intel-gfx] [PATCH v3 2/2] drm/i915/display/psr: Clear more PSR state during disable

2022-04-14 Thread José Roberto de Souza
After commit 805f04d42a6b ("drm/i915/display/psr: Use continuos full frame to handle frontbuffer invalidations") was merged we started to get some drm_WARN_ON(&dev_priv->drm, !(tmp & PSR2_MAN_TRK_CTL_ENABLE)) in tests that are executed in pipe B. This is probably due psr2_sel_fetch_cff_enabled bei

[Intel-gfx] [PATCH v3 1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails

2022-04-14 Thread José Roberto de Souza
If any of the PSR2 checks after intel_psr2_sel_fetch_config_valid() fails, enable_psr2_sel_fetch will be kept enabled causing problems in the functions that only checks for it and not for has_psr2. So here moving the check that do not depend on enable_psr2_sel_fetch and for the remaning ones jumpi

Re: [Intel-gfx] [PATCH 2/2] drm/i915/fbc: s/false/0/

2022-04-14 Thread Navare, Manasi
On Wed, Apr 13, 2022 at 06:28:52PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > intel_fbc_check_plane() is supposed to an int, not a boolean. > So replace the bogus 'return false's with the correct 'return 0's. > These were accidental copy-paste mistakes when the code got moved > into in

Re: [Intel-gfx] [PATCH 1/2] drm/i915/fbc: Consult hw.crtc instead of uapi.crtc

2022-04-14 Thread Navare, Manasi
On Wed, Apr 13, 2022 at 06:28:51PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > plane_state->uapi.crtc is not what we want to be looking at. > If bigjoiner is used hw.crtc is what tells us what crtc the plane > is supposedly using. > > Not an actual problem on current hardware as the on

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Make the rest of the VFIO driver interface use vfio_device (rev2)

2022-04-14 Thread Patchwork
== Series Details == Series: Make the rest of the VFIO driver interface use vfio_device (rev2) URL : https://patchwork.freedesktop.org/series/102606/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/102606/revisions/2/mbox/ not applied Applying: vfi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rpl-p: Add PCI IDs

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915/rpl-p: Add PCI IDs URL : https://patchwork.freedesktop.org/series/102701/ State : success == Summary == CI Bug Log - changes from CI_DRM_11500 -> Patchwork_102701v1 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: CEA data block iterators, and more

2022-04-14 Thread Patchwork
== Series Details == Series: drm/edid: CEA data block iterators, and more URL : https://patchwork.freedesktop.org/series/102703/ State : warning == Summary == Error: dim checkpatch failed 3c1721b51008 drm/edid: reset display info in drm_add_edid_modes() for NULL edid 819f872f2dc6 drm/edid: che

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/edid: CEA data block iterators, and more

2022-04-14 Thread Patchwork
== Series Details == Series: drm/edid: CEA data block iterators, and more URL : https://patchwork.freedesktop.org/series/102703/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11500 -> Patchwork_102703v1 Summary --- *

Re: [Intel-gfx] [PATCH v5 03/10] drm/hdcp: Update property value on content type and user changes

2022-04-14 Thread Sean Paul
On Tue, Apr 12, 2022 at 09:25:59AM -0400, Rodrigo Vivi wrote: > On Mon, Apr 11, 2022 at 08:47:32PM +, Sean Paul wrote: > > From: Sean Paul > > > > This patch updates the connector's property value in 2 cases which were > > previously missed: > > > > 1- Content type changes. The value should

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/edid: low level EDID block read refactoring etc. (rev9)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/edid: low level EDID block read refactoring etc. (rev9) URL : https://patchwork.freedesktop.org/series/102329/ State : success == Summary == CI Bug Log - changes from CI_DRM_11499_full -> Patchwork_102329v9_full =

Re: [Intel-gfx] [PATCH v5 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2022-04-14 Thread Sean Paul
On Tue, Apr 12, 2022 at 09:41:35AM -0400, Rodrigo Vivi wrote: > On Mon, Apr 11, 2022 at 08:47:29PM +, Sean Paul wrote: > > From: Sean Paul > > > > Rebased set from November. Fixed a nit from Stephen in the msm patch and > > moved hdcp registers into the trogdor dtsi file to avoid differences

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915: ttm backend dont provide mmap_offset for kernel buffers

2022-04-14 Thread Robert Beckett
On 14/04/2022 15:05, Thomas Hellström wrote: On Tue, 2022-04-12 at 15:18 +, Robert Beckett wrote: stolen/kernel buffers should not be mmapable by userland. do not provide callbacks to facilitate this for these buffers. Signed-off-by: Robert Beckett ---  drivers/gpu/drm/i915/gem/i915_ge

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use i915_probe_error instead of drm_err

2022-04-14 Thread Jani Nikula
On Thu, 14 Apr 2022, "Belgaumkar, Vinay" wrote: > On 4/13/2022 11:41 PM, Anshuman Gupta wrote: >> On 2022-04-13 at 04:18:52 +0530, Vinay Belgaumkar wrote: >>> This will ensure we don't have false positives when we run >>> error injection tests. >>> >>> Signed-off-by: Vinay Belgaumkar >>> --- >>>

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use i915_probe_error instead of drm_err

2022-04-14 Thread Gupta, Anshuman
> -Original Message- > From: Belgaumkar, Vinay > Sent: Thursday, April 14, 2022 8:38 PM > To: Gupta, Anshuman > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use i915_probe_error > instead of drm_err > > > On

[Intel-gfx] ✗ Fi.CI.IGT: failure for add support for enum module parameters

2022-04-14 Thread Patchwork
== Series Details == Series: add support for enum module parameters URL : https://patchwork.freedesktop.org/series/102695/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11499_full -> Patchwork_102695v1_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/adl-n: Differentiate ADLP and ADLN steppings

2022-04-14 Thread Souza, Jose
On Wed, 2022-04-13 at 16:28 +0530, Tejas Upadhyay wrote: > ADL-N and ADL-P stepping are different, thus we > need to add check for ADL-N in IS_ADLP_DISPLAY_STEP(). > > Signed-off-by: Tejas Upadhyay > --- > drivers/gpu/drm/i915/i915_drv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails

2022-04-14 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails URL : https://patchwork.freedesktop.org/series/102704/ State : success == Summary == CI Bug Log - changes from CI_DRM_11500 -> Patchw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: CEA data block iterators, and more (rev2)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/edid: CEA data block iterators, and more (rev2) URL : https://patchwork.freedesktop.org/series/102703/ State : warning == Summary == Error: dim checkpatch failed 3bcd5f30a3e4 drm/edid: reset display info in drm_add_edid_modes() for NULL edid 4bddacab36a6 drm/ed

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915: stolen memory use ttm backend

2022-04-14 Thread Robert Beckett
On 14/04/2022 15:41, Thomas Hellström wrote: Hi, On 4/12/22 21:38, Robert Beckett wrote: +struct ttm_resource * +i915_gem_stolen_reserve_range(struct drm_i915_private *i915, +  resource_size_t size, +  u64 start, u64 end)   { -    int ret; +    struct intel_m

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: CEA data block iterators, and more (rev2)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/edid: CEA data block iterators, and more (rev2) URL : https://patchwork.freedesktop.org/series/102703/ State : success == Summary == CI Bug Log - changes from CI_DRM_11500 -> Patchwork_102703v2 Summary -

Re: [Intel-gfx] [PATCH v3] drm/i915: program wm blocks to at least blocks required per line

2022-04-14 Thread Ville Syrjälä
On Wed, Apr 06, 2022 at 08:43:11PM +0300, Vinod Govindapillai wrote: > In configurations with single DRAM channel, for usecases like > 4K 60 Hz, FIFO underruns are observed quite frequently. Looks > like the wm0 watermark values need to bumped up because the wm0 > memory latency calculations are pr

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Load DMC on DG2 (rev4)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Load DMC on DG2 (rev4) URL : https://patchwork.freedesktop.org/series/102630/ State : success == Summary == CI Bug Log - changes from CI_DRM_11500 -> Patchwork_102630v4 Summary --- **SUCCESS

Re: [Intel-gfx] [PATCH] drm/i915: Don't show client busyness in fdinfo with GuC submission

2022-04-14 Thread Ceraolo Spurio, Daniele
On 4/13/2022 3:57 PM, Ashutosh Dixit wrote: Client busyness is not available when GuC submission is used. Don't show it in fdinfo till this is supported by GuC. GuC does support this, but we don't yet have code in place in i915 to fetch the data, so this commit message needs a slightly rewo

[Intel-gfx] [PATCH v2 1/1] i915/gem: drop wbinvd_on_all_cpus usage

2022-04-14 Thread Michael Cheng
Previous concern with using drm_clflush_sg was that we don't know what the sg_table is pointing to, thus the usage of wbinvd_on_all_cpus to flush everything at once to avoid paranoia. To make i915 more architecture-neutral and be less paranoid, lets attempt to use drm_clflush_sg to flush the pages

[Intel-gfx] [PATCH v2 0/1]

2022-04-14 Thread Michael Cheng
To align with the discussion in [1][2], this patch series drops all usage of wbvind_on_all_cpus within i915 by either replacing the call with certain drm clflush helpers, or reverting to a previous logic.

[Intel-gfx] [PATCH v2 1/1] i915/gem: drop wbinvd_on_all_cpus usage

2022-04-14 Thread Michael Cheng
Previous concern with using drm_clflush_sg was that we don't know what the sg_table is pointing to, thus the usage of wbinvd_on_all_cpus to flush everything at once to avoid paranoia. To make i915 more architecture-neutral and be less paranoid, lets attempt to use drm_clflush_sg to flush the pages

[Intel-gfx] [PATCH v2 0/1] Drop wbinvd_on_all_cpus usage

2022-04-14 Thread Michael Cheng
To align with the discussion in [1][2], this patch series drops all usage of wbvind_on_all_cpus within i915 by either replacing the call with certain drm clflush helpers, or reverting to a previous logic.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/rpl-p: Add PCI IDs

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915/rpl-p: Add PCI IDs URL : https://patchwork.freedesktop.org/series/102701/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11500_full -> Patchwork_102701v1_full Summary --- **FAILUR

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v3,1/2] drm/dp: Factor out a function to probe a DPCD address (rev3)

2022-04-14 Thread Imre Deak
On Mon, Apr 11, 2022 at 08:18:39PM +, Patchwork wrote: > == Series Details == > > Series: series starting with [v3,1/2] drm/dp: Factor out a function to probe > a DPCD address (rev3) > URL : https://patchwork.freedesktop.org/series/102428/ > State : failure I pushed patch 1/2 to drm-misc-n

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't show client busyness in fdinfo with GuC submission (rev2)

2022-04-14 Thread Patchwork
== Series Details == Series: drm/i915: Don't show client busyness in fdinfo with GuC submission (rev2) URL : https://patchwork.freedesktop.org/series/102676/ State : success == Summary == CI Bug Log - changes from CI_DRM_11500 -> Patchwork_102676v2

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/1] i915/gem: drop wbinvd_on_all_cpus usage

2022-04-14 Thread Patchwork
== Series Details == Series: series starting with [v2,1/1] i915/gem: drop wbinvd_on_all_cpus usage URL : https://patchwork.freedesktop.org/series/102708/ State : warning == Summary == Error: dim checkpatch failed 5557f3ff453a i915/gem: drop wbinvd_on_all_cpus usage -:10: WARNING:COMMIT_LOG_LON

[Intel-gfx] [CI 2/4] drm/i915/doc: Convert perf UAPI comments to kerneldoc

2022-04-14 Thread Matt Roper
Convert the comments for drm_i915_query_perf_config and drm_i915_perf_oa_config to kerneldoc so that they will show up in the generated documentation. Also correct a couple places that referred to query_id when they actually meant to refer to query_item.flags. Signed-off-by: Matt Roper Reviewed

[Intel-gfx] [CI 1/4] drm/i915/doc: Convert drm_i915_query_topology_info comment to kerneldoc

2022-04-14 Thread Matt Roper
This structure has a great comment describing the fields, but it's not currently in kerneldoc form and does not show up in the generated documentation. Let's fix that and also clarify the description of what "subslice" refers to on gen12 platforms and beyond and that "slice" is no longer meaningfu

[Intel-gfx] [CI 3/4] drm/i915/doc: Link query items to their uapi structs

2022-04-14 Thread Matt Roper
Document the possible options for drm_i915_query_item.query_id with links to the corresponding uapi structures. Signed-off-by: Matt Roper Reviewed-by: Francisco Jerez --- include/uapi/drm/i915_drm.h | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff

  1   2   >