[Intel-gfx] [PATCH v9 0/3] Refactor GVT-g MMIO tracking table and handlers

2022-04-07 Thread Zhi Wang
To support the new mdev interfaces and the re-factor patches from Christoph, which moves the GVT-g code into a dedicated module, the GVT-g initialization path has to be separated into two phases: a) Early initialization. The early initialization of GVT requires to be done when loading i915. Mostl

[Intel-gfx] [PATCH v9 2/3] i915/gvt: Save the initial HW state snapshot in i915

2022-04-07 Thread Zhi Wang
Save the initial HW state snapshot in i915 so that the rest code of GVT-g can be moved into a dedicated module while it can still get a clean initial HW state saved at the correct time during the initialization of i915. The futhrer vGPU created by GVT-g will use this HW state as the initial HW stat

[Intel-gfx] [PATCH v9 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-07 Thread Zhi Wang
From: Zhi Wang To support the new mdev interfaces and the re-factor patches from Christoph, which moves the GVT-g code into a dedicated module, the GVT-g MMIO tracking table needs to be separated from GVT-g. v9: - Fix a problem might cause kernel panic. v8: - Use SPDX header in the intel_gvt_mm

[Intel-gfx] [PATCH v9 3/3] i915/gvt: Use the initial HW state snapshot saved in i915

2022-04-07 Thread Zhi Wang
The code of saving initial HW state snapshot has been moved into i915. Let the GVT-g core logic use that snapshot. Cc: Christoph Hellwig Cc: Jason Gunthorpe Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Vivi Rodrigo Cc: Zhenyu Wang Cc: Zhi Wang Signed-off-by: Zhi Wang --- drivers/gpu/drm/i915/g

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: consider min_page_size when migrating

2022-04-07 Thread Patchwork
== Series Details == Series: drm/i915: consider min_page_size when migrating URL : https://patchwork.freedesktop.org/series/102288/ State : success == Summary == CI Bug Log - changes from CI_DRM_11467_full -> Patchwork_22800_full Summary --

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Refactor GVT-g MMIO tracking table and handlers (rev2)

2022-04-07 Thread Patchwork
== Series Details == Series: Refactor GVT-g MMIO tracking table and handlers (rev2) URL : https://patchwork.freedesktop.org/series/102073/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/comp

Re: [Intel-gfx] [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-07 Thread Thomas Zimmermann
Hi Daniel Am 31.03.22 um 17:20 schrieb Daniel Vetter: The stuff never really worked, and leads to lots of fun because it out-of-order frees atomic states. Which upsets KASAN, among other things. For async updates we now have a more solid solution with the ->atomic_async_check and ->atomic_async

Re: [Intel-gfx] [PATCH v9 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-07 Thread Christoph Hellwig
The whole series looks good and works fine on by Kaby Lake Thinkpad: Reviewed-by: Christoph Hellwig Tested-by: Christoph Hellwig

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/bios: Rework BDB block handling and PNPID->panel_type matching (rev6)

2022-04-07 Thread Patchwork
== Series Details == Series: drm/i915/bios: Rework BDB block handling and PNPID->panel_type matching (rev6) URL : https://patchwork.freedesktop.org/series/102213/ State : success == Summary == CI Bug Log - changes from CI_DRM_11467_full -> Patchwork_22801_full

[Intel-gfx] [PATCH] drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A

2022-04-07 Thread Stanislav Lisovskiy
We had some FIFO underruns appearing on platforms like ADL, which could be fixed though by increasing CDCLK, however we were lacking explanation for that - we were not calculating CDCLK, also based on cumulative bpp W/A formula, mentioned in BSpec 64631. With that patch no FIFO underruns appear an

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A

2022-04-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A URL : https://patchwork.freedesktop.org/series/102322/ State : warning == Summary == $ dim checkpatch origin/drm-tip b2b7dace2671 drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A -:8

[Intel-gfx] [PULL] drm-misc-next

2022-04-07 Thread Maxime Ripard
Hi Dave, Daniel, Here's the first drm-misc-next for 5.19 Maxime drm-misc-next-2022-04-07: drm-misc-next for 5.19: UAPI Changes: Cross-subsystem Changes: Core Changes: - atomic: Add atomic_print_state to private objects - edid: Constify the EDID parsing API, rework of the API - dma-buf:

Re: [Intel-gfx] [PATCH 02/15] dma-buf: specify usage while adding fences to dma_resv obj v7

2022-04-07 Thread Daniel Vetter
On Thu, Apr 07, 2022 at 10:59:33AM +0200, Christian König wrote: > Instead of distingting between shared and exclusive fences specify > the fence usage while adding fences. > > Rework all drivers to use this interface instead and deprecate the old one. > > v2: some kerneldoc comments suggested by

[Intel-gfx] [PATCH 00/12] drm/edid: low level EDID block read refactoring etc.

2022-04-07 Thread Jani Nikula
Ever so slowly moving towards cleaner EDID reading. Jani Nikula (12): drm/edid: convert edid_is_zero() to edid_block_is_zero() for blocks drm/edid: have edid_block_check() detect blocks that are all zero drm/edid: refactor EDID block status printing drm/edid: add a helper to log dump an ED

[Intel-gfx] [PATCH 02/12] drm/edid: have edid_block_check() detect blocks that are all zero

2022-04-07 Thread Jani Nikula
We have the check function, have it also detect blocks that are all zero instead of leaving that to callers. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu

[Intel-gfx] [PATCH 03/12] drm/edid: refactor EDID block status printing

2022-04-07 Thread Jani Nikula
Split out a function to log EDID block status. The printouts get changed slightly. Unfortunately, not all users will have struct drm_device available, so we convert to pr_* debug logging instead of drm device based logging. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 75

[Intel-gfx] [PATCH 01/12] drm/edid: convert edid_is_zero() to edid_block_is_zero() for blocks

2022-04-07 Thread Jani Nikula
As edid_is_zero() is only ever used on EDID blocks, convert it to edid_block_is_zero() with implicit block size. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/d

[Intel-gfx] [PATCH 04/12] drm/edid: add a helper to log dump an EDID block

2022-04-07 Thread Jani Nikula
Unify debug log dumping. There's duplication in the error paths for EDID block validity checks, but this should be neglible. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/g

[Intel-gfx] [PATCH 05/12] drm/edid: pass struct edid to connector_bad_edid()

2022-04-07 Thread Jani Nikula
Avoid casting here and there, and make it const. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 8638e54e0879..ba54701f91f6 100644 --- a/dri

[Intel-gfx] [PATCH 06/12] drm/edid: add typedef for block read function

2022-04-07 Thread Jani Nikula
Make the callback a bit easier on the eye. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index ba54701f91f6..926ffe5cd97e 100644 --- a/driver

[Intel-gfx] [PATCH 07/12] drm/edid: abstract an EDID block read helper

2022-04-07 Thread Jani Nikula
We have an abstraction for the EDID base block read, yet duplicating the retries and error handling for extension block reads. Introduce a more generic EDID block read helper. Switch to the helper piecemeal, starting with drm_edid_get_panel_id(), which doesn't need or have access to the connector

[Intel-gfx] [PATCH 08/12] drm/edid: use EDID block read helper in drm_do_get_edid()

2022-04-07 Thread Jani Nikula
Convert drm_do_get_edit() from the base block read helper to the generic block read helper. There's quite a bit going on here, as the corrupt and null EDID information is moved back to the caller. As we see, they were not all that clear to begin with, and this change underlines that. Signed-off-by

[Intel-gfx] [PATCH 09/12] drm/edid: convert extension block read to EDID block read helper

2022-04-07 Thread Jani Nikula
Use the EDID block read helper also for extension block reads, making edid_block_read() the only place with the read retry logic. Note: We observe that drm_do_get_edid() does not use invalid extension blocks to flag the EDID as corrupt. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c

[Intel-gfx] [PATCH 10/12] drm/edid: drop extra local var

2022-04-07 Thread Jani Nikula
We don't need override as a variable for anything. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 6fa17084af02..767639364bd9 100644 --- a/drivers/g

Re: [Intel-gfx] DMA-resv usage

2022-04-07 Thread Daniel Vetter
On Thu, Apr 07, 2022 at 10:59:31AM +0200, Christian König wrote: > Hi Daniel, > > only patch #2 had some significant changes. The rest ist pretty much the > same except for the dropped exynos change and the added cleanup for the > seqlock. Reviewed that patch, I plan to do a full review of the do

[Intel-gfx] [PATCH 11/12] drm/edid: add single point of return to drm_do_get_edid()

2022-04-07 Thread Jani Nikula
This will be useful in the future. Use fail label for fail exit. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 767639364bd9..90615e30eaf5

[Intel-gfx] [PATCH 12/12] drm/edid: add EDID block count and size helpers

2022-04-07 Thread Jani Nikula
Add some helpers to figure out the EDID extension block count, block count, size, pointers to blocks. Unfortunately, we'll need to cast away the const in a few places where we actually need to access the data. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 78 ++

Re: [Intel-gfx] [PATCH 15/15] seqlock: drop seqcount_ww_mutex_t

2022-04-07 Thread Daniel Vetter
On Thu, Apr 07, 2022 at 10:59:46AM +0200, Christian König wrote: > Daniel pointed out that this series removes the last user of > seqcount_ww_mutex_t, so let's drop this. > > Signed-off-by: Christian König > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Will Deacon > Cc: Waiman Long > Cc: Boqun

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A

2022-04-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A URL : https://patchwork.freedesktop.org/series/102322/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h K

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A

2022-04-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A URL : https://patchwork.freedesktop.org/series/102322/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11469 -> Patchwork_22807 Su

Re: [Intel-gfx] [PATCH 15/15] seqlock: drop seqcount_ww_mutex_t

2022-04-07 Thread Peter Zijlstra
On Thu, Apr 07, 2022 at 10:59:46AM +0200, Christian König wrote: > Daniel pointed out that this series removes the last user of > seqcount_ww_mutex_t, so let's drop this. > > Signed-off-by: Christian König Acked-by: Peter Zijlstra (Intel)

Re: [Intel-gfx] [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-07 Thread Daniel Vetter
On Thu, Apr 07, 2022 at 09:49:49AM +0200, Thomas Zimmermann wrote: > Hi Daniel > > Am 31.03.22 um 17:20 schrieb Daniel Vetter: > > The stuff never really worked, and leads to lots of fun because it > > out-of-order frees atomic states. Which upsets KASAN, among other > > things. > > > > For async

Re: [Intel-gfx] [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-07 Thread Daniel Vetter
On Wed, Apr 06, 2022 at 06:27:00PM -0700, Jessica Zhang wrote: > > > On 3/31/2022 8:20 AM, Daniel Vetter wrote: > > The stuff never really worked, and leads to lots of fun because it > > out-of-order frees atomic states. Which upsets KASAN, among other > > things. > > > > For async updates we no

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/rps: Centralize computation of freq caps (rev6)

2022-04-07 Thread Patchwork
== Series Details == Series: drm/i915/rps: Centralize computation of freq caps (rev6) URL : https://patchwork.freedesktop.org/series/101606/ State : success == Summary == CI Bug Log - changes from CI_DRM_11467_full -> Patchwork_22802_full S

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A

2022-04-07 Thread Lisovskiy, Stanislav
gt@i915_selftest@live@coherency failure on bdw, sure doesn't have anything with this patch :D Restarted test run in hopes.. Best Regards, Lisovskiy Stanislav Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo From: Patchwork

Re: [Intel-gfx] [PATCH v2 01/22] drm/i915/bios: Use the cached BDB version

2022-04-07 Thread Jani Nikula
On Tue, 05 Apr 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > We have the BDB version cached, use it. We're going to have to > start doing some of the BDB block parsing later, at which point > we may no longer have the VBT around anymore (we free it at the > end of intel_bios_init() when it

Re: [Intel-gfx] [PATCH v3 02/22] drm/i915/bios: Make copies of VBT data blocks

2022-04-07 Thread Jani Nikula
On Wed, 06 Apr 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Make a copy of each VB data block with a guaranteed minimum > size. The extra (if any) will just be left zeroed. > > This means we don't have to worry about going out of bounds > when accessing any of the structure members. Other

Re: [Intel-gfx] [PATCH v9 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-07 Thread Wang, Zhi A
Thanks so much! Jani and Joonas, it would be better to have one rb from i915 maintainers as this patches also modify i915 code. Thanks, Zhi. On 4/7/22 8:06 AM, Christoph Hellwig wrote: > The whole series looks good and works fine on by Kaby Lake Thinkpad: > > Reviewed-by: Christoph Hellwig >

Re: [Intel-gfx] [PATCH v2 03/22] drm/i915/bios: Use the copy of the LFP data table always

2022-04-07 Thread Jani Nikula
On Tue, 05 Apr 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently get_lvds_fp_timing() still returns a pointer to the original > data block rather than our copy. Let's convert the data pointer offsets > to be relative to the data block rather than the whole BDB. With that > we can mak

[Intel-gfx] [PULL] drm-misc-next-fixes

2022-04-07 Thread Maarten Lankhorst
drm-misc-next-fixes-2022-04-07: drm-misc-next-fixes for v5.18-rc2: - fix warning about fence containers - fix logic error in new fence merge code - handle empty dma_fence_arrays gracefully - Try all possible cases for bridge/panel detection. The following changes since commit 7344bad7fb6daa4877a1c0

[Intel-gfx] [PULL] drm-misc-fixes

2022-04-07 Thread Maarten Lankhorst
drm-misc-fixes-2022-04-07: drm-misc-fixes for v5.18-rc2: - Fix a crash when booting with nouveau on tegra. - Don't require input port for MIPI-DSI, and make width/height mandatory. - Fix unregistering of framebuffers without device. - The following changes since commit 3123109284176b1532874591f7c81

[Intel-gfx] [PATCH 2/2] drm/i915/buddy: sanity check the size

2022-04-07 Thread Matthew Auld
Ensure we check that the size is compatible with the requested page_size. For tiny objects that are automatically annotated with TTM_PL_FLAG_CONTIGUOUS(since they fit within a single page), we currently end up silently overriding the min_page_size, which ends up hiding bugs elsewhere. Signed-off-b

[Intel-gfx] [PATCH 1/2] drm/i915: consider min_page_size when migrating

2022-04-07 Thread Matthew Auld
We can only force migrate an object if the existing object size is compatible with the new destinations min_page_size for the region. Currently we blow up with something like: [ 2857.497462] kernel BUG at drivers/gpu/drm/i915/gt/intel_migrate.c:431! [ 2857.497497] invalid opcode: [#1] PREEMPT

Re: [Intel-gfx] [PATCH] drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A

2022-04-07 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 11:42:35AM +0300, Stanislav Lisovskiy wrote: > We had some FIFO underruns appearing on platforms like ADL, > which could be fixed though by increasing CDCLK, however we were > lacking explanation for that - we were not calculating CDCLK, > also based on cumulative bpp W/A fo

Re: [Intel-gfx] [PATCH v3 02/22] drm/i915/bios: Make copies of VBT data blocks

2022-04-07 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 01:23:38PM +0300, Jani Nikula wrote: > On Wed, 06 Apr 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Make a copy of each VB data block with a guaranteed minimum > > size. The extra (if any) will just be left zeroed. > > > > This means we don't have to worry abo

Re: [Intel-gfx] [PATCH] drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A

2022-04-07 Thread Lisovskiy, Stanislav
On Thu, Apr 07, 2022 at 02:10:52PM +0300, Ville Syrjälä wrote: > On Thu, Apr 07, 2022 at 11:42:35AM +0300, Stanislav Lisovskiy wrote: > > We had some FIFO underruns appearing on platforms like ADL, > > which could be fixed though by increasing CDCLK, however we were > > lacking explanation for that

Re: [Intel-gfx] [PATCH] drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A

2022-04-07 Thread Lisovskiy, Stanislav
On Thu, Apr 07, 2022 at 02:10:52PM +0300, Ville Syrjälä wrote: > On Thu, Apr 07, 2022 at 11:42:35AM +0300, Stanislav Lisovskiy wrote: > > We had some FIFO underruns appearing on platforms like ADL, > > which could be fixed though by increasing CDCLK, however we were > > lacking explanation for that

Re: [Intel-gfx] [PULL] drm-misc-next-fixes

2022-04-07 Thread Maxime Ripard
Hi On Thu, Apr 07, 2022 at 12:56:27PM +0200, Maarten Lankhorst wrote: > drm-misc-next-fixes-2022-04-07: > drm-misc-next-fixes for v5.18-rc2: > - fix warning about fence containers > - fix logic error in new fence merge code > - handle empty dma_fence_arrays gracefully > - Try all possible cases fo

Re: [Intel-gfx] [PATCH 03/12] drm/edid: refactor EDID block status printing

2022-04-07 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 12:14:29PM +0300, Jani Nikula wrote: > Split out a function to log EDID block status. The printouts get changed > slightly. > > Unfortunately, not all users will have struct drm_device available, so > we convert to pr_* debug logging instead of drm device based logging. >

Re: [Intel-gfx] [PATCH 05/12] drm/edid: pass struct edid to connector_bad_edid()

2022-04-07 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 12:14:31PM +0300, Jani Nikula wrote: > Avoid casting here and there, and make it const. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 15 ++- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b

Re: [Intel-gfx] [PATCH] drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A

2022-04-07 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 02:24:17PM +0300, Lisovskiy, Stanislav wrote: > On Thu, Apr 07, 2022 at 02:10:52PM +0300, Ville Syrjälä wrote: > > On Thu, Apr 07, 2022 at 11:42:35AM +0300, Stanislav Lisovskiy wrote: > > > We had some FIFO underruns appearing on platforms like ADL, > > > which could be fixe

Re: [Intel-gfx] [PATCH 06/12] drm/edid: add typedef for block read function

2022-04-07 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 12:14:32PM +0300, Jani Nikula wrote: > Make the callback a bit easier on the eye. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/dr

Re: [Intel-gfx] [PATCH v3 02/22] drm/i915/bios: Make copies of VBT data blocks

2022-04-07 Thread Jani Nikula
On Thu, 07 Apr 2022, Ville Syrjälä wrote: > On Thu, Apr 07, 2022 at 01:23:38PM +0300, Jani Nikula wrote: >> On Wed, 06 Apr 2022, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > Make a copy of each VB data block with a guaranteed minimum >> > size. The extra (if any) will just be left zer

Re: [Intel-gfx] [PATCH] drm/i915: program wm blocks to at least blocks required per line

2022-04-07 Thread Govindapillai, Vinod
On Thu, 2022-04-07 at 09:43 +0300, Lisovskiy, Stanislav wrote: > On Wed, Apr 06, 2022 at 09:09:06PM +0300, Ville Syrjälä wrote: > > On Wed, Apr 06, 2022 at 08:14:58PM +0300, Lisovskiy, Stanislav wrote: > > > On Wed, Apr 06, 2022 at 05:01:39PM +0300, Ville Syrjälä wrote: > > > > On Wed, Apr 06, 2022

Re: [Intel-gfx] [PATCH v3 02/22] drm/i915/bios: Make copies of VBT data blocks

2022-04-07 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 03:06:04PM +0300, Jani Nikula wrote: > On Thu, 07 Apr 2022, Ville Syrjälä wrote: > > On Thu, Apr 07, 2022 at 01:23:38PM +0300, Jani Nikula wrote: > >> On Wed, 06 Apr 2022, Ville Syrjala wrote: > >> > From: Ville Syrjälä > >> > > >> > Make a copy of each VB data block with

Re: [Intel-gfx] [PATCH v3 08/22] drm/i915/bios: Generate LFP data table pointers if the VBT lacks them

2022-04-07 Thread Jani Nikula
On Wed, 06 Apr 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Modern VBTs no longer contain the LFP data table pointers > block (41). We are expecting to have one in order to be able > to parse the LFP data block (42), so let's make one up. Bspec says, "These fields are used by the BMP too

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/edid: low level EDID block read refactoring etc.

2022-04-07 Thread Patchwork
== Series Details == Series: drm/edid: low level EDID block read refactoring etc. URL : https://patchwork.freedesktop.org/series/102329/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compil

Re: [Intel-gfx] [PATCH 15/15] drm/i915/xehp: Eliminate shared/implicit steering

2022-04-07 Thread Tvrtko Ursulin
On 04/04/2022 22:35, Matt Roper wrote: On Thu, Mar 31, 2022 at 06:35:52PM +0100, Tvrtko Ursulin wrote: On 31/03/2022 00:28, Matt Roper wrote: Historically we've selected and programmed a single MCR group/instance ID at driver startup that will steer register accesses for GSLICE/DSS ranges to

Re: [Intel-gfx] [PATCH v3 08/22] drm/i915/bios: Generate LFP data table pointers if the VBT lacks them

2022-04-07 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 03:24:15PM +0300, Jani Nikula wrote: > On Wed, 06 Apr 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Modern VBTs no longer contain the LFP data table pointers > > block (41). We are expecting to have one in order to be able > > to parse the LFP data block (42),

Re: [Intel-gfx] [PATCH 15/15] drm/i915/xehp: Eliminate shared/implicit steering

2022-04-07 Thread Tvrtko Ursulin
On 04/04/2022 22:42, Matt Roper wrote: On Fri, Apr 01, 2022 at 09:34:04AM +0100, Tvrtko Ursulin wrote: On 31/03/2022 00:28, Matt Roper wrote: Historically we've selected and programmed a single MCR group/instance ID at driver startup that will steer register accesses for GSLICE/DSS ranges to

Re: [Intel-gfx] [PATCH] drm/i915: program wm blocks to at least blocks required per line

2022-04-07 Thread Lisovskiy, Stanislav
On Thu, Apr 07, 2022 at 03:09:48PM +0300, Govindapillai, Vinod wrote: > On Thu, 2022-04-07 at 09:43 +0300, Lisovskiy, Stanislav wrote: > > On Wed, Apr 06, 2022 at 09:09:06PM +0300, Ville Syrjälä wrote: > > > On Wed, Apr 06, 2022 at 08:14:58PM +0300, Lisovskiy, Stanislav wrote: > > > > On Wed, Apr 0

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/atomic-helpers: remove legacy_cursor_update hacks (rev2)

2022-04-07 Thread Patchwork
== Series Details == Series: drm/atomic-helpers: remove legacy_cursor_update hacks (rev2) URL : https://patchwork.freedesktop.org/series/102028/ State : warning == Summary == $ dim checkpatch origin/drm-tip dfd8d6b68c5c drm/atomic-helpers: remove legacy_cursor_update hacks -:29: ERROR:GIT_COMM

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/edid: low level EDID block read refactoring etc.

2022-04-07 Thread Jani Nikula
On Thu, 07 Apr 2022, Patchwork wrote: > == Series Details == > > Series: drm/edid: low level EDID block read refactoring etc. > URL : https://patchwork.freedesktop.org/series/102329/ > State : failure > > == Summary == > > CALLscripts/checksyscalls.sh > CALLscripts/atomic/check-atomics

Re: [Intel-gfx] [PATCH 00/12] drm/edid: low level EDID block read refactoring etc.

2022-04-07 Thread Ville Syrjälä
On Thu, Apr 07, 2022 at 12:14:26PM +0300, Jani Nikula wrote: > Ever so slowly moving towards cleaner EDID reading. > > Jani Nikula (12): > drm/edid: convert edid_is_zero() to edid_block_is_zero() for blocks > drm/edid: have edid_block_check() detect blocks that are all zero > drm/edid: refac

[Intel-gfx] [PATCH 00/20] GSC support for XeHP SDV and DG2 platforms

2022-04-07 Thread Alexander Usyskin
Add GSC support for XeHP SDV and DG2 platforms. The series includes changes for the mei driver: - add ability to use polling instead of interrupts - add ability to use extended timeouts - setup extended operational memory for GSC The series includes changes for the i915 driver: - allocate extende

[Intel-gfx] [PATCH 01/20] drm/i915/gsc: add gsc as a mei auxiliary device

2022-04-07 Thread Alexander Usyskin
From: Tomas Winkler GSC is a graphics system controller, it provides a chassis controller for graphics discrete cards. There are two MEI interfaces in GSC: HECI1 and HECI2. Both interfaces are on the BAR0 at offsets 0x00258000 and 0x00259000. GSC is a GT Engine (class 4: instance 6). HECI1 inte

[Intel-gfx] [PATCH 02/20] mei: add support for graphics system controller (gsc) devices

2022-04-07 Thread Alexander Usyskin
From: Tomas Winkler GSC is a graphics system controller, based on CSE, it provides a chassis controller for graphics discrete cards, as well as it supports media protection on selected devices. mei_gsc binds to a auxiliary devices exposed by Intel discrete driver i915. Signed-off-by: Alexander

[Intel-gfx] [PATCH 03/20] mei: gsc: setup char driver alive in spite of firmware handshake failure

2022-04-07 Thread Alexander Usyskin
Setup char device in spite of firmware handshake failure. In order to provide host access to the firmware status registers and other information required for the manufacturing process. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Reviewed-by: Daniele Ceraolo Spurio --- drivers

[Intel-gfx] [PATCH 04/20] mei: gsc: add runtime pm handlers

2022-04-07 Thread Alexander Usyskin
From: Tomas Winkler Implement runtime handlers for mei-gsc, to track idle state of the device properly. CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin Reviewed-by: Rodrigo Vivi --- drivers/misc/mei/gsc-me.c | 67 ++- 1 file

[Intel-gfx] [PATCH 05/20] mei: gsc: retrieve the firmware version

2022-04-07 Thread Alexander Usyskin
Add a hook to retrieve the firmware version of the GSC devices to bus-fixup. GSC has a different MKHI clients GUIDs but the same message structure to retrieve the firmware version as MEI so mei_fwver() can be reused. CC: Ashutosh Dixit Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkle

[Intel-gfx] [PATCH 06/20] HAX: drm/i915: force INTEL_MEI_GSC on for CI

2022-04-07 Thread Alexander Usyskin
From: Daniele Ceraolo Spurio After the new config option is merged we'll enable it by default in the CI config, but for now just force it on via the i915 Kconfig so we can get pre-merge CI results for it. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/Kconfig.debug | 1 + 1 fil

[Intel-gfx] [PATCH 07/20] drm/i915/gsc: skip irq initialization if using polling

2022-04-07 Thread Alexander Usyskin
From: Vitaly Lubart If we use polling instead of interrupts, irq initialization should be skipped. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/gt/intel_gsc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(

[Intel-gfx] [PATCH 08/20] drm/i915/gsc: add slow_fw flag to the mei auxiliary device

2022-04-07 Thread Alexander Usyskin
Add slow_fw flag to the mei auxiliary device info to inform the mei driver about slow underlying firmware. Such firmware will require to use larger operation timeouts. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- include/linux/mei_aux.h | 1 + 1 file changed, 1 insertion(+)

[Intel-gfx] [PATCH 09/20] drm/i915/gsc: add slow_fw flag to the gsc device definition

2022-04-07 Thread Alexander Usyskin
Add slow_fw flag to the gsc device definition and pass it to mei auxiliary device. Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/gt/intel_gsc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gsc.c b/drivers/gpu/drm/i915/gt/intel_gsc.c index 280db

[Intel-gfx] [PATCH 10/20] drm/i915/gsc: add GSC XeHP SDV platform definition

2022-04-07 Thread Alexander Usyskin
Define GSC on XeHP SDV (Intel(R) dGPU without display) XeHP SDV uses the same hardware settings as DG1, but uses polling instead of interrupts and runs the firmware in slow pace due to hardware limitations. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usysk

[Intel-gfx] [PATCH 11/20] mei: gsc: use polling instead of interrupts

2022-04-07 Thread Alexander Usyskin
From: Tomas Winkler A work-around for a HW issue in XEHPSDV that manifests itself when SW reads a gsc register when gsc is sending an interrupt. The work-around is to disable interrupts and to use polling instead. Cc: James Ausmus Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler ---

[Intel-gfx] [PATCH 12/20] mei: gsc: wait for reset thread on stop

2022-04-07 Thread Alexander Usyskin
Wait for reset work to complete before initiating stop reset flow sequence. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c index eb052005ca86..5bb6b

[Intel-gfx] [PATCH 13/20] mei: extend timeouts on slow devices.

2022-04-07 Thread Alexander Usyskin
Parametrize operational timeouts in order to support slow firmware on some graphic devices. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 3 +-- drivers/misc/mei/client.c| 14 +++--- drivers/misc/mei/gsc-me.c| 2 +- drivers/mi

[Intel-gfx] [PATCH 16/20] mei: mkhi: add memory ready command

2022-04-07 Thread Alexander Usyskin
From: Tomas Winkler Add GSC memory ready command. The command indicates to the firmware that extend operation memory was setup and the firmware may enter PXP mode. CC: Daniele Ceraolo Spurio Signed-off-by: Tomas Winkler --- drivers/misc/mei/mkhi.h | 14 +- 1 file changed, 13 inser

[Intel-gfx] [PATCH 14/20] drm/i915/dg2: add gsc with special gsc bar offsets

2022-04-07 Thread Alexander Usyskin
From: Tomas Winkler DG2 uses different GSC offsets on memory bar and uses PXP head (HECI1). Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/gpu/drm/i915/gt/intel_gsc.c | 15 +++ drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 17/20] mei: gsc: setup gsc extended operational memory

2022-04-07 Thread Alexander Usyskin
From: Tomas Winkler 1. Retrieve extended operational memory physical pointers from the auxiliary device info. 2. Setup memory registers. 3. Notify firmware that the memory is ready by sending the memory ready command. 4. Disable PXP device if GSC is not in PXP mode. CC: Daniele Ceraolo Spu

[Intel-gfx] [PATCH 18/20] mei: gsc: add transition to PXP mode in resume flow

2022-04-07 Thread Alexander Usyskin
From: Vitaly Lubart Added transition to PXP mode in resume flow. CC: Daniele Ceraolo Spurio Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/gsc-me.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gs

[Intel-gfx] [PATCH 15/20] mei: bus: export common mkhi definitions into a separate header

2022-04-07 Thread Alexander Usyskin
From: Vitaly Lubart Exported common mkhi definitions from bus-fixup.c into a separate header file mkhi.h for other driver usage. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 32 ++--- drivers/misc/mei/mkhi.h | 45 +++

[Intel-gfx] [PATCH 19/20] mei: debugfs: add pxp mode to devstate in debugfs

2022-04-07 Thread Alexander Usyskin
From: Tomas Winkler CC: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/debugfs.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c index 1ce61e9e24fc..4074fec866a6 100644 --- a/drivers/misc/mei/debugf

[Intel-gfx] [PATCH 20/20] drm/i915/gsc: allocate extended operational memory in LMEM

2022-04-07 Thread Alexander Usyskin
From: Tomas Winkler GSC requires more operational memory than available on chip. Reserve 4M of LMEM for GSC operation. The memory is provided to the GSC as struct resource to the auxiliary data of the child device. Signed-off-by: Tomas Winkler Signed-off-by: Daniele Ceraolo Spurio Cc: Alan Pre

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/atomic-helpers: remove legacy_cursor_update hacks (rev2)

2022-04-07 Thread Patchwork
== Series Details == Series: drm/atomic-helpers: remove legacy_cursor_update hacks (rev2) URL : https://patchwork.freedesktop.org/series/102028/ State : success == Summary == CI Bug Log - changes from CI_DRM_11471 -> Patchwork_22809 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A (rev2)

2022-04-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A (rev2) URL : https://patchwork.freedesktop.org/series/102322/ State : warning == Summary == $ dim checkpatch origin/drm-tip c1adc525a765 drm/i915: Fix FIFO underruns caused by missing cumulative bpp

Re: [Intel-gfx] [PATCH 02/15] dma-buf: specify usage while adding fences to dma_resv obj v7

2022-04-07 Thread Javier Martinez Canillas
Hello Christian, On 4/7/22 10:59, Christian König wrote: > Instead of distingting between shared and exclusive fences specify > the fence usage while adding fences. > > Rework all drivers to use this interface instead and deprecate the old one. > This patch broke compilation for the vc4 DRM dri

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pmu: Drop redundant IS_VALLEYVIEW check in __get_rc6() (rev2)

2022-04-07 Thread Tvrtko Ursulin
On 06/04/2022 12:10, Gupta, Anshuman wrote: -Original Message- From: Tvrtko Ursulin Sent: Wednesday, April 6, 2022 4:23 PM To: Gupta, Anshuman ; intel- g...@lists.freedesktop.org Subject: Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pmu: Drop redundant IS_VALLEYVIEW check in __get

Re: [Intel-gfx] [PATCH 02/15] dma-buf: specify usage while adding fences to dma_resv obj v7

2022-04-07 Thread Javier Martinez Canillas
On 4/7/22 15:13, Christian König wrote: > Am 07.04.22 um 15:08 schrieb Javier Martinez Canillas: >> Hello Christian, >> >> On 4/7/22 10:59, Christian König wrote: >>> Instead of distingting between shared and exclusive fences specify >>> the fence usage while adding fences. >>> >>> Rework all drive

Re: [Intel-gfx] [PATCH] drm/i915/rps: Centralize computation of freq caps

2022-04-07 Thread Gupta, Anshuman
> -Original Message- > From: Dixit, Ashutosh > Sent: Thursday, April 7, 2022 12:49 AM > To: intel-gfx@lists.freedesktop.org > Cc: Gupta, Anshuman > Subject: [PATCH] drm/i915/rps: Centralize computation of freq caps > > Freq caps (i.e. RP0, RP1 and RPn frequencies) are read from HW. Ho

Re: [Intel-gfx] [PATCH 4/4] drm/i915/dg2: Add support for DG2 clear color compression

2022-04-07 Thread Imre Deak
On Thu, Apr 07, 2022 at 08:47:13AM +0300, Gupta, Anshuman wrote: > > -Original Message- > > From: Deak, Imre > > Sent: Monday, April 4, 2022 7:09 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Gupta, Anshuman ; Kahola, Mika > > ; Heikkila, Juha-pekka > pekka.heikk...@intel.com>; C, Ra

Re: [Intel-gfx] [PATCH 2/4] drm/i915/dg2: Add support for DG2 render and media compression

2022-04-07 Thread Juha-Pekka Heikkila
Reviewed-by: Juha-Pekka Heikkila On 4.4.2022 16.38, Imre Deak wrote: From: Matt Roper Add support for DG2 render and media compression, for the description of buffer layouts see the previous patch adding the corresponding frame buffer modifiers. v2: Display version fix [Imre] v3: Split

Re: [Intel-gfx] [PATCH 3/4] drm/fourcc: Introduce format modifier for DG2 clear color

2022-04-07 Thread Juha-Pekka Heikkila
Reviewed-by: Juha-Pekka Heikkila On 4.4.2022 16.38, Imre Deak wrote: From: Mika Kahola DG2 clear color render compression uses Tile4 layout. Therefore, we need to define a new format modifier for uAPI to support clear color rendering. v2: Display version is fixed. [Imre] KDoc is enhanc

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A (rev2)

2022-04-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A (rev2) URL : https://patchwork.freedesktop.org/series/102322/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11471 -> Patchwork_22810 =

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A (rev2)

2022-04-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix FIFO underruns caused by missing cumulative bpp W/A (rev2) URL : https://patchwork.freedesktop.org/series/102322/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/comp

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix warnings about PSR lock not held

2022-04-07 Thread Hogander, Jouni
On Wed, 2022-04-06 at 14:05 -0700, José Roberto de Souza wrote: > Commit 3b6f409547fb ("drm/i915/display/psr: Lock and unlock PSR > around > pipe updates") did not took into account async flips with PSR1 and > PSR2 HW tracking, causing PSR lock not be held and causing warnings > when intel_psr2_pro

Re: [Intel-gfx] [PATCH v9 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-07 Thread Zhenyu Wang
On 2022.04.07 03:19:43 -0400, Zhi Wang wrote: > From: Zhi Wang > > To support the new mdev interfaces and the re-factor patches from > Christoph, which moves the GVT-g code into a dedicated module, the GVT-g > MMIO tracking table needs to be separated from GVT-g. > Looks fine to me. Thanks! Rev

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/rps: Centralize computation of freq caps (rev6)

2022-04-07 Thread Anshuman Gupta
On 2022-04-07 at 09:44:48 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/rps: Centralize computation of freq caps (rev6) > URL : https://patchwork.freedesktop.org/series/101606/ > State : success Pushed to drm-intel-gt-next. Thanks for patch and review. Br, Anshuman. > > ==

Re: [Intel-gfx] [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-04-07 Thread Paul Menzel
Dear Arunpravin, Thank you for your patch. Am 07.04.22 um 07:46 schrieb Arunpravin Paneer Selvam: - Switch to drm buddy allocator - Add resource cursor support for drm buddy I though after the last long discussion, you would actually act on the review comments. Daniel wrote a good summary,

  1   2   >