Re: [Intel-gfx] [PATCH] drm/i915/rps: Centralize computation of freq caps

2022-03-23 Thread Nilawar, Badal
On 23-03-2022 00:26, Ashutosh Dixit wrote: Freq caps (i.e. RP0, RP1 and RPn frequencies) are read from HW. However the formats (bit positions, widths, registers and units) of these vary for different generations with even more variations arriving in the future. In order not to have to do ident

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/edid: overhaul CEA data block iteration

2022-03-23 Thread Patchwork
== Series Details == Series: drm/edid: overhaul CEA data block iteration URL : https://patchwork.freedesktop.org/series/101659/ State : success == Summary == CI Bug Log - changes from CI_DRM_11397_full -> Patchwork_22648_full Summary --

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/amdgpu: add drm buddy support to amdgpu (rev2)

2022-03-23 Thread Patchwork
== Series Details == Series: drm/amdgpu: add drm buddy support to amdgpu (rev2) URL : https://patchwork.freedesktop.org/series/100908/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.

[Intel-gfx] [PATCH] [topic/core-for-CI] Revert "drm/i915/dg2: Add relocation exception"

2022-03-23 Thread Zbigniew Kempczyński
This reverts commit 904ebf2ba89edaeba5c7c10540e43dba63541dc6. Failures on dg2 tests were caused by invalid alignment when local memory was in use. Changes which adopt alignment according to gen were already merged in IGT so lets revert relocation temporary enabler for dg2. Keeping it is a little b

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/4] drm/i915/display: Program PIPE_MBUS_DBOX_CTL with adl-p values

2022-03-23 Thread Patchwork
== Series Details == Series: series starting with [v2,1/4] drm/i915/display: Program PIPE_MBUS_DBOX_CTL with adl-p values URL : https://patchwork.freedesktop.org/series/101661/ State : success == Summary == CI Bug Log - changes from CI_DRM_11397_full -> Patchwork_22649_full ==

[Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Paul Menzel
Dear Christian, Am 23.03.22 um 08:42 schrieb Christian König: Am 23.03.22 um 07:42 schrieb Paul Menzel: Am 23.03.22 um 07:25 schrieb Arunpravin Paneer Selvam: - Remove drm_mm references and replace with drm buddy functionalities The commit message summary to me suggested, you can somehow

[Intel-gfx] [PATCH v4 0/3] Improve on resume time with VT-d enabled

2022-03-23 Thread Thomas Hellström
When DMAR / VT-d is enabled, the display engine uses overfetching, presumably to deal with the increased latency. To avoid display engine errors and DMAR faults, as a workaround the GGTT is populated with scatch PTEs when VT-d is enabled. However starting with gen10, Write-combined writing of scrat

[Intel-gfx] [PATCH v4 1/3] drm/i915: Wrap all access to i915_vma.node.start|size

2022-03-23 Thread Thomas Hellström
From: Chris Wilson We already wrap i915_vma.node.start for use with the GGTT, as there we can perform additional sanity checks that the node belongs to the GGTT and fits within the 32b registers. In the next couple of patches, we will introduce guard pages around the objects _inside_ the drm_mm_n

[Intel-gfx] [PATCH v4 2/3] drm/i915: Introduce guard pages to i915_vma

2022-03-23 Thread Thomas Hellström
From: Chris Wilson Introduce the concept of padding the i915_vma with guard pages before and aft. The major consequence is that all ordinary uses of i915_vma must use i915_vma_offset/i915_vma_size and not i915_vma.node.start/size directly, as the drm_mm_node will include the guard pages that surr

[Intel-gfx] [PATCH v4 3/3] drm/i915: Refine VT-d scanout workaround

2022-03-23 Thread Thomas Hellström
From: Chris Wilson VT-d may cause overfetch of the scanout PTE, both before and after the vma (depending on the scanout orientation). bspec recommends that we provide a tile-row in either directions, and suggests using 168 PTE, warning that the accesses will wrap around the ends of the GGTT. Curr

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Revert "drm/i915/dg2: Add relocation exception"

2022-03-23 Thread Patchwork
== Series Details == Series: Revert "drm/i915/dg2: Add relocation exception" URL : https://patchwork.freedesktop.org/series/101669/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_enable' not found

[Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "drm/i915/dg2: Add relocation exception"

2022-03-23 Thread Patchwork
== Series Details == Series: Revert "drm/i915/dg2: Add relocation exception" URL : https://patchwork.freedesktop.org/series/101669/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11397 -> Patchwork_22652 Summary --- *

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm: add a check to verify the size alignment (rev2)

2022-03-23 Thread Patchwork
== Series Details == Series: drm: add a check to verify the size alignment (rev2) URL : https://patchwork.freedesktop.org/series/101569/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_enable' not f

Re: [Intel-gfx] [v2] drm/edid: check basic audio support on CEA extension block

2022-03-23 Thread Jani Nikula
On Wed, 23 Mar 2022, Lee Shawn C wrote: > From: Cooper Chiou > > Tag code stored in bit7:5 for CTA block byte[3] is not the same as > CEA extension block definition. Only check CEA block has > basic audio support. > > Cc: Jani Nikula > Cc: Shawn C Lee > Cc: intel-gfx > Signed-off-by: Cooper Ch

[Intel-gfx] [PATCH v5 2/2] drm/i915/intel_combo_phy: Print I/O voltage info

2022-03-23 Thread Ankit Nautiyal
Print I/O voltage and process info for each combo phy ports. v2: Used drm_dbg_kms for logs. (Jani) Added names for different voltage levels. (Imre) v3: Used const char * for names. (Jani) v4: Dropped the procom values and changed commit msg (Imre) Suggested-by: Imre Deak Signed-off-by: Ankit N

[Intel-gfx] [PATCH] drm/i915: Decouple engine->sanitize callback on removing the status page

2022-03-23 Thread Gwan-gyeong Mun
From: Chris Wilson We have to be careful not to call into the submission backend's sanitize callback if we abort the module load and free the status page. Since we are only using the sanitize callback to cleanup the status page when we suspect its contents may have been lost (first load, upon res

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/edid: filter DisplayID v2.0 CTA block in audio detection (rev2)

2022-03-23 Thread Patchwork
== Series Details == Series: drm/edid: filter DisplayID v2.0 CTA block in audio detection (rev2) URL : https://patchwork.freedesktop.org/series/101565/ State : success == Summary == CI Bug Log - changes from CI_DRM_11397_full -> Patchwork_22650_full

Re: [Intel-gfx] [PATCH] drm/edid: filter DisplayID v2.0 CTA block in audio detection

2022-03-23 Thread Jani Nikula
On Mon, 21 Mar 2022, Cooper Chiou wrote: > In DisplayID v2.0 CTS data block 0x81 case, there is no any audio > information definition, but drm_detect_monitor_audio didn't filter > it so that it caused eDP dummy audio card be detected improperly. > > We observed this issue on some AUO/BOE eDP panel

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: add a check to verify the size alignment (rev2)

2022-03-23 Thread Patchwork
== Series Details == Series: drm: add a check to verify the size alignment (rev2) URL : https://patchwork.freedesktop.org/series/101569/ State : success == Summary == CI Bug Log - changes from CI_DRM_11397 -> Patchwork_22653 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Improve on resume time with VT-d enabled

2022-03-23 Thread Patchwork
== Series Details == Series: Improve on resume time with VT-d enabled URL : https://patchwork.freedesktop.org/series/101676/ State : warning == Summary == $ dim checkpatch origin/drm-tip f21c5b663eaf drm/i915: Wrap all access to i915_vma.node.start|size b41b256f8934 drm/i915: Introduce guard p

[Intel-gfx] [PATCH] drm/edid: fix CEA extension byte #3 parsing

2022-03-23 Thread Jani Nikula
Only an EDID CEA extension has byte #3, while the CTA DisplayID Data Block does not. Don't interpret bogus data for color formats. For most displays it's probably an unlikely scenario you'd have a CTA DisplayID Data Block without a CEA extension, but they do exist. Fixes: e28ad544f462 ("drm/edid:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Improve on resume time with VT-d enabled

2022-03-23 Thread Patchwork
== Series Details == Series: Improve on resume time with VT-d enabled URL : https://patchwork.freedesktop.org/series/101676/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Improve on resume time with VT-d enabled

2022-03-23 Thread Patchwork
== Series Details == Series: Improve on resume time with VT-d enabled URL : https://patchwork.freedesktop.org/series/101676/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_enable' not found ./drive

Re: [Intel-gfx] [v8 3/5] drm/edid: read HF-EEODB ext block

2022-03-23 Thread Jani Nikula
On Thu, 17 Mar 2022, Lee Shawn C wrote: > According to HDMI 2.1 spec. > > "The HDMI Forum EDID Extension Override Data Block (HF-EEODB) > is utilized by Sink Devices to provide an alternate method to > indicate an EDID Extension Block count larger than 1, while > avoiding the need to present a VES

Re: [Intel-gfx] [PATCH] drm/edid: filter DisplayID v2.0 CTA block in audio detection

2022-03-23 Thread Lee, Shawn C
On Wednesday, March 23, 2022 6:04 PM, Nikula, Jani wrote : >On Mon, 21 Mar 2022, Cooper Chiou wrote: >> In DisplayID v2.0 CTS data block 0x81 case, there is no any audio >> information definition, but drm_detect_monitor_audio didn't filter it >> so that it caused eDP dummy audio card be detect

[Intel-gfx] ✓ Fi.CI.BAT: success for Improve on resume time with VT-d enabled

2022-03-23 Thread Patchwork
== Series Details == Series: Improve on resume time with VT-d enabled URL : https://patchwork.freedesktop.org/series/101676/ State : success == Summary == CI Bug Log - changes from CI_DRM_11397 -> Patchwork_22654 Summary --- **SUCCES

Re: [Intel-gfx] [PATCH] drm/edid: filter DisplayID v2.0 CTA block in audio detection

2022-03-23 Thread Jani Nikula
On Wed, 23 Mar 2022, "Lee, Shawn C" wrote: > On Wednesday, March 23, 2022 6:04 PM, Nikula, Jani > wrote : >>On Mon, 21 Mar 2022, Cooper Chiou wrote: >>> In DisplayID v2.0 CTS data block 0x81 case, there is no any audio >>> information definition, but drm_detect_monitor_audio didn't filter it >>

Re: [Intel-gfx] [PATCH] drm/i915: Decouple engine->sanitize callback on removing the status page

2022-03-23 Thread Matthew Auld
On Wed, 23 Mar 2022 at 09:44, Gwan-gyeong Mun wrote: > > From: Chris Wilson > > We have to be careful not to call into the submission backend's sanitize > callback if we abort the module load and free the status page. Since we > are only using the sanitize callback to cleanup the status page when

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Remove check for ComboPHY I/O voltage for DP source rate (rev5)

2022-03-23 Thread Patchwork
== Series Details == Series: Remove check for ComboPHY I/O voltage for DP source rate (rev5) URL : https://patchwork.freedesktop.org/series/96293/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_enab

Re: [Intel-gfx] [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-23 Thread kernel test robot
Hi Arunpravin, Thank you for the patch! Yet something to improve: [auto build test ERROR on a678f97326454b60ffbbde6abf52d23997d71a27] url: https://github.com/0day-ci/linux/commits/Arunpravin-Paneer-Selvam/drm-amdgpu-add-drm-buddy-support-to-amdgpu/20220323-142749 base

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: add a check to verify the size alignment (rev2)

2022-03-23 Thread Patchwork
== Series Details == Series: drm: add a check to verify the size alignment (rev2) URL : https://patchwork.freedesktop.org/series/101569/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11397_full -> Patchwork_22653_full Summa

[Intel-gfx] ✓ Fi.CI.BAT: success for Remove check for ComboPHY I/O voltage for DP source rate (rev5)

2022-03-23 Thread Patchwork
== Series Details == Series: Remove check for ComboPHY I/O voltage for DP source rate (rev5) URL : https://patchwork.freedesktop.org/series/96293/ State : success == Summary == CI Bug Log - changes from CI_DRM_11398 -> Patchwork_22655 Summa

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Decouple engine->sanitize callback on removing the status page

2022-03-23 Thread Patchwork
== Series Details == Series: drm/i915: Decouple engine->sanitize callback on removing the status page URL : https://patchwork.freedesktop.org/series/101679/ State : warning == Summary == $ dim checkpatch origin/drm-tip 716dbea36f93 drm/i915: Decouple engine->sanitize callback on removing the

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Decouple engine->sanitize callback on removing the status page

2022-03-23 Thread Patchwork
== Series Details == Series: drm/i915: Decouple engine->sanitize callback on removing the status page URL : https://patchwork.freedesktop.org/series/101679/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked sepa

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Decouple engine->sanitize callback on removing the status page

2022-03-23 Thread Patchwork
== Series Details == Series: drm/i915: Decouple engine->sanitize callback on removing the status page URL : https://patchwork.freedesktop.org/series/101679/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel

Re: [Intel-gfx] [v8 3/5] drm/edid: read HF-EEODB ext block

2022-03-23 Thread Jani Nikula
On Wed, 23 Mar 2022, Jani Nikula wrote: > On Thu, 17 Mar 2022, Lee Shawn C wrote: >> According to HDMI 2.1 spec. >> >> "The HDMI Forum EDID Extension Override Data Block (HF-EEODB) >> is utilized by Sink Devices to provide an alternate method to >> indicate an EDID Extension Block count larger th

Re: [Intel-gfx] [v8 3/5] drm/edid: read HF-EEODB ext block

2022-03-23 Thread Simon Ser
On Wednesday, March 23rd, 2022 at 13:02, Jani Nikula wrote: > Simon and Daniel also tell me on IRC we can't just modify the base block > extension count to match HF-EEODB to dodge the problem, because the EDID > gets exposed to userspace. I'm not familiar how the EDID blob gets exposed to user-

Re: [Intel-gfx] [v8 3/5] drm/edid: read HF-EEODB ext block

2022-03-23 Thread Jani Nikula
On Wed, 23 Mar 2022, Simon Ser wrote: > On Wednesday, March 23rd, 2022 at 13:02, Jani Nikula > wrote: > >> Simon and Daniel also tell me on IRC we can't just modify the base block >> extension count to match HF-EEODB to dodge the problem, because the EDID >> gets exposed to userspace. > > I'm no

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Decouple engine->sanitize callback on removing the status page

2022-03-23 Thread Patchwork
== Series Details == Series: drm/i915: Decouple engine->sanitize callback on removing the status page URL : https://patchwork.freedesktop.org/series/101679/ State : success == Summary == CI Bug Log - changes from CI_DRM_11398 -> Patchwork_22656 =

[Intel-gfx] ✓ Fi.CI.IGT: success for Improve on resume time with VT-d enabled

2022-03-23 Thread Patchwork
== Series Details == Series: Improve on resume time with VT-d enabled URL : https://patchwork.freedesktop.org/series/101676/ State : success == Summary == CI Bug Log - changes from CI_DRM_11397_full -> Patchwork_22654_full Summary ---

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/edid: fix CEA extension byte #3 parsing

2022-03-23 Thread Patchwork
== Series Details == Series: drm/edid: fix CEA extension byte #3 parsing URL : https://patchwork.freedesktop.org/series/101680/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_enable' not found ./dr

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: fix CEA extension byte #3 parsing

2022-03-23 Thread Patchwork
== Series Details == Series: drm/edid: fix CEA extension byte #3 parsing URL : https://patchwork.freedesktop.org/series/101680/ State : success == Summary == CI Bug Log - changes from CI_DRM_11398 -> Patchwork_22657 Summary --- **SUC

Re: [Intel-gfx] [PATCH v13 00/13] Add GuC Error Capture Support

2022-03-23 Thread Tvrtko Ursulin
Hi, On 21/03/2022 16:45, Alan Previn wrote: This series: 1. Enables support of GuC to report error-state-capture using a list of MMIO registers the driver registers and GuC will dump, log and notify right before a GuC triggered engine-reset event. 2. Updates the ADS blo

Re: [Intel-gfx] [PATCH] drm/edid: filter DisplayID v2.0 CTA block in audio detection

2022-03-23 Thread Lee, Shawn C
On Wednesday, March 23, 2022 6:40 PM, Jani wrote : >On Wed, 23 Mar 2022, "Lee, Shawn C" wrote: >> On Wednesday, March 23, 2022 6:04 PM, Nikula, Jani >> wrote : >>>On Mon, 21 Mar 2022, Cooper Chiou wrote: In DisplayID v2.0 CTS data block 0x81 case, there is no any audio information d

Re: [Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Daniel Stone
On Wed, 23 Mar 2022 at 08:19, Christian König wrote: > Am 23.03.22 um 09:10 schrieb Paul Menzel: > > Sorry, I disagree. The motivation needs to be part of the commit > > message. For example see recent discussion on the LWN article > > *Donenfeld: Random number generator enhancements for Linux 5.1

[Intel-gfx] ✗ Fi.CI.IGT: failure for Remove check for ComboPHY I/O voltage for DP source rate (rev5)

2022-03-23 Thread Patchwork
== Series Details == Series: Remove check for ComboPHY I/O voltage for DP source rate (rev5) URL : https://patchwork.freedesktop.org/series/96293/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11398_full -> Patchwork_22655_full =

Re: [Intel-gfx] [v8 3/5] drm/edid: read HF-EEODB ext block

2022-03-23 Thread Ville Syrjälä
On Wed, Mar 23, 2022 at 12:11:50PM +0200, Jani Nikula wrote: > On Thu, 17 Mar 2022, Lee Shawn C wrote: > > According to HDMI 2.1 spec. > > > > "The HDMI Forum EDID Extension Override Data Block (HF-EEODB) > > is utilized by Sink Devices to provide an alternate method to > > indicate an EDID Extens

Re: [Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Alex Deucher
On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > On Wed, 23 Mar 2022 at 08:19, Christian König > wrote: > > Am 23.03.22 um 09:10 schrieb Paul Menzel: > > > Sorry, I disagree. The motivation needs to be part of the commit > > > message. For example see recent discussion on the LWN article

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Decouple engine->sanitize callback on removing the status page

2022-03-23 Thread Patchwork
== Series Details == Series: drm/i915: Decouple engine->sanitize callback on removing the status page URL : https://patchwork.freedesktop.org/series/101679/ State : success == Summary == CI Bug Log - changes from CI_DRM_11398_full -> Patchwork_22656_full ===

Re: [Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Daniel Stone
Hi Alex, On Wed, 23 Mar 2022 at 14:42, Alex Deucher wrote: > On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > On Wed, 23 Mar 2022 at 08:19, Christian König > > wrote: > > > Well the key point is it's not about you to judge that. > > > > > > If you want to complain about the commit mess

Re: [Intel-gfx] [PATCH] drm/edid: fix CEA extension byte #3 parsing

2022-03-23 Thread Ville Syrjälä
On Wed, Mar 23, 2022 at 12:04:38PM +0200, Jani Nikula wrote: > Only an EDID CEA extension has byte #3, while the CTA DisplayID Data > Block does not. Don't interpret bogus data for color formats. I think what we might want eventually is a cleaner split between the CTA data blocks vs. the rest of t

Re: [Intel-gfx] [PATCH] drm/i915/display: Add smem fallback allocation for dpt

2022-03-23 Thread Juha-Pekka Heikkila
On 22.3.2022 17.53, Matthew Auld wrote: On Tue, 22 Mar 2022 at 12:06, Juha-Pekka Heikkila wrote: On 22.3.2022 12.45, Matthew Auld wrote: On Mon, 21 Mar 2022 at 18:36, Juha-Pekka Heikkila wrote: On 21.3.2022 14.29, Matthew Auld wrote: On Fri, 18 Mar 2022 at 09:22, Juha-Pekka Heikkila wrot

Re: [Intel-gfx] [PATCH 00/22] drm: Review of mode copies

2022-03-23 Thread Ville Syrjälä
On Wed, Mar 23, 2022 at 01:39:44PM +0300, Dmitry Baryshkov wrote: > On 22/03/2022 01:37, Ville Syrjälä wrote: > > On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: > >> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä > >> wrote: > >>> > >>> On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville

Re: [Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Alex Deucher
On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: > > Hi Alex, > > On Wed, 23 Mar 2022 at 14:42, Alex Deucher wrote: > > On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > > On Wed, 23 Mar 2022 at 08:19, Christian König > > > wrote: > > > > Well the key point is it's not about you to

Re: [Intel-gfx] [PATCH] drm/edid: fix CEA extension byte #3 parsing

2022-03-23 Thread Jani Nikula
On Wed, 23 Mar 2022, Ville Syrjälä wrote: > On Wed, Mar 23, 2022 at 12:04:38PM +0200, Jani Nikula wrote: >> Only an EDID CEA extension has byte #3, while the CTA DisplayID Data >> Block does not. Don't interpret bogus data for color formats. > > I think what we might want eventually is a cleaner s

Re: [Intel-gfx] [RFC 01/19] drm/edid: add drm_edid_extension_block_count() and drm_edid_size()

2022-03-23 Thread Ville Syrjälä
On Tue, Mar 22, 2022 at 11:40:30PM +0200, Jani Nikula wrote: > Add abstractions for getting the number of EDID extension blocks and the > total EDID size in bytes. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 18 ++ > include/drm/drm_edid.h | 2 ++ > 2

Re: [Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Daniel Stone
On Wed, 23 Mar 2022 at 15:14, Alex Deucher wrote: > On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: > > That's not what anyone's saying here ... > > > > No-one's demanding AMD publish RTL, or internal design docs, or > > hardware specs, or URLs to JIRA tickets no-one can access. > > > > This

Re: [Intel-gfx] [RFC 02/19] drm: use drm_edid_extension_block_count() and drm_edid_size()

2022-03-23 Thread Ville Syrjälä
On Tue, Mar 22, 2022 at 11:40:31PM +0200, Jani Nikula wrote: > Use the block count and size helpers in all drm core code. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_connector.c | 2 +- > drivers/gpu/drm/drm_debugfs.c | 3 +-- > drivers/gpu/drm/drm_edid.c | 14 +++

Re: [Intel-gfx] [RFC 03/19] drm/edid: clean up CEA data block tag definitions

2022-03-23 Thread Ville Syrjälä
On Tue, Mar 22, 2022 at 11:40:32PM +0200, Jani Nikula wrote: > Add prefixed names, group, sort, add references. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 59 +- > 1 file changed, 32 insertions(+), 27 deletions(-) > > diff --git a/dri

Re: [Intel-gfx] [PATCH 10/22] drm/msm: Nuke weird on stack mode copy

2022-03-23 Thread Dmitry Baryshkov
On 18/02/2022 13:03, Ville Syrjala wrote: From: Ville Syrjälä This on stack middle man mode looks entirely pointless. Just duplicate the original mode directly. Cc: Rob Clark Cc: Sean Paul Cc: Abhinav Kumar Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org Signed-off-by:

Re: [Intel-gfx] [PATCH v2] drm: Fix a infinite loop condition when order becomes 0

2022-03-23 Thread Christian König
Am 16.03.22 um 12:31 schrieb Matthew Auld: On 16/03/2022 06:34, Arunpravin Paneer Selvam wrote: handle a situation in the condition order-- == min_order, when order = 0 and min_order = 0, leading to order = -1, it now won't exit the loop. To avoid this problem, added a order check in the same co

Re: [Intel-gfx] [PATCH 12/22] drm/msm: Use drm_mode_copy()

2022-03-23 Thread Dmitry Baryshkov
On 18/02/2022 13:03, Ville Syrjala wrote: From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the des

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/display: Remove MBUS joining invalid TODOs

2022-03-23 Thread Caz Yokoyama
On Tue, Mar 22, 2022 at 2:45 PM José Roberto de Souza wrote: > skl_compute_ddb() will for a modeset in all pipes when MBUS joining > changes between states, so all pipes will be disabled, have all > MBUS related registers updated and then each pipe enabled. > I am not clear what you want to say h

Re: [Intel-gfx] [External] Re: drm/i915/adl_p: Increase CDCLK by 15% if PSR2 is used

2022-03-23 Thread Mark Pearson
Thanks Stanislav, On 3/22/22 10:18, Lisovskiy, Stanislav wrote: > On Tue, Mar 22, 2022 at 09:55:35AM -0400, Mark Pearson wrote: >> Hi, >> >> On 3/21/22 06:49, Stanislav Lisovskiy wrote: >>> We are currently getting FIFO underruns, in particular >>> when PSR2 is enabled. There seem to be no existin

Re: [Intel-gfx] [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-23 Thread Christian König
Am 23.03.22 um 07:25 schrieb Arunpravin Paneer Selvam: [SNIP] @@ -415,48 +409,86 @@ static int amdgpu_vram_mgr_new(struct ttm_resource_manager *man, goto error_fini; } - mode = DRM_MM_INSERT_BEST; + INIT_LIST_HEAD(&node->blocks); + if (place->flags & TTM

Re: [Intel-gfx] [PATCH 2/5] dyndbg: add class_id field and query support

2022-03-23 Thread Jason Baron
On 3/11/22 20:06, jim.cro...@gmail.com wrote: > On Fri, Mar 11, 2022 at 12:06 PM Jason Baron wrote: >> >> >> >> On 3/10/22 23:47, Jim Cromie wrote: >>> DRM defines/uses 10 enum drm_debug_category's to create exclusive >>> classes of debug messages. To support this directly in dynamic-debug, >>

Re: [Intel-gfx] drm/i915/adl_p: Increase CDCLK by 15% if PSR2 is used

2022-03-23 Thread Mark Pearson
Hi, On 3/21/22 06:49, Stanislav Lisovskiy wrote: > We are currently getting FIFO underruns, in particular > when PSR2 is enabled. There seem to be no existing workaround > or patches, which can fix that issue(were expecting some recent > selective fetch update and DBuf bw/SAGV fixes to help, > whi

Re: [Intel-gfx] [PATCH v2] drm: add a check to verify the size alignment

2022-03-23 Thread Christian König
Am 23.03.22 um 08:34 schrieb Arunpravin Paneer Selvam: Add a simple check to reject any size not aligned to the min_page_size. handle instances when size is not aligned with the min_page_size. Unigine Heaven has allocation requests for example required pages are 257 and alignment request is 256.

[Intel-gfx] [PATCH 22/23] drm/i915: drop bo->moving dependency

2022-03-23 Thread Christian König
That should now be handled by the common dma_resv framework. Signed-off-by: Christian König Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gem/i915_gem_object.c | 29 ++-- drivers/gpu/drm/i915/gem/i915_gem_object.h | 5 ++-- drivers/gpu/drm/i915/gem/i915_gem_tt

Re: [Intel-gfx] [PATCH 11/22] drm/msm: Use drm_mode_init() for on-stack modes

2022-03-23 Thread Dmitry Baryshkov
On 18/02/2022 13:03, Ville Syrjala wrote: From: Ville Syrjälä Initialize on-stack modes with drm_mode_init() to guarantee no stack garbage in the list head, or that we aren't copying over another mode's list head. Based on the following cocci script, with manual fixups: @decl@ identifier M; ex

[Intel-gfx] [PATCH] drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"

2022-03-23 Thread Colin Ian King
There is a spelling mistake in a gvt_vgpu_err error message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gvt/handlers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c index 520a7e19

Re: [Intel-gfx] [PATCH 00/22] drm: Review of mode copies

2022-03-23 Thread Dmitry Baryshkov
On 22/03/2022 01:37, Ville Syrjälä wrote: On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä wrote: On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: drm: Add drm_mode_init() drm/bridge: Use drm_mode_copy() drm/im

Re: [Intel-gfx] [PATCH 1/5] dyndbg: fix static_branch manipulation

2022-03-23 Thread Jason Baron
On 3/10/22 23:47, Jim Cromie wrote: > In > https://urldefense.com/v3/__https://lore.kernel.org/lkml/20211209150910.ga23...@axis.com/__;!!GjvTz_vk!HGKKoni4RVdEBgv_V0zPSNSX428bpf02zkCy2WbeQkBdVtp1QJqGX-lJYlRDGg$ > > > Vincent's patch commented on, and worked around, a bug toggling > static_bra

Re: [Intel-gfx] [PATCH 18/22] drm/i915: Use drm_mode_init() for on-stack modes

2022-03-23 Thread Julia Lawall
On Mon, 21 Mar 2022, Ville Syrjälä wrote: > On Wed, Mar 16, 2022 at 10:00:06AM +0200, Jani Nikula wrote: > > On Fri, 18 Feb 2022, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Initialize on-stack modes with drm_mode_init() to guarantee > > > no stack garbage in the list head, or t

Re: [Intel-gfx] [PATCH 2/5] dyndbg: add class_id field and query support

2022-03-23 Thread Jason Baron
On 3/10/22 23:47, Jim Cromie wrote: > DRM defines/uses 10 enum drm_debug_category's to create exclusive > classes of debug messages. To support this directly in dynamic-debug, > add the following: > > - struct _ddebug.class_id:4 - 4 bits is enough > - define _DPRINTK_SITE_UNCLASSED 15 - see be

Re: [Intel-gfx] [RFC 06/19] drm/edid: clean up cea_db_is_*() functions

2022-03-23 Thread Ville Syrjälä
On Tue, Mar 22, 2022 at 11:40:35PM +0200, Jani Nikula wrote: > Abstract helpers for matching vendor data blocks and extended tags, and > use them to simplify all the cea_db_is_*() functions. > > Take void pointer as parameter to allow transitional use for both u8 * > and struct cea_db *. > > Sign

Re: [Intel-gfx] [External] Re: drm/i915/adl_p: Increase CDCLK by 15% if PSR2 is used

2022-03-23 Thread Souza, Jose
Hi Mark See comment below. On Tue, 2022-03-22 at 10:23 -0400, Mark Pearson wrote: > Thanks Stanislav, > > On 3/22/22 10:18, Lisovskiy, Stanislav wrote: > > On Tue, Mar 22, 2022 at 09:55:35AM -0400, Mark Pearson wrote: > > > Hi, > > > > > > On 3/21/22 06:49, Stanislav Lisovskiy wrote: > > > > We

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/edid: fix CEA extension byte #3 parsing

2022-03-23 Thread Patchwork
== Series Details == Series: drm/edid: fix CEA extension byte #3 parsing URL : https://patchwork.freedesktop.org/series/101680/ State : success == Summary == CI Bug Log - changes from CI_DRM_11398_full -> Patchwork_22657_full Summary --

[Intel-gfx] ✗ Fi.CI.BUILD: failure for dyndbg add exclusive class support (rev2)

2022-03-23 Thread Patchwork
== Series Details == Series: dyndbg add exclusive class support (rev2) URL : https://patchwork.freedesktop.org/series/101265/ State : failure == Summary == Applying: dyndbg: fix static_branch manipulation Applying: dyndbg: add class_id field and query support error: sha1 information is lacking

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"

2022-03-23 Thread Patchwork
== Series Details == Series: drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported" URL : https://patchwork.freedesktop.org/series/101699/ State : warning == Summary == $ dim checkpatch origin/drm-tip fce9e0a464ec drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported" -:23: W

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"

2022-03-23 Thread Patchwork
== Series Details == Series: drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported" URL : https://patchwork.freedesktop.org/series/101699/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_ena

Re: [Intel-gfx] [RFC 05/19] drm/edid: add iterator for CEA data blocks

2022-03-23 Thread Ville Syrjälä
On Tue, Mar 22, 2022 at 11:40:34PM +0200, Jani Nikula wrote: > Add an iterator for CEA Data Blocks across CEA extensions and CTA > DisplayID Data Blocks. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 198 ++--- > 1 file changed, 186 insertion

Re: [Intel-gfx] [RFC 09/19] drm/edid: convert drm_edid_to_sad() to use cea db iter

2022-03-23 Thread Ville Syrjälä
On Tue, Mar 22, 2022 at 11:40:38PM +0200, Jani Nikula wrote: > Use the cea db iterator for short audio descriptors. We'll still stop at > the first audio data block, but not at the first CEA extension if that > doesn't have the info. This stuff should probably be converted over to the drm_edid_to_

Re: [Intel-gfx] [RFC 19/19] drm/edid: sunset drm_find_cea_extension()

2022-03-23 Thread Ville Syrjälä
On Tue, Mar 22, 2022 at 11:40:48PM +0200, Jani Nikula wrote: > Convert drm_find_cea_extension() to a predicate function to check if the > EDID has a CEA extension or a DisplayID CTA data block. This is mainly > to avoid adding new users that only find the first CEA extension. > > Signed-off-by: Ja

Re: [Intel-gfx] [RFC 00/19] drm/edid: overhaul CEA data block iteration

2022-03-23 Thread Ville Syrjälä
On Tue, Mar 22, 2022 at 11:40:29PM +0200, Jani Nikula wrote: > Add iterators for EDID blocks and CEA data blocks, to iterate through > all data blocks across all CEA extensions and CTA blocks in DisplayID > data blocks. Fix all code assuming only one CEA extension. Fix code > assuming CTA blocks co

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"

2022-03-23 Thread Patchwork
== Series Details == Series: drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported" URL : https://patchwork.freedesktop.org/series/101699/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11398 -> Patchwork_22659 Summ

Re: [Intel-gfx] [RFC 06/19] drm/edid: clean up cea_db_is_*() functions

2022-03-23 Thread Jani Nikula
On Wed, 23 Mar 2022, Ville Syrjälä wrote: > On Tue, Mar 22, 2022 at 11:40:35PM +0200, Jani Nikula wrote: >> Abstract helpers for matching vendor data blocks and extended tags, and >> use them to simplify all the cea_db_is_*() functions. >> >> Take void pointer as parameter to allow transitional u

[Intel-gfx] [PATCH] [topic/core-for-CI] Revert "drm/i915/dg2: Add relocation exception"

2022-03-23 Thread Zbigniew Kempczyński
This reverts commit 904ebf2ba89edaeba5c7c10540e43dba63541dc6. Failures on dg2 tests were caused by invalid alignment when local memory was in use. Changes which adopt alignment according to gen were already merged in IGT so lets revert relocation temporary enabler for dg2. Keeping it is a little b

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Revert "drm/i915/dg2: Add relocation exception" (rev2)

2022-03-23 Thread Patchwork
== Series Details == Series: Revert "drm/i915/dg2: Add relocation exception" (rev2) URL : https://patchwork.freedesktop.org/series/101669/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_enable' not

[Intel-gfx] [CI] PR for DG2 DMC v2.06

2022-03-23 Thread Tolakanahalli Pradeep, Madhumitha
The following changes since commit 681281e49fb6778831370e5d94e6e1d97f0752d6: amdgpu: update PSP 13.0.8 firmware (2022-03-18 07:35:54 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware dg2_dmc_v2.06 for you to fetch changes up to ecc28070ea5edd4733b

[Intel-gfx] [PATCH 0/9] drm/i915: More fixed_mode refactoring

2022-03-23 Thread Ville Syrjala
From: Ville Syrjälä Continue refactoring the panel fixed_mode stuff. The main thing here is unifying SDVO with the rest of the world. Ville Syrjälä (9): drm/i915: Pass intel_connector to intel_panel_{init,fini}() drm/i915: Use DRM_MODE_FMT+DRM_MODE_ARG() drm/i915: Extract intel_edp_add_pro

[Intel-gfx] [PATCH 2/9] drm/i915: Use DRM_MODE_FMT+DRM_MODE_ARG()

2022-03-23 Thread Ville Syrjala
From: Ville Syrjälä Replace all drm_mode_debug_printmodeline() calls with DRM_MODE_FMT+DRM_MODE_ARG(). Makes the debug output a bit more terse in places where we previously had a newline in the precedeing drm_dbg_kms(), and avoids anything else sneaking in between the two printk()s in all cases.

[Intel-gfx] [PATCH 3/9] drm/i915: Extract intel_edp_add_properties()

2022-03-23 Thread Ville Syrjala
From: Ville Syrjälä Pull the drm_connector_set_panel_orientation_with_quirk() into intel_edp_add_properties() to match how the DSI encoders do it. Less clutter in intel_edp_init_connector() overall. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 22 +

[Intel-gfx] [PATCH 4/9] drm/i915: Use intel_panel_preferred_fixed_mode() more

2022-03-23 Thread Ville Syrjala
From: Ville Syrjälä Use intel_panel_preferred_fixed_mode() for all the orientation quirk setup and compute_is_dual_link_lvds()). All of these happen after intel_panel_init() so the panel fixed_mode list is already in place. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.

[Intel-gfx] [PATCH 6/9] drm/i915: Extract intel_panel_vbt_sdvo_fixed_mode()

2022-03-23 Thread Ville Syrjala
From: Ville Syrjälä We have a function for duplicating the VBT LFP mode. Add the same for the VBT SDVO mode. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_panel.c | 20 drivers/gpu/drm/i915/display/intel_panel.h | 2 ++ drivers/gpu/drm/i915/display/i

[Intel-gfx] [PATCH 7/9] drm/i915: Extract intel_panel_encoder_fixed_mode()

2022-03-23 Thread Ville Syrjala
From: Ville Syrjälä Apart from the EDID and VBT based mechanism we also sometimes use the encoder's current mode as the panel fixed mode. We currently have the same code for that duplicated in two places. Let's unify. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dvo.c

[Intel-gfx] [PATCH 8/9] drm/i915: Use intel_panel_edid_fixed_mode() for sdvo

2022-03-23 Thread Ville Syrjala
From: Ville Syrjälä Despite the name intel_panel_edid_fixed_mode() doesn't actually look in the EDID. All it does is dig out the preferred mode from the connector's probed_modes list. That is also what the SDVO LVDS code is doing by hand. Let's just call intel_panel_edid_fixed_mode(). The slight

[Intel-gfx] [PATCH 5/9] drm/i915: Rename intel_panel_vbt_fixed_mode()

2022-03-23 Thread Ville Syrjala
From: Ville Syrjälä Rename intel_panel_vbt_fixed_mode() to intel_panel_vbt_lfp_fixed_mode() to be more descriptive. We'll have another VBT fixed mode function soon and we don't want to confuse the two. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 2 +- drivers/

[Intel-gfx] [PATCH 9/9] drm/i915: Change SDVO fixed mode handling

2022-03-23 Thread Ville Syrjala
From: Ville Syrjälä SDVO is the only connector type currently returning the VBT fixed mode directly from .get_modes(), everyone else just adds it to the fixed_modes list and then returns that from .get_modes(). Adjust SDVO to follow the common behaviour. Signed-off-by: Ville Syrjälä --- driver

[Intel-gfx] [PATCH 1/9] drm/i915: Pass intel_connector to intel_panel_{init, fini}()

2022-03-23 Thread Ville Syrjala
From: Ville Syrjälä All the other intel_panel functions take struct intel_connector, so might as well make init()/fini() take one as well. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.c | 2 +- drivers/gpu/drm/i915/display/intel_connector.c | 2 +- drivers/gp

  1   2   >