Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-03-03 Thread Hellstrom, Thomas
On Wed, 2022-03-02 at 03:23 +0530, Ramalingam C wrote: > When we are swapping out the local memory obj on flat-ccs capable > platform, > we need to capture the ccs data too along with main meory and we need > to > restore it when we are swapping in the content. > > When lmem object is swapped into

[Intel-gfx] [v2] drm/i915: update new TMDS clock setting defined by VBT

2022-03-03 Thread Lee Shawn C
VBT 249 update to support more TMDS clock rate 3.00G, 3.40G and 5.94G. Refer to this new definition to configure max TMDS clock rate for HDMI driver. BSpec: 20124 v2: new subject Cc: Jani Nikula Cc: Ville Syrjala Cc: Ankit Nautiyal Signed-off-by: Lee Shawn C --- drivers/gpu/drm/i915/display

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Dan Carpenter
On Wed, Mar 02, 2022 at 12:07:04PM -0800, Kees Cook wrote: > On Wed, Mar 02, 2022 at 10:29:31AM +0100, Rasmus Villemoes wrote: > > This won't help the current issue (because it doesn't exist and might > > never), but just in case some compiler people are listening, I'd like to > > have some sort of

Re: [Intel-gfx] [v2] drm/i915/gem: missing boundary check in vm_access leads to OOB read/write

2022-03-03 Thread Tvrtko Ursulin
+ Matt On 03/03/2022 06:04, Mastan Katragadda wrote: Intel ID: PSIRT-PTK0002429 A missing bounds check in vm_access()can lead to an out-of-bounds read or write in the adjacent memory area.The len attribute is not validated before the memcpy at [1]or [2] occurs. s/[1]or [2]/later in the fun

[Intel-gfx] [PULL] drm-misc-next

2022-03-03 Thread Maarten Lankhorst
drm-misc-next-2022-03-03: drm-misc-next for v5.18: UAPI Changes: Cross-subsystem Changes: - Improve performance of some fbdev ops, in some cases up to 6x faster. Core Changes: - Some small DP fixes. - Find panels in subnodes of OF devices, and add of_get_drm_panel_display_mode to retrieve mode

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread David Laight
From: Xiaomeng Tong > Sent: 03 March 2022 07:27 > > On Thu, 3 Mar 2022 04:58:23 +, David Laight wrote: > > on 3 Mar 2022 10:27:29 +0800, Xiaomeng Tong wrote: > > > The problem is the mis-use of iterator outside the loop on exit, and > > > the iterator will be the HEAD's container_of pointer wh

Re: [Intel-gfx] [v2] drm/i915/gem: missing boundary check in vm_access leads to OOB read/write

2022-03-03 Thread Jani Nikula
On Thu, 03 Mar 2022, Mastan Katragadda wrote: > Intel ID: PSIRT-PTK0002429 What's that and why is it the first thing in the commit message? BR, Jani. > > A missing bounds check in vm_access()can lead to an out-of-bounds read or > write in the adjacent memory area.The len attribute is not valida

Re: [Intel-gfx] [PATCH 06/15] drm/i915: enforce min GTT alignment for discrete cards

2022-03-03 Thread Jani Nikula
On Sat, 19 Feb 2022, Ramalingam C wrote: > diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.h > b/drivers/gpu/drm/i915/gt/intel_gtt.h > index 8073438b67c8..6cd518a3277c 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gtt.h > +++ b/drivers/gpu/drm/i915/gt/intel_gtt.h > @@ -29,6 +29,8 @@ > #include "i9

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: add more TMDS clock rate supported by HDMI driver (rev2)

2022-03-03 Thread Patchwork
== Series Details == Series: drm/i915: add more TMDS clock rate supported by HDMI driver (rev2) URL : https://patchwork.freedesktop.org/series/100866/ State : success == Summary == CI Bug Log - changes from CI_DRM_11317 -> Patchwork_22469 S

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Make the heartbeat play nice with long pre-emption timeouts

2022-03-03 Thread Tvrtko Ursulin
On 02/03/2022 17:55, John Harrison wrote: I was assuming 2.5s tP is enough and basing all calculation on that. Heartbeat or timeslicing regardless. I thought we established neither of us knows how long is enough. Are you now saying 2.5s is definitely not enough? How is that usable for a d

Re: [Intel-gfx] [PATCH] drm/i915/cdclk: Add cdclk check to atomic check

2022-03-03 Thread Jani Nikula
On Wed, 02 Mar 2022, Anusha Srivatsa wrote: > Checking cdclk conditions during atomic check and preparing > for commit phase so we can have atomic commit as simple > as possible. Add the specific steps to be taken during > cdclk changes, prepare for squashing, crawling and modeset > scenarios. > >

[Intel-gfx] [PATCH] drm/i915/gtt: reduce overzealous alignment constraints for GGTT

2022-03-03 Thread Matthew Auld
Currently this will enforce both 2M alignment and padding for any LMEM pages inserted into the GGTT. However, this was only meant to be applied to the compact-pt layout with the ppGTT. For the GGTT we can reduce the alignment and padding to 64K. Bspec: 45015 Fixes: 87bd701ee268 ("drm/i915: enforce

[Intel-gfx] [PULL] drm-misc-fixes

2022-03-03 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the drm-misc-fixes PR for this week. Best regards Thomas drm-misc-fixes-2022-03-03: * drm/arm: Select DRM_GEM_CMEA_HELPER for HDLCD * drm/bridge: ti-sn65dsi86: Properly undo autosuspend * drm/vrr: Fix potential NULL-pointer deref The following changes since commit e

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

2022-03-03 Thread Tvrtko Ursulin
On 02/03/2022 18:22, John Harrison wrote: On 3/2/2022 01:49, Tvrtko Ursulin wrote: On 25/02/2022 20:41, john.c.harri...@intel.com wrote: From: John Harrison GuC converts the pre-emption timeout and timeslice quantum values into clock ticks internally. That significantly reduces the point of

Re: [Intel-gfx] [PATCH v5 5/7] drm/i915/gt: Create per-tile RC6 sysfs interface

2022-03-03 Thread Andrzej Hajda
On 17.02.2022 15:41, Andi Shyti wrote: Now tiles have their own sysfs interfaces under the gt/ directory. Because RC6 is a property that can be configured on a tile basis, then each tile should have its own interface The new sysfs structure will have a similar layout for the 4 tile case: /sy

Re: [Intel-gfx] [PATCH 3/5] drm/i915/dsi: Add some debug logging to mipi_exec_i2c

2022-03-03 Thread Jani Nikula
On Fri, 25 Feb 2022, Hans de Goede wrote: > Add some debug logging to mipi_exec_i2c, to make debugging various > issues seen with it easier. > > Signed-off-by: Hans de Goede > --- > drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/

Re: [Intel-gfx] [PATCH] drm/i915/gt: Handle errors for i915_gem_object_trylock

2022-03-03 Thread Hellstrom, Thomas
On Wed, 2022-03-02 at 10:37 +, Tvrtko Ursulin wrote: > > + Thomas, Matt > > On 02/03/2022 06:19, Jiasheng Jiang wrote: > > As the potential failure of the i915_gem_object_trylock(), > > it should be better to check it and return error if fails. > > > > Fixes: 94ce0d65076c ("drm/i915/gt: Setu

[Intel-gfx] [PULL] drm-intel-fixes

2022-03-03 Thread Tvrtko Ursulin
Hi Dave, Daniel, Two small fixes for -rc7. GuC SLPC is for future platform work and other one is fixing misidentification of Ice Lake MacBook Pro's. Regards, Tvrtko drm-intel-fixes-2022-03-03: - Fix GuC SLPC unset command. (Vinay Belgaumkar) - Fix misidentification of some Apple MacBook Pro

Re: [Intel-gfx] [v2] drm/i915/gem: missing boundary check in vm_access leads to OOB read/write

2022-03-03 Thread Matthew Auld
On 03/03/2022 09:00, Tvrtko Ursulin wrote: + Matt On 03/03/2022 06:04, Mastan Katragadda wrote: Intel ID: PSIRT-PTK0002429 A missing bounds check in vm_access()can lead to an out-of-bounds read or write in the adjacent memory area.The len attribute is not validated before the memcpy at  [1]

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: reduce overzealous alignment constraints for GGTT

2022-03-03 Thread Patchwork
== Series Details == Series: drm/i915/gtt: reduce overzealous alignment constraints for GGTT URL : https://patchwork.freedesktop.org/series/100991/ State : success == Summary == CI Bug Log - changes from CI_DRM_11317 -> Patchwork_22470 Summ

Re: [Intel-gfx] [PATCH] drm/i915/selftests: check the return value of kstrdup()

2022-03-03 Thread Matthew Auld
On Tue, 22 Feb 2022 at 13:32, wrote: > > From: Xiaoke Wang > > kstrdup() is a memory allocation function which can return NULL when > some internaly memory errors happen. It is better to check the return > value of it to prevent further wrong memory access. > > Signed-off-by: Xiaoke Wang Reviewe

Re: [Intel-gfx] [PATCH v5 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces

2022-03-03 Thread Andrzej Hajda
On 17.02.2022 15:41, Andi Shyti wrote: Now tiles have their own sysfs interfaces under the gt/ directory. Because RPS is a property that can be configured on a tile basis, then each tile should have its own interface The new sysfs structure will have a similar layout for the 4 tile case: /sy

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Dan Carpenter
On Wed, Mar 02, 2022 at 10:29:31AM +0100, Rasmus Villemoes wrote: > This won't help the current issue (because it doesn't exist and might > never), but just in case some compiler people are listening, I'd like to > have some sort of way to tell the compiler "treat this variable as > uninitialized f

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display/adlp: Remove code related to underrun recovery

2022-03-03 Thread Patchwork
== Series Details == Series: drm/i915/display/adlp: Remove code related to underrun recovery URL : https://patchwork.freedesktop.org/series/100965/ State : success == Summary == CI Bug Log - changes from CI_DRM_11316_full -> Patchwork_22466_full

Re: [Intel-gfx] [PATCH] drm/i915/selftests: check the return value of kstrdup()

2022-03-03 Thread Matthew Auld
On Thu, 3 Mar 2022 at 10:53, Matthew Auld wrote: > > On Tue, 22 Feb 2022 at 13:32, wrote: > > > > From: Xiaoke Wang > > > > kstrdup() is a memory allocation function which can return NULL when > > some internaly memory errors happen. It is better to check the return > > value of it to prevent fu

Re: [Intel-gfx] [PATCH v5 7/7] drm/i915/gt: Adding new sysfs frequency attributes

2022-03-03 Thread Andrzej Hajda
On 17.02.2022 15:41, Andi Shyti wrote: From: Sujaritha Sundaresan This patch adds the following new sysfs frequency attributes; - punit_req_freq_mhz - throttle_reason_status - throttle_reason_pl1 - throttle_reason_pl2 - throttle_reason_pl4 - th

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Remove usage of list iterator past the loop body (rev5)

2022-03-03 Thread Patchwork
== Series Details == Series: Remove usage of list iterator past the loop body (rev5) URL : https://patchwork.freedesktop.org/series/100822/ State : warning == Summary == $ dim checkpatch origin/drm-tip ceb0dd20faa6 drivers: usb: remove usage of list iterator past the loop body -:67: CHECK:PARE

Re: [Intel-gfx] [v2] drm/i915: update new TMDS clock setting defined by VBT

2022-03-03 Thread Ville Syrjälä
On Thu, Mar 03, 2022 at 04:38:02PM +0800, Lee Shawn C wrote: > VBT 249 update to support more TMDS clock rate 3.00G, 3.40G > and 5.94G. Refer to this new definition to configure max > TMDS clock rate for HDMI driver. > > BSpec: 20124 > > v2: new subject > > Cc: Jani Nikula > Cc: Ville Syrjala

Re: [Intel-gfx] [PATCH] drm/i915/display/adlp: Remove code related to underrun recovery

2022-03-03 Thread Ville Syrjälä
On Wed, Mar 02, 2022 at 03:11:19PM -0800, Swathi Dhanavanthri wrote: > This is not supported for ADLP and is not needed. > > Signed-off-by: Swathi Dhanavanthri Thanks. Pushed to drm-intel-next. > --- > drivers/gpu/drm/i915/display/intel_display.c | 21 > 1 file changed, 21

[Intel-gfx] [PATCH] drm/i915/adl-n: Add stepping info

2022-03-03 Thread Tejas Upadhyay
Add ADL-N stepping-substepping info in accordance to BSpec. Bspec: 68397 Cc: Matt Roper Signed-off-by: Tejas Upadhyay --- drivers/gpu/drm/i915/intel_step.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_step.c b/drivers/gpu/drm/i915/intel_step.c index 4f

[Intel-gfx] ✓ Fi.CI.BAT: success for Remove usage of list iterator past the loop body (rev5)

2022-03-03 Thread Patchwork
== Series Details == Series: Remove usage of list iterator past the loop body (rev5) URL : https://patchwork.freedesktop.org/series/100822/ State : success == Summary == CI Bug Log - changes from CI_DRM_11317 -> Patchwork_22471 Summary

Re: [Intel-gfx] [Kgdb-bugreport] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Daniel Thompson
On Thu, Mar 03, 2022 at 03:26:57PM +0800, Xiaomeng Tong wrote: > On Thu, 3 Mar 2022 04:58:23 +, David Laight wrote: > > on 3 Mar 2022 10:27:29 +0800, Xiaomeng Tong wrote: > > > The problem is the mis-use of iterator outside the loop on exit, and > > > the iterator will be the HEAD's container_o

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Use I915_BO_ALLOC_CONTIGUOUS flag for DPT

2022-03-03 Thread Matthew Auld
On Thu, 9 Dec 2021 at 17:00, Stanislav Lisovskiy wrote: > > Do mapping using CONTIGUOUS flag - otherwise > i915_gem_object_is_contiguous warn is triggered. > > Signed-off-by: Stanislav Lisovskiy As a temporary fix, Reviewed-by: Matthew Auld > --- > drivers/gpu/drm/i915/display/intel_dpt.c | 2

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: add more TMDS clock rate supported by HDMI driver (rev2)

2022-03-03 Thread Patchwork
== Series Details == Series: drm/i915: add more TMDS clock rate supported by HDMI driver (rev2) URL : https://patchwork.freedesktop.org/series/100866/ State : success == Summary == CI Bug Log - changes from CI_DRM_11317_full -> Patchwork_22469_full =

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Set "SF Partial Frame Enable" also on full update (rev5)

2022-03-03 Thread Souza, Jose
On Sun, 2022-02-27 at 05:27 +, Patchwork wrote: Patch Details Series: drm/i915/psr: Set "SF Partial Frame Enable" also on full update (rev5) URL:https://patchwork.freedesktop.org/series/100633/ State: success Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22427/index.h

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/adl-n: Add stepping info

2022-03-03 Thread Patchwork
== Series Details == Series: drm/i915/adl-n: Add stepping info URL : https://patchwork.freedesktop.org/series/100995/ State : success == Summary == CI Bug Log - changes from CI_DRM_11318 -> Patchwork_22472 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Don't skip ddb allocation if data_rate==0

2022-03-03 Thread Lisovskiy, Stanislav
On Mon, Feb 14, 2022 at 12:55:29PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > data_rate==0 no longer means a plane is disabled, it could > also mean we want to use the minimum ddb allocation for it. > Hence we can't bail out early during ddb allocation or > else we'll simply forget to

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Check async flip capability early on

2022-03-03 Thread Lisovskiy, Stanislav
On Mon, Feb 14, 2022 at 12:55:30PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Since the async flip state check is done very late and > thus it can see potentially all the planes in the state > (due to the wm/ddb optimization) we need to move the > "can the requested plane do async flip

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Fix the async flip wm0/ddb optimization

2022-03-03 Thread Lisovskiy, Stanislav
On Mon, Feb 14, 2022 at 12:55:31PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > The current implementation of the async flip wm0/ddb optimization > does not work at all. The biggest problem is that we skip the > whole intel_pipe_update_{start,end}() dance and thus never actually > comple

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Pimp async flip debugs

2022-03-03 Thread Lisovskiy, Stanislav
On Mon, Feb 14, 2022 at 12:55:32PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Print the offending plane/crtc id+name in the async flip debugs. Reviewed-by: Stanislav Lisovskiy > > Cc: Stanislav Lisovskiy > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_d

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gtt: reduce overzealous alignment constraints for GGTT

2022-03-03 Thread Patchwork
== Series Details == Series: drm/i915/gtt: reduce overzealous alignment constraints for GGTT URL : https://patchwork.freedesktop.org/series/100991/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11317_full -> Patchwork_22470_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg2: Use I915_BO_ALLOC_CONTIGUOUS flag for DPT (rev2)

2022-03-03 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Use I915_BO_ALLOC_CONTIGUOUS flag for DPT (rev2) URL : https://patchwork.freedesktop.org/series/97806/ State : failure == Summary == Applying: drm/i915/dg2: Use I915_BO_ALLOC_CONTIGUOUS flag for DPT Using index info to reconstruct a base tree... M

[Intel-gfx] ✗ Fi.CI.IGT: failure for Remove usage of list iterator past the loop body (rev5)

2022-03-03 Thread Patchwork
== Series Details == Series: Remove usage of list iterator past the loop body (rev5) URL : https://patchwork.freedesktop.org/series/100822/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11317_full -> Patchwork_22471_full Su

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-03-03 Thread Abhinav Kumar
On 3/2/2022 10:31 AM, Laurent Pinchart wrote: Hi Abhinav, On Wed, Mar 02, 2022 at 10:28:03AM -0800, Abhinav Kumar wrote: On 2/28/2022 5:42 AM, Laurent Pinchart wrote: On Mon, Feb 28, 2022 at 02:28:27PM +0200, Laurent Pinchart wrote: On Mon, Feb 28, 2022 at 02:09:15PM +0200, Jani Nikula wro

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Remove the vm open count

2022-03-03 Thread Matthew Auld
On Wed, 2 Mar 2022 at 10:22, Thomas Hellström wrote: > > vms are not getting properly closed. Rather than fixing that, > Remove the vm open count and instead rely on the vm refcount. > > The vm open count existed solely to break the strong references the > vmas had on the vms. Now instead make tho

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Xiaomeng Tong
On Wed, 2 Mar 2022 14:04:06 +, David Laight wrote: > I think that it would be better to make any alternate loop macro > just set the variable to NULL on the loop exit. > That is easier to code for and the compiler might be persuaded to > not redo the test. No, that would lead to a NULL derefe

Re: [Intel-gfx] [PATCH v9] drm/amdgpu: add drm buddy support to amdgpu

2022-03-03 Thread Christian König
Am 01.03.22 um 21:38 schrieb Arunpravin: - Remove drm_mm references and replace with drm buddy functionalities - Add res cursor support for drm buddy v2(Matthew Auld): - replace spinlock with mutex as we call kmem_cache_zalloc (..., GFP_KERNEL) in drm_buddy_alloc() function - lock

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Xiaomeng Tong
On Thu, 3 Mar 2022 04:58:23 +, David Laight wrote: > on 3 Mar 2022 10:27:29 +0800, Xiaomeng Tong wrote: > > The problem is the mis-use of iterator outside the loop on exit, and > > the iterator will be the HEAD's container_of pointer which pointers > > to a type-confused struct. Sidenote: The *

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Xiaomeng Tong
correct for typo: -for (struct list_head *list = head->next, cond = (struct list_head *)-1; cond == (struct list_head *)-1; cond = NULL) \ +for (struct list_head *list = head->next, *cond = (struct list_head *)-1; cond == (struct list_head *)-1; cond = NULL) \ -- Xiaomeng Tong

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Xiaomeng Tong
> From: Xiaomeng Tong > > Sent: 03 March 2022 07:27 > > > > On Thu, 3 Mar 2022 04:58:23 +, David Laight wrote: > > > on 3 Mar 2022 10:27:29 +0800, Xiaomeng Tong wrote: > > > > The problem is the mis-use of iterator outside the loop on exit, and > > > > the iterator will be the HEAD's container

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Jakob Koschel
> On 3. Mar 2022, at 05:58, David Laight wrote: > > From: Xiaomeng Tong >> Sent: 03 March 2022 02:27 >> >> On Wed, 2 Mar 2022 14:04:06 +, David Laight >> wrote: >>> I think that it would be better to make any alternate loop macro >>> just set the variable to NULL on the loop exit. >>> Th

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Xiaomeng Tong
> I think this would make sense, it would mean you only assign the containing > element on valid elements. > > I was thinking something along the lines of: > > #define list_for_each_entry(pos, head, member) > \ > for (struct list_head *list = head->next

Re: [Intel-gfx] [PATCH] drm/i915/selftests: check the return value of kstrdup()

2022-03-03 Thread Xiaoke Wang
Matthew Auld wrote: > Scratch that. it looks like the for() already accounts for this, as > pointed out by Chris. Yes, you are right. I rechecked and found this one is indeed an ordinary code smell. Thank you for taking the time. Xiaoke Wang

Re: [Intel-gfx] [PATCH v12 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-03-03 Thread Robin Murphy
On 2022-03-02 15:55, Michael Cheng wrote: Thanks for the feedback Robin! Sorry my choices of word weren't that great, but what I meant is to understand how ARM flushes a range of dcache for device drivers, and not an equal to x86 clflush. I believe the concern is if the CPU writes an update,

[Intel-gfx] [PATCH v2 5/7] drm/i915/selftests: use the memcpy_from_wc call from the drm

2022-03-03 Thread Balasubramani Vivekanandan
memcpy_from_wc functions in i915_memcpy.c will be removed and replaced by the implementation in drm_cache.c. Updated to use the functions provided by drm_cache.c. v2: check if the source and destination memory address is from local memory or system memory and initialize the iosys_map according

[Intel-gfx] [PATCH v2 4/7] drm/i915/guc: use the memcpy_from_wc call from the drm

2022-03-03 Thread Balasubramani Vivekanandan
memcpy_from_wc functions in i915_memcpy.c will be removed and replaced by the implementation in drm_cache.c. Updated to use the functions provided by drm_cache.c. v2: Check if the log object allocated from local memory or system memory and according setup the iosys_map (Lucas) Cc: Lucas De Ma

[Intel-gfx] [PATCH v2 3/7] drm/i915: use the memcpy_from_wc call from the drm

2022-03-03 Thread Balasubramani Vivekanandan
memcpy_from_wc functions in i915_memcpy.c will be removed and replaced by the implementation in drm_cache.c. Updated to use the functions provided by drm_cache.c. Signed-off-by: Balasubramani Vivekanandan Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/gem/i915_gem_object.c | 6 -- 1

[Intel-gfx] [PATCH v2 6/7] drm/i915/gt: Avoid direct dereferencing of io memory

2022-03-03 Thread Balasubramani Vivekanandan
io mapped memory should not be directly dereferenced to ensure portability. io memory should be read/written/copied using helper functions. i915_memcpy_from_wc() function was used to copy the data from io memory to a temporary buffer and pointer to the temporary buffer was passed to CRC calculation

[Intel-gfx] [PATCH v2 7/7] drm/i915: Avoid dereferencing io mapped memory

2022-03-03 Thread Balasubramani Vivekanandan
Pointer passed to zlib_deflate() for compression could point to io mapped memory and might end up in direct derefencing. io mapped memory is copied to a temporary buffer, which is then shared to zlib_deflate(), only for the case where platform supports fast copy using non-temporal instructions. If

[Intel-gfx] [PATCH v2 1/7] drm: Relax alignment constraint for destination address

2022-03-03 Thread Balasubramani Vivekanandan
There is no need for the destination address to be aligned to 16 byte boundary to be able to use the non-temporal instructions while copying. Non-temporal instructions are used only for loading from the source address which has alignment constraints. We only need to take care of using the right ins

[Intel-gfx] [PATCH v2 0/7] drm/i915: Use the memcpy_from_wc function from drm

2022-03-03 Thread Balasubramani Vivekanandan
drm_memcpy_from_wc() performs fast copy from WC memory type using non-temporal instructions. Now there are two similar implementations of this function. One exists in drm_cache.c as drm_memcpy_from_wc() and another implementation in i915/i915_memcpy.c as i915_memcpy_from_wc(). drm_memcpy_from_wc()

[Intel-gfx] [PATCH v2 2/7] drm: Add drm_memcpy_from_wc() variant which accepts destination address

2022-03-03 Thread Balasubramani Vivekanandan
Fast copy using non-temporal instructions for x86 currently exists at two locations. One is implemented in i915 driver at i915/i915_memcpy.c and another copy at drm_cache.c. The plan is to remove the duplicate implementation in i915 driver and use the functions from drm_cache.c. A variant of drm_m

[Intel-gfx] [PATCH 2/5] drm/i915/gmbus: reduce gmbus pin lookups in gmbus setup

2022-03-03 Thread Jani Nikula
Avoid separate pin lookups for validity and name. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_gmbus.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c index 9

[Intel-gfx] [PATCH 4/5] drm/i915/gmbus: alloc intel_gmbus dynamically

2022-03-03 Thread Jani Nikula
Allocate the individual intel_gmbus structs dynamically. This lets us hide struct intel_gmbus inside intel_gmbus.c completely. Also use the cleanup function on the error path to avoid duplication. Leave #include in i915_drv.h for now, as it pulls in a bunch of implicit dependencies. Signed-off-b

[Intel-gfx] [PATCH 3/5] drm/i915/gmbus: pass gpio reg to intel_gpio_setup()

2022-03-03 Thread Jani Nikula
Avoid the additional gmbus lookup on the pin. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_gmbus.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c index 9dc664

[Intel-gfx] [PATCH 5/5] drm/i915: include linux/highmem.h and linux/swap.h where needed

2022-03-03 Thread Jani Nikula
Include linux/highmem.h and linux/swap.h explicitly where needed so we can drop the linux/i2c.h include from i915_drv.h where it pulled in the dependencies implicitly. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gem/i915_gem_context.c| 1 + drivers/gpu/drm/i915/gem/i915_gem_execb

[Intel-gfx] [PATCH 1/5] drm/i915/gmbus: combine gmbus pin lookups to one function

2022-03-03 Thread Jani Nikula
Combine the platform specific if ladders for array lookup and size checks into one. This is cleaner and avoids duplication, but hopefully also helps any static analyzers that seem to have trouble with the bounds checks. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_gmbus.c |

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: reduce overzealous alignment constraints for GGTT (rev2)

2022-03-03 Thread Patchwork
== Series Details == Series: drm/i915/gtt: reduce overzealous alignment constraints for GGTT (rev2) URL : https://patchwork.freedesktop.org/series/100991/ State : success == Summary == CI Bug Log - changes from CI_DRM_11320 -> Patchwork_22474 ===

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Use the memcpy_from_wc function from drm (rev3)

2022-03-03 Thread Patchwork
== Series Details == Series: drm/i915: Use the memcpy_from_wc function from drm (rev3) URL : https://patchwork.freedesktop.org/series/100581/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Make the heartbeat play nice with long pre-emption timeouts

2022-03-03 Thread John Harrison
On 3/3/2022 01:55, Tvrtko Ursulin wrote: On 02/03/2022 17:55, John Harrison wrote: I was assuming 2.5s tP is enough and basing all calculation on that. Heartbeat or timeslicing regardless. I thought we established neither of us knows how long is enough. Are you now saying 2.5s is definitely

[Intel-gfx] [PATCH v2 0/9] drm/i915: Fix bandwith related cdclk calculations

2022-03-03 Thread Ville Syrjala
From: Ville Syrjälä Fix up the dbuf bandwidth cdclk calculations to match the spec, and also implement the cdclk based pipe max bandwidth limit. TODO: intel_bw contains two orthogonal things (qgv vs. cdclk). We should probably just split it into two parts to life less confusing. But

[Intel-gfx] [PATCH v2 1/9] drm/i915: Tweak plane ddb allocation tracking

2022-03-03 Thread Ville Syrjala
From: Ville Syrjälä Let's store the plane allocation in a manner which more closely matches how the hw operates. That is, we store the packed/CbCr ddb in one struct, and the Y ddb in another. Currently we're storing packed/Y in one struct, CbCr in the other. This also works pretty well for icl+

[Intel-gfx] [PATCH v2 2/9] drm/i915: Split plane data_rate into data_rate+data_rate_y

2022-03-03 Thread Ville Syrjala
From: Ville Syrjälä Split the currently combined plane data_rate into the proper Y vs. CbCr components. This matches how we now track the plane dbuf allocations, and thus will make the dbuf bandwidth calculations actually produce the correct numbers for each dbuf slice. Reviewed-by: Stanislav Li

[Intel-gfx] [PATCH v2 4/9] drm/i915: Remove total[] and uv_total[] from ddb allocation

2022-03-03 Thread Ville Syrjala
From: Ville Syrjälä There's really no need to maintain these total[] arrays to track the size of each plane's ddb allocation. We just stick the results straight into the crtc_state ddb tracking structures. The main annoyance with all this is the mismatch between wm_uv vs. ddb_y on pre-icl. If on

[Intel-gfx] [PATCH v2 3/9] drm/i915: Pre-calculate plane relative data rate

2022-03-03 Thread Ville Syrjala
From: Ville Syrjälä Handle the plane relative data rate in exactly the same way as we already handle the real data rate. Ie. pre-calculate it during intel_plane_atomic_check_with_state(), and assign/clear it for the Y plane as needed. This should guarantee that the tracking is 100% consistent, an

[Intel-gfx] [PATCH v2 5/9] drm/i915: Nuke intel_bw_calc_min_cdclk()

2022-03-03 Thread Ville Syrjala
From: Ville Syrjälä intel_bw_calc_min_cdclk() is entirely pointless. All it manages to do is somehow conflate the per-pipe min cdclk with dbuf min cdclk. There is no (at least documented) dbuf min cdclk limit on pre-skl so let's just get rid of all this confusion. Reviewed-by: Stanislav Lisovski

[Intel-gfx] [PATCH v2 6/9] drm/i915: Round up when calculating display bandwidth requirements

2022-03-03 Thread Ville Syrjala
From: Ville Syrjälä We should round up when doing bandwidth calculations to make sure our estimates don't fall short of the actual number. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gp

[Intel-gfx] [PATCH v2 8/9] drm/i915: Fix DBUF bandwidth vs. cdclk handling

2022-03-03 Thread Ville Syrjala
From: Ville Syrjälä Make the dbuf bandwidth min cdclk calculations match the spec more closely. Supposedly the arbiter can only guarantee an equal share of the total bandwidth of the slice to each active plane on that slice. So we take the max bandwidth of any of the planes on each slice and mult

[Intel-gfx] [PATCH v2 7/9] drm/i915: Properly write lock bw_state when it changes

2022-03-03 Thread Ville Syrjala
From: Ville Syrjälä The current code also forgets to call intel_atomic_lock_global_state() when other stuff besides the final min_cdlck changes in the state. That means we may throw away data which actually has changed, and thus we can't be at all sure what the code ends up doing during subsequen

[Intel-gfx] [PATCH v2 9/9] drm/i915: Add "maximum pipe read bandwidth" checks

2022-03-03 Thread Ville Syrjala
From: Ville Syrjälä Make sure the CDCLK is high enough to support the so called "maximum pipe read bandwidth" limitation. Specified as 51.2 x CDCLK. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bw.c | 36 + drivers/gpu/drm/i915/display/intel_bw.h

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915/gmbus: combine gmbus pin lookups to one function

2022-03-03 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/gmbus: combine gmbus pin lookups to one function URL : https://patchwork.freedesktop.org/series/101007/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use the memcpy_from_wc function from drm (rev3)

2022-03-03 Thread Patchwork
== Series Details == Series: drm/i915: Use the memcpy_from_wc function from drm (rev3) URL : https://patchwork.freedesktop.org/series/100581/ State : success == Summary == CI Bug Log - changes from CI_DRM_11320 -> Patchwork_22475 Summary --

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915/gmbus: combine gmbus pin lookups to one function

2022-03-03 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/gmbus: combine gmbus pin lookups to one function URL : https://patchwork.freedesktop.org/series/101007/ State : success == Summary == CI Bug Log - changes from CI_DRM_11320 -> Patchwork_22476

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix bandwith related cdclk calculations (rev2)

2022-03-03 Thread Patchwork
== Series Details == Series: drm/i915: Fix bandwith related cdclk calculations (rev2) URL : https://patchwork.freedesktop.org/series/98975/ State : warning == Summary == $ dim checkpatch origin/drm-tip c60dc5b8150b drm/i915: Tweak plane ddb allocation tracking f73e140093bf drm/i915: Split plan

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix bandwith related cdclk calculations (rev2)

2022-03-03 Thread Patchwork
== Series Details == Series: drm/i915: Fix bandwith related cdclk calculations (rev2) URL : https://patchwork.freedesktop.org/series/98975/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915/cdclk: Add cdclk check to atomic check

2022-03-03 Thread Srivatsa, Anusha
> -Original Message- > From: Jani Nikula > Sent: Thursday, March 3, 2022 1:59 AM > To: Srivatsa, Anusha ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/cdclk: Add cdclk check to atomic > check > > On Wed, 02 Mar 2022, Anusha Srivatsa wrote: > > Checki

Re: [Intel-gfx] [PATCH 4/5] drm/i915/gmbus: alloc intel_gmbus dynamically

2022-03-03 Thread Ville Syrjälä
On Thu, Mar 03, 2022 at 08:19:30PM +0200, Jani Nikula wrote: > Allocate the individual intel_gmbus structs dynamically. This lets us > hide struct intel_gmbus inside intel_gmbus.c completely. Also use the > cleanup function on the error path to avoid duplication. > > Leave #include in i915_drv.h

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix bandwith related cdclk calculations (rev2)

2022-03-03 Thread Patchwork
== Series Details == Series: drm/i915: Fix bandwith related cdclk calculations (rev2) URL : https://patchwork.freedesktop.org/series/98975/ State : success == Summary == CI Bug Log - changes from CI_DRM_11320 -> Patchwork_22477 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/selftests: fix a shift-out-of-bounds bug

2022-03-03 Thread Patchwork
== Series Details == Series: drm/selftests: fix a shift-out-of-bounds bug URL : https://patchwork.freedesktop.org/series/101012/ State : warning == Summary == $ dim checkpatch origin/drm-tip 233edfd3e6e2 drm/selftests: fix a shift-out-of-bounds bug -:47: WARNING:COMMIT_LOG_LONG_LINE: Possible

[Intel-gfx] [CI 1/2] drm/i915/fbdev: fixup setting screen_size

2022-03-03 Thread Matthew Auld
Since we are actually mapping the object and not the vma, when dealing with LMEM, we should be careful and use the obj->base.size here, since the vma could have all kinds of funny padding constraints. Signed-off-by: Matthew Auld Cc: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_fbd

[Intel-gfx] [CI 2/2] drm/i915/dpt: setup dummy scratch

2022-03-03 Thread Matthew Auld
We currently blow up in i915_vm_lock_objects when binding the dpt, due to what looks like NULL scratch[0]. Likely the moving fence has not been unset yet(even though it should have signalled), due to some previous move. For now let's just create something which more closely resembles a proper vm.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/adl-n: Add stepping info

2022-03-03 Thread Patchwork
== Series Details == Series: drm/i915/adl-n: Add stepping info URL : https://patchwork.freedesktop.org/series/100995/ State : success == Summary == CI Bug Log - changes from CI_DRM_11318_full -> Patchwork_22472_full Summary --- **SUC

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/selftests: fix a shift-out-of-bounds bug

2022-03-03 Thread Patchwork
== Series Details == Series: drm/selftests: fix a shift-out-of-bounds bug URL : https://patchwork.freedesktop.org/series/101012/ State : success == Summary == CI Bug Log - changes from CI_DRM_11320 -> Patchwork_22478 Summary --- **SU

[Intel-gfx] 2022 X.Org Board of Directors Elections timeline extended, Request for nominations

2022-03-03 Thread Lyude Paul
We are seeking nominations for candidates for election to the X.org Foundation Board of Directors. However, as we presently do not have enough nominations to start the election - the decision has been made to extend the timeline by 2 weeks. Note this is a fairly regular part of the elections proces

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/fbdev: fixup setting screen_size

2022-03-03 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/fbdev: fixup setting screen_size URL : https://patchwork.freedesktop.org/series/101016/ State : success == Summary == CI Bug Log - changes from CI_DRM_11320 -> Patchwork_22479 ==

[Intel-gfx] ✓ Fi.CI.BAT: success for Bump DMC to v2.16 on ADL-P (rev2)

2022-03-03 Thread Patchwork
== Series Details == Series: Bump DMC to v2.16 on ADL-P (rev2) URL : https://patchwork.freedesktop.org/series/100666/ State : success == Summary == CI Bug Log - changes from CI_DRM_11320 -> Patchwork_22480 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v2 10/13] drm/i915: Start tracking PIPESRC as a drm_rect

2022-03-03 Thread Navare, Manasi
On Wed, Feb 23, 2022 at 03:13:12PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Instead of just having the pipe_src_{w,h} let's use a full > drm_rect for it. This will be particularly useful to astract > away some bigjoiner details. > > v2: No hweight() stuff yet > > Signed-off-by: Vil

Re: [Intel-gfx] [PATCH v2 12/13] drm/i915: Use bigjoiner_pipes more

2022-03-03 Thread Navare, Manasi
On Thu, Feb 24, 2022 at 12:35:59PM +0200, Ville Syrjälä wrote: > On Wed, Feb 23, 2022 at 12:00:28PM -0800, Navare, Manasi wrote: > > On Wed, Feb 23, 2022 at 03:13:14PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Replace the hardcoded 2 pipe assumptions when we're massaging >

[Intel-gfx] [PATCH 1/2] drm/i915/xehp: Support platforms with CCS engines but no RCS

2022-03-03 Thread Matt Roper
In the past we've always assumed that an RCS engine is present on every platform. However now that we have compute engines there may be platforms that have CCS engines but no RCS, or platforms that are designed to have both, but have the RCS engine fused off. Various engine-centric initialization

[Intel-gfx] [PATCH 2/2] drm/i915: Add RCS mask to GuC ADS params

2022-03-03 Thread Matt Roper
From: Stuart Summers If RCS is not enumerated, GuC will return invalid parameters. Make sure we do not send RCS supported when we have not enumerated it. Cc: Vinay Belgaumkar Signed-off-by: Stuart Summers Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 2 +- 1 file

  1   2   >