[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: use get_reset_domain() helper

2022-02-18 Thread Patchwork
== Series Details == Series: drm/i915/gt: use get_reset_domain() helper URL : https://patchwork.freedesktop.org/series/100326/ State : success == Summary == CI Bug Log - changes from CI_DRM_11242_full -> Patchwork_22314_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/dp: remove accidental static on what should be a local variable

2022-02-18 Thread Jani Nikula
On Thu, 17 Feb 2022, Lucas De Marchi wrote: > On Thu, Feb 17, 2022 at 10:39:38AM +0200, Jani Nikula wrote: >>The variable should obviously be local, not static. >> >>Fixes: a421d8a99216 ("drm/i915/dp: rewrite DP 2.0 128b/132b link training >>based on errata") >>Cc: Ville Syrjälä >>Signed-off-by:

Re: [Intel-gfx] [PATCH v5 09/19] Doc/gpu/rfc/i915: i915 DG2 64k pagesize uAPI

2022-02-18 Thread Ramalingam C
On 2022-02-17 at 21:39:16 -0800, Lucas De Marchi wrote: > On Tue, Feb 01, 2022 at 04:11:22PM +0530, Ramalingam C wrote: > > Details of the 64k pagesize support added as part of DG2 enabling and its > > implicit impact on the uAPI. > > > > v2: improvised the Flat-CCS documentation [Danvet & CQ] > >

Re: [Intel-gfx] [PATCH v3] drm/i915/display/vrr: Reset VRR capable property on a long hpd

2022-02-18 Thread Jani Nikula
On Thu, 17 Feb 2022, "Navare, Manasi" wrote: > Hi Jani, > > This addresses the review comments, could you please take a look at thsi > patch? Sorry for the delay, Reviewed-by: Jani Nikula > > Manasi > > On Tue, Feb 15, 2022 at 12:26:01PM -0800, Manasi Navare wrote: >> With some VRR panels, u

Re: [Intel-gfx] [PATCH v5 5/7] drm/i915/gt: Create per-tile RC6 sysfs interface

2022-02-18 Thread Tvrtko Ursulin
On 17/02/2022 15:53, Andi Shyti wrote: Hi Tvrtko, Now tiles have their own sysfs interfaces under the gt/ directory. Because RC6 is a property that can be configured on a tile basis, then each tile should have its own interface The new sysfs structure will have a similar layout for the 4 til

Re: [Intel-gfx] [PATCH v5 5/7] drm/i915/gt: Create per-tile RC6 sysfs interface

2022-02-18 Thread Andi Shyti
Hi Tvrtko, > > > > Now tiles have their own sysfs interfaces under the gt/ > > > > directory. Because RC6 is a property that can be configured on a > > > > tile basis, then each tile should have its own interface > > > > > > > > The new sysfs structure will have a similar layout for the 4 tile >

[Intel-gfx] [PATCH 1/2] drm/i915/dg2: Drop 38.4 MHz MPLLB tables

2022-02-18 Thread Lucas De Marchi
From: Matt Roper Our early understanding of DG2 was incorrect; since the 5th display isn't actually a Type-C output, 38.4 MHz input clocks are never used on this platform and we can drop the corresponding MPLLB tables. Cc: Anusha Srivatsa Cc: José Roberto de Souza Signed-off-by: Matt Roper Si

[Intel-gfx] [PATCH 0/2] drm/i915/dg2: Do not use phy E

2022-02-18 Thread Lucas De Marchi
This is an alternative to https://patchwork.freedesktop.org/series/100151/ ("drm/i915/dg2: 5th Display output"). We tried to enable the 5th port in order to get rid of the unclaimed register access, but even after the basic plumbing, we are still getting and error that the phy failed to calibrate.

[Intel-gfx] [PATCH 2/2] drm/i915/dg2: Do not use phy E

2022-02-18 Thread Lucas De Marchi
PORT_TC1 is still not being initialized - that is the port that uses phy E. However the intel_phy_is_snps() reports that phy as being present, which causes warnings about unclaimed access to the PHY_MISC register. Even with some basic wiring up for that port, it still gives the error: i91

[Intel-gfx] [PATCH 00/22] drm: Review of mode copies

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä I might be taking this a bit too far, but the lack of consistency in our methods to copy drm_display_mode structs around is bugging me. The main worry is the embedded list head, which if clobbered could lead to list corruption. I'd also prefer to make sure even the valid list

[Intel-gfx] [PATCH 01/22] drm: Add drm_mode_init()

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä Add a variant of drm_mode_copy() that explicitly clears out the list head of the destination mode. Helpful to guarantee we don't have stack garbage left in there for on-stack modes. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_modes.c | 17 + include

[Intel-gfx] [PATCH 03/22] drm/amdgpu: Use drm_mode_init() for on-stack modes

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä Initialize on-stack modes with drm_mode_init() to guarantee no stack garbage in the list head, or that we aren't copying over another mode's list head. Based on the following cocci script, with manual fixups: @decl@ identifier M; expression E; @@ - struct drm_display_mode M =

[Intel-gfx] [PATCH 02/22] drm/amdgpu: Remove pointless on stack mode copies

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä These on stack copies of the modes appear to be pointless. Just look at the originals directly. Cc: Harry Wentland Cc: Leo Li Cc: Rodrigo Siqueira Cc: Alex Deucher Cc: amd-...@lists.freedesktop.org Cc: Nikola Cornij Cc: Aurabindo Pillai Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH 05/22] drm/radeon: Use drm_mode_copy()

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the destination mode. Even if we know the destinat

[Intel-gfx] [PATCH 06/22] drm/bridge: Use drm_mode_copy()

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the destination mode. Even if we know the destinat

[Intel-gfx] [PATCH 07/22] drm/gma500: Use drm_mode_copy()

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the destination mode. Even if we know the destinat

[Intel-gfx] [PATCH 04/22] drm/amdgpu: Use drm_mode_copy()

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the destination mode. Even if we know the destinat

[Intel-gfx] [PATCH 08/22] drm/hisilicon: Use drm_mode_init() for on-stack modes

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä Initialize on-stack modes with drm_mode_init() to guarantee no stack garbage in the list head. Cc: Xinliang Liu Cc: Tian Tao Cc: John Stultz Cc: Xinwei Kong Cc: Chen Feng Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 2 +- 1 file chang

[Intel-gfx] [PATCH 09/22] drm/imx: Use drm_mode_duplicate()

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä Replace the hand rolled drm_mode_duplicate() with the real thing. @is_dup@ @@ drm_mode_duplicate(...) { ... } @depends on !is_dup@ expression dev, oldmode; identifier newmode; @@ - newmode = drm_mode_create(dev); + newmode = drm_mode_duplicate(dev, oldmode); ... - drm_mode

[Intel-gfx] [PATCH 10/22] drm/msm: Nuke weird on stack mode copy

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä This on stack middle man mode looks entirely pointless. Just duplicate the original mode directly. Cc: Rob Clark Cc: Sean Paul Cc: Abhinav Kumar Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/msm/dp/

[Intel-gfx] [PATCH 11/22] drm/msm: Use drm_mode_init() for on-stack modes

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä Initialize on-stack modes with drm_mode_init() to guarantee no stack garbage in the list head, or that we aren't copying over another mode's list head. Based on the following cocci script, with manual fixups: @decl@ identifier M; expression E; @@ - struct drm_display_mode M =

[Intel-gfx] [PATCH 12/22] drm/msm: Use drm_mode_copy()

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the destination mode. Even if we know the destinat

[Intel-gfx] [PATCH 13/22] drm/mtk: Use drm_mode_init() for on-stack modes

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä Initialize on-stack modes with drm_mode_init() to guarantee no stack garbage in the list head. Based on the following cocci script, with manual fixups: @decl@ identifier M; expression E; @@ - struct drm_display_mode M = E; + struct drm_display_mode M; @@ identifier decl.M; e

[Intel-gfx] [PATCH 14/22] drm/rockchip: Use drm_mode_copy()

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the destination mode. Even if we know the destinat

[Intel-gfx] [PATCH 17/22] drm/vc4: Use drm_mode_copy()

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the destination mode. Even if we know the destinat

[Intel-gfx] [PATCH 19/22] drm/i915: Use drm_mode_copy()

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the destination mode. Even if we know the destinat

[Intel-gfx] [PATCH 20/22] drm/panel: Use drm_mode_duplicate()

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä Replace the hand rolled drm_mode_duplicate() with the real thing. @is_dup@ @@ drm_mode_duplicate(...) { ... } @depends on !is_dup@ expression dev, oldmode; identifier newmode; @@ - newmode = drm_mode_create(dev); + newmode = drm_mode_duplicate(dev, oldmode); ... - drm_mode

[Intel-gfx] [PATCH 22/22] drm: Use drm_mode_copy()

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the destination mode. Even if we know the destinat

[Intel-gfx] [PATCH 15/22] drm/sti: Use drm_mode_copy()

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the destination mode. Even if we know the destinat

[Intel-gfx] [PATCH 18/22] drm/i915: Use drm_mode_init() for on-stack modes

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä Initialize on-stack modes with drm_mode_init() to guarantee no stack garbage in the list head, or that we aren't copying over another mode's list head. Based on the following cocci script, with manual fixups: @decl@ identifier M; expression E; @@ - struct drm_display_mode M =

[Intel-gfx] [PATCH 16/22] drm/tilcdc: Use drm_mode_copy()

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the destination mode. Even if we know the destinat

[Intel-gfx] [PATCH 21/22] drm: Use drm_mode_init() for on-stack modes

2022-02-18 Thread Ville Syrjala
From: Ville Syrjälä Initialize on-stack modes with drm_mode_init() to guarantee no stack garbage in the list head, or that we aren't copying over another mode's list head. Based on the following cocci script, with manual fixups: @decl@ identifier M; expression E; @@ - struct drm_display_mode M =

Re: [Intel-gfx] [PATCH v5 11/19] drm/i915/lmem: Enable lmem for platforms with Flat CCS

2022-02-18 Thread Lucas De Marchi
On Tue, Feb 01, 2022 at 04:11:24PM +0530, Ramalingam C wrote: From: Abdiel Janulgue A portion of device memory is reserved for Flat CCS so usable device memory will be reduced by size of Flat CCS. Size of Flat CCS is specified in “XEHPSDV_FLAT_CCS_BASE_ADDR”. So to get effective device memory w

Re: [Intel-gfx] [PATCH 3/9] lib/ref_tracker: __ref_tracker_dir_print improve printing

2022-02-18 Thread Andrzej Hajda
On 17.02.2022 16:38, Eric Dumazet wrote: On Thu, Feb 17, 2022 at 6:05 AM Andrzej Hajda wrote: To improve readibility of ref_tracker printing following changes have been performed: - added display name for ref_tracker_dir, - stack trace is printed indented, in the same printk call, - total nu

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Disconnect PHYs left connected by BIOS on disabled ports

2022-02-18 Thread Patchwork
== Series Details == Series: drm/i915: Disconnect PHYs left connected by BIOS on disabled ports URL : https://patchwork.freedesktop.org/series/100336/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11243_full -> Patchwork_22317_full =

Re: [Intel-gfx] [PATCH v5 11/19] drm/i915/lmem: Enable lmem for platforms with Flat CCS

2022-02-18 Thread Lucas De Marchi
On Fri, Feb 18, 2022 at 02:08:18AM -0800, Lucas De Marchi wrote: On Tue, Feb 01, 2022 at 04:11:24PM +0530, Ramalingam C wrote: From: Abdiel Janulgue A portion of device memory is reserved for Flat CCS so usable device memory will be reduced by size of Flat CCS. Size of Flat CCS is specified in

Re: [Intel-gfx] [PATCH 5/9] lib/ref_tracker: improve allocation flags

2022-02-18 Thread Andrzej Hajda
On 17.02.2022 16:13, Eric Dumazet wrote: On Thu, Feb 17, 2022 at 6:05 AM Andrzej Hajda wrote: Library can be called in non-sleeping context, so it should not use __GFP_NOFAIL. Instead it should calmly handle allocation fails, for this __GFP_NOWARN has been added as well. Your commit changel

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Separate wakeref tracking

2022-02-18 Thread Andrzej Hajda
On 17.02.2022 15:48, Ville Syrjälä wrote: On Thu, Feb 17, 2022 at 03:04:38PM +0100, Andrzej Hajda wrote: -static noinline depot_stack_handle_t +static intel_wakeref_t track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm) { - depot_stack_handle_t stack, *stacks; - unsign

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-18 Thread Hans de Goede
Hi, Sorry for jumping in in the middle of the thread I did not notice this thread before. On 2/16/22 13:00, Emil Velikov wrote: > On Tue, 15 Feb 2022 at 16:37, Simon Ser wrote: >> >> On Tuesday, February 15th, 2022 at 15:38, Emil Velikov >> wrote: >> >>> On Tue, 15 Feb 2022 at 13:55, Simon Ser

Re: [Intel-gfx] [PATCH v5 5/7] drm/i915/gt: Create per-tile RC6 sysfs interface

2022-02-18 Thread Joonas Lahtinen
Quoting Andi Shyti (2022-02-17 17:53:58) > Hi Tvrtko, > > > > Now tiles have their own sysfs interfaces under the gt/ > > > directory. Because RC6 is a property that can be configured on a > > > tile basis, then each tile should have its own interface > > > > > > The new sysfs structure will have

Re: [Intel-gfx] [PATCH 2/9] lib/ref_tracker: compact stacktraces before printing

2022-02-18 Thread Andrzej Hajda
On 17.02.2022 16:23, Eric Dumazet wrote: On Thu, Feb 17, 2022 at 6:05 AM Andrzej Hajda wrote: In cases references are taken alternately on multiple exec paths leak report can grow substantially, sorting and grouping leaks by stack_handle allows to compact it. Signed-off-by: Andrzej Hajda R

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add driver for GSC controller (rev9)

2022-02-18 Thread Patchwork
== Series Details == Series: Add driver for GSC controller (rev9) URL : https://patchwork.freedesktop.org/series/98066/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11243_full -> Patchwork_22318_full Summary --- **F

Re: [Intel-gfx] [PATCH 01/22] drm: Add drm_mode_init()

2022-02-18 Thread Andrzej Hajda
On 18.02.2022 11:03, Ville Syrjala wrote: From: Ville Syrjälä Add a variant of drm_mode_copy() that explicitly clears out the list head of the destination mode. Helpful to guarantee we don't have stack garbage left in there for on-stack modes. Signed-off-by: Ville Syrjälä --- drivers/gpu

[Intel-gfx] [PATCH 0/2] doc/rfc for small BAR support

2022-02-18 Thread Matthew Auld
The new bits of proposed uAPI for the upcoming small BAR support. -- 2.34.1

[Intel-gfx] [PATCH 1/2] drm/doc: remove rfc section for dg1

2022-02-18 Thread Matthew Auld
We already completed the steps for this. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: mesa-...@lists.freedesktop.org --- Documentation/gpu/rfc/i915_gem_lmem.rst | 22 -- Documentation/gpu/

[Intel-gfx] [PATCH 2/2] drm/doc: add rfc section for small BAR uapi

2022-02-18 Thread Matthew Auld
Add an entry for the new uapi needed for small BAR on DG2+. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: mesa-...@lists.freedesktop.org --- Documentation/gpu/rfc/i915_small_bar.h | 153 +

Re: [Intel-gfx] [PATCH 06/22] drm/bridge: Use drm_mode_copy()

2022-02-18 Thread Andrzej Hajda
On 18.02.2022 11:03, Ville Syrjala wrote: From: Ville Syrjälä struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the

Re: [Intel-gfx] [PATCH V3 2/13] clk: mvebu: use time_is_before_eq_jiffies() instead of open coding it

2022-02-18 Thread Stephen Boyd
Quoting Qing Wang (2022-02-14 17:55:39) > From: Wang Qing > > Use the helper function time_is_{before,after}_jiffies() to improve > code readability. > > Signed-off-by: Wang Qing > --- Applied to clk-next

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-18 Thread Simon Ser
On Friday, February 18th, 2022 at 11:38, Hans de Goede wrote: > What I'm reading in the above is that it is being considered to allow > changing the panel-orientation value after the connector has been made > available to userspace; and let userspace know about this through a uevent. > > I belie

Re: [Intel-gfx] [PATCH 09/22] drm/imx: Use drm_mode_duplicate()

2022-02-18 Thread Philipp Zabel
On Fri, 2022-02-18 at 12:03 +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the hand rolled drm_mode_duplicate() with the > real thing. > > @is_dup@ > @@ > drm_mode_duplicate(...) > { ... } > > @depends on !is_dup@ > expression dev, oldmode; > identifier newmode; > @@ > - newmode

Re: [Intel-gfx] [PATCH] iommu/vt-d: Add RPLS to quirk list to skip TE disabling

2022-02-18 Thread Rodrigo Vivi
On Tue, Feb 15, 2022 at 05:08:18PM +0530, Tejas Upadhyay wrote: > The VT-d spec requires (10.4.4 Global Command Register, TE > field) that: > > Hardware implementations supporting DMA draining must drain > any in-flight DMA read/write requests queued within the > Root-Complex before completing the

Re: [Intel-gfx] [PATCH 20/22] drm/panel: Use drm_mode_duplicate()

2022-02-18 Thread Sam Ravnborg
Hi Ville, On Fri, Feb 18, 2022 at 12:04:01PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the hand rolled drm_mode_duplicate() with the > real thing. > > @is_dup@ > @@ > drm_mode_duplicate(...) > { ... } > > @depends on !is_dup@ > expression dev, oldmode; > identifier newmode;

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-18 Thread Hans de Goede
Hi, On 2/18/22 12:39, Simon Ser wrote: > On Friday, February 18th, 2022 at 11:38, Hans de Goede > wrote: > >> What I'm reading in the above is that it is being considered to allow >> changing the panel-orientation value after the connector has been made >> available to userspace; and let usersp

Re: [Intel-gfx] [PATCH 01/22] drm: Add drm_mode_init()

2022-02-18 Thread Ville Syrjälä
On Fri, Feb 18, 2022 at 12:22:44PM +0100, Andrzej Hajda wrote: > > > On 18.02.2022 11:03, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Add a variant of drm_mode_copy() that explicitly clears out > > the list head of the destination mode. Helpful to guarantee > > we don't have stack garba

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ttm: fixup the mock_bo (rev2)

2022-02-18 Thread Patchwork
== Series Details == Series: drm/i915/ttm: fixup the mock_bo (rev2) URL : https://patchwork.freedesktop.org/series/100255/ State : warning == Summary == $ dim checkpatch origin/drm-tip 31d5b4fb673a drm/i915/ttm: fixup the mock_bo -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit de

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-18 Thread Simon Ser
On Friday, February 18th, 2022 at 12:54, Hans de Goede wrote: > On 2/18/22 12:39, Simon Ser wrote: > > On Friday, February 18th, 2022 at 11:38, Hans de Goede > > wrote: > > > >> What I'm reading in the above is that it is being considered to allow > >> changing the panel-orientation value afte

Re: [Intel-gfx] [PATCH 01/22] drm: Add drm_mode_init()

2022-02-18 Thread Andrzej Hajda
On 18.02.2022 12:56, Ville Syrjälä wrote: On Fri, Feb 18, 2022 at 12:22:44PM +0100, Andrzej Hajda wrote: On 18.02.2022 11:03, Ville Syrjala wrote: From: Ville Syrjälä Add a variant of drm_mode_copy() that explicitly clears out the list head of the destination mode. Helpful to guarantee we

[Intel-gfx] [PATCH] drm/i915/adlp: Add TypeC PHY TBT->DP-alt/legacy mode switch workaround

2022-02-18 Thread Imre Deak
Add display workaround # 1309179469 , which fixes a PHY hang when switching from TBT mode to DP-alt/legacy mode. The workaround also requires an IFWI/PHY firmware change, before that this change has no effect (the DKL_PCS_DW5/SOFTRESET flag is always cleared). HSDES: 18018237866 HSDES: 16014473319

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ttm: fixup the mock_bo (rev2)

2022-02-18 Thread Patchwork
== Series Details == Series: drm/i915/ttm: fixup the mock_bo (rev2) URL : https://patchwork.freedesktop.org/series/100255/ State : success == Summary == CI Bug Log - changes from CI_DRM_11248 -> Patchwork_22328 Summary --- **SUCCESS*

[Intel-gfx] [PATCH v2] drm/i915/adlp: Add TypeC PHY TBT->DP-alt/legacy mode switch workaround

2022-02-18 Thread Imre Deak
Add display workaround # 1309179469 , which fixes a PHY hang when switching from TBT mode to DP-alt/legacy mode. The workaround also requires an IFWI/PHY firmware change, before that this change has no effect (the DKL_PCS_DW5/SOFTRESET flag is always cleared). HSDES: 18018237866 HSDES: 16014473319

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg2: Do not use phy E

2022-02-18 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Do not use phy E URL : https://patchwork.freedesktop.org/series/100390/ State : warning == Summary == $ dim checkpatch origin/drm-tip 58e2625786ba drm/i915/dg2: Drop 38.4 MHz MPLLB tables a0ab07a6c339 drm/i915/dg2: Do not use phy E -:11: WARNING:COMMI

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Move PIPE_CHICKEN RMW out from the vblank evade critical section

2022-02-18 Thread Juha-Pekka Heikkila
This patch set look all ok. That failed cursor test in ci run seem to be flip flopping on other runs too on same icl box. Reviewed-by: Juha-Pekka Heikkila On 2.2.2022 13.16, Ville Syrjala wrote: From: Ville Syrjälä We don't want any RMWs in the part of the commit that happens under vblank e

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Move PIPE_CHICKEN RMW out from the vblank evade critical section

2022-02-18 Thread Ville Syrjälä
On Fri, Feb 18, 2022 at 02:38:37PM +0200, Juha-Pekka Heikkila wrote: > This patch set look all ok. That failed cursor test in ci run seem to be > flip flopping on other runs too on same icl box. Yeah, some of those tests seem a bit flaky on the icls. Not sure what's causing that. > > Reviewed-

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg2: Do not use phy E

2022-02-18 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Do not use phy E URL : https://patchwork.freedesktop.org/series/100390/ State : success == Summary == CI Bug Log - changes from CI_DRM_11248 -> Patchwork_22329 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Kill the fake lmem support (rev2)

2022-02-18 Thread Patchwork
== Series Details == Series: drm/i915: Kill the fake lmem support (rev2) URL : https://patchwork.freedesktop.org/series/100276/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11244_full -> Patchwork_22319_full Summary --

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display: Implement Wa_16013835468

2022-02-18 Thread Hogander, Jouni
On Wed, 2022-02-16 at 13:48 +, Souza, Jose wrote: > On Tue, 2022-02-15 at 12:31 +, Hogander, Jouni wrote: > > On Thu, 2022-02-10 at 10:52 -0800, José Roberto de Souza wrote: > > > PSR2 workaround required when mode has delayed vblank. > > > > > > BSpec: 52890 > > > BSpec: 49421 > > > Cc: J

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: Group PSR2 prog sequences and workarounds

2022-02-18 Thread Hogander, Jouni
Reviewed-by: Jouni Högander for both patches. On Thu, 2022-02-10 at 10:52 -0800, José Roberto de Souza wrote: > Grouping inside of the same if all the programing sequences and > workarounds of PSR2. > The order of programing changed in intel_psr_enable_source() but > it will not affect PSR2 as a

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Review of mode copies

2022-02-18 Thread Patchwork
== Series Details == Series: drm: Review of mode copies URL : https://patchwork.freedesktop.org/series/100394/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./drivers/gpu/drm/amd/amdgpu/../amdgp

Re: [Intel-gfx] [PATCH v8 5/5] drm/i915/uapi: document behaviour for DG2 64K support

2022-02-18 Thread Ramalingam C
On 2022-02-17 at 20:57:35 -0800, Jordan Justen wrote: > Robert Beckett writes: > > > From: Matthew Auld > > > > On discrete platforms like DG2, we need to support a minimum page size > > of 64K when dealing with device local-memory. This is quite tricky for > > various reasons, so try to documen

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dg2: 5th Display output (rev3)

2022-02-18 Thread Patchwork
== Series Details == Series: drm/i915/dg2: 5th Display output (rev3) URL : https://patchwork.freedesktop.org/series/100151/ State : success == Summary == CI Bug Log - changes from CI_DRM_11244_full -> Patchwork_22320_full Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for doc/rfc for small BAR support

2022-02-18 Thread Patchwork
== Series Details == Series: doc/rfc for small BAR support URL : https://patchwork.freedesktop.org/series/100399/ State : warning == Summary == $ dim checkpatch origin/drm-tip b54660c8b559 drm/doc: remove rfc section for dg1 -:20: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), doe

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Review of mode copies

2022-02-18 Thread Patchwork
== Series Details == Series: drm: Review of mode copies URL : https://patchwork.freedesktop.org/series/100394/ State : success == Summary == CI Bug Log - changes from CI_DRM_11248 -> Patchwork_22330 Summary --- **SUCCESS** No regr

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc/slpc: Use wrapper for reading RP_STATE_CAP (rev2)

2022-02-18 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Use wrapper for reading RP_STATE_CAP (rev2) URL : https://patchwork.freedesktop.org/series/100217/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11244_full -> Patchwork_22321_full =

[Intel-gfx] ✓ Fi.CI.BAT: success for doc/rfc for small BAR support

2022-02-18 Thread Patchwork
== Series Details == Series: doc/rfc for small BAR support URL : https://patchwork.freedesktop.org/series/100399/ State : success == Summary == CI Bug Log - changes from CI_DRM_11248 -> Patchwork_22331 Summary --- **SUCCESS** No r

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/display: Group PSR2 prog sequences and workarounds

2022-02-18 Thread Souza, Jose
On Fri, 2022-02-11 at 00:04 +, Patchwork wrote: Patch Details Series: series starting with [1/2] drm/i915/display: Group PSR2 prog sequences and workarounds URL:https://patchwork.freedesktop.org/series/99989/ State: success Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwo

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Fix flag query helper function to not modify state

2022-02-18 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix flag query helper function to not modify state URL : https://patchwork.freedesktop.org/series/100364/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11244_full -> Patchwork_22323_full ===

[Intel-gfx] [PATCH i-g-t] lib/igt_device: Add support for accessing unbound VF PCI devices

2022-02-18 Thread Janusz Krzysztofik
The library provides igt_device_get_pci_device() function that allows to get access to a PCI device from an open DRM device file descriptor. It can be used on VF devices as long as a DRM driver is bound to them. However, SR-IOV tests may want to exercise VF PCI devices created by a PF without bind

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-18 Thread Alex Deucher
On Fri, Feb 18, 2022 at 7:13 AM Simon Ser wrote: > > On Friday, February 18th, 2022 at 12:54, Hans de Goede > wrote: > > > On 2/18/22 12:39, Simon Ser wrote: > > > On Friday, February 18th, 2022 at 11:38, Hans de Goede > > > wrote: > > > > > >> What I'm reading in the above is that it is being

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-18 Thread Harry Wentland
On 2022-02-18 07:12, Simon Ser wrote: > On Friday, February 18th, 2022 at 12:54, Hans de Goede > wrote: > >> On 2/18/22 12:39, Simon Ser wrote: >>> On Friday, February 18th, 2022 at 11:38, Hans de Goede >>> wrote: >>> What I'm reading in the above is that it is being considered to allow >

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib/igt_device: Add support for accessing unbound VF PCI devices

2022-02-18 Thread Chris Wilson
Quoting Janusz Krzysztofik (2022-02-18 15:19:35) > @@ -206,15 +229,19 @@ static struct pci_device > *__igt_device_get_pci_device(int fd) > igt_warn("Couldn't find PCI device %04x:%02x:%02x:%02x\n", > pci_addr.domain, pci_addr.bus, >

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/4] drm/i915/dsi: disassociate VBT video transfer mode from register values

2022-02-18 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915/dsi: disassociate VBT video transfer mode from register values URL : https://patchwork.freedesktop.org/series/100368/ State : success == Summary == CI Bug Log - changes from CI_DRM_11244_full -> Patchwork_22324_full =

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dg2: Do not use phy E

2022-02-18 Thread Souza, Jose
On Fri, 2022-02-18 at 01:54 -0800, Lucas De Marchi wrote: > PORT_TC1 is still not being initialized - that is the port that uses phy > E. However the intel_phy_is_snps() reports that phy as being present, > which causes warnings about unclaimed access to the PHY_MISC register. > Even with some bas

[Intel-gfx] ✗ Fi.CI.IGT: failure for Prep work for next GuC release (rev2)

2022-02-18 Thread Patchwork
== Series Details == Series: Prep work for next GuC release (rev2) URL : https://patchwork.freedesktop.org/series/99805/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11244_full -> Patchwork_22325_full Summary --- **

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] lib/igt_device: Add support for accessing unbound VF PCI devices

2022-02-18 Thread Janusz Krzysztofik
Hi Chris, On Friday, 18 February 2022 17:03:01 CET Chris Wilson wrote: > Quoting Janusz Krzysztofik (2022-02-18 15:19:35) > > @@ -206,15 +229,19 @@ static struct pci_device > > *__igt_device_get_pci_device(int fd) > > igt_warn("Couldn't find PCI device %04x:%02x:%02x:%02x\n", > >

Re: [Intel-gfx] [PATCH 06/22] drm/bridge: Use drm_mode_copy()

2022-02-18 Thread Laurent Pinchart
Hi Ville, Thank you for the patch. On Fri, Feb 18, 2022 at 12:03:47PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > struct drm_display_mode embeds a list head, so overwriting > the full struct with another one will corrupt the list > (if the destination mode is on a list). Use drm_mode_

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/3] drm/i915: Fix for PHY_MISC_TC1 offset

2022-02-18 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915: Fix for PHY_MISC_TC1 offset URL : https://patchwork.freedesktop.org/series/100373/ State : success == Summary == CI Bug Log - changes from CI_DRM_11244_full -> Patchwork_22326_full

Re: [Intel-gfx] [PATCH v8 5/5] drm/i915/uapi: document behaviour for DG2 64K support

2022-02-18 Thread Robert Beckett
On 18/02/2022 13:47, Ramalingam C wrote: On 2022-02-17 at 20:57:35 -0800, Jordan Justen wrote: Robert Beckett writes: From: Matthew Auld On discrete platforms like DG2, we need to support a minimum page size of 64K when dealing with device local-memory. This is quite tricky for various r

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/adlp: Add TypeC PHY TBT->DP-alt/legacy mode switch workaround (rev2)

2022-02-18 Thread Patchwork
== Series Details == Series: drm/i915/adlp: Add TypeC PHY TBT->DP-alt/legacy mode switch workaround (rev2) URL : https://patchwork.freedesktop.org/series/100404/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checke

Re: [Intel-gfx] [PATCH 1/2] drm/doc: remove rfc section for dg1

2022-02-18 Thread Lucas De Marchi
On Fri, Feb 18, 2022 at 11:22:41AM +, Matthew Auld wrote: We already completed the steps for this. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: mesa-...@lists.freedesktop.org I was indeed wondering why

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/adlp: Add TypeC PHY TBT->DP-alt/legacy mode switch workaround (rev2)

2022-02-18 Thread Patchwork
== Series Details == Series: drm/i915/adlp: Add TypeC PHY TBT->DP-alt/legacy mode switch workaround (rev2) URL : https://patchwork.freedesktop.org/series/100404/ State : success == Summary == CI Bug Log - changes from CI_DRM_11250 -> Patchwork_22332 ===

[Intel-gfx] [PATCH 00/15] drm/i915: Enable DG2

2022-02-18 Thread Ramalingam C
Enabling the Dg2 on drm/i915. This series adds support for 64k pagesize and documents the uapi impacts. And also adds basic flat-ccs enabling patches to support the local memory initialization and object creation. Kdoc is added to document the Flat-ccs support. Flat-ccs modifiers will be enabled

[Intel-gfx] [PATCH 01/15] drm/i915/dg2: Define GuC firmware version for DG2

2022-02-18 Thread Ramalingam C
From: John Harrison First release of GuC for DG2. Signed-off-by: John Harrison CC: Tomasz Mistat CC: Ramalingam C CC: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/g

[Intel-gfx] [PATCH 03/15] drm/i915/dg2: Drop 38.4 MHz MPLLB tables

2022-02-18 Thread Ramalingam C
From: Matt Roper Our early understanding of DG2 was incorrect; since the 5th display isn't actually a Type-C output, 38.4 MHz input clocks are never used on this platform and we can drop the corresponding MPLLB tables. Cc: Anusha Srivatsa Cc: José Roberto de Souza Signed-off-by: Matt Roper Si

[Intel-gfx] [PATCH 02/15] drm/i915: Fix for PHY_MISC_TC1 offset

2022-02-18 Thread Ramalingam C
From: Jouni Högander Currently ICL_PHY_MISC macro is returning offset 0x64C10 for PHY_E. The PORT_TC1 port is not yet enabled properly in the driver, but intel_phy_snps.c is relying on intel_phy_is_snps() to filter out unavailable phys. That function was already considering the last phy as availa

[Intel-gfx] [PATCH 04/15] drm/i915/dg2: Enable 5th port

2022-02-18 Thread Ramalingam C
From: Matt Roper DG2 supports a 5th display output which the hardware refers to as "TC1," even though it isn't a Type-C output. This behaves similarly to the TC1 on past platforms with just a couple minor differences: * DG2's TC1 bit in SDEISR is at bit 25 rather than 24 as it is on ICP/TGP

[Intel-gfx] [PATCH 07/15] drm/i915: support 64K GTT pages for discrete cards

2022-02-18 Thread Ramalingam C
From: Matthew Auld discrete cards optimise 64K GTT pages for local-memory, since everything should be allocated at 64K granularity. We say goodbye to sparse entries, and instead get a compact 256B page-table for 64K pages, which should be more cache friendly. 4K pages for local-memory are no long

[Intel-gfx] [PATCH 06/15] drm/i915: enforce min GTT alignment for discrete cards

2022-02-18 Thread Ramalingam C
From: Matthew Auld For local-memory objects we need to align the GTT addresses to 64K, both for the ppgtt and ggtt. We need to support vm->min_alignment > 4K, depending on the vm itself and the type of object we are inserting. With this in mind update the GTT selftests to take this into account.

[Intel-gfx] [PATCH 08/15] drm/i915: add gtt misalignment test

2022-02-18 Thread Ramalingam C
From: Robert Beckett add test to check handling of misaligned offsets and sizes v4: * remove spurious blank lines * explicitly cast intel_region_id to intel_memory_type in misaligned_pin Reported-by: kernel test robot v6: * use NEEDS_COMPACT_PT instead of hard coding for

[Intel-gfx] [PATCH 05/15] drm/i915: add needs_compact_pt flag

2022-02-18 Thread Ramalingam C
Add a new platform flag, needs_compact_pt, to mark the requirement of compact pt layout support for the ppGTT when using 64K GTT pages. With this flag has_64k_pages will only indicate requirement of 64K GTT page sizes or larger for device local memory access. v6: * minor doc formatting S

[Intel-gfx] [PATCH 09/15] drm/i915/gtt: allow overriding the pt alignment

2022-02-18 Thread Ramalingam C
From: Matthew Auld On some platforms we have alignment restrictions when accessing LMEM from the GTT. In the next few patches we need to be able to modify the page-tables directly via the GTT itself. Suggested-by: Ramalingam C Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C

  1   2   >