Re: [Intel-gfx] [PATCH 6/6] drm/i915/gt: Order GT registers by MMIO offset

2022-02-09 Thread Ville Syrjälä
On Tue, Feb 08, 2022 at 09:11:40PM -0800, Matt Roper wrote: > The random order of register definitions we have today causes a lot of > confusion and unintentional duplication when new registers/bits are > added to the driver. Let's order the GT register file by MMIO offset > > A couple duplicated

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix flag query to not modify state

2022-02-09 Thread Tvrtko Ursulin
On 08/02/2022 18:53, John Harrison wrote: On 2/8/2022 01:39, Tvrtko Ursulin wrote: On 08/02/2022 02:07, john.c.harri...@intel.com wrote: From: John Harrison A flag query helper was actually writing to the flags word rather than just reading. Fix that. Also update the function's comment as

Re: [Intel-gfx] [PATCH v7 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-02-09 Thread Tvrtko Ursulin
On 09/02/2022 06:30, Michael Cheng wrote: Add arm64 support for drm_clflush_virt_range. dcache_clean_inval_poc performs a flush by first performing a clean, follow by an invalidation operation. v2 (Michael Cheng): Use correct macro for cleaning and invalidation the dcache.

Re: [Intel-gfx] [PATCH v6 1/3] i915/gvt: Introduce the mmio table to support VFIO new mdev API

2022-02-09 Thread Jani Nikula
On Wed, 09 Feb 2022, Christoph Hellwig wrote: > On Tue, Feb 08, 2022 at 05:15:00PM +0200, Jani Nikula wrote: >> > #ifdef CONFIG_DRM_I915_GVT >> > + >> > +#define D_BDW (1 << 0) >> > +#define D_SKL (1 << 1) >> > +#define D_KBL (1 << 2) >> > +#define D_BXT (1 << 3) >> > +#define D_CFL

Re: [Intel-gfx] [RFC 00/12] locking: Separate lock tracepoints from lockdep/lock_stat (v1)

2022-02-09 Thread Peter Zijlstra
On Tue, Feb 08, 2022 at 10:41:56AM -0800, Namhyung Kim wrote: > Eventually I'm mostly interested in the contended locks only and I > want to reduce the overhead in the fast path. By moving that, it'd be > easy to track contended locks with timing by using two tracepoints. So why not put in two n

Re: [Intel-gfx] [PATCH v2 6/8] drm/i915/dp: add 128b/132b support to link status checks

2022-02-09 Thread Jani Nikula
On Tue, 08 Feb 2022, Ville Syrjälä wrote: > On Thu, Feb 03, 2022 at 11:03:55AM +0200, Jani Nikula wrote: >> Abstract link status check to a function that takes 128b/132b and 8b/10b >> into account, and use it. Also dump link status on failures. >> >> Cc: Uma Shankar >> Cc: Ville Syrjälä >> Sign

Re: [Intel-gfx] [PATCH v2 6/8] drm/i915/dp: add 128b/132b support to link status checks

2022-02-09 Thread Ville Syrjälä
On Wed, Feb 09, 2022 at 11:09:41AM +0200, Jani Nikula wrote: > On Tue, 08 Feb 2022, Ville Syrjälä wrote: > > On Thu, Feb 03, 2022 at 11:03:55AM +0200, Jani Nikula wrote: > >> Abstract link status check to a function that takes 128b/132b and 8b/10b > >> into account, and use it. Also dump link stat

[Intel-gfx] [PATCH 1/2] drm/atomic: Don't pollute crtc_state->mode_blob with error pointers

2022-02-09 Thread Ville Syrjala
From: Ville Syrjälä Make sure we don't assign an error pointer to crtc_state->mode_blob as that will break all kinds of places that assume either NULL or a valid pointer (eg. drm_property_blob_put()). Reported-by: fuyufan Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic_uapi.c | 14

[Intel-gfx] [PATCH 2/2] drm/modes: Fix drm_mode_copy() docs

2022-02-09 Thread Ville Syrjala
From: Ville Syrjälä There is no object id in drm_display_mode anymore. Remove stale comments to the contrary. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_modes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes

Re: [Intel-gfx] [PATCH v2 0/8] drm/dp, drm/i915: 128b/132b updates

2022-02-09 Thread Jani Nikula
On Thu, 03 Feb 2022, Jani Nikula wrote: > v2 of https://patchwork.freedesktop.org/series/99324/ > > BR, > Jani. > > Jani Nikula (8): > drm/dp: add drm_dp_128b132b_read_aux_rd_interval() > drm/dp: add 128b/132b link status helpers from DP 2.0 E11 > drm/dp: add some new DPCD macros from DP 2.0

Re: [Intel-gfx] [PATCH] drm/i915: move intel_hws_csb_write_index() out of i915_drv.h

2022-02-09 Thread Tvrtko Ursulin
On 08/02/2022 17:16, Jani Nikula wrote: Underscore prefix the index macros, and place INTEL_HWS_CSB_WRITE_INDEX() as a macro next to them, to declutter i915_drv.h. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_engine.h | 6 -- drivers/gpu/drm/i915/gt/intel_

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915: split out intel_vtd.[ch] from i915_drv.h

2022-02-09 Thread Tvrtko Ursulin
On 08/02/2022 16:54, Jani Nikula wrote: Perhaps a bit contrived, but we need to reduce the size of i915_drv.h from all the accumulated cruft. v4: Rebase v3: Rebase v2: Turns out asm/hypervisor.h is not self-contained Cc: Daniel Vetter Cc: Ville Syrjälä Cc: Tvrtko Ursulin Signed-off-by: J

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915: split out intel_vtd.[ch] from i915_drv.h

2022-02-09 Thread Jani Nikula
On Wed, 09 Feb 2022, Tvrtko Ursulin wrote: > On 08/02/2022 16:54, Jani Nikula wrote: >> Perhaps a bit contrived, but we need to reduce the size of i915_drv.h >> from all the accumulated cruft. >> >> v4: Rebase >> >> v3: Rebase >> >> v2: Turns out asm/hypervisor.h is not self-contained >> >> Cc

Re: [Intel-gfx] [PATCH] drm/i915: move intel_hws_csb_write_index() out of i915_drv.h

2022-02-09 Thread Jani Nikula
On Wed, 09 Feb 2022, Tvrtko Ursulin wrote: > On 08/02/2022 17:16, Jani Nikula wrote: >> Underscore prefix the index macros, and place >> INTEL_HWS_CSB_WRITE_INDEX() as a macro next to them, to declutter >> i915_drv.h. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/gt/intel_eng

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/atomic: Don't pollute crtc_state->mode_blob with error pointers

2022-02-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/atomic: Don't pollute crtc_state->mode_blob with error pointers URL : https://patchwork.freedesktop.org/series/99891/ State : success == Summary == CI Bug Log - changes from CI_DRM_11206 -> Patchwork_22219 ===

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915: split out intel_vtd.[ch] from i915_drv.h

2022-02-09 Thread Tvrtko Ursulin
On 09/02/2022 09:51, Jani Nikula wrote: On Wed, 09 Feb 2022, Tvrtko Ursulin wrote: On 08/02/2022 16:54, Jani Nikula wrote: Perhaps a bit contrived, but we need to reduce the size of i915_drv.h from all the accumulated cruft. v4: Rebase v3: Rebase v2: Turns out asm/hypervisor.h is not self

Re: [Intel-gfx] [PATCH] drm/i915: move intel_hws_csb_write_index() out of i915_drv.h

2022-02-09 Thread Tvrtko Ursulin
On 09/02/2022 10:00, Jani Nikula wrote: On Wed, 09 Feb 2022, Tvrtko Ursulin wrote: On 08/02/2022 17:16, Jani Nikula wrote: Underscore prefix the index macros, and place INTEL_HWS_CSB_WRITE_INDEX() as a macro next to them, to declutter i915_drv.h. Signed-off-by: Jani Nikula --- drivers/g

Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference

2022-02-09 Thread Ville Syrjälä
On Wed, Feb 09, 2022 at 02:02:05AM +, Sripada, Radhakrishna wrote: > > > > -Original Message- > > From: Łukasz Bartosik > > Sent: Tuesday, February 8, 2022 8:20 AM > > To: Jani Nikula ; Joonas Lahtinen > > ; Vivi, Rodrigo ; > > Tvrtko Ursulin > > Cc: Sripada, Radhakrishna ; intel- >

Re: [Intel-gfx] [PATCH 1/7] drm/i915: group i915_drv.h forward declarations together

2022-02-09 Thread Ville Syrjälä
On Thu, Feb 03, 2022 at 04:02:27PM +0200, Jani Nikula wrote: > Group the forward declarations in i915_drv.h together near the top, like > in other header files, and sort. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.h | 44 ++--- > 1 file chang

Re: [Intel-gfx] [PATCH 2/7] drm/i915/color: hide struct intel_color_funcs

2022-02-09 Thread Ville Syrjälä
On Thu, Feb 03, 2022 at 04:02:28PM +0200, Jani Nikula wrote: > The struct is only needed in intel_color.c, move it there. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_color.c | 19 +++ > drivers/gpu/drm/i915/i915_drv.h

Re: [Intel-gfx] [PATCH 7/7] drm/i915/pm: hide struct drm_i915_clock_gating_funcs

2022-02-09 Thread Ville Syrjälä
On Thu, Feb 03, 2022 at 04:02:33PM +0200, Jani Nikula wrote: > The struct is only needed in intel_pm.c, move it there. > > Signed-off-by: Jani Nikula I find these single vfunc structs a bit ridiculous, but since we have them might as well hide them. For the series is Reviewed-by: Ville Syrjälä

Re: [Intel-gfx] [PATCH] drm/i915: move the DRIVER_* macros to i915_driver.[ch]

2022-02-09 Thread Ville Syrjälä
On Thu, Feb 03, 2022 at 04:39:24PM +0200, Jani Nikula wrote: > The macros are more at home in i915_driver.[ch]. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/gem/i915_gem_pm.c| 1 + > drivers/gpu/drm/i915/i915_driver.c| 15 > drivers/gpu/drm/i915/i

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Add fallback inside memcpy_from_wc functions

2022-02-09 Thread Balasubramani Vivekanandan
On 08.02.2022 11:11, Lucas De Marchi wrote: > On Mon, Feb 07, 2022 at 09:43:08PM +0530, Balasubramani Vivekanandan wrote: > > memcpy_from_wc functions can fail if SSE4.1 is not supported or the > > supplied addresses are not 16-byte aligned. It was then upto to the > > caller to use memcpy as fallb

[Intel-gfx] [PATCH] drm/i915/ttm: tweak priority hint selection

2022-02-09 Thread Matthew Auld
For some reason we are selecting PRIO_HAS_PAGES when we don't have mm.pages, and vice versa. v2(Thomas): - Add missing fixes tag Fixes: 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend") Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- d

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/atomic: Don't pollute crtc_state->mode_blob with error pointers

2022-02-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/atomic: Don't pollute crtc_state->mode_blob with error pointers URL : https://patchwork.freedesktop.org/series/99891/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11206_full -> Patchwork_22219_full =

[Intel-gfx] [PATCH 1/7] drm/i915: Move vblank waits out from IPS code

2022-02-09 Thread Ville Syrjala
From: Ville Syrjälä Hoist the IPS related vblank waits one level up. Later on we'll want to consolidate all the potential pre-plane update vblank waits into one so we can't be hiding any in low level code. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 19 +

[Intel-gfx] [PATCH 5/7] drm/i915: Extract hsw_ips_get_config()

2022-02-09 Thread Ville Syrjala
From: Ville Syrjälä Pull the IPS state readout into hsw_ips.c. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/hsw_ips.c | 20 drivers/gpu/drm/i915/display/hsw_ips.h | 1 + drivers/gpu/drm/i915/display/intel_display.c | 14 +- 3 files

[Intel-gfx] [PATCH 4/7] drm/i915: Move the IPS code to its own file

2022-02-09 Thread Ville Syrjala
From: Ville Syrjälä IPS is a prety well isolated feature. Move the relevant code to a separate file from polluting intel_display.c. I stuck to the hsw_ips since that's what the function were already using, and also to avoid confusion with the ILK "Intelligen Power Sharing"/intel_ips GPU turbo st

[Intel-gfx] [PATCH 2/7] drm/i915: Change IPS calling convention

2022-02-09 Thread Ville Syrjala
From: Ville Syrjälä Follow the modern state+crtc calling convention for the IPS code as well. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 38 +++- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/display/in

[Intel-gfx] [PATCH 6/7] drm/i915: Fix IPS disable in intel_plane_disable_noatomic()

2022-02-09 Thread Ville Syrjala
From: Ville Syrjälä IPS must be disabled prior to disabling the last plane (excluding the cursor). Make the code do that instead of assuming the primary plane would be the last one. This is probably 100% theoretical as the BIOS should never light up the other planes anyway. But no harm in making

[Intel-gfx] [PATCH 3/7] drm/i915: Hoover the IPS enable/disable calls into the pre/post update hooks

2022-02-09 Thread Ville Syrjala
From: Ville Syrjälä No reason the caller of the IPS pre/post update hooks should be responsible for the actual IPS enab/disable. Just pull those calls into the pre/post update hooks themselves. And while at it let's adjust the function naming a bit to have a consistent namespace. Signed-off-by:

[Intel-gfx] [PATCH 7/7] drm/i915: Consolidate all pre plane update vblank waits

2022-02-09 Thread Ville Syrjala
From: Ville Syrjälä There are several reasons why we might have to do a vblank wait between some of the pre_plane_update() steps and the actual plane update. Currently we do a vblank wait for each of those individually. Let's consolidate things so that we just do a single vblank wait at the end o

[Intel-gfx] [PATCH] drm/i915: move the DRIVER_* macros to i915_driver.[ch]

2022-02-09 Thread Jani Nikula
The macros are more at home in i915_driver.[ch]. v2: Rebase Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gem/i915_gem_pm.c| 1 + drivers/gpu/drm/i915/i915_driver.c| 15 + drivers/gpu/drm/i915/i915_driver.h| 5 +

Re: [Intel-gfx] [PATCH] drm/i915: move the DRIVER_* macros to i915_driver.[ch]

2022-02-09 Thread Jani Nikula
On Wed, 09 Feb 2022, Ville Syrjälä wrote: > On Thu, Feb 03, 2022 at 04:39:24PM +0200, Jani Nikula wrote: >> The macros are more at home in i915_driver.[ch]. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/gem/i915_gem_pm.c| 1 + >> drivers/gpu/drm/i915/i915_driver.c

[Intel-gfx] [PATCH] drm/i915: move intel_hws_csb_write_index() out of i915_drv.h

2022-02-09 Thread Jani Nikula
Underscore prefix the index macros, and place INTEL_HWS_CSB_WRITE_INDEX() as a macro next to them, to declutter i915_drv.h. v2: Don't underscore the index macros (Tvrtko) Signed-off-by: Jani Nikula Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_engine.h | 2 ++ dri

Re: [Intel-gfx] [PATCH 7/7] drm/i915/pm: hide struct drm_i915_clock_gating_funcs

2022-02-09 Thread Jani Nikula
On Wed, 09 Feb 2022, Ville Syrjälä wrote: > On Thu, Feb 03, 2022 at 04:02:33PM +0200, Jani Nikula wrote: >> The struct is only needed in intel_pm.c, move it there. >> >> Signed-off-by: Jani Nikula > > I find these single vfunc structs a bit ridiculous, but since > we have them might as well hide

Re: [Intel-gfx] [PATCH] drm/i915: move intel_hws_csb_write_index() out of i915_drv.h

2022-02-09 Thread Jani Nikula
On Wed, 09 Feb 2022, Tvrtko Ursulin wrote: > On 09/02/2022 10:00, Jani Nikula wrote: >> On Wed, 09 Feb 2022, Tvrtko Ursulin wrote: >>> On 08/02/2022 17:16, Jani Nikula wrote: Underscore prefix the index macros, and place INTEL_HWS_CSB_WRITE_INDEX() as a macro next to them, to declutter

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Move vblank waits out from IPS code

2022-02-09 Thread Jani Nikula
On Wed, 09 Feb 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Hoist the IPS related vblank waits one level up. Later on we'll > want to consolidate all the potential pre-plane update vblank > waits into one so we can't be hiding any in low level code. > > Signed-off-by: Ville Syrjälä Revi

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Change IPS calling convention

2022-02-09 Thread Jani Nikula
On Wed, 09 Feb 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Follow the modern state+crtc calling convention for the IPS > code as well. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display.c | 38 +++- > 1 file c

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Hoover the IPS enable/disable calls into the pre/post update hooks

2022-02-09 Thread Jani Nikula
On Wed, 09 Feb 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > No reason the caller of the IPS pre/post update hooks should > be responsible for the actual IPS enab/disable. Just pull those > calls into the pre/post update hooks themselves. And while > at it let's adjust the function naming

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Move the IPS code to its own file

2022-02-09 Thread Jani Nikula
On Wed, 09 Feb 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > IPS is a prety well isolated feature. Move the relevant code *pretty > to a separate file from polluting intel_display.c. > > I stuck to the hsw_ips since that's what the function were already > using, and also to avoid confusi

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Extract hsw_ips_get_config()

2022-02-09 Thread Jani Nikula
On Wed, 09 Feb 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Pull the IPS state readout into hsw_ips.c. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/hsw_ips.c | 20 > drivers/gpu/drm/i915/display/hsw_ips.h

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Consolidate all pre plane update vblank waits

2022-02-09 Thread Jani Nikula
On Wed, 09 Feb 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > There are several reasons why we might have to do a vblank wait > between some of the pre_plane_update() steps and the actual > plane update. Currently we do a vblank wait for each of those > individually. Let's consolidate thing

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Fix IPS disable in intel_plane_disable_noatomic()

2022-02-09 Thread Jani Nikula
On Wed, 09 Feb 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > IPS must be disabled prior to disabling the last plane (excluding > the cursor). Make the code do that instead of assuming the primary > plane would be the last one. This is probably 100% theoretical > as the BIOS should never li

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Protect lockdep functions with #ifdef

2022-02-09 Thread Jani Nikula
On Tue, 08 Feb 2022, Namhyung Kim wrote: > Hello, > > On Tue, Feb 8, 2022 at 10:51 AM Jani Nikula > wrote: >> >> On Tue, 08 Feb 2022, Namhyung Kim wrote: >> > With upcoming lock tracepoints config, it'd define some of lockdep >> > functions without enabling CONFIG_LOCKDEP actually. The existin

Re: [Intel-gfx] [PATCH v1] drm/i915: fix null pointer dereference

2022-02-09 Thread Łukasz Bartosik
Have you had a chance to review the patch ? The crash is still there on v5.17-rc3. Thanks, Lukasz wt., 1 lut 2022 o 16:49 Jani Nikula napisał(a): > > > Thanks for the patch, adding some Cc's from the commit that regressed. > > BR, > Jani. > > On Tue, 01 Feb 2022, Lukasz Bartosik wrote: > > From

Re: [Intel-gfx] [PATCH 3/6] dma-buf: Warn about dma_fence_chain container rules v2

2022-02-09 Thread Thomas Hellström
On Fri, 2022-02-04 at 11:04 +0100, Christian König wrote: > Chaining of dma_fence_chain objects is only allowed through the prev > fence and not through the contained fence. > > Warn about that when we create a dma_fence_chain. > > v2: fix comment style > > Signed-off-by: Christian König > Revi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ttm: tweak priority hint selection

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915/ttm: tweak priority hint selection URL : https://patchwork.freedesktop.org/series/99897/ State : success == Summary == CI Bug Log - changes from CI_DRM_11207 -> Patchwork_0 Summary --- **SUCC

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Move vblank waits out from IPS code

2022-02-09 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Move vblank waits out from IPS code URL : https://patchwork.freedesktop.org/series/99898/ State : warning == Summary == $ dim checkpatch origin/drm-tip 07fcb18e1bb8 drm/i915: Move vblank waits out from IPS code 38cc565cd61b drm/

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/7] drm/i915: Move vblank waits out from IPS code

2022-02-09 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Move vblank waits out from IPS code URL : https://patchwork.freedesktop.org/series/99898/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separ

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Move vblank waits out from IPS code

2022-02-09 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Move vblank waits out from IPS code URL : https://patchwork.freedesktop.org/series/99898/ State : success == Summary == CI Bug Log - changes from CI_DRM_11207 -> Patchwork_1 ==

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: move the DRIVER_* macros to i915_driver.[ch] (rev3)

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915: move the DRIVER_* macros to i915_driver.[ch] (rev3) URL : https://patchwork.freedesktop.org/series/99671/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915/display/tgl+: Implement new PLL programming step

2022-02-09 Thread Imre Deak
On Tue, Feb 08, 2022 at 01:35:48PM -0800, José Roberto de Souza wrote: > A new programming step was added to combo and TC PLL sequences. > If override_AFC_startup is set in VBT, driver should overwrite > AFC_startup value to 0x7 in PLL's div0 register. > > The current understating is that only TGL

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: move the DRIVER_* macros to i915_driver.[ch] (rev3)

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915: move the DRIVER_* macros to i915_driver.[ch] (rev3) URL : https://patchwork.freedesktop.org/series/99671/ State : success == Summary == CI Bug Log - changes from CI_DRM_11207 -> Patchwork_2 Summary

Re: [Intel-gfx] [PATCH 3/6] dma-buf: Warn about dma_fence_chain container rules v2

2022-02-09 Thread Christian König
Am 09.02.22 um 15:02 schrieb Thomas Hellström: On Fri, 2022-02-04 at 11:04 +0100, Christian König wrote: Chaining of dma_fence_chain objects is only allowed through the prev fence and not through the contained fence. Warn about that when we create a dma_fence_chain. v2: fix comment style Sign

Re: [Intel-gfx] [GVT PULL] gvt-fixes for drm-intel-fixes

2022-02-09 Thread Wang, Zhi A
Hi folks: Ping. This pull seems not got merged. Thanks, Zhi. -Original Message- From: Zhi Wang Sent: Saturday, January 15, 2022 12:46 PM To: Vivi, Rodrigo ; jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com Cc: intel-gvt-...@lists.freedesktop.org; intel-gfx@lists.freedeskto

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: move intel_hws_csb_write_index() out of i915_drv.h (rev2)

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915: move intel_hws_csb_write_index() out of i915_drv.h (rev2) URL : https://patchwork.freedesktop.org/series/99853/ State : warning == Summary == $ dim checkpatch origin/drm-tip 365790a1da63 drm/i915: move intel_hws_csb_write_index() out of i915_drv.h -:50: W

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: move intel_hws_csb_write_index() out of i915_drv.h (rev2)

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915: move intel_hws_csb_write_index() out of i915_drv.h (rev2) URL : https://patchwork.freedesktop.org/series/99853/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Futher optimize plane updates (rev2)

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915: Futher optimize plane updates (rev2) URL : https://patchwork.freedesktop.org/series/99149/ State : failure == Summary == Applying: drm/i915: Clean up pre-skl primary plane registers Using index info to reconstruct a base tree... M drivers/gpu/drm/i9

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: move intel_hws_csb_write_index() out of i915_drv.h (rev2)

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915: move intel_hws_csb_write_index() out of i915_drv.h (rev2) URL : https://patchwork.freedesktop.org/series/99853/ State : success == Summary == CI Bug Log - changes from CI_DRM_11207 -> Patchwork_3 S

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/tgl+: Implement new PLL programming step (rev2)

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915/display/tgl+: Implement new PLL programming step (rev2) URL : https://patchwork.freedesktop.org/series/99867/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1dc3174e835d drm/i915/display/tgl+: Implement new PLL programming step -:51: WARNING

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display/tgl+: Implement new PLL programming step (rev2)

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915/display/tgl+: Implement new PLL programming step (rev2) URL : https://patchwork.freedesktop.org/series/99867/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Protect lockdep functions with #ifdef

2022-02-09 Thread Steven Rostedt
On Wed, 09 Feb 2022 15:49:01 +0200 Jani Nikula wrote: > > Because I want to use the lockdep annotation for other purposes. > > But the workqueue lockdep_map was defined under LOCKDEP > > only. Please see the description in the cover letter. > > > > https://lore.kernel.org/all/20220208184208.7930

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Consolidate all pre plane update vblank waits

2022-02-09 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, February 9, 2022 5:05 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 7/7] drm/i915: Consolidate all pre plane update > vblank waits > > From: Ville Syrjälä > > There are seve

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ttm: tweak priority hint selection

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915/ttm: tweak priority hint selection URL : https://patchwork.freedesktop.org/series/99897/ State : success == Summary == CI Bug Log - changes from CI_DRM_11207_full -> Patchwork_0_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/tgl+: Implement new PLL programming step (rev2)

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915/display/tgl+: Implement new PLL programming step (rev2) URL : https://patchwork.freedesktop.org/series/99867/ State : success == Summary == CI Bug Log - changes from CI_DRM_11207 -> Patchwork_5 Summ

Re: [Intel-gfx] [PATCH v6 4/6] drm/i915/: Re-work clflush_write32

2022-02-09 Thread kernel test robot
Hi Michael, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm/drm-next v5.17-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we sugges

[Intel-gfx] [PATCH] drm/i915/: fix noderef.cocci warnings

2022-02-09 Thread kernel test robot
From: kernel test robot drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1310:32-38: ERROR: application of sizeof to pointer drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1322:32-38: ERROR: application of sizeof to pointer sizeof when applied to a pointer typed expression gives the size of th

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/7] drm/i915: Move vblank waits out from IPS code

2022-02-09 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Move vblank waits out from IPS code URL : https://patchwork.freedesktop.org/series/99898/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11207_full -> Patchwork_1_full

Re: [Intel-gfx] [RFC 00/12] locking: Separate lock tracepoints from lockdep/lock_stat (v1)

2022-02-09 Thread Waiman Long
On 2/9/22 04:09, Peter Zijlstra wrote: On Tue, Feb 08, 2022 at 10:41:56AM -0800, Namhyung Kim wrote: Eventually I'm mostly interested in the contended locks only and I want to reduce the overhead in the fast path. By moving that, it'd be easy to track contended locks with timing by using two t

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: move the DRIVER_* macros to i915_driver.[ch] (rev3)

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915: move the DRIVER_* macros to i915_driver.[ch] (rev3) URL : https://patchwork.freedesktop.org/series/99671/ State : success == Summary == CI Bug Log - changes from CI_DRM_11207_full -> Patchwork_2_full ===

Re: [Intel-gfx] [RFC 00/12] locking: Separate lock tracepoints from lockdep/lock_stat (v1)

2022-02-09 Thread Waiman Long
On 2/9/22 13:29, Mathieu Desnoyers wrote: - On Feb 9, 2022, at 1:19 PM, Waiman Long long...@redhat.com wrote: On 2/9/22 04:09, Peter Zijlstra wrote: On Tue, Feb 08, 2022 at 10:41:56AM -0800, Namhyung Kim wrote: Eventually I'm mostly interested in the contended locks only and I want to re

Re: [Intel-gfx] [PATCH v3 0/4] GuC HWCONFIG with documentation

2022-02-09 Thread Bloomfield, Jon
Acked-by: Jon Bloomfield > -Original Message- > From: Intel-gfx On Behalf Of > Jordan Justen > Sent: Tuesday, February 8, 2022 1:05 PM > To: intel-gfx > Cc: dri-devel > Subject: [Intel-gfx] [PATCH v3 0/4] GuC HWCONFIG with documentation > > This is John/Rodrigo's 2 patches with some m

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: move intel_hws_csb_write_index() out of i915_drv.h (rev2)

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915: move intel_hws_csb_write_index() out of i915_drv.h (rev2) URL : https://patchwork.freedesktop.org/series/99853/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11207_full -> Patchwork_3_full =

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/7] drm/i915: Move vblank waits out from IPS code

2022-02-09 Thread Ville Syrjälä
On Wed, Feb 09, 2022 at 05:36:17PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [1/7] drm/i915: Move vblank waits out from IPS > code > URL : https://patchwork.freedesktop.org/series/99898/ > State : failure > > == Summary == > > CI Bug Log - changes from CI

Re: [Intel-gfx] [RFC 00/12] locking: Separate lock tracepoints from lockdep/lock_stat (v1)

2022-02-09 Thread Namhyung Kim
Hello, On Wed, Feb 9, 2022 at 11:02 AM Waiman Long wrote: > > On 2/9/22 13:29, Mathieu Desnoyers wrote: > > - On Feb 9, 2022, at 1:19 PM, Waiman Long long...@redhat.com wrote: > > > >> On 2/9/22 04:09, Peter Zijlstra wrote: > >>> On Tue, Feb 08, 2022 at 10:41:56AM -0800, Namhyung Kim wrote: >

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Protect lockdep functions with #ifdef

2022-02-09 Thread Namhyung Kim
Hello, On Wed, Feb 9, 2022 at 8:27 AM Steven Rostedt wrote: > > On Wed, 09 Feb 2022 15:49:01 +0200 > Jani Nikula wrote: > > > > Because I want to use the lockdep annotation for other purposes. > > > But the workqueue lockdep_map was defined under LOCKDEP > > > only. Please see the description i

Re: [Intel-gfx] [RFC 00/12] locking: Separate lock tracepoints from lockdep/lock_stat (v1)

2022-02-09 Thread Waiman Long
On 2/9/22 14:17, Mathieu Desnoyers wrote: - On Feb 9, 2022, at 2:02 PM, Waiman Long long...@redhat.com wrote: On 2/9/22 13:29, Mathieu Desnoyers wrote: - On Feb 9, 2022, at 1:19 PM, Waiman Long long...@redhat.com wrote: On 2/9/22 04:09, Peter Zijlstra wrote: On Tue, Feb 08, 2022 at

Re: [Intel-gfx] [RFC 00/12] locking: Separate lock tracepoints from lockdep/lock_stat (v1)

2022-02-09 Thread Namhyung Kim
On Wed, Feb 9, 2022 at 11:28 AM Mathieu Desnoyers wrote: > > - On Feb 9, 2022, at 2:22 PM, Namhyung Kim namhy...@kernel.org wrote: > > I'm also concerning dynamic allocated locks in a data structure. > > If we keep the info in a hash table, we should delete it when the > > lock is gone. I'm n

Re: [Intel-gfx] [PATCH v6 2/3] i915/gvt: Save the initial HW state snapshot in i915

2022-02-09 Thread Wang, Zhi A
On 2/9/22 7:32 AM, Christoph Hellwig wrote: > On Tue, Feb 08, 2022 at 06:11:50AM -0500, Zhi Wang wrote: >> +struct drm_i915_private *dev_priv = iter->i915; >> +u32 *mmio, i; >> + >> +for (i = offset; i < offset + size; i += 4) { >> +mmio = iter->data + i; >> +*mm

[Intel-gfx] [PATCH] drm/i915: Check stolen memory size before calling drm_mm_init

2022-02-09 Thread José Roberto de Souza
From: Steve Carbonari Add check for zero usable stolen memory before calling drm_mm_init to support configurations where stolen memory exists but is fully reserved. Also skip memory test in such case. Cc: Ville Syrjälä Cc: Daniele Ceraolo Spurio Signed-off-by: José Roberto de Souza Signed-of

Re: [Intel-gfx] [PATCH v6 1/3] i915/gvt: Introduce the mmio table to support VFIO new mdev API

2022-02-09 Thread Wang, Zhi A
On 2/9/22 7:28 AM, Christoph Hellwig wrote: > On Tue, Feb 08, 2022 at 05:15:00PM +0200, Jani Nikula wrote: >>> #ifdef CONFIG_DRM_I915_GVT >>> + >>> +#define D_BDW (1 << 0) >>> +#define D_SKL (1 << 1) >>> +#define D_KBL (1 << 2) >>> +#define D_BXT (1 << 3) >>> +#define D_CFL (

Re: [Intel-gfx] [PATCH 07/10] drm/i915: Convert for_each_intel_crtc_mask() to take a pipe mask instead

2022-02-09 Thread Navare, Manasi
On Thu, Feb 03, 2022 at 08:38:20PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Often using pipes is more convenient than crtc indices. > Convert the current for_each_intel_crtc_mask() to take a > pipe mask instead of a crtc index mask, and rename it to > for_each_intel_crtc_in_pipe_mask

Re: [Intel-gfx] [PATCH v6 1/3] i915/gvt: Introduce the mmio table to support VFIO new mdev API

2022-02-09 Thread Wang, Zhi A
On 2/9/22 9:04 AM, Jani Nikula wrote: > On Wed, 09 Feb 2022, Christoph Hellwig wrote: >> On Tue, Feb 08, 2022 at 05:15:00PM +0200, Jani Nikula wrote: #ifdef CONFIG_DRM_I915_GVT + +#define D_BDW (1 << 0) +#define D_SKL (1 << 1) +#define D_KBL (1 << 2) +#defi

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Use for_each_intel_crtc_in_pipe_mask() more

2022-02-09 Thread Navare, Manasi
On Thu, Feb 03, 2022 at 08:38:21PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Convert a few hand roller for_each_intel_crtc_in_pipe_mask() > to the real thing. > > Signed-off-by: Ville Syrjälä Reviewed-by: Manasi Navare Manasi > --- > drivers/gpu/drm/i915/display/intel_display.c

Re: [Intel-gfx] [PATCH 09/10] drm/i915: Return both master and slave pipes from enabled_bigjoiner_pipes()

2022-02-09 Thread Navare, Manasi
On Thu, Feb 03, 2022 at 08:38:22PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Return both the master and slave pipe bitmasks from > enabled_bigjoiner_pipes(). We'll have use for both during > readout soon. > > Signed-off-by: Ville Syrjälä This looks good, can this be just combined w

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display/tgl+: Implement new PLL programming step (rev2)

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915/display/tgl+: Implement new PLL programming step (rev2) URL : https://patchwork.freedesktop.org/series/99867/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11207_full -> Patchwork_5_full

Re: [Intel-gfx] [PATCH 09/10] drm/i915: Return both master and slave pipes from enabled_bigjoiner_pipes()

2022-02-09 Thread Ville Syrjälä
On Wed, Feb 09, 2022 at 12:00:26PM -0800, Navare, Manasi wrote: > On Thu, Feb 03, 2022 at 08:38:22PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Return both the master and slave pipe bitmasks from > > enabled_bigjoiner_pipes(). We'll have use for both during > > readout soon. > >

Re: [Intel-gfx] [RFC 00/12] locking: Separate lock tracepoints from lockdep/lock_stat (v1)

2022-02-09 Thread Waiman Long
On 2/9/22 14:45, Namhyung Kim wrote: On Wed, Feb 9, 2022 at 11:28 AM Mathieu Desnoyers wrote: - On Feb 9, 2022, at 2:22 PM, Namhyung Kim namhy...@kernel.org wrote: I'm also concerning dynamic allocated locks in a data structure. If we keep the info in a hash table, we should delete it wh

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915: Check stolen memory size before calling drm_mm_init

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915: Check stolen memory size before calling drm_mm_init URL : https://patchwork.freedesktop.org/series/99917/ State : warning == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh CHK include/generated/compile.h CC [

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Check stolen memory size before calling drm_mm_init

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915: Check stolen memory size before calling drm_mm_init URL : https://patchwork.freedesktop.org/series/99917/ State : success == Summary == CI Bug Log - changes from CI_DRM_11207 -> Patchwork_6 Summary

[Intel-gfx] [PATCH v2] drm/i915: Check stolen memory size before calling drm_mm_init

2022-02-09 Thread José Roberto de Souza
From: Steve Carbonari Add check for zero usable stolen memory before calling drm_mm_init to support configurations where stolen memory exists but is fully reserved. Also skip memory test in such case. v2: - convert stolen_usable_size to u64 so build do not break depending on PHYS_ADDR_T_64BIT c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Check stolen memory size before calling drm_mm_init (rev2)

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915: Check stolen memory size before calling drm_mm_init (rev2) URL : https://patchwork.freedesktop.org/series/99917/ State : success == Summary == CI Bug Log - changes from CI_DRM_11207 -> Patchwork_7

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Check stolen memory size before calling drm_mm_init

2022-02-09 Thread Patchwork
== Series Details == Series: drm/i915: Check stolen memory size before calling drm_mm_init URL : https://patchwork.freedesktop.org/series/99917/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11207_full -> Patchwork_6_full ===

[Intel-gfx] [PATCH v4 0/4] GuC HWCONFIG with documentation

2022-02-09 Thread Jordan Justen
This is John/Rodrigo's 2 patches with some minor changes, and I added 2 patches. "drm/i915/uapi: Add query for hwconfig blob" was changed: * Rename DRM_I915_QUERY_HWCONFIG_TABLE to DRM_I915_QUERY_HWCONFIG_BLOB as requested by Joonas. * Reword commit message * I added Acked-by to this patc

[Intel-gfx] [PATCH v4 2/4] drm/i915/uapi: Add query for hwconfig blob

2022-02-09 Thread Jordan Justen
From: Rodrigo Vivi The DRM_I915_QUERY_HWCONFIG_BLOB query item returns a blob of data which it receives from the GuC software. This blob provides some useful data about the hardware for drivers. Although the blob is not fully documented at this time, the basic format is an array of u32 values. T

[Intel-gfx] [PATCH v4 3/4] drm/i915/uapi: Add struct drm_i915_query_hwconfig_blob_item

2022-02-09 Thread Jordan Justen
Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct. v3: * Add various changes suggested by Tvrtko Cc: Daniel Vetter Signed-off-by: Jordan Justen Acked-by: Jon Bloomfield --- include/uapi/drm/i915_drm.h | 35 +++ 1 file changed, 35 insertions(+) diff

[Intel-gfx] [PATCH v4 4/4] drm/i915/guc: Verify hwconfig blob matches supported format

2022-02-09 Thread Jordan Justen
i915_drm.h now defines the format of the returned DRM_I915_QUERY_HWCONFIG_BLOB query item. Since i915 receives this from the black box GuC software, it should verify that the data matches that format before sending it to user-space. The verification makes a single simple pass through the blob cont

[Intel-gfx] [PATCH v4 1/4] drm/i915/guc: Add fetch of hwconfig table

2022-02-09 Thread Jordan Justen
From: John Harrison Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer. Note that the table is only available on ADL-P and later platforms. Cc: Mich

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GuC HWCONFIG with documentation (rev4)

2022-02-09 Thread Patchwork
== Series Details == Series: GuC HWCONFIG with documentation (rev4) URL : https://patchwork.freedesktop.org/series/99787/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2a4b80691a34 drm/i915/guc: Add fetch of hwconfig table -:79: WARNING:FILE_PATH_CHANGES: added, moved or delete

  1   2   >