[Intel-gfx] [PATCH v5 0/5] Add driver for GSC controller

2022-02-06 Thread Alexander Usyskin
GSC is a graphics system controller, it provides a chassis controller for graphics discrete cards. There are two MEI interfaces in GSC: HECI1 and HECI2. This series includes instantiation of the auxiliary devices for HECI2 and mei-gsc auxiliary device driver that binds to the auxiliary device. I

[Intel-gfx] [PATCH v5 1/5] drm/i915/gsc: add gsc as a mei auxiliary device

2022-02-06 Thread Alexander Usyskin
From: Tomas Winkler GSC is a graphics system controller, it provides a chassis controller for graphics discrete cards. There are two MEI interfaces in GSC: HECI1 and HECI2. Both interfaces are on the BAR0 at offsets 0x00258000 and 0x00259000. GSC is a GT Engine (class 4: instance 6). HECI1 inte

[Intel-gfx] [PATCH v5 2/5] mei: add support for graphics system controller (gsc) devices

2022-02-06 Thread Alexander Usyskin
From: Tomas Winkler GSC is a graphics system controller, based on CSE, it provides a chassis controller for graphics discrete cards, as well as it supports media protection on selected devices. mei_gsc binds to a auxiliary devices exposed by Intel discrete driver i915. Signed-off-by: Alexander

[Intel-gfx] [PATCH v5 3/5] mei: gsc: setup char driver alive in spite of firmware handshake failure

2022-02-06 Thread Alexander Usyskin
Setup char device in spite of firmware handshake failure. In order to provide host access to the firmware status registers and other information required for the manufacturing process. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- V5: Rebase --- drivers/misc/mei/gsc-me.c | 1

[Intel-gfx] [PATCH v5 4/5] mei: gsc: add runtime pm handlers

2022-02-06 Thread Alexander Usyskin
From: Tomas Winkler Implement runtime handlers for mei-gsc, to track idle state of the device properly. CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- V4: drop debug prints V5: Rebase --- drivers/misc/mei/gsc-me.c | 67 +

[Intel-gfx] [PATCH v5 5/5] mei: gsc: retrieve the firmware version

2022-02-06 Thread Alexander Usyskin
Add a hook to retrieve the firmware version of the GSC devices to bus-fixup. GSC has a different MKHI clients GUIDs but the same message structure to retrieve the firmware version as MEI so mei_fwver() can be reused. CC: Ashutosh Dixit Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkle

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add driver for GSC controller (rev5)

2022-02-06 Thread Patchwork
== Series Details == Series: Add driver for GSC controller (rev5) URL : https://patchwork.freedesktop.org/series/98066/ State : warning == Summary == $ dim checkpatch origin/drm-tip e61d88f542ff drm/i915/gsc: add gsc as a mei auxiliary device -:62: WARNING:FILE_PATH_CHANGES: added, moved or de

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add driver for GSC controller (rev5)

2022-02-06 Thread Patchwork
== Series Details == Series: Add driver for GSC controller (rev5) URL : https://patchwork.freedesktop.org/series/98066/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for Add driver for GSC controller (rev5)

2022-02-06 Thread Patchwork
== Series Details == Series: Add driver for GSC controller (rev5) URL : https://patchwork.freedesktop.org/series/98066/ State : success == Summary == CI Bug Log - changes from CI_DRM_11190 -> Patchwork_22185 Summary --- **SUCCESS**

[Intel-gfx] [PATCH 0/4] DGFX OpRegion

2022-02-06 Thread Anshuman Gupta
This series setup DGFX OpRegion. Anshuman Gupta (4): drm/i915/opregion: Abstract opregion function drm/i915/opregion: Register opreg func only for disp parts drm/i915/dgfx: OPROM OpRegion Setup drm/i915/dgfx: Get VBT from rvda drivers/gpu/drm/i915/display/intel_opregion.c | 533 +

[Intel-gfx] [PATCH 1/4] drm/i915/opregion: Abstract opregion function

2022-02-06 Thread Anshuman Gupta
Abstract opregion operations like get opregion base, get rvda and opregion cleanup in form of i915_opregion_ops. This will be required to converge igfx and dgfx opregion. This keeps intel_opregion_setup() as static function, and adds a new function intel_opregion_init(). Cc: Jani Nikula Cc: Rodri

[Intel-gfx] [PATCH 2/4] drm/i915/opregion: Register opreg func only for disp parts

2022-02-06 Thread Anshuman Gupta
It need to register opregion_func only for graphics sku which has display. Use HAS_DISPLAY() to register opregion_func. Cc: Badal Nilawar Cc: Jani Nikula Cc: Uma Shankar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_opregion.c | 7 +-- 1 file changed, 5 insertions(+

[Intel-gfx] [PATCH 3/4] drm/i915/dgfx: OPROM OpRegion Setup

2022-02-06 Thread Anshuman Gupta
On igfx cards ACPI OpRegion retrieve through ASLS. System BIOS writes ASLS address to pci config space(0xFC) but on discrete cards OpRegion is part of PCI Option ROM(OPROM) along with other firmware images, i915 is interested only in Code Signature System(CSS) and OpRegion + VBT image. DGFX Cards

[Intel-gfx] [PATCH 4/4] drm/i915/dgfx: Get VBT from rvda

2022-02-06 Thread Anshuman Gupta
Since OpRegion ver 2.1 MBOX3 RVDA field is Relative address of Raw VBT data from OpRegion Base. Populate the opreion->rvda accordingly. As Intel DGFX cards supports OpRegion version 2.2 or greater, RVDA as an absolute VBT physical address (Ver 2.0) doesn't applicable to DGFX cards. Cc: Jani Nikula

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DGFX OpRegion

2022-02-06 Thread Patchwork
== Series Details == Series: DGFX OpRegion URL : https://patchwork.freedesktop.org/series/99738/ State : warning == Summary == $ dim checkpatch origin/drm-tip f2cee5f27f9b drm/i915/opregion: Abstract opregion function 7b611238fd8b drm/i915/opregion: Register opreg func only for disp parts 00e2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DGFX OpRegion

2022-02-06 Thread Patchwork
== Series Details == Series: DGFX OpRegion URL : https://patchwork.freedesktop.org/series/99738/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add driver for GSC controller (rev5)

2022-02-06 Thread Patchwork
== Series Details == Series: Add driver for GSC controller (rev5) URL : https://patchwork.freedesktop.org/series/98066/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11190_full -> Patchwork_22185_full Summary --- **F

[Intel-gfx] ✓ Fi.CI.BAT: success for DGFX OpRegion

2022-02-06 Thread Patchwork
== Series Details == Series: DGFX OpRegion URL : https://patchwork.freedesktop.org/series/99738/ State : success == Summary == CI Bug Log - changes from CI_DRM_11190 -> Patchwork_22186 Summary --- **SUCCESS** No regressions found.

[Intel-gfx] ✗ Fi.CI.IGT: failure for DGFX OpRegion

2022-02-06 Thread Patchwork
== Series Details == Series: DGFX OpRegion URL : https://patchwork.freedesktop.org/series/99738/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11190_full -> Patchwork_22186_full Summary --- **FAILURE** Serious unk

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

2022-02-06 Thread Abhinav Kumar
Hi Laurent On 2/6/2022 3:32 PM, Dmitry Baryshkov wrote: On Wed, 2 Feb 2022 at 16:26, Laurent Pinchart wrote: Hi Jani, On Wed, Feb 02, 2022 at 03:15:03PM +0200, Jani Nikula wrote: On Wed, 02 Feb 2022, Laurent Pinchart wrote: On Wed, Feb 02, 2022 at 02:24:28PM +0530, Kandpal Suraj wrote: Ch

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Allow !join_mbus cases for adlp+ dbuf configuration

2022-02-06 Thread Lisovskiy, Stanislav
On Fri, Feb 04, 2022 at 04:18:16PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Reintroduce the !join_mbus single pipe cases for adlp+. > > Due to the mbus relative dbuf offsets in PLANE_BUF_CFG we > need to know the actual slices used by the pipe when doing > readout, even when mbus jo

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Populate pipe dbuf slices more accurately during readout

2022-02-06 Thread Lisovskiy, Stanislav
On Fri, Feb 04, 2022 at 04:18:17PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > During readout we cannot assume the planes are actually using the > slices they are supposed to use. The BIOS may have misprogrammed > things and put the planes onto the wrong dbuf slices. So let's > do the r

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Workaround broken BIOS DBUF configuration on TGL/RKL

2022-02-06 Thread Lisovskiy, Stanislav
On Fri, Feb 04, 2022 at 04:18:18PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > On TGL/RKL the BIOS likes to use some kind of bogus DBUF layout > that doesn't match what the spec recommends. With a single active > pipe that is not going to be a problem, but with multiple pipes > active s

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Change bigjoiner state tracking to use the pipe bitmask

2022-02-06 Thread Ville Syrjälä
On Fri, Feb 04, 2022 at 03:58:29PM -0800, Navare, Manasi wrote: > On Thu, Feb 03, 2022 at 08:38:23PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Get rid of the inflexible bigjoiner_linked_crtc pointer thing > > and just track things as a bitmask of pipes instead. We can > > also n

Re: [Intel-gfx] [PATCH 06/10] drm/i915: Introduce intel_crtc_is_bigjoiner_{slave, master}()

2022-02-06 Thread Ville Syrjälä
On Fri, Feb 04, 2022 at 01:27:54PM -0800, Navare, Manasi wrote: > On Thu, Feb 03, 2022 at 08:38:19PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Introduce helpers to query whether the crtc is the slave/master > > for bigjoiner. This decouples most places from the exact > > state l

Re: [Intel-gfx] [PATCH v2 04/10] drm/i915: Clean up the bigjoiner state copy logic

2022-02-06 Thread Ville Syrjälä
On Fri, Feb 04, 2022 at 12:52:01PM -0800, Navare, Manasi wrote: > On Fri, Feb 04, 2022 at 09:20:49AM +0200, Ville Syrjala wrote: > > static int > > -copy_bigjoiner_crtc_state(struct intel_crtc_state *crtc_state, > > - const struct intel_crtc_state *from_crtc_state) > > +copy_b