Re: [Intel-gfx] [PATCH 01/15] drm/i915: Drop pointless dev_priv argument

2022-01-27 Thread Lisovskiy, Stanislav
On Tue, Jan 18, 2022 at 11:23:40AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > skl_ddb_entry_init_from_hw() has no need for dev_priv. > > Signed-off-by: Ville Syrjälä Reviewed-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915/intel_pm.c | 11 +-- > 1 file changed, 5 ins

Re: [Intel-gfx] [PATCH 02/15] drm/i915: Extract skl_ddb_entry_init()

2022-01-27 Thread Lisovskiy, Stanislav
On Tue, Jan 18, 2022 at 11:23:41AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Extract a small helper to populate a ddb entry. > > Signed-off-by: Ville Syrjälä Reviewed-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915/intel_pm.c | 44 +++-- > 1 file

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: Am 26.01.22 um 21:36 schrieb Lucas De Marchi: When dma_buf_map struct is passed around, it's useful to be able to init

Re: [Intel-gfx] [RFC PATCH] drm/i915: Remove all frontbuffer tracking calls from the gem code

2022-01-27 Thread Maarten Lankhorst
Op 26-01-2022 om 14:09 schreef Jouni Högander: > We should now rely on userspace doing dirtyfb. There is no > need to have separate frontbuffer tracking hooks in gem code. > > This patch is removing all frontbuffer tracking calls from the gem > code. > > Cc: Ville Syrjälä > Cc: Jani Nikula > Cc:

Re: [Intel-gfx] [PATCH 03/15] drm/i915: Fix plane relative_data_rate calculation

2022-01-27 Thread Lisovskiy, Stanislav
On Tue, Jan 18, 2022 at 11:23:42AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > We are currently computing the relative data rates as > src_size * scale_factor where scale_factor is src_size / dst_size. > Thus relative data rate is src_size * src_size / dst_size, > which is just utter no

Re: [Intel-gfx] [PATCH 04/15] drm/i915: Introduce skl_plane_ddb_iter

2022-01-27 Thread Lisovskiy, Stanislav
On Tue, Jan 18, 2022 at 11:23:43AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Collect a bit of the stuff used during the plane ddb > allocation into a struct we can pass around. > > Signed-off-by: Ville Syrjälä Reviewed-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915/intel_p

Re: [Intel-gfx] [PATCH 05/15] drm/i915: Extract skl_allocate_plane_ddb()

2022-01-27 Thread Lisovskiy, Stanislav
On Tue, Jan 18, 2022 at 11:23:44AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace some copy-pasta with a function. > > Signed-off-by: Ville Syrjälä Reviewed-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915/intel_pm.c | 41 +++-- > 1 file change

Re: [Intel-gfx] [PATCH 06/15] drm/i915: Extract skl_crtc_calc_dbuf_bw()

2022-01-27 Thread Lisovskiy, Stanislav
On Tue, Jan 18, 2022 at 11:23:45AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Extract the dbuf slice data_rate calculation into a small > helper. Should make it a bit easier to handle the different > color planes of planar formats correctly. > > Signed-off-by: Ville Syrjälä Reviewed

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/pmu: Fix KMD and GuC race on accessing busyness

2022-01-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pmu: Fix KMD and GuC race on accessing busyness URL : https://patchwork.freedesktop.org/series/99388/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11148_full -> Patchwork_22119_full

[Intel-gfx] [PATCH] drm/i915/selftests: fix some error codes in __cancel_reset()

2022-01-27 Thread Dan Carpenter
There were two error paths in __cancel_reset() which return success instead of a negative error code as expected. Fixes: 4e6835466771 ("drm/i915/selftests: Add a cancel request selftest that triggers a reset") Signed-off-by: Dan Carpenter --- >From static analysis. I am not 100% sure this. Ple

Re: [Intel-gfx] [PATCH 03/15] drm/i915: Fix plane relative_data_rate calculation

2022-01-27 Thread Ville Syrjälä
On Thu, Jan 27, 2022 at 10:21:06AM +0200, Lisovskiy, Stanislav wrote: > On Tue, Jan 18, 2022 at 11:23:42AM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > We are currently computing the relative data rates as > > src_size * scale_factor where scale_factor is src_size / dst_size. > > T

Re: [Intel-gfx] [PATCH v2 2/5] mei: add support for graphics system controller (gsc) devices

2022-01-27 Thread Usyskin, Alexander
> -Original Message- > From: Greg Kroah-Hartman > Sent: Wednesday, January 26, 2022 20:06 > To: Usyskin, Alexander > Cc: Jani Nikula ; Joonas Lahtinen > ; Vivi, Rodrigo ; > David Airlie ; Daniel Vetter ; Winkler, > Tomas ; Lubart, Vitaly ; > intel-gfx@lists.freedesktop.org; linux-ker..

[Intel-gfx] [PATCH] drm/i915: delete shadow "ret" variable

2022-01-27 Thread Dan Carpenter
This "ret" declaration shadows an existing "ret" variable at the top of the function. Delete it. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/i915/i915_vma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c index 0026e85a

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Christian König
Am 27.01.22 um 09:18 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: Am 26.01.22 um 21:36 schrieb Lucas De Marchi: [SNIP] humn... not sure i

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: > Am 27.01.22 um 08:57 schrieb Lucas De Marchi: > > On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: > > > Am 26.01.22 um 21:36 schrieb Lucas De Marchi: > > > > When dma_buf_map struct is passed around, it's useful to

Re: [Intel-gfx] [PATCH 01/19] dma-buf-map: Add read/write helpers

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 08:59:36AM +0100, Christian König wrote: > Am 27.01.22 um 08:36 schrieb Matthew Brost: > > [SNIP] > > > >/** > > > > * dma_buf_map_memcpy_to - Memcpy into dma-buf mapping > > > > * @dst: The dma-buf mapping structure > > > > @@ -263,4 +304,44 @@ static inline

[Intel-gfx] [PULL] drm-misc-fixes

2022-01-27 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-fixes. Besides the bug fixes, it contains a backmerge from drm/drm-fixes to get the tree to v5.17-rc1. Best regards Thomas drm-misc-fixes-2022-01-27: * drm/ast: Revert 1600x800 with 108MHz PCLK * drm/atomic: fix CRTC handling during modese

Re: [Intel-gfx] [PATCH v2 2/5] mei: add support for graphics system controller (gsc) devices

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, "Usyskin, Alexander" wrote: >> -Original Message- >> From: Greg Kroah-Hartman >> Sent: Wednesday, January 26, 2022 20:06 >> To: Usyskin, Alexander >> Cc: Jani Nikula ; Joonas Lahtinen >> ; Vivi, Rodrigo ; >> David Airlie ; Daniel Vetter ; Winkler, >> Tomas ; Lubart,

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 09:55:05AM +0100, Christian König wrote: Am 27.01.22 um 09:18 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: Am 26.

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Christian König
Am 27.01.22 um 10:12 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 09:55:05AM +0100, Christian König wrote: Am 27.01.22 um 09:18 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 0

Re: [Intel-gfx] [PATCH v5 02/10] drm/i915/guc: Add XE_LP registers for GuC error state capture.

2022-01-27 Thread Jani Nikula
On Wed, 26 Jan 2022, "Teres Alexis, Alan Previn" wrote: > Thanks Jani for taking the time to review... > > 1. apologies on the const issue, this is my bad, i think it was > one of the comments from earlier rev not sure how i missed it. > Will fix this on next rev. > > 2. I do have a question bel

[Intel-gfx] [PATCH 00/14] drm/i915: M/N cleanup

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä Start cleaning up the M/N stuff. Couple of eventual goals: - fix/enhance DRRS (it's currently in kind of poor state) - move towards eliminating any RMW stuff from the atomic commit so that we can start playing around with using DSB for it, and the DRRS PIPECONF RMWs are a

[Intel-gfx] [PATCH 01/14] drm/i915: Extract intel_{get,set}_m_n()

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä Make the M/N setup/readout a bit less repitive by extracting a few small helpers. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 109 --- 1 file changed, 47 insertions(+), 62 deletions(-) diff --git a/drivers/gpu/drm/i915/di

[Intel-gfx] [PATCH 03/14] drm/i915: s/gmch_{m,n}/data_{m,n}/

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä Rename the gmch_* M/N members to data_* to match the register definitions and thus make life a little less confusing. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 4 +- drivers/gpu/drm/i915/display/intel_display.c | 48 ++-

[Intel-gfx] [PATCH 02/14] drm/i915: Clean up M/N register defines

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä Use REG_GENMASK() & co. for the M/N register values. There are also a lot of weird unused defines (eg. *_OFFSET) we can just throw out. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 10 - drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 04/14] drm/i915: Move drrs hardware bit frobbing to small helpers

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä Split the drrs code that actually changes the refresh rate (via PIPECONF or M/N values) to small helper functions that only deal with the hardware details an nothing else. We'll soon have a third way of doing this, and it's less confusing when each difference method lives in i

[Intel-gfx] [PATCH 06/14] drm/i915: Move PCH transcoder M/N setup into the PCH code

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä Do the PCH transcoder M/N setup next to where all the other PCH transcoder stuff is programmed. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/g4x_dp.c | 1 + drivers/gpu/drm/i915/display/intel_display.c | 92 --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH 05/14] drm/i915: Make M/N set/get a bit more direct

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä Throw out the middle-men (dp_{get/set}_m_n()) and just call the cpu/pch transcoder functions directly. Let's us nuke this enum link_m_n_set stuff. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/g4x_dp.c | 19 +- drivers/gpu/drm/i915/display/intel_ddi

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: > On Thu, Jan 27, 2022 at 08:27:11AM +0100, Christian König wrote: > > Am 26.01.22 um 21:36 schrieb Lucas De Marchi: > > >

[Intel-gfx] [PATCH 07/14] drm/i915: Move M/N setup to a more logical place on ddi platforms

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä Let's do the cpu transcoder M/N setup next to where we program most other cpu transcoder timings/etc. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 10 +- drivers/gpu/drm/i915/display/intel_display.c | 14 ++ drivers/gpu

Re: [Intel-gfx] [PATCH 1/3] drm: add writeback pointers to drm_connector

2022-01-27 Thread Kandpal, Suraj
> > + laurent on this > > Hi Suraj > Jani pointed me to this thread as i had posted something similar here : > https://patchwork.freedesktop.org/patch/470296/ but since this thread was > posted earlier, we can discuss further here. > > Overall, its similar to what I had posted in the RFC and you

[Intel-gfx] [PATCH 09/14] drm/i915: Add fdi_m2_n2

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä We're going to need M2/N2 for FDI when doing refresh rate switching with PCH ports. We'll start by setting to match the FDI M1/N1. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 19 +-- drivers/gpu/drm/i915/display/intel_dis

[Intel-gfx] [PATCH 10/14] drm/i915: Program FDI RX TUSIZE2

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä When using the refresh rate swithching with FDI we must program RXTUSIZE2 in addition to RXTUSIZE1. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fdi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c

[Intel-gfx] [PATCH 08/14] drm/i915: Extract {i9xx, ilk}_configure_cpu_transcoder()

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä Follow the path laid out by hsw+ and extract helpers to configure the cpu transcoder for earlier platforms as well. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 65 +++- 1 file changed, 35 insertions(+), 30 deletions(-) di

[Intel-gfx] [PATCH 11/14] drm/i915: Dump dp_m2_n2 always

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä No point in special casing the dp_m2_n2 dumping. Just do it always. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/d

[Intel-gfx] [PATCH 13/14] drm/i915: Set DP M2/N2 equal to M1/N1 when not doing DRRS

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä Make life simpler by always programming DP M2/N2. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_drrs.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_drrs.c b/drivers/gpu/drm/i915/display/in

[Intel-gfx] [PATCH 14/14] drm/i915: Always check dp_m2_n2 on pre-bdw

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä No point in special casing the check of dp_m2_n2 on pre-bdw platforms. Either the transcoder has M2/N2 in which case the values should be set to something sensible, or it doesn't in which case dp_m2_n2 is always zeroed. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 12/14] drm/i915: Extract can_enable_drrs()

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä Pull the "can we do DRRS?" check into helper in order to reduce the clutter in intel_drrs_compute_config(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_drrs.c | 31 ++- 1 file changed, 19 insertions(+), 12 deletions(-) diff --git

Re: [Intel-gfx] [PATCH v5 1/5] drm/i915: add needs_compact_pt flag

2022-01-27 Thread Intel
On 1/26/22 18:11, Robert Beckett wrote: On 26/01/2022 13:49, Thomas Hellström (Intel) wrote: On 1/25/22 20:35, Robert Beckett wrote: From: Ramalingam C Add a new platform flag, needs_compact_pt, to mark the requirement of compact pt layout support for the ppGTT when using 64K GTT pages.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/adlp: Fix TypeC PHY-ready status readout

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915/adlp: Fix TypeC PHY-ready status readout URL : https://patchwork.freedesktop.org/series/99359/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11145_full -> Patchwork_22111_full Summary -

Re: [Intel-gfx] mmotm 2022-01-26-21-04 uploaded (gpu/drm/i915/i915_gem_evict.h)

2022-01-27 Thread Jani Nikula
On Wed, 26 Jan 2022, Randy Dunlap wrote: > On 1/26/22 21:04, a...@linux-foundation.org wrote: >> The mm-of-the-moment snapshot 2022-01-26-21-04 has been uploaded to >> >>https://www.ozlabs.org/~akpm/mmotm/ >> >> mmotm-readme.txt says >> >> README for mm-of-the-moment: >> >> https://www.ozl

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: fix some error codes in __cancel_reset()

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix some error codes in __cancel_reset() URL : https://patchwork.freedesktop.org/series/99407/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11149 -> Patchwork_22120 Summary

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: > On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: > > On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: > > > Am 27.01.22 um 08:57 schrieb Lucas De Marchi: > > > > On Thu, Jan 27, 2022 at 08:27:11AM +0100

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Christian König
Am 27.01.22 um 11:00 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.01.22 um 08:57 schrieb Lucas De Marchi: On Thu, Ja

[Intel-gfx] [PATCH] drm/i915/adl-n: Add PCH Support for Alder Lake N

2022-01-27 Thread Tejas Upadhyay
Add the PCH ID for ADL-N. Signed-off-by: Tejas Upadhyay --- drivers/gpu/drm/i915/intel_pch.c | 1 + drivers/gpu/drm/i915/intel_pch.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c index da8f82c2342f..4f7a61d5502e 100644 -

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: M/N cleanup

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915: M/N cleanup URL : https://patchwork.freedesktop.org/series/99409/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/i9

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: delete shadow "ret" variable

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915: delete shadow "ret" variable URL : https://patchwork.freedesktop.org/series/99408/ State : success == Summary == CI Bug Log - changes from CI_DRM_11149 -> Patchwork_22121 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/adl-n: Add PCH Support for Alder Lake N

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915/adl-n: Add PCH Support for Alder Lake N URL : https://patchwork.freedesktop.org/series/99413/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 01/14] drm/i915: Extract intel_{get, set}_m_n()

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Make the M/N setup/readout a bit less repitive by extracting > a few small helpers. > > Signed-off-by: Ville Syrjälä Nice! Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display.c | 109

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 11:21:20AM +0100, Christian König wrote: > Am 27.01.22 um 11:00 schrieb Daniel Vetter: > > On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: > > > On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: > > > > On Thu, Jan 27, 2022 at 09:02:54AM +0100,

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Clean up M/N register defines

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Use REG_GENMASK() & co. for the M/N register values. There are > also a lot of weird unused defines (eg. *_OFFSET) we can just > throw out. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_display.c |

Re: [Intel-gfx] [PATCH 03/14] drm/i915: s/gmch_{m,n}/data_{m,n}/

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Rename the gmch_* M/N members to data_* to match the register > definitions and thus make life a little less confusing. Yes, please! Reviewed-by: Jani Nikula > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/di

[Intel-gfx] [PATCH v4 0/5] Add driver for GSC controller

2022-01-27 Thread Alexander Usyskin
GSC is a graphics system controller, it provides a chassis controller for graphics discrete cards. There are two MEI interfaces in GSC: HECI1 and HECI2. This series includes instantiation of the auxiliary devices for HECI2 and mei-gsc auxiliary device driver that binds to the auxiliary device. I

[Intel-gfx] [PATCH v4 1/5] drm/i915/gsc: add gsc as a mei auxiliary device

2022-01-27 Thread Alexander Usyskin
From: Tomas Winkler GSC is a graphics system controller, it provides a chassis controller for graphics discrete cards. There are two MEI interfaces in GSC: HECI1 and HECI2. Both interfaces are on the BAR0 at offsets 0x00258000 and 0x00259000. GSC is a GT Engine (class 4: instance 6). HECI1 inte

[Intel-gfx] [PATCH v4 2/5] mei: add support for graphics system controller (gsc) devices

2022-01-27 Thread Alexander Usyskin
From: Tomas Winkler GSC is a graphics system controller, based on CSE, it provides a chassis controller for graphics discrete cards, as well as it supports media protection on selected devices. mei_gsc binds to a auxiliary devices exposed by Intel discrete driver i915. Signed-off-by: Alexander

[Intel-gfx] [PATCH v4 3/5] mei: gsc: setup char driver alive in spite of firmware handshake failure

2022-01-27 Thread Alexander Usyskin
Setup char device in spite of firmware handshake failure. In order to provide host access to the firmware status registers and other information required for the manufacturing process. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/gsc-me.c | 11 ++-

[Intel-gfx] [PATCH v4 4/5] mei: gsc: add runtime pm handlers

2022-01-27 Thread Alexander Usyskin
From: Tomas Winkler Implement runtime handlers for mei-gsc, to track idle state of the device properly. CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- V4: drop debug prints --- drivers/misc/mei/gsc-me.c | 67 ++- 1 file

[Intel-gfx] [PATCH v4 5/5] mei: gsc: retrieve the firmware version

2022-01-27 Thread Alexander Usyskin
Add a hook to retrieve the firmware version of the GSC devices to bus-fixup. GSC has a different MKHI clients GUIDs but the same message structure to retrieve the firmware version as MEI so mei_fwver() can be reused. CC: Ashutosh Dixit Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkle

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Move drrs hardware bit frobbing to small helpers

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Split the drrs code that actually changes the refresh rate > (via PIPECONF or M/N values) to small helper functions that > only deal with the hardware details an nothing else. We'll > soon have a third way of doing this, and it's

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Move drrs hardware bit frobbing to small helpers

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, Jani Nikula wrote: > On Thu, 27 Jan 2022, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> Split the drrs code that actually changes the refresh rate >> (via PIPECONF or M/N values) to small helper functions that >> only deal with the hardware details an nothing else. We'll

Re: [Intel-gfx] [PATCH v4 0/5] Add driver for GSC controller

2022-01-27 Thread Greg Kroah-Hartman
On Thu, Jan 27, 2022 at 01:20:58PM +0200, Alexander Usyskin wrote: > GSC is a graphics system controller, it provides > a chassis controller for graphics discrete cards. > > There are two MEI interfaces in GSC: HECI1 and HECI2. > > This series includes instantiation of the auxiliary devices for H

Re: [Intel-gfx] [PATCH v4 0/5] Add driver for GSC controller

2022-01-27 Thread Greg Kroah-Hartman
On Thu, Jan 27, 2022 at 12:31:07PM +0100, Greg Kroah-Hartman wrote: > On Thu, Jan 27, 2022 at 01:20:58PM +0200, Alexander Usyskin wrote: > > GSC is a graphics system controller, it provides > > a chassis controller for graphics discrete cards. > > > > There are two MEI interfaces in GSC: HECI1 and

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Clean up M/N register defines

2022-01-27 Thread Ville Syrjälä
On Thu, Jan 27, 2022 at 01:17:21PM +0200, Jani Nikula wrote: > On Thu, 27 Jan 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Use REG_GENMASK() & co. for the M/N register values. There are > > also a lot of weird unused defines (eg. *_OFFSET) we can just > > throw out. > > > > Signed-o

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Move drrs hardware bit frobbing to small helpers

2022-01-27 Thread Ville Syrjälä
On Thu, Jan 27, 2022 at 01:24:05PM +0200, Jani Nikula wrote: > On Thu, 27 Jan 2022, Jani Nikula wrote: > > On Thu, 27 Jan 2022, Ville Syrjala wrote: > >> From: Ville Syrjälä > >> > >> Split the drrs code that actually changes the refresh rate > >> (via PIPECONF or M/N values) to small helper fun

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Add driver for GSC controller (rev4)

2022-01-27 Thread Patchwork
== Series Details == Series: Add driver for GSC controller (rev4) URL : https://patchwork.freedesktop.org/series/98066/ State : failure == Summary == Applying: drm/i915/gsc: add gsc as a mei auxiliary device Using index info to reconstruct a base tree... M MAINTAINERS M drivers/gpu

Re: [Intel-gfx] [PATCH 02/14] drm/i915: Clean up M/N register defines

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, Ville Syrjälä wrote: > On Thu, Jan 27, 2022 at 01:17:21PM +0200, Jani Nikula wrote: >> On Thu, 27 Jan 2022, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > Use REG_GENMASK() & co. for the M/N register values. There are >> > also a lot of weird unused defines (eg. *_O

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Move drrs hardware bit frobbing to small helpers

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, Ville Syrjälä wrote: > On Thu, Jan 27, 2022 at 01:24:05PM +0200, Jani Nikula wrote: >> On Thu, 27 Jan 2022, Jani Nikula wrote: >> > On Thu, 27 Jan 2022, Ville Syrjala wrote: >> >> From: Ville Syrjälä >> >> >> >> Split the drrs code that actually changes the refresh rate >>

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/adl-n: Add PCH Support for Alder Lake N

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915/adl-n: Add PCH Support for Alder Lake N URL : https://patchwork.freedesktop.org/series/99413/ State : success == Summary == CI Bug Log - changes from CI_DRM_11149 -> Patchwork_22123 Summary --- *

[Intel-gfx] [PATCH] drm/i915: Fix a race between vma / object destruction and unbinding

2022-01-27 Thread Thomas Hellström
The vma destruction code was using an unlocked advisory check for drm_mm_node_allocated() to avoid racing with eviction code unbinding the vma. This is very fragile and prohibits the dereference of non-refcounted pointers of dying vmas after a call to __i915_vma_unbind(). It also prohibits the der

Re: [Intel-gfx] [Linaro-mm-sig] Re: [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 12:44:21PM +0100, Christian König wrote: > Am 27.01.22 um 12:16 schrieb Daniel Vetter: > > On Thu, Jan 27, 2022 at 11:21:20AM +0100, Christian König wrote: > > > Am 27.01.22 um 11:00 schrieb Daniel Vetter: > > > > On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wro

Re: [Intel-gfx] [PATCH] drm/i915: Fix a race between vma / object destruction and unbinding

2022-01-27 Thread Maarten Lankhorst
Op 27-01-2022 om 12:56 schreef Thomas Hellström: > The vma destruction code was using an unlocked advisory check for > drm_mm_node_allocated() to avoid racing with eviction code unbinding > the vma. > > This is very fragile and prohibits the dereference of non-refcounted > pointers of dying vmas af

[Intel-gfx] [PULL] drm-misc-next

2022-01-27 Thread Maarten Lankhorst
Hi Dave & Daniel, First pull for v5.18 drm-misc-next-2022-01-27: drm-misc-next for v5.18: UAPI Changes: - Fix invalid IN_FORMATS blob when plane->format_mod_supported is NULL. Cross-subsystem Changes: - Assorted dt bindings updates. - Fix vga16fb vga checking on x86. - Fix extra semicolon in rw

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915/pmu: Fix KMD and GuC race on accessing busyness

2022-01-27 Thread Jani Nikula
On Thu, 27 Jan 2022, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] drm/i915/pmu: Fix KMD and GuC race on > accessing busyness > URL : https://patchwork.freedesktop.org/series/99386/ > State : failure > > == Summary == > > CALLscripts/checksyscalls.sh > CAL

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Maarten Lankhorst
Op 26-01-2022 om 13:55 schreef Gwan-gyeong Mun: > > > On 1/26/22 9:37 AM, Maarten Lankhorst wrote: >> set_cache_level may unbind the object, which will result in the below >> lockdep splat: >> <6> [184.578145] [IGT] kms_addfb_basic: starting subtest >> addfb25-framebuffer-vs-set-tiling >> <4> [184

[Intel-gfx] [PATCH v2 02/14] drm/i915: Clean up M/N register defines

2022-01-27 Thread Ville Syrjala
From: Ville Syrjälä Use REG_GENMASK() & co. for the M/N register values. There are also a lot of weird unused defines (eg. *_OFFSET) we can just throw out. Also let's mask out the unused bits during readout for good measure. Previously we only masked out the TU_SIZE from one of the registers, wh

[Intel-gfx] [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread Zhi Wang
From: Zhi Wang To support the new mdev interfaces and the re-factor patches from Christoph, which moves the GVT-g code into a dedicated module, the GVT-g initialization path has to be separated into two phases: a) Early initialization. The early initialization of GVT requires to be done when lo

[Intel-gfx] [PATCH 2/3] i915/gvt: save the initial HW state snapshot in i915.

2022-01-27 Thread Zhi Wang
Save the inital HW state snapshot in i915 so that the rest code of GVT-g can be moved into a dedicated module while it can still get a clean initial HW state saved at the correct time during the initialization of i915. The futhrer vGPU created by GVT-g will use this HW state as the initial HW state

[Intel-gfx] [PATCH 3/3] i915/gvt: Use the initial HW state snapshot saved in i915

2022-01-27 Thread Zhi Wang
The code of saving initial HW state snapshot has been moved into i915. Let the GVT-g core logic use that snapshot. Cc: Christoph Hellwig Cc: Jason Gunthorpe Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Vivi Rodrigo Cc: Zhenyu Wang Cc: Zhi Wang Signed-off-by: Zhi Wang --- drivers/gpu/drm/i915/g

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Thomas Hellström
On Thu, 2022-01-27 at 13:02 +0100, Maarten Lankhorst wrote: > Op 26-01-2022 om 13:55 schreef Gwan-gyeong Mun: > > > > > > On 1/26/22 9:37 AM, Maarten Lankhorst wrote: > > > set_cache_level may unbind the object, which will result in the > > > below > > > lockdep splat: > > > <6> [184.578145] [IGT

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Thomas Hellström
On 1/27/22 13:05, Thomas Hellström wrote: The bug on vm_close is a separate bug, and would probably best be fixed in a separate patch. Could I get a r-b on this? It should fix some issues, even if the unbind there is a separate bug. ~Maarten Recognizing that it doesn't fix the vm_close is

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Maarten Lankhorst
Op 27-01-2022 om 13:09 schreef Thomas Hellström: > > On 1/27/22 13:05, Thomas Hellström wrote: >> >>> The bug on vm_close is a separate bug, and would probably best be >>> fixed in a separate patch. >>> >>> Could I get a r-b on this? It should fix some issues, even if the >>> unbind there is a sepa

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-27 Thread Thomas Hellström
On 1/27/22 13:38, Maarten Lankhorst wrote: Op 27-01-2022 om 13:09 schreef Thomas Hellström: On 1/27/22 13:05, Thomas Hellström wrote: The bug on vm_close is a separate bug, and would probably best be fixed in a separate patch. Could I get a r-b on this? It should fix some issues, even if the

Re: [Intel-gfx] [Linaro-mm-sig] Re: [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Christian König
Am 27.01.22 um 12:16 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 11:21:20AM +0100, Christian König wrote: Am 27.01.22 um 11:00 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: On Thu, Jan

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix a race between vma / object destruction and unbinding

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915: Fix a race between vma / object destruction and unbinding URL : https://patchwork.freedesktop.org/series/99418/ State : success == Summary == CI Bug Log - changes from CI_DRM_11150 -> Patchwork_22125 S

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: delete shadow "ret" variable

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915: delete shadow "ret" variable URL : https://patchwork.freedesktop.org/series/99408/ State : success == Summary == CI Bug Log - changes from CI_DRM_11149_full -> Patchwork_22121_full Summary --- *

Re: [Intel-gfx] [PATCH 01/19] dma-buf-map: Add read/write helpers

2022-01-27 Thread Thomas Zimmermann
Hi Am 26.01.22 um 21:36 schrieb Lucas De Marchi: In certain situations it's useful to be able to read or write to an offset that is calculated by having the memory layout given by a struct declaration. Usually we are going to read/write a u8, u16, u32 or u64. Add a pair of macros dma_buf_map_re

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Thomas Zimmermann
Am 26.01.22 um 21:36 schrieb Lucas De Marchi: When dma_buf_map struct is passed around, it's useful to be able to initialize a second map that takes care of reading/writing to an offset of the original map. Add a helper that copies the struct and add the offset to the proper address. Cc: Sumi

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: M/N cleanup (rev2)

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915: M/N cleanup (rev2) URL : https://patchwork.freedesktop.org/series/99409/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [RFC PATCH] drm/i915: Remove all frontbuffer tracking calls from the gem code

2022-01-27 Thread Rodrigo Vivi
On Thu, Jan 27, 2022 at 09:20:14AM +0100, Maarten Lankhorst wrote: > Op 26-01-2022 om 14:09 schreef Jouni Högander: > > We should now rely on userspace doing dirtyfb. There is no > > need to have separate frontbuffer tracking hooks in gem code. > > > > This patch is removing all frontbuffer trackin

Re: [Intel-gfx] [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread Christoph Hellwig
What tree is this series against? It doesn't seem to apply to Linus' current tree or 5.17-rc1.

Re: [Intel-gfx] [PATCH 02/19] dma-buf-map: Add helper to initialize second map

2022-01-27 Thread Thomas Zimmermann
Hi Am 27.01.22 um 11:21 schrieb Christian König: Am 27.01.22 um 11:00 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 01:33:32AM -0800, Lucas De Marchi wrote: On Thu, Jan 27, 2022 at 09:57:25AM +0100, Daniel Vetter wrote: On Thu, Jan 27, 2022 at 09:02:54AM +0100, Christian König wrote: Am 27.

Re: [Intel-gfx] [PATCH 09/19] dma-buf-map: Add wrapper over memset

2022-01-27 Thread Thomas Zimmermann
Hi Am 26.01.22 um 21:36 schrieb Lucas De Marchi: Just like memcpy_toio(), there is also need to write a direct value to a memory block. Add dma_buf_map_memset() to abstract memset() vs memset_io() Cc: Matt Roper Cc: Sumit Semwal Cc: Christian König Cc: linux-me...@vger.kernel.org Cc: dri-de.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: M/N cleanup (rev2)

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915: M/N cleanup (rev2) URL : https://patchwork.freedesktop.org/series/99409/ State : success == Summary == CI Bug Log - changes from CI_DRM_11151 -> Patchwork_22126 Summary --- **SUCCESS** No reg

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread Patchwork
== Series Details == Series: series starting with [1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API URL : https://patchwork.freedesktop.org/series/99420/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1d24765d58ce i915/gvt: Introduce the mmio_table.c to su

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread Patchwork
== Series Details == Series: series starting with [1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API URL : https://patchwork.freedesktop.org/series/99420/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit w

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/adl-n: Add PCH Support for Alder Lake N

2022-01-27 Thread Patchwork
== Series Details == Series: drm/i915/adl-n: Add PCH Support for Alder Lake N URL : https://patchwork.freedesktop.org/series/99413/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11149_full -> Patchwork_22123_full Summary --

Re: [Intel-gfx] [RFC PATCH] drm/i915: Remove all frontbuffer tracking calls from the gem code

2022-01-27 Thread Ville Syrjälä
On Thu, Jan 27, 2022 at 09:20:14AM +0100, Maarten Lankhorst wrote: > Op 26-01-2022 om 14:09 schreef Jouni Högander: > > We should now rely on userspace doing dirtyfb. There is no > > need to have separate frontbuffer tracking hooks in gem code. > > > > This patch is removing all frontbuffer trackin

Re: [Intel-gfx] [PATCH 09/19] dma-buf-map: Add wrapper over memset

2022-01-27 Thread Lucas De Marchi
On Thu, Jan 27, 2022 at 03:54:21PM +0100, Thomas Zimmermann wrote: Hi Am 26.01.22 um 21:36 schrieb Lucas De Marchi: Just like memcpy_toio(), there is also need to write a direct value to a memory block. Add dma_buf_map_memset() to abstract memset() vs memset_io() Cc: Matt Roper Cc: Sumit Semw

Re: [Intel-gfx] [PATCH 09/19] dma-buf-map: Add wrapper over memset

2022-01-27 Thread Thomas Zimmermann
Am 27.01.22 um 16:38 schrieb Lucas De Marchi: On Thu, Jan 27, 2022 at 03:54:21PM +0100, Thomas Zimmermann wrote: Hi Am 26.01.22 um 21:36 schrieb Lucas De Marchi: Just like memcpy_toio(), there is also need to write a direct value to a memory block. Add dma_buf_map_memset() to abstract memset

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API

2022-01-27 Thread Patchwork
== Series Details == Series: series starting with [1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API URL : https://patchwork.freedesktop.org/series/99420/ State : success == Summary == CI Bug Log - changes from CI_DRM_11151 -> Patchwork_22127 =

  1   2   >