[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2)

2022-01-17 Thread Patchwork
== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2) URL : https://patchwork.freedesktop.org/series/98895/ State : warning == Summary == $ dim checkpatch origin/drm-tip a6f5bc26c327 drm/i915: Call i915_gem_evict_vm in vm_fault_gtt to p

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2)

2022-01-17 Thread Patchwork
== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2) URL : https://patchwork.freedesktop.org/series/98895/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be che

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2)

2022-01-17 Thread Patchwork
== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2) URL : https://patchwork.freedesktop.org/series/98895/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/i915_gem_evict.c:144: warning:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2)

2022-01-17 Thread Patchwork
== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2) URL : https://patchwork.freedesktop.org/series/98895/ State : success == Summary == CI Bug Log - changes from CI_DRM_11088 -> Patchwork_22006

Re: [Intel-gfx] [PATCH] drm/i915/psr: remove unused lines_to_wait vbt info

2022-01-17 Thread Jani Nikula
On Wed, 12 Jan 2022, "Souza, Jose" wrote: > On Wed, 2022-01-12 at 13:27 +0200, Jani Nikula wrote: >> The lines_to_wait info from VBT is never used. Remove. >> > > Reviewed-by: José Roberto de Souza Thanks, pushed. BR, Jani. > >> Cc: José Roberto de Souza >> Cc: Jouni Högander >> Cc: Ville

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove short term pins from execbuf by requiring lock to unbind.

2022-01-17 Thread Patchwork
== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. URL : https://patchwork.freedesktop.org/series/98895/ State : success == Summary == CI Bug Log - changes from CI_DRM_11086_full -> Patchwork_22003_full =

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/pxp: Hold RPM wakelock during PXP unbind

2022-01-17 Thread Jani Nikula
On Thu, 13 Jan 2022, Rodrigo Vivi wrote: > On Thu, Jan 06, 2022 at 12:02:36PM -0800, Juston Li wrote: >> Similar to commit b8d8436840ca ("drm/i915/gt: Hold RPM wakelock during >> PXP suspend") but to fix the same warning for unbind during shutdown: >> >> [ cut here ] >> RP

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/wopcm: Handle pre-programmed WOPCM registers

2022-01-17 Thread Patchwork
== Series Details == Series: drm/i915/wopcm: Handle pre-programmed WOPCM registers URL : https://patchwork.freedesktop.org/series/98910/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11088_full -> Patchwork_22004_full Summa

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dg2: add Wa_14015023722

2022-01-17 Thread Patchwork
== Series Details == Series: drm/i915/dg2: add Wa_14015023722 URL : https://patchwork.freedesktop.org/series/98911/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11088_full -> Patchwork_22005_full Summary --- **FAILU

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2)

2022-01-17 Thread Patchwork
== Series Details == Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind. (rev2) URL : https://patchwork.freedesktop.org/series/98895/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11088_full -> Patchwork_22006_full ==

Re: [Intel-gfx] [PATCH] drm/i915: Add locking to i915_gem_evict_vm(), v3.

2022-01-17 Thread Thomas Hellström
On 1/17/22 08:56, Maarten Lankhorst wrote: i915_gem_evict_vm will need to be able to evict objects that are locked by the current ctx. By testing if the current context already locked the object, we can do this correctly. This allows us to evict the entire vm even if we already hold some object

[Intel-gfx] [PATCH v3 0/2] Introduce multitile support

2022-01-17 Thread Andi Shyti
Hi, This is the second series that prepares i915 to host multitile platforms. It introduces the for_each_gt() macro that loops over the tiles to perform per gt actions. This patch is a combination of two patches developed originally by Abdiel, who introduced some refactoring during probe, and the

[Intel-gfx] [PATCH v3 1/2] drm/i915: Prepare for multiple GTs

2022-01-17 Thread Andi Shyti
From: Tvrtko Ursulin On a multi-tile platform, each tile has its own registers + GGTT space, and BAR 0 is extended to cover all of them. Up to four gts are supported in i915->gt[], with slot zero shadowing the existing i915->gt0 to enable source compatibility with legacy driver paths. A for_each

[Intel-gfx] [PATCH v3 2/2] drm/i915/gt: make a gt sysfs group and move power management files

2022-01-17 Thread Andi Shyti
The GT has its own properties and in sysfs they should be grouped in the 'gt/' directory. Create a 'gt/' directory in sysfs which will contain gt0...gtN directories related to each tile configured in the GPU. Move the power management files inside those directories. The previous power management

[Intel-gfx] [PATCH] drm/i915/buddy: fixup potential uaf

2022-01-17 Thread Matthew Auld
If we are unlucky and can't allocate enough memory when splitting blocks, where we temporarily end up with the given block and its buddy on the respective free list, then we need to ensure we delete both blocks, and no just the buddy, before potentially freeing them. Fixes: 14d1b9a6247c ("drm/i915

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce multitile support

2022-01-17 Thread Patchwork
== Series Details == Series: Introduce multitile support URL : https://patchwork.freedesktop.org/series/98950/ State : warning == Summary == $ dim checkpatch origin/drm-tip 28afa8633a19 drm/i915: Prepare for multiple GTs -:255: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id__' - possible sid

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Introduce multitile support

2022-01-17 Thread Patchwork
== Series Details == Series: Introduce multitile support URL : https://patchwork.freedesktop.org/series/98950/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/gt: make a gt sysfs group and move power management files

2022-01-17 Thread Tvrtko Ursulin
On 17/01/2022 15:09, Andi Shyti wrote: The GT has its own properties and in sysfs they should be grouped in the 'gt/' directory. Create a 'gt/' directory in sysfs which will contain gt0...gtN directories related to each tile configured in the GPU. Move the power management files inside those d

[Intel-gfx] ✗ Fi.CI.BAT: failure for Introduce multitile support

2022-01-17 Thread Patchwork
== Series Details == Series: Introduce multitile support URL : https://patchwork.freedesktop.org/series/98950/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11091 -> Patchwork_22007 Summary --- **FAILURE** Serious

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/gt: make a gt sysfs group and move power management files

2022-01-17 Thread Andi Shyti
Hi Tvrtko, > > The previous power management files are kept in their original > > root directory to avoid breaking the ABI. They point to the tile > > '0' and a warning message is printed whenever accessed to. The > > deprecated interface needs for the CONFIG_SYSFS_DEPRECATED_V2 > > flag in order

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/buddy: fixup potential uaf

2022-01-17 Thread Patchwork
== Series Details == Series: drm/i915/buddy: fixup potential uaf URL : https://patchwork.freedesktop.org/series/98953/ State : success == Summary == CI Bug Log - changes from CI_DRM_11092 -> Patchwork_22008 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.IGT: failure for Introduce multitile support

2022-01-17 Thread Patchwork
== Series Details == Series: Introduce multitile support URL : https://patchwork.freedesktop.org/series/98950/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11091_full -> Patchwork_22007_full Summary --- **FAILURE**

[Intel-gfx] [PATCH v4 0/2] Introduce multitile support

2022-01-17 Thread Andi Shyti
Hi, This is the second series that prepares i915 to host multitile platforms. It introduces the for_each_gt() macro that loops over the tiles to perform per gt actions. This patch is a combination of two patches developed originally by Abdiel, who introduced some refactoring during probe, and the

[Intel-gfx] [PATCH v4 1/2] drm/i915: Prepare for multiple GTs

2022-01-17 Thread Andi Shyti
From: Tvrtko Ursulin On a multi-tile platform, each tile has its own registers + GGTT space, and BAR 0 is extended to cover all of them. Up to four gts are supported in i915->gt[], with slot zero shadowing the existing i915->gt0 to enable source compatibility with legacy driver paths. A for_each

[Intel-gfx] [PATCH v4 2/2] drm/i915/gt: make a gt sysfs group and move power management files

2022-01-17 Thread Andi Shyti
The GT has its own properties and in sysfs they should be grouped in the 'gt/' directory. Create a 'gt/' directory in sysfs which will contain gt0...gtN directories related to each tile configured in the GPU. Move the power management files inside those directories. The previous power management

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/buddy: fixup potential uaf

2022-01-17 Thread Patchwork
== Series Details == Series: drm/i915/buddy: fixup potential uaf URL : https://patchwork.freedesktop.org/series/98953/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11092_full -> Patchwork_22008_full Summary --- **FA

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce multitile support

2022-01-17 Thread Patchwork
== Series Details == Series: Introduce multitile support URL : https://patchwork.freedesktop.org/series/98958/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3a9bf34c3413 drm/i915: Prepare for multiple GTs -:255: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id__' - possible sid

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Introduce multitile support

2022-01-17 Thread Patchwork
== Series Details == Series: Introduce multitile support URL : https://patchwork.freedesktop.org/series/98958/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for Introduce multitile support

2022-01-17 Thread Patchwork
== Series Details == Series: Introduce multitile support URL : https://patchwork.freedesktop.org/series/98958/ State : success == Summary == CI Bug Log - changes from CI_DRM_11092 -> Patchwork_22009 Summary --- **SUCCESS** No regr

Re: [Intel-gfx] [PATCH v7 4/6] drm/i915: Use vma resources for async unbinding

2022-01-17 Thread Robert Beckett
On 10/01/2022 17:22, Thomas Hellström wrote: Implement async (non-blocking) unbinding by not syncing the vma before calling unbind on the vma_resource. Add the resulting unbind fence to the object's dma_resv from where it is picked up by the ttm migration code. Ideally these unbind fences shou

[Intel-gfx] ✗ Fi.CI.IGT: failure for Introduce multitile support

2022-01-17 Thread Patchwork
== Series Details == Series: Introduce multitile support URL : https://patchwork.freedesktop.org/series/98958/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11092_full -> Patchwork_22009_full Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915: Prepare for multiple GTs

2022-01-17 Thread Michal Wajdeczko
Hi Andi, please find few late nits below On 17.01.2022 20:32, Andi Shyti wrote: > From: Tvrtko Ursulin > > On a multi-tile platform, each tile has its own registers + GGTT > space, and BAR 0 is extended to cover all of them. > > Up to four gts are supported in i915->gt[], with slot zero s/gts

Re: [Intel-gfx] [PATCH v11 01/19] dyndbg: add _DPRINTK_FLAGS_ENABLED

2022-01-17 Thread jim . cromie
On Fri, Jan 14, 2022 at 4:57 AM Vincent Whitchurch wrote: > > On Fri, Jan 07, 2022 at 06:29:24AM +0100, Jim Cromie wrote: > > #ifdef CONFIG_JUMP_LABEL > > - if (dp->flags & _DPRINTK_FLAGS_PRINT) { > > - if (!(modifiers->flags & > > _DPRINTK_FLAGS_P

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/gt: make a gt sysfs group and move power management files

2022-01-17 Thread Michal Wajdeczko
Hi Andi, few more late nits below On 17.01.2022 20:32, Andi Shyti wrote: > The GT has its own properties and in sysfs they should be grouped > in the 'gt/' directory. > > Create a 'gt/' directory in sysfs which will contain gt0...gtN > directories related to each tile configured in the GPU. Move

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915: Prepare for multiple GTs

2022-01-17 Thread Andi Shyti
Hi Michal, > please find few late nits below thanks for the comments! > > On a multi-tile platform, each tile has its own registers + GGTT > > space, and BAR 0 is extended to cover all of them. > > > > Up to four gts are supported in i915->gt[], with slot zero > > s/gts/GTs (to match as below)

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/gt: make a gt sysfs group and move power management files

2022-01-17 Thread Andi Shyti
Hi Michal, > > /sys/.../card0 > > ├── gt > > │   ├── gt0 > > │   │   ├── id > > │   │   ├── rc6_enable > > │   │   ├── rc6_residency_ms > > │   │   ├── rps_act_freq_mhz > > │   │   ├── rps_boost_freq_mhz > > │   │   ├── rps_cu

Re: [Intel-gfx] [PATCH 07/14] drm/i915: Clean up pre-skl primary plane registers

2022-01-17 Thread Ville Syrjälä
On Wed, Jan 12, 2022 at 08:12:31PM +, Souza, Jose wrote: > On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote: > > @@ -427,9 +427,9 @@ static void i9xx_plane_update_noarm(struct intel_plane > > *plane, > > * program whatever is there. > > */ > > intel_

Re: [Intel-gfx] [PATCH 09/14] drm/i915: Clean up vlv/chv sprite plane registers

2022-01-17 Thread Ville Syrjälä
On Fri, Jan 14, 2022 at 04:34:14PM +, Souza, Jose wrote: > On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote: > > @@ -7238,28 +7257,36 @@ enum { > > #define SPCSCYGOFF(plane_id) _MMIO_CHV_SPCSC(plane_id, 0x6d900) > > #define SPCSCCBOFF(plane_id) _MMIO_CHV_SPCSC(plane_id, 0x6d

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Do not return '0' if there is nothing to return

2022-01-17 Thread Andi Shyti
Ping... Lucas, do you mind merging this trivial refactoring? Thanks, Andi On Sat, Nov 27, 2021 at 03:17:15AM +0200, Andi Shyti wrote: > Change functions that always return '0' to be void type. > > Signed-off-by: Andi Shyti > Cc: Maciej Patelczyk > --- > drivers/gpu/drm/i915/gt/intel_gt_debugf