On 14/12/2021 18:07, Matthew Auld wrote:
Ditch the writeback hook and drop i915_gem_object_writeback(). We
already support the shrinker_release_pages hook which can just call
shmem_writeback directly.
Looks like a good cleanup to me.
Reviewed-by: Tvrtko Ursulin
A couple of bike shedding co
> From: Ville Syrjälä
>
> On Tue, Dec 14, 2021 at 06:25:43PM +0200, Ville Syrjälä wrote:
> > On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote:
> > > On Mon, 13 Dec 2021, Ville Syrjala wrote:
> > >
> > > This one is only used in gvt, anyway. And that actually makes me wonder
> > > if t
On Mon, 13 Dec 2021, Thomas Zimmermann wrote:
> Hi
>
> Am 13.12.21 um 14:34 schrieb Jani Nikula:
>> On Mon, 13 Dec 2021, Thomas Zimmermann wrote:
>>> Split-off DisplayPort functions from KMS helper library and move them
>>> into their own module. Reduces the size of drm_kms_helper.ko by ~50%.
>>>
This patch series introduces infrastructure for asynchronous vma
unbinding. The single enabled use-case is initially at buffer object
migration where we otherwise sync when unbinding vmas before migration.
This in theory allows us to pipeline any number of migrations, but in
practice the number is
Since the gt migration code was using only a single fence for
dependencies, these were collected in a dma_fence_array. However, it
turns out that it's illegal to use some dma_fences in a dma_fence_array,
in particular other dma_fence_arrays and dma_fence_chains, and this
causes trouble for us movin
Since it's starting to be used outside the i915 TTM move code, move it
to a separate set of files.
Signed-off-by: Thomas Hellström
---
drivers/gpu/drm/i915/Makefile| 1 +
drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 181 +-
drivers/gpu/drm/i915/gem/i915_gem_ttm_mo
Protect updates of struct i915_vma flags and async binding / unbinding
with the vm::mutex. This means that i915_vma_bind() needs to assert
vm::mutex held. In order to make that possible drop the caching of
kmap_atomic() maps around i915_vma_bind().
An alternative would be to use kmap_local() but s
Introduce vma resources, sort of similar to TTM resources, needed for
asynchronous bind management. Initially we will use them to hold
completion of unbinding when we capture data from a vma, but they will
be used extensively in upcoming patches for asynchronous vma unbinding.
Signed-off-by: Thom
When introducing asynchronous unbinding, the vma itself may no longer
be alive when the actual binding or unbinding takes place.
Update the gtt i915_vma_ops accordingly to take a struct i915_vma_resource
instead of a struct i915_vma for the bind_vma() and unbind_vma() ops.
Similarly change the ins
Implement async (non-blocking) unbinding by not syncing the vma before
calling unbind on the vma_resource.
Add the resulting unbind fence to the object's dma_resv from where it is
picked up by the ttm migration code.
Ideally these unbind fences should be coalesced with the migration blit
fence to a
There is always a struct vma_resource guaranteed to be alive when we
access a corresponding struct vma_snapshot.
So ditch the latter and instead of allocating vma_snapshots, reference
the already existning vma_resource.
This requires a couple of extra members in struct vma_resource but that's
a s
== Series Details ==
Series: drm/i915: Increment composite fence seqno
URL : https://patchwork.freedesktop.org/series/98034/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11003_full -> Patchwork_21850_full
Summary
---
Hi Dave and Daniel,
First, a heads up that I will be on vacation for the next weeks
so Jani will cover the drm-intel-fixes for the next rounds.
Now, here goes drm-intel-fixes-2021-12-15:
Fix a bound check in the DMC fw load.
Thanks,
Rodrigo.
The following changes since commit 2585cf9dfaaddf00b
Split-off DisplayPort functions from KMS helper library and move them
into their own module. Reduces the size of drm_kms_helper.ko by ~50%.
This patchset is part of an on-going effort to reduce the minimum
binary size of the DRM core and helpers. It's helpful for systems with
early-boot DRM graphi
Move all public DisplayPort headers into dp and update users. No
functional changes.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 4 ++--
drivers/gpu/drm/amd/amdgpu/atombios_
Move DisplayPort functions into a separate module to reduce the size
of the KMS helpers. Select DRM_DP_HELPER for all users of the code. To
avoid naming conflicts, rename drm_dp_helper.c to drm_dp.c
This change can help to reduce the size of the kernel binary. Some
numbers from a x86-64 test build
Split the DP declarations from other helpers before moving the
DP functions into a separate module.
v2:
* forward-declare struct drm_dp_aux (Jani)
* add include guards in drm_dp_helper_internal.h
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/drm_crtc_helper_internal.h | 2
Fix coding style.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/drm_dp_mst_topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
b/drivers/gpu/drm/drm_dp_mst_topology.c
index f3d79eda94bb..7f0ff96261cf 100644
--- a/drivers/gp
Move drm_dp_aux_bus.c and its header file into the DP subdirectory
and update all users. No functional changes.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/Makefile | 2 --
drivers/gpu/drm/bridge/parade-ps8640.c | 2 +-
drivers/gpu/drm/bridge/ti-sn65dsi
On Wed, 15 Dec 2021, Thomas Zimmermann wrote:
> * move DP helper code into dp/ (Jani)
I suggested adding the subdirectory, but I'm going to bikeshed the name,
which I didn't suggest.
$ find drivers/gpu/drm -mindepth 1 -maxdepth 1 -type d | wc -l
68
Assuming we move more of the drm modules
Ditch the writeback hook and drop i915_gem_object_writeback(). We
already support the shrinker_release_pages hook which can just call
shmem_writeback directly.
Suggested-by: Tvrtko Ursulin
Signed-off-by: Matthew Auld
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/gem/i915_gem_object.h
Add some proper flags for the different modes, and shorten the name to
something more snappy.
Suggested-by: Tvrtko Ursulin
Signed-off-by: Matthew Auld
---
.../gpu/drm/i915/gem/i915_gem_object_types.h | 23 ---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 8 +++
drivers/
On Wed, 15 Dec 2021, Thomas Hellström wrote:
> Since it's starting to be used outside the i915 TTM move code, move it
> to a separate set of files.
Sure, but why the top level instead of gem/?
BR,
Jani.
>
> Signed-off-by: Thomas Hellström
> ---
> drivers/gpu/drm/i915/Makefile|
Hi
Am 15.12.21 um 12:04 schrieb Jani Nikula:
On Wed, 15 Dec 2021, Thomas Zimmermann wrote:
* move DP helper code into dp/ (Jani)
I suggested adding the subdirectory, but I'm going to bikeshed the name,
which I didn't suggest.
$ find drivers/gpu/drm -mindepth 1 -maxdepth 1 -type d |
== Series Details ==
Series: drm/i915: Asynchronous vma unbinding
URL : https://patchwork.freedesktop.org/series/98055/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
40ccf1d6e849 drm/i915: Avoid using the i915_fence_array when collecting
dependencies
c45e38a63dd7 drm/i915: Bre
== Series Details ==
Series: drm/i915: Asynchronous vma unbinding
URL : https://patchwork.freedesktop.org/series/98055/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Asynchronous vma unbinding
URL : https://patchwork.freedesktop.org/series/98055/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11004 -> Patchwork_21851
Summary
---
**SUCCESS**
== Series Details ==
Series: drm/dp: Move DisplayPort helpers into own module (rev2)
URL : https://patchwork.freedesktop.org/series/97961/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
CALLscripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/comp
== Series Details ==
Series: series starting with [1/2] drm/i915: remove writeback hook
URL : https://patchwork.freedesktop.org/series/98061/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: series starting with [1/2] drm/i915: remove writeback hook
URL : https://patchwork.freedesktop.org/series/98061/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11004 -> Patchwork_21853
Summary
--
On Tue, 14 Dec 2021, Lucas De Marchi wrote:
> On Tue, Dec 14, 2021 at 11:42:41AM +0200, Jani Nikula wrote:
>>On Fri, 17 Sep 2021, Lucas De Marchi wrote:
>>> From: Clint Taylor
>>>
>>> Read OPROM SPI through MMIO and find VBT entry since we can't use
>>> OpRegion and PCI mapping may not work on s
== Series Details ==
Series: drm/i915/dg1: Read OPROM via SPI controller (rev2)
URL : https://patchwork.freedesktop.org/series/94826/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
0152dbed149b drm/i915/dg1: Read OPROM via SPI controller
-:63: WARNING:OOM_MESSAGE: Possible unnec
== Series Details ==
Series: drm/i915/dg1: Read OPROM via SPI controller (rev2)
URL : https://patchwork.freedesktop.org/series/94826/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On Wed, Dec 15, 2021 at 09:05:03AM +, Sarvela, Tomi P wrote:
> > From: Ville Syrjälä
> >
> > On Tue, Dec 14, 2021 at 06:25:43PM +0200, Ville Syrjälä wrote:
> > > On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote:
> > > > On Mon, 13 Dec 2021, Ville Syrjala
> > > > wrote:
> > > >
>
> From: Ville Syrjälä
> On Wed, Dec 15, 2021 at 09:05:03AM +, Sarvela, Tomi P wrote:
> > > From: Ville Syrjälä
> > >
> > > On Tue, Dec 14, 2021 at 06:25:43PM +0200, Ville Syrjälä wrote:
> > > > On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote:
> > > > > On Mon, 13 Dec 2021, Ville S
== Series Details ==
Series: drm/i915/dg1: Read OPROM via SPI controller (rev2)
URL : https://patchwork.freedesktop.org/series/94826/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11004 -> Patchwork_21854
Summary
---
GSC is a graphics system controller, based on CSE, it provides
a chassis controller for graphics discrete cards, as well as it
supports media protection (HDCP 2.2) on selected devices.
There are two MEI interfaces in GSC: HECI1, the one that provides media
protection and HECI2 the one that provide
From: Tomas Winkler
GSC is a graphics system controller, based on CSE, it provides
a chassis controller for graphics discrete cards, as well as it
supports media protection (HDCP 2.2) on selected devices.
There are two MEI interfaces in GSC HECI1, the one that provides media
protection and HECI2
From: Tomas Winkler
GSC is a graphics system controller, based on CSE, it provides
a chassis controller for graphics discrete cards, as well as it
supports media protection (HDCP 2.2) on selected devices.
mei_gsc binds to a platform devices exposed by Intel discrete
driver i915 via MFD framework
Continue to char device setup in spite of firmware handshake failure.
In order to provide access to the firmware status registers and other
information are valuable for debug and manufacturing.
Signed-off-by: Alexander Usyskin
Signed-off-by: Tomas Winkler
---
drivers/misc/mei/gsc-me.c | 11
GSC has a different MKHI client GUID with same message structure
as MEI to retrieve the firmware version.
Add a bus-fixup to retrieve the firmware version of the
GSC devices.
CC: Ashutosh Dixit
Signed-off-by: Alexander Usyskin
Signed-off-by: Tomas Winkler
---
drivers/misc/mei/bus-fixup.c | 25
From: Tomas Winkler
Implement runtime handlers for mei-gsc, to track
idle state of the device properly.
CC: Rodrigo Vivi
Signed-off-by: Tomas Winkler
Signed-off-by: Alexander Usyskin
---
drivers/misc/mei/gsc-me.c | 80 ++-
1 file changed, 79 insertions(+),
== Series Details ==
Series: Add driver for GSC controller
URL : https://patchwork.freedesktop.org/series/98066/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
06f5f59f4a16 drm/i915/gsc: add gsc as a mei platform device
-:51: WARNING:FILE_PATH_CHANGES: added, moved or deleted fi
On Wed, Dec 15, 2021 at 03:56:18PM +0200, Alexander Usyskin wrote:
> From: Tomas Winkler
>
> GSC is a graphics system controller, based on CSE, it provides
> a chassis controller for graphics discrete cards, as well as it
> supports media protection (HDCP 2.2) on selected devices.
>
> There are
== Series Details ==
Series: Add driver for GSC controller
URL : https://patchwork.freedesktop.org/series/98066/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
> From: Sarvela, Tomi P
> > From: Ville Syrjälä
> > On Wed, Dec 15, 2021 at 09:05:03AM +, Sarvela, Tomi P wrote:
> > > > From: Ville Syrjälä
> > > >
> > > > On Tue, Dec 14, 2021 at 06:25:43PM +0200, Ville Syrjälä wrote:
> > > > > On Mon, Dec 13, 2021 at 09:54:04PM +0200, Jani Nikula wrote:
>
== Series Details ==
Series: drm/i915: Asynchronous vma unbinding
URL : https://patchwork.freedesktop.org/series/98055/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11004_full -> Patchwork_21851_full
Summary
---
**F
== Series Details ==
Series: Add driver for GSC controller
URL : https://patchwork.freedesktop.org/series/98066/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11004 -> Patchwork_21855
Summary
---
**WARNING**
Minor
== Series Details ==
Series: series starting with [1/2] drm/i915: remove writeback hook
URL : https://patchwork.freedesktop.org/series/98061/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11004_full -> Patchwork_21853_full
On 15/12/2021 11:07, Matthew Auld wrote:
Add some proper flags for the different modes, and shorten the name to
something more snappy.
Looks good to me - but since it touches TTM I leave for Thomas to approve.
Regards,
Tvrtko
P.S. I hope writing the patch means you thought it is an improve
your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/drm-i915-Asynchronous-vma-unbinding/
On 09/12/2021 17:45, Ramalingam C wrote:
From: Mika Kahola
DG2 clear color render compression uses Tile4 layout. Therefore, we need
to define a new format modifier for uAPI to support clear color rendering.
Signed-off-by: Mika Kahola
cc: Anshuman Gupta
Signed-off-by: Juha-Pekka Heikkilä
Sig
On 15/12/2021 15:55, Tvrtko Ursulin wrote:
On 15/12/2021 11:07, Matthew Auld wrote:
Add some proper flags for the different modes, and shorten the name to
something more snappy.
Looks good to me - but since it touches TTM I leave for Thomas to approve.
Regards,
Tvrtko
P.S. I hope writing t
== Series Details ==
Series: drm/i915/dg1: Read OPROM via SPI controller (rev2)
URL : https://patchwork.freedesktop.org/series/94826/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11004_full -> Patchwork_21854_full
Summary
The fixes below fix gem_lmem_swapping@basic igt test
On 09/12/2021 15:45, Ramalingam C wrote:
From: Ayaz A Siddiqui
Xe-HP and latest devices support Flat CCS which reserved a portion of
the device memory to store compression metadata, during the clearing of
device memory buffer object we also
tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/drm-i915-Asynchronous-vma-unbinding/20211215-183859
base: git://anongit.free
== Series Details ==
Series: Add driver for GSC controller
URL : https://patchwork.freedesktop.org/series/98066/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11004_full -> Patchwork_21855_full
Summary
---
**SUCCESS*
6-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/drm-i915-Asynchronous-vma-unb
tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/drm-i915-Asynchronous-vma-unbinding/20211215-183859
base: git://anongit.free
On Fri, Dec 10, 2021 at 10:50:09AM +0530, Nautiyal, Ankit K wrote:
>
> On 10/15/2021 7:09 PM, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > We're currently duplicating the DFP min/max TMDS clock checks
> > in .mode_valid() and .compute_config(). Extract a helper suitable
> > for both use c
On Tue, Dec 14, 2021 at 08:09:29AM +0100, Christian König wrote:
> Am 14.12.21 um 04:37 schrieb Ira Weiny:
> > On Mon, Dec 13, 2021 at 09:37:32PM +0100, Christian König wrote:
> > > Am 11.12.21 um 00:24 schrieb ira.we...@intel.com:
> > > > From: Ira Weiny
> > > >
> > > > The default case leaves t
The following changes since commit b0e898fbaf377c99a36aac6fdeb7250003648ca4:
linux-firmware: Update firmware file for Intel Bluetooth 9462 (2021-11-23
12:31:45 -0500)
are available in the Git repository at:
ssh://git.freedesktop.org/git/drm/drm-firmware guc_v69.0.3
for you to fetch changes
From: John Harrison
A fault injection probe test hit a BUG_ON in a GuC error path. It
showed that the GuC code could potentially attempt to do many things
when the device is actually wedged. So, add a check in to prevent that.
Signed-off-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_g
Bump! :)
Thanks,
- Madhumitha
On Wed, 2021-12-08 at 18:11 +, Srivatsa, Anusha wrote:
> Ping :)
> Can these updates be merged to linux-firmware?
>
>
> Thanks,
> Anusha
>
> > -Original Message-
> > From: Tolakanahalli Pradeep, Madhumitha
> >
> > Sent: Thursday, December 2, 2021 6:48
== Series Details ==
Series: drm/i915/guc: Check for wedged before doing stuff
URL : https://patchwork.freedesktop.org/series/98099/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11005 -> Patchwork_21856
Summary
---
On Wed, Dec 15, 2021 at 02:45:56PM -0800, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> A fault injection probe test hit a BUG_ON in a GuC error path. It
> showed that the GuC code could potentially attempt to do many things
> when the device is actually wedged. So, add a check in to
On 12/10/2021 10:58 PM, john.c.harri...@intel.com wrote:
From: John Harrison
A workaround was added to the driver to allow OpenCL workloads to run
'forever' by disabling pre-emption on the RCS engine for Gen12.
It is not totally unbound as the heartbeat will kick in eventually
and cause a re
On 12/10/2021 10:58 PM, john.c.harri...@intel.com wrote:
From: John Harrison
If GuC encounters an error during engine reset, the i915 driver
promotes to full GT reset. This includes an info message about why the
reset is happening. However, that is not treated as a failure by any
of the CI s
== Series Details ==
Series: drm/i915/guc: Check for wedged before doing stuff
URL : https://patchwork.freedesktop.org/series/98099/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11005_full -> Patchwork_21856_full
Summary
-
From: Clint Taylor
Read OPROM SPI through MMIO and find VBT entry since we can't use
OpRegion and PCI mapping may not work on some systems due to most BIOSes
not leaving the Option ROM mapped.
v2: Remove message with allocation failure
Cc: Ville Syrjälä
Cc: Tomas Winkler
Signed-off-by: Clint
== Series Details ==
Series: drm/i915/dg1: Read OPROM via SPI controller (rev3)
URL : https://patchwork.freedesktop.org/series/94826/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/dg1: Read OPROM via SPI controller (rev3)
URL : https://patchwork.freedesktop.org/series/94826/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11006 -> Patchwork_21857
Summary
---
On Mon, Dec 13, 2021 at 03:29:10PM -0800, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> Added a an extra step to the i915_hangman tests to check that the
> system is still alive after the hang and recovery. This submits a
> simple batch to each engine which does a write to memory and
On Mon, Dec 13, 2021 at 03:29:11PM -0800, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> A lot of tests use almost identical code for creating a batch buffer
> which does a single write to memory. This patch collects two such
> instances into a common helper function. Unfortunately, t
74 matches
Mail list logo
