Re: [Intel-gfx] [PATCH v4 07/16] drm/i915/dg2: Tile 4 plane format support

2021-12-10 Thread Ramalingam C
On 2021-12-10 at 09:33:07 +0200, Lisovskiy, Stanislav wrote: > On Thu, Dec 09, 2021 at 09:15:24PM +0530, Ramalingam C wrote: > > From: Stanislav Lisovskiy > > > > Tile4 in bspec format is 4K tile organized into > > 64B subtiles with same basic shape as for legacy TileY > > which will be supported

Re: [Intel-gfx] [PATCH 2/9] drm/i915/gvt: Constify intel_gvt_gtt_pte_ops

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put them in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/gtt.c | 62 +- > drivers/gpu/drm/i915/gvt/g

Re: [Intel-gfx] [PATCH 3/9] drm/i915/gvt: Constify intel_gvt_irq_ops

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put them in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/interrupt.c | 10 +- > drivers/gpu/drm/i915/gvt/interrupt.h | 2 +-

Re: [Intel-gfx] [PATCH 4/9] drm/i915/gvt: Constify intel_gvt_sched_policy_ops

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put them in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/sched_policy.c | 2 +- > drivers/gpu/drm/i915/gvt/scheduler.h| 2 +- >

Re: [Intel-gfx] [PATCH 5/9] drm/i915/gvt: Constify gvt_mmio_block

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put it in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/gvt.h | 2 +- > drivers/gpu/drm/i915/gvt/handlers.c | 12 ++-- >

Re: [Intel-gfx] [PATCH 6/9] drm/i915/gvt: Constify cmd_interrupt_events

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > It is never modified, so make it const to allow the compiler to put it > in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Intel-gfx] [PATCH 7/9] drm/i915/gvt: Constify formats

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put them in read-only memory. WHile at it, make the description const > char* since it is never modified. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/

Re: [Intel-gfx] [PATCH 8/9] drm/i915/gvt: Constify gtt_type_table_entry

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > It is never modified, so make it const to allow the compiler to put it > in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/gtt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/driv

Re: [Intel-gfx] [PATCH 9/9] drm/i915/gvt: Constify vgpu_types

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > It is never modified, so make it const to allow the compiler to put it > in read-only memory. While at it, make name a const char*. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/vgpu.c | 4 ++-- > 1 file changed, 2 insertio

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Use correct context lock when callig clr_context_registered

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/guc: Use correct context lock when callig clr_context_registered URL : https://patchwork.freedesktop.org/series/97823/ State : success == Summary == CI Bug Log - changes from CI_DRM_10987 -> Patchwork_21811

Re: [Intel-gfx] [PATCH] drm/i915/guc: Use correct context lock when callig clr_context_registered

2021-12-10 Thread Tvrtko Ursulin
On 09/12/2021 19:14, Daniele Ceraolo Spurio wrote: On 12/9/2021 10:48 AM, Matthew Brost wrote: s/ce/cn/ when grabbing guc_state.lock before calling clr_context_registered. Fixes: 0f7976506de61 ("drm/i915/guc: Rework and simplify locking") Signed-off-by: Matthew Brost Cc: I think Cc: sta

Re: [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice

2021-12-10 Thread Tvrtko Ursulin
On 10/12/2021 01:31, dong.y...@intel.com wrote: From: "Yang, Dong" With unknow race condition, the i915_request will be added What do you mean with unknown here? to intel_context list twice, and result in system panic. If node alreay exist then do not add it again. Note the call chains

Re: [Intel-gfx] [PATCH 1/9] drm/i915/gvt: Constify intel_gvt_gtt_pte_ops

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to > put them in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/gpu/drm/i915/gvt/gtt.c | 4 ++-- > drivers/gpu/drm/i915/gvt/gtt.h | 2 +- > 2 files changed

Re: [Intel-gfx] [PATCH 0/9] drm/i915/gvt: Constify static structs

2021-12-10 Thread Wang, Zhi A
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > Constify a number of static structs that are never modified to allow the > compiler to put them in read-only memory. In order to do this, constify a > number of local variables and pointers in structs. > > This is most important for structs that cont

[Intel-gfx] ✓ Fi.CI.IGT: success for Support bigger GuC RSA keys

2021-12-10 Thread Patchwork
== Series Details == Series: Support bigger GuC RSA keys URL : https://patchwork.freedesktop.org/series/97760/ State : success == Summary == CI Bug Log - changes from CI_DRM_10984_full -> Patchwork_21797_full Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Remove racey GEM_BUG_ON

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/guc: Remove racey GEM_BUG_ON URL : https://patchwork.freedesktop.org/series/97825/ State : success == Summary == CI Bug Log - changes from CI_DRM_10987 -> Patchwork_21812 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GPD Win Max display fixes (rev6)

2021-12-10 Thread Patchwork
== Series Details == Series: GPD Win Max display fixes (rev6) URL : https://patchwork.freedesktop.org/series/90483/ State : warning == Summary == $ dim checkpatch origin/drm-tip 77130fc0f92b drm/i915/opregion: add support for mailbox #5 EDID -:20: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapp

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for GPD Win Max display fixes (rev6)

2021-12-10 Thread Patchwork
== Series Details == Series: GPD Win Max display fixes (rev6) URL : https://patchwork.freedesktop.org/series/90483/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for GPD Win Max display fixes (rev6)

2021-12-10 Thread Patchwork
== Series Details == Series: GPD Win Max display fixes (rev6) URL : https://patchwork.freedesktop.org/series/90483/ State : success == Summary == CI Bug Log - changes from CI_DRM_10987 -> Patchwork_21813 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/guc: Request RP0 before loading firmware (rev2)

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/guc: Request RP0 before loading firmware (rev2) URL : https://patchwork.freedesktop.org/series/97682/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Introduce new Tile 4 format

2021-12-10 Thread Imre Deak
On Thu, Dec 09, 2021 at 05:14:56PM +0200, Chery, Nanley G wrote: > > > > -Original Message- > > From: Lisovskiy, Stanislav > > Sent: Thursday, December 9, 2021 5:47 AM > > To: intel-gfx@lists.freedesktop.org > > Cc: dri-de...@lists.freedesktop.org; Lisovskiy, Stanislav > > ; Saarinen, Ja

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Request RP0 before loading firmware (rev2)

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/guc: Request RP0 before loading firmware (rev2) URL : https://patchwork.freedesktop.org/series/97682/ State : success == Summary == CI Bug Log - changes from CI_DRM_10987 -> Patchwork_21814 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Introduce new Tile 4 format

2021-12-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Introduce new Tile 4 format URL : https://patchwork.freedesktop.org/series/97778/ State : success == Summary == CI Bug Log - changes from CI_DRM_10984_full -> Patchwork_21798_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More preparation for multi gt patches (rev7)

2021-12-10 Thread Patchwork
== Series Details == Series: More preparation for multi gt patches (rev7) URL : https://patchwork.freedesktop.org/series/97020/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3898ddfa1ff2 drm/i915: Store backpointer to GT in uncore 7c7e522ad409 drm/i915: Introduce to_gt() helper

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for More preparation for multi gt patches (rev7)

2021-12-10 Thread Patchwork
== Series Details == Series: More preparation for multi gt patches (rev7) URL : https://patchwork.freedesktop.org/series/97020/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915/guc: Use correct context lock when callig clr_context_registered

2021-12-10 Thread Jani Nikula
On Fri, 10 Dec 2021, Tvrtko Ursulin wrote: > On 09/12/2021 19:14, Daniele Ceraolo Spurio wrote: >> >> >> On 12/9/2021 10:48 AM, Matthew Brost wrote: >>> s/ce/cn/ when grabbing guc_state.lock before calling >>> clr_context_registered. >>> >>> Fixes: 0f7976506de61 ("drm/i915/guc: Rework and simpli

Re: [Intel-gfx] [PATCH v4 11/16] drm/i915/dg2: Add DG2 unified compression

2021-12-10 Thread Imre Deak
On Thu, Dec 09, 2021 at 09:15:28PM +0530, Ramalingam C wrote: > From: Matt Roper > > DG2 unifies render compression and media compression into a single > format for the first time. The programming and buffer layout is > supposed to match compression on older gen12 platforms, but the actual > com

Re: [Intel-gfx] [PATCH 02/10] drm: Add privacy-screen class (v4)

2021-12-10 Thread Thorsten Leemhuis
Hi, this is your Linux kernel regression tracker speaking. Top-posting for once, to make this easy accessible to everyone. Hans, I stumbled upon your blog post about something that afaics is related to below patch: https://hansdegoede.livejournal.com/25948.html To quote: > To avoid any regressi

Re: [Intel-gfx] [PATCH 02/10] drm: Add privacy-screen class (v4)

2021-12-10 Thread Hans de Goede
Hi Thorsten, On 12/10/21 11:12, Thorsten Leemhuis wrote: > Hi, this is your Linux kernel regression tracker speaking. > > Top-posting for once, to make this easy accessible to everyone. > > Hans, I stumbled upon your blog post about something that afaics is > related to below patch: > https://ha

Re: [Intel-gfx] [RFC] drm/i915/display: Move cdclk checks to atomic check

2021-12-10 Thread Jani Nikula
On Thu, 09 Dec 2021, Anusha Srivatsa wrote: > i915 has squashing for DG2 and crawling for ADLP. > Moving the checks to atomic check phase so > at a later phase we know how the cdclk changes. Just some high level comments: - Functions named intel_cdclk_can_foo() must *not* change the state, tha

Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform

2021-12-10 Thread Jani Nikula
On Fri, 10 Dec 2021, Tejas Upadhyay wrote: > Adding PCI device ids and enabling ADL-N platform. > ADL-N from i915 point of view is subplatform of ADL-P. > > BSpec: 68397 > > Changes since V2: > - Added version log history > Changes since V1: > - replace IS_ALDERLAKE_N with IS_ADLP_N -

Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform

2021-12-10 Thread Surendrakumar Upadhyay, TejaskumarX
> -Original Message- > From: Jani Nikula > Sent: 10 December 2021 16:18 > To: Surendrakumar Upadhyay, TejaskumarX > ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH V3] drm/i915/adl-n: Enable ADL-N platform > > On Fri, 10 Dec 2021, Tejas Upadhyay > wrote: > > Ad

[Intel-gfx] ✓ Fi.CI.BAT: success for More preparation for multi gt patches (rev7)

2021-12-10 Thread Patchwork
== Series Details == Series: More preparation for multi gt patches (rev7) URL : https://patchwork.freedesktop.org/series/97020/ State : success == Summary == CI Bug Log - changes from CI_DRM_10987 -> Patchwork_21815 Summary --- **SUC

Re: [Intel-gfx] [PATCH 1/3] drm/i915/fbc: Parametrize FBC register offsets

2021-12-10 Thread Jani Nikula
On Thu, 09 Dec 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Parametrize ilk+ FBC register offsets based on the FBC instance. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_fbc.c | 34 +--- > drivers/gpu/drm/i915/display/intel_fbc.h | 6 +

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Do not add same i915_request to intel_context twice

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Do not add same i915_request to intel_context twice URL : https://patchwork.freedesktop.org/series/97843/ State : warning == Summary == $ dim checkpatch origin/drm-tip 94b2a1bdd53a drm/i915/gt: Do not add same i915_request to intel_context twice -:7: W

Re: [Intel-gfx] [PATCH 2/3] drm/i915/fbc: Loop through FBC instances in various places

2021-12-10 Thread Jani Nikula
On Thu, 09 Dec 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Convert i915->fbc into an array in preparation for > multiple FBC instances, and loop through all instances > in all places where the caller does not know which > instance(s) (if any) are relevant. This is the case > for eg. fron

[Intel-gfx] [PATCH] drm/i915: Stop doing writeback from the shrinker

2021-12-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This effectively removes writeback which was added in 2d6692e642e7 ("drm/i915: Start writeback from the shrinker"). Digging through the history it seems we went back and forth on the topic of whether it would be safe a couple of times. See for instance 5537252b6b6d ("drm/i91

Re: [Intel-gfx] [PATCH 3/3] drm/i915/fbc: Introduce device info fbc_mask

2021-12-10 Thread Jani Nikula
On Thu, 09 Dec 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Declare which FBC instances are present via a fbc_mask > in device info. For the moment there is just the one. > > TODO: Need to figure out how to expose multiple FBC > instances in debugs. Just different file names, or move > th

Re: [Intel-gfx] [PATCH 02/10] drm: Add privacy-screen class (v4)

2021-12-10 Thread Thorsten Leemhuis
On 10.12.21 11:46, Hans de Goede wrote: > On 12/10/21 11:12, Thorsten Leemhuis wrote: >> Hi, this is your Linux kernel regression tracker speaking. >> >> Top-posting for once, to make this easy accessible to everyone. >> >> Hans, I stumbled upon your blog post about something that afaics is >> rela

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: prepare reset based on reset domain

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: prepare reset based on reset domain URL : https://patchwork.freedesktop.org/series/97786/ State : success == Summary == CI Bug Log - changes from CI_DRM_10984_full -> Patchwork_21799_full Summary --

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Do not add same i915_request to intel_context twice

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Do not add same i915_request to intel_context twice URL : https://patchwork.freedesktop.org/series/97843/ State : success == Summary == CI Bug Log - changes from CI_DRM_10987 -> Patchwork_21816 Summ

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Assorted fixes/tweaks to GuC support (rev6)

2021-12-10 Thread Patchwork
== Series Details == Series: Assorted fixes/tweaks to GuC support (rev6) URL : https://patchwork.freedesktop.org/series/97514/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1cf15e0b68da drm/i915/uc: Allow platforms to have GuC but not HuC -:38: ERROR:COMPLEX_MACRO: Macros with

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Assorted fixes/tweaks to GuC support (rev6)

2021-12-10 Thread Patchwork
== Series Details == Series: Assorted fixes/tweaks to GuC support (rev6) URL : https://patchwork.freedesktop.org/series/97514/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 3/3] drm/i915/fbc: Introduce device info fbc_mask

2021-12-10 Thread Ville Syrjälä
On Fri, Dec 10, 2021 at 01:14:22PM +0200, Jani Nikula wrote: > On Thu, 09 Dec 2021, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Declare which FBC instances are present via a fbc_mask > > in device info. For the moment there is just the one. > > > > TODO: Need to figure out how to expose

[Intel-gfx] ✓ Fi.CI.BAT: success for Assorted fixes/tweaks to GuC support (rev6)

2021-12-10 Thread Patchwork
== Series Details == Series: Assorted fixes/tweaks to GuC support (rev6) URL : https://patchwork.freedesktop.org/series/97514/ State : success == Summary == CI Bug Log - changes from CI_DRM_10987 -> Patchwork_21817 Summary --- **SUCC

Re: [Intel-gfx] [PATCH 3/3] drm/i915/fbc: Introduce device info fbc_mask

2021-12-10 Thread Jani Nikula
On Fri, 10 Dec 2021, Ville Syrjälä wrote: > On Fri, Dec 10, 2021 at 01:14:22PM +0200, Jani Nikula wrote: >> On Thu, 09 Dec 2021, Ville Syrjala wrote: >> > diff --git a/drivers/gpu/drm/i915/intel_device_info.h >> > b/drivers/gpu/drm/i915/intel_device_info.h >> > index 213ae2c07126..89712019f073 1

[Intel-gfx] [PATCH] drm/i915: Move pipe/transcoder/abox masks under intel_device_info.display

2021-12-10 Thread Ville Syrjala
From: Ville Syrjälä Collect the dipslay related mask under the display sub-structure in intel_device_info. Note that there is a slight change in behaviour in that we zero out .display entirely when !HAS_DISPLAY (aka. pipe_mask==0), so now we also zero out the other masks (although cpu_transocder

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Fix up pixel_rate vs. clock confusion in wm calculations

2021-12-10 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Fix up pixel_rate vs. clock confusion in wm calculations URL : https://patchwork.freedesktop.org/series/97808/ State : success == Summary == CI Bug Log - changes from CI_DRM_10984_full -> Patchwork_21804_full ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/adl-n: Enable ADL-N platform (rev3)

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/adl-n: Enable ADL-N platform (rev3) URL : https://patchwork.freedesktop.org/series/97406/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7d0f0f58c665 drm/i915/adl-n: Enable ADL-N platform -:103: ERROR:COMPLEX_MACRO: Macros with complex value

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/adl-n: Enable ADL-N platform (rev3)

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/adl-n: Enable ADL-N platform (rev3) URL : https://patchwork.freedesktop.org/series/97406/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: include reductions

2021-12-10 Thread Jani Nikula
On Fri, 10 Dec 2021, Patchwork wrote: > == Series Details == > > Series: drm/i915: include reductions > URL : https://patchwork.freedesktop.org/series/97789/ > State : failure > > == Summary == > > CALLscripts/checksyscalls.sh > CALLscripts/atomic/check-atomics.sh > DESCEND objtool >

Re: [Intel-gfx] [PATCH] drm/i915: Move pipe/transcoder/abox masks under intel_device_info.display

2021-12-10 Thread Jani Nikula
On Fri, 10 Dec 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Collect the dipslay related mask under the display sub-structure > in intel_device_info. > > Note that there is a slight change in behaviour in that we zero > out .display entirely when !HAS_DISPLAY (aka. pipe_mask==0), so > now

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/adl-n: Enable ADL-N platform (rev3)

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/adl-n: Enable ADL-N platform (rev3) URL : https://patchwork.freedesktop.org/series/97406/ State : success == Summary == CI Bug Log - changes from CI_DRM_10988 -> Patchwork_21818 Summary --- **SUC

[Intel-gfx] [PATCH v2 1/7] drm/i915/reset: include intel_display.h instead of intel_display_types.h

2021-12-10 Thread Jani Nikula
Use the more specific include that's needed. v2: Include intel_display.h (Ville) Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_reset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/

[Intel-gfx] [PATCH v2 0/7] drm/i915: include reductions

2021-12-10 Thread Jani Nikula
v2 of https://patchwork.freedesktop.org/series/97789/ Jani Nikula (7): drm/i915/reset: include intel_display.h instead of intel_display_types.h drm/i915/active: remove useless i915_utils.h include drm/i915/psr: avoid intel_frontbuffer.h include with declaration drm/i915/fbc: avoid inte

[Intel-gfx] [PATCH v2 3/7] drm/i915/psr: avoid intel_frontbuffer.h include with declaration

2021-12-10 Thread Jani Nikula
Reduce include dependencies using forward declarations. Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_psr.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.h b/drivers/gpu/drm/

[Intel-gfx] [PATCH v2 2/7] drm/i915/active: remove useless i915_utils.h include

2021-12-10 Thread Jani Nikula
Not needed. Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_active_types.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_active_types.h b/drivers/gpu/drm/i915/i915_active_types.h index c149f348a972..b02a78ac87db 100644 --- a/

[Intel-gfx] [PATCH v2 4/7] drm/i915/fbc: avoid intel_frontbuffer.h include with declaration

2021-12-10 Thread Jani Nikula
Reduce include dependencies using forward declarations. Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fbc.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.h b/drivers/gpu/drm/i915/displ

[Intel-gfx] [PATCH v2 5/7] drm/i915/fb: reduce include dependencies

2021-12-10 Thread Jani Nikula
We actually need i915_active_types.h, not i915_active.h. Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_frontbuffer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_frontbuffer.h b/drivers/gpu

[Intel-gfx] [PATCH v2 6/7] drm/i915/pxp: un-inline intel_pxp_is_enabled()

2021-12-10 Thread Jani Nikula
In the interest of reducing include dependencies, un-inline intel_pxp_is_enabled(). v2: Fix build for CONFIG_DRM_I915_PXP=n Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 5 + drivers/gpu/drm/i915/pxp/intel_pxp.h | 15 +-- 2 fi

[Intel-gfx] [PATCH v2 7/7] drm/i915/pxp: remove useless includes

2021-12-10 Thread Jani Nikula
Not needed. Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/pxp/intel_pxp_types.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_types.h b/drivers/gpu/drm/i915/pxp/intel_pxp_types.h index 73ef7d1754e1..7ce5f37ee12e 100644

Re: [Intel-gfx] [PATCH] drm/i915/gem: Use local pointer ttm for __i915_ttm_move

2021-12-10 Thread Hellstrom, Thomas
On Wed, 2021-12-08 at 16:05 -0800, Jasmine Newsome wrote: > Using local pointer ttm as argument in  __i915_ttm_move > instead of bo->ttm, as local pointer was previously assigned > to bo->ttm in function. This will make code a bit more readable. > > Signed-off-by: Jasmine Newsome Reviewed-by: Th

[Intel-gfx] [bug report] drm/i915/gt: Replace direct submit with direct call to tasklet

2021-12-10 Thread Dan Carpenter
Hello Chris Wilson, The patch 16f2941ad307: "drm/i915/gt: Replace direct submit with direct call to tasklet" from Dec 24, 2020, leads to the following Smatch static checker warning: drivers/gpu/drm/i915/gt/selftest_lrc.c:1616 garbage_reset() warn: sleeping in atomic context drive

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Sanity Check for device memory region (rev4)

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Sanity Check for device memory region (rev4) URL : https://patchwork.freedesktop.org/series/97715/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10984_full -> Patchwork_21806_full Summ

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: Move cdclk checks to atomic check

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/display: Move cdclk checks to atomic check URL : https://patchwork.freedesktop.org/series/97850/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH] drm/i915/selftests: Fix inconsistent object in IS_ERR and PTR_ERR

2021-12-10 Thread Miaoqian Lin
Fix inconsistent object in IS_ERR and PTR_ERR in igt_dmabuf_import_same_driver and igt_dmabuf_import_same_driver_lmem. As obj is the return value of __i915_gem_object_create_user, the proper object to be passed as argument to PTR_ERR is obj. Signed-off-by: Miaoqian Lin --- drivers/gpu/drm/i915/g

[Intel-gfx] [PATCH] drm: i915: display: intel_dmc: Fixes an unsigned subtraction which can never be negative.

2021-12-10 Thread Harshit Mogalapalli
smatch warning: drivers/gpu/drm/i915/display/intel_dmc.c:601 parse_dmc_fw() warn: unsigned 'fw->size - offset' is never less than zero Firmware size is size_t and offset is u32. So the subtraction is unsigned which can never be less than zero. Fixes: 3d5928a168a9 ("drm/i915/xelpd: Pipe A DMC plug

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Move cdclk checks to atomic check

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/display: Move cdclk checks to atomic check URL : https://patchwork.freedesktop.org/series/97850/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10988 -> Patchwork_21819 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Stop doing writeback from the shrinker

2021-12-10 Thread Thomas Hellström
On Fri, 2021-12-10 at 11:05 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > This effectively removes writeback which was added in 2d6692e642e7 > ("drm/i915: Start writeback from the shrinker"). > > Digging through the history it seems we went back and forth on the > topic > of whether it

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't leak the capture list items (rev2)

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Don't leak the capture list items (rev2) URL : https://patchwork.freedesktop.org/series/97804/ State : success == Summary == CI Bug Log - changes from CI_DRM_10988 -> Patchwork_21820 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Stop doing writeback from the shrinker

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Stop doing writeback from the shrinker URL : https://patchwork.freedesktop.org/series/97856/ State : warning == Summary == $ dim checkpatch origin/drm-tip ea5ef6ccbc42 drm/i915: Stop doing writeback from the shrinker -:9: ERROR:GIT_COMMIT_ID: Please use g

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Stop doing writeback from the shrinker

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Stop doing writeback from the shrinker URL : https://patchwork.freedesktop.org/series/97856/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/cdclk: improve abstractions

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/cdclk: improve abstractions URL : https://patchwork.freedesktop.org/series/97802/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10984_full -> Patchwork_21807_full Summary --- **F

Re: [Intel-gfx] [PATCH v7 08/11] drm/i915/pxp: Use to_gt() helper

2021-12-10 Thread Matt Roper
On Fri, Dec 10, 2021 at 03:07:56AM +0200, Andi Shyti wrote: > Use to_gt() helper consistently throughout the codebase. > Pure mechanical s/i915->gt/to_gt(i915). No functional changes. > > Signed-off-by: Andi Shyti Reviewed-by: Matt Roper > --- > Hi, > > the inline of i915_dev_to_pxp() was acc

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Stop doing writeback from the shrinker

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Stop doing writeback from the shrinker URL : https://patchwork.freedesktop.org/series/97856/ State : success == Summary == CI Bug Log - changes from CI_DRM_10988 -> Patchwork_21821 Summary --- *

Re: [Intel-gfx] [PATCH] drm/i915: Stop doing writeback from the shrinker

2021-12-10 Thread Tvrtko Ursulin
On 10/12/2021 14:46, Thomas Hellström wrote: On Fri, 2021-12-10 at 11:05 +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin This effectively removes writeback which was added in 2d6692e642e7 ("drm/i915: Start writeback from the shrinker"). Digging through the history it seems we went back an

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Move pipe/transcoder/abox masks under intel_device_info.display

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Move pipe/transcoder/abox masks under intel_device_info.display URL : https://patchwork.freedesktop.org/series/97864/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9fb166758466 drm/i915: Move pipe/transcoder/abox masks under intel_device

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Move pipe/transcoder/abox masks under intel_device_info.display

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Move pipe/transcoder/abox masks under intel_device_info.display URL : https://patchwork.freedesktop.org/series/97864/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked sep

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move pipe/transcoder/abox masks under intel_device_info.display

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Move pipe/transcoder/abox masks under intel_device_info.display URL : https://patchwork.freedesktop.org/series/97864/ State : success == Summary == CI Bug Log - changes from CI_DRM_10988 -> Patchwork_21822

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: include reductions (rev2)

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915: include reductions (rev2) URL : https://patchwork.freedesktop.org/series/97789/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Fix inconsistent object in IS_ERR and PTR_ERR

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix inconsistent object in IS_ERR and PTR_ERR URL : https://patchwork.freedesktop.org/series/97868/ State : failure == Summary == Applying: drm/i915/selftests: Fix inconsistent object in IS_ERR and PTR_ERR Using index info to reconstruct a base

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: include reductions (rev2)

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915: include reductions (rev2) URL : https://patchwork.freedesktop.org/series/97789/ State : success == Summary == CI Bug Log - changes from CI_DRM_10988 -> Patchwork_21823 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dg2: Enabling 64k page size and flat ccs (rev4)

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Enabling 64k page size and flat ccs (rev4) URL : https://patchwork.freedesktop.org/series/95686/ State : success == Summary == CI Bug Log - changes from CI_DRM_10985_full -> Patchwork_21808_full Su

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: i915: display: intel_dmc: Fixes an unsigned subtraction which can never be negative.

2021-12-10 Thread Patchwork
== Series Details == Series: drm: i915: display: intel_dmc: Fixes an unsigned subtraction which can never be negative. URL : https://patchwork.freedesktop.org/series/97869/ State : success == Summary == CI Bug Log - changes from CI_DRM_10988 -> Patchwork_21825

Re: [Intel-gfx] [PATCH] drm: i915: display: intel_dmc: Fixes an unsigned subtraction which can never be negative.

2021-12-10 Thread Lucas De Marchi
On Thu, Dec 09, 2021 at 08:41:24PM -0800, Harshit Mogalapalli wrote: smatch warning: drivers/gpu/drm/i915/display/intel_dmc.c:601 parse_dmc_fw() warn: unsigned 'fw->size - offset' is never less than zero Firmware size is size_t and offset is u32. So the subtraction is unsigned which can never be

Re: [Intel-gfx] [PATCH] drm/i915/guc: Use correct context lock when callig clr_context_registered

2021-12-10 Thread Matthew Brost
On Fri, Dec 10, 2021 at 08:41:22AM +, Tvrtko Ursulin wrote: > > On 09/12/2021 19:14, Daniele Ceraolo Spurio wrote: > > > > > > On 12/9/2021 10:48 AM, Matthew Brost wrote: > > > s/ce/cn/ when grabbing guc_state.lock before calling > > > clr_context_registered. > > > > > > Fixes: 0f7976506de6

[Intel-gfx] [PATCH] drm/i915/ttm: fix large buffer population trucation

2021-12-10 Thread Robert Beckett
ttm->num_pages is uint32_t which was causing very large buffers to only populate a truncated size. This fixes gem_create@create-clear igt test on large memory systems. Fixes: 7ae034590cea ("drm/i915/ttm: add tt shmem backend") Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_

[Intel-gfx] [PATCH v2] drm/i915: Don't disable interrupts and pretend a lock as been acquired in __timeline_mark_lock().

2021-12-10 Thread Sebastian Andrzej Siewior
This is a revert of commits d67739268cf0e ("drm/i915/gt: Mark up the nested engine-pm timeline lock as irqsafe") 6c69a45445af9 ("drm/i915/gt: Mark context->active_count as protected by timeline->mutex") 6dcb85a0ad990 ("drm/i915: Hold irq-off for the entire fake lock period") The existin

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ttm: fix large buffer population trucation

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/ttm: fix large buffer population trucation URL : https://patchwork.freedesktop.org/series/97881/ State : success == Summary == CI Bug Log - changes from CI_DRM_10988 -> Patchwork_21826 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/privacy_screen_x86: Add entry for ChromeOS privacy-screen

2021-12-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/privacy_screen_x86: Add entry for ChromeOS privacy-screen URL : https://patchwork.freedesktop.org/series/97883/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7f0620e36c0b drm/privacy_screen_x86: Add entry for ChromeOS

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/privacy_screen_x86: Add entry for ChromeOS privacy-screen

2021-12-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/privacy_screen_x86: Add entry for ChromeOS privacy-screen URL : https://patchwork.freedesktop.org/series/97883/ State : success == Summary == CI Bug Log - changes from CI_DRM_10988 -> Patchwork_21827 =

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Don't disable interrupts and pretend a lock as been acquired in __timeline_mark_lock(). (rev2)

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Don't disable interrupts and pretend a lock as been acquired in __timeline_mark_lock(). (rev2) URL : https://patchwork.freedesktop.org/series/97082/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4e6d66ad49f7 drm/i915: Don't disable interr

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Don't disable interrupts and pretend a lock as been acquired in __timeline_mark_lock(). (rev2)

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Don't disable interrupts and pretend a lock as been acquired in __timeline_mark_lock(). (rev2) URL : https://patchwork.freedesktop.org/series/97082/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, e

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/fbc: More multi-FBC refactoring

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/fbc: More multi-FBC refactoring URL : https://patchwork.freedesktop.org/series/97821/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10987_full -> Patchwork_21810_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't disable interrupts and pretend a lock as been acquired in __timeline_mark_lock(). (rev2)

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915: Don't disable interrupts and pretend a lock as been acquired in __timeline_mark_lock(). (rev2) URL : https://patchwork.freedesktop.org/series/97082/ State : success == Summary == CI Bug Log - changes from CI_DRM_10988 -> Patchwork_21828 =

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Use correct context lock when callig clr_context_registered

2021-12-10 Thread Patchwork
== Series Details == Series: drm/i915/guc: Use correct context lock when callig clr_context_registered URL : https://patchwork.freedesktop.org/series/97823/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10987_full -> Patchwork_21811_full ==

[Intel-gfx] [PATCH 3/7] drm/gma: Remove calls to kmap()

2021-12-10 Thread ira . weiny
From: Ira Weiny kmap() is being deprecated and these instances are easy to convert to kmap_local_page(). Furthermore, in gma_crtc_cursor_set() use the memcpy_from_page() helper instead of an open coded use of kmap_local_page(). Signed-off-by: Ira Weiny --- drivers/gpu/drm/gma500/gma_display.c

[Intel-gfx] [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()

2021-12-10 Thread ira . weiny
From: Ira Weiny kmap() is being deprecated and these usages are all local to the thread so there is no reason kmap_local_page() can't be used. Replace kmap() calls with kmap_local_page(). Signed-off-by: Ira Weiny --- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 4 ++-- drivers/gpu/drm

[Intel-gfx] [PATCH 2/7] drm/amd: Replace kmap() with kmap_local_page()

2021-12-10 Thread ira . weiny
From: Ira Weiny kmap() is being deprecated. These maps are thread local and can be replaced with kmap_local_page(). Replace kmap() with kmap_local_page() Signed-off-by: Ira Weiny --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff -

[Intel-gfx] [PATCH 5/7] drm/msm: Alter comment to use kmap_local_page()

2021-12-10 Thread ira . weiny
From: Ira Weiny kmap() is being deprecated. So this comment could be misleading in the future. Change this comment to point to using kmap_local_page(). While here remove 'we' from the comment. Signed-off-by: Ira Weiny --- drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++-- 1 file changed, 2 inse

  1   2   >