[Intel-gfx] [PATCH] drm/i915: Fix coredump of perma-pinned vmas

2021-12-08 Thread Thomas Hellström
When updating the error capture code and introducing vma snapshots, we introduced code to hold the vma in memory while capturing it, calling i915_active_acquire_if_busy(). Now that function isn't relevant for perma-pinned vmas and caused important vmas to be dropped from the coredump. Like for exam

Re: [Intel-gfx] [PATCH] drm/i915/dg2: make GuC FW a requirement for Gen12 and beyond devices

2021-12-08 Thread Tvrtko Ursulin
On 07/12/2021 17:53, Adrian Larumbe wrote: Beginning with DG2, all successive devices will require GuC FW to be present and loaded at probe() time. This change alters error handling in the FW init and load functions so that the driver's probe() function will fail if GuC could not be loaded. Si

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Request RP0 before loading firmware

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915/guc: Request RP0 before loading firmware URL : https://patchwork.freedesktop.org/series/97682/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10970_full -> Patchwork_21778_full Summary -

Re: [Intel-gfx] [PATCH v9 2/8] drm/i915/ttm: add tt shmem backend

2021-12-08 Thread Tvrtko Ursulin
On 07/12/2021 14:05, Matthew Auld wrote: On 07/12/2021 13:10, Tvrtko Ursulin wrote: On 18/10/2021 10:10, Matthew Auld wrote: For cached objects we can allocate our pages directly in shmem. This should make it possible(in a later patch) to utilise the existing i915-gem shrinker code for such

Re: [Intel-gfx] [PATCH v9 2/8] drm/i915/ttm: add tt shmem backend

2021-12-08 Thread Thomas Hellström
On 12/8/21 09:30, Tvrtko Ursulin wrote: ... Apart from the code organisation questions, on the practical level - do you need writeback from the TTM backend or while I am proposing to remove it from the "legacy" paths, I can propose removing it from the TTM flow as well? Yeah, if that is

Re: [Intel-gfx] [PATCH linux-next] drm/i915/display: Remove the useless variable offset and its assignment

2021-12-08 Thread Jani Nikula
On Wed, 08 Dec 2021, cgel@gmail.com wrote: > From: luo penghao > > The existence of offset is meaningless, so it should be deleted. > > The clang_analyzer complains as follows: > > Value stored to 'offset' is never read > > Reported-by: Zeal Robot > Signed-off-by: luo penghao I've said the

Re: [Intel-gfx] [PATCH] drm/i915: Don't disable interrupts and pretend a lock as been acquired in __timeline_mark_lock().

2021-12-08 Thread Tvrtko Ursulin
On 18/11/2021 16:59, Sebastian Andrzej Siewior wrote: This is a revert of commits d67739268cf0e ("drm/i915/gt: Mark up the nested engine-pm timeline lock as irqsafe") 6c69a45445af9 ("drm/i915/gt: Mark context->active_count as protected by timeline->mutex") 6dcb85a0ad99 ("drm/i915: H

Re: [Intel-gfx] [PATCH v9 2/8] drm/i915/ttm: add tt shmem backend

2021-12-08 Thread Tvrtko Ursulin
On 08/12/2021 08:39, Thomas Hellström wrote: On 12/8/21 09:30, Tvrtko Ursulin wrote: ... Apart from the code organisation questions, on the practical level - do you need writeback from the TTM backend or while I am proposing to remove it from the "legacy" paths, I can propose removing it

Re: [Intel-gfx] [PATCH v9 2/8] drm/i915/ttm: add tt shmem backend

2021-12-08 Thread Thomas Hellström
On 12/8/21 10:24, Tvrtko Ursulin wrote: On 08/12/2021 08:39, Thomas Hellström wrote: On 12/8/21 09:30, Tvrtko Ursulin wrote: ... Apart from the code organisation questions, on the practical level - do you need writeback from the TTM backend or while I am proposing to remove it from the

Re: [Intel-gfx] [v3 0/3] Introduce Raptor Lake S

2021-12-08 Thread Tvrtko Ursulin
On 06/12/2021 04:29, Srivatsa, Anusha wrote: -Original Message- From: Tvrtko Ursulin Sent: Friday, December 3, 2021 2:57 PM To: Srivatsa, Anusha ; intel- g...@lists.freedesktop.org Cc: x...@kernel.org; dri-de...@lists.freedesktop.org; Ingo Molnar ; Borislav Petkov ; Dave Hansen ; Joona

Re: [Intel-gfx] [PATCH] drm/i915/gem: Use local pointer ttm for __i915_ttm_move

2021-12-08 Thread Intel
Hi, Jasmine, On 12/3/21 22:49, Jasmine Newsome wrote: To avoid confusion with deferencing possible null pointer bo->ttm, replace pointer bo->ttm with local pointer ttm in i915_ttm_move as ttm has checks for null before getting passed to __i915_ttm_move It's OK to use the local variable ttm her

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix coredump of perma-pinned vmas

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Fix coredump of perma-pinned vmas URL : https://patchwork.freedesktop.org/series/97709/ State : success == Summary == CI Bug Log - changes from CI_DRM_10971 -> Patchwork_21783 Summary --- **SUCC

Re: [Intel-gfx] [PATCH] drm/i915/ddi: add use_edp_hobl() and use_edp_low_vswing() helpers

2021-12-08 Thread Jani Nikula
On Fri, 03 Dec 2021, "Souza, Jose" wrote: > On Fri, 2021-12-03 at 15:13 +0200, Jani Nikula wrote: >> Localize HOBL and low vswing VBT lookups to a couple of small helpers, >> and get rid of a bunch of local variables. > > Reviewed-by: José Roberto de Souza Thanks, pushed. > >> >> Signed-off-by

Re: [Intel-gfx] [PATCH] drm/i915/snps: use div32 version of MPLLB word clock for UHBR

2021-12-08 Thread Jani Nikula
On Thu, 02 Dec 2021, Ville Syrjälä wrote: > On Thu, Dec 02, 2021 at 04:44:56PM +0200, Jani Nikula wrote: >> The mode set sequence for 128b/132b requires setting the div32 version >> of MPLLB clock. >> >> Bspec: 53880, 54128 > > Weird place for that information when all the other bits are listed >

[Intel-gfx] [PATCH 0/3] drm/i915: Sanity Check for device memory region

2021-12-08 Thread Ramalingam C
Changes for introducing the quick test on the device memory range and also a test of detailed validation for each addr of the range with read and write. Detailed testing is optionally enabled with a modparam i915.memtest=1 And third patch fixes the driver accessible stolen memory. Chris Wilson (

[Intel-gfx] [PATCH 2/3] drm/i915: Test all device memory on probing

2021-12-08 Thread Ramalingam C
From: Chris Wilson This extends the previous sanitychecking of device memory to read/write all the memory on the device during the device probe, ala memtest86, as an optional module parameter: i915.memtest=1. This is not expected to be fast, but a reasonably thorough verfification that the device

[Intel-gfx] [PATCH 1/3] drm/i915: Sanitycheck device iomem on probe

2021-12-08 Thread Ramalingam C
From: Chris Wilson As we setup the memory regions for the device, give each a quick test to verify that we can read and write to the full iomem range. This ensures that our physical addressing for the device's memory is correct, and some reassurance that the memory is functional. Signed-off-by:

[Intel-gfx] [PATCH 3/3] drm/i915: Exclude reserved stolen from driver use

2021-12-08 Thread Ramalingam C
From: Chris Wilson Remove the portion of stolen memory reserved for private use from driver access. Signed-off-by: Chris Wilson cc: Matthew Auld Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i

[Intel-gfx] [PATCH v3 0/2] drm/i915: trace display split

2021-12-08 Thread Jani Nikula
v3 of https://patchwork.freedesktop.org/series/97106/ Jani Nikula (2): drm/i915/trace: clean up boilerplate organization drm/i915/trace: split out display trace to a separate file drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/g4x_dp.c | 1 + dr

[Intel-gfx] [PATCH v3 1/2] drm/i915/trace: clean up boilerplate organization

2021-12-08 Thread Jani Nikula
Follow the style that seems to be prevalent in kernel for undef and define of TRACE_SYSTEM, TRACE_INCLUDE_PATH, and TRACE_INCLUDE_FILE. There should be no changes to tracepoints. v2: Keep TRACE_INCLUDE_PATH relative to define_trace.h (Chris) Cc: Ville Syrjälä Signed-off-by: Jani Nikula Reviewe

[Intel-gfx] [PATCH v3 2/2] drm/i915/trace: split out display trace to a separate file

2021-12-08 Thread Jani Nikula
Add display/intel_display_trace.[ch] for defining display tracepoints. The main goal is to reduce cross-includes between gem and display. It would be possible split up tracing even further, but that would lead to more boilerplate. We end up having to include intel_crtc.h in a few places because it

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Sanitycheck device iomem on probe

2021-12-08 Thread Matthew Auld
On 08/12/2021 10:20, Ramalingam C wrote: From: Chris Wilson As we setup the memory regions for the device, give each a quick test to verify that we can read and write to the full iomem range. This ensures that our physical addressing for the device's memory is correct, and some reassurance that

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Sanitycheck device iomem on probe

2021-12-08 Thread Ramalingam C
On 2021-12-08 at 11:12:07 +, Matthew Auld wrote: > On 08/12/2021 10:20, Ramalingam C wrote: > > From: Chris Wilson > > > > As we setup the memory regions for the device, give each a quick test to > > verify that we can read and write to the full iomem range. This ensures > > that our physical

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pmu: Wait longer for busyness data to be available from GuC

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Wait longer for busyness data to be available from GuC URL : https://patchwork.freedesktop.org/series/97696/ State : success == Summary == CI Bug Log - changes from CI_DRM_10970_full -> Patchwork_21780_full

Re: [Intel-gfx] [PATCH v2 09/16] drm/i915: Ensure i915_vma tests do not get -ENOSPC with the locking changes.

2021-12-08 Thread Matthew Auld
On Mon, 29 Nov 2021 at 13:58, Maarten Lankhorst wrote: > > Now that we require locking to evict, multiple vmas from the same object > might not be evicted. This is expected and required, because execbuf will > move to short-term pinning by using the lock only. This will cause these > tests to fail

Re: [Intel-gfx] [PATCH v2 09/16] drm/i915: Ensure i915_vma tests do not get -ENOSPC with the locking changes.

2021-12-08 Thread Matthew Auld
On Wed, 8 Dec 2021 at 11:49, Matthew Auld wrote: > > On Mon, 29 Nov 2021 at 13:58, Maarten Lankhorst > wrote: > > > > Now that we require locking to evict, multiple vmas from the same object > > might not be evicted. This is expected and required, because execbuf will > > move to short-term pinni

Re: [Intel-gfx] [PATCH v2 10/16] drm/i915: Make i915_gem_evict_vm work correctly for already locked objects

2021-12-08 Thread Matthew Auld
On Mon, 29 Nov 2021 at 13:58, Maarten Lankhorst wrote: > > i915_gem_execbuf will call i915_gem_evict_vm() after failing to pin > all objects in the first round. We are about to remove those short-term > pins, but even without those the objects are still locked. Add a special > case to allow i915_g

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add has_64k_pages flag

2021-12-08 Thread Intel
Hi, On 12/7/21 17:51, Ramalingam C wrote: From: Stuart Summers Add a new platform flag, has_64k_pages, for platforms supporting base page sizes of 64k. Signed-off-by: Stuart Summers Signed-off-by: Ramalingam C Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_drv.h | 2

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev7)

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev7) URL : https://patchwork.freedesktop.org/series/96855/ State : success == Summary == CI Bug Log - changes from CI_DRM_10970_full -> Patchwork_21782_full ==

Re: [Intel-gfx] [PATCH 2/4] drm/i915/xehpsdv: set min page-size to 64K

2021-12-08 Thread Intel
On 12/7/21 17:51, Ramalingam C wrote: From: Matthew Auld LMEM should be allocated at 64K granularity, since 4K page support will eventually be dropped for LMEM when using the PPGTT. Signed-off-by: Matthew Auld Signed-off-by: Stuart Summers Signed-off-by: Ramalingam C Cc: Joonas Lahtinen

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add has_64k_pages flag

2021-12-08 Thread Matthew Auld
On Wed, 8 Dec 2021 at 12:43, Thomas Hellström (Intel) wrote: > > Hi, > > On 12/7/21 17:51, Ramalingam C wrote: > > From: Stuart Summers > > > > Add a new platform flag, has_64k_pages, for platforms supporting > > base page sizes of 64k. > > > > Signed-off-by: Stuart Summers > > Signed-off-by: Ra

Re: [Intel-gfx] [PATCH linux-next] drm/i915/display: Delete redundant post_mask assignment

2021-12-08 Thread Ville Syrjälä
On Wed, Dec 08, 2021 at 07:46:19AM +, cgel@gmail.com wrote: > From: luo penghao > > This value will be overwritten by the following if statement, even > if the if is not executed, the value will not be used > > The clang_analyzer complains as follows: > > Value stored to 'port_mask' is

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Sanity Check for device memory region

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Sanity Check for device memory region URL : https://patchwork.freedesktop.org/series/97715/ State : warning == Summary == $ dim checkpatch origin/drm-tip a4fb1d110926 drm/i915: Sanitycheck device iomem on probe -:70: WARNING:VSPRINTF_SPECIFIER_PX: Using v

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Sanity Check for device memory region

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Sanity Check for device memory region URL : https://patchwork.freedesktop.org/series/97715/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v2 06/16] drm/i915: Ensure gem_contexts selftests work with unbind changes.

2021-12-08 Thread Maarten Lankhorst
On 07-12-2021 11:44, Matthew Auld wrote: > On Mon, 29 Nov 2021 at 13:57, Maarten Lankhorst > wrote: >> In the next commit, we don't evict when refcount = 0. >> >> igt_vm_isolation() continuously tries to pin/unpin at same address, >> but also calls put() on the object, which means the object may n

Re: [Intel-gfx] [PATCH linux-next] drm/i915/display: Delete redundant post_mask assignment

2021-12-08 Thread Jani Nikula
On Wed, 08 Dec 2021, Ville Syrjälä wrote: > On Wed, Dec 08, 2021 at 07:46:19AM +, cgel@gmail.com wrote: >> From: luo penghao >> >> This value will be overwritten by the following if statement, even >> if the if is not executed, the value will not be used >> >> The clang_analyzer complai

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add has_64k_pages flag

2021-12-08 Thread Intel
On 12/8/21 13:59, Matthew Auld wrote: On Wed, 8 Dec 2021 at 12:43, Thomas Hellström (Intel) wrote: Hi, On 12/7/21 17:51, Ramalingam C wrote: From: Stuart Summers Add a new platform flag, has_64k_pages, for platforms supporting base page sizes of 64k. Signed-off-by: Stuart Summers Signed

Re: [Intel-gfx] [PATCH 3/4] drm/i915/gtt/xehpsdv: move scratch page to system memory

2021-12-08 Thread Thomas Hellström
On 12/7/21 17:51, Ramalingam C wrote: From: Matthew Auld On some platforms the hw has dropped support for 4K GTT pages when dealing with LMEM, and due to the design of 64K GTT pages in the hw, we can only mark the *entire* page-table as operating in 64K GTT mode, since the enable bit is still

Re: [Intel-gfx] [PATCH v2 07/16] drm/i915: Take trylock during eviction, v2.

2021-12-08 Thread Maarten Lankhorst
On 07-12-2021 12:01, Matthew Auld wrote: > On Mon, 29 Nov 2021 at 13:57, Maarten Lankhorst > wrote: >> Now that freeing objects takes the object lock when destroying the >> backing pages, we can confidently take the object lock even for dead >> objects. > That looks to be a future patch, at least

Re: [Intel-gfx] [PATCH 4/4] drm/i915: enforce min page size for scratch

2021-12-08 Thread Thomas Hellström
On 12/7/21 17:51, Ramalingam C wrote: From: Matthew Auld If the device needs 64K minimum GTT pages for device local-memory, like on XEHPSDV, then we need to fail the allocation if we can't meet it, instead of falling back to 4K pages, otherwise we can't safely support the insertion of device

Re: [Intel-gfx] [PATCH v2 10/16] drm/i915: Make i915_gem_evict_vm work correctly for already locked objects

2021-12-08 Thread Maarten Lankhorst
On 08-12-2021 13:07, Matthew Auld wrote: > On Mon, 29 Nov 2021 at 13:58, Maarten Lankhorst > wrote: >> i915_gem_execbuf will call i915_gem_evict_vm() after failing to pin >> all objects in the first round. We are about to remove those short-term >> pins, but even without those the objects are stil

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Sanity Check for device memory region

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Sanity Check for device memory region URL : https://patchwork.freedesktop.org/series/97715/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10973 -> Patchwork_21784 Summary --- **

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: trace display split

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: trace display split URL : https://patchwork.freedesktop.org/series/97721/ State : warning == Summary == $ dim checkpatch origin/drm-tip 25fd3bfdc326 drm/i915/trace: clean up boilerplate organization b994ae8af368 drm/i915/trace: split out display trace to

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: trace display split

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: trace display split URL : https://patchwork.freedesktop.org/series/97721/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH linux-next] drm/i915/display: Delete redundant post_mask assignment

2021-12-08 Thread cgel . zte
From: luo penghao This value will be overwritten by the following if statement, even if the if is not executed, the value will not be used The clang_analyzer complains as follows: Value stored to 'port_mask' is never read Reported-by: Zeal Robot Signed-off-by: luo penghao --- drivers/gpu/dr

[Intel-gfx] [PATCH linux-next] drm/i915/display: Remove the useless variable offset and its assignment

2021-12-08 Thread cgel . zte
From: luo penghao The existence of offset is meaningless, so it should be deleted. The clang_analyzer complains as follows: Value stored to 'offset' is never read Reported-by: Zeal Robot Signed-off-by: luo penghao --- drivers/gpu/drm/i915/display/i9xx_plane.c | 8 1 file changed, 4

[Intel-gfx] [PATCH 0/4] drm/i915: Basic enabling of 64k page support

2021-12-08 Thread Ramalingam C
Preparational patches for 64k page support. Matthew Auld (3): drm/i915/xehpsdv: set min page-size to 64K drm/i915/gtt/xehpsdv: move scratch page to system memory drm/i915: enforce min page size for scratch Stuart Summers (1): drm/i915: Add has_64k_pages flag drivers/gpu/drm/i915/gem/i91

[Intel-gfx] [PATCH 1/4] drm/i915: Add has_64k_pages flag

2021-12-08 Thread Ramalingam C
From: Stuart Summers Add a new platform flag, has_64k_pages, to mark the requirement of 64K GTT page sizes or larger for device local memory access. Also implies that we require or at least support the compact PT layout for the ppGTT when using 64K GTT pages. v2: More explanation for the flag [

[Intel-gfx] [PATCH 2/4] drm/i915/xehpsdv: set min page-size to 64K

2021-12-08 Thread Ramalingam C
From: Matthew Auld LMEM should be allocated at 64K granularity, since 4K page support will eventually be dropped for LMEM when using the PPGTT. Signed-off-by: Matthew Auld Signed-off-by: Stuart Summers Signed-off-by: Ramalingam C Cc: Joonas Lahtinen Cc: Rodrigo Vivi Reviewed-by: Lucas De Ma

[Intel-gfx] [PATCH 3/4] drm/i915/gtt/xehpsdv: move scratch page to system memory

2021-12-08 Thread Ramalingam C
From: Matthew Auld On some platforms the hw has dropped support for 4K GTT pages when dealing with LMEM, and due to the design of 64K GTT pages in the hw, we can only mark the *entire* page-table as operating in 64K GTT mode, since the enable bit is still on the pde, and not the pte. And since we

[Intel-gfx] [PATCH 4/4] drm/i915: enforce min page size for scratch

2021-12-08 Thread Ramalingam C
From: Matthew Auld If the device needs 64K minimum GTT pages for device local-memory, like on XEHPSDV, then we need to fail the allocation if we can't meet it, instead of falling back to 4K pages, otherwise we can't safely support the insertion of device local-memory pages for this vm, since the

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix coredump of perma-pinned vmas

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Fix coredump of perma-pinned vmas URL : https://patchwork.freedesktop.org/series/97709/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10971_full -> Patchwork_21783_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: trace display split

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: trace display split URL : https://patchwork.freedesktop.org/series/97721/ State : success == Summary == CI Bug Log - changes from CI_DRM_10973 -> Patchwork_21785 Summary --- **SUCCESS** No re

Re: [Intel-gfx] [PATCH 2/4] drm/i915/xehpsdv: set min page-size to 64K

2021-12-08 Thread Matthew Auld
On Wed, 8 Dec 2021 at 14:16, Ramalingam C wrote: > > From: Matthew Auld > > LMEM should be allocated at 64K granularity, since 4K page support will > eventually be dropped for LMEM when using the PPGTT. s/will eventually be dropped/has been dropped/ as per Thomas' suggestion. > > Signed-off-by:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Delete redundant post_mask assignment

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915/display: Delete redundant post_mask assignment URL : https://patchwork.freedesktop.org/series/97723/ State : success == Summary == CI Bug Log - changes from CI_DRM_10973 -> Patchwork_21786 Summary -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Remove the useless variable offset and its assignment

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915/display: Remove the useless variable offset and its assignment URL : https://patchwork.freedesktop.org/series/97724/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4c9a41e79dcc drm/i915/display: Remove the useless variable offset and its as

[Intel-gfx] [PATCH 0/3] drm/i915: Sanity Check for device memory region

2021-12-08 Thread Ramalingam C
Changes for introducing the quick test on the device memory range and also a test of detailed validation for each addr of the range with read and write. Detailed testing is optionally enabled with a modparam i915.memtest=1 And third patch fixes the driver accessible stolen memory. v2: Adding a w

[Intel-gfx] [PATCH 1/3] drm/i915: Exclude reserved stolen from driver use

2021-12-08 Thread Ramalingam C
From: Chris Wilson Remove the portion of stolen memory reserved for private use from driver access. Signed-off-by: Chris Wilson cc: Matthew Auld Signed-off-by: Ramalingam C Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 3 +++ 1 file changed, 3 insertions(+) dif

[Intel-gfx] [PATCH 2/3] drm/i915: Sanitycheck device iomem on probe

2021-12-08 Thread Ramalingam C
From: Chris Wilson As we setup the memory regions for the device, give each a quick test to verify that we can read and write to the full iomem range. This ensures that our physical addressing for the device's memory is correct, and some reassurance that the memory is functional. v2: wrapper for

[Intel-gfx] [PATCH 3/3] drm/i915: Test all device memory on probing

2021-12-08 Thread Ramalingam C
From: Chris Wilson This extends the previous sanitychecking of device memory to read/write all the memory on the device during the device probe, ala memtest86, as an optional module parameter: i915.memtest=1. This is not expected to be fast, but a reasonably thorough verfification that the device

[Intel-gfx] [PATCH] drm/i915: Remove zombie async flip vt-d w/a

2021-12-08 Thread Ville Syrjala
From: Ville Syrjälä This async flip vt-d w/a was moved to a different place in commit 7d396cacaea6 ("drm/i195: Make the async flip VT-d workaround dynamic") but the drm-intel-fixes cherry-pick commit b2d73debfdc1 ("drm/i915: Extend the async flip VT-d w/a to skl/bxt") resurrected the original cod

Re: [Intel-gfx] [PATCH 2/4] drm/i915/xehpsdv: set min page-size to 64K

2021-12-08 Thread Thomas Hellström
On 12/8/21 15:34, Matthew Auld wrote: On Wed, 8 Dec 2021 at 14:16, Ramalingam C wrote: From: Matthew Auld LMEM should be allocated at 64K granularity, since 4K page support will eventually be dropped for LMEM when using the PPGTT. s/will eventually be dropped/has been dropped/ as per Thoma

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Exclude reserved stolen from driver use

2021-12-08 Thread Andi Shyti
On Wed, Dec 08, 2021 at 08:27:58PM +0530, Ramalingam C wrote: > From: Chris Wilson > > Remove the portion of stolen memory reserved for private use from driver > access. > > Signed-off-by: Chris Wilson > cc: Matthew Auld > Signed-off-by: Ramalingam C > Reviewed-by: Matthew Auld > --- > driv

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Exclude reserved stolen from driver use

2021-12-08 Thread Andi Shyti
Hi Ram, On Wed, Dec 08, 2021 at 08:27:58PM +0530, Ramalingam C wrote: > From: Chris Wilson > > Remove the portion of stolen memory reserved for private use from driver > access. > > Signed-off-by: Chris Wilson > cc: Matthew Auld > Signed-off-by: Ramalingam C > Reviewed-by: Matthew Auld Rev

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Sanitycheck device iomem on probe

2021-12-08 Thread Andi Shyti
Hi Ram, > +static int intel_memory_region_memtest(struct intel_memory_region *mem, > +void *caller) > +{ > + struct drm_i915_private *i915 = mem->i915; > + int err = 0; > + > + if (!mem->io_start) > + return 0; > + > + if (IS_ENABLED(

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Test all device memory on probing

2021-12-08 Thread Andi Shyti
Hi Ram and Chris, > param(char *, guc_firmware_path, NULL, 0400) \ > param(char *, huc_firmware_path, NULL, 0400) \ > param(char *, dmc_firmware_path, NULL, 0400) \ > + param(bool, memtest, false, 0400) \ this partially answers my previous question... [...] > - if (IS_

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Basic enabling of 64k page support

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Basic enabling of 64k page support URL : https://patchwork.freedesktop.org/series/97725/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH 0/3] drm/i915: Sanity Check for device memory region

2021-12-08 Thread Ramalingam C
Changes for introducing the quick test on the device memory range and also a test of detailed validation for each addr of the range with read and write. Detailed testing is optionally enabled with a modparam i915.memtest=1 And third patch fixes the driver accessible stolen memory. v2: Adding a w

[Intel-gfx] [PATCH 1/3] drm/i915: Exclude reserved stolen from driver use

2021-12-08 Thread Ramalingam C
From: Chris Wilson Remove the portion of stolen memory reserved for private use from driver access. Signed-off-by: Chris Wilson cc: Matthew Auld Signed-off-by: Ramalingam C Reviewed-by: Matthew Auld Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 3 +++ 1 file chan

[Intel-gfx] [PATCH 2/3] drm/i915: Sanitycheck device iomem on probe

2021-12-08 Thread Ramalingam C
From: Chris Wilson As we setup the memory regions for the device, give each a quick test to verify that we can read and write to the full iomem range. This ensures that our physical addressing for the device's memory is correct, and some reassurance that the memory is functional. v2: wrapper for

[Intel-gfx] [PATCH 3/3] drm/i915: Test all device memory on probing

2021-12-08 Thread Ramalingam C
From: Chris Wilson This extends the previous sanitychecking of device memory to read/write all the memory on the device during the device probe, ala memtest86, as an optional module parameter: i915.memtest=1. This is not expected to be fast, but a reasonably thorough verfification that the device

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Remove the useless variable offset and its assignment

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915/display: Remove the useless variable offset and its assignment URL : https://patchwork.freedesktop.org/series/97724/ State : success == Summary == CI Bug Log - changes from CI_DRM_10973 -> Patchwork_21787 ===

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Sanitycheck device iomem on probe

2021-12-08 Thread Ramalingam C
On 2021-12-08 at 17:23:26 +0200, Andi Shyti wrote: > Hi Ram, > > > +static int intel_memory_region_memtest(struct intel_memory_region *mem, > > + void *caller) > > +{ > > + struct drm_i915_private *i915 = mem->i915; > > + int err = 0; > > + > > + if (!mem->io

[Intel-gfx] [PATCH 2/4] drm/i915/xehpsdv: set min page-size to 64K

2021-12-08 Thread Ramalingam C
From: Matthew Auld Conditionally allocate LMEM with 64K granularity, since 4K page support for LMEM will be dropped on some platforms when using the PPGTT. v2: updated commit msg [Thomas] Signed-off-by: Matthew Auld Signed-off-by: Stuart Summers Signed-off-by: Ramalingam C Cc: Joonas Lahti

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/trace: split out display trace to a separate file

2021-12-08 Thread Lucas De Marchi
On Wed, Dec 08, 2021 at 01:05:17PM +0200, Jani Nikula wrote: Add display/intel_display_trace.[ch] for defining display tracepoints. The main goal is to reduce cross-includes between gem and display. It would be possible split up tracing even further, but that would lead to more boilerplate. We e

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Change DMC FW size on ADL-P

2021-12-08 Thread Jani Nikula
On Mon, 06 Dec 2021, Madhumitha Tolakanahalli Pradeep wrote: > Increase the size of DMC on ADL-P to account for support of > new features in the current/upcoming DMC versions. > > Signed-off-by: Madhumitha Tolakanahalli Pradeep > > --- > drivers/gpu/drm/i915/display/intel_dmc.c | 4 +++- > 1 f

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add has_64k_pages flag

2021-12-08 Thread Andi Shyti
Hi Ram, Reviewed-by: Andi Shyti but just two notes on the patchstyle, no need to resend: 1. would be nice to have [PATCH v2...] otherwise it's difficult to see if I'm reading the correct version. (I don't see the difficulty 'git format-patch -v 2...') > Add a new platform flag, has_64k_p

Re: [Intel-gfx] [PATCH 2/4] drm/i915/xehpsdv: set min page-size to 64K

2021-12-08 Thread Andi Shyti
Hi Ram, On Wed, Dec 08, 2021 at 07:46:11PM +0530, Ramalingam C wrote: > From: Matthew Auld > > LMEM should be allocated at 64K granularity, since 4K page support will > eventually be dropped for LMEM when using the PPGTT. > > Signed-off-by: Matthew Auld > Signed-off-by: Stuart Summers > Signe

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Wait longer for busyness data to be available from GuC

2021-12-08 Thread Jani Nikula
On Tue, 07 Dec 2021, Umesh Nerlige Ramappa wrote: > live_engine_busy_stats waits for busyness to start ticking before > sampling busyness for the test sample duration. The wait accesses an > MMIO register and the uncore call to read it takes up to 3 ms in the > worst case. This can result in the

Re: [Intel-gfx] [PATCH 3/4] drm/i915/gtt/xehpsdv: move scratch page to system memory

2021-12-08 Thread Andi Shyti
Hi Ram and Matt, > On some platforms the hw has dropped support for 4K GTT pages when > dealing with LMEM, and due to the design of 64K GTT pages in the hw, we > can only mark the *entire* page-table as operating in 64K GTT mode, > since the enable bit is still on the pde, and not the pte. And sin

Re: [Intel-gfx] [PATCH 4/4] drm/i915: enforce min page size for scratch

2021-12-08 Thread Andi Shyti
Hi Matt and Ram, On Wed, Dec 08, 2021 at 07:46:13PM +0530, Ramalingam C wrote: > From: Matthew Auld > > If the device needs 64K minimum GTT pages for device local-memory, > like on XEHPSDV, then we need to fail the allocation if we can't > meet it, instead of falling back to 4K pages, otherwise

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Basic enabling of 64k page support

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Basic enabling of 64k page support URL : https://patchwork.freedesktop.org/series/97725/ State : success == Summary == CI Bug Log - changes from CI_DRM_10973 -> Patchwork_21788 Summary --- **SUC

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/trace: split out display trace to a separate file

2021-12-08 Thread Jani Nikula
On Wed, 08 Dec 2021, Lucas De Marchi wrote: > On Wed, Dec 08, 2021 at 01:05:17PM +0200, Jani Nikula wrote: >>Add display/intel_display_trace.[ch] for defining display >>tracepoints. The main goal is to reduce cross-includes between gem and >>display. It would be possible split up tracing even furt

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove zombie async flip vt-d w/a

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Remove zombie async flip vt-d w/a URL : https://patchwork.freedesktop.org/series/97729/ State : success == Summary == CI Bug Log - changes from CI_DRM_10973 -> Patchwork_21789 Summary --- **SUCC

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pmu: Fix wakeref leak in PMU busyness during reset (rev3)

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Fix wakeref leak in PMU busyness during reset (rev3) URL : https://patchwork.freedesktop.org/series/97635/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10970_full -> Patchwork_21776_full ==

Re: [Intel-gfx] [PATCH] drm/i915/dg2: make GuC FW a requirement for Gen12 and beyond devices

2021-12-08 Thread Robert Beckett
On 07/12/2021 23:15, John Harrison wrote: On 12/7/2021 09:53, Adrian Larumbe wrote: Beginning with DG2, all successive devices will require GuC FW to be present and loaded at probe() time. This change alters error handling in the FW init and load functions so that the driver's probe() functio

Re: [Intel-gfx] i915 Updates: ADL-P DMC v2.14

2021-12-08 Thread Srivatsa, Anusha
Ping :) Can these updates be merged to linux-firmware? Thanks, Anusha > -Original Message- > From: Tolakanahalli Pradeep, Madhumitha > > Sent: Thursday, December 2, 2021 6:48 AM > To: Hutchings, Ben ; intel-gfx@lists.freedesktop.org; > k...@mcmartin.ca; jwbo...@kernel.org > Cc: Srivats

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: trace display split

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: trace display split URL : https://patchwork.freedesktop.org/series/97721/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10973_full -> Patchwork_21785_full Summary --- **FAILURE*

Re: [Intel-gfx] [RFC 6/7] drm/i915/guc: Copy new GuC error capture logs upon G2H notification.

2021-12-08 Thread Teres Alexis, Alan Previn
After chatting offline with Matt, it became apparent that i somehow missed the fact that the ctb processing handler was already in a work queue. That said, Matt is correct, i dont need to create a work queue to extract that capture log into the interim-store. That would eliminate the race condition

Re: [Intel-gfx] [RFC 1/7] drm/i915/guc: Add basic support for error capture lists

2021-12-08 Thread Teres Alexis, Alan Previn
I missed responding to this. Thanks for the review Michal - will fix them on next rev. ...alan On Tue, 2021-11-23 at 22:12 +0100, Michal Wajdeczko wrote: > > On 23.11.2021 00:03, Alan Previn wrote: > > From: John Harrison > ... > > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Wait longer for busyness data to be available from GuC

2021-12-08 Thread Matthew Brost
On Tue, Dec 07, 2021 at 06:15:12PM -0800, Umesh Nerlige Ramappa wrote: > live_engine_busy_stats waits for busyness to start ticking before > sampling busyness for the test sample duration. The wait accesses an > MMIO register and the uncore call to read it takes up to 3 ms in the > worst case. This

[Intel-gfx] [PATCH] drm/i915/pmu: Wait longer for busyness data to be available from GuC

2021-12-08 Thread Umesh Nerlige Ramappa
live_engine_busy_stats waits for busyness to start ticking before sampling busyness for the test sample duration. The wait accesses an MMIO register and the uncore call to read it takes up to 3 ms in the worst case. This can result in the wait timing out since the MMIO read itself consumes up the t

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pmu: Fix wakeref leak in PMU busyness during reset (rev3)

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Fix wakeref leak in PMU busyness during reset (rev3) URL : https://patchwork.freedesktop.org/series/97635/ State : success == Summary == CI Bug Log - changes from CI_DRM_10970_full -> Patchwork_21776_full ==

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Delete redundant post_mask assignment

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915/display: Delete redundant post_mask assignment URL : https://patchwork.freedesktop.org/series/97723/ State : success == Summary == CI Bug Log - changes from CI_DRM_10973_full -> Patchwork_21786_full Sum

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix coredump of perma-pinned vmas (rev2)

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Fix coredump of perma-pinned vmas (rev2) URL : https://patchwork.freedesktop.org/series/97709/ State : success == Summary == CI Bug Log - changes from CI_DRM_10975 -> Patchwork_21790 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Remove the useless variable offset and its assignment

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915/display: Remove the useless variable offset and its assignment URL : https://patchwork.freedesktop.org/series/97724/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10973_full -> Patchwork_21787_full =

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Sanity Check for device memory region (rev3)

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Sanity Check for device memory region (rev3) URL : https://patchwork.freedesktop.org/series/97715/ State : warning == Summary == $ dim checkpatch origin/drm-tip d2fc59f489d3 drm/i915: Exclude reserved stolen from driver use 4e5c58d3e7b8 drm/i915: Sanitych

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Sanity Check for device memory region (rev3)

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Sanity Check for device memory region (rev3) URL : https://patchwork.freedesktop.org/series/97715/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Sanity Check for device memory region (rev3)

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Sanity Check for device memory region (rev3) URL : https://patchwork.freedesktop.org/series/97715/ State : success == Summary == CI Bug Log - changes from CI_DRM_10975 -> Patchwork_21791 Summary --

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Basic enabling of 64k page support (rev2)

2021-12-08 Thread Patchwork
== Series Details == Series: drm/i915: Basic enabling of 64k page support (rev2) URL : https://patchwork.freedesktop.org/series/97725/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

  1   2   >