Re: [Intel-gfx] [PATCH 25/33] drm/i915/guc: Support request cancellation

2021-10-05 Thread Sebastian Andrzej Siewior
On 2021-07-27 12:15:59 [-0700], Daniele Ceraolo Spurio wrote: > On 7/26/2021 5:23 PM, Matthew Brost wrote: > > This adds GuC backend support for i915_request_cancel(), which in turn > > makes CONFIG_DRM_I915_REQUEST_TIMEOUT work. > > > Reviewed-by: Daniele Ceraolo Spurio I have a few instances o

Re: [Intel-gfx] [PATCH] drm/i915: remove IS_ACTIVE

2021-10-05 Thread Lucas De Marchi
On Tue, Oct 05, 2021 at 09:19:39AM +0300, Dan Carpenter wrote: On Mon, Oct 04, 2021 at 01:52:27PM -0700, Lucas De Marchi wrote: Cc'ing Dan Carpenter On Fri, Oct 01, 2021 at 12:57:13PM +0300, Jani Nikula wrote: > On Fri, 01 Oct 2021, Chris Wilson wrote: > > Quoting Lucas De Marchi (2021-10-01 0

[Intel-gfx] [PATCH] drm/i915/display: Remove check for low voltage sku for max dp source rate

2021-10-05 Thread Ankit Nautiyal
The low voltage sku check can be ignored as OEMs need to consider that when designing the board and then put any limits in VBT. Same is now changed in Bspec (53720). Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 32 +++-- 1 file changed, 3 inser

Re: [Intel-gfx] refactor the i915 GVT support

2021-10-05 Thread Wang, Zhi A
Hi folks: It seems we haven't reached a possible solution of this refactor patch series. The current patch series needs to be re-worked because of the module/symbol dependency(The root cause has been discussed in another email). I have to get them off from our gvt-next repo so that we can cont

Re: [Intel-gfx] [PATCH 08/28] dma-buf: use the new iterator in dma_buf_debug_show

2021-10-05 Thread Tvrtko Ursulin
On 01/10/2021 11:05, Christian König wrote: Simplifying the code a bit. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 61e

Re: [Intel-gfx] [PATCH 09/28] dma-buf: use the new iterator in dma_resv_poll

2021-10-05 Thread Tvrtko Ursulin
On 01/10/2021 11:05, Christian König wrote: Simplify the code a bit. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Increase DRM_OBJECT_MAX_PROPERTY by 18.

2021-10-05 Thread Patchwork
== Series Details == Series: drm: Increase DRM_OBJECT_MAX_PROPERTY by 18. URL : https://patchwork.freedesktop.org/series/95440/ State : warning == Summary == $ dim checkpatch origin/drm-tip 275051930b84 drm: Increase DRM_OBJECT_MAX_PROPERTY by 18. -:9: WARNING:COMMIT_LOG_LONG_LINE: Possible un

Re: [Intel-gfx] [PATCH 23/28] drm: use new iterator in drm_gem_fence_array_add_implicit v3

2021-10-05 Thread Tvrtko Ursulin
On 01/10/2021 11:06, Christian König wrote: Simplifying the code a bit. v2: add missing rcu_read_lock()/unlock() v3: switch to locked version Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) dif

Re: [Intel-gfx] [PATCH 24/28] drm: use new iterator in drm_gem_plane_helper_prepare_fb

2021-10-05 Thread Tvrtko Ursulin
On 01/10/2021 11:06, Christian König wrote: Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_atomic_helper.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

Re: [Intel-gfx] [PATCH 12/26] drm/i915/guc: Implement multi-lrc submission

2021-10-05 Thread kernel test robot
the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matthew-Brost/Parallel-submission-aka-multi-bb-execbuf/20211005-061424 b

[Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2021-10-05 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: include/linux/dma-buf.h:456: warning: Function parameter or member 'cb_in' not described in 'dma_buf' include/linux/dma-buf.h:456: warning: Function parameter or member 'cb_out' not described in

Re: [Intel-gfx] [PATCH] drm/i915/display: Remove check for low voltage sku for max dp source rate

2021-10-05 Thread Jani Nikula
On Tue, 05 Oct 2021, Ankit Nautiyal wrote: > The low voltage sku check can be ignored as OEMs need to consider that > when designing the board and then put any limits in VBT. "can" or "must"? VBT has been notoriously buggy over the years, and we need to safeguard against that. Are there any case

[Intel-gfx] [PATCH 1/2] drm/dp: add drm_dp_phy_name() for getting DP PHY name

2021-10-05 Thread Jani Nikula
Add a helper for getting the DP PHY name. In the interest of caller simplicity and to avoid allocations and passing in of buffers, duplicate the const strings to return. It's a minor penalty to pay for simplicity in all the call sites. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gp

[Intel-gfx] [PATCH 2/2] drm/i915/dp: use drm_dp_phy_name() for logging

2021-10-05 Thread Jani Nikula
Drop the local intel_dp_phy_name() function, and replace with drm_dp_phy_name(). This lets us drop a number of local buffers. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_dp_link_training.c | 24 --- 1 file changed, 4 insertions(+), 20 deletions(-)

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Increase DRM_OBJECT_MAX_PROPERTY by 18.

2021-10-05 Thread Patchwork
== Series Details == Series: drm: Increase DRM_OBJECT_MAX_PROPERTY by 18. URL : https://patchwork.freedesktop.org/series/95440/ State : success == Summary == CI Bug Log - changes from CI_DRM_10681 -> Patchwork_21243 Summary --- **SUC

Re: [Intel-gfx] [PATCH 1/2] drm/dp: add drm_dp_phy_name() for getting DP PHY name

2021-10-05 Thread Ville Syrjälä
On Tue, Oct 05, 2021 at 11:10:52AM +0300, Jani Nikula wrote: > Add a helper for getting the DP PHY name. In the interest of caller > simplicity and to avoid allocations and passing in of buffers, duplicate > the const strings to return. It's a minor penalty to pay for simplicity > in all the call s

Re: [Intel-gfx] [PATCH 21/26] drm/i915: Multi-BB execbuf

2021-10-05 Thread kernel test robot
the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matthew-Brost/Parallel-submission-aka-multi-bb-execbuf/20211005-061424 b

Re: [Intel-gfx] [PATCH 1/2] drm/dp: add drm_dp_phy_name() for getting DP PHY name

2021-10-05 Thread Jani Nikula
On Tue, 05 Oct 2021, Ville Syrjälä wrote: > On Tue, Oct 05, 2021 at 11:10:52AM +0300, Jani Nikula wrote: >> Add a helper for getting the DP PHY name. In the interest of caller >> simplicity and to avoid allocations and passing in of buffers, duplicate >> the const strings to return. It's a minor p

Re: [Intel-gfx] [PATCH 09/28] dma-buf: use the new iterator in dma_resv_poll

2021-10-05 Thread Tvrtko Ursulin
On 05/10/2021 09:16, Christian König wrote: Am 05.10.21 um 09:44 schrieb Tvrtko Ursulin: On 01/10/2021 11:05, Christian König wrote: Simplify the code a bit. Signed-off-by: Christian König ---   drivers/dma-buf/dma-buf.c | 36 ++--   1 file changed, 6 inserti

Re: [Intel-gfx] [vfio:next 33/38] drivers/gpu/drm/i915/i915_pci.c:975:2: warning: missing field 'override_only' initializer

2021-10-05 Thread Jani Nikula
On Fri, 01 Oct 2021, Jason Gunthorpe wrote: > On Fri, Oct 01, 2021 at 02:04:04PM +0300, Jani Nikula wrote: >> On Fri, 27 Aug 2021, Jason Gunthorpe wrote: >> > On Fri, Aug 27, 2021 at 03:12:36PM +, kernel test robot wrote: >> >> tree: https://github.com/awilliam/linux-vfio.git next >> >> hea

Re: [Intel-gfx] [PATCH] drm/i915: Fix bug in user proto-context creation that leaked contexts

2021-10-05 Thread Tvrtko Ursulin
On 01/10/2021 16:48, Matthew Brost wrote: On Fri, Oct 01, 2021 at 09:40:19AM +0100, Tvrtko Ursulin wrote: + Daniel as reviewer and maybe merge, avoid falling through cracks at least. Ty, working on push rights myself. I ended up pushing it myself to avoid having a potential crash in the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Increase DRM_OBJECT_MAX_PROPERTY by 18.

2021-10-05 Thread Patchwork
== Series Details == Series: drm: Increase DRM_OBJECT_MAX_PROPERTY by 18. URL : https://patchwork.freedesktop.org/series/95440/ State : success == Summary == CI Bug Log - changes from CI_DRM_10681_full -> Patchwork_21243_full Summary --

Re: [Intel-gfx] [PATCH 25/33] drm/i915/guc: Support request cancellation

2021-10-05 Thread Tvrtko Ursulin
On 05/10/2021 08:06, Sebastian Andrzej Siewior wrote: On 2021-07-27 12:15:59 [-0700], Daniele Ceraolo Spurio wrote: On 7/26/2021 5:23 PM, Matthew Brost wrote: This adds GuC backend support for i915_request_cancel(), which in turn makes CONFIG_DRM_I915_REQUEST_TIMEOUT work. Reviewed-by: Dan

Re: [Intel-gfx] [PATCH] drm/i915/display: Remove check for low voltage sku for max dp source rate

2021-10-05 Thread Nautiyal, Ankit K
On 10/5/2021 1:34 PM, Jani Nikula wrote: On Tue, 05 Oct 2021, Ankit Nautiyal wrote: The low voltage sku check can be ignored as OEMs need to consider that when designing the board and then put any limits in VBT. "can" or "must"? VBT has been notoriously buggy over the years, and we need to sa

Re: [Intel-gfx] [PATCH] drm/i915/display: Remove check for low voltage sku for max dp source rate

2021-10-05 Thread Jani Nikula
Cc: Imre, I think you were involved in adding the checks. BR, Jani. On Tue, 05 Oct 2021, "Nautiyal, Ankit K" wrote: > On 10/5/2021 1:34 PM, Jani Nikula wrote: >> On Tue, 05 Oct 2021, Ankit Nautiyal wrote: >>> The low voltage sku check can be ignored as OEMs need to consider that >>> when desi

Re: [Intel-gfx] [PATCH 12/26] drm/i915/guc: Implement multi-lrc submission

2021-10-05 Thread kernel test robot
wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matthew-Brost/Parallel-submission-aka-multi-bb-execbuf/20211005-061424 b

Re: [Intel-gfx] [PATCH 24/28] drm: use new iterator in drm_gem_plane_helper_prepare_fb

2021-10-05 Thread Tvrtko Ursulin
On 05/10/2021 11:27, Christian König wrote: Am 05.10.21 um 09:53 schrieb Tvrtko Ursulin: On 01/10/2021 11:06, Christian König wrote: Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König ---   drivers/gpu/drm/drm_gem_atomi

Re: [Intel-gfx] [PATCH 25/33] drm/i915/guc: Support request cancellation

2021-10-05 Thread Sebastian Andrzej Siewior
On 2021-10-05 11:13:16 [+0100], Tvrtko Ursulin wrote: > Needs this fix: > > commit d576b31bdece7b5034047cbe21170e948198d32f > Author: Matthew Auld > Date: Fri Sep 24 15:46:46 2021 +0100 > > drm/i915: remember to call i915_sw_fence_fini Thanks, works. Needed a tweak since it does not apply

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Remove check for low voltage sku for max dp source rate

2021-10-05 Thread Patchwork
== Series Details == Series: drm/i915/display: Remove check for low voltage sku for max dp source rate URL : https://patchwork.freedesktop.org/series/95444/ State : success == Summary == CI Bug Log - changes from CI_DRM_10683 -> Patchwork_21244

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/dp: add drm_dp_phy_name() for getting DP PHY name

2021-10-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/dp: add drm_dp_phy_name() for getting DP PHY name URL : https://patchwork.freedesktop.org/series/95447/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be chec

[Intel-gfx] [PATCH] drm/i915: Handle Intel igfx + Intel dgfx hybrid graphics setup

2021-10-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In short this makes i915 work for hybrid setups (DRI_PRIME=1 with Mesa) when rendering is done on Intel dgfx and scanout/composition on Intel igfx. Before this patch the driver was not quite ready for that setup, mainly because it was able to emit a semaphore wait between th

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/dp: add drm_dp_phy_name() for getting DP PHY name

2021-10-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/dp: add drm_dp_phy_name() for getting DP PHY name URL : https://patchwork.freedesktop.org/series/95447/ State : success == Summary == CI Bug Log - changes from CI_DRM_10683 -> Patchwork_21245 =

[Intel-gfx] ✗ Fi.CI.BUILD: failure for CPU + GPU synchronised priority scheduling (rev3)

2021-10-05 Thread Patchwork
== Series Details == Series: CPU + GPU synchronised priority scheduling (rev3) URL : https://patchwork.freedesktop.org/series/95294/ State : failure == Summary == Applying: effective and consolidated user experience. In other words why user would not be error: drivers/gpu/drm/i915/i915_drm_cl

Re: [Intel-gfx] [PATCH 09/28] dma-buf: use the new iterator in dma_resv_poll

2021-10-05 Thread Christian König
Am 05.10.21 um 09:44 schrieb Tvrtko Ursulin: On 01/10/2021 11:05, Christian König wrote: Simplify the code a bit. Signed-off-by: Christian König ---   drivers/dma-buf/dma-buf.c | 36 ++--   1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/d

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Improve DP link training further (rev4)

2021-10-05 Thread Patchwork
== Series Details == Series: drm/i915: Improve DP link training further (rev4) URL : https://patchwork.freedesktop.org/series/95405/ State : warning == Summary == $ dim checkpatch origin/drm-tip abef31c7b13c drm/i915: Tweak the DP "max vswing reached?" condition b54d2483d9e1 drm/i915: Show LTT

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/dp: add drm_dp_phy_name() for getting DP PHY name

2021-10-05 Thread Jani Nikula
I wonder what's going on here?! BR, Jani. On Tue, 05 Oct 2021, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] drm/dp: add drm_dp_phy_name() for getting > DP PHY name > URL : https://patchwork.freedesktop.org/series/95447/ > State : warning > > == Summary ==

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2021-10-05 Thread Christian König
Thanks for the notice, going to fix this. Christian. Am 05.10.21 um 09:59 schrieb Stephen Rothwell: Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: include/linux/dma-buf.h:456: warning: Function parameter or member 'cb_in' not described in

[Intel-gfx] [PATCH 15/28] drm/radeon: use new iterator in radeon_sync_resv

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_sync.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_sync.c b/drivers/gpu/drm/radeon/radeon_sync.c index 9257b60144c4..b991ba1

[Intel-gfx] [PATCH 04/28] dma-buf: use new iterator in dma_resv_copy_fences

2021-10-05 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 84 +++--- 1 file changed, 32 insertions(+), 52 deletions(-) diff --git a/dri

[Intel-gfx] [PATCH 09/28] dma-buf: use the new iterator in dma_resv_poll

2021-10-05 Thread Christian König
Simplify the code a bit. Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin --- drivers/dma-buf/dma-buf.c | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 8242b5d9baeb..b

[Intel-gfx] [PATCH 05/28] dma-buf: use new iterator in dma_resv_get_fences v3

2021-10-05 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. v2: use sizeof(void*) instead v3: fix rebase bug Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 108 - 1 file changed, 35

[Intel-gfx] [PATCH 27/28] drm/etnaviv: use new iterator in etnaviv_gem_describe

2021-10-05 Thread Christian König
Instead of hand rolling the logic. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 31 ++- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c index 8f1b5

[Intel-gfx] [PATCH 22/28] drm/i915: use new cursor in intel_prepare_plane_fb

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/display/intel_display.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 134a6acbd8fb..

Re: [Intel-gfx] [PATCH 24/28] drm: use new iterator in drm_gem_plane_helper_prepare_fb

2021-10-05 Thread Christian König
Am 05.10.21 um 09:53 schrieb Tvrtko Ursulin: On 01/10/2021 11:06, Christian König wrote: Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König ---   drivers/gpu/drm/drm_gem_atomic_helper.c | 13 +++--   1 file changed,

Re: [Intel-gfx] [PATCH v3 10/14] drm/msm/dpu: Remove encoder->enable() hack

2021-10-05 Thread Dmitry Baryshkov
On 01/10/2021 18:11, Sean Paul wrote: From: Sean Paul encoder->commit() was being misused because there were some global resources which needed to be tweaked in encoder->enable() which were not accessible in dpu_encoder.c. That is no longer true and the redirect serves no purpose any longer. So

Re: [Intel-gfx] [PATCH v3 11/14] drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules

2021-10-05 Thread Dmitry Baryshkov
On 01/10/2021 18:11, Sean Paul wrote: From: Sean Paul Audio is initialized last, it should be de-initialized first to match the order in dp_init_sub_modules(). Reviewed-by: Abhinav Kumar Reviewed-by: Stephen Boyd Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/

[Intel-gfx] [PATCH 07/28] dma-buf: use new iterator in dma_resv_test_signaled

2021-10-05 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 57 +- 1 file changed, 7 insertions(+), 50 deletions(-) diff --git a/drive

Re: [Intel-gfx] [PATCH v3 09/14] drm/msm/dpu: Remove useless checks in dpu_encoder

2021-10-05 Thread Dmitry Baryshkov
On 01/10/2021 18:11, Sean Paul wrote: From: Sean Paul A couple more useless checks to remove in dpu_encoder. Reviewed-by: Stephen Boyd Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-10-s...@poorly.run #v1 Link: https://patchwork.freedeskt

[Intel-gfx] [PATCH 19/28] drm/i915: use the new iterator in i915_request_await_object v2

2021-10-05 Thread Christian König
Simplifying the code a bit. v2: add missing rcu_read_lock()/rcu_read_unlock() v3: use dma_resv_for_each_fence instead Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_request.c | 34 + 1 file changed, 5 insertions(+), 29 delet

[Intel-gfx] [PATCH 25/28] drm/nouveau: use the new iterator in nouveau_fence_sync

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_fence.c | 48 +++-- 1 file changed, 12 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c index 05d0b3eb

[Intel-gfx] [PATCH 23/28] drm: use new iterator in drm_gem_fence_array_add_implicit v3

2021-10-05 Thread Christian König
Simplifying the code a bit. v2: add missing rcu_read_lock()/unlock() v3: switch to locked version Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/drm_gem.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 16/28] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

2021-10-05 Thread Christian König
Simplifying the code a bit. v2: use dma_resv_for_each_fence Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/gpu/drm/scheduler/sched_main.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.

Re: [Intel-gfx] [PATCH v3 08/14] drm/msm/dpu_kms: Re-order dpu includes

2021-10-05 Thread Dmitry Baryshkov
On 01/10/2021 18:11, Sean Paul wrote: From: Sean Paul Make includes alphabetical in dpu_kms.c Reviewed-by: Abhinav Kumar Reviewed-by: Stephen Boyd Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-9-s...@poorly.run #v1 Link: https://patchwo

[Intel-gfx] Deploying new iterator interface for dma-buf

2021-10-05 Thread Christian König
Hi guys, a few more bug fixes, looks like the more selftests I add the more odies I find. Assuming the CI tests now pass I will start pushing patches I've already got an rb for to drm-misc-next. Please review and/or comment, Christian.

[Intel-gfx] [PATCH 28/28] drm/etnaviv: replace dma_resv_get_excl_unlocked

2021-10-05 Thread Christian König
We certainly hold the reservation lock here, no need for the RCU dance. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etna

[Intel-gfx] [PATCH 14/28] drm/msm: use new iterator in msm_gem_describe

2021-10-05 Thread Christian König
Simplifying the code a bit. Also drop the RCU read side lock since the object is locked anyway. Untested since I can't get the driver to compile on !ARM. Signed-off-by: Christian König --- drivers/gpu/drm/msm/msm_gem.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-)

[Intel-gfx] [PATCH 24/28] drm: use new iterator in drm_gem_plane_helper_prepare_fb v2

2021-10-05 Thread Christian König
Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). v2: improve coding and documentation Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_atomic_helper.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/g

[Intel-gfx] [PATCH 03/28] dma-buf: add dma_resv selftest v3

2021-10-05 Thread Christian König
Just exercising a very minor subset of the functionality, but already proven useful. v2: add missing locking v3: some more cleanup and consolidation, add unlocked test as well Signed-off-by: Christian König --- drivers/dma-buf/Makefile | 3 +- drivers/dma-buf/selftests.h | 1 + drive

[Intel-gfx] [PATCH 06/28] dma-buf: use new iterator in dma_resv_wait_timeout

2021-10-05 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 69 +- 1 file changed, 8 insertions(+), 61 deletions(-) diff --git a/drive

[Intel-gfx] [PATCH 08/28] dma-buf: use the new iterator in dma_buf_debug_show

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin --- drivers/dma-buf/dma-buf.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 61e20ae7b08b..8242b5d9ba

[Intel-gfx] [PATCH 13/28] drm/amdgpu: use new iterator in amdgpu_vm_prt_fini

2021-10-05 Thread Christian König
No need to actually allocate an array of fences here. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amd

[Intel-gfx] [PATCH 10/28] drm/ttm: use the new iterator in ttm_bo_flush_all_fences

2021-10-05 Thread Christian König
This is probably a fix since we didn't even grabed a reference to the fences. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/gpu/drm/ttm/ttm_bo.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/g

[Intel-gfx] [PATCH 11/28] drm/amdgpu: use the new iterator in amdgpu_sync_resv

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 44 1 file changed, 14 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c index 862eb3

[Intel-gfx] [PATCH 18/28] drm/i915: use the new iterator in i915_sw_fence_await_reservation v3

2021-10-05 Thread Christian König
Simplifying the code a bit. v2: use dma_resv_for_each_fence instead, according to Tvrtko the lock is held here anyway. v3: back to using dma_resv_for_each_fence_unlocked. Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_sw_fence.c | 53 ++-- 1 file change

[Intel-gfx] [PATCH 02/28] dma-buf: add dma_resv_for_each_fence v2

2021-10-05 Thread Christian König
A simpler version of the iterator to be used when the dma_resv object is locked. v2: fix index check here as well Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 49 ++ include/linux/dma-resv.h | 19 +++ 2 files changed, 68 inser

[Intel-gfx] [PATCH 26/28] drm/nouveau: use the new interator in nv50_wndw_prepare_fb

2021-10-05 Thread Christian König
Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c b/drivers/g

[Intel-gfx] [PATCH 20/28] drm/i915: use new iterator in i915_gem_object_wait_reservation

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 51 +--- 1 file changed, 9 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index f909aaa

[Intel-gfx] [PATCH 17/28] drm/i915: use the new iterator in i915_gem_busy_ioctl v2

2021-10-05 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_busy.c | 35 ++-- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH 12/28] drm/amdgpu: use new iterator in amdgpu_ttm_bo_eviction_valuable

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index e8d70b6e6737..722e3c

[Intel-gfx] [PATCH 21/28] drm/i915: use new iterator in i915_gem_object_wait_priority

2021-10-05 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 31 +--- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index a13193d

Re: [Intel-gfx] [PATCH 24/28] drm: use new iterator in drm_gem_plane_helper_prepare_fb

2021-10-05 Thread Christian König
Am 05.10.21 um 12:47 schrieb Tvrtko Ursulin: On 05/10/2021 11:27, Christian König wrote: Am 05.10.21 um 09:53 schrieb Tvrtko Ursulin: On 01/10/2021 11:06, Christian König wrote: Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christi

[Intel-gfx] [PATCH 01/28] dma-buf: add dma_resv_for_each_fence_unlocked v8

2021-10-05 Thread Christian König
Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences where we can be sure we grabbed the right one. v2: fix accessing the shared fences while they might be freed, improve kerneldoc, rename _cu

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/dp: add drm_dp_phy_name() for getting DP PHY name

2021-10-05 Thread Sarvela, Tomi P
There was an issue with fd.o expired root cert, and that caused some issues during the weekend and yesterday, mostly with git fetches. I wonder if this is related. Can you re-test the patchset and see if the issue persists? Other patchsets nearby timewise seem to be unaffected by spurious sparses.

Re: [Intel-gfx] [PATCH 17/28] drm/i915: use the new iterator in i915_gem_busy_ioctl v2

2021-10-05 Thread Tvrtko Ursulin
On 05/10/2021 12:37, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin Reminder - r-b was retracted until at least more text is added to commit message about pros

Re: [Intel-gfx] [PATCH 17/28] drm/i915: use the new iterator in i915_gem_busy_ioctl v2

2021-10-05 Thread Christian König
Am 05.10.21 um 14:40 schrieb Tvrtko Ursulin: On 05/10/2021 12:37, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin Reminder - r-b was retracted until at least more

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Improve DP link training further (rev4)

2021-10-05 Thread Patchwork
== Series Details == Series: drm/i915: Improve DP link training further (rev4) URL : https://patchwork.freedesktop.org/series/95405/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10683 -> Patchwork_21247 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Handle Intel igfx + Intel dgfx hybrid graphics setup

2021-10-05 Thread Thomas Hellström
Hi, Tvrtko, On 10/5/21 13:31, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In short this makes i915 work for hybrid setups (DRI_PRIME=1 with Mesa) when rendering is done on Intel dgfx and scanout/composition on Intel igfx. Before this patch the driver was not quite ready for that setup, mainly

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Handle Intel igfx + Intel dgfx hybrid graphics setup (rev3)

2021-10-05 Thread Patchwork
== Series Details == Series: drm/i915: Handle Intel igfx + Intel dgfx hybrid graphics setup (rev3) URL : https://patchwork.freedesktop.org/series/94105/ State : success == Summary == CI Bug Log - changes from CI_DRM_10683 -> Patchwork_21248

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/28] dma-buf: add dma_resv_for_each_fence_unlocked v8

2021-10-05 Thread Patchwork
== Series Details == Series: series starting with [01/28] dma-buf: add dma_resv_for_each_fence_unlocked v8 URL : https://patchwork.freedesktop.org/series/95456/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4d20a8353f25 dma-buf: add dma_resv_for_each_fence_unlocked v8 -:23: WA

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/28] dma-buf: add dma_resv_for_each_fence_unlocked v8

2021-10-05 Thread Patchwork
== Series Details == Series: series starting with [01/28] dma-buf: add dma_resv_for_each_fence_unlocked v8 URL : https://patchwork.freedesktop.org/series/95456/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/28] dma-buf: add dma_resv_for_each_fence_unlocked v8

2021-10-05 Thread Patchwork
== Series Details == Series: series starting with [01/28] dma-buf: add dma_resv_for_each_fence_unlocked v8 URL : https://patchwork.freedesktop.org/series/95456/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10683 -> Patchwork_21249

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Improve DP link training further (rev5)

2021-10-05 Thread Patchwork
== Series Details == Series: drm/i915: Improve DP link training further (rev5) URL : https://patchwork.freedesktop.org/series/95405/ State : warning == Summary == $ dim checkpatch origin/drm-tip dee501a3511e drm/i915: Tweak the DP "max vswing reached?" condition 94bb4313c0df drm/i915: Show LTT

Re: [Intel-gfx] [PATCH v5 09/13] drm/i915/ttm: add tt shmem backend

2021-10-05 Thread Thomas Hellström
On 10/5/21 04:05, Zeng, Oak wrote: Hi Matthew/Thomas, See one question inline Regards, Oak -Original Message- From: Intel-gfx On Behalf Of Matthew Auld Sent: September 27, 2021 7:41 AM To: intel-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org; Thomas Hellström ; Chri

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Improve DP link training further (rev4)

2021-10-05 Thread Ville Syrjälä
On Tue, Oct 05, 2021 at 12:49:53PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Improve DP link training further (rev4) > URL : https://patchwork.freedesktop.org/series/95405/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_10683 -> Patchwork_21

Re: [Intel-gfx] [PATCH v5 09/13] drm/i915/ttm: add tt shmem backend

2021-10-05 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Thomas Hellström > Sent: October 5, 2021 9:48 AM > To: Zeng, Oak ; Auld, Matthew > ; intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org; Christian König > > Subject: Re: [Intel-gfx] [PATCH v5 09/13] drm/i915/ttm: add tt shmem

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Improve DP link training further (rev5)

2021-10-05 Thread Patchwork
== Series Details == Series: drm/i915: Improve DP link training further (rev5) URL : https://patchwork.freedesktop.org/series/95405/ State : success == Summary == CI Bug Log - changes from CI_DRM_10683 -> Patchwork_21250 Summary ---

Re: [Intel-gfx] [PATCH v2] component: do not leave master devres group open after bind

2021-10-05 Thread Greg KH
On Wed, Sep 22, 2021 at 11:54:32AM +0300, Kai Vehmanen wrote: > In current code, the devres group for aggregate master is left open > after call to component_master_add_*(). This leads to problems when the > master does further managed allocations on its own. When any > participating driver calls c

Re: [Intel-gfx] [PATCH] drm/i915: Handle Intel igfx + Intel dgfx hybrid graphics setup

2021-10-05 Thread Tvrtko Ursulin
On 05/10/2021 14:05, Thomas Hellström wrote: Hi, Tvrtko, On 10/5/21 13:31, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In short this makes i915 work for hybrid setups (DRI_PRIME=1 with Mesa) when rendering is done on Intel dgfx and scanout/composition on Intel igfx. Before this patch the dr

[Intel-gfx] [PATCH 4/8] drm/i915: skip DRM_I915_LOW_LEVEL_TRACEPOINTS with NOTRACE

2021-10-05 Thread Sebastian Andrzej Siewior
The order of the header files is important. If this header file is included after tracepoint.h was included then the NOTRACE here becomes a nop. Currently this happens for two .c files which use the tracepoitns behind DRM_I915_LOW_LEVEL_TRACEPOINTS. Cc: Steven Rostedt Signed-off-by: Sebastian And

[Intel-gfx] [PATCH 3/8] drm/i915: Disable tracing points on PREEMPT_RT

2021-10-05 Thread Sebastian Andrzej Siewior
Luca Abeni reported this: | BUG: scheduling while atomic: kworker/u8:2/15203/0x0003 | CPU: 1 PID: 15203 Comm: kworker/u8:2 Not tainted 4.19.1-rt3 #10 | Call Trace: | rt_spin_lock+0x3f/0x50 | gen6_read32+0x45/0x1d0 [i915] | g4x_get_vblank_counter+0x36/0x40 [i915] | trace_event_raw_event_i915

[Intel-gfx] [PATCH 1/8] drm/i915: Use preempt_disable/enable_rt() where recommended

2021-10-05 Thread Sebastian Andrzej Siewior
From: Mike Galbraith Mario Kleiner suggest in commit ad3543ede630f ("drm/intel: Push get_scanout_position() timestamping into kms driver.") a spots where preemption should be disabled on PREEMPT_RT. The difference is that on PREEMPT_RT the intel_uncore::lock disables neither preemption nor in

[Intel-gfx] [PATCH 2/8] drm/i915: Don't disable interrupts on PREEMPT_RT during atomic updates

2021-10-05 Thread Sebastian Andrzej Siewior
From: Mike Galbraith Commit 8d7849db3eab7 ("drm/i915: Make sprite updates atomic") started disabling interrupts across atomic updates. This breaks on PREEMPT_RT because within this section the code attempt to acquire spinlock_t locks which are sleeping locks on PREEMPT_RT. According to the c

[Intel-gfx] [PATCH 0/8] drm/i915: PREEMPT_RT related fixups.

2021-10-05 Thread Sebastian Andrzej Siewior
Hi, the following patches are from the PREEMPT_RT queue. It is mostly about disabling interrupts/preemption which leads to problems. Unfortunately DRM_I915_LOW_LEVEL_TRACEPOINTS had to be disabled because it acquires locks from within trace points. I tested it on a SandyBridge with built-in i915 b

[Intel-gfx] [PATCH 6/8] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock()

2021-10-05 Thread Sebastian Andrzej Siewior
execlists_dequeue() is invoked from a function which uses local_irq_disable() to disable interrupts so the spin_lock() behaves like spin_lock_irq(). This breaks PREEMPT_RT because local_irq_disable() + spin_lock() is not the same as spin_lock_irq(). execlists_dequeue_irq() and execlists_dequeue()

[Intel-gfx] [PATCH 7/8] drm/i915: Drop the irqs_disabled() check

2021-10-05 Thread Sebastian Andrzej Siewior
The !irqs_disabled() check triggers on PREEMPT_RT even with i915_sched_engine::lock acquired. The reason is the lock is transformed into a sleeping lock on PREEMPT_RT and does not disable interrupts. There is no need to check for disabled interrupts. The lockdep annotation below already check if t

[Intel-gfx] [PATCH 8/8] drm/i915: Don't disable interrupts and pretend a lock as been acquired in __timeline_mark_lock().

2021-10-05 Thread Sebastian Andrzej Siewior
This is a revert of commits d67739268cf0e ("drm/i915/gt: Mark up the nested engine-pm timeline lock as irqsafe") 6c69a45445af9 ("drm/i915/gt: Mark context->active_count as protected by timeline->mutex") The existing code leads to a different behaviour depending on wheather lockdep is enabl

[Intel-gfx] [PATCH 5/8] drm/i915/gt: Queue and wait for the irq_work item.

2021-10-05 Thread Sebastian Andrzej Siewior
Disabling interrupts and invoking the irq_work function directly breaks on PREEMPT_RT. PREEMPT_RT does not invoke all irq_work from hardirq context because some of the user have spinlock_t locking in the callback function. These locks are then turned into a sleeping locks which can not be acquired

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Remove check for low voltage sku for max dp source rate

2021-10-05 Thread Patchwork
== Series Details == Series: drm/i915/display: Remove check for low voltage sku for max dp source rate URL : https://patchwork.freedesktop.org/series/95444/ State : success == Summary == CI Bug Log - changes from CI_DRM_10683_full -> Patchwork_21244_full ==

Re: [Intel-gfx] [PATCH] drm/i915/display: Remove check for low voltage sku for max dp source rate

2021-10-05 Thread Imre Deak
On Tue, Oct 05, 2021 at 01:34:21PM +0300, Jani Nikula wrote: > > Cc: Imre, I think you were involved in adding the checks. About ADL-S the spec says: Bspec 53597: Combo Port Maximum Speed: OEM must use VBT to specify a maximum that is tolerated by the board design. Combo Port HBR3 support: May

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/dp: add drm_dp_phy_name() for getting DP PHY name

2021-10-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/dp: add drm_dp_phy_name() for getting DP PHY name URL : https://patchwork.freedesktop.org/series/95447/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10683_full -> Patchwork_21245_full ===

  1   2   >