[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Stop using I915_TILING_* in client blit selftest

2021-10-01 Thread Patchwork
== Series Details == Series: drm/i915: Stop using I915_TILING_* in client blit selftest URL : https://patchwork.freedesktop.org/series/95308/ State : success == Summary == CI Bug Log - changes from CI_DRM_10670_full -> Patchwork_21212_full

[Intel-gfx] [PATCH] drm/i915: remove IS_ACTIVE

2021-10-01 Thread Lucas De Marchi
When trying to bring IS_ACTIVE to linux/kconfig.h I thought it wouldn't provide much value just encapsulating it in a boolean context. So I also added the support for handling undefined macros as the IS_ENABLED() counterpart. However the feedback received from Masahiro Yamada was that it is too ugl

Re: [Intel-gfx] [PATCH] drm/i915: remove IS_ACTIVE

2021-10-01 Thread Jani Nikula
On Fri, 01 Oct 2021, Lucas De Marchi wrote: > When trying to bring IS_ACTIVE to linux/kconfig.h I thought it wouldn't > provide much value just encapsulating it in a boolean context. So I also > added the support for handling undefined macros as the IS_ENABLED() > counterpart. However the feedback

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Wait PSR2 get out of deep sleep to update pipe

2021-10-01 Thread Patchwork
== Series Details == Series: drm/i915/display: Wait PSR2 get out of deep sleep to update pipe URL : https://patchwork.freedesktop.org/series/95309/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10670_full -> Patchwork_21213_full

Re: [Intel-gfx] [PATCH v2 3/3] Move IS_CONFIG_NONZERO() to kconfig.h

2021-10-01 Thread Masahiro Yamada
On Fri, Oct 1, 2021 at 12:55 AM Lucas De Marchi wrote: > > On Thu, Sep 30, 2021 at 11:01:36PM +0900, Masahiro Yamada wrote: > >On Thu, Sep 30, 2021 at 3:34 AM Lucas De Marchi > > wrote: > >> > >> The check for config value doesn't really belong to i915_utils.h - we > >> are trying to eliminate tha

Re: [Intel-gfx] [PATCH v3] drm/i915/ttm: Rework object initialization slightly

2021-10-01 Thread Matthew Auld
On 30/09/2021 12:32, Thomas Hellström wrote: We may end up in i915_ttm_bo_destroy() in an error path before the object is fully initialized. In that case it's not correct to call __i915_gem_free_object(), because that function a) Assumes the gem object refcount is 0, which it isn't. b) frees the

Re: [Intel-gfx] [PATCH] drm/i915: Fix bug in user proto-context creation that leaked contexts

2021-10-01 Thread Tvrtko Ursulin
+ Daniel as reviewer and maybe merge, avoid falling through cracks at least. On 22/09/2021 20:43, Matthew Brost wrote: Set number of engines before attempting to create contexts so the function free_engines can clean up properly. Also check return of alloc_engines for NULL. v2: (Tvrtko)

Re: [Intel-gfx] [PATCH 1/4] drm/i915/fdi: move fdi modeset asserts to intel_fdi.c

2021-10-01 Thread Jani Nikula
On Thu, 30 Sep 2021, Jani Nikula wrote: > On Thu, 30 Sep 2021, Ville Syrjälä wrote: >> On Thu, Sep 30, 2021 at 12:22:58PM +0300, Jani Nikula wrote: >> >>> diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c >>> b/drivers/gpu/drm/i915/display/intel_fdi.c >>> index af01d1fa761e..02d3294bad7b 10

Re: [Intel-gfx] [PATCH 6/6] drm/i915/dram: return -ENOENT instead of -1

2021-10-01 Thread Jani Nikula
On Thu, 30 Sep 2021, Ville Syrjälä wrote: > On Thu, Sep 30, 2021 at 02:24:36PM +0300, Jani Nikula wrote: >> Avoid using the incidental -EPERM. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/intel_dram.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --

Re: [Intel-gfx] [PATCH] drm/i915/fdi: use -EAGAIN instead of local special return value

2021-10-01 Thread Jani Nikula
On Thu, 30 Sep 2021, Ville Syrjälä wrote: > On Thu, Sep 30, 2021 at 12:32:29PM +0300, Jani Nikula wrote: >> Using standard -EAGAIN should be perfectly fine instead of using a >> special case value. > > Can't immediately spot any uses of -EAGAIN which would conflict here. > > Reviewed-by: Ville Syr

Re: [Intel-gfx] [RFC 1/6] sched: Add nice value change notifier

2021-10-01 Thread Tvrtko Ursulin
Hi Peter, On 30/09/2021 19:33, Peter Zijlstra wrote: On Thu, Sep 30, 2021 at 06:15:47PM +0100, Tvrtko Ursulin wrote: void set_user_nice(struct task_struct *p, long nice) { bool queued, running; - int old_prio; + int old_prio, ret; struct rq_flags rf; st

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: remove IS_ACTIVE

2021-10-01 Thread Patchwork
== Series Details == Series: drm/i915: remove IS_ACTIVE URL : https://patchwork.freedesktop.org/series/95312/ State : success == Summary == CI Bug Log - changes from CI_DRM_10671 -> Patchwork_21214 Summary --- **SUCCESS** No regre

[Intel-gfx] [PATCH v2] drm/locking: add backtrace for locking contended locks without backoff

2021-10-01 Thread Jani Nikula
If drm_modeset_lock() returns -EDEADLK, the caller is supposed to drop all currently held locks using drm_modeset_backoff(). Failing to do so will result in warnings and backtraces on the paths trying to lock a contended lock. Add support for optionally printing the backtrace on the path that hit t

Re: [Intel-gfx] [PATCH] drm/locking: add backtrace for locking contended locks without backoff

2021-10-01 Thread Jani Nikula
On Thu, 30 Sep 2021, Daniel Vetter wrote: > On Wed, Sep 29, 2021 at 01:32:41AM +0300, Jani Nikula wrote: >> If drm_modeset_lock() returns -EDEADLK, the caller is supposed to drop >> all currently held locks using drm_modeset_backoff(). Failing to do so >> will result in warnings and backtraces on

Re: [Intel-gfx] [RFC PATCH 2/2] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock()

2021-10-01 Thread Sebastian Andrzej Siewior
On 2021-09-16 11:38:55 [+0200], Maarten Lankhorst wrote: > Patches look good. Thank you for looking. > For both patches: > > Reviewed-by: Maarten Lankhorst > > I've been looking at running i915 with the -rt patch series, and > noticed i915_request_submit fails with GEM_BUG_ON(!irqs_disabled());

Re: [Intel-gfx] [PATCH] drm/i915/hdmi: convert intel_hdmi_to_dev to intel_hdmi_to_i915

2021-10-01 Thread Jani Nikula
On Tue, 21 Sep 2021, Ville Syrjälä wrote: > On Tue, Sep 21, 2021 at 02:02:44PM +0300, Jani Nikula wrote: >> Prefer i915 over drm pointer. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Ville Syrjälä Thanks, pushed. BR, Jani. > >> --- >> drivers/gpu/drm/i915/display/intel_hdmi.c | 16

Re: [Intel-gfx] [PULL] drm-misc-fixes

2021-10-01 Thread Daniel Vetter
On Thu, Sep 30, 2021 at 12:06:21PM +0200, Maarten Lankhorst wrote: > drm-misc-fixes-2021-09-30: > drm-misc-fixes for v5.15: > - Not sure if drm-misc-fixes-2021-09-08 tag was pulled, assuming it is. > - Power management fixes for vc4. > - Compiler fix for vc4. > - Cursor fix for nouveau. > - Fix ttm

Re: [Intel-gfx] [PATCH] drm/i915: remove IS_ACTIVE

2021-10-01 Thread Jani Nikula
On Fri, 01 Oct 2021, Chris Wilson wrote: > Quoting Lucas De Marchi (2021-10-01 08:40:41) >> When trying to bring IS_ACTIVE to linux/kconfig.h I thought it wouldn't >> provide much value just encapsulating it in a boolean context. So I also >> added the support for handling undefined macros as the

[Intel-gfx] [PATCH] drm/i915/reg: add AUD_TCA_DP_2DOT0_CTRL registers

2021-10-01 Thread Jani Nikula
For controlling the audio SDP split. Bspec: 63837 Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 3a20a55d2512..0d2d89ea376b 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH] drm/i915/dg2: update link training for 128b/132b

2021-10-01 Thread Jani Nikula
The 128b/132b channel coding link training uses more straightforward TX FFE preset values. v2: Fix UHBR rate checks, use intel_dp_is_uhbr() helper Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_ddi.c | 13 ++- .../drm/i915/display/intel_dp_link_training.c | 86 ++

Re: [Intel-gfx] [RFC 1/6] sched: Add nice value change notifier

2021-10-01 Thread Tvrtko Ursulin
On 01/10/2021 10:04, Tvrtko Ursulin wrote: Hi Peter, On 30/09/2021 19:33, Peter Zijlstra wrote: On Thu, Sep 30, 2021 at 06:15:47PM +0100, Tvrtko Ursulin wrote:   void set_user_nice(struct task_struct *p, long nice)   {   bool queued, running; -    int old_prio; +    int old_prio, ret;  

Re: [Intel-gfx] [PATCH 17/28] drm/i915: use the new iterator in i915_gem_busy_ioctl v2

2021-10-01 Thread Tvrtko Ursulin
On 01/10/2021 11:05, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin Sorry I retract until you add the text about the increased cost of the added atomics. I thin

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: remove IS_ACTIVE

2021-10-01 Thread Patchwork
== Series Details == Series: drm/i915: remove IS_ACTIVE URL : https://patchwork.freedesktop.org/series/95312/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10671_full -> Patchwork_21214_full Summary --- **FAILURE**

Re: [Intel-gfx] [vfio:next 33/38] drivers/gpu/drm/i915/i915_pci.c:975:2: warning: missing field 'override_only' initializer

2021-10-01 Thread Jani Nikula
On Fri, 27 Aug 2021, Jason Gunthorpe wrote: > On Fri, Aug 27, 2021 at 03:12:36PM +, kernel test robot wrote: >> tree: https://github.com/awilliam/linux-vfio.git next >> head: ea870730d83fc13a5fa2bd0e175176d7ac8a400a >> commit: 343b7258687ecfbb363bfda8833a7cf641aac524 [33/38] PCI: Add >> '

Re: [Intel-gfx] [PATCH] drm/i915/reg: add AUD_TCA_DP_2DOT0_CTRL registers

2021-10-01 Thread Ville Syrjälä
On Fri, Oct 01, 2021 at 01:03:16PM +0300, Jani Nikula wrote: > For controlling the audio SDP split. > > Bspec: 63837 > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_reg.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/d

Re: [Intel-gfx] [PATCH] drm/i915/reg: add AUD_TCA_DP_2DOT0_CTRL registers

2021-10-01 Thread Jani Nikula
On Fri, 01 Oct 2021, Ville Syrjälä wrote: > On Fri, Oct 01, 2021 at 01:03:16PM +0300, Jani Nikula wrote: >> For controlling the audio SDP split. >> >> Bspec: 63837 >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/i915_reg.h | 5 + >> 1 file changed, 5 insertions(+) >> >> diff -

[Intel-gfx] [PATCH 23/28] drm: use new iterator in drm_gem_fence_array_add_implicit v3

2021-10-01 Thread Christian König
Simplifying the code a bit. v2: add missing rcu_read_lock()/unlock() v3: switch to locked version Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/

[Intel-gfx] Deploying new iterator interface for dma-buf

2021-10-01 Thread Christian König
Hi guys, I've fixed up the lockdep splat in the new selftests found by the CI systems and added another path for dma_resv_poll. I know you guys are flooded, but can we get at least the first few patches committed? The patches to change the individual drivers could also be pushed later on I think

[Intel-gfx] [PATCH 08/28] dma-buf: use the new iterator in dma_buf_debug_show

2021-10-01 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 61e20ae7b08b..8242b5d9baeb 100644 --- a/drivers/dma-b

[Intel-gfx] [PATCH 17/28] drm/i915: use the new iterator in i915_gem_busy_ioctl v2

2021-10-01 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_busy.c | 35 ++-- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH 09/28] dma-buf: use the new iterator in dma_resv_poll

2021-10-01 Thread Christian König
Simplify the code a bit. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index 8242b5d9baeb..beb504a92d60 100644 --- a/driv

[Intel-gfx] [PATCH 21/28] drm/i915: use new iterator in i915_gem_object_wait_priority

2021-10-01 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 31 +--- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index a13193d

[Intel-gfx] [PATCH 14/28] drm/msm: use new iterator in msm_gem_describe

2021-10-01 Thread Christian König
Simplifying the code a bit. Also drop the RCU read side lock since the object is locked anyway. Untested since I can't get the driver to compile on !ARM. Signed-off-by: Christian König --- drivers/gpu/drm/msm/msm_gem.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-)

[Intel-gfx] [PATCH 27/28] drm/etnaviv: use new iterator in etnaviv_gem_describe

2021-10-01 Thread Christian König
Instead of hand rolling the logic. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 31 ++- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c index 8f1b5

[Intel-gfx] [PATCH 03/28] dma-buf: add dma_resv selftest

2021-10-01 Thread Christian König
Just exercising a very minor subset of the functionality, but already proven useful. Signed-off-by: Christian König --- drivers/dma-buf/Makefile | 3 +- drivers/dma-buf/selftests.h | 1 + drivers/dma-buf/st-dma-resv.c | 164 ++ 3 files changed, 167 inse

[Intel-gfx] [PATCH 22/28] drm/i915: use new cursor in intel_prepare_plane_fb

2021-10-01 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/display/intel_display.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 134a6acbd8fb..

[Intel-gfx] [PATCH 25/28] drm/nouveau: use the new iterator in nouveau_fence_sync

2021-10-01 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_fence.c | 48 +++-- 1 file changed, 12 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c index 05d0b3eb

[Intel-gfx] [PATCH 04/28] dma-buf: use new iterator in dma_resv_copy_fences

2021-10-01 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 84 +++--- 1 file changed, 32 insertions(+), 52 deletions(-) diff --git a/dri

[Intel-gfx] [PATCH 11/28] drm/amdgpu: use the new iterator in amdgpu_sync_resv

2021-10-01 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 44 1 file changed, 14 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c index 862eb3

[Intel-gfx] [PATCH 01/28] dma-buf: add dma_resv_for_each_fence_unlocked v7

2021-10-01 Thread Christian König
Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences where we can be sure we grabbed the right one. v2: fix accessing the shared fences while they might be freed, improve kerneldoc, rename _cu

[Intel-gfx] [PATCH 10/28] drm/ttm: use the new iterator in ttm_bo_flush_all_fences

2021-10-01 Thread Christian König
This is probably a fix since we didn't even grabed a reference to the fences. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/gpu/drm/ttm/ttm_bo.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/g

[Intel-gfx] [PATCH 13/28] drm/amdgpu: use new iterator in amdgpu_vm_prt_fini

2021-10-01 Thread Christian König
No need to actually allocate an array of fences here. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amd

[Intel-gfx] [PATCH 06/28] dma-buf: use new iterator in dma_resv_wait_timeout

2021-10-01 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 69 +- 1 file changed, 8 insertions(+), 61 deletions(-) diff --git a/drive

[Intel-gfx] [PATCH 20/28] drm/i915: use new iterator in i915_gem_object_wait_reservation

2021-10-01 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 51 +--- 1 file changed, 9 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index f909aaa

[Intel-gfx] [PATCH 24/28] drm: use new iterator in drm_gem_plane_helper_prepare_fb

2021-10-01 Thread Christian König
Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_atomic_helper.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_atomic_helper.c b/driv

[Intel-gfx] [PATCH 16/28] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

2021-10-01 Thread Christian König
Simplifying the code a bit. v2: use dma_resv_for_each_fence Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/gpu/drm/scheduler/sched_main.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.

Re: [Intel-gfx] [PATCH 17/28] drm/i915: use the new iterator in i915_gem_busy_ioctl v2

2021-10-01 Thread Christian König
Am 01.10.21 um 12:37 schrieb Tvrtko Ursulin: On 01/10/2021 11:05, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin Sorry I retract until you add the text about the

[Intel-gfx] [PATCH 18/28] drm/i915: use the new iterator in i915_sw_fence_await_reservation v3

2021-10-01 Thread Christian König
Simplifying the code a bit. v2: use dma_resv_for_each_fence instead, according to Tvrtko the lock is held here anyway. v3: back to using dma_resv_for_each_fence_unlocked. Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_sw_fence.c | 53 ++-- 1 file change

[Intel-gfx] [PATCH 15/28] drm/radeon: use new iterator in radeon_sync_resv

2021-10-01 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_sync.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_sync.c b/drivers/gpu/drm/radeon/radeon_sync.c index 9257b60144c4..b991ba1

[Intel-gfx] [PATCH 28/28] drm/etnaviv: replace dma_resv_get_excl_unlocked

2021-10-01 Thread Christian König
We certainly hold the reservation lock here, no need for the RCU dance. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etna

[Intel-gfx] [PATCH 02/28] dma-buf: add dma_resv_for_each_fence

2021-10-01 Thread Christian König
A simpler version of the iterator to be used when the dma_resv object is locked. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 46 ++ include/linux/dma-resv.h | 19 2 files changed, 65 insertions(+) diff --git a/drivers/dm

[Intel-gfx] [PATCH 12/28] drm/amdgpu: use new iterator in amdgpu_ttm_bo_eviction_valuable

2021-10-01 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index e8d70b6e6737..722e3c

[Intel-gfx] [PATCH 19/28] drm/i915: use the new iterator in i915_request_await_object v2

2021-10-01 Thread Christian König
Simplifying the code a bit. v2: add missing rcu_read_lock()/rcu_read_unlock() v3: use dma_resv_for_each_fence instead Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_request.c | 34 + 1 file changed, 5 insertions(+), 29 delet

[Intel-gfx] [PATCH 07/28] dma-buf: use new iterator in dma_resv_test_signaled

2021-10-01 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 57 +- 1 file changed, 7 insertions(+), 50 deletions(-) diff --git a/drive

[Intel-gfx] [PATCH 05/28] dma-buf: use new iterator in dma_resv_get_fences v3

2021-10-01 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. v2: use sizeof(void*) instead v3: fix rebase bug Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 108 - 1 file changed, 35

[Intel-gfx] [PATCH 26/28] drm/nouveau: use the new interator in nv50_wndw_prepare_fb

2021-10-01 Thread Christian König
Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c b/drivers/g

Re: [Intel-gfx] [PATCH] drm/i915: remove IS_ACTIVE

2021-10-01 Thread kernel test robot
is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Lucas-De-Marchi/drm-i915-remove-IS_ACTIVE/20211001-154226 b

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/locking: add backtrace for locking contended locks without backoff (rev2)

2021-10-01 Thread Patchwork
== Series Details == Series: drm/locking: add backtrace for locking contended locks without backoff (rev2) URL : https://patchwork.freedesktop.org/series/95182/ State : warning == Summary == $ dim checkpatch origin/drm-tip 28bb80fe7399 drm/locking: add backtrace for locking contended locks wi

[Intel-gfx] [PATCH v2 01/10] drm/i915: Introduce has_iboost()

2021-10-01 Thread Ville Syrjala
From: Ville Syrjälä Suck the "do we have iboost?" platform checks into a small helper. Cc: Imre Deak Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_d

[Intel-gfx] [PATCH v2 03/10] drm/i915: Generalize .set_signal_levels()

2021-10-01 Thread Ville Syrjala
From: Ville Syrjälä Currently .set_signal_levels() is only used by encoders in DP mode. For most modern platforms there is no essential difference between DP and HDMI, and both codepaths just end up calling the same function under the hood. Let's get remove the need for that extra indirection by

[Intel-gfx] [PATCH v2 06/10] drm/i915: Hoover the level>=n_entries WARN into intel_ddi_level()

2021-10-01 Thread Ville Syrjala
From: Ville Syrjälä All callers of intel_ddi_level() duplicate the check+WARN to make sure the returned level is actually present in the appropriate buf_trans table. Let's push that stuff into intel_ddi_level() so the callers don't have to worry about it. Reviewed-by: Imre Deak Signed-off-by: V

[Intel-gfx] [PATCH v2 00/10] drm/i915: DP per-lane drive settings prep work

2021-10-01 Thread Ville Syrjala
From: Ville Syrjälä Revised set after I fixed the DDI_BUF_CTL stuff Imre pointed out. Also pushed the first s/ddi_translation/trans/ rename patch already. There are two new patches at the start of the series to refactor some platform checks into a more sensible form. Ville Syrjälä (10): drm/i

[Intel-gfx] [PATCH v2 05/10] drm/i915: De-wrapper bxt_ddi_phy_set_signal_levels()

2021-10-01 Thread Ville Syrjala
From: Ville Syrjälä Convert bxt_ddi_phy_set_signal_levels() to act as the full .set_signal_levels() hook instead of going through a pointless wrapper. Reviewed-by: Imre Deak Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 24 +-- drivers/gpu/drm/i9

[Intel-gfx] [PATCH v2 04/10] drm/i915: Nuke useless .set_signal_levels() wrappers

2021-10-01 Thread Ville Syrjala
From: Ville Syrjälä Now that .set_signal_levels() is used for HDMI as well, we can remove the extra level of indirection and just plug the correct stuff straight into .set_signal_levels(). Reviewed-by: Imre Deak Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c |

[Intel-gfx] [PATCH v2 09/10] drm/i915: Prepare link training for per-lane drive settings

2021-10-01 Thread Ville Syrjala
From: Ville Syrjälä Adjust the link training code to accommodate per-lane drive settings, if supported by the platform. Actually enabling this will involve some changes to each platform's .set_signal_level() implementation, so for the moment all supported platforms will keep using the current cod

[Intel-gfx] [PATCH v2 02/10] drm/i915: Introduce has_buf_trans_select()

2021-10-01 Thread Ville Syrjala
From: Ville Syrjälä Add a small helper to determine if DDI_BUF_CTL uses the DDI_BUF_TRANS_SELECT field, and whether we have the accompanying DDI_BUF_TRANS table in the hardware. Cc: Imre Deak Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 11 +-- 1 file ch

[Intel-gfx] [PATCH v2 10/10] drm/i915: Allow per-lane drive settings with LTTPRs

2021-10-01 Thread Ville Syrjala
From: Ville Syrjälä LTTPRs should support per-lane drive settings I think, and even if they don't they should implement their own fallback logic to determine suitable common drive settings to use for all the lanes. v2: Actually check the correct thing Reviewed-by: Imre Deak Signed-off-by: Vill

[Intel-gfx] [PATCH v2 07/10] drm/i915: Nuke intel_ddi_hdmi_num_entries()

2021-10-01 Thread Ville Syrjala
From: Ville Syrjälä Since intel_ddi_level() now looks that buf_trans table there's no point in having intel_ddi_hdmi_num_entries() around. Just roll the necessary bits of locic into intel_ddi_hdmi_level()/intel_ddi_level(). Reviewed-by: Imre Deak Signed-off-by: Ville Syrjälä --- drivers/gpu/d

[Intel-gfx] [PATCH v2 08/10] drm/i915: Pass the lane to intel_ddi_level()

2021-10-01 Thread Ville Syrjala
From: Ville Syrjälä In order to have per-lane drive settings we need intel_ddi_level() to accept the lane as a parameter. That is, the eventual goal is to call intel_ddi_level() once for each lane. For now we just pass in a hardcoded 0 and use the same settings for every lane. Ie. no change in be

Re: [Intel-gfx] refactor the i915 GVT support

2021-10-01 Thread Wang, Zhi A
On 9/29/21 6:55 PM, Jason Gunthorpe wrote: > On Wed, Sep 29, 2021 at 06:27:16PM +, Wang, Zhi A wrote: >> On 9/28/21 3:05 PM, Jason Gunthorpe wrote: >>> On Tue, Sep 28, 2021 at 02:35:06PM +, Wang, Zhi A wrote: >>> Yes. I was thinking of the possibility of putting off some work later so

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/locking: add backtrace for locking contended locks without backoff (rev2)

2021-10-01 Thread Patchwork
== Series Details == Series: drm/locking: add backtrace for locking contended locks without backoff (rev2) URL : https://patchwork.freedesktop.org/series/95182/ State : success == Summary == CI Bug Log - changes from CI_DRM_10674 -> Patchwork_21215

[Intel-gfx] [bug report] drm/i915/tc: Fix TypeC PHY connect/disconnect logic on ADL-P

2021-10-01 Thread Dan Carpenter
Hello Imre Deak, This is a semi-automatic email about new static checker warnings. The patch 3e0abc7661c8: "drm/i915/tc: Fix TypeC PHY connect/disconnect logic on ADL-P" from Sep 29, 2021, leads to the following Smatch complaint: drivers/gpu/drm/i915/display/intel_ddi.c:4028 intel_ddi_enco

Re: [Intel-gfx] [bug report] drm/i915/tc: Fix TypeC PHY connect/disconnect logic on ADL-P

2021-10-01 Thread Ville Syrjälä
On Fri, Oct 01, 2021 at 04:25:35PM +0300, Dan Carpenter wrote: > Hello Imre Deak, > > This is a semi-automatic email about new static checker warnings. > > The patch 3e0abc7661c8: "drm/i915/tc: Fix TypeC PHY > connect/disconnect logic on ADL-P" from Sep 29, 2021, leads to the > following Smatch

Re: [Intel-gfx] [PATCH v2 01/10] drm/i915: Introduce has_iboost()

2021-10-01 Thread Imre Deak
On Fri, Oct 01, 2021 at 04:00:58PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Suck the "do we have iboost?" platform checks into a small helper. > > Cc: Imre Deak > Signed-off-by: Ville Syrjälä Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 13

Re: [Intel-gfx] [PATCH v2 02/10] drm/i915: Introduce has_buf_trans_select()

2021-10-01 Thread Imre Deak
On Fri, Oct 01, 2021 at 04:00:59PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Add a small helper to determine if DDI_BUF_CTL uses the > DDI_BUF_TRANS_SELECT field, and whether we have the > accompanying DDI_BUF_TRANS table in the hardware. > > Cc: Imre Deak > Signed-off-by: Ville Syr

Re: [Intel-gfx] [PULL] drm-misc-fixes

2021-10-01 Thread Daniel Vetter
On Fri, Oct 01, 2021 at 11:50:52AM +0200, Daniel Vetter wrote: > On Thu, Sep 30, 2021 at 12:06:21PM +0200, Maarten Lankhorst wrote: > > drm-misc-fixes-2021-09-30: > > drm-misc-fixes for v5.15: > > - Not sure if drm-misc-fixes-2021-09-08 tag was pulled, assuming it is. > > - Power management fixes f

Re: [Intel-gfx] [PATCH] drm/i915: Use direction definition DMA_BIDIRECTIONAL instead of PCI_DMA_BIDIRECTIONAL

2021-10-01 Thread Daniel Vetter
On Thu, Sep 30, 2021 at 08:58:15PM +0200, Christophe JAILLET wrote: > Le 30/09/2021 à 16:21, Daniel Vetter a écrit : > > On Sat, Sep 25, 2021 at 08:46:12PM +0800, Cai Huoqing wrote: > > > Replace direction definition PCI_DMA_BIDIRECTIONAL > > > with DMA_BIDIRECTIONAL, because it helps to enhance re

Re: [Intel-gfx] [bug report] drm/i915/tc: Fix TypeC PHY connect/disconnect logic on ADL-P

2021-10-01 Thread Dan Carpenter
On Fri, Oct 01, 2021 at 05:20:17PM +0300, Ville Syrjälä wrote: > On Fri, Oct 01, 2021 at 04:25:35PM +0300, Dan Carpenter wrote: > > Hello Imre Deak, > > > > This is a semi-automatic email about new static checker warnings. > > > > The patch 3e0abc7661c8: "drm/i915/tc: Fix TypeC PHY > > connect/d

Re: [Intel-gfx] [PULL] drm-intel-fixes

2021-10-01 Thread Daniel Vetter
On Thu, Sep 30, 2021 at 11:50:20AM +0300, Jani Nikula wrote: > > Hi Dave & Daniel - > > drm-intel-fixes-2021-09-30: > drm/i915 fixes for v5.15-rc4: > - Fix GVT scheduler ww lock usage > - Fix pdfdocs documentation build > - Fix request early tracepoints > - Fix an invalid warning from rps worker

[Intel-gfx] [PATCH v3 00/14] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2021-10-01 Thread Sean Paul
From: Sean Paul Hello again, Here is v3 of the patch series. Notable changes include incorporating review feedback involving: - Changed dt-bindings to introduce new compatible string - Code changes in msm driver as suggested by Stephen & Abhinav - Fixed issues found by 0-day Thank you to the

[Intel-gfx] [PATCH v3 01/14] drm/hdcp: Add drm_hdcp_atomic_check()

2021-10-01 Thread Sean Paul
From: Sean Paul This patch moves the hdcp atomic check from i915 to drm_hdcp so other drivers can use it. No functional changes, just cleaned up some of the code when moving it over. Acked-by: Jani Nikula Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175

[Intel-gfx] [PATCH v3 02/14] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2021-10-01 Thread Sean Paul
From: Sean Paul Instead of forcing a modeset in the hdcp atomic check, simply return true if the content protection value is changing and let the driver decide whether a modeset is required or not. Acked-by: Jani Nikula Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/ms

[Intel-gfx] [PATCH v3 03/14] drm/hdcp: Update property value on content type and user changes

2021-10-01 Thread Sean Paul
From: Sean Paul This patch updates the connector's property value in 2 cases which were previously missed: 1- Content type changes. The value should revert back to DESIRED from ENABLED in case the driver must re-authenticate the link due to the new content type. 2- Userspace sets value to

[Intel-gfx] [PATCH v3 04/14] drm/hdcp: Expand HDCP helper library for enable/disable/check

2021-10-01 Thread Sean Paul
From: Sean Paul This patch expands upon the HDCP helper library to manage HDCP enable, disable, and check. Previous to this patch, the majority of the state management and sink interaction is tucked inside the Intel driver with the understanding that once a new platform supported HDCP we could m

[Intel-gfx] [PATCH v3 05/14] drm/i915/hdcp: Consolidate HDCP setup/state cache

2021-10-01 Thread Sean Paul
From: Sean Paul Stick all of the setup for HDCP into a dedicated function. No functional change, but this will facilitate moving HDCP logic into helpers. Acked-by: Jani Nikula Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-6-s...@poorly.run

[Intel-gfx] [PATCH v3 06/14] drm/i915/hdcp: Retain hdcp_capable return codes

2021-10-01 Thread Sean Paul
From: Sean Paul The shim functions return error codes, but they are discarded in intel_hdcp.c. This patch plumbs the return codes through so they are properly handled. Acked-by: Jani Nikula Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-7-s..

[Intel-gfx] [PATCH v3 07/14] drm/i915/hdcp: Use HDCP helpers for i915

2021-10-01 Thread Sean Paul
From: Sean Paul Now that all of the HDCP 1.x logic has been migrated to the central HDCP helpers, use it in the i915 driver. The majority of the driver code for HDCP 1.x will live in intel_hdcp.c, however there are a few helper hooks which are connector-specific and need to be partially or fully

[Intel-gfx] [PATCH v3 08/14] drm/msm/dpu_kms: Re-order dpu includes

2021-10-01 Thread Sean Paul
From: Sean Paul Make includes alphabetical in dpu_kms.c Reviewed-by: Abhinav Kumar Reviewed-by: Stephen Boyd Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-9-s...@poorly.run #v1 Link: https://patchwork.freedesktop.org/patch/msgid/202109152

[Intel-gfx] [PATCH v3 09/14] drm/msm/dpu: Remove useless checks in dpu_encoder

2021-10-01 Thread Sean Paul
From: Sean Paul A couple more useless checks to remove in dpu_encoder. Reviewed-by: Stephen Boyd Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-10-s...@poorly.run #v1 Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-1

[Intel-gfx] [PATCH v3 10/14] drm/msm/dpu: Remove encoder->enable() hack

2021-10-01 Thread Sean Paul
From: Sean Paul encoder->commit() was being misused because there were some global resources which needed to be tweaked in encoder->enable() which were not accessible in dpu_encoder.c. That is no longer true and the redirect serves no purpose any longer. So remove the indirection. Reviewed-by: S

[Intel-gfx] [PATCH v3 11/14] drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules

2021-10-01 Thread Sean Paul
From: Sean Paul Audio is initialized last, it should be de-initialized first to match the order in dp_init_sub_modules(). Reviewed-by: Abhinav Kumar Reviewed-by: Stephen Boyd Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-12-s...@poorly.run

[Intel-gfx] [PATCH v3 12/14] dt-bindings: msm/dp: Add bindings for HDCP registers

2021-10-01 Thread Sean Paul
From: Sean Paul This patch adds the bindings for the MSM DisplayPort HDCP registers which are required to write the HDCP key into the display controller as well as the registers to enable HDCP authentication/key exchange/encryption. We'll use a new compatible string for this since the fields are

[Intel-gfx] [PATCH v3 13/14] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2021-10-01 Thread Sean Paul
From: Sean Paul This patch adds the register ranges required for HDCP key injection and HDCP TrustZone interaction as described in the dt-bindings for the sc7180 dp controller. Now that these are supported, change the compatible string to "dp-hdcp". Signed-off-by: Sean Paul Link: https://patch

[Intel-gfx] [PATCH v3 14/14] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2021-10-01 Thread Sean Paul
From: Sean Paul This patch adds HDCP 1.x support to msm DP connectors using the new HDCP helpers. Cc: Stephen Boyd Cc: Abhinav Kumar Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-15-s...@poorly.run #v1 Link: https://patchwork.freedesktop.

Re: [Intel-gfx] [PATCH] drm/i915/dg2: update link training for 128b/132b

2021-10-01 Thread Ville Syrjälä
On Fri, Oct 01, 2021 at 01:02:47PM +0300, Jani Nikula wrote: > The 128b/132b channel coding link training uses more straightforward TX > FFE preset values. > > v2: Fix UHBR rate checks, use intel_dp_is_uhbr() helper > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_ddi.c

Re: [Intel-gfx] [RFC 1/6] sched: Add nice value change notifier

2021-10-01 Thread Peter Zijlstra
On Fri, Oct 01, 2021 at 11:32:16AM +0100, Tvrtko Ursulin wrote: > > On 01/10/2021 10:04, Tvrtko Ursulin wrote: > > > > Hi Peter, > > > > On 30/09/2021 19:33, Peter Zijlstra wrote: > > > On Thu, Sep 30, 2021 at 06:15:47PM +0100, Tvrtko Ursulin wrote: > > > >   void set_user_nice(struct task_struc

Re: [Intel-gfx] [vfio:next 33/38] drivers/gpu/drm/i915/i915_pci.c:975:2: warning: missing field 'override_only' initializer

2021-10-01 Thread Jason Gunthorpe
On Fri, Oct 01, 2021 at 02:04:04PM +0300, Jani Nikula wrote: > On Fri, 27 Aug 2021, Jason Gunthorpe wrote: > > On Fri, Aug 27, 2021 at 03:12:36PM +, kernel test robot wrote: > >> tree: https://github.com/awilliam/linux-vfio.git next > >> head: ea870730d83fc13a5fa2bd0e175176d7ac8a400a > >>

Re: [Intel-gfx] [PATCH] drm/i915: Fix bug in user proto-context creation that leaked contexts

2021-10-01 Thread Matthew Brost
On Fri, Oct 01, 2021 at 09:40:19AM +0100, Tvrtko Ursulin wrote: > > + Daniel as reviewer and maybe merge, avoid falling through cracks at least. > Ty, working on push rights myself. > On 22/09/2021 20:43, Matthew Brost wrote: > > Set number of engines before attempting to create contexts so the

[Intel-gfx] [PATCH] drm/i915: Fix bug in user proto-context creation that leaked contexts

2021-10-01 Thread Matthew Brost
Set number of engines before attempting to create contexts so the function free_engines can clean up properly. Also check return of alloc_engines for NULL. v2: (Tvrtko) - Send as stand alone patch (John Harrison) - Check for alloc_engines returning NULL v3: (Checkpatch / Tvrtko) - Remove

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/reg: add AUD_TCA_DP_2DOT0_CTRL registers

2021-10-01 Thread Patchwork
== Series Details == Series: drm/i915/reg: add AUD_TCA_DP_2DOT0_CTRL registers URL : https://patchwork.freedesktop.org/series/95316/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2e6ff8d7426c drm/i915/reg: add AUD_TCA_DP_2DOT0_CTRL registers -:25: WARNING:LONG_LINE: line length

  1   2   >