Re: [Intel-gfx] [PATCH V5 1/5] drm/i915/gt: Add support of mocs propagation

2021-09-16 Thread Siddiqui, Ayaz A
> -Original Message- > From: Roper, Matthew D > Sent: Wednesday, September 15, 2021 9:09 AM > To: Siddiqui, Ayaz A > Cc: intel-gfx@lists.freedesktop.org; Tang, CQ > Subject: Re: [PATCH V5 1/5] drm/i915/gt: Add support of mocs propagation > > On Fri, Sep 03, 2021 at 02:51:49PM +0530,

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Add "intel_" as prefix in set_mocs_index()

2021-09-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: Add "intel_" as prefix in set_mocs_index() URL : https://patchwork.freedesktop.org/series/94721/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10594 -> Patchwork_21069 Summary -

[Intel-gfx] [PULL] drm-misc-next

2021-09-16 Thread Maxime Ripard
Hi Dave, Daniel, Here's the first drm-misc-next PR for 5.16 Thanks! Maxime drm-misc-next-2021-09-16: drm-misc-next for $kernel-version: UAPI Changes: Cross-subsystem Changes: - dma-buf: Avoid a warning with some allocations, Remove DMA_FENCE_TRACE macros Core Changes: - bridge: New he

Re: [Intel-gfx] [PATCH] drm/i915: zero fill vma name buffer

2021-09-16 Thread Tvrtko Ursulin
On 15/09/2021 20:23, Tim Gardner wrote: In capture_vma() Coverity complains of a possible buffer overrun. Even though this is a static function where all call sites can be checked, limiting the copy length could save some future grief. CID 93300 (#1 of 1): Copy into fixed size buffer (STRING_O

Re: [Intel-gfx] [PATCH 1/9] drm/connector: Add support for privacy-screen properties (v4)

2021-09-16 Thread Jani Nikula
On Wed, 15 Sep 2021, Lyude Paul wrote: > On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: >>   >> +   /** >> +    * @privacy_screen_sw_state: See :ref:`Standard Connector >> +    * Properties` >> +    */ > > So THAT'S how you reference other sections. I've always wondered!

Re: [Intel-gfx] [PATCH 08/27] drm/i915: Add logical engine mapping

2021-09-16 Thread Tvrtko Ursulin
On 15/09/2021 17:58, Matthew Brost wrote: On Wed, Sep 15, 2021 at 09:24:15AM +0100, Tvrtko Ursulin wrote: On 14/09/2021 19:04, Matthew Brost wrote: On Tue, Sep 14, 2021 at 09:34:08AM +0100, Tvrtko Ursulin wrote: 8< Today we have: for_each intel_engines: // intel_engines is a flat list

Re: [Intel-gfx] 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-16 Thread Tvrtko Ursulin
Hi, On 16/09/2021 05:37, Hugh Dickins wrote: Two Lenovo ThinkPads, old T420s (2011), newer X1 Carbon 5th gen (2017): i915 working fine on both up to 5.14, but blank screens booting 5.15-rc1, kernel crashed in some way. T420s could be SandyBridge and X1 Carbon KabyLake. I wanted to say what

Re: [Intel-gfx] [PATCH 2/9] drm: Add privacy-screen class (v3)

2021-09-16 Thread Hans de Goede
Hi Lyude, Thank you very much for the review of this series. On 9/15/21 10:01 PM, Lyude Paul wrote: > On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: >> On some new laptops the LCD panel has a builtin electronic privacy-screen. >> We want to export this functionality as a property on the

Re: [Intel-gfx] [PATCH 3/9] drm/privacy-screen: Add X86 specific arch init code

2021-09-16 Thread Jani Nikula
On Mon, 06 Sep 2021, Hans de Goede wrote: > Add X86 specific arch init code, which fills the privacy-screen lookup > table by checking for various vendor specific ACPI interfaces for > controlling the privacy-screen. > > This initial version only checks for the Lenovo Thinkpad specific ACPI > meth

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/1] tests/i915/query: Query, parse and validate the hwconfig table

2021-09-16 Thread Petri Latvala
On Wed, Sep 15, 2021 at 02:55:58PM -0700, john.c.harri...@intel.com wrote: > From: Rodrigo Vivi > > Newer platforms have an embedded table giving details about that > platform's hardware configuration. This table can be retrieved from > the KMD via the existing query API. So add a test for it as

Re: [Intel-gfx] [PATCH v3 06/12] drm/ttm: add TTM_PAGE_FLAG_EXTERNAL_MAPPABLE

2021-09-16 Thread Thomas Hellström
On Thu, 2021-09-16 at 08:55 +0200, Christian König wrote: > > > Am 15.09.21 um 20:59 schrieb Matthew Auld: > > In commit: > > > > commit 667a50db0477d47fdff01c666f5ee1ce26b5264c > > Author: Thomas Hellstrom > > Date:   Fri Jan 3 11:17:18 2014 +0100 > > > > drm/ttm: Refuse to fault (prime-

Re: [Intel-gfx] [PATCH 4/9] drm/privacy-screen: Add notifier support

2021-09-16 Thread Hans de Goede
Hi, On 9/15/21 10:26 PM, Lyude Paul wrote: > On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: >> Add support for privacy-screen consumers to register a notifier to >> be notified of external (e.g. done by the hw itself on a hotkey press) >> state changes. >> >> Reviewed-by: Emil Velikov >>

Re: [Intel-gfx] [PATCH 8/9] platform/x86: thinkpad_acpi: Register a privacy-screen device

2021-09-16 Thread Hans de Goede
Hi, On 9/15/21 10:55 PM, Lyude Paul wrote: > On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: >> Register a privacy-screen device on laptops with a privacy-screen, >> this exports the PrivacyGuard features to user-space using a >> standardized vendor-agnostic sysfs interface. Note the sysfs

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-16 Thread Hans de Goede
Hi, On 9/15/21 11:11 PM, Lyude Paul wrote: > On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: >> Add support for eDP panels with a built-in privacy screen using the >> new drm_privacy_screen class. >> >> One thing which stands out here is the addition of these 2 lines to >> intel_atomic_com

Re: [Intel-gfx] [PATCH 3/9] drm/privacy-screen: Add X86 specific arch init code

2021-09-16 Thread Hans de Goede
Hi, On 9/16/21 10:51 AM, Jani Nikula wrote: > On Mon, 06 Sep 2021, Hans de Goede wrote: >> Add X86 specific arch init code, which fills the privacy-screen lookup >> table by checking for various vendor specific ACPI interfaces for >> controlling the privacy-screen. >> >> This initial version only

[Intel-gfx] ✗ Fi.CI.BUILD: failure for i915/display: split and constify vtable (rev6)

2021-09-16 Thread Patchwork
== Series Details == Series: i915/display: split and constify vtable (rev6) URL : https://patchwork.freedesktop.org/series/94459/ State : failure == Summary == Applying: drm/i915/uncore: split the fw get function into separate vfunc Applying: drm/i915/pm: drop get_fifo_size vfunc. Applying: dr

Re: [Intel-gfx] New uAPI for color management proposal and feedback request v2

2021-09-16 Thread Pekka Paalanen
On Tue, 3 Aug 2021 11:38:19 +0200 Werner Sembach wrote: > Greetings, > > Original proposal: > https://www.mail-archive.com/amd-gfx@lists.freedesktop.org/msg62387.html > > Abstract: Add "preferred color format", "active color format", "active bpc", > and "active Broadcast RGB" drm properties,

Re: [Intel-gfx] [PATCH 0/9] drm: Add privacy-screen class and connector properties

2021-09-16 Thread Hans de Goede
Hi, On 9/15/21 11:12 PM, Lyude Paul wrote: > OK! Looked over all of these patches. Patches 2 and 4 have some comments that > should be addressed, but otherwise this series is: > > Reviewed-by: Lyude Paul Thank you! > Let me know when/if you need help pushing this upstream My plan was to just

Re: [Intel-gfx] [RFC PATCH 2/2] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock()

2021-09-16 Thread Maarten Lankhorst
Op 08-09-2021 om 20:57 schreef Sebastian Andrzej Siewior: > execlists_dequeue() is invoked from a function which uses > local_irq_disable() to disable interrupts so the spin_lock() behaves > like spin_lock_irq(). > This breaks PREEMPT_RT because local_irq_disable() + spin_lock() is not > the same a

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-16 Thread Jani Nikula
Cc: Ville for input here, see question inline. On Mon, 06 Sep 2021, Hans de Goede wrote: > Add support for eDP panels with a built-in privacy screen using the > new drm_privacy_screen class. > > One thing which stands out here is the addition of these 2 lines to > intel_atomic_commit_tail: > >

Re: [Intel-gfx] [PATCH 00/19] drm/i915: Short-term pinning and async eviction.

2021-09-16 Thread Intel
On 8/30/21 2:09 PM, Maarten Lankhorst wrote: Remove some parts of the i915_vma api, ensure obj->vma always exists, and finally force the object lock to be taken when calling i915_vma_unbind is called. Should this be vma->obj? With this, locking is a lot cleaner, and we no longer need all

Re: [Intel-gfx] [PATCH 17/19] drm/i915: Add functions to set/get moving fence

2021-09-16 Thread Thomas Hellström
On 8/30/21 2:10 PM, Maarten Lankhorst wrote: We want to get rid of i915_vma tracking to simplify the code and lifetimes. Add a way to set/put the moving fence, in preparation for removing the tracking. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/gem/i915_gem_object.c | 15

Re: [Intel-gfx] [PATCH 01/19] drm/i915: Move __i915_gem_free_object to ttm_bo_destroy

2021-09-16 Thread Intel
On 8/30/21 2:09 PM, Maarten Lankhorst wrote: When we implement delayed destroy, we may have a second call to the delete_mem_notify() handler, while free_object() only should be called once. Move it to bo->destroy(), to ensure it's only called once. This fixes some weird memory corruption issue

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Fix the dsc check while selecting min_cdclk (rev2)

2021-09-16 Thread Kulkarni, Vandita
From: Patchwork Sent: Wednesday, September 15, 2021 5:05 PM To: Kulkarni, Vandita Cc: intel-gfx@lists.freedesktop.org Subject: ✗ Fi.CI.BAT: failure for drm/i915/display: Fix the dsc check while selecting min_cdclk (rev2) Patch Details Series: drm/i915/display: Fix the dsc check while selecting

Re: [Intel-gfx] [PATCH v3 06/12] drm/ttm: add TTM_PAGE_FLAG_EXTERNAL_MAPPABLE

2021-09-16 Thread Matthew Auld
On 16/09/2021 10:03, Thomas Hellström wrote: On Thu, 2021-09-16 at 08:55 +0200, Christian König wrote: Am 15.09.21 um 20:59 schrieb Matthew Auld: In commit: commit 667a50db0477d47fdff01c666f5ee1ce26b5264c Author: Thomas Hellstrom Date:   Fri Jan 3 11:17:18 2014 +0100 drm/ttm: Refuse

Re: [Intel-gfx] [PATCH 18/19] drm/i915: Add support for asynchronous moving fence waiting

2021-09-16 Thread Intel
Hi, We're moving towards a failsafe migration on DG1, but on DG2+ we'd have to wedge the GPU when an error occurs during initial clearing or swapin. But CPU maps don't care whether the GPU is wedged so we need to check the error status both below and in the TTM fault handler, I guess. On 8/3

Re: [Intel-gfx] [PATCH v3 06/12] drm/ttm: add TTM_PAGE_FLAG_EXTERNAL_MAPPABLE

2021-09-16 Thread Thomas Hellström
On 9/16/21 11:58 AM, Matthew Auld wrote: On 16/09/2021 10:03, Thomas Hellström wrote: On Thu, 2021-09-16 at 08:55 +0200, Christian König wrote: Am 15.09.21 um 20:59 schrieb Matthew Auld: In commit: commit 667a50db0477d47fdff01c666f5ee1ce26b5264c Author: Thomas Hellstrom Date:   Fri Jan 3

Re: [Intel-gfx] [PATCH 0/9] drm: Add privacy-screen class and connector properties

2021-09-16 Thread Jani Nikula
On Thu, 16 Sep 2021, Hans de Goede wrote: > Hi, > > On 9/15/21 11:12 PM, Lyude Paul wrote: >> OK! Looked over all of these patches. Patches 2 and 4 have some comments that >> should be addressed, but otherwise this series is: >> >> Reviewed-by: Lyude Paul > > Thank you! > >> Let me know when/if

[Intel-gfx] [PATCH] drm/i915/dsi: unregister gmbus if LFP display was MIPI panel

2021-09-16 Thread Lee Shawn C
Gmbus driver would setup all Intel i2c GMBuses. But DDC bus may configured as gpio and reserved for MIPI driver to control panel power on/off sequence. Using i2c tool to communicate to peripherals via i2c interface reversed for gmbus(DDC). There will be some high/low pulse appear on DDC SCL and SD

Re: [Intel-gfx] [PATCH v3 1/6] drm/i915/ttm: Implement a function to copy the contents of two TTM-based objects

2021-09-16 Thread Matthew Auld
On 14/09/2021 20:31, Thomas Hellström wrote: When backing up or restoring contents of pinned objects at suspend / resume time we need to allocate a new object as the backup. Add a function to facilitate copies between the two. Some data needs to be copied before the migration context is ready for

Re: [Intel-gfx] 5.15-rc1 i915 blank screen booting on ThinkPads

2021-09-16 Thread Jani Nikula
On Thu, 16 Sep 2021, Tvrtko Ursulin wrote: > Hi, > > On 16/09/2021 05:37, Hugh Dickins wrote: >> Two Lenovo ThinkPads, old T420s (2011), newer X1 Carbon 5th gen (2017): >> i915 working fine on both up to 5.14, but blank screens booting 5.15-rc1, >> kernel crashed in some way. > > T420s could be Sa

Re: [Intel-gfx] [PATCH v3 2/6] drm/i915/gem: Implement a function to process all gem objects of a region

2021-09-16 Thread Matthew Auld
On 14/09/2021 20:31, Thomas Hellström wrote: An upcoming common pattern is to traverse the region object list and perform certain actions on all objects in a region. It's a little tricky to get the list locking right, in particular since a gem object may change region unless it's pinned or the ob

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-16 Thread Hans de Goede
Hi, On 9/16/21 11:40 AM, Jani Nikula wrote: > > Cc: Ville for input here, see question inline. > > On Mon, 06 Sep 2021, Hans de Goede wrote: >> Add support for eDP panels with a built-in privacy screen using the >> new drm_privacy_screen class. >> >> One thing which stands out here is the addit

Re: [Intel-gfx] [PATCH] drm/i915/dsi: unregister gmbus if LFP display was MIPI panel

2021-09-16 Thread Jani Nikula
On Thu, 16 Sep 2021, Lee Shawn C wrote: > Gmbus driver would setup all Intel i2c GMBuses. But DDC bus > may configured as gpio and reserved for MIPI driver to control > panel power on/off sequence. > > Using i2c tool to communicate to peripherals via i2c interface > reversed for gmbus(DDC). There

Re: [Intel-gfx] [PATCH] drm/i915: zero fill vma name buffer

2021-09-16 Thread Jani Nikula
On Thu, 16 Sep 2021, Tvrtko Ursulin wrote: > On 15/09/2021 20:23, Tim Gardner wrote: >> In capture_vma() Coverity complains of a possible buffer overrun. Even >> though this is a static function where all call sites can be checked, >> limiting the copy length could save some future grief. >> >> C

Re: [Intel-gfx] [PATCH v3 02/12] drm/ttm: move ttm_tt_{add, clear}_mapping into amdgpu

2021-09-16 Thread Christian König
Am 15.09.21 um 20:59 schrieb Matthew Auld: Now that setting page->index shouldn't be needed anymore, we are just left with setting page->mapping, and here it looks like amdgpu is the only user, where pointing the page->mapping at the dev_mapping is used to verify that the pages do indeed belon

Re: [Intel-gfx] [PATCH v3 03/12] drm/ttm: remove TTM_PAGE_FLAG_NO_RETRY

2021-09-16 Thread Christian König
Am 15.09.21 um 20:59 schrieb Matthew Auld: No longer used it seems. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Christian König Reviewed-by: Christian König --- include/drm/ttm/ttm_tt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/drm/ttm/ttm_tt.h b/include/drm/

Re: [Intel-gfx] [PATCH v3 01/12] drm/ttm: stop setting page->index for the ttm_tt

2021-09-16 Thread Christian König
Am 15.09.21 um 20:59 schrieb Matthew Auld: In commit: commit 58aa6622d32af7d2c08d45085f44c54554a16ed7 Author: Thomas Hellstrom Date: Fri Jan 3 11:47:23 2014 +0100 drm/ttm: Correctly set page mapping and -index members we started setting the page->mapping and page->index to point to the

Re: [Intel-gfx] [PATCH v3 04/12] drm/ttm: s/FLAG_SG/FLAG_EXTERNAL/

2021-09-16 Thread Christian König
Am 15.09.21 um 20:59 schrieb Matthew Auld: It covers more than just ttm_bo_type_sg usage, like with say dma-buf, since one other user is userptr in amdgpu, and in the future we might have some more. Hence EXTERNAL is likely a more suitable name. Suggested-by: Christian König Signed-off-by: M

Re: [Intel-gfx] [PATCH v3 05/12] drm/ttm: add some kernel-doc for TTM_PAGE_FLAG_*

2021-09-16 Thread Christian König
Am 15.09.21 um 20:59 schrieb Matthew Auld: Move it to inline kernel-doc, otherwise we can't add empty lines it seems. Also drop the kernel-doc for pages_list, which doesn't seem to exist, and get rid of all the strange holes. As suggested on the other patch I would do the rename and renumbering

Re: [Intel-gfx] [PATCH v3 06/12] drm/ttm: add TTM_PAGE_FLAG_EXTERNAL_MAPPABLE

2021-09-16 Thread Christian König
Am 15.09.21 um 20:59 schrieb Matthew Auld: In commit: commit 667a50db0477d47fdff01c666f5ee1ce26b5264c Author: Thomas Hellstrom Date: Fri Jan 3 11:17:18 2014 +0100 drm/ttm: Refuse to fault (prime-) imported pages we introduced the restriction that imported pages should not be directl

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: unregister gmbus if LFP display was MIPI panel

2021-09-16 Thread Patchwork
== Series Details == Series: drm/i915/dsi: unregister gmbus if LFP display was MIPI panel URL : https://patchwork.freedesktop.org/series/94733/ State : success == Summary == CI Bug Log - changes from CI_DRM_10596 -> Patchwork_21071 Summary

Re: [Intel-gfx] [PATCH] drm/i915/dsi: unregister gmbus if LFP display was MIPI panel

2021-09-16 Thread Lee, Shawn C
On Thu, 16 Sep 2021, Jani Nikula wrote: >On Thu, 16 Sep 2021, Lee Shawn C wrote: >> Gmbus driver would setup all Intel i2c GMBuses. But DDC bus may >> configured as gpio and reserved for MIPI driver to control panel power >> on/off sequence. >> >> Using i2c tool to communicate to peripherals vi

Re: [Intel-gfx] [PATCH v9 04/17] drm/i915/pxp: allocate a vcs context for pxp usage

2021-09-16 Thread Jani Nikula
On Wed, 15 Sep 2021, Rodrigo Vivi wrote: > On Wed, Sep 15, 2021 at 04:53:35PM +0300, Jani Nikula wrote: >> On Fri, 10 Sep 2021, Daniele Ceraolo Spurio >> wrote: >> > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.h >> > b/drivers/gpu/drm/i915/pxp/intel_pxp.h >> > new file mode 100644 >> > inde

Re: [Intel-gfx] [PATCH] drm/i915/dsi: unregister gmbus if LFP display was MIPI panel

2021-09-16 Thread Jani Nikula
On Thu, 16 Sep 2021, "Lee, Shawn C" wrote: > On Thu, 16 Sep 2021, Jani Nikula wrote: >>On Thu, 16 Sep 2021, Lee Shawn C wrote: >>> Gmbus driver would setup all Intel i2c GMBuses. But DDC bus may >>> configured as gpio and reserved for MIPI driver to control panel power >>> on/off sequence. >>>

Re: [Intel-gfx] [PATCH 19/19] drm/i915: Add accelerated migration to ttm

2021-09-16 Thread Intel
drm/i915/ttm: Add async migration to the TTM backend? On 8/30/21 2:10 PM, Maarten Lankhorst wrote: Expose the fence to ttm_bo->moving, which will get picked up by i915 through the i915_gem_object_get_moving_fence call. Should be sufficient for the needs we have. Signed-off-by: Maarten Lankhorst

Re: [Intel-gfx] [PATCH 00/19] drm/i915: Short-term pinning and async eviction.

2021-09-16 Thread Maarten Lankhorst
Op 16-09-2021 om 11:40 schreef Thomas Hellström (Intel): > > On 8/30/21 2:09 PM, Maarten Lankhorst wrote: >> Remove some parts of the i915_vma api, ensure obj->vma always exists, >> and finally force the object lock to be taken when calling i915_vma_unbind >> is called. > > Should this be vma->obj?

Re: [Intel-gfx] [PATCH] drm/i915: zero fill vma name buffer

2021-09-16 Thread Tim Gardner
On 9/16/21 4:43 AM, Jani Nikula wrote: On Thu, 16 Sep 2021, Tvrtko Ursulin wrote: On 15/09/2021 20:23, Tim Gardner wrote: In capture_vma() Coverity complains of a possible buffer overrun. Even though this is a static function where all call sites can be checked, limiting the copy length cou

[Intel-gfx] [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine v2

2021-09-16 Thread Christian König
This is maybe even a fix since the RCU usage here looks incorrect. v2: add missing rcu_read_lock()/unlock() Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_object.h | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i9

[Intel-gfx] [PATCH RESEND v2 1/3] lib, stackdepot: check stackdepot handle before accessing slabs.

2021-09-16 Thread Imran Khan
stack_depot_save allocates slabs that will be used for storing objects in future.If this slab allocation fails we may get to a situation where space allocation for a new stack_record fails, causing stack_depot_save to return 0 as handle. If user of this handle ends up invoking stack_depot_fetch wit

[Intel-gfx] [PATCH 06/26] dma-buf: use new iterator in dma_resv_test_signaled

2021-09-16 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 54 +- 1 file changed, 7 insertions(+), 47 deletions(-) diff --git a/drivers/dma-buf/dma-resv.c b/driv

[Intel-gfx] [PATCH 12/26] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

2021-09-16 Thread Christian König
Simplifying the code a bit. v2: use dma_resv_for_each_fence Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/sched_main.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/schedul

[Intel-gfx] [PATCH 03/26] dma-buf: use new iterator in dma_resv_copy_fences

2021-09-16 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 81 +++--- 1 file changed, 32 insertions(+), 49 deletions(-) diff --git a/drivers/dma-buf/dma-resv.c b/dr

[Intel-gfx] [PATCH 09/26] drm/amdgpu: use new iterator in amdgpu_ttm_bo_eviction_valuable

2021-09-16 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index 1129e17e9f09..b3859c

[Intel-gfx] [PATCH 11/26] drm/radeon: use new iterator in radeon_sync_resv

2021-09-16 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_sync.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_sync.c b/drivers/gpu/drm/radeon/radeon_sync.c index 9257b60144c4..23fa98d

[Intel-gfx] [PATCH 04/26] dma-buf: use new iterator in dma_resv_get_fences v2

2021-09-16 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. v2: use sizeof(void*) instead Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 110 + 1 file changed, 37 insertions(+), 73 deletions(-) diff --git a/d

[Intel-gfx] [PATCH 08/26] drm/amdgpu: use the new iterator in amdgpu_sync_resv

2021-09-16 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 44 1 file changed, 14 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c index 862eb3

[Intel-gfx] [PATCH 07/26] drm/ttm: use the new iterator in ttm_bo_flush_all_fences

2021-09-16 Thread Christian König
This is probably a fix since we didn't even grabed a reference to the fences. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 3b22c0

[Intel-gfx] [PATCH 21/26] drm: use new iterator in drm_gem_plane_helper_prepare_fb v2

2021-09-16 Thread Christian König
Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). v2: add missing rcu_read_lock()/unlock() Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_atomic_helper.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/driver

[Intel-gfx] [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked v2

2021-09-16 Thread Christian König
Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences where we can be sure we grabbed the right one. v2: fix accessing the shared fences while they might be freed, improve kerneldoc, rename _cu

[Intel-gfx] [PATCH 23/26] drm/nouveau: use the new interator in nv50_wndw_prepare_fb v2

2021-09-16 Thread Christian König
Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). v2: add missing rcu_read_lock()/unlock() Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/

[Intel-gfx] [PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl

2021-09-16 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_busy.c | 30 +++- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_ge

[Intel-gfx] Deploying new iterator interface for dma-buf

2021-09-16 Thread Christian König
Next round for that one here, maybe the CI systems are now more gracefully with me :) I'm pretty sure that a couple of those dma_resv_for_each_fence_unlocked should actually be replaced with lock+dma_resv_for_each_fence, but that needs more auditing. Please review and comment. Thanks, Christian.

[Intel-gfx] [PATCH 22/26] drm/nouveau: use the new iterator in nouveau_fence_sync

2021-09-16 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_fence.c | 48 +++-- 1 file changed, 12 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c index 05d0b3eb

[Intel-gfx] [PATCH 26/26] dma-buf: nuke dma_resv_get_excl_unlocked

2021-09-16 Thread Christian König
Heureka, that's finally not used any more. Signed-off-by: Christian König --- include/linux/dma-resv.h | 26 -- 1 file changed, 26 deletions(-) diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h index 6761512ba662..3e6ffba0af70 100644 --- a/include/linux/dm

[Intel-gfx] [PATCH 02/26] dma-buf: add dma_resv_for_each_fence

2021-09-16 Thread Christian König
A simpler version of the iterator to be used when the dma_resv object is locked. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 37 + include/linux/dma-resv.h | 18 ++ 2 files changed, 55 insertions(+) diff --git a/drivers/d

[Intel-gfx] [PATCH 14/26] drm/i915: use the new iterator in i915_sw_fence_await_reservation v2

2021-09-16 Thread Christian König
Simplifying the code a bit. v2: use dma_resv_for_each_fence instead, according to Tvrtko the lock is held here anyway. Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_sw_fence.c | 51 +--- 1 file changed, 9 insertions(+), 42 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH 24/26] drm/etnaviv: use new iterator in etnaviv_gem_describe

2021-09-16 Thread Christian König
Instead of hand rolling the logic. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c index 8f1b5a

[Intel-gfx] [PATCH 16/26] drm/i915: use new iterator in i915_gem_object_wait_reservation v2

2021-09-16 Thread Christian König
Simplifying the code a bit. v2: add missing rcu read unlock. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 57 +++- 1 file changed, 15 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i91

[Intel-gfx] [PATCH 05/26] dma-buf: use new iterator in dma_resv_wait_timeout

2021-09-16 Thread Christian König
This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König --- drivers/dma-buf/dma-resv.c | 64 +- 1 file changed, 7 insertions(+), 57 deletions(-) diff --git a/drivers/dma-buf/dma-resv.c b/driv

[Intel-gfx] [PATCH 20/26] drm: use new iterator in drm_gem_fence_array_add_implicit v2

2021-09-16 Thread Christian König
Simplifying the code a bit. v2: add missing rcu_read_lock()/unlock() Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem.c | 36 +--- 1 file changed, 13 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c inde

[Intel-gfx] [PATCH 19/26] drm/i915: use new cursor in intel_prepare_plane_fb v2

2021-09-16 Thread Christian König
Simplifying the code a bit. v2: add rcu_read_lock()/unlock() Signed-off-by: Christian König --- drivers/gpu/drm/i915/display/intel_display.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/displa

[Intel-gfx] [PATCH 15/26] drm/i915: use the new iterator in i915_request_await_object v2

2021-09-16 Thread Christian König
Simplifying the code a bit. v2: add missing rcu_read_lock()/rcu_read_unlock() Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_request.c | 40 - 1 file changed, 11 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers

[Intel-gfx] [PATCH RESEND v2 0/3] lib, stackdepot: check stackdepot handle before accessing slabs

2021-09-16 Thread Imran Khan
Changes in v2: - Fixed compilation error [1] due to typo in patch-3 (stack_depot_print used in place of stack_depot_snprint) This compilation error appears with CONFIG_DRM_I915_DEBUG_RUNTIME_PM=y and this was missed by my test config (x86_64_defconfig) [1] https://patchwork.freedesktop.o

[Intel-gfx] [PATCH 25/26] drm/etnaviv: replace dma_resv_get_excl_unlocked

2021-09-16 Thread Christian König
We certainly hold the reservation lock here, no need for the RCU dance. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etna

[Intel-gfx] [PATCH 17/26] drm/i915: use new iterator in i915_gem_object_wait_priority v2

2021-09-16 Thread Christian König
Simplifying the code a bit. v2: add missing rcu_read_lock()/unlock() Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 33 +++- 1 file changed, 9 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/

[Intel-gfx] [PATCH RESEND v2 3/3] lib, stackdepot: Add helper to print stack entries into buffer.

2021-09-16 Thread Imran Khan
To print stack entries into a buffer, users of stackdepot, first get a list of stack entries using stack_depot_fetch and then print this list into a buffer using stack_trace_snprint. Provide a helper in stackdepot for this purpose. Also change above mentioned users to use this helper. Signed-off-b

[Intel-gfx] [PATCH RESEND v2 2/3] lib, stackdepot: Add helper to print stack entries.

2021-09-16 Thread Imran Khan
To print a stack entries, users of stackdepot, first use stack_depot_fetch to get a list of stack entries and then use stack_trace_print to print this list. Provide a helper in stackdepot to print stack entries based on stackdepot handle. Also change above mentioned users to use this helper. Signe

[Intel-gfx] [PATCH 10/26] drm/msm: use new iterator in msm_gem_describe

2021-09-16 Thread Christian König
Simplifying the code a bit. Also drop the RCU read side lock since the object is locked anyway. Untested since I can't get the driver to compile on !ARM. Signed-off-by: Christian König --- drivers/gpu/drm/msm/msm_gem.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-)

Re: [Intel-gfx] [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked v2

2021-09-16 Thread Daniel Vetter
On Thu, Sep 16, 2021 at 01:30:17PM +0200, Christian König wrote: > Abstract the complexity of iterating over all the fences > in a dma_resv object. > > The new loop handles the whole RCU and retry dance and > returns only fences where we can be sure we grabbed the > right one. > > v2: fix accessi

[Intel-gfx] ✗ Fi.CI.BUILD: failure for lib, stackdepot: check stackdepot handle before accessing slabs (rev2)

2021-09-16 Thread Patchwork
== Series Details == Series: lib, stackdepot: check stackdepot handle before accessing slabs (rev2) URL : https://patchwork.freedesktop.org/series/94696/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include

Re: [Intel-gfx] [PATCH v2 12/13] dt-bindings: msm/dp: Add bindings for HDCP registers

2021-09-16 Thread Rob Herring
On Wed, 15 Sep 2021 16:38:31 -0400, Sean Paul wrote: > From: Sean Paul > > This patch adds the bindings for the MSM DisplayPort HDCP registers > which are required to write the HDCP key into the display controller as > well as the registers to enable HDCP authentication/key > exchange/encryption.

[Intel-gfx] [PATCH v2] drm/i915: use strscpy() to avoid buffer overrun

2021-09-16 Thread Tim Gardner
In capture_vma() Coverity complains of a possible buffer overrun. Even though this is a static function where all call sites can be checked, limiting the copy length could save some future grief. CID 93300 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW) 4. fixed_size_dest: You might overr

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/26] dma-buf: add dma_resv_for_each_fence_unlocked v2

2021-09-16 Thread Patchwork
== Series Details == Series: series starting with [01/26] dma-buf: add dma_resv_for_each_fence_unlocked v2 URL : https://patchwork.freedesktop.org/series/94750/ State : warning == Summary == $ dim checkpatch origin/drm-tip 79becb99fccc dma-buf: add dma_resv_for_each_fence_unlocked v2 -:72: CH

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dsi: unregister gmbus if LFP display was MIPI panel

2021-09-16 Thread Patchwork
== Series Details == Series: drm/i915/dsi: unregister gmbus if LFP display was MIPI panel URL : https://patchwork.freedesktop.org/series/94733/ State : success == Summary == CI Bug Log - changes from CI_DRM_10596_full -> Patchwork_21071_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/26] dma-buf: add dma_resv_for_each_fence_unlocked v2

2021-09-16 Thread Patchwork
== Series Details == Series: series starting with [01/26] dma-buf: add dma_resv_for_each_fence_unlocked v2 URL : https://patchwork.freedesktop.org/series/94750/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10596 -> Patchwork_21073

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: zero fill vma name buffer (rev2)

2021-09-16 Thread Patchwork
== Series Details == Series: drm/i915: zero fill vma name buffer (rev2) URL : https://patchwork.freedesktop.org/series/94708/ State : warning == Summary == $ dim checkpatch origin/drm-tip 129ca4e746b8 drm/i915: use strscpy() to avoid buffer overrun -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible

Re: [Intel-gfx] [PATCH v2 12/13] dt-bindings: msm/dp: Add bindings for HDCP registers

2021-09-16 Thread Rob Herring
On Wed, Sep 15, 2021 at 04:38:31PM -0400, Sean Paul wrote: > From: Sean Paul > > This patch adds the bindings for the MSM DisplayPort HDCP registers > which are required to write the HDCP key into the display controller as > well as the registers to enable HDCP authentication/key > exchange/encry

Re: [Intel-gfx] [PATCH v2] kernel/locking: Add context to ww_mutex_trylock.

2021-09-16 Thread Maarten Lankhorst
Op 14-09-2021 om 15:54 schreef Daniel Vetter: > On Tue, Sep 14, 2021 at 02:43:02PM +0200, Maarten Lankhorst wrote: >> Op 14-09-2021 om 08:50 schreef Peter Zijlstra: >>> On Mon, Sep 13, 2021 at 10:42:36AM +0200, Maarten Lankhorst wrote: >>> > +/** > + * ww_mutex_trylock - tries to acquire th

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/display: Workaround cursor left overs with PSR2 selective fetch enabled

2021-09-16 Thread Ville Syrjälä
On Wed, Sep 15, 2021 at 06:18:35PM +, Souza, Jose wrote: > On Wed, 2021-09-15 at 17:58 +0300, Ville Syrjälä wrote: > > On Tue, Sep 14, 2021 at 02:25:05PM -0700, José Roberto de Souza wrote: > > > Not sure why but when moving the cursor fast it causes some artifacts > > > of the cursor to be lef

Re: [Intel-gfx] [PATCH 8/8] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2021-09-16 Thread Hans de Goede
Hi, On 9/16/21 5:20 AM, Stephen Boyd wrote: > Quoting Hans de Goede (2021-08-17 14:52:01) >> diff --git a/drivers/usb/typec/altmodes/displayport.c >> b/drivers/usb/typec/altmodes/displayport.c >> index aa669b9cf70e..c1d8c23baa39 100644 >> --- a/drivers/usb/typec/altmodes/displayport.c >> +++ b/dr

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: zero fill vma name buffer (rev2)

2021-09-16 Thread Patchwork
== Series Details == Series: drm/i915: zero fill vma name buffer (rev2) URL : https://patchwork.freedesktop.org/series/94708/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10596 -> Patchwork_21074 Summary --- **FAILU

Re: [Intel-gfx] [PATCH 01/16] Revert "drm/i915/display: Disable audio, DRRS and PSR before planes"

2021-09-16 Thread Ville Syrjälä
On Wed, Sep 15, 2021 at 08:19:41PM +, Souza, Jose wrote: > On Wed, 2021-09-15 at 15:30 +0300, Ville Syrjälä wrote: > > On Wed, Sep 15, 2021 at 12:00:28AM +, Souza, Jose wrote: > > > On Tue, 2021-09-14 at 16:30 -0700, José Roberto de Souza wrote: > > > > On Tue, 2021-09-14 at 11:20 +0300, Vi

Re: [Intel-gfx] [PATCH v2] kernel/locking: Add context to ww_mutex_trylock.

2021-09-16 Thread Peter Zijlstra
On Thu, Sep 16, 2021 at 03:00:39PM +0200, Maarten Lankhorst wrote: > > For merge logistics, can we pls have a stable branch? I expect that the > > i915 patches will be ready for 5.16. > > > > Or send it in for -rc2 so that the interface change doesn't cause needless > > conflicts, whatever you thi

[Intel-gfx] [PULL] drm-intel-fixes

2021-09-16 Thread Jani Nikula
Hi Dave & Daniel - Fixes for v5.15-rc2. Looks like our CI is currently unhealthy. It's a wip, but these don't seem to make matters worse, so I think better get them moving than holding on. drm-intel-fixes-2021-09-16: drm/i915 fixes for v5.15-rc2: - Propagate DP link training error returns - Us

Re: [Intel-gfx] [PATCH 01/19] drm/i915: Move __i915_gem_free_object to ttm_bo_destroy

2021-09-16 Thread Maarten Lankhorst
Op 16-09-2021 om 11:43 schreef Thomas Hellström (Intel): > > On 8/30/21 2:09 PM, Maarten Lankhorst wrote: >> When we implement delayed destroy, we may have a second >> call to the delete_mem_notify() handler, while free_object() >> only should be called once. >> >> Move it to bo->destroy(), to ensu

[Intel-gfx] [PATCH RESEND v3 2/3] lib, stackdepot: Add helper to print stack entries.

2021-09-16 Thread Imran Khan
To print a stack entries, users of stackdepot, first use stack_depot_fetch to get a list of stack entries and then use stack_trace_print to print this list. Provide a helper in stackdepot to print stack entries based on stackdepot handle. Also change above mentioned users to use this helper. Signe

[Intel-gfx] [PATCH RESEND v3 3/3] lib, stackdepot: Add helper to print stack entries into buffer.

2021-09-16 Thread Imran Khan
To print stack entries into a buffer, users of stackdepot, first get a list of stack entries using stack_depot_fetch and then print this list into a buffer using stack_trace_snprint. Provide a helper in stackdepot for this purpose. Also change above mentioned users to use this helper. Signed-off-b

[Intel-gfx] [PATCH RESEND v3 0/3] lib, stackdepot: check stackdepot handle before accessing slabs

2021-09-16 Thread Imran Khan
Changes in v3: - Fixed build error [1], due to missing EXPORT_SYMBOL_GPL in patch-3 [1] https://patchwork.freedesktop.org/series/94696/#rev2 Changes in v2: - Fixed compilation error [1] due to typo in patch-3 (stack_depot_print used in place of stack_depot_snprint) This compilation error

[Intel-gfx] [PATCH RESEND v3 1/3] lib, stackdepot: check stackdepot handle before accessing slabs.

2021-09-16 Thread Imran Khan
stack_depot_save allocates slabs that will be used for storing objects in future.If this slab allocation fails we may get to a situation where space allocation for a new stack_record fails, causing stack_depot_save to return 0 as handle. If user of this handle ends up invoking stack_depot_fetch wit

  1   2   >