On 14/09/2021 19:04, Matthew Brost wrote:
On Tue, Sep 14, 2021 at 09:34:08AM +0100, Tvrtko Ursulin wrote:
8<
Today we have:
for_each intel_engines: // intel_engines is a flat list of all engines
intel_engine_setup()
You propose to change it to:
for_each engine_class:
for 0.
On Tue, 14 Sep 2021, Vasily Khoruzhick wrote:
> On Tue, Sep 14, 2021 at 3:31 PM Jani Nikula
> wrote:
>>
>> On Tue, 14 Sep 2021, Lyude Paul wrote:
>> > On Tue, 2021-09-14 at 12:09 +0300, Jani Nikula wrote:
>> >> On Mon, 13 Sep 2021, Vasily Khoruzhick wrote:
>> >> > Panel in my Dell XPS 7590, th
On Sat, 11 Sep 2021, Imran Khan wrote:
> To print stack entries into a buffer, users of stackdepot,
> first get a list of stack entries using stack_depot_fetch
> and then print this list into a buffer using stack_trace_snprint.
> Provide a helper in stackdepot for this purpose.
> Also change above
On Mon, 13 Sep 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Suck the "do we need bigjoiner?" checks into a helper instead of
> duplicating them in two differentt places.
Could've called it intel_dp_need_bigjoiner() but meh.
Reviewed-by: Jani Nikula
>
> Signed-off-by: Ville Syrjälä
>
On Mon, 13 Sep 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> hsw_crtc_compute_clock() has become spaghetti. Flatten
> it a bit to make it at least semi-legible.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_dpll.c | 20 +++
On Mon, 13 Sep 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> PIPECONF becamse TRANSCONF when HSW introduced the EDP transcoder.
> Bigjoiner is making life even more confusing by introducing
> a N:1 relationship between pipes and transcoders. In that case
> we only enable/configure the tran
On Mon, 13 Sep 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Pass the crtc+cpu_transcoder rather than the crtc state to
> intel_dsc_power_domain(). This should allow us to reuse it
> during readout as well.
Reviewed-by: Jani Nikula
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/
On Mon, 13 Sep 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Extract the "panel transcoder" bitmask into a helper. We'll
> have a couple of uses for this later.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 16 +++
On Mon, 13 Sep 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Add a helper to determine the master crtc for bigjoiner usage.
> Also name the variables consistently.
I think this would be a good time to to rename bigjoiner {master, slave}
to {primary, secondary}. The change is coming to bsp
Fixes the following splat:
i915: Running i915_gem_mman_live_selftests/igt_mmap
[ cut here ]
WARNING: CPU: 3 PID: 5654 at include/linux/mmap_lock.h:164 find_vma+0x4e/0xb0
Modules linked in: i915(+) vgem fuse snd_hda_codec_hdmi snd_hda_codec_realtek
snd_hda_codec_generic led
From: Colin Ian King
Don't populate the read-only array states on the stack but instead it
static. Also makes the object code smaller.
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driver
== Series Details ==
Series: drm/i915/display: Fix the dsc check while selecting min_cdclk (rev2)
URL : https://patchwork.freedesktop.org/series/94683/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10588 -> Patchwork_21054
From: Tvrtko Ursulin
It is not very useful to have code which tries to report a rapidly
transient state which will not report anything majority of the time,
especially since it is currently only used from
/i915_gem_framebuffers.
Signed-off-by: Tvrtko Ursulin
Acked-by: Christian König
Cc: Danie
== Series Details ==
Series: drm/i915: Add mmap lock around vma_lookup() to prevent lockdep splats
URL : https://patchwork.freedesktop.org/series/94687/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10588 -> Patchwork_21055
On Wed, Sep 15, 2021 at 01:24:32PM +0300, Jani Nikula wrote:
> On Mon, 13 Sep 2021, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Add a helper to determine the master crtc for bigjoiner usage.
> > Also name the variables consistently.
>
> I think this would be a good time to to rename big
== Series Details ==
Series: drm/i915: Suspend / resume backup- and restore of LMEM. (rev5)
URL : https://patchwork.freedesktop.org/series/94278/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
0dcc28cd9f83 drm/i915/ttm: Implement a function to copy the contents of two
TTM-based
Am 14.09.21 um 19:31 schrieb Matthew Auld:
On Tue, 14 Sept 2021 at 10:03, Christian König wrote:
Am 14.09.21 um 10:50 schrieb Matthew Auld:
Add new flag to indicate special shmem based tt, which can directly
handle swapping itself, and should be visible to some shrinker.
As part of this we sh
On Wed, Sep 15, 2021 at 12:00:28AM +, Souza, Jose wrote:
> On Tue, 2021-09-14 at 16:30 -0700, José Roberto de Souza wrote:
> > On Tue, 2021-09-14 at 11:20 +0300, Ville Syrjälä wrote:
> > > On Mon, Sep 13, 2021 at 04:28:35PM +, Souza, Jose wrote:
> > > > On Mon, 2021-09-13 at 17:44 +0300, Vi
On Wed, Sep 15, 2021 at 01:16:58PM +0300, Jani Nikula wrote:
> On Mon, 13 Sep 2021, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > PIPECONF becamse TRANSCONF when HSW introduced the EDP transcoder.
> > Bigjoiner is making life even more confusing by introducing
> > a N:1 relationship betwee
On Fri, 10 Sep 2021, Randy Dunlap wrote:
> Hi,
>
> I would like to use QHD resolution (2560x1440) with my shiny new
> computer and display. That resolution works if I boot Windows 10
> (cough).
>
> What do I need to do to use that resolution in Linux?
>
> I first tried openSUSE 15.3 (kernel 5.3.18
== Series Details ==
Series: drm/i915: Suspend / resume backup- and restore of LMEM. (rev5)
URL : https://patchwork.freedesktop.org/series/94278/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10589 -> Patchwork_21056
Summar
On Wed, 15 Sep 2021, Ville Syrjälä wrote:
> On Wed, Sep 15, 2021 at 01:16:58PM +0300, Jani Nikula wrote:
>> On Mon, 13 Sep 2021, Ville Syrjala wrote:
>> > From: Ville Syrjälä
>> >
>> > PIPECONF becamse TRANSCONF when HSW introduced the EDP transcoder.
>> > Bigjoiner is making life even more conf
On Wed, 15 Sept 2021 at 12:00, Maarten Lankhorst
wrote:
>
> Fixes the following splat:
>
> i915: Running i915_gem_mman_live_selftests/igt_mmap
> [ cut here ]
> WARNING: CPU: 3 PID: 5654 at include/linux/mmap_lock.h:164 find_vma+0x4e/0xb0
> Modules linked in: i915(+) vgem fu
On Mon, 13 Sep 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Add the _if_enabled() counterpart to with_intel_display_power().
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
Looks like there's plenty of code that could use this.
> ---
> drivers/gpu/drm/i915/display/intel_di
Op 15-09-2021 om 15:19 schreef Matthew Auld:
> On Wed, 15 Sept 2021 at 12:00, Maarten Lankhorst
> wrote:
>> Fixes the following splat:
>>
>> i915: Running i915_gem_mman_live_selftests/igt_mmap
>> [ cut here ]
>> WARNING: CPU: 3 PID: 5654 at include/linux/mmap_lock.h:164 fin
On Fri, 10 Sep 2021, Daniele Ceraolo Spurio
wrote:
> Ahead of the PXP implementation, define the relevant define flag and
> kconfig option.
>
> v2: flip kconfig default to N. Some machines have IFWIs that do not
> support PXP, so we need it to be an opt-in until we add support to query
> the caps
== Series Details ==
Series: drm/i915: make array states static const
URL : https://patchwork.freedesktop.org/series/94688/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10589 -> Patchwork_21057
Summary
---
**FAILURE
On Mon, Sep 13, 2021 at 10:54:14PM +, Souza, Jose wrote:
> On Thu, 2021-09-09 at 23:28 +0300, Ville Syrjälä wrote:
> > On Thu, Sep 09, 2021 at 08:23:20PM +, Souza, Jose wrote:
> > > On Thu, 2021-09-09 at 23:20 +0300, Ville Syrjälä wrote:
> > > > On Thu, Sep 09, 2021 at 12:49:16PM -0700, Jos
On Fri, 10 Sep 2021, Daniele Ceraolo Spurio
wrote:
> diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.h
> b/drivers/gpu/drm/i915/pxp/intel_pxp.h
> new file mode 100644
> index ..e87550fb9821
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/pxp/intel_pxp.h
> @@ -0,0 +1,35 @@
> +/* SPDX-Lic
== Series Details ==
Series: drm/i915/debugfs: Do not report currently active engine when describing
objects
URL : https://patchwork.freedesktop.org/series/94691/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10589 -> Patchwork_21058
==
Am 14.09.21 um 14:47 schrieb Tvrtko Ursulin:
On 14/09/2021 13:32, Christian König wrote:
Am 14.09.21 um 14:27 schrieb Tvrtko Ursulin:
On 13/09/2021 14:16, Christian König wrote:
This is maybe even a fix since the RCU usage here looks incorrect.
What you think is incorrect? Pointless extra
On Tue, Sep 14, 2021 at 08:10:14PM +0300, Jani Nikula wrote:
> On Mon, 13 Sep 2021, Nathan Chancellor wrote:
> > On Tue, Aug 24, 2021 at 03:54:24PM -0700, Nathan Chancellor wrote:
> >> Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings")
> >> disabled -Wsometimes-uninitialized as no
Hi Vlastimil,
On 14/9/21 7:03 pm, Vlastimil Babka wrote:
On 9/10/21 16:10, Imran Khan wrote:
This change is in response to discussion at [1].
The patch has been created on top of my earlier changes [2] and [3].
If needed I can resend all of these patches together, though my
earlier patches have
i915 enables a wider set of warnings with '-Wall -Wextra' then disables
several with cc-disable-warning. If an unknown flag gets added to
KBUILD_CFLAGS when building with clang, all subsequent calls to
cc-{disable-warning,option} will fail, meaning that all of these
warnings do not get disabled [1]
Am 14.09.21 um 15:07 schrieb Tvrtko Ursulin:
On 14/09/2021 12:25, Christian König wrote:
Am 14.09.21 um 12:53 schrieb Tvrtko Ursulin:
On 13/09/2021 14:16, Christian König wrote:
[SNIP]
+ if (fence) {
+ fence = dma_fence_get_rcu(fence);
+ } else if (all_fences && curso
To print a stack entries, users of stackdepot, first
use stack_depot_fetch to get a list of stack entries
and then use stack_trace_print to print this list.
Provide a helper in stackdepot to print stack entries
based on stackdepot handle.
Also change above mentioned users to use this helper.
Signe
stack_depot_save allocates slabs that will be used for storing
objects in future.If this slab allocation fails we may get to
a situation where space allocation for a new stack_record fails,
causing stack_depot_save to return 0 as handle.
If user of this handle ends up invoking stack_depot_fetch wit
To print stack entries into a buffer, users of stackdepot,
first get a list of stack entries using stack_depot_fetch
and then print this list into a buffer using stack_trace_snprint.
Provide a helper in stackdepot for this purpose.
Also change above mentioned users to use this helper.
Signed-off-b
This patch series consolidates the changes submitted and reviewed at [1]
and [2].
The patches at [1] and [2] were submitted separarely, but they have some
inter dependency (later patches were created on top of earlier ones).
As both sets are still under review, I have put them in a single
change se
== Series Details ==
Series: drm/i915: Clean up disabled warnings (rev2)
URL : https://patchwork.freedesktop.org/series/94009/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/i91
Looks good to me.
Reviewed-by: Gwan-gyeong Mun
On 9/15/21 12:25 AM, José Roberto de Souza wrote:
Wa_16014451276 fixes the starting coordinate for PSR2 selective
updates. CHICKEN_TRANS definition of the workaround bit has a wrong
name based on workaround definition and HSD.
Wa_14014971508 allo
On Tue, Sep 14, 2021 at 02:25:05PM -0700, José Roberto de Souza wrote:
> Not sure why but when moving the cursor fast it causes some artifacts
> of the cursor to be left in the cursor path, adding some pixels above
> the cursor to the damaged area fixes the issue, so leaving this as a
> workaround
== Series Details ==
Series: drm/i915: Clean up disabled warnings (rev2)
URL : https://patchwork.freedesktop.org/series/94009/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10590 -> Patchwork_21059
Summary
---
**FAIL
On Mon, Sep 06, 2021 at 08:34:15AM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Mark GPU wedging on driver unregister unrecoverable (rev2)
> URL : https://patchwork.freedesktop.org/series/94247/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_10
On 9/14/2021 12:13 PM, Rodrigo Vivi wrote:
On Fri, Sep 10, 2021 at 08:36:22AM -0700, Daniele Ceraolo Spurio wrote:
From: "Huang, Sean Z"
During the power event S3+ sleep/resume, hardware will lose all the
encryption keys for every hardware session, even though the
session state might still
On Wed, Sep 15, 2021 at 08:11:54AM -0700, Daniele Ceraolo Spurio wrote:
>
>
> On 9/14/2021 12:13 PM, Rodrigo Vivi wrote:
> > On Fri, Sep 10, 2021 at 08:36:22AM -0700, Daniele Ceraolo Spurio wrote:
> > > From: "Huang, Sean Z"
> > >
> > > During the power event S3+ sleep/resume, hardware will los
On Wed, Sep 15, 2021 at 04:29:50PM +0300, Jani Nikula wrote:
> On Fri, 10 Sep 2021, Daniele Ceraolo Spurio
> wrote:
> > Ahead of the PXP implementation, define the relevant define flag and
> > kconfig option.
> >
> > v2: flip kconfig default to N. Some machines have IFWIs that do not
> > support
On Wed, Sep 15, 2021 at 01:12:26PM +0300, Jani Nikula wrote:
> On Mon, 13 Sep 2021, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Suck the "do we need bigjoiner?" checks into a helper instead of
> > duplicating them in two differentt places.
>
> Could've called it intel_dp_need_bigjoiner(
On Wed, Sep 15, 2021 at 04:48:49PM +0300, Ville Syrjälä wrote:
> On Mon, Sep 13, 2021 at 10:54:14PM +, Souza, Jose wrote:
> > On Thu, 2021-09-09 at 23:28 +0300, Ville Syrjälä wrote:
> > > On Thu, Sep 09, 2021 at 08:23:20PM +, Souza, Jose wrote:
> > > > On Thu, 2021-09-09 at 23:20 +0300, Vil
== Series Details ==
Series: lib, stackdepot: check stackdepot handle before accessing slabs
URL : https://patchwork.freedesktop.org/series/94696/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
CALLscripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/genera
Hi Jason, Greg, Daniel, DRM folks,
In DRM-debug currently, drm_debug_enabled() is called a lot to decide
whether or not to write debug messages. Each test is cheap, but costs
continue with uptime. DYNAMIC_DEBUG "dyndbg", when built with
JUMP_LABEL, replaces each of those tests with a patchable N
dd-exec-queries accepts a separate module arg (so it can support
$module.dyndbg cmdline arg), add it to the vpr-info for more context.
Signed-off-by: Jim Cromie
---
lib/dynamic_debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
i
add "bootparam" to format. no functional changes.
Signed-off-by: Jim Cromie
---
lib/dynamic_debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index dfe1e6a857bc..da91ff507117 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_de
change current v*pr_info() calls to fit this new scheme:
-1 module add/remove, callsite counts - a few v2s here now
-2 command ingest, splitting
-3 command parsing - many v1s here now
-4 per-site changes - was v2
2 is new, to isolate a problem where a stress-test script (which feeds
large multi-c
`echo $cmd > control` can be finicky with respect to quoting (mostly
wrt * expansion), so lets not complicate things by adding our own in
debug messages. Quote as <%s> instead of '%s' or \"%s\"
Signed-off-by: Jim Cromie
---
lib/dynamic_debug.c | 16
1 file changed, 8 insertions
On qemu --smp 3 runs, remove-module can get called 3 times.
Instead, print once at end, if entry was found and removed.
Signed-off-by: Jim Cromie
---
lib/dynamic_debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index eac6c6
when `echo $cmd > control` contains multiple queries, extra query
separators (;\n) can parse as empty statements. This is normal, and
pr-info on empty command is just noise. Also change varname.
Signed-off-by: Jim Cromie
---
lib/dynamic_debug.c | 13 +++--
1 file changed, 7 insertions(
DEFINE_DYNAMIC_DEBUG_CATEGORIES(fsname, var, bitmap_desc, @bit_descs)
allows users to create a drm.debug style (bitmap) sysfs interface,
mapping each bit to a pr_debug "category".
Unlike drm, dyndbg has no coding of "category", but it can select a
set of pr_debugs with a substr match on their form
This example uses dyndbg as a core/kernel param; it is a (fake) module
param. Using it as given gets an "Unknown command line parameters:"
warning. Fix the broken example.
Signed-off-by: Jim Cromie
---
Documentation/admin-guide/dynamic-debug-howto.rst | 6 ++
1 file changed, 2 insertions(+
no code changes, good for rc
Signed-off-by: Jim Cromie
---
include/drm/drm_drv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
index b439ae1921b8..ebb22166ace1 100644
--- a/include/drm/drm_drv.h
+++ b/include/drm/drm_drv.h
@@ -5
Taking embedded spaces out of existing prefixes makes them better
class-prefixes; simplifying the extra quoting needed otherwise:
$> echo format "^gvt: core:" +p >control
Dropping the internal spaces means any trailing space in a query will
more clearly terminate the prefix being searched for.
The gvt component of this driver has ~120 pr_debugs, in 9 categories
quite similar to those in DRM. Following the interface model of
drm.debug, add a parameter to map bits to these categorizations.
DEFINE_DYNAMIC_DEBUG_CATEGORIES(debug_gvt, __gvt_debug,
"dyndbg bitmap desc",
_DD_c
logger_types.h defines many DC_LOG_*() categorized debug wrappers.
Most of these already use DRM debug API, so are controllable using
drm.debug, but others use a bare pr_debug("$prefix: .."), with 1 of 13
different class-prefixes matching ~/^\[[_A-Z]+\]:/
Use DEFINE_DYNAMIC_DEBUG_CATEGORIES to cre
drm's debug system writes 10 distinct categories of messages to syslog
using a small API[1]: drm_dbg*(10 names), DRM_DEV_DEBUG*(3 names),
DRM_DEBUG*(8 names). There are thousands of these callsites, each
categorized in this systematized way.
These callsites can be enabled at runtime by their cate
Duplicate drm_debug_enabled() code into both "basic" and "dyndbg"
ifdef branches. Then add a pr_debug("todo: ...") into the "dyndbg"
branch.
Then convert the "dyndbg" branch's code to a macro, so that the
pr_debug() get its callsite info from the invoking function, instead
of from drm_debug_enabl
With DRM_USE_DYNAMIC_DEBUG, each callsite record requires 56 bytes.
We can combine 12 into one here and save ~620 bytes.
Signed-off-by: Jim Cromie
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 36 +--
1 file changed, 23 insertions(+), 13 deletions(-)
diff --git a/drivers/g
There are blocks of DRM_DEBUG calls, consolidate their args into
single calls. With dynamic-debug in use, each callsite consumes 56
bytes of callsite data, and this patch removes about 65 calls, so
it saves ~3.5kb.
no functional changes.
RFC: this creates multi-line log messages, does that break
On Wed, Sep 15, 2021 at 06:57:19PM +0300, Ville Syrjälä wrote:
> On Wed, Sep 15, 2021 at 04:48:49PM +0300, Ville Syrjälä wrote:
> > On Mon, Sep 13, 2021 at 10:54:14PM +, Souza, Jose wrote:
> > > On Thu, 2021-09-09 at 23:28 +0300, Ville Syrjälä wrote:
> > > > On Thu, Sep 09, 2021 at 08:23:20PM +
== Series Details ==
Series: use DYNAMIC_DEBUG to implement DRM.debug (rev3)
URL : https://patchwork.freedesktop.org/series/93914/
State : failure
== Summary ==
Applying: dyndbg: add module to a vpr-info in dd-exec-queries
Applying: dyndbg: pr-info in boot-param should say so
Applying: dyndbg:
On Wed, Sep 15, 2021 at 09:24:15AM +0100, Tvrtko Ursulin wrote:
>
> On 14/09/2021 19:04, Matthew Brost wrote:
> > On Tue, Sep 14, 2021 at 09:34:08AM +0100, Tvrtko Ursulin wrote:
> > >
>
> 8<
>
> > > Today we have:
> > >
> > > for_each intel_engines: // intel_engines is a flat list of all engin
From: Caz Yokoyama
Do not overwrite registers that don't need to change from default
value to 0.
bspec 49213
Cc: Radhakrishna Sripada
Cc: José Roberto de Souza
Cc: Matt Roper
Signed-off-by: Caz Yokoyama
---
drivers/gpu/drm/i915/display/intel_display.c | 13 +
1 file changed, 9 i
On Wed, 2021-09-15 at 10:10 -0700, Yokoyama, Caz wrote:
> From: Caz Yokoyama
>
> Do not overwrite registers that don't need to change from default
> value to 0.
Reviewed-by: José Roberto de Souza
>
> bspec 49213
> Cc: Radhakrishna Sripada
> Cc: José Roberto de Souza
> Cc: Matt Roper
> Sign
I don't really see how this patch could be responsible for either this
or the sparse report that I got... it is a simple build time change,
nothing at runtime should be affected.
Cheers,
Nathan
On Wed, Sep 15, 2021 at 03:00:19PM -, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915
== Series Details ==
Series: series starting with [1/1] drm/i915/adlp: Keep hardware default dbox B
credits
URL : https://patchwork.freedesktop.org/series/94702/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10592 -> Patchwork_21062
===
On Wed, 2021-09-15 at 17:58 +0300, Ville Syrjälä wrote:
> On Tue, Sep 14, 2021 at 02:25:05PM -0700, José Roberto de Souza wrote:
> > Not sure why but when moving the cursor fast it causes some artifacts
> > of the cursor to be left in the cursor path, adding some pixels above
> > the cursor to the
In commit:
commit 58aa6622d32af7d2c08d45085f44c54554a16ed7
Author: Thomas Hellstrom
Date: Fri Jan 3 11:47:23 2014 +0100
drm/ttm: Correctly set page mapping and -index members
we started setting the page->mapping and page->index to point to the
virtual address space, if the pages were faul
Now that setting page->index shouldn't be needed anymore, we are just
left with setting page->mapping, and here it looks like amdgpu is the
only user, where pointing the page->mapping at the dev_mapping is used
to verify that the pages do indeed belong to the device, if userspace
later tries to tou
No longer used it seems.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
Cc: Christian König
---
include/drm/ttm/ttm_tt.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/drm/ttm/ttm_tt.h b/include/drm/ttm/ttm_tt.h
index 89b15d673b22..842ce756213c 100644
--- a/include/drm/ttm/ttm_tt
Move it to inline kernel-doc, otherwise we can't add empty lines it
seems. Also drop the kernel-doc for pages_list, which doesn't seem to
exist, and get rid of all the strange holes.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
Cc: Christian König
---
include/drm/ttm/ttm_tt.h | 57
In commit:
commit 667a50db0477d47fdff01c666f5ee1ce26b5264c
Author: Thomas Hellstrom
Date: Fri Jan 3 11:17:18 2014 +0100
drm/ttm: Refuse to fault (prime-) imported pages
we introduced the restriction that imported pages should not be directly
mappable through TTM(this also extends to userp
It covers more than just ttm_bo_type_sg usage, like with say dma-buf,
since one other user is userptr in amdgpu, and in the future we might
have some more. Hence EXTERNAL is likely a more suitable name.
Suggested-by: Christian König
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
Cc: Christian
From: Thomas Hellström
Break out some shmem backend utils for future reuse by the TTM backend:
shmem_alloc_st(), shmem_free_st() and __shmem_writeback() which we can
use to provide a shmem-backed TTM page pool for cached-only TTM
buffer objects.
Main functional change here is that we now compute
This should let us do an accelerated copy directly to the shmem pages
when temporarily moving lmem-only objects, where the i915-gem shrinker
can later kick in to swap out the pages, if needed.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 8 -
For cached objects we can allocate our pages directly in shmem. This
should make it possible(in a later patch) to utilise the existing
i915-gem shrinker code for such objects. For now this is still disabled.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
Cc: Christian König
---
drivers/gpu/d
Drop the atomic shrink_pin stuff, and just have make_{un}shrinkable
update the shrinker visible lists immediately. This at least simplifies
the next patch, and does make the behaviour more obvious. The potential
downside is that make_unshrinkable now grabs a global lock even when the
object itself
We currently just evict lmem objects to system memory when under memory
pressure. For this case we lack the usual object mm.pages, which
effectively hides the pages from the i915-gem shrinker, until we
actually "attach" the TT to the object, or in the case of lmem-only
objects it just gets migrated
Enable shmem tt backend, and enable shrinking.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index e758de336b96..
== Series Details ==
Series: series starting with [v2,1/5] drm/i915/display/adlp: Fix
PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR calculation (rev2)
URL : https://patchwork.freedesktop.org/series/94674/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10593 -> Patchwork_21063
==
On 8/20/2021 15:44, Matthew Brost wrote:
Add multi-lrc context registration H2G. In addition a workqueue and
process descriptor are setup during multi-lrc context registration as
these data structures are needed for multi-lrc submission.
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/i915/g
On 9/14/2021 12:51 PM, Lucas De Marchi wrote:
The clflush calls here aren't doing anything since we are not writting
something and flushing the cache lines to be visible to GuC. Here the
intention seems to be to make sure whatever GuC has written is visible
to the CPU before we read them. Howe
On 8/20/2021 15:44, Matthew Brost wrote:
In GuC parent-child contexts the parent context controls the scheduling,
ensure only the parent does the scheduling operations.
Signed-off-by: Matthew Brost
---
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 24 ++-
1 file changed, 18
On 9/15/2021 12:24, Belgaumkar, Vinay wrote:
On 9/14/2021 12:51 PM, Lucas De Marchi wrote:
The clflush calls here aren't doing anything since we are not writting
something and flushing the cache lines to be visible to GuC. Here the
intention seems to be to make sure whatever GuC has written is v
In capture_vma() Coverity complains of a possible buffer overrun. Even
though this is a static function where all call sites can be checked,
limiting the copy length could save some future grief.
CID 93300 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW)
4. fixed_size_dest: You might overr
== Series Details ==
Series: series starting with [v3,01/12] drm/ttm: stop setting page->index for
the ttm_tt
URL : https://patchwork.freedesktop.org/series/94705/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
13d749649308 drm/ttm: stop setting page->index for the ttm_tt
-:11:
== Series Details ==
Series: series starting with [v3,01/12] drm/ttm: stop setting page->index for
the ttm_tt
URL : https://patchwork.freedesktop.org/series/94705/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be chec
On Wed, Sep 15, 2021 at 12:21:35PM -0700, John Harrison wrote:
> On 8/20/2021 15:44, Matthew Brost wrote:
> > Add multi-lrc context registration H2G. In addition a workqueue and
> > process descriptor are setup during multi-lrc context registration as
> > these data structures are needed for multi-
On Wed, Sep 15, 2021 at 12:24:41PM -0700, John Harrison wrote:
> On 8/20/2021 15:44, Matthew Brost wrote:
> > In GuC parent-child contexts the parent context controls the scheduling,
> > ensure only the parent does the scheduling operations.
> >
> > Signed-off-by: Matthew Brost
> > ---
> > .../
On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote:
> From: Rajat Jain
>
> Add support for generic electronic privacy screen properties, that
> can be added by systems that have an integrated EPS.
>
> Changes in v2 (Hans de Goede)
> - Create 2 properties, "privacy-screen sw-state" and
> "p
On Wed, 2021-09-15 at 16:48 +0300, Ville Syrjälä wrote:
> On Mon, Sep 13, 2021 at 10:54:14PM +, Souza, Jose wrote:
> > On Thu, 2021-09-09 at 23:28 +0300, Ville Syrjälä wrote:
> > > On Thu, Sep 09, 2021 at 08:23:20PM +, Souza, Jose wrote:
> > > > On Thu, 2021-09-09 at 23:20 +0300, Ville Syrj
> -Original Message-
> From: Kai Vehmanen
> Sent: Monday, September 13, 2021 10:10 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Shankar, Uma ; ville.syrj...@linux.intel.com;
> Nikula,
> Jani ; Kai Vehmanen
> Subject: [PATCH v2] drm/i915/display: program audio CDCLK-TS for keepalives
1 - 100 of 143 matches
Mail list logo
