Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2021-09-14 Thread Lisovskiy, Stanislav
On Mon, Sep 13, 2021 at 08:09:23PM +0530, Vandita Kulkarni wrote: > Each VDSC operates with 1ppc throughput, hence enable the second > VDSC engine when moderate is higher that the current cdclk. > > Signed-off-by: Vandita Kulkarni > --- > drivers/gpu/drm/i915/display/intel_dp.c | 12 ++--

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2021-09-14 Thread Ville Syrjälä
On Mon, Sep 13, 2021 at 08:09:23PM +0530, Vandita Kulkarni wrote: > Each VDSC operates with 1ppc throughput, hence enable the second > VDSC engine when moderate is higher that the current cdclk. > > Signed-off-by: Vandita Kulkarni > --- > drivers/gpu/drm/i915/display/intel_dp.c | 12 ++--

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2021-09-14 Thread Kulkarni, Vandita
> -Original Message- > From: Ville Syrjälä > Sent: Tuesday, September 14, 2021 12:59 PM > To: Kulkarni, Vandita > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani ; > Navare, Manasi D > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC > engine for higher moderates >

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2021-09-14 Thread Kulkarni, Vandita
> -Original Message- > From: Lisovskiy, Stanislav > Sent: Tuesday, September 14, 2021 12:49 PM > To: Kulkarni, Vandita > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani ; > Navare, Manasi D > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC > engine for higher mode

Re: [Intel-gfx] [PATCH 04/14] drm/hdcp: Expand HDCP helper library for enable/disable/check

2021-09-14 Thread kernel test robot
Hi Sean, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.15-rc1 next-20210914] [cannot apply to drm-intel/for-linux-next drm/drm-next] [If your patch

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2021-09-14 Thread Ville Syrjälä
On Tue, Sep 14, 2021 at 07:31:46AM +, Kulkarni, Vandita wrote: > > -Original Message- > > From: Ville Syrjälä > > Sent: Tuesday, September 14, 2021 12:59 PM > > To: Kulkarni, Vandita > > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani ; > > Navare, Manasi D > > Subject: Re: [Intel-

Re: [Intel-gfx] [PATCH 01/16] Revert "drm/i915/display: Disable audio, DRRS and PSR before planes"

2021-09-14 Thread Ville Syrjälä
On Mon, Sep 13, 2021 at 04:28:35PM +, Souza, Jose wrote: > On Mon, 2021-09-13 at 17:44 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Disabling planes in the middle of the modeset seuqnece does not make > > sense since userspace can anyway disable planes before the modeset > > ev

Re: [Intel-gfx] [RFC PATCH] drm/ttm: Add a private member to the struct ttm_resource

2021-09-14 Thread Thomas Hellström
On Tue, 2021-09-14 at 09:40 +0200, Christian König wrote: > Am 13.09.21 um 14:41 schrieb Thomas Hellström: > > [SNIP] > > > > > Let's say you have a struct ttm_object_vram and a struct > > > > > ttm_object_gtt, both subclassing drm_gem_object. Then I'd say > > > > > a > > > > > driver would want

Re: [Intel-gfx] [PATCH 08/27] drm/i915: Add logical engine mapping

2021-09-14 Thread Tvrtko Ursulin
On 13/09/2021 17:50, Matthew Brost wrote: On Mon, Sep 13, 2021 at 10:24:43AM +0100, Tvrtko Ursulin wrote: On 10/09/2021 20:49, Matthew Brost wrote: On Fri, Sep 10, 2021 at 12:12:42PM +0100, Tvrtko Ursulin wrote: On 20/08/2021 23:44, Matthew Brost wrote: Add logical engine mapping. This is

Re: [Intel-gfx] [PATCH v2 0/6] drm/displayid: VESA vendor block and drm/i915 MSO use of it

2021-09-14 Thread Maxime Ripard
Hi, On Mon, Sep 13, 2021 at 07:45:03PM +0300, Jani Nikula wrote: > On Tue, 31 Aug 2021, Jani Nikula wrote: > > v2 of https://patchwork.freedesktop.org/series/94161/ with the VESA OUI > > check and an OUI helper patch added. > > Maarten, Maxime, Thomas - may I have an ack for merging this via > d

Re: [Intel-gfx] [PATCH 04/27] drm/i915/guc: Take GT PM ref when deregistering context

2021-09-14 Thread Tvrtko Ursulin
On 13/09/2021 18:12, Matthew Brost wrote: On Mon, Sep 13, 2021 at 10:55:59AM +0100, Tvrtko Ursulin wrote: On 20/08/2021 23:44, Matthew Brost wrote: Taking a PM reference to prevent intel_gt_wait_for_idle from short circuiting while a deregister context H2G is in flight. FIXME: Move locking

[Intel-gfx] [PATCH v2 1/7] drm/i915/gem: Break out some shmem backend utils

2021-09-14 Thread Matthew Auld
From: Thomas Hellström Break out some shmem backend utils for future reuse by the TTM backend: shmem_alloc_st(), shmem_free_st() and __shmem_writeback() which we can use to provide a shmem-backed TTM page pool for cached-only TTM buffer objects. Main functional change here is that we now compute

[Intel-gfx] [PATCH v2 2/7] drm/ttm: add TTM_PAGE_FLAG_SHMEM

2021-09-14 Thread Matthew Auld
Add new flag to indicate special shmem based tt, which can directly handle swapping itself, and should be visible to some shrinker. As part of this we should skip the ttm_pages_allocated accounting, since such tt objects should already be reachable, and potentially reclaimable by some shrinker, if

[Intel-gfx] [PATCH v2 3/7] drm/i915/ttm: add tt shmem backend

2021-09-14 Thread Matthew Auld
For cached objects we can allocate our pages directly in shmem. This should make it possible(in a later patch) to utilise the existing i915-gem shrinker code for such objects. For now this is still disabled. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Christian König --- drivers/gpu/d

[Intel-gfx] [PATCH v2 4/7] drm/i915/ttm: use cached system pages when evicting lmem

2021-09-14 Thread Matthew Auld
This should let us do an accelerated copy directly to the shmem pages when temporarily moving lmem-only objects, where the i915-gem shrinker can later kick in to swap out the pages, if needed. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 8 -

[Intel-gfx] [PATCH v2 5/7] drm/i915: try to simplify make_{un}shrinkable

2021-09-14 Thread Matthew Auld
Drop the atomic shrink_pin stuff, and just have make_{un}shrinkable update the shrinker visible lists immediately. This at least simplifies the next patch, and does make the behaviour more obvious. The potential downside is that make_unshrinkable now grabs a global lock even when the object itself

[Intel-gfx] [PATCH v2 6/7] drm/i915/ttm: make evicted shmem pages visible to the shrinker

2021-09-14 Thread Matthew Auld
We currently just evict lmem objects to system memory when under memory pressure. For this case we lack the usual object mm.pages, which effectively hides the pages from the i915-gem shrinker, until we actually "attach" the TT to the object, or in the case of lmem-only objects it just gets migrated

[Intel-gfx] [PATCH v2 7/7] drm/i915/ttm: enable shmem tt backend

2021-09-14 Thread Matthew Auld
Enable shmem tt backend, and enable shrinking. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c index f02037a8cebd..

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2021-09-14 Thread Lisovskiy, Stanislav
On Tue, Sep 14, 2021 at 10:48:46AM +0300, Ville Syrjälä wrote: > On Tue, Sep 14, 2021 at 07:31:46AM +, Kulkarni, Vandita wrote: > > > -Original Message- > > > From: Ville Syrjälä > > > Sent: Tuesday, September 14, 2021 12:59 PM > > > To: Kulkarni, Vandita > > > Cc: intel-gfx@lists.fre

Re: [Intel-gfx] [PATCH 0/1] lib, stackdepot: Add helper to print stack entries into buffer.

2021-09-14 Thread Vlastimil Babka
On 9/10/21 16:10, Imran Khan wrote: > This change is in response to discussion at [1]. > The patch has been created on top of my earlier changes [2] and [3]. > If needed I can resend all of these patches together, though my > earlier patches have been Acked. I think you sent those at the beginning

Re: [Intel-gfx] [PATCH] drm/i915/dp: add a delay before setting panel brightness after power on

2021-09-14 Thread Jani Nikula
On Mon, 13 Sep 2021, Vasily Khoruzhick wrote: > Panel in my Dell XPS 7590, that uses Intel's HDR backlight interface to > control brightness, apparently needs a delay before setting brightness > after power on. Without this delay the panel does accept the setting > and may come up with some arbitr

[Intel-gfx] [PATCH] drm/i915: Remove warning from the rps worker

2021-09-14 Thread Tejas Upadhyay
In commit 4e5c8a99e1cb ("drm/i915: Drop i915_request.lock requirement for intel_rps_boost()"), we decoupled the rps worker from the pm so that we could avoid the synchronization penalty which makes the assertion liable to run too early. Which makes warning invalid hence removed. Fixes: 4e5c8a99e1c

Re: [Intel-gfx] [PATCH 1/4] drm/i915: rename debugfs_gt files

2021-09-14 Thread Jani Nikula
On Wed, 08 Sep 2021, Lucas De Marchi wrote: > We shouldn't be using debugfs_ namespace for this functionality. Rename > debugfs_gt.[ch] to intel_gt_debugfs.[ch] and then make functions, > defines and structs follow suit. > > While at it and since we are renaming the header, sort the includes > alp

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for kernel/locking: Add context to ww_mutex_trylock. (rev4)

2021-09-14 Thread Patchwork
== Series Details == Series: kernel/locking: Add context to ww_mutex_trylock. (rev4) URL : https://patchwork.freedesktop.org/series/94437/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3e5b7ed1e30d kernel/locking: Add context to ww_mutex_trylock. -:9: WARNING:COMMIT_LOG_LONG_LI

[Intel-gfx] ✗ Fi.CI.BAT: failure for kernel/locking: Add context to ww_mutex_trylock. (rev4)

2021-09-14 Thread Patchwork
== Series Details == Series: kernel/locking: Add context to ww_mutex_trylock. (rev4) URL : https://patchwork.freedesktop.org/series/94437/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10579 -> Patchwork_21036 Summary -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/7] drm/i915/gem: Break out some shmem backend utils

2021-09-14 Thread Patchwork
== Series Details == Series: series starting with [v2,1/7] drm/i915/gem: Break out some shmem backend utils URL : https://patchwork.freedesktop.org/series/94648/ State : warning == Summary == $ dim checkpatch origin/drm-tip d3fcbc14d6ee drm/i915/gem: Break out some shmem backend utils 5e8ae12

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/7] drm/i915/gem: Break out some shmem backend utils

2021-09-14 Thread Patchwork
== Series Details == Series: series starting with [v2,1/7] drm/i915/gem: Break out some shmem backend utils URL : https://patchwork.freedesktop.org/series/94648/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checke

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/7] drm/i915/gem: Break out some shmem backend utils

2021-09-14 Thread Patchwork
== Series Details == Series: series starting with [v2,1/7] drm/i915/gem: Break out some shmem backend utils URL : https://patchwork.freedesktop.org/series/94648/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10579 -> Patchwork_21037 ===

Re: [Intel-gfx] [PATCH 15/26] drm/i915: use the new iterator in i915_request_await_object

2021-09-14 Thread Tvrtko Ursulin
On 13/09/2021 14:16, Christian König wrote: Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_request.c | 36 ++--- 1 file changed, 7 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/g

Re: [Intel-gfx] [RFC PATCH] drm/ttm: Add a private member to the struct ttm_resource

2021-09-14 Thread Thomas Hellström
On Tue, 2021-09-14 at 10:53 +0200, Christian König wrote: > Am 14.09.21 um 10:27 schrieb Thomas Hellström: > > On Tue, 2021-09-14 at 09:40 +0200, Christian König wrote: > > > Am 13.09.21 um 14:41 schrieb Thomas Hellström: > > > > [SNIP] > > > > > > > Let's say you have a struct ttm_object_vram and

Re: [Intel-gfx] [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked

2021-09-14 Thread Tvrtko Ursulin
On 13/09/2021 14:16, Christian König wrote: Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences where we can be sure we grabbed the right one. Signed-off-by: Christian König --- drivers/dm

Re: [Intel-gfx] [PATCH 15/26] drm/i915: use the new iterator in i915_request_await_object

2021-09-14 Thread Tvrtko Ursulin
On 14/09/2021 11:39, Christian König wrote: Am 14.09.21 um 12:26 schrieb Tvrtko Ursulin: On 13/09/2021 14:16, Christian König wrote: Simplifying the code a bit. Signed-off-by: Christian König ---   drivers/gpu/drm/i915/i915_request.c | 36 ++---   1 file changed, 7 i

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Remove warning from the rps worker

2021-09-14 Thread Patchwork
== Series Details == Series: drm/i915: Remove warning from the rps worker URL : https://patchwork.freedesktop.org/series/94650/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10580 -> Patchwork_21038 Summary --- **FAI

Re: [Intel-gfx] [RFC PATCH] drm/ttm: Add a private member to the struct ttm_resource

2021-09-14 Thread Christian König
Am 13.09.21 um 14:41 schrieb Thomas Hellström: [SNIP] Let's say you have a struct ttm_object_vram and a struct ttm_object_gtt, both subclassing drm_gem_object. Then I'd say a driver would want to subclass those to attach identical data, extend functionality and provide a single i915_gem_object

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2021-09-14 Thread Jani Nikula
On Tue, 14 Sep 2021, "Lisovskiy, Stanislav" wrote: > On Tue, Sep 14, 2021 at 10:48:46AM +0300, Ville Syrjälä wrote: >> On Tue, Sep 14, 2021 at 07:31:46AM +, Kulkarni, Vandita wrote: >> > > -Original Message- >> > > From: Ville Syrjälä >> > > Sent: Tuesday, September 14, 2021 12:59 PM

[Intel-gfx] [PATCH v2 1/1] lib, stackdepot: Add helper to print stack entries into buffer.

2021-09-14 Thread Imran Khan
To print stack entries into a buffer, users of stackdepot, first get a list of stack entries using stack_depot_fetch and then print this list into a buffer using stack_trace_snprint. Provide a helper in stackdepot for this purpose. Also change above mentioned users to use this helper. Signed-off-b

Re: [Intel-gfx] [PATCH 15/26] drm/i915: use the new iterator in i915_request_await_object

2021-09-14 Thread Christian König
Am 14.09.21 um 12:26 schrieb Tvrtko Ursulin: On 13/09/2021 14:16, Christian König wrote: Simplifying the code a bit. Signed-off-by: Christian König ---   drivers/gpu/drm/i915/i915_request.c | 36 ++---   1 file changed, 7 insertions(+), 29 deletions(-) diff --git a/dri

Re: [Intel-gfx] [PATCH 1/1] lib, stackdepot: Add helper to print stack entries into buffer.

2021-09-14 Thread imran . f . khan
On 13/9/21 6:51 pm, Vlastimil Babka wrote: On 9/10/21 16:10, Imran Khan wrote: To print stack entries into a buffer, users of stackdepot, first get a list of stack entries using stack_depot_fetch and then print this list into a buffer using stack_trace_snprint. Provide a helper in stackdepot

Re: [Intel-gfx] [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked

2021-09-14 Thread Christian König
Am 14.09.21 um 12:53 schrieb Tvrtko Ursulin: On 13/09/2021 14:16, Christian König wrote: Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences where we can be sure we grabbed the right one. Sig

[Intel-gfx] [PATCH v2 0/1] lib, stackdepot: Add helper to print stack entries into buffer.

2021-09-14 Thread Imran Khan
Changes in v2: - Addressed review comment. - Added Acked from Vlastimil. - Fixed one mistake, due to which stack_trace_snprint was always getting invoked with 0 as space value. Changed it to make use of space argument, because users that are printing stack entries into buffer, may

Re: [Intel-gfx] [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine

2021-09-14 Thread Tvrtko Ursulin
On 13/09/2021 14:16, Christian König wrote: This is maybe even a fix since the RCU usage here looks incorrect. What you think is incorrect? Pointless extra rcu locking? Also, FWIW, I submitted a patch to remove this function altogether since its IMO pretty useless, just failed in getting an

Re: [Intel-gfx] [PATCH 2/5] drm/i915/display/adlp: Add new PSR2 workarounds

2021-09-14 Thread Gwan-gyeong Mun
On 9/13/21 8:00 PM, Souza, Jose wrote: On Mon, 2021-09-13 at 19:09 +0300, Gwan-gyeong Mun wrote: On 9/10/21 7:29 PM, Souza, Jose wrote: On Fri, 2021-09-10 at 16:38 +0300, Gwan-gyeong Mun wrote: On 9/10/21 2:07 AM, José Roberto de Souza wrote: Wa_16014451276 fixes the starting coordinate

Re: [Intel-gfx] [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine

2021-09-14 Thread Christian König
Am 14.09.21 um 14:27 schrieb Tvrtko Ursulin: On 13/09/2021 14:16, Christian König wrote: This is maybe even a fix since the RCU usage here looks incorrect. What you think is incorrect? Pointless extra rcu locking? Yeah, exactly that. I also wondered for a second if rcu_read_lock() can nest

Re: [Intel-gfx] [PATCH 17/26] drm/i915: use new iterator in i915_gem_object_wait_priority

2021-09-14 Thread Tvrtko Ursulin
On 13/09/2021 14:16, Christian König wrote: Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 29 1 file changed, 5 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/driv

Re: [Intel-gfx] [PATCH 4/5] drm/i915/display/psr: Use drm damage helpers to calculate plane damaged area

2021-09-14 Thread Gwan-gyeong Mun
On 9/13/21 7:45 PM, Souza, Jose wrote: On Mon, 2021-09-13 at 19:03 +0300, Gwan-gyeong Mun wrote: On 9/10/21 2:07 AM, José Roberto de Souza wrote: drm_atomic_helper_damage_iter_init() + drm_atomic_for_each_plane_damage() returns the full plane area in case no damaged area was set by userspac

Re: [Intel-gfx] [PATCH v2] kernel/locking: Add context to ww_mutex_trylock.

2021-09-14 Thread Maarten Lankhorst
Op 14-09-2021 om 08:50 schreef Peter Zijlstra: > On Mon, Sep 13, 2021 at 10:42:36AM +0200, Maarten Lankhorst wrote: > >>> +/** >>> + * ww_mutex_trylock - tries to acquire the w/w mutex with optional acquire >>> context >>> + * @ww: mutex to lock >>> + * @ww_ctx: optional w/w acquire context >>> +

Re: [Intel-gfx] [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine

2021-09-14 Thread Tvrtko Ursulin
On 14/09/2021 13:32, Christian König wrote: Am 14.09.21 um 14:27 schrieb Tvrtko Ursulin: On 13/09/2021 14:16, Christian König wrote: This is maybe even a fix since the RCU usage here looks incorrect. What you think is incorrect? Pointless extra rcu locking? Yeah, exactly that. I also won

Re: [Intel-gfx] [RFC PATCH] drm/ttm: Add a private member to the struct ttm_resource

2021-09-14 Thread Christian König
Am 14.09.21 um 10:27 schrieb Thomas Hellström: On Tue, 2021-09-14 at 09:40 +0200, Christian König wrote: Am 13.09.21 um 14:41 schrieb Thomas Hellström: [SNIP] Let's say you have a struct ttm_object_vram and a struct ttm_object_gtt, both subclassing drm_gem_object. Then I'd say a driver would w

Re: [Intel-gfx] [PATCH v2 2/7] drm/ttm: add TTM_PAGE_FLAG_SHMEM

2021-09-14 Thread Christian König
Am 14.09.21 um 10:50 schrieb Matthew Auld: Add new flag to indicate special shmem based tt, which can directly handle swapping itself, and should be visible to some shrinker. As part of this we should skip the ttm_pages_allocated accounting, since such tt objects should already be reachable, and

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2021-09-14 Thread Lisovskiy, Stanislav
On Tue, Sep 14, 2021 at 03:04:11PM +0300, Jani Nikula wrote: > On Tue, 14 Sep 2021, "Lisovskiy, Stanislav" > wrote: > > On Tue, Sep 14, 2021 at 10:48:46AM +0300, Ville Syrjälä wrote: > >> On Tue, Sep 14, 2021 at 07:31:46AM +, Kulkarni, Vandita wrote: > >> > > -Original Message- > >> >

Re: [Intel-gfx] [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked

2021-09-14 Thread Tvrtko Ursulin
On 14/09/2021 12:25, Christian König wrote: Am 14.09.21 um 12:53 schrieb Tvrtko Ursulin: On 13/09/2021 14:16, Christian König wrote: Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences wher

Re: [Intel-gfx] [PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl

2021-09-14 Thread Tvrtko Ursulin
On 13/09/2021 14:16, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_busy.c | 30 +++- 1 file changed, 9 insertions(+), 21 deletions

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2021-09-14 Thread Lisovskiy, Stanislav
On Tue, Sep 14, 2021 at 04:04:25PM +0300, Lisovskiy, Stanislav wrote: > On Tue, Sep 14, 2021 at 03:04:11PM +0300, Jani Nikula wrote: > > On Tue, 14 Sep 2021, "Lisovskiy, Stanislav" > > wrote: > > > On Tue, Sep 14, 2021 at 10:48:46AM +0300, Ville Syrjälä wrote: > > >> On Tue, Sep 14, 2021 at 07:31

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Add support for querying hw info that UMDs need (rev3)

2021-09-14 Thread Patchwork
== Series Details == Series: Add support for querying hw info that UMDs need (rev3) URL : https://patchwork.freedesktop.org/series/94305/ State : failure == Summary == Applying: drm/i915/guc: Add fetch of hwconfig table error: sha1 information is lacking or useless (drivers/gpu/drm/i915/Makefi

[Intel-gfx] ✗ Fi.CI.BUILD: failure for lib, stackdepot: Add helper to print stack entries into buffer.

2021-09-14 Thread Patchwork
== Series Details == Series: lib, stackdepot: Add helper to print stack entries into buffer. URL : https://patchwork.freedesktop.org/series/94655/ State : failure == Summary == Applying: lib, stackdepot: Add helper to print stack entries into buffer. error: sha1 information is lacking or usele

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Move vfio_ccw to the new mdev API (rev2)

2021-09-14 Thread Patchwork
== Series Details == Series: Move vfio_ccw to the new mdev API (rev2) URL : https://patchwork.freedesktop.org/series/94520/ State : failure == Summary == Applying: Move vfio_ccw to the new mdev API error: sha1 information is lacking or useless (drivers/s390/cio/vfio_ccw_fsm.c). error: could no

Re: [Intel-gfx] [PATCH v2] kernel/locking: Add context to ww_mutex_trylock.

2021-09-14 Thread Daniel Vetter
On Tue, Sep 14, 2021 at 02:43:02PM +0200, Maarten Lankhorst wrote: > Op 14-09-2021 om 08:50 schreef Peter Zijlstra: > > On Mon, Sep 13, 2021 at 10:42:36AM +0200, Maarten Lankhorst wrote: > > > >>> +/** > >>> + * ww_mutex_trylock - tries to acquire the w/w mutex with optional > >>> acquire context

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2021-09-14 Thread Jani Nikula
On Tue, 14 Sep 2021, "Lisovskiy, Stanislav" wrote: > On Tue, Sep 14, 2021 at 04:04:25PM +0300, Lisovskiy, Stanislav wrote: >> On Tue, Sep 14, 2021 at 03:04:11PM +0300, Jani Nikula wrote: >> > On Tue, 14 Sep 2021, "Lisovskiy, Stanislav" >> > wrote: >> > > On Tue, Sep 14, 2021 at 10:48:46AM +0300

Re: [Intel-gfx] [RFC PATCH] drm/ttm: Add a private member to the struct ttm_resource

2021-09-14 Thread Daniel Vetter
On Tue, Sep 14, 2021 at 12:38:00PM +0200, Thomas Hellström wrote: > On Tue, 2021-09-14 at 10:53 +0200, Christian König wrote: > > Am 14.09.21 um 10:27 schrieb Thomas Hellström: > > > On Tue, 2021-09-14 at 09:40 +0200, Christian König wrote: > > > > Am 13.09.21 um 14:41 schrieb Thomas Hellström: > >

Re: [Intel-gfx] [PATCH 2/4] drm/i915/guc: Do error capture asynchronously

2021-09-14 Thread Daniel Vetter
On Mon, Sep 13, 2021 at 10:09:54PM -0700, Matthew Brost wrote: > An error capture allocates memory, memory allocations depend on resets, > and resets need to flush the G2H handlers to seal several races. If the > error capture is done from the G2H handler this creates a circular > dependency. To wo

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Refcount context during error capture

2021-09-14 Thread Daniel Vetter
On Mon, Sep 13, 2021 at 10:09:56PM -0700, Matthew Brost wrote: > From: John Harrison > > When i915 receives a context reset notification from GuC, it triggers > an error capture before resetting any outstanding requsts of that > context. Unfortunately, the error capture is not a time bound > oper

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2021-09-14 Thread Kulkarni, Vandita
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, September 14, 2021 7:33 PM > To: Lisovskiy, Stanislav > Cc: Ville Syrjälä ; Kulkarni, Vandita > ; intel-gfx@lists.freedesktop.org; Navare, > Manasi D > Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC > engin

Re: [Intel-gfx] [PATCH 1/4] drm/i915: rename debugfs_gt files

2021-09-14 Thread Lucas De Marchi
On Tue, Sep 14, 2021 at 12:16:13PM +0300, Jani Nikula wrote: On Wed, 08 Sep 2021, Lucas De Marchi wrote: We shouldn't be using debugfs_ namespace for this functionality. Rename debugfs_gt.[ch] to intel_gt_debugfs.[ch] and then make functions, defines and structs follow suit. While at it and si

Re: [Intel-gfx] [PATCH 1/4] drm/i915: rename debugfs_gt files

2021-09-14 Thread Jani Nikula
On Tue, 14 Sep 2021, Lucas De Marchi wrote: > On Tue, Sep 14, 2021 at 12:16:13PM +0300, Jani Nikula wrote: >>On Wed, 08 Sep 2021, Lucas De Marchi wrote: >>> We shouldn't be using debugfs_ namespace for this functionality. Rename >>> debugfs_gt.[ch] to intel_gt_debugfs.[ch] and then make functions

Re: [Intel-gfx] [PATCH] drm/i915/display: Enable second VDSC engine for higher moderates

2021-09-14 Thread Jani Nikula
On Tue, 14 Sep 2021, "Kulkarni, Vandita" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Tuesday, September 14, 2021 7:33 PM >> To: Lisovskiy, Stanislav >> Cc: Ville Syrjälä ; Kulkarni, Vandita >> ; intel-gfx@lists.freedesktop.org; Navare, >> Manasi D >> Subject: Re: [Intel-

Re: [Intel-gfx] [RFC PATCH] drm/ttm: Add a private member to the struct ttm_resource

2021-09-14 Thread Thomas Hellström
On 9/14/21 4:07 PM, Daniel Vetter wrote: On Tue, Sep 14, 2021 at 12:38:00PM +0200, Thomas Hellström wrote: On Tue, 2021-09-14 at 10:53 +0200, Christian König wrote: Am 14.09.21 um 10:27 schrieb Thomas Hellström: On Tue, 2021-09-14 at 09:40 +0200, Christian König wrote: Am 13.09.21 um 14:41

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Do not define vma on stack

2021-09-14 Thread Matthew Brost
On Tue, Sep 14, 2021 at 03:04:59PM +1000, Dave Airlie wrote: > On Tue, 14 Sept 2021 at 14:55, Matthew Brost wrote: > > > > From: Venkata Sandeep Dhanalakota > > > > Defining vma on stack can cause stack overflow, if > > vma gets populated with new fields. > > Is there some higher level locking s

Re: [Intel-gfx] [PATCH v2 1/9] vfio/ccw: Use functions for alloc/free of the vfio_ccw_private

2021-09-14 Thread Cornelia Huck
On Fri, Sep 10 2021, Christoph Hellwig wrote: > On Thu, Sep 09, 2021 at 04:38:41PM -0300, Jason Gunthorpe wrote: >> + >> +private = kzalloc(sizeof(*private), GFP_KERNEL | GFP_DMA); >> +if (!private) >> +return ERR_PTR(-ENOMEM); > > Nit: there is no need to add GFP_KERNEL when

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable GuC submission by default on DG1 (rev6)

2021-09-14 Thread Patchwork
== Series Details == Series: Enable GuC submission by default on DG1 (rev6) URL : https://patchwork.freedesktop.org/series/93325/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable GuC submission by default on DG1 (rev6)

2021-09-14 Thread Patchwork
== Series Details == Series: Enable GuC submission by default on DG1 (rev6) URL : https://patchwork.freedesktop.org/series/93325/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10583 -> Patchwork_21042 Summary --- **F

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Do error capture async, flush G2H processing on reset (rev3)

2021-09-14 Thread Patchwork
== Series Details == Series: Do error capture async, flush G2H processing on reset (rev3) URL : https://patchwork.freedesktop.org/series/94642/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +dr

[Intel-gfx] ✗ Fi.CI.BAT: failure for Do error capture async, flush G2H processing on reset (rev3)

2021-09-14 Thread Patchwork
== Series Details == Series: Do error capture async, flush G2H processing on reset (rev3) URL : https://patchwork.freedesktop.org/series/94642/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10583 -> Patchwork_21043 Summary

Re: [Intel-gfx] [PATCH 0/3] drm/i915: Enable -Wsometimes-uninitialized

2021-09-14 Thread Jani Nikula
On Mon, 13 Sep 2021, Nathan Chancellor wrote: > On Tue, Aug 24, 2021 at 03:54:24PM -0700, Nathan Chancellor wrote: >> Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings") >> disabled -Wsometimes-uninitialized as noisy but there have been a few >> fixes to clang that make the false p

Re: [Intel-gfx] [PATCH 05/25] drm/i915/wm: provide wrappers around watermark vfuncs calls (v2)

2021-09-14 Thread Jani Nikula
On Fri, 10 Sep 2021, Dave Airlie wrote: > From: Dave Airlie > > This moves one wrapper from the pm->display side, and creates > wrappers for all the others, this should simplify things later. > > One thing to note is that the code checks the existance of some > of these ptrs, so the wrappers are

Re: [Intel-gfx] [PATCH 06/25] drm/i915: add wrappers around cdclk vtable funcs.

2021-09-14 Thread Jani Nikula
On Fri, 10 Sep 2021, Dave Airlie wrote: > From: Dave Airlie > > This adds wrappers around all the vtable callers so they are in > one place. > > Suggested by Jani. > > Signed-off-by: Dave Airlie Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_cdclk.c| 47

Re: [Intel-gfx] [PATCH 07/25] drm/i915/display: add intel_fdi_link_train wrapper.

2021-09-14 Thread Jani Nikula
On Fri, 10 Sep 2021, Dave Airlie wrote: > From: Dave Airlie > > This wraps the fdi link training vfunc to make it clearer. > > Suggested by Jani. > > Signed-off-by: Dave Airlie Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display.c | 2 +- > drivers/gpu/drm/i915/displ

Re: [Intel-gfx] [PATCH v2 2/7] drm/ttm: add TTM_PAGE_FLAG_SHMEM

2021-09-14 Thread Matthew Auld
On Tue, 14 Sept 2021 at 10:03, Christian König wrote: > > Am 14.09.21 um 10:50 schrieb Matthew Auld: > > Add new flag to indicate special shmem based tt, which can directly > > handle swapping itself, and should be visible to some shrinker. > > > > As part of this we should skip the ttm_pages_allo

Re: [Intel-gfx] [PATCH v2 0/9] Move vfio_ccw to the new mdev API

2021-09-14 Thread Jason Gunthorpe
On Mon, Sep 13, 2021 at 04:31:54PM -0400, Eric Farman wrote: > > I rebased it and fixed it up here: > > > > https://github.com/jgunthorpe/linux/tree/vfio_ccw > > > > Can you try again? > > That does address the crash, but then why is it processing a BROKEN > event? Seems problematic. The stuff

Re: [Intel-gfx] [PATCH 1/2] drm/i915/xehpsdv: Define MOCS table for XeHP SDV

2021-09-14 Thread Clint Taylor
Appears to match latest BSPEC Reviewed-by: Clint Taylor -Clint On 9/3/21 5:35 PM, Matt Roper wrote: From: Lucas De Marchi Like DG1, XeHP SDV doesn't have LLC/eDRAM control values due to being a dgfx card. XeHP SDV adds 2 more bits: L3_GLBGO to "push the Go point to memory for L3 destined t

Re: [Intel-gfx] [PATCH 08/27] drm/i915: Add logical engine mapping

2021-09-14 Thread Matthew Brost
On Tue, Sep 14, 2021 at 09:34:08AM +0100, Tvrtko Ursulin wrote: > > On 13/09/2021 17:50, Matthew Brost wrote: > > On Mon, Sep 13, 2021 at 10:24:43AM +0100, Tvrtko Ursulin wrote: > > > > > > On 10/09/2021 20:49, Matthew Brost wrote: > > > > On Fri, Sep 10, 2021 at 12:12:42PM +0100, Tvrtko Ursulin

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Move vfio_ccw to the new mdev API (rev3)

2021-09-14 Thread Patchwork
== Series Details == Series: Move vfio_ccw to the new mdev API (rev3) URL : https://patchwork.freedesktop.org/series/94520/ State : failure == Summary == Patch is empty. When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead.

Re: [Intel-gfx] [PATCH 09/25] drm/i915: split watermark vfuncs from display vtable.

2021-09-14 Thread Jani Nikula
On Fri, 10 Sep 2021, Dave Airlie wrote: > From: Dave Airlie > > These are the watermark api between display and pm. > > Signed-off-by: Dave Airlie Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display.c | 35 - > drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 00/24] i915/display: split and constify vtable (v5)

2021-09-14 Thread Jani Nikula
This is Dave's series [1] with patch 2 (drm/i915/uncore: constify the register vtables.) dropped because it conflicts between drm-intel-next and drm-intel-gt-next. I want to get proper CI results on this before merging. We can do the leftover patch afterwards. Everything else is unmodified. BR, Ja

[Intel-gfx] [PATCH 01/24] drm/i915/uncore: split the fw get function into separate vfunc

2021-09-14 Thread Jani Nikula
From: Dave Airlie constify it while here. drop the put function since it was never overloaded and always has done the same thing, no point in indirecting it for show. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_uncore.c | 70 +

[Intel-gfx] [PATCH 02/24] drm/i915/pm: drop get_fifo_size vfunc.

2021-09-14 Thread Jani Nikula
From: Dave Airlie The i845_update_wm code was always calling the i845 variant, and the i9xx_update_wm had only a choice between i830 and i9xx paths, hardly worth the vfunc overhead. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_d

[Intel-gfx] [PATCH 03/24] drm/i915: make update_wm take a dev_priv.

2021-09-14 Thread Jani Nikula
From: Dave Airlie The crtc was never being used here. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 10 +- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH 04/24] drm/i915/wm: provide wrappers around watermark vfuncs calls (v2)

2021-09-14 Thread Jani Nikula
From: Dave Airlie This moves one wrapper from the pm->display side, and creates wrappers for all the others, this should simplify things later. One thing to note is that the code checks the existance of some of these ptrs, so the wrappers are a bit complicated by that. Suggested by Jani. v2: f

[Intel-gfx] [PATCH 06/24] drm/i915/display: add intel_fdi_link_train wrapper.

2021-09-14 Thread Jani Nikula
From: Dave Airlie This wraps the fdi link training vfunc to make it clearer. Suggested by Jani. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_fdi.c | 8

[Intel-gfx] [PATCH 05/24] drm/i915: add wrappers around cdclk vtable funcs.

2021-09-14 Thread Jani Nikula
From: Dave Airlie This adds wrappers around all the vtable callers so they are in one place. Suggested by Jani. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c| 47 +++ drivers/gpu/drm/i915/dis

[Intel-gfx] [PATCH 07/24] drm/i915: split clock gating init from display vtable

2021-09-14 Thread Jani Nikula
From: Dave Airlie This function is only used inside intel_pm.c Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_drv.h | 9 ++- drivers/gpu/drm/i915/intel_pm.c | 48 - 2 files changed, 32 insertio

[Intel-gfx] [PATCH 08/24] drm/i915: split watermark vfuncs from display vtable.

2021-09-14 Thread Jani Nikula
From: Dave Airlie These are the watermark api between display and pm. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 35 - drivers/gpu/drm/i915/i915_drv.h | 24 driver

[Intel-gfx] [PATCH 09/24] drm/i915: split color functions from display vtable

2021-09-14 Thread Jani Nikula
From: Dave Airlie These are only used internally in the color module Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c | 64 +++--- drivers/gpu/drm/i915/i915_drv.h| 39 +++-- 2 fil

[Intel-gfx] [PATCH 10/24] drm/i915: split audio functions from display vtable

2021-09-14 Thread Jani Nikula
From: Dave Airlie These are only used internally in the audio code Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_audio.c | 24 +++--- drivers/gpu/drm/i915/i915_drv.h| 19 +++-- 2 f

[Intel-gfx] [PATCH 11/24] drm/i915: split cdclk functions from display vtable.

2021-09-14 Thread Jani Nikula
From: Dave Airlie This moves all the cdclk related functions into their own vtable. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 142 ++--- drivers/gpu/drm/i915/i915_drv.h| 8 +-

[Intel-gfx] [PATCH 12/24] drm/i915: split irq hotplug function from display vtable

2021-09-14 Thread Jani Nikula
From: Dave Airlie This provide a service from irq to display, so make it separate Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hotplug.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 9 - drivers/gp

[Intel-gfx] [PATCH 13/24] drm/i915: split fdi link training from display vtable.

2021-09-14 Thread Jani Nikula
From: Dave Airlie It may make sense to merge this with display again later, however the fdi use of the vtable is limited to only a few generations. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fdi.c | 8 drive

[Intel-gfx] [PATCH 14/24] drm/i915: split the dpll clock compute out from display vtable.

2021-09-14 Thread Jani Nikula
From: Dave Airlie this single function might be possible to merge later, but for now it's simple to just split it out. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 6 +++--- drivers/gpu/drm/i915/display/int

[Intel-gfx] [PATCH 15/24] drm/i915: constify fdi link training vtable

2021-09-14 Thread Jani Nikula
From: Dave Airlie Put the vtable into ro memory. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_fdi.c | 20 drivers/gpu/drm/i915/i915_drv.h | 2 +- 2 files changed, 17 insertions(+), 5 delet

[Intel-gfx] [PATCH 16/24] drm/i915: constify hotplug function vtable.

2021-09-14 Thread Jani Nikula
From: Dave Airlie Use a macro to avoid mistakes, this type of macro is only used in a couple of places. Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_hotplug.c | 4 +-- drivers/gpu/drm/i915/i915_drv.h | 2

[Intel-gfx] [PATCH 17/24] drm/i915: constify color function vtable.

2021-09-14 Thread Jani Nikula
From: Dave Airlie This clarifies quite well what functions get used on what platforms instead of having to decipher the old tree. v2: fixed IVB mistake (Jani) Reviewed-by: Jani Nikula Signed-off-by: Dave Airlie Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c | 138

  1   2   >