Pushed this one doc patch with Daniel's R-b on IRC.
dispcnlunit1_cp_xosc_clkreq clock observed to be active on TGL-H platform
despite Wa_14010685332 original sequence, thus blocks entry to deeper s0ix
state.
The Tweaked Wa_14010685332 sequence fixes this issue, therefore use tweaked
Wa_14010685332 sequence for every PCH since PCH_CNP.
v2:
- remov
On 30/07/2021 19:06, Matthew Brost wrote:
On Fri, Jul 30, 2021 at 10:58:38AM +0100, Tvrtko Ursulin wrote:
On 27/07/2021 19:20, Matthew Brost wrote:
With GuC submission contexts can get reordered (compared to submission
order), if contexts get reordered the sequential nature of the batches
r
Op 30-07-2021 om 11:52 schreef Daniel Vetter:
> I've added a new check to make sure that drivers which insepct the
> damage property have it set up correctly, but somehow missed that this
> borke the damage selftest in the CI result noise.
>
> Fix it up by mocking enough of drm_device and drm_plane
Matthew Auld writes:
> Try to document the object caching related bits, like cache_coherent and
> cache_dirty.
>
> v2(Ville):
> - As pointed out by Ville, fix the completely incorrect assumptions
>about the "partial" coherency on shared LLC platforms.
>
> Suggested-by: Daniel Vetter
> Signe
On 30/07/2021 19:13, John Harrison wrote:
On 7/30/2021 02:49, Tvrtko Ursulin wrote:
On 30/07/2021 01:13, John Harrison wrote:
On 7/28/2021 17:34, Matthew Brost wrote:
If an engine associated with a context does not have a heartbeat,
ban it
immediately. This is needed for GuC submission as a
Matt Roper writes:
> On Wed, Jul 28, 2021 at 06:05:57PM -0700, Matt Roper wrote:
>> On Wed, Jul 28, 2021 at 04:34:11PM -0700, Matt Roper wrote:
>> > The register offset for SFC_DONE was missing a '0' at the end, causing
>> > us to read from a non-existent register address. We only use this
>> >
Sync PCI IDs with Bspec.
Bspec:53655
Signed-off-by: Tejas Upadhyay
---
include/drm/i915_pciids.h | 4
1 file changed, 4 deletions(-)
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index eee18fa53b54..8adb058dfc5a 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm
On Thu, Jul 29, 2021 at 10:27:29PM +, Patchwork wrote:
> == Series Details ==
>
> Series: lpsp with hdmi/dp outputs
> URL : https://patchwork.freedesktop.org/series/93179/
> State : failure
Thanks for the patch pushed it to -din, fixing some typos in the commit
message and the playback doma
Hi all,
My bad for the resend. Adding cc: intel-gfx, and the maintainers and
mailing lists for include/drm/drm_file.h.
Following a discussion on the patch ("drm: use the lookup lock in
drm_is_current_master") [1], Peter Zijlstra proposed new lockdep_assert
helpers to make it convenient to compose
From: Peter Zijlstra
Extract lockdep_assert{,_once}() helpers to more easily write composite
assertions like, for example:
lockdep_assert(lockdep_is_held(&drm_device.master_mutex) ||
lockdep_is_held(&drm_file.master_lookup_lock));
Signed-off-by: Peter Zijlstra (In
In drm_is_current_master_locked, accessing drm_file.master should be
protected by either drm_file.master_lookup_lock or
drm_device.master_mutex. This was previously awkward to assert with
lockdep.
Following patch ("locking/lockdep: Provide lockdep_assert{,_once}()
helpers"), this assertion is now
Hello
Thanks for your reply. Exactly , the tools is base on codespell
But it seems not working well > iff
-Original Message-
From: Lucas De Marchi
Sent: 2021年7月31日 1:31
To: Cai,Huoqing
Cc: jani.nik...@linux.intel.com; joonas.lahti...@linux.intel.com;
rodrigo.v...@intel.com; airl...@li
Duplicate include header file "intel_region_lmem.h"
line 8: #include "intel_region_lmem.h"
line 12: #include "intel_region_lmem.h"
Signed-off-by: zhouchuangao
---
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_region_l
== Series Details ==
Series: drm/i915/adl_s: Update ADL-S PCI IDs
URL : https://patchwork.freedesktop.org/series/93302/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10437 -> Patchwork_20756
Summary
---
**SUCCESS**
From: Ankit Nautiyal
Till DISPLAY12 the PIPE_MISC bits 5-7 are used to set the
Dithering BPC, with valid values of 6, 8, 10 BPC, with Dithering bit enabled.
Also, these bits are used in case of HW readout for pipe_bpp in case of
DSI.
For ADLP+ these bits are used to set the PORT OUTPUT BPC, with
== Series Details ==
Series: locking/lockdep, drm: apply new lockdep assert in drm_auth.c
URL : https://patchwork.freedesktop.org/series/93304/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
60bc4f495a48 locking/lockdep: Provide lockdep_assert{, _once}() helpers
-:30: WARNING:SI
== Series Details ==
Series: locking/lockdep, drm: apply new lockdep assert in drm_auth.c
URL : https://patchwork.freedesktop.org/series/93304/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+driv
Atm the EFI FB driver gets a runtime PM reference for the associated GFX
PCI device during driver probing and releases it only when removing the
driver.
When fbcon switches to the FB provided by the PCI device's driver (for
instance i915/drmfb), the EFI FB will get only unregistered without the
EF
== Series Details ==
Series: gpu/drm/i915: Remove duplicated include of intel_region_lmem.h
URL : https://patchwork.freedesktop.org/series/93305/
State : failure
== Summary ==
Applying: gpu/drm/i915: Remove duplicated include of intel_region_lmem.h
Using index info to reconstruct a base tree..
== Series Details ==
Series: locking/lockdep, drm: apply new lockdep assert in drm_auth.c
URL : https://patchwork.freedesktop.org/series/93304/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10437 -> Patchwork_20757
Summary
== Series Details ==
Series: drm/i915/display: Fix the 12 BPC bits for PIPE_MISC reg
URL : https://patchwork.freedesktop.org/series/93306/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
fee101cc5424 drm/i915/display: Fix the 12 BPC bits for PIPE_MISC reg
-:10: WARNING:COMMIT_LOG
== Series Details ==
Series: drm/i915/display: Fix the 12 BPC bits for PIPE_MISC reg
URL : https://patchwork.freedesktop.org/series/93306/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10437 -> Patchwork_20759
Summary
-
== Series Details ==
Series: fbdev/efifb: Release PCI device's runtime PM ref during FB destroy
URL : https://patchwork.freedesktop.org/series/93307/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10437 -> Patchwork_20760
Su
Hi all,
Today's linux-next merge of the drm-intel tree got a conflict in:
drivers/gpu/drm/i915/intel_device_info.c
between commit:
0f9ed3b2c9ec ("drm/i915/display/cnl+: Handle fused off DSC")
from the drm-intel-fixes tree and commit:
a4d082fc194a ("drm/i915: rename/remove CNL registers"
== Series Details ==
Series: lpsp with hdmi/dp outputs
URL : https://patchwork.freedesktop.org/series/93179/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10418_full -> Patchwork_20740_full
Summary
---
**SUCCESS**
Hi all,
Today's linux-next merge of the drm-intel tree got a conflict in:
drivers/gpu/drm/i915/display/intel_display.c
between commit:
b4bde5554f70 ("drm/i915/display: split DISPLAY_VER 9 and 10 in
intel_setup_outputs()")
from Linus' tree and commits:
cad83b405fe4 ("drm/i915/display: r
Hi all,
Jason wanted to do that as part of the scheduler series, but I object
since rcu is very, very hard to review when adding, and much, much harder
even to review when removing.
This is because simply looking for __rcu pointer annotations and rcu
functions isn't enough, rcu is also relied upo
Changing the vm from a finalized gem ctx is no longer possible, which
means we don't have to check for that anymore.
I was pondering whether to keep the check as a WARN_ON, but things go
boom real bad real fast if the vm of a vma is wrong. Plus we'd need to
also get the ggtt vm for !full-ppgtt pla
The important part isn't so much that this does an rcu lookup - that's
more an implementation detail, which will also be removed.
The thing that makes this different from other functions is that it's
gettting you the vm that batchbuffers will run in for that gem
context, which is either a full ppg
Consolidates the "which is the vm my execbuf runs in" code a bit. We
do some get/put which isn't really required, but all the other users
want the refcounting, and I figured doing a function just for this
getparam to avoid 2 atomis is a bit much.
Signed-off-by: Daniel Vetter
Cc: Jon Bloomfield
C
And use it anywhere we have open-coded checks for ctx->vm that really
only check for full ppgtt.
Plus for paranoia add a GEM_BUG_ON that checks it's really only set
when we have full ppgtt, just in case. gem_context->vm is different
since it's NULL in ggtt mode, unlike intel_context->vm or gt->vm,
Since
commit ccbc1b97948ab671335e950271e39766729736c3
Author: Jason Ekstrand
Date: Thu Jul 8 10:48:30 2021 -0500
drm/i915/gem: Don't allow changing the VM on running contexts (v4)
the gem_ctx->vm can't change anymore. Plus we always set the
intel_context->vm, so might as well use the help
It's been invariant since
commit ccbc1b97948ab671335e950271e39766729736c3
Author: Jason Ekstrand
Date: Thu Jul 8 10:48:30 2021 -0500
drm/i915/gem: Don't allow changing the VM on running contexts (v4)
this just completes the deed. I've tried to split out prep work for
more
The full audit is quite a bit of work:
- i915_dpt has very simple lifetime (somehow we create a display pagetable vm
per object, so its _very_ simple, there's only ever a single vma in there),
and uses i915_vm_close(), which internally does a i915_vm_put(). No rcu.
Aside: wtf is i915_dpt do
There's quite a fundamental difference between userspace contexts, and
kernel contexts. Latter all share intel_gt->vm, former get their vm
from gem_ctx->vm (on full ppgtt at least).
By splitting context creation for userspace from kernel-internal ones
we can make this all a bit more strict and WAR
We don't need the absolute speed of rcu for this. And
i915_address_space in general dont need rcu protection anywhere else,
after we've made gem contexts and engines a lot more immutable.
Note that this semantically reverts
commit aabbe344dc3ca5f7d8263a02608ba6179e8a4499
Author: Chris Wilson
Dat
Re-reported.
-Original Message-
From: Deak, Imre
Sent: Monday, August 2, 2021 4:23 AM
To: intel-gfx@lists.freedesktop.org; Gupta, Anshuman
; Vudum, Lakshminarayana
Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for lpsp with hdmi/dp outputs
On Thu, Jul 29, 2021 at 10:27:29PM +, Pa
Hi Jim,
On Sat, 31 Jul 2021 at 22:42, Jim Cromie wrote:
> Use of this new data member will be rare, it might be worth redoing
> this as a separate/sub-type to keep the base case.
>
> Signed-off-by: Jim Cromie
> ---
> include/linux/moduleparam.h | 11 +--
> 1 file changed, 9 insertions(
Hi Jim,
On Sat, 31 Jul 2021 at 22:42, Jim Cromie wrote:
> +struct dyndbg_bitdesc {
> + /* bitpos is inferred from index in containing array */
> + char *prefix;
> + char *help;
AFAICT these two should also be constant, right?
> +int param_set_dyndbg(const char *instr, const s
Hi Jim,
On Sat, 31 Jul 2021 at 22:42, Jim Cromie wrote:
> DYNDBG_BITMAP_DESC(__gvt_debug, "dyndbg bitmap desc",
> { "gvt: cmd: ", "command processing" },
> { "gvt: core: ", "core help" },
> { "gvt: dpy: ", "display help" },
> { "gvt: el: ", "help" },
>
== Series Details ==
Series: remove rcu support from i915_address_space
URL : https://patchwork.freedesktop.org/series/93314/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
a853815d3335 drm/i915: Drop code to handle set-vm races from execbuf
-:17: WARNING:COMMIT_LOG_LONG_LINE: P
== Series Details ==
Series: remove rcu support from i915_address_space
URL : https://patchwork.freedesktop.org/series/93314/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-drivers/gpu/drm/i915/g
== Series Details ==
Series: remove rcu support from i915_address_space
URL : https://patchwork.freedesktop.org/series/93314/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10439 -> Patchwork_20761
Summary
---
**FAILU
On Mon, Aug 2, 2021 at 10:18 AM Emil Velikov wrote:
>
> Hi Jim,
>
> On Sat, 31 Jul 2021 at 22:42, Jim Cromie wrote:
>
> > Use of this new data member will be rare, it might be worth redoing
> > this as a separate/sub-type to keep the base case.
> >
> > Signed-off-by: Jim Cromie
> > ---
> > incl
On Mon, Aug 2, 2021 at 10:24 AM Emil Velikov wrote:
>
> Hi Jim,
>
> On Sat, 31 Jul 2021 at 22:42, Jim Cromie wrote:
>
> > +struct dyndbg_bitdesc {
> > + /* bitpos is inferred from index in containing array */
> > + char *prefix;
> > + char *help;
> AFAICT these two should also b
CI test results/further experiments show that the workaround added in
commit 573d7ce4f69a ("drm/i915/adlp: Add workaround to disable CMTG clock
gating")
can be applied only while DPLL0 is enabled. If it's disabled the
TRANS_CMTG_CHICKEN register is not accessible. Accordingly move the WA
to DPLL
== Series Details ==
Series: drm/i915/adl_s: Update ADL-S PCI IDs
URL : https://patchwork.freedesktop.org/series/93302/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10437_full -> Patchwork_20756_full
Summary
---
**S
== Series Details ==
Series: drm/i915: Apply CMTG clock disabling WA while DPLL0 is enabled
URL : https://patchwork.freedesktop.org/series/93318/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
31185812783d drm/i915: Apply CMTG clock disabling WA while DPLL0 is enabled
-:12: WARN
On Mon, Aug 02, 2021 at 09:59:01AM +0100, Tvrtko Ursulin wrote:
>
>
> On 30/07/2021 19:06, Matthew Brost wrote:
> > On Fri, Jul 30, 2021 at 10:58:38AM +0100, Tvrtko Ursulin wrote:
> > >
> > > On 27/07/2021 19:20, Matthew Brost wrote:
> > > > With GuC submission contexts can get reordered (compar
== Series Details ==
Series: drm/i915: Apply CMTG clock disabling WA while DPLL0 is enabled
URL : https://patchwork.freedesktop.org/series/93318/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10440 -> Patchwork_20762
Summar
On Mon, 2021-08-02 at 22:01 +0300, Imre Deak wrote:
> CI test results/further experiments show that the workaround added in
>
> commit 573d7ce4f69a ("drm/i915/adlp: Add workaround to disable CMTG clock
> gating")
>
> can be applied only while DPLL0 is enabled. If it's disabled the
> TRANS_CMTG_C
On Mon, Aug 02, 2021 at 11:52:41PM +0300, Souza, Jose wrote:
> On Mon, 2021-08-02 at 22:01 +0300, Imre Deak wrote:
> > CI test results/further experiments show that the workaround added in
> >
> > commit 573d7ce4f69a ("drm/i915/adlp: Add workaround to disable CMTG clock
> > gating")
> >
> > can
On Tue, 2021-08-03 at 00:07 +0300, Imre Deak wrote:
> On Mon, Aug 02, 2021 at 11:52:41PM +0300, Souza, Jose wrote:
> > On Mon, 2021-08-02 at 22:01 +0300, Imre Deak wrote:
> > > CI test results/further experiments show that the workaround added in
> > >
> > > commit 573d7ce4f69a ("drm/i915/adlp: Ad
On Tue, Aug 03, 2021 at 12:16:30AM +0300, Souza, Jose wrote:
> On Tue, 2021-08-03 at 00:07 +0300, Imre Deak wrote:
> > On Mon, Aug 02, 2021 at 11:52:41PM +0300, Souza, Jose wrote:
> > > On Mon, 2021-08-02 at 22:01 +0300, Imre Deak wrote:
> > > > CI test results/further experiments show that the wor
== Series Details ==
Series: locking/lockdep, drm: apply new lockdep assert in drm_auth.c
URL : https://patchwork.freedesktop.org/series/93304/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10437_full -> Patchwork_20757_full
== Series Details ==
Series: drm/i915/display: Fix the 12 BPC bits for PIPE_MISC reg
URL : https://patchwork.freedesktop.org/series/93306/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10437_full -> Patchwork_20759_full
Sum
, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Daniel-Vetter/remove-rcu-support-from-i915_address_space/20210802-234929
base: git://anongit.freedeskt
== Series Details ==
Series: fbdev/efifb: Release PCI device's runtime PM ref during FB destroy
URL : https://patchwork.freedesktop.org/series/93307/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10437_full -> Patchwork_20760_full
==
From: Venkata Sandeep Dhanalakota
Defining vma on stack can cause stack overflow, if
vma gets populated with new fields.
Cc: Daniele Ceraolo Spurio
Cc: Tvrtko Ursulin
Signed-off-by: Venkata Sandeep Dhanalakota
Signef-off-by: Matthew Brost
---
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 18 ++
Minimum set of patches to enable GuC submission on DG1 and enable it by
default.
A little difficult to test as IGTs do not work with DG1 due to a bunch
of uAPI features being disabled (e.g. relocations, caching memory
options, etc...).
Tested with the loading the driver and 'live' selftests. Subm
From: Daniele Ceraolo Spurio
The firmware binary has to be loaded from lmem and the recommendation is
to put all other objects in there as well. Note that we don't fall back
to system memory if the allocation in lmem fails because all objects are
allocated during driver load and if we have issues
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
index da57d18d9f6b..fc2fc8d111d8 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_
Signed-off-by: Matthew Brost
---
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
index f8cb00ffb506..a685d563df72 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
== Series Details ==
Series: Enable GuC submission by default on DG1
URL : https://patchwork.freedesktop.org/series/93325/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9d575da473a3 drm/i915: Do not define vma on stack
-:12: WARNING:BAD_SIGN_OFF: Non-standard signature: 'Signef
== Series Details ==
Series: Enable GuC submission by default on DG1
URL : https://patchwork.freedesktop.org/series/93325/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/i915/di
== Series Details ==
Series: Enable GuC submission by default on DG1
URL : https://patchwork.freedesktop.org/series/93325/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10440 -> Patchwork_20763
Summary
---
**SUCCESS*
67 matches
Mail list logo