[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move system memory to TTM for discrete (rev8)

2021-06-23 Thread Patchwork
== Series Details == Series: drm/i915: Move system memory to TTM for discrete (rev8) URL : https://patchwork.freedesktop.org/series/90898/ State : success == Summary == CI Bug Log - changes from CI_DRM_10265 -> Patchwork_20434 Summary -

Re: [Intel-gfx] New uAPI for color management proposal and feedback request

2021-06-23 Thread Pekka Paalanen
On Tue, 22 Jun 2021 19:06:43 +0200 Werner Sembach wrote: > Am 19.05.21 um 11:34 schrieb Pekka Paalanen: > > On Wed, 12 May 2021 16:04:16 +0300 > > Ville Syrjälä wrote: > > > >> On Wed, May 12, 2021 at 02:06:56PM +0200, Werner Sembach wrote: > >>> Hello, > >>> > >>> In addition to the existin

[Intel-gfx] [PATCH] drm/i915/selftest: Extend ctx_timestamp ICL workaround to GEN11

2021-06-23 Thread Tejas Upadhyay
EHL and JSL are also observing requirement for 80ns interval for CTX_TIMESTAMP thus extending it to GEN11. Signed-off-by: Tejas Upadhyay --- drivers/gpu/drm/i915/gt/selftest_engine_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_engin

Re: [Intel-gfx] [PATCH v4 09/17] drm/uAPI: Add "active color range" drm property as feedback for userspace

2021-06-23 Thread Pekka Paalanen
On Tue, 22 Jun 2021 11:48:52 + Simon Ser wrote: > On Tuesday, June 22nd, 2021 at 11:50, Werner Sembach > wrote: > > > Unknown is when no monitor is connected or is when the > > connector/monitor is disabled. > > I think the other connector props (link-status, non-desktop, etc) don't > h

Re: [Intel-gfx] [PATCH v4 15/17] drm/uAPI: Move "Broadcast RGB" property from driver specific to general context

2021-06-23 Thread Pekka Paalanen
On Tue, 22 Jun 2021 11:57:53 +0200 Werner Sembach wrote: > Am 22.06.21 um 09:25 schrieb Pekka Paalanen: > > On Fri, 18 Jun 2021 11:11:14 +0200 > > Werner Sembach wrote: > > > >> Add "Broadcast RGB" to general drm context so that more drivers besides > >> i915 and gma500 can implement it withou

Re: [Intel-gfx] [PATCH v4 17/17] drm/amd/display: Add handling for new "Broadcast RGB" property

2021-06-23 Thread Pekka Paalanen
On Tue, 22 Jun 2021 11:28:57 +0200 Werner Sembach wrote: > Am 22.06.21 um 09:29 schrieb Pekka Paalanen: > > On Fri, 18 Jun 2021 11:11:16 +0200 > > Werner Sembach wrote: > > > >> This commit implements the "Broadcast RGB" drm property for the AMD GPU > >> driver. > >> > >> Signed-off-by: Werner

Re: [Intel-gfx] [PATCH] ALSA: hda: Release display power reference during shutdown/reboot

2021-06-23 Thread Takashi Iwai
On Tue, 22 Jun 2021 21:58:13 +0200, Imre Deak wrote: > > On Tue, Jun 22, 2021 at 04:18:14PM +0200, Takashi Iwai wrote: > > On Mon, 21 Jun 2021 19:44:15 +0200, > > Imre Deak wrote: > > > > > > Make sure the HDA driver's display power reference is released during > > > shutdown/reboot. > > > > > >

Re: [Intel-gfx] [PATCH] Revert "drm: add a locked version of drm_is_current_master"

2021-06-23 Thread Daniel Vetter
On Wed, Jun 23, 2021 at 10:09 AM Desmond Cheong Zhi Xi wrote: > > On 22/6/21 3:54 pm, Daniel Vetter wrote: > > This reverts commit 1815d9c86e3090477fbde066ff314a7e9721ee0f. > > > > Unfortunately this inverts the locking hierarchy, so back to the > > drawing board. Full lockdep splat below: > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftest: Extend ctx_timestamp ICL workaround to GEN11

2021-06-23 Thread Patchwork
== Series Details == Series: drm/i915/selftest: Extend ctx_timestamp ICL workaround to GEN11 URL : https://patchwork.freedesktop.org/series/91805/ State : success == Summary == CI Bug Log - changes from CI_DRM_10265 -> Patchwork_20435 Summa

Re: [Intel-gfx] [PATCH v14 00/12] Restricted DMA

2021-06-23 Thread Konrad Rzeszutek Wilk
On Sat, Jun 19, 2021 at 11:40:31AM +0800, Claire Chang wrote: > This series implements mitigations for lack of DMA access control on > systems without an IOMMU, which could result in the DMA accessing the > system memory at unexpected times and/or unexpected addresses, possibly > leading to data le

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Move system memory to TTM for discrete (rev8)

2021-06-23 Thread Patchwork
== Series Details == Series: drm/i915: Move system memory to TTM for discrete (rev8) URL : https://patchwork.freedesktop.org/series/90898/ State : success == Summary == CI Bug Log - changes from CI_DRM_10265_full -> Patchwork_20434_full Sum

Re: [Intel-gfx] [PATCH v14 00/12] Restricted DMA

2021-06-23 Thread Claire Chang
On Wed, Jun 23, 2021 at 4:38 PM Konrad Rzeszutek Wilk wrote: > > On Sat, Jun 19, 2021 at 11:40:31AM +0800, Claire Chang wrote: > > This series implements mitigations for lack of DMA access control on > > systems without an IOMMU, which could result in the DMA accessing the > > system memory at une

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for ALSA: hda: Release display power reference during shutdown/reboot (rev3)

2021-06-23 Thread Patchwork
== Series Details == Series: ALSA: hda: Release display power reference during shutdown/reboot (rev3) URL : https://patchwork.freedesktop.org/series/91742/ State : warning == Summary == $ dim checkpatch origin/drm-tip bf84d7730b88 ALSA: hda: Release display power reference during shutdown/rebo

[Intel-gfx] ✓ Fi.CI.BAT: success for ALSA: hda: Release display power reference during shutdown/reboot (rev3)

2021-06-23 Thread Patchwork
== Series Details == Series: ALSA: hda: Release display power reference during shutdown/reboot (rev3) URL : https://patchwork.freedesktop.org/series/91742/ State : success == Summary == CI Bug Log - changes from CI_DRM_10266 -> Patchwork_20436 ==

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftest: Extend ctx_timestamp ICL workaround to GEN11

2021-06-23 Thread Patchwork
== Series Details == Series: drm/i915/selftest: Extend ctx_timestamp ICL workaround to GEN11 URL : https://patchwork.freedesktop.org/series/91805/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10265_full -> Patchwork_20435_full =

Re: [Intel-gfx] [PATCH 15/15] RFC: drm/amdgpu: Implement a proper implicit fencing uapi

2021-06-23 Thread Bas Nieuwenhuizen
On Tue, Jun 22, 2021 at 6:55 PM Daniel Vetter wrote: > > WARNING: Absolutely untested beyond "gcc isn't dying in agony". > > Implicit fencing done properly needs to treat the implicit fencing > slots like a funny kind of IPC mailbox. In other words it needs to be > explicitly. This is the only way

Re: [Intel-gfx] [PATCH v4 17/17] drm/amd/display: Add handling for new "Broadcast RGB" property

2021-06-23 Thread Werner Sembach
Am 23.06.21 um 10:01 schrieb Pekka Paalanen: > On Tue, 22 Jun 2021 11:28:57 +0200 > Werner Sembach wrote: > >> Am 22.06.21 um 09:29 schrieb Pekka Paalanen: >>> On Fri, 18 Jun 2021 11:11:16 +0200 >>> Werner Sembach wrote: >>> This commit implements the "Broadcast RGB" drm property for the A

[Intel-gfx] [drm-intel:drm-intel-gt-next 7/8] drivers/gpu/drm/i915/intel_region_ttm.c:181:6: error: no previous prototype for 'intel_region_ttm_node_free'

2021-06-23 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-gt-next head: 13c2ceb6addb6b14468e09b75832c98909eed8e7 commit: d53ec322dc7de32a59bf1c2a56b93e90fc2f1c28 [7/8] drm/i915/ttm: switch over to ttm_buddy_man config: i386-defconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

Re: [Intel-gfx] [PATCH v4 15/17] drm/uAPI: Move "Broadcast RGB" property from driver specific to general context

2021-06-23 Thread Werner Sembach
Am 23.06.21 um 09:48 schrieb Pekka Paalanen: > On Tue, 22 Jun 2021 11:57:53 +0200 > Werner Sembach wrote: > >> Am 22.06.21 um 09:25 schrieb Pekka Paalanen: >>> On Fri, 18 Jun 2021 11:11:14 +0200 >>> Werner Sembach wrote: >>> Add "Broadcast RGB" to general drm context so that more drivers b

Re: [Intel-gfx] [PATCH] drm/i915: return DRIVER_NAME for the fence driver name

2021-06-23 Thread Thomas Zimmermann
Hi Am 16.06.21 um 14:28 schrieb Matthew Auld: The first tracepoint for a request is trace_dma_fence_init which is called in the ctor before we have properly setup the request->engine. So if it's a non-recycled request the rq->engine might be NULL, or some garbage value, which leads to a crash.

Re: [Intel-gfx] [PATCH] Revert "drm: add a locked version of drm_is_current_master"

2021-06-23 Thread Desmond Cheong Zhi Xi
On 23/6/21 4:14 pm, Daniel Vetter wrote: On Wed, Jun 23, 2021 at 10:09 AM Desmond Cheong Zhi Xi wrote: On 22/6/21 3:54 pm, Daniel Vetter wrote: This reverts commit 1815d9c86e3090477fbde066ff314a7e9721ee0f. Unfortunately this inverts the locking hierarchy, so back to the drawing board. Full l

Re: [Intel-gfx] [PATCH v13 01/12] swiotlb: Refactor swiotlb init functions

2021-06-23 Thread Stefano Stabellini
On Fri, 18 Jun 2021, Christoph Hellwig wrote: > On Fri, Jun 18, 2021 at 09:09:17AM -0500, Tom Lendacky wrote: > > > swiotlb_init_with_tbl uses memblock_alloc to allocate the io_tlb_mem > > > and memblock_alloc[1] will do memset in memblock_alloc_try_nid[2], so > > > swiotlb_init_with_tbl is also go

Re: [Intel-gfx] Allow mdev drivers to directly create the vfio_device (v4)

2021-06-23 Thread Jason Gunthorpe
On Thu, Jun 17, 2021 at 04:22:08PM +0200, Christoph Hellwig wrote: > This is my alternative take on this series from Jason: > > https://lore.kernel.org/dri-devel/87czsszi9i@redhat.com/T/ > > The mdev/vfio parts are exactly the same, but this solves the driver core > changes for the direct pro

Re: [Intel-gfx] [PATCH] Revert "drm: add a locked version of drm_is_current_master"

2021-06-23 Thread Desmond Cheong Zhi Xi
On 22/6/21 3:54 pm, Daniel Vetter wrote: This reverts commit 1815d9c86e3090477fbde066ff314a7e9721ee0f. Unfortunately this inverts the locking hierarchy, so back to the drawing board. Full lockdep splat below: == WARNING: possible circular lock

Re: [Intel-gfx] [PATCH v14 01/12] swiotlb: Refactor swiotlb init functions

2021-06-23 Thread Stefano Stabellini
On Sat, 19 Jun 2021, Claire Chang wrote: > Add a new function, swiotlb_init_io_tlb_mem, for the io_tlb_mem struct > initialization to make the code reusable. > > Signed-off-by: Claire Chang > Reviewed-by: Christoph Hellwig > Tested-by: Stefano Stabellini > Tested-by: Will Deacon Acked-by: Ste

Re: [Intel-gfx] [PATCH v4 09/17] drm/uAPI: Add "active color range" drm property as feedback for userspace

2021-06-23 Thread Werner Sembach
Am 23.06.21 um 09:32 schrieb Pekka Paalanen: > On Tue, 22 Jun 2021 11:48:52 + > Simon Ser wrote: > >> On Tuesday, June 22nd, 2021 at 11:50, Werner Sembach >> wrote: >> >>> Unknown is when no monitor is connected or is when the >>> connector/monitor is disabled. >> I think the other conne

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Revert "drm: add a locked version of drm_is_current_master" (rev2)

2021-06-23 Thread Patchwork
== Series Details == Series: Revert "drm: add a locked version of drm_is_current_master" (rev2) URL : https://patchwork.freedesktop.org/series/91758/ State : failure == Summary == Applying: Revert "drm: add a locked version of drm_is_current_master" error: git diff header lacks filename inform

Re: [Intel-gfx] [PATCH v4 09/17] drm/uAPI: Add "active color range" drm property as feedback for userspace

2021-06-23 Thread Pekka Paalanen
On Wed, 23 Jun 2021 12:17:40 +0200 Werner Sembach wrote: > Am 23.06.21 um 09:32 schrieb Pekka Paalanen: > > On Tue, 22 Jun 2021 11:48:52 + > > Simon Ser wrote: > > > >> On Tuesday, June 22nd, 2021 at 11:50, Werner Sembach > >> wrote: > >> > >>> Unknown is when no monitor is connected o

[Intel-gfx] ✗ Fi.CI.IGT: failure for ALSA: hda: Release display power reference during shutdown/reboot (rev3)

2021-06-23 Thread Patchwork
== Series Details == Series: ALSA: hda: Release display power reference during shutdown/reboot (rev3) URL : https://patchwork.freedesktop.org/series/91742/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10266_full -> Patchwork_20436_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftest: Extend ctx_timestamp ICL workaround to GEN11 (rev2)

2021-06-23 Thread Patchwork
== Series Details == Series: drm/i915/selftest: Extend ctx_timestamp ICL workaround to GEN11 (rev2) URL : https://patchwork.freedesktop.org/series/91805/ State : success == Summary == CI Bug Log - changes from CI_DRM_10266 -> Patchwork_20438

Re: [Intel-gfx] [PATCH v4 09/17] drm/uAPI: Add "active color range" drm property as feedback for userspace

2021-06-23 Thread Werner Sembach
Am 23.06.21 um 13:14 schrieb Pekka Paalanen: > On Wed, 23 Jun 2021 12:17:40 +0200 > Werner Sembach wrote: > >> Am 23.06.21 um 09:32 schrieb Pekka Paalanen: >>> On Tue, 22 Jun 2021 11:48:52 + >>> Simon Ser wrote: >>> On Tuesday, June 22nd, 2021 at 11:50, Werner Sembach wrote: >>>

Re: [Intel-gfx] [PATCH] Revert "drm: add a locked version of drm_is_current_master"

2021-06-23 Thread Daniel Vetter
On Wed, Jun 23, 2021 at 11:51 AM Desmond Cheong Zhi Xi wrote: > > On 23/6/21 4:14 pm, Daniel Vetter wrote: > > On Wed, Jun 23, 2021 at 10:09 AM Desmond Cheong Zhi Xi > > wrote: > >> > >> On 22/6/21 3:54 pm, Daniel Vetter wrote: > >>> This reverts commit 1815d9c86e3090477fbde066ff314a7e9721ee0f. >

[Intel-gfx] [PATCH 1/3] drm/i915/ttm: consider all placements for the page alignment

2021-06-23 Thread Matthew Auld
Just checking the current region is not enough, if we later migrate the object somewhere else. For example if the placements are {SMEM, LMEM}, then we might get this wrong. Another idea might be to make the page_alignment part of the ttm_place, instead of the BO. Signed-off-by: Matthew Auld Cc: T

[Intel-gfx] [PATCH 3/3] drm/i915/gtt: ignore min_page_size for paging structures

2021-06-23 Thread Matthew Auld
The min_page_size is only needed for pages inserted into the GTT, and for our paging structures we only need at most 4K bytes, so simply ignore the min_page_size restrictions here, otherwise we might see some severe overallocation on some devices. Signed-off-by: Matthew Auld Cc: Thomas Hellström

[Intel-gfx] [PATCH 2/3] drm/i915: support forcing the page size with lmem

2021-06-23 Thread Matthew Auld
For some specialised objects we might need something larger than the regions min_page_size due to some hw restriction, and slightly more hairy is needing something smaller with the guarantee that such objects will never be inserted into any GTT, which is the case for the paging structures. Signed-

Re: [Intel-gfx] [PATCH v4 15/17] drm/uAPI: Move "Broadcast RGB" property from driver specific to general context

2021-06-23 Thread Pekka Paalanen
On Wed, 23 Jun 2021 12:10:14 +0200 Werner Sembach wrote: > Am 23.06.21 um 09:48 schrieb Pekka Paalanen: > > On Tue, 22 Jun 2021 11:57:53 +0200 > > Werner Sembach wrote: > > > >> Am 22.06.21 um 09:25 schrieb Pekka Paalanen: > >>> On Fri, 18 Jun 2021 11:11:14 +0200 > >>> Werner Sembach wrote:

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gtt: ignore min_page_size for paging structures

2021-06-23 Thread Thomas Hellström
On 6/23/21 1:26 PM, Matthew Auld wrote: The min_page_size is only needed for pages inserted into the GTT, and for our paging structures we only need at most 4K bytes, so simply ignore the min_page_size restrictions here, otherwise we might see some severe overallocation on some devices. Signed-

Re: [Intel-gfx] [PATCH 1/6] drm/i915/display/psr: Handle SU Y granularity

2021-06-23 Thread Gwan-gyeong Mun
looks good to me. Reviewed-by: Gwan-gyeong Mun On 6/16/21 11:31 PM, José Roberto de Souza wrote: We were only handling X and width granularity, what was causing issues when sink had a granularity different than 4. While at it, renaming su_x_granularity to su_w_granularity to better match real

Re: [Intel-gfx] [PATCH 15/15] RFC: drm/amdgpu: Implement a proper implicit fencing uapi

2021-06-23 Thread Daniel Vetter
On Wed, Jun 23, 2021 at 11:45 AM Bas Nieuwenhuizen wrote: > > On Tue, Jun 22, 2021 at 6:55 PM Daniel Vetter wrote: > > > > WARNING: Absolutely untested beyond "gcc isn't dying in agony". > > > > Implicit fencing done properly needs to treat the implicit fencing > > slots like a funny kind of IPC

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gtt: ignore min_page_size for paging structures

2021-06-23 Thread Matthew Auld
On 23/06/2021 12:51, Thomas Hellström wrote: On 6/23/21 1:26 PM, Matthew Auld wrote: The min_page_size is only needed for pages inserted into the GTT, and for our paging structures we only need at most 4K bytes, so simply ignore the min_page_size restrictions here, otherwise we might see some s

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftest: Extend ctx_timestamp ICL workaround to GEN11 (rev2)

2021-06-23 Thread Patchwork
== Series Details == Series: drm/i915/selftest: Extend ctx_timestamp ICL workaround to GEN11 (rev2) URL : https://patchwork.freedesktop.org/series/91805/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10266_full -> Patchwork_20438_full ==

Re: [Intel-gfx] [PATCH 01/15] dma-resv: Fix kerneldoc

2021-06-23 Thread Christian König
Am 22.06.21 um 18:54 schrieb Daniel Vetter: Oversight from commit 6edbd6abb783d54f6ac4c3ed5cd9e50cff6c15e9 Author: Christian König Date: Mon May 10 16:14:09 2021 +0200 dma-buf: rename and cleanup dma_resv_get_excl v3 Signed-off-by: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König"

Re: [Intel-gfx] [PATCH 02/15] dma-buf: Switch to inline kerneldoc

2021-06-23 Thread Christian König
Am 22.06.21 um 18:54 schrieb Daniel Vetter: Also review & update everything while we're at it. This is prep work to smash a ton of stuff into the kerneldoc for @resv. Signed-off-by: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: Alex Deucher Cc: Daniel Vetter Cc: Dave Airlie Cc:

Re: [Intel-gfx] [PATCH 03/15] dma-buf: Document dma-buf implicit fencing/resv fencing rules

2021-06-23 Thread Christian König
Am 22.06.21 um 18:54 schrieb Daniel Vetter: Docs for struct dma_resv are fairly clear: "A reservation object can have attached one exclusive fence (normally associated with write operations) or N shared fences (read operations)." https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2

Re: [Intel-gfx] [PATCH 14/15] drm/gem: Tiny kernel clarification for drm_gem_fence_array_add

2021-06-23 Thread Christian König
Am 22.06.21 um 18:55 schrieb Daniel Vetter: Spotted while trying to convert panfrost to these. Signed-off-by: Daniel Vetter Cc: "Christian König" Cc: Lucas Stach Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/drm_gem

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gtt: ignore min_page_size for paging structures

2021-06-23 Thread Thomas Hellström
On Wed, 2021-06-23 at 13:25 +0100, Matthew Auld wrote: > On 23/06/2021 12:51, Thomas Hellström wrote: > > > > On 6/23/21 1:26 PM, Matthew Auld wrote: > > > The min_page_size is only needed for pages inserted into the GTT, > > > and > > > for our paging structures we only need at most 4K bytes, so

Re: [Intel-gfx] [PATCH 1/3] drm/i915/ttm: consider all placements for the page alignment

2021-06-23 Thread Thomas Hellström
On Wed, 2021-06-23 at 12:26 +0100, Matthew Auld wrote: > Just checking the current region is not enough, if we later migrate > the > object somewhere else. For example if the placements are {SMEM, > LMEM}, > then we might get this wrong. Another idea might be to make the > page_alignment part of th

Re: [Intel-gfx] [PATCH 2/3] drm/i915: support forcing the page size with lmem

2021-06-23 Thread Thomas Hellström
On Wed, 2021-06-23 at 12:26 +0100, Matthew Auld wrote: > For some specialised objects we might need something larger than the > regions min_page_size due to some hw restriction, and slightly more > hairy is needing something smaller with the guarantee that such > objects > will never be inserted in

Re: [Intel-gfx] [PATCH v2 13/17] drm/i915: Deduplicate icl DP HBR2 vs. eDP HBR3 table

2021-06-23 Thread Ville Syrjälä
On Fri, Jun 18, 2021 at 03:30:28PM +0300, Jani Nikula wrote: > On Tue, 08 Jun 2021, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The icl combo phy DP HBR2 is identical to the eDP HBR3 table. > > Get rid of one redundant copy. > > > > Signed-off-by: Ville Syrjälä > > Reviewed-by: Jani Ni

Re: [Intel-gfx] [PATCH] drm/i915: allow DG1 autoprobe for CONFIG_BROKEN

2021-06-23 Thread Jani Nikula
On Thu, 17 Jun 2021, Daniel Vetter wrote: > I think stuffing this into topic/core-for-CI is fine, lets wait a bit more > until mesa and everything is ready with adding the pciids to an official > tree. On a related note, I think we'll need rationale documented for each commit in topic/core-for-CI

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gtt: ignore min_page_size for paging structures

2021-06-23 Thread Thomas Hellström
On 6/23/21 1:26 PM, Matthew Auld wrote: The min_page_size is only needed for pages inserted into the GTT, and for our paging structures we only need at most 4K bytes, so simply ignore the min_page_size restrictions here, otherwise we might see some severe overallocation on some devices. Signed-

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gtt: ignore min_page_size for paging structures

2021-06-23 Thread Matthew Auld
On 23/06/2021 14:32, Thomas Hellström wrote: On 6/23/21 1:26 PM, Matthew Auld wrote: The min_page_size is only needed for pages inserted into the GTT, and for our paging structures we only need at most 4K bytes, so simply ignore the min_page_size restrictions here, otherwise we might see some s

Re: [Intel-gfx] [PATCH 15/15] RFC: drm/amdgpu: Implement a proper implicit fencing uapi

2021-06-23 Thread Bas Nieuwenhuizen
On Wed, Jun 23, 2021 at 2:59 PM Christian König wrote: > > Am 23.06.21 um 14:18 schrieb Daniel Vetter: > > On Wed, Jun 23, 2021 at 11:45 AM Bas Nieuwenhuizen > > wrote: > >> On Tue, Jun 22, 2021 at 6:55 PM Daniel Vetter > >> wrote: > >>> WARNING: Absolutely untested beyond "gcc isn't dying in a

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gtt: ignore min_page_size for paging structures

2021-06-23 Thread Thomas Hellström
On 6/23/21 3:38 PM, Matthew Auld wrote: On 23/06/2021 14:32, Thomas Hellström wrote: On 6/23/21 1:26 PM, Matthew Auld wrote: The min_page_size is only needed for pages inserted into the GTT, and for our paging structures we only need at most 4K bytes, so simply ignore the min_page_size restri

Re: [Intel-gfx] [PATCH] ALSA: hda: Release display power reference during shutdown/reboot

2021-06-23 Thread Imre Deak
On Wed, Jun 23, 2021 at 10:07:21AM +0200, Takashi Iwai wrote: > On Tue, 22 Jun 2021 21:58:13 +0200, > Imre Deak wrote: > > > > On Tue, Jun 22, 2021 at 04:18:14PM +0200, Takashi Iwai wrote: > > > On Mon, 21 Jun 2021 19:44:15 +0200, > > > Imre Deak wrote: > > > > > > > > Make sure the HDA driver's

[Intel-gfx] [PATCH 2/2] ALSA: hda: Release codec display power during shutdown/reboot

2021-06-23 Thread Imre Deak
Similarly to the previous patch for the HDA controller make sure here that codecs also drop the display power reference during shutdown and reboot. This fixes a power ref leaked WARN in i915 during shutdown if the HDA driver is built with CONFIG_PM=n. Suggested-by: Takashi Iwai References: https

[Intel-gfx] [PATCH 1/2] ALSA: hda: Release controller display power during shutdown/reboot

2021-06-23 Thread Imre Deak
Make sure the HDA driver's display power reference is released during shutdown/reboot. During the shutdown/reboot sequence the pci device core calls the pm_runtime_resume handler for all devices before calling the driver's shutdown callback and so the HDA driver's runtime resume callback will acqu

Re: [Intel-gfx] [PATCH 15/15] RFC: drm/amdgpu: Implement a proper implicit fencing uapi

2021-06-23 Thread Daniel Vetter
On Wed, Jun 23, 2021 at 3:44 PM Christian König wrote: > > Am 23.06.21 um 15:38 schrieb Bas Nieuwenhuizen: > > On Wed, Jun 23, 2021 at 2:59 PM Christian König > > wrote: > >> Am 23.06.21 um 14:18 schrieb Daniel Vetter: > >>> On Wed, Jun 23, 2021 at 11:45 AM Bas Nieuwenhuizen > >>> wrote: >

Re: [Intel-gfx] [PATCH v2 14/17] drm/i915: Fix ehl edp hbr2 vswing table

2021-06-23 Thread Jani Nikula
On Tue, 08 Jun 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > EHL is supposed to use special buf trans values for eDP HBR2+. > Add such a table. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > .../drm/i915/display/intel_ddi_buf_trans.c| 28 +-- > 1

[Intel-gfx] [PATCH v9 0/3] drm/i915: Move system memory to TTM for discrete

2021-06-23 Thread Thomas Hellström
Early implementation of moving system memory for discrete cards over to TTM. We first add the notion of objects being migratable under the object lock to i915 gem, and add some asserts to verify that objects are either locked or pinned when the placement is checked by the gem code. Patch 2 deals w

[Intel-gfx] [PATCH v9 1/3] drm/i915: Update object placement flags to be mutable

2021-06-23 Thread Thomas Hellström
The object ops i915_GEM_OBJECT_HAS_IOMEM and the object I915_BO_ALLOC_STRUCT_PAGE flags are considered immutable by much of our code. Introduce a new mem_flags member to hold these and make sure checks for these flags being set are either done under the object lock or with pages properly pinned. Th

[Intel-gfx] [PATCH v9 2/3] drm/i915/ttm: Adjust gem flags and caching settings after a move

2021-06-23 Thread Thomas Hellström
After a TTM move or object init we need to update the i915 gem flags and caching settings to reflect the new placement. Currently caching settings are not changed during the lifetime of an object, although that might change moving forward if we run into performance issues or issues with WC system p

[Intel-gfx] [PATCH v9 3/3] drm/i915/ttm: Use TTM for system memory

2021-06-23 Thread Thomas Hellström
For discrete, use TTM for both cached and WC system memory. That means we currently rely on the TTM memory accounting / shrinker. For cached system memory we should consider remaining shmem-backed, which can be implemented from our ttm_tt_populate callback. We can then also reuse our own very elabo

Re: [Intel-gfx] [PATCH v2 15/17] drm/i915: Clean up jsl/ehl buf trans functions

2021-06-23 Thread Jani Nikula
On Tue, 08 Jun 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > The jsl/ehl buf trans functions are needlessly conplicated. ^ My only disappointment here is that now some of the *_get_combo_buf_trans_edp() functions handle low vswing inside,

Re: [Intel-gfx] [PATCH v2 16/17] drm/i915: Nuke buf_trans hdmi functions

2021-06-23 Thread Jani Nikula
On Tue, 08 Jun 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > All the foo_get_buf_trans_hdmi() functions just reuturn a single table. > Remove the pointless wrappers. > > v2: Handle adl-p > > Signed-off-by: Ville Syrjälä Less is more. Reviewed-by: Jani Nikula > --- > .../drm/i915/disp

[Intel-gfx] [PATCH v2 1/2] drm/i915: support forcing the page size with lmem

2021-06-23 Thread Matthew Auld
For some specialised objects we might need something larger than the regions min_page_size due to some hw restriction, and slightly more hairy is needing something smaller with the guarantee that such objects will never be inserted into any GTT, which is the case for the paging structures. This al

[Intel-gfx] [PATCH v2 2/2] drm/i915/gtt: ignore min_page_size for paging structures

2021-06-23 Thread Matthew Auld
The min_page_size is only needed for pages inserted into the GTT, and for our paging structures we only need at most 4K bytes, so simply ignore the min_page_size restrictions here, otherwise we might see some severe overallocation on some devices. v2(Thomas): add some commentary Signed-off-by: Ma

Re: [Intel-gfx] [PATCH v13 01/12] swiotlb: Refactor swiotlb init functions

2021-06-23 Thread Tom Lendacky
On 6/18/21 1:25 AM, Claire Chang wrote: > On Fri, Jun 18, 2021 at 7:30 AM Stefano Stabellini > wrote: >> >> On Thu, 17 Jun 2021, Claire Chang wrote: >>> Add a new function, swiotlb_init_io_tlb_mem, for the io_tlb_mem struct >>> initialization to make the code reusable. >>> >>> Signed-off-by: Clair

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/ttm: consider all placements for the page alignment

2021-06-23 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/ttm: consider all placements for the page alignment URL : https://patchwork.freedesktop.org/series/91811/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't

[Intel-gfx] [PATCH] drm/i915/ttm: fix static warning

2021-06-23 Thread Matthew Auld
warning: symbol 'i915_gem_ttm_obj_ops' was not declared. Should it be static? Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/d

Re: [Intel-gfx] [PATCH v2 17/17] drm/i915: Add the missing adls vswing tables

2021-06-23 Thread Jani Nikula
On Tue, 08 Jun 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > adls is supposed to use special buf trans tables. Add what's > missing. > > v2: Drop the RBR/HBR table since it's the same as for tgl > > Signed-off-by: Ville Syrjälä Pedantically reviewed every value, Reviewed-by: Jani Nikula

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/ttm: consider all placements for the page alignment

2021-06-23 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/ttm: consider all placements for the page alignment URL : https://patchwork.freedesktop.org/series/91811/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10268 -> Patchwork_20439 ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] ALSA: hda: Release controller display power during shutdown/reboot

2021-06-23 Thread Patchwork
== Series Details == Series: series starting with [1/2] ALSA: hda: Release controller display power during shutdown/reboot URL : https://patchwork.freedesktop.org/series/91815/ State : warning == Summary == $ dim checkpatch origin/drm-tip 150ed9082a2d ALSA: hda: Release controller display pow

Re: [Intel-gfx] [PATCH 15/15] RFC: drm/amdgpu: Implement a proper implicit fencing uapi

2021-06-23 Thread Daniel Vetter
On Wed, Jun 23, 2021 at 4:02 PM Christian König wrote: > > Am 23.06.21 um 15:49 schrieb Daniel Vetter: > > On Wed, Jun 23, 2021 at 3:44 PM Christian König > > wrote: > >> Am 23.06.21 um 15:38 schrieb Bas Nieuwenhuizen: > >>> On Wed, Jun 23, 2021 at 2:59 PM Christian König > >>> wrote: > Am

Re: [Intel-gfx] [PATCH 1/2] ALSA: hda: Release controller display power during shutdown/reboot

2021-06-23 Thread Takashi Iwai
On Wed, 23 Jun 2021 15:46:00 +0200, Imre Deak wrote: > > Make sure the HDA driver's display power reference is released during > shutdown/reboot. > > During the shutdown/reboot sequence the pci device core calls the > pm_runtime_resume handler for all devices before calling the driver's > shutdow

Re: [Intel-gfx] [PATCH 15/15] RFC: drm/amdgpu: Implement a proper implicit fencing uapi

2021-06-23 Thread Bas Nieuwenhuizen
On Wed, Jun 23, 2021 at 4:50 PM Daniel Vetter wrote: > > On Wed, Jun 23, 2021 at 4:02 PM Christian König > wrote: > > > > Am 23.06.21 um 15:49 schrieb Daniel Vetter: > > > On Wed, Jun 23, 2021 at 3:44 PM Christian König > > > wrote: > > >> Am 23.06.21 um 15:38 schrieb Bas Nieuwenhuizen: > > >>>

Re: [Intel-gfx] [PATCH 15/15] RFC: drm/amdgpu: Implement a proper implicit fencing uapi

2021-06-23 Thread Daniel Vetter
On Wed, Jun 23, 2021 at 04:58:27PM +0200, Bas Nieuwenhuizen wrote: > On Wed, Jun 23, 2021 at 4:50 PM Daniel Vetter wrote: > > > > On Wed, Jun 23, 2021 at 4:02 PM Christian König > > wrote: > > > > > > Am 23.06.21 um 15:49 schrieb Daniel Vetter: > > > > On Wed, Jun 23, 2021 at 3:44 PM Christian Kö

Re: [Intel-gfx] [PATCH v6 1/3] drm/i915: Update object placement flags to be mutable

2021-06-23 Thread Daniel Vetter
On Mon, Jun 21, 2021 at 09:36:42PM +0200, Thomas Hellström wrote: > The object ops i915_GEM_OBJECT_HAS_IOMEM and the object > I915_BO_ALLOC_STRUCT_PAGE flags are considered immutable by > much of our code. Introduce a new mem_flags member to hold these > and make sure checks for these flags being s

Re: [Intel-gfx] [PATCH 15/15] RFC: drm/amdgpu: Implement a proper implicit fencing uapi

2021-06-23 Thread Daniel Vetter
On Wed, Jun 23, 2021 at 05:07:17PM +0200, Christian König wrote: > Am 23.06.21 um 17:03 schrieb Daniel Vetter: > > On Wed, Jun 23, 2021 at 04:58:27PM +0200, Bas Nieuwenhuizen wrote: > > > On Wed, Jun 23, 2021 at 4:50 PM Daniel Vetter > > > wrote: > > > > On Wed, Jun 23, 2021 at 4:02 PM Christian

Re: [Intel-gfx] [PATCH 01/15] dma-resv: Fix kerneldoc

2021-06-23 Thread Daniel Vetter
On Wed, Jun 23, 2021 at 10:31:18AM +0200, Christian König wrote: > Am 22.06.21 um 18:54 schrieb Daniel Vetter: > > Oversight from > > > > commit 6edbd6abb783d54f6ac4c3ed5cd9e50cff6c15e9 > > Author: Christian König > > Date: Mon May 10 16:14:09 2021 +0200 > > > > dma-buf: rename and cleanu

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] ALSA: hda: Release controller display power during shutdown/reboot

2021-06-23 Thread Patchwork
== Series Details == Series: series starting with [1/2] ALSA: hda: Release controller display power during shutdown/reboot URL : https://patchwork.freedesktop.org/series/91815/ State : success == Summary == CI Bug Log - changes from CI_DRM_10268 -> Patchwork_20440

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Move system memory to TTM for discrete (rev9)

2021-06-23 Thread Patchwork
== Series Details == Series: drm/i915: Move system memory to TTM for discrete (rev9) URL : https://patchwork.freedesktop.org/series/90898/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +drivers/g

Re: [Intel-gfx] [PATCH] drm/i915/ttm: fix static warning

2021-06-23 Thread Thomas Hellström
On 6/23/21 4:34 PM, Matthew Auld wrote: warning: symbol 'i915_gem_ttm_obj_ops' was not declared. Should it be static? Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH 2/6] drm/i915/display/adl_p: Implement Wa_22012278275

2021-06-23 Thread Gwan-gyeong Mun
On 6/16/21 11:31 PM, José Roberto de Souza wrote: The PSR2_CTL io buffer wake and fast wake values do not match expected in pre production hardware, so here adding a table that matches with HW to program it with values that HW expect. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza

Re: [Intel-gfx] [PATCH v6 1/3] drm/i915: Update object placement flags to be mutable

2021-06-23 Thread Thomas Hellström
Thanks for reviewing, Daniel. On 6/23/21 5:09 PM, Daniel Vetter wrote: + unsigned int mem_flags:2; Is the entire bitfield array all protected by dma_resv_lock? If not I'd just go with a full field, avoids headaches and all that. Also kerneldoc for this would be really sweet. Means some wor

Re: [Intel-gfx] [PATCH 07/15] drm/atomic-helper: make drm_gem_plane_helper_prepare_fb the default

2021-06-23 Thread Sam Ravnborg
Hi Daniel, > > >* equivalent functionality should be implemented through private > > >* members in the plane structure. > > >* > > > - * Drivers which always have their buffers pinned should use > > > - * drm_gem_plane_helper_prepare_fb() for this hook. > > > +

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move system memory to TTM for discrete (rev9)

2021-06-23 Thread Patchwork
== Series Details == Series: drm/i915: Move system memory to TTM for discrete (rev9) URL : https://patchwork.freedesktop.org/series/90898/ State : success == Summary == CI Bug Log - changes from CI_DRM_10268 -> Patchwork_20441 Summary -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915: support forcing the page size with lmem

2021-06-23 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: support forcing the page size with lmem URL : https://patchwork.freedesktop.org/series/91820/ State : warning == Summary == $ dim checkpatch origin/drm-tip 870ae7fc4949 drm/i915: support forcing the page size with lmem -:323

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915: support forcing the page size with lmem

2021-06-23 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: support forcing the page size with lmem URL : https://patchwork.freedesktop.org/series/91820/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be check

[Intel-gfx] [PATCH] dma-buf: Switch to inline kerneldoc

2021-06-23 Thread Daniel Vetter
Also review & update everything while we're at it. This is prep work to smash a ton of stuff into the kerneldoc for @resv. v2: Move the doc for sysfs_entry.attachment_uid to the right place too (Sam) Acked-by: Christian König Cc: Sam Ravnborg Reviewed-by: Alex Deucher Signed-off-by: Daniel Ve

[Intel-gfx] [PATCH] dma-buf: Document dma-buf implicit fencing/resv fencing rules

2021-06-23 Thread Daniel Vetter
Docs for struct dma_resv are fairly clear: "A reservation object can have attached one exclusive fence (normally associated with write operations) or N shared fences (read operations)." https://dri.freedesktop.org/docs/drm/driver-api/dma-buf.html#reservation-objects Furthermore a review across a

[Intel-gfx] [PATCH] drm/atomic-helper: make drm_gem_plane_helper_prepare_fb the default

2021-06-23 Thread Daniel Vetter
There's a bunch of atomic drivers who don't do this quite correctly, luckily most of them aren't in wide use or people would have noticed the tearing. By making this the default we avoid the constant audit pain and can additionally remove a ton of lines from vfuncs for a bit more clarity in smalle

[Intel-gfx] [PATCH] drm/simple-helper: drm_gem_simple_display_pipe_prepare_fb as default

2021-06-23 Thread Daniel Vetter
It's tedious to review this all the time, and my audit showed that arcpgu actually forgot to set this. Make this the default and stop worrying. Again I sprinkled WARN_ON_ONCE on top to make sure we don't have strange combinations of hooks: cleanup_fb without prepare_fb doesn't make sense, and sin

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: support forcing the page size with lmem

2021-06-23 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: support forcing the page size with lmem URL : https://patchwork.freedesktop.org/series/91820/ State : success == Summary == CI Bug Log - changes from CI_DRM_10268 -> Patchwork_20442 ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ttm: fix static warning

2021-06-23 Thread Patchwork
== Series Details == Series: drm/i915/ttm: fix static warning URL : https://patchwork.freedesktop.org/series/91821/ State : warning == Summary == $ dim checkpatch origin/drm-tip 884185292bdf drm/i915/ttm: fix static warning -:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit descripti

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/ttm: fix static warning

2021-06-23 Thread Patchwork
== Series Details == Series: drm/i915/ttm: fix static warning URL : https://patchwork.freedesktop.org/series/91821/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -O:drivers/gpu/drm/i915/gem/i915_

Re: [Intel-gfx] [PATCH v6 1/3] drm/i915: Update object placement flags to be mutable

2021-06-23 Thread Daniel Vetter
On Wed, Jun 23, 2021 at 5:38 PM Thomas Hellström wrote: > > Thanks for reviewing, Daniel. > > On 6/23/21 5:09 PM, Daniel Vetter wrote: > > > >> > >> +unsigned int mem_flags:2; > > Is the entire bitfield array all protected by dma_resv_lock? If not I'd > > just go with a full field, avoids head

Re: [Intel-gfx] [PATCH v3] drm/i915: keep backlight_enable on until turn eDP display off

2021-06-23 Thread Jani Nikula
On Tue, 22 Jun 2021, Lee Shawn C wrote: > This workaround is specific for a particular panel on Google > chromebook project. When user space daemon enter idle state. > It request adjust brightness to 0, turn backlight_enable signal > off and keep eDP main link active. > > On general LCD, this beha

Re: [Intel-gfx] [PATCH 06/15] drm/panfrost: Fix implicit sync

2021-06-23 Thread Boris Brezillon
On Tue, 22 Jun 2021 18:55:02 +0200 Daniel Vetter wrote: > Currently this has no practial relevance I think because there's not > many who can pull off a setup with panfrost and another gpu in the > same system. But the rules are that if you're setting an exclusive > fence, indicating a gpu write

Re: [Intel-gfx] [PATCH 05/15] drm/panfrost: Use xarray and helpers for depedency tracking

2021-06-23 Thread Boris Brezillon
On Tue, 22 Jun 2021 18:55:01 +0200 Daniel Vetter wrote: > More consistency and prep work for the next patch. > > Aside: I wonder whether we shouldn't just move this entire xarray > business into the scheduler so that not everyone has to reinvent the > same wheels. Cc'ing some scheduler people fo

  1   2   3   >