[Intel-gfx] ✓ Fi.CI.BAT: success for i915 TTM sync accelerated migration and clear (rev4)

2021-06-17 Thread Patchwork
== Series Details == Series: i915 TTM sync accelerated migration and clear (rev4) URL : https://patchwork.freedesktop.org/series/91463/ State : success == Summary == CI Bug Log - changes from CI_DRM_10233 -> Patchwork_20397 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add relocation exceptions for two other platforms (rev8)

2021-06-17 Thread Patchwork
== Series Details == Series: drm/i915: Add relocation exceptions for two other platforms (rev8) URL : https://patchwork.freedesktop.org/series/89594/ State : success == Summary == CI Bug Log - changes from CI_DRM_10233_full -> Patchwork_20395_full ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg1: Add HWMON power sensor support (rev6)

2021-06-17 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Add HWMON power sensor support (rev6) URL : https://patchwork.freedesktop.org/series/88459/ State : warning == Summary == $ dim checkpatch origin/drm-tip 77d53ceadffe drm/i915/dg1: Add HWMON power sensor support -:22: WARNING:FILE_PATH_CHANGES: added,

[Intel-gfx] ✓ Fi.CI.IGT: success for i915 TTM sync accelerated migration and clear (rev4)

2021-06-17 Thread Patchwork
== Series Details == Series: i915 TTM sync accelerated migration and clear (rev4) URL : https://patchwork.freedesktop.org/series/91463/ State : success == Summary == CI Bug Log - changes from CI_DRM_10233_full -> Patchwork_20397_full Summar

[Intel-gfx] [PATCH] drm/i915/ttm: remove unused function

2021-06-17 Thread Matthew Auld
intel_region_ttm_node_free is no longer used. Also fixup the related kerneldoc. Reported-by: kernel test robot Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/intel_region_ttm.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/driver

Re: [Intel-gfx] [PATCH] drm/i915/gem: Remove duplicated call to ops->pread

2021-06-17 Thread Daniel Vetter
On Wed, Jun 16, 2021 at 11:45:28AM +0100, Matthew Auld wrote: > On Wed, 16 Jun 2021 at 10:04, Daniel Vetter wrote: > > > > Between > > > > commit ae30af84edb5b7cc95485922e43afd909a892e1b > > Author: Maarten Lankhorst > > Date: Tue Mar 23 16:50:00 2021 +0100 > > > > drm/i915: Disable userptr

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg1: Add HWMON power sensor support (rev6)

2021-06-17 Thread Patchwork
== Series Details == Series: drm/i915/dg1: Add HWMON power sensor support (rev6) URL : https://patchwork.freedesktop.org/series/88459/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10233 -> Patchwork_20398 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/ttm: remove unused function

2021-06-17 Thread Patchwork
== Series Details == Series: drm/i915/ttm: remove unused function URL : https://patchwork.freedesktop.org/series/91621/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -O:drivers/gpu/drm/i915/intel

Re: [Intel-gfx] [PATCH] drm/i915/ttm: remove unused function

2021-06-17 Thread Thomas Hellström
On 6/17/21 10:37 AM, Matthew Auld wrote: intel_region_ttm_node_free is no longer used. Also fixup the related kerneldoc. Reported-by: kernel test robot Signed-off-by: Matthew Auld Cc: Thomas Hellström LGTM. Reviewed-by: Thomas Hellström ___ I

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ttm: remove unused function

2021-06-17 Thread Patchwork
== Series Details == Series: drm/i915/ttm: remove unused function URL : https://patchwork.freedesktop.org/series/91621/ State : success == Summary == CI Bug Log - changes from CI_DRM_10233 -> Patchwork_20399 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH] drm/dp_mst: Add missing drm parameters to recently added call to drm_dbg_kms()

2021-06-17 Thread Lin, Wayne
[Public] Really sorry for the mistake that I made and any inconvenience it brought. Thanks José and Lyude. Regards, Wayne > From: Lyude Paul > Sent: Thursday, June 17, 2021 03:47 > To: José Roberto de Souza; intel-gfx@lists.freedesktop.org > Cc: dri-de..

Re: [Intel-gfx] [PATCH v12 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing

2021-06-17 Thread Stefano Stabellini
On Wed, 16 Jun 2021, Claire Chang wrote: > Propagate the swiotlb_force into io_tlb_default_mem->force_bounce and > use it to determine whether to bounce the data or not. This will be > useful later to allow for different pools. > > Signed-off-by: Claire Chang > --- > include/linux/swiotlb.h | 11

Re: [Intel-gfx] [PATCH v12 11/12] dt-bindings: of: Add restricted DMA pool

2021-06-17 Thread Stefano Stabellini
On Wed, 16 Jun 2021, Claire Chang wrote: > Introduce the new compatible string, restricted-dma-pool, for restricted > DMA. One can specify the address and length of the restricted DMA memory > region by restricted-dma-pool in the reserved-memory node. > > Signed-off-by: Claire Chang > --- > .../

Re: [Intel-gfx] [PATCH] drm/i915: Perform execbuffer object locking as a separate step

2021-06-17 Thread Ramalingam C
On 2021-06-15 at 13:36:00 +0200, Thomas Hellström wrote: > To help avoid evicting already resident buffers from the batch we're > processing, perform locking as a separate step. > Looks reasonable to me. Reviewed-by: Ramalingam C > Signed-off-by: Thomas Hellström > --- > .../gpu/drm/i915/gem/

Re: [Intel-gfx] [PATCH] drm/i915: Perform execbuffer object locking as a separate step

2021-06-17 Thread Thomas Hellström
On 6/17/21 11:56 AM, Ramalingam C wrote: On 2021-06-15 at 13:36:00 +0200, Thomas Hellström wrote: To help avoid evicting already resident buffers from the batch we're processing, perform locking as a separate step. Looks reasonable to me. Reviewed-by: Ramalingam C Thanks for reviewing!

Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms

2021-06-17 Thread Rodrigo Vivi
On Thu, Jun 17, 2021 at 07:44:18AM +0200, Zbigniew Kempczyński wrote: > For topic/intel-for-CI branch only. pushed to topic/core-for-CI. Thanks for the patch. > > We have established previously we stop using relocations starting > from gen12 platforms with Tigerlake as an exception. We keep thi

Re: [Intel-gfx] [PATCH] drm/i915: Perform execbuffer object locking as a separate step

2021-06-17 Thread Maarten Lankhorst
Op 15-06-2021 om 13:36 schreef Thomas Hellström: > To help avoid evicting already resident buffers from the batch we're > processing, perform locking as a separate step. > > Signed-off-by: Thomas Hellström > --- > .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 25 --- > 1 file ch

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ttm: remove unused function

2021-06-17 Thread Patchwork
== Series Details == Series: drm/i915/ttm: remove unused function URL : https://patchwork.freedesktop.org/series/91621/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10233_full -> Patchwork_20399_full Summary --- **F

[Intel-gfx] Allow mdev drivers to directly create the vfio_device (v4)

2021-06-17 Thread Christoph Hellwig
This is my alternative take on this series from Jason: https://lore.kernel.org/dri-devel/87czsszi9i@redhat.com/T/ The mdev/vfio parts are exactly the same, but this solves the driver core changes for the direct probing without the in/out flag that Greg hated, which cause a little more work, b

[Intel-gfx] [PATCH 01/10] driver core: Pull required checks into driver_probe_device()

2021-06-17 Thread Christoph Hellwig
From: Jason Gunthorpe Checking if the dev is dead or if the dev is already bound is a required precondition to invoking driver_probe_device(). All the call chains leading here duplicate these checks. Add it directly to driver_probe_device() so the precondition is clear and remove the checks from

[Intel-gfx] [PATCH 02/10] driver core: Better distinguish probe errors in really_probe

2021-06-17 Thread Christoph Hellwig
really_probe tries to special case errors from ->probe, but due to all other initialization added to the function over time now a lot of internal errors hit that code path as well. Untangle that by adding a new probe_err local variable and apply the special casing only to that. Signed-off-by: Chr

[Intel-gfx] [PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind

2021-06-17 Thread Christoph Hellwig
Currently really_probe() returns 1 on success and 0 if the probe() call fails. This return code arrangement is designed to be useful for __device_attach_driver() which is walking the device list and trying every driver. 0 means to keep trying. However, it is not useful for the other places that ca

[Intel-gfx] [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during sysfs bind

2021-06-17 Thread Christoph Hellwig
EPROBE_DEFER is an internal kernel error code and it should not be leaked to userspace via the bind_store() sysfs. Userspace doesn't have this constant and cannot understand it. Further, it doesn't really make sense to have userspace trigger a deferred probe via bind_store(), which could eventuall

[Intel-gfx] [PATCH 05/10] driver core: Export device_driver_attach()

2021-06-17 Thread Christoph Hellwig
From: Jason Gunthorpe This is intended as a replacement API for device_bind_driver(). It has at least the following benefits: - Internal locking. Few of the users of device_bind_driver() follow the locking rules - Calls device driver probe() internally. Notably this means that devm support

[Intel-gfx] [PATCH 06/10] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE

2021-06-17 Thread Christoph Hellwig
From: Jason Gunthorpe For some reason the vfio_mdev shim mdev_driver has its own module and kconfig. As the next patch requires access to it from mdev.ko merge the two modules together and remove VFIO_MDEV_DEVICE. A later patch deletes this driver entirely. Signed-off-by: Jason Gunthorpe Signe

[Intel-gfx] [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind

2021-06-17 Thread Christoph Hellwig
From: Jason Gunthorpe This allows a mdev driver to opt out of using vfio_mdev.c, instead the driver will provide a 'struct mdev_driver' and register directly with the driver core. Much of mdev_parent_ops becomes unused in this mode: - create()/remove() are done via the mdev_driver probe()/remove

[Intel-gfx] [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev()

2021-06-17 Thread Christoph Hellwig
From: Jason Gunthorpe This is straightforward conversion, the mdev_state is actually serving as the vfio_device and we can replace all the mdev_get_drvdata()'s and the wonky dead code with a simple container_of() Reviewed-by: Christoph Hellwig Signed-off-by: Jason Gunthorpe Signed-off-by: Chri

[Intel-gfx] [PATCH 09/10] vfio/mdpy: Convert to use vfio_register_group_dev()

2021-06-17 Thread Christoph Hellwig
From: Jason Gunthorpe This is straightforward conversion, the mdev_state is actually serving as the vfio_device and we can replace all the mdev_get_drvdata()'s and the wonky dead code with a simple container_of(). Reviewed-by: Christoph Hellwig Signed-off-by: Jason Gunthorpe Signed-off-by: Chr

[Intel-gfx] [PATCH 10/10] vfio/mbochs: Convert to use vfio_register_group_dev()

2021-06-17 Thread Christoph Hellwig
From: Jason Gunthorpe This is straightforward conversion, the mdev_state is actually serving as the vfio_device and we can replace all the mdev_get_drvdata()'s and the wonky dead code with a simple container_of(). Reviewed-by: Christoph Hellwig Signed-off-by: Jason Gunthorpe Signed-off-by: Chr

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] driver core: Pull required checks into driver_probe_device()

2021-06-17 Thread Patchwork
== Series Details == Series: series starting with [01/10] driver core: Pull required checks into driver_probe_device() URL : https://patchwork.freedesktop.org/series/91634/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8569eedd3acf driver core: Pull required checks into driver

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/10] driver core: Pull required checks into driver_probe_device()

2021-06-17 Thread Patchwork
== Series Details == Series: series starting with [01/10] driver core: Pull required checks into driver_probe_device() URL : https://patchwork.freedesktop.org/series/91634/ State : success == Summary == CI Bug Log - changes from CI_DRM_10237 -> Patchwork_20400

Re: [Intel-gfx] [PATCH] drm/i915: Perform execbuffer object locking as a separate step

2021-06-17 Thread Tang, CQ
> -Original Message- > From: Intel-gfx On Behalf Of > Thomas Hellström > Sent: Tuesday, June 15, 2021 4:36 AM > To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Cc: Thomas Hellström ; Auld, Matthew > > Subject: [Intel-gfx] [PATCH] drm/i915: Perform execbuffer objec

Re: [Intel-gfx] [RFC PATCH 2/2] drm/doc/rfc: i915 new parallel submission uAPI plan

2021-06-17 Thread Daniel Vetter
Sorry I'm behind on mails ... On Fri, Jun 11, 2021 at 12:50:29PM -0700, Matthew Brost wrote: > On Fri, Jun 04, 2021 at 07:59:05PM +0200, Daniel Vetter wrote: > > On Wed, May 26, 2021 at 04:33:57PM -0700, Matthew Brost wrote: > > > Add entry for i915 new parallel submission uAPI plan. > > > > > >

Re: [Intel-gfx] [PATCH 0/2] GuC submission / DRM scheduler integration plan + new uAPI

2021-06-17 Thread Daniel Vetter
On Fri, Jun 11, 2021 at 04:40:42PM -0700, Matthew Brost wrote: > Subject and patches say it all. > > v2: Address comments, patches have details of changes > v3: Address comments, patches have details of changes > v4: Address comments, patches have details of changes > > Signed-off-by: Matthew Bro

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [01/10] driver core: Pull required checks into driver_probe_device()

2021-06-17 Thread Patchwork
== Series Details == Series: series starting with [01/10] driver core: Pull required checks into driver_probe_device() URL : https://patchwork.freedesktop.org/series/91634/ State : success == Summary == CI Bug Log - changes from CI_DRM_10237_full -> Patchwork_20400_full ==

Re: [Intel-gfx] [PATCH v2] drm/i915: Document the Virtual Engine uAPI

2021-06-17 Thread Daniel Vetter
On Mon, Jun 14, 2021 at 10:09:59AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > A little bit of documentation covering the topics of engine discovery, > context engine maps and virtual engines. It is not very detailed but > supposed to be a starting point of giving a brief high level o

Re: [Intel-gfx] [PATCH] drm/i915: allow DG1 autoprobe for CONFIG_BROKEN

2021-06-17 Thread Daniel Vetter
On Wed, Jun 16, 2021 at 03:29:26PM +0100, Matthew Auld wrote: > On Mon, 14 Jun 2021 at 10:22, Matthew Auld wrote: > > > > Purely for CI so we can get some pre-merge results for DG1. This is > > especially useful for cross driver TTM changes where CI can hopefully > > catch regressions. This is sim

Re: [Intel-gfx] drm/i915: __GFP_RETRY_MAYFAIL allocations in stable kernels

2021-06-17 Thread Daniel Vetter
On Mon, Jun 14, 2021 at 09:45:37PM +0900, Sergey Senozhatsky wrote: > Hi, > > We are observing some user-space crashes (sigabort, segfaults etc.) > under moderate memory pressure (pretty far from severe pressure) which > have one thing in common - restrictive GFP mask in setup_scratch_page(). > >

Re: [Intel-gfx] [RFC PATCH 2/2] drm/doc/rfc: i915 new parallel submission uAPI plan

2021-06-17 Thread Matthew Brost
On Thu, Jun 17, 2021 at 06:46:48PM +0200, Daniel Vetter wrote: > Sorry I'm behind on mails ... > Aren't we all. > On Fri, Jun 11, 2021 at 12:50:29PM -0700, Matthew Brost wrote: > > On Fri, Jun 04, 2021 at 07:59:05PM +0200, Daniel Vetter wrote: > > > On Wed, May 26, 2021 at 04:33:57PM -0700, Mat

Re: [Intel-gfx] [PATCH] drm/i915: Remove duplicate include of intel_region_lmem.h

2021-06-17 Thread Daniel Vetter
On Tue, Jun 15, 2021 at 07:35:20PM +0800, Wan Jiabing wrote: > Fix the following checkinclude.pl warning: > drivers/gpu/drm/i915/gt/intel_region_lmem.c > 8 #include "intel_region_lmem.h" > 12 #include "intel_region_lmem.h" > > Signed-off-by: Wan Jiabing Applied to drm-intel-gt-nex

Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix duplicate included intel_region_lmem.h

2021-06-17 Thread Daniel Vetter
On Wed, Jun 16, 2021 at 02:01:58PM +0800, Jiapeng Chong wrote: > Clean up the following includecheck warning: > > ./drivers/gpu/drm/i915/gt/intel_region_lmem.c: intel_region_lmem.h is > included more than once. > > No functional change. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chon

Re: [Intel-gfx] [PATCH v5 01/12] drm/i915: Reference objects on the ww object list

2021-06-17 Thread Daniel Vetter
On Thu, Jun 17, 2021 at 08:30:07AM +0200, Thomas Hellström wrote: > Since the ww transaction endpoint easily end up far out-of-scope of > the objects on the ww object list, particularly for contending lock > objects, make sure we reference objects on the list so they don't > disappear under us. >

Re: [Intel-gfx] [PATCH v2] drm/i915: Document the Virtual Engine uAPI

2021-06-17 Thread Tvrtko Ursulin
On 17/06/2021 18:17, Daniel Vetter wrote: On Mon, Jun 14, 2021 at 10:09:59AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin A little bit of documentation covering the topics of engine discovery, context engine maps and virtual engines. It is not very detailed but supposed to be a starting

[Intel-gfx] [PATCH v4 3/3] drm/i915: Add support for explicit L3BANK steering

2021-06-17 Thread Matt Roper
Because Render Power Gating restricts us to just a single subslice as a valid steering target for reads of multicast registers in a SUBSLICE range, the default steering we setup at init may not lead to a suitable target for L3BANK multicast register. In cases where it does not, use explicit runtim

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Explicity steer l3bank multicast reads when necessary (rev6)

2021-06-17 Thread Patchwork
== Series Details == Series: Explicity steer l3bank multicast reads when necessary (rev6) URL : https://patchwork.freedesktop.org/series/91485/ State : failure == Summary == Applying: drm/i915: extract steered reg access to common function Applying: drm/i915: Add GT support for multiple types

[Intel-gfx] [PATCH 0/5] Pipe DMC bits + PSR fix

2021-06-17 Thread Anusha Srivatsa
Pipe DMC series exposed a corner case in PSR patches that were merged recently. Sending the fix along with the Pipe DMC bits to get ensure that CI has no regressions. Anusha Srivatsa (4): drm/i915/dmc: Introduce DMC_FW_MAIN drm/i915/xelpd: Pipe A DMC plugging drm/i915/adl_p: Pipe B DMC Suppo

[Intel-gfx] [PATCH 2/5] drm/i915/dmc: Introduce DMC_FW_MAIN

2021-06-17 Thread Anusha Srivatsa
This is a prep patch for Pipe DMC plugging. Add dmc_info struct in intel_dmc to have all common fields shared between all DMC's in the package. Add DMC_FW_MAIN(dmc_id 0) to refer to the blob. v2: Remove dmc_offset and start_mmioaddr from dmc_info struct (Jose) Cc: Souza, Jose Signed-off-by: Anu

[Intel-gfx] [PATCH 3/5] drm/i915/xelpd: Pipe A DMC plugging

2021-06-17 Thread Anusha Srivatsa
This patch adds Pipe A plumbing to the already existing parsing and loading functions which is taken care of in the prep patches. Adding MAX_DMC_FW to keep track for both Main and Pipe A DMC while loading the respective blobs. Also adding present field in dmc_info. s/find_dmc_fw_offset/csr_set_dmc

[Intel-gfx] [PATCH 4/5] drm/i915/adl_p: Pipe B DMC Support

2021-06-17 Thread Anusha Srivatsa
ADLP requires us to load both Pipe A and Pipe B. Plug Pipe B loading support. Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 ++ drivers/gpu/drm/i915/display/intel_dmc.h | 1 + 2 files cha

[Intel-gfx] [PATCH 5/5] drm/i915/adl_p: Load DMC

2021-06-17 Thread Anusha Srivatsa
Load DMC v2.10 on ADLP. The release notes mention that this version enables few power savings features. v2: Add DMC_PATH() for ADLP (Lucas) Cc: Lucas De Marchi Cc: Clint Taylor Signed-off-by: Anusha Srivatsa Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dmc.c | 10 +

[Intel-gfx] [PATCH 1/5] drm/i915/display: Limit disabling PSR around cdclk changes to ADL-P

2021-06-17 Thread Anusha Srivatsa
From: Gwan-gyeong Mun Only ADL-P platform requires a temporal disabling of PSR for changing the CDCLK PLL frequency with crawling. Changing the CDCLK PLL frequency on prior platforms of ADL-P or changing the CDCLK PLL frequency without crawling on ADL-P don't need to disable of PSR. Bspec: 49207

[Intel-gfx] [CI 0/3] Explicity steer l3bank multicast reads when necessary

2021-06-17 Thread Matt Roper
We've recently learned that when steering reads of multicast registers that use 'subslice' replication, it's not only important to steer to a subslice that isn't fused off, but also to steer to the lowest-numbered subslice. This is because when Render Power Gating is enabled, grabbing forcewake wi

[Intel-gfx] [CI 2/3] drm/i915: Add GT support for multiple types of multicast steering

2021-06-17 Thread Matt Roper
Although most of our multicast registers are replicated per-subslice, we also have a small number of multicast registers that are replicated per-l3 bank instead. For both types of multicast registers we need to make sure we steer reads of these registers to a valid instance. Ideally we'd like to f

[Intel-gfx] [CI 3/3] drm/i915: Add support for explicit L3BANK steering

2021-06-17 Thread Matt Roper
Because Render Power Gating restricts us to just a single subslice as a valid steering target for reads of multicast registers in a SUBSLICE range, the default steering we setup at init may not lead to a suitable target for L3BANK multicast register. In cases where it does not, use explicit runtim

[Intel-gfx] [CI 1/3] drm/i915: extract steered reg access to common function

2021-06-17 Thread Matt Roper
From: Daniele Ceraolo Spurio New steering cases will be added in the follow-up patches, so prepare a common helper to avoid code duplication. Cc: Tvrtko Ursulin Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Matt Roper Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_engine

Re: [Intel-gfx] [PATCH 1/5] drm/i915/display: Limit disabling PSR around cdclk changes to ADL-P

2021-06-17 Thread Souza, Jose
On Thu, 2021-06-17 at 14:12 -0700, Anusha Srivatsa wrote: > From: Gwan-gyeong Mun > > Only ADL-P platform requires a temporal disabling of PSR for changing the > CDCLK PLL frequency with crawling. Changing the CDCLK PLL frequency on > prior platforms of ADL-P or changing the CDCLK PLL frequency w

Re: [Intel-gfx] [PATCH 1/5] drm/i915/display: Limit disabling PSR around cdclk changes to ADL-P

2021-06-17 Thread Srivatsa, Anusha
> -Original Message- > From: Souza, Jose > Sent: Thursday, June 17, 2021 2:18 PM > To: Mun, Gwan-gyeong ; Srivatsa, Anusha > ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 1/5] drm/i915/display: Limit disabling PSR > around cdclk changes to ADL-P > > On Thu, 2021-06

Re: [Intel-gfx] [PATCH 1/5] drm/i915/display: Limit disabling PSR around cdclk changes to ADL-P

2021-06-17 Thread Souza, Jose
On Thu, 2021-06-17 at 14:26 -0700, Srivatsa, Anusha wrote: > > > -Original Message- > > From: Souza, Jose > > Sent: Thursday, June 17, 2021 2:18 PM > > To: Mun, Gwan-gyeong ; Srivatsa, Anusha > > ; intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH 1/5] drm/i915/display:

[Intel-gfx] [PATCH] drm/i915/display: Do not zero past infoframes.vsc

2021-06-17 Thread Kees Cook
intel_dp_vsc_sdp_unpack() was using a memset() size (36, struct dp_sdp) larger than the destination (24, struct drm_dp_vsc_sdp), clobbering fields in struct intel_crtc_state after infoframes.vsc. Use the actual target size for the memset(). Fixes: 1b404b7dbb10 ("drm/i915/dp: Read out DP SDPs") Cc:

Re: [Intel-gfx] [PATCH] drm/i915/display: Do not zero past infoframes.vsc

2021-06-17 Thread Souza, Jose
On Thu, 2021-06-17 at 14:33 -0700, Kees Cook wrote: > intel_dp_vsc_sdp_unpack() was using a memset() size (36, struct dp_sdp) > larger than the destination (24, struct drm_dp_vsc_sdp), clobbering > fields in struct intel_crtc_state after infoframes.vsc. Use the actual > target size for the memset()

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Pipe DMC bits + PSR fix

2021-06-17 Thread Patchwork
== Series Details == Series: Pipe DMC bits + PSR fix URL : https://patchwork.freedesktop.org/series/91647/ State : warning == Summary == $ dim checkpatch origin/drm-tip 30ae65475a6b drm/i915/display: Limit disabling PSR around cdclk changes to ADL-P ef0c0ea027d1 drm/i915/dmc: Introduce DMC_FW_

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Pipe DMC bits + PSR fix

2021-06-17 Thread Patchwork
== Series Details == Series: Pipe DMC bits + PSR fix URL : https://patchwork.freedesktop.org/series/91647/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/display/intel_disp

[Intel-gfx] ✓ Fi.CI.BAT: success for Pipe DMC bits + PSR fix

2021-06-17 Thread Patchwork
== Series Details == Series: Pipe DMC bits + PSR fix URL : https://patchwork.freedesktop.org/series/91647/ State : success == Summary == CI Bug Log - changes from CI_DRM_10239 -> Patchwork_20403 Summary --- **SUCCESS** No regressi

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Explicity steer l3bank multicast reads when necessary (rev7)

2021-06-17 Thread Patchwork
== Series Details == Series: Explicity steer l3bank multicast reads when necessary (rev7) URL : https://patchwork.freedesktop.org/series/91485/ State : warning == Summary == $ dim checkpatch origin/drm-tip 796eee9fb582 drm/i915: extract steered reg access to common function -:90: CHECK:MULTIPL

[Intel-gfx] ✓ Fi.CI.BAT: success for Explicity steer l3bank multicast reads when necessary (rev7)

2021-06-17 Thread Patchwork
== Series Details == Series: Explicity steer l3bank multicast reads when necessary (rev7) URL : https://patchwork.freedesktop.org/series/91485/ State : success == Summary == CI Bug Log - changes from CI_DRM_10239 -> Patchwork_20404 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Do not zero past infoframes.vsc

2021-06-17 Thread Patchwork
== Series Details == Series: drm/i915/display: Do not zero past infoframes.vsc URL : https://patchwork.freedesktop.org/series/91650/ State : success == Summary == CI Bug Log - changes from CI_DRM_10239 -> Patchwork_20405 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for Pipe DMC bits + PSR fix

2021-06-17 Thread Patchwork
== Series Details == Series: Pipe DMC bits + PSR fix URL : https://patchwork.freedesktop.org/series/91647/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10239_full -> Patchwork_20403_full Summary --- **FAILURE** S

[Intel-gfx] ✗ Fi.CI.IGT: failure for Explicity steer l3bank multicast reads when necessary (rev7)

2021-06-17 Thread Patchwork
== Series Details == Series: Explicity steer l3bank multicast reads when necessary (rev7) URL : https://patchwork.freedesktop.org/series/91485/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10239_full -> Patchwork_20404_full

[Intel-gfx] [PATCH 2/8] drm/i915: Add i915_sched_engine_is_empty function

2021-06-17 Thread Matthew Brost
Add wrapper function around RB tree to determine if i915_sched_engine is empty. Signed-off-by: Matthew Brost Reviewed-by: Jason Ekstrand --- drivers/gpu/drm/i915/gt/intel_engine_cs.c| 2 +- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 6 +++--- drivers/gpu/drm/i915/gt/uc/i

[Intel-gfx] [PATCH 0/8] Introduce i915_sched_engine object

2021-06-17 Thread Matthew Brost
As discussed in [1] we are breaking that large series into a several smaller ones. This series is stand alone patch part of step #4 which has no other dependencies or patches relevant to it. v2: (Daniel Vetter): - Split into several smaller patches - Add kernel doc for i915_sched_engine (Mat

[Intel-gfx] [PATCH 7/8] drm/i915: Update i915_scheduler to operate on i915_sched_engine

2021-06-17 Thread Matthew Brost
Rather passing around an intel_engine_cs in the scheduling code, pass around a i915_sched_engine. v3: (Jason Ekstrand) Add READ_ONCE around rq->engine in lock_sched_engine Signed-off-by: Matthew Brost Reviewed-by: Jason Ekstrand --- .../drm/i915/gt/intel_execlists_submission.c | 11 +++--

[Intel-gfx] [PATCH 4/8] drm/i915: Move active tracking to i915_sched_engine

2021-06-17 Thread Matthew Brost
Move active request tracking and its lock to i915_sched_engine. This lock is also the submission lock so having it in the i915_sched_engine is the correct place. v3: (Jason Ekstrand) Add kernel doc v6: Rebase Signed-off-by: Matthew Brost Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu

[Intel-gfx] [PATCH 1/8] drm/i915: Move priolist to new i915_sched_engine object

2021-06-17 Thread Matthew Brost
Introduce i915_sched_engine object which is lower level data structure that i915_scheduler / generic code can operate on without touching execlist specific structures. This allows additional submission backends to be added without breaking the layering. Currently the execlists backend uses 1 of the

[Intel-gfx] [PATCH 6/8] drm/i915: Add kick_backend function to i915_sched_engine

2021-06-17 Thread Matthew Brost
Not all back-ends require a kick after a scheduling update, so make the kick a call-back function that the back-end can opt-in to. Also move the current kick function from the scheduler to the execlists file as it is specific to that back-end. Signed-off-by: Matthew Brost Reviewed-by: Daniele C

[Intel-gfx] [PATCH 5/8] drm/i915: Move engine->schedule to i915_sched_engine

2021-06-17 Thread Matthew Brost
The schedule function should be in the schedule object. v3: (Jason Ekstrand) Add kernel doc Signed-off-by: Matthew Brost Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 4 ++-- drivers/gpu/drm/i915/gt/intel_engine_cs.c| 3 --- drivers/gpu

[Intel-gfx] [PATCH 3/8] drm/i915: Reset sched_engine.no_priolist immediately after dequeue

2021-06-17 Thread Matthew Brost
Rather than touching schedule state in the generic PM code, reset the priolist allocation when empty in the submission code. Add a wrapper function to do this and update the backends to call it in the correct place. v3: (Jason Ekstrand) Update patch commit message with a better description Sig

[Intel-gfx] [PATCH 8/8] drm/i915: Move submission tasklet to i915_sched_engine

2021-06-17 Thread Matthew Brost
The submission tasklet operates on i915_sched_engine, thus it is the correct place for it. v3: (Jason Ekstrand) Change sched_engine->engine to a void* private data pointer Add kernel doc v4: (Daniele) Update private_data comment Set queue_priority_hint in kick_execlists v5: (CI) Rebas

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Do not zero past infoframes.vsc

2021-06-17 Thread Patchwork
== Series Details == Series: drm/i915/display: Do not zero past infoframes.vsc URL : https://patchwork.freedesktop.org/series/91650/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10239_full -> Patchwork_20405_full Summary -

[Intel-gfx] ✓ Fi.CI.BAT: success for Introduce i915_sched_engine object (rev6)

2021-06-17 Thread Patchwork
== Series Details == Series: Introduce i915_sched_engine object (rev6) URL : https://patchwork.freedesktop.org/series/90630/ State : success == Summary == CI Bug Log - changes from CI_DRM_10240 -> Patchwork_20406 Summary --- **SUCCES

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Explicity steer l3bank multicast reads when necessary (rev7)

2021-06-17 Thread Matt Roper
On Fri, Jun 18, 2021 at 12:10:23AM +, Patchwork wrote: > == Series Details == > > Series: Explicity steer l3bank multicast reads when necessary (rev7) > URL : https://patchwork.freedesktop.org/series/91485/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_10239_full

Re: [Intel-gfx] [PULL] drm-misc-next-fixes

2021-06-17 Thread Dave Airlie
when I pulled this in drm-next I got these. were the mst fixes meant for next or fixes btw? I'm not really sure, but either way I don't think this is a local reason it doesn't build or did I miss something? Dave. /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/drm_dp_mst_topology.c: In functi

Re: [Intel-gfx] drm/i915: __GFP_RETRY_MAYFAIL allocations in stable kernels

2021-06-17 Thread Sergey Senozhatsky
On (21/06/17 19:27), Daniel Vetter wrote: > > > > So can all allocations in gen8_init_scratch() use > > GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_NOWARN > > Yeah that looks all fairly broken tbh. The only thing I didn't know was > that GFP_DMA32 wasn't a full gfp mask with reclaim bits set as

Re: [Intel-gfx] [PULL] drm-misc-next-fixes

2021-06-17 Thread Lyude Paul
22:27 airlied: re: the pull, I should have pushed a fix for the compilation error today. that was something I pulled in from amd that they didn't compile check and I missed :S 22:28 airlied: 24ff3dc18b99c4b912ab1746e803ddb3be5ced4c in drm- misc/drm-misc-next-fixes sorry about this - I already ta

Re: [Intel-gfx] [PULL] drm-misc-next-fixes

2021-06-17 Thread Dave Airlie
On Fri, 18 Jun 2021 at 12:26, Dave Airlie wrote: > > when I pulled this in drm-next I got these. > > were the mst fixes meant for next or fixes btw? I'm not really sure, > but either way I don't think this is a local reason it doesn't build > or did I miss something? Hi Thomas, Please resend wit

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Do not zero past infoframes.vsc

2021-06-17 Thread Kees Cook
On Fri, Jun 18, 2021 at 12:58:22AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915/display: Do not zero past infoframes.vsc > URL : https://patchwork.freedesktop.org/series/91650/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_10239_full -> Patchwo

[Intel-gfx] ✗ Fi.CI.IGT: failure for Introduce i915_sched_engine object (rev6)

2021-06-17 Thread Patchwork
== Series Details == Series: Introduce i915_sched_engine object (rev6) URL : https://patchwork.freedesktop.org/series/90630/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10240_full -> Patchwork_20406_full Summary ---

Re: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_plane_alpha_blend: Don't set primary fb color in coverage-vs-premult-vs-constant

2021-06-17 Thread Srinivas, Vidya
Hello, Humble request for review of this please https://patchwork.freedesktop.org/series/90828/ Can anyone kindly help review this so we can request for merge? Thank you so much. Regards Vidya -Original Message- From: Srinivas, Vidya Sent: Tuesday, June 15, 2021 1:55 PM To: Modem, Bha

Re: [Intel-gfx] [PATCH v13 01/12] swiotlb: Refactor swiotlb init functions

2021-06-17 Thread Claire Chang
On Fri, Jun 18, 2021 at 7:30 AM Stefano Stabellini wrote: > > On Thu, 17 Jun 2021, Claire Chang wrote: > > Add a new function, swiotlb_init_io_tlb_mem, for the io_tlb_mem struct > > initialization to make the code reusable. > > > > Signed-off-by: Claire Chang > > Reviewed-by: Christoph Hellwig >