[Intel-gfx] ✓ Fi.CI.BAT: success for Non-interface changing GuC CTBs updates (rev2)

2021-05-26 Thread Patchwork
== Series Details == Series: Non-interface changing GuC CTBs updates (rev2) URL : https://patchwork.freedesktop.org/series/90552/ State : success == Summary == CI Bug Log - changes from CI_DRM_10133 -> Patchwork_20196 Summary --- **S

Re: [Intel-gfx] [PATCH v3 06/12] drm/ttm: Add a generic TTM memcpy move for page-based iomem

2021-05-26 Thread Thomas Hellström
On 5/25/21 5:48 PM, Christian König wrote: Am 25.05.21 um 12:07 schrieb Thomas Hellström: On Tue, 2021-05-25 at 10:58 +0100, Matthew Auld wrote: On Tue, 25 May 2021 at 10:32, Thomas Hellström wrote: On 5/25/21 11:18 AM, Matthew Auld wrote: On Fri, 21 May 2021 at 16:33, Thomas Hellström

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Introduce timeslicing for userspace

2021-05-26 Thread Patchwork
== Series Details == Series: drm/i915/gt: Introduce timeslicing for userspace URL : https://patchwork.freedesktop.org/series/90568/ State : success == Summary == CI Bug Log - changes from CI_DRM_10133_full -> Patchwork_20195_full Summary --

[Intel-gfx] [PATCH] drm/i915/adl_p: enable MSO on pipe B

2021-05-26 Thread Jani Nikula
On ADL-P, it's possible to enable the stream splitter on pipe B in addition to pipe A. Bspec: 50174 Cc: Uma Shankar Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_ddi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/d

Re: [Intel-gfx] [RFC PATCH 60/97] drm/i915: Track 'serial' counts for virtual engines

2021-05-26 Thread Tvrtko Ursulin
On 25/05/2021 18:52, Matthew Brost wrote: On Tue, May 25, 2021 at 11:16:12AM +0100, Tvrtko Ursulin wrote: On 06/05/2021 20:14, Matthew Brost wrote: From: John Harrison The serial number tracking of engines happens at the backend of request submission and was expecting to only be given phys

[Intel-gfx] [PATCH v1 0/1] drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Nischal Varide
If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block. Nischal Varide (1): drm/i915/xelpd: Enabling dithering after the CC1 drivers/gpu/drm

[Intel-gfx] [PATCH v1 1/1] drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Nischal Varide
If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block. Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_color.c | 15 ++

Re: [Intel-gfx] [RFC PATCH 36/97] drm/i915/guc: Add non blocking CTB send function

2021-05-26 Thread Tvrtko Ursulin
On 25/05/2021 18:21, Matthew Brost wrote: On Tue, May 25, 2021 at 10:21:00AM +0100, Tvrtko Ursulin wrote: On 06/05/2021 20:13, Matthew Brost wrote: Add non blocking CTB send function, intel_guc_send_nb. In order to support a non blocking CTB send function a spin lock is needed to protect the

[Intel-gfx] [PATCH v1 1/1] drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Nischal Varide
If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block. Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_color.c | 15 ++

[Intel-gfx] [PATCH v1 0/1] drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Nischal Varide
If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block. Nischal Varide (1): drm/i915/xelpd: Enabling dithering after the CC1 drivers/gpu/drm

Re: [Intel-gfx] [RFC PATCH 55/97] drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC

2021-05-26 Thread Tvrtko Ursulin
On 25/05/2021 18:07, Matthew Brost wrote: On Tue, May 25, 2021 at 11:06:00AM +0100, Tvrtko Ursulin wrote: On 06/05/2021 20:14, Matthew Brost wrote: When running the GuC the GPU can't be considered idle if the GuC still has contexts pinned. As such, a call has been added in intel_gt_wait_for_

Re: [Intel-gfx] [RFC PATCH 53/97] drm/i915/guc: Disable semaphores when using GuC scheduling

2021-05-26 Thread Tvrtko Ursulin
On 25/05/2021 18:01, Matthew Brost wrote: On Tue, May 25, 2021 at 10:52:01AM +0100, Tvrtko Ursulin wrote: On 06/05/2021 20:14, Matthew Brost wrote: Disable semaphores when using GuC scheduling as semaphores are broken in the current GuC firmware. What is "current"? Given that the patch its

Re: [Intel-gfx] [RFC PATCH 39/97] drm/i915/guc: Increase size of CTB buffers

2021-05-26 Thread Tvrtko Ursulin
On 25/05/2021 18:15, Matthew Brost wrote: On Tue, May 25, 2021 at 10:24:09AM +0100, Tvrtko Ursulin wrote: On 06/05/2021 20:13, Matthew Brost wrote: With the introduction of non-blocking CTBs more than one CTB can be in flight at a time. Increasing the size of the CTBs should reduce how often

[Intel-gfx] ✓ Fi.CI.IGT: success for Non-interface changing GuC CTBs updates (rev2)

2021-05-26 Thread Patchwork
== Series Details == Series: Non-interface changing GuC CTBs updates (rev2) URL : https://patchwork.freedesktop.org/series/90552/ State : success == Summary == CI Bug Log - changes from CI_DRM_10133_full -> Patchwork_20196_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/adl_p: enable MSO on pipe B

2021-05-26 Thread Patchwork
== Series Details == Series: drm/i915/adl_p: enable MSO on pipe B URL : https://patchwork.freedesktop.org/series/90579/ State : success == Summary == CI Bug Log - changes from CI_DRM_10133 -> Patchwork_20197 Summary --- **SUCCESS**

[Intel-gfx] [PATCH 1/1] drm/i915: Add Wa_14010733141

2021-05-26 Thread Aditya Swarup
The WA requires the following procedure for VDBox SFC reset: If (MFX-SFC usage is 1) { 1.Issue a MFX-SFC forced lock 2.Wait for MFX-SFC forced lock ack 3.Check the MFX-SFC usage bit If (MFX-SFC usage bit is 1) Reset VDBOX and SFC else

[Intel-gfx] [PATCH 0/1] Adding Wa_14010733141 for SFC reset

2021-05-26 Thread Aditya Swarup
Need an ack for push to intel gt branch. The patch has already been reviewed by Daniele. Aditya Swarup (1): drm/i915: Add Wa_14010733141 drivers/gpu/drm/i915/gt/intel_reset.c | 194 +- drivers/gpu/drm/i915/i915_reg.h | 6 + 2 files changed, 137 insertions(+), 63

[Intel-gfx] [PATCH] drm/i915/params: Align visibility of device level and global modparams

2021-05-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We have a few modparams which get conditionaly exposed based on a Kconfig options and in most cases this also means portions of the driver implementing the respective feature are also left out. Align the visibility of device level and global modparams to make them consistent

Re: [Intel-gfx] [PATCH 1/1] Let userspace know if they can trust timeslicing by including it as part of the I915_PARAM_HAS_SCHEDULER::I915_SCHEDULER_CAP_TIMESLICING

2021-05-26 Thread Tvrtko Ursulin
On 25/05/2021 15:47, Daniel Vetter wrote: On Tue, May 25, 2021 at 03:19:47PM +0100, Tvrtko Ursulin wrote: + dri-devel as per process On 25/05/2021 14:55, Tejas Upadhyay wrote: v2: Only declare timeslicing if we can safely preempt userspace. Commit message got butchered up somehow so you'l

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Patchwork
== Series Details == Series: drm/i915/xelpd: Enabling dithering after the CC1 URL : https://patchwork.freedesktop.org/series/90582/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6abe80f275a2 drm/i915/xelpd: Enabling dithering after the CC1 -:27: CHECK:UNNECESSARY_PARENTHESES: U

Re: [Intel-gfx] [RFC PATCH 49/97] drm/i915/guc: Disable engine barriers with GuC during unpin

2021-05-26 Thread Tvrtko Ursulin
On 06/05/2021 20:14, Matthew Brost wrote: Disable engine barriers for unpinning with GuC. This feature isn't needed with the GuC as it disables context scheduling before unpinning Just isn't needed or causes a problem somehow? which guarantees the HW will not reference the context. Hence it

[Intel-gfx] [PATCH 0/2] drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Bhanuprakash Modem
If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block. Bhanuprakash Modem (1): drm/i915/display/debug: Expose Dither status via debugfs Nisc

[Intel-gfx] [PATCH 1/2] drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Bhanuprakash Modem
From: Nischal Varide If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block. Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/

[Intel-gfx] [PATCH 2/2] drm/i915/display/debug: Expose Dither status via debugfs

2021-05-26 Thread Bhanuprakash Modem
It's useful to know the dithering state & pipe bpc for IGT testing. This patch will expose the dithering state for the crtc via a debugfs file "dither". Example usage: cat /sys/kernel/debug/dri/0/crtc-0/dither Cc: Uma Shankar Cc: Nischal Varide Cc: Matt Roper Signed-off-by: Bhanuprakash Modem

Re: [Intel-gfx] [PATCH v3 06/12] drm/ttm: Add a generic TTM memcpy move for page-based iomem

2021-05-26 Thread Christian König
Am 26.05.21 um 09:39 schrieb Thomas Hellström: [SNIP] I think the long term goal is to use memremap all over the place, to just not have to bother with the __iomem annotation. But to do that io- mapping.h needs to support memremap. But for now we need to be strict about __iomem unless we're in a

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Patchwork
== Series Details == Series: drm/i915/xelpd: Enabling dithering after the CC1 URL : https://patchwork.freedesktop.org/series/90582/ State : success == Summary == CI Bug Log - changes from CI_DRM_10133 -> Patchwork_20198 Summary --- *

Re: [Intel-gfx] [PATCH v3 06/12] drm/ttm: Add a generic TTM memcpy move for page-based iomem

2021-05-26 Thread Thomas Hellström
On Wed, 2021-05-26 at 12:45 +0200, Christian König wrote: > Am 26.05.21 um 09:39 schrieb Thomas Hellström: > > [SNIP] > > > > I think the long term goal is to use memremap all over the > > > > place, to > > > > just not have to bother with the __iomem annotation. But to do > > > > that io- > > > >

Re: [Intel-gfx] [PATCH 2/7] dma-buf: Rename dma_resv helpers from _rcu to _unlocked (v2)

2021-05-26 Thread Christian König
Am 25.05.21 um 23:17 schrieb Jason Ekstrand: None of these helpers actually leak any RCU details to the caller. They all assume you have a genuine reference, take the RCU read lock, and retry if needed. Naming them with an _rcu is likely to cause callers more panic than needed. I'm really won

Re: [Intel-gfx] [PATCH 5/7] dma-buf: Add an API for exporting sync files (v11)

2021-05-26 Thread Christian König
Am 25.05.21 um 23:17 schrieb Jason Ekstrand: Modern userspace APIs like Vulkan are built on an explicit synchronization model. This doesn't always play nicely with the implicit synchronization used in the kernel and assumed by X11 and Wayland. The client -> compositor half of the synchronizatio

Re: [Intel-gfx] [PATCH 5/7] dma-buf: Add an API for exporting sync files (v11)

2021-05-26 Thread Daniel Stone
Hi Christian, On Wed, 26 May 2021 at 12:02, Christian König wrote: > Am 25.05.21 um 23:17 schrieb Jason Ekstrand: > > This new IOCTL solves this problem by allowing us to get a snapshot of > > the implicit synchronization state of a given dma-buf in the form of a > > sync file. It's effectively

Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong name announced on FB driver switching

2021-05-26 Thread Janusz Krzysztofik
Hi, On poniedziałek, 3 maja 2021 19:38:17 CEST Jani Nikula wrote: > On Thu, 29 Apr 2021, Janusz Krzysztofik wrote: > > Commit 7a0f9ef9703d ("drm/i915: Use drm_fb_helper_fill_info") > > effectively changed our FB driver name from "inteldrmfb" to > > "i915drmfb". However, we are still using the o

[Intel-gfx] [PATCH v4 00/15] drm/i915: Move LMEM (VRAM) management over to TTM

2021-05-26 Thread Thomas Hellström
This is an initial patch series to move discrete memory management over to TTM. It will be followed up shortly with adding more functionality. The buddy allocator is temporarily removed along with its selftests and It is replaced with the TTM range manager and some selftests are adjusted to accoun

[Intel-gfx] [PATCH v4 09/15] drm/ttm: Document and optimize ttm_bo_pipeline_gutting()

2021-05-26 Thread Thomas Hellström
If the bo is idle when calling ttm_bo_pipeline_gutting(), we unnecessarily create a ghost object and push it out to delayed destroy. Fix this by adding a path for idle, and document the function. Also avoid having the bo end up in a bad state vulnerable to user-space triggered kernel BUGs if the c

[Intel-gfx] [PATCH v4 06/15] drm/ttm: Add a generic TTM memcpy move for page-based iomem

2021-05-26 Thread Thomas Hellström
The internal ttm_bo_util memcpy uses ioremap functionality, and while it probably might be possible to use it for copying in- and out of sglist represented io memory, using io_mem_reserve() / io_mem_free() callbacks, that would cause problems with fault(). Instead, implement a method mapping page-b

[Intel-gfx] [PATCH v4 01/15] drm/i915: Untangle the vma pages_mutex

2021-05-26 Thread Thomas Hellström
Any sleeping dma_resv lock taken while the vma pages_mutex is held will cause a lockdep splat. Move the i915_gem_object_pin_pages() call out of the pages_mutex critical section. Signed-off-by: Thomas Hellström Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_vma.c | 29 +

[Intel-gfx] [PATCH v4 08/15] drm/ttm: Use drm_memcpy_from_wc_dbm for TTM bo moves

2021-05-26 Thread Thomas Hellström
Use fast wc memcpy for reading out of wc memory for TTM bo moves. Cc: Dave Airlie Cc: Christian König Cc: Daniel Vetter Signed-off-by: Thomas Hellström -- v4: - Clarify when we try drm_memcpy_from_wc_dbm (Reported by Matthew Auld) - Be paranoid about when drm_memcpy_from_wc_dbm may fail (Repor

[Intel-gfx] [PATCH v4 13/15] drm/i915: Disable mmap ioctl for gen12+

2021-05-26 Thread Thomas Hellström
From: Maarten Lankhorst The paltform should exclusively use mmap_offset, one less path to worry about for discrete. Signed-off-by: Maarten Lankhorst Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gp

[Intel-gfx] [PATCH v4 14/15] drm/vma: Add a driver_private member to vma_node.

2021-05-26 Thread Thomas Hellström
From: Maarten Lankhorst This allows drivers to distinguish between different types of vma_node's. The readonly flag was unused and is thus removed. Signed-off-by: Maarten Lankhorst Reviewed-by: Thomas Hellström --- drivers/gpu/drm/drm_gem.c | 9 - include/drm/drm_vma_manager.h | 2

[Intel-gfx] [PATCH v4 02/15] drm/i915: Don't free shared locks while shared

2021-05-26 Thread Thomas Hellström
We are currently sharing the VM reservation locks across a number of gem objects with page-table memory. Since TTM will individiualize the reservation locks when freeing objects, including accessing the shared locks, make sure that the shared locks are not freed until that is done. For PPGTT we add

[Intel-gfx] [PATCH v4 04/15] drm/i915/ttm Initialize the ttm device and memory managers

2021-05-26 Thread Thomas Hellström
Temporarily remove the buddy allocator and related selftests and hook up the TTM range manager for i915 regions. Also modify the mock region selftests somewhat to account for a fragmenting manager. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld #v2 --- v2: - Fix an error unwind in lm

[Intel-gfx] [PATCH v4 07/15] drm, drm/i915: Move the memcpy_from_wc functionality to core drm

2021-05-26 Thread Thomas Hellström
Memcpy from wc will be used as well by TTM memcpy. Move it to core drm, and make the interface do the right thing even on !X86. Cc: Christian König Cc: Daniel Vetter Cc: Dave Airlie Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- v4: - Fix !X86 path (Reported by Matthew Auld) --

[Intel-gfx] [PATCH v4 10/15] drm/ttm, drm/amdgpu: Allow the driver some control over swapping

2021-05-26 Thread Thomas Hellström
We are calling the eviction_valuable driver callback at eviction time to determine whether we actually can evict a buffer object. The upcoming i915 TTM backend needs the same functionality for swapout, and that might actually be beneficial to other drivers as well. Add an eviction_valuable call al

[Intel-gfx] [PATCH v4 12/15] drm/i915/lmem: Verify checks for lmem residency

2021-05-26 Thread Thomas Hellström
Since objects can be migrated or evicted when not pinned or locked, update the checks for lmem residency or future residency so that the value returned is not immediately stale. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- v2: Simplify i915_gem_object_migratable() (Reported by M

[Intel-gfx] [PATCH v4 15/15] drm/i915: Use ttm mmap handling for ttm bo's.

2021-05-26 Thread Thomas Hellström
From: Maarten Lankhorst Use the ttm handlers for servicing page faults, and vm_access. We do our own validation of read-only access, otherwise use the ttm handlers as much as possible. Because the ttm handlers expect the vma_node at vma->base, we slightly need to massage the mmap handlers to lo

[Intel-gfx] [PATCH v4 05/15] drm/i915/ttm: Embed a ttm buffer object in the i915 gem object

2021-05-26 Thread Thomas Hellström
Embed a struct ttm_buffer_object into the i915 gem object, making sure we alias the gem object part. It's a bit unfortunate that the struct ttm_buffer_ojbect embeds a gem object since we otherwise could make the TTM part private to the TTM backend, and use the usual i915 gem object for the other ba

[Intel-gfx] [PATCH v4 03/15] drm/i915: Fix i915_sg_page_sizes to record dma segments rather than physical pages

2021-05-26 Thread Thomas Hellström
All users of this function actually want the dma segment sizes, but that's not what's calculated. Fix that and rename the function to i915_sg_dma_sizes to reflect what's calculated. Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 2 +-

[Intel-gfx] [PATCH v4 11/15] drm/i915/ttm: Introduce a TTM i915 gem object backend

2021-05-26 Thread Thomas Hellström
Most logical place to introduce TTM buffer objects is as an i915 gem object backend. We need to add some ops to account for added functionality like delayed delete and LRU list manipulation. Initially we support only LMEM and SYSTEM memory, but SYSTEM (which in this case means evicted LMEM objects

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Patchwork
== Series Details == Series: drm/i915/xelpd: Enabling dithering after the CC1 URL : https://patchwork.freedesktop.org/series/90583/ State : warning == Summary == $ dim checkpatch origin/drm-tip a7d93728c6c9 drm/i915/xelpd: Enabling dithering after the CC1 -:27: CHECK:UNNECESSARY_PARENTHESES: U

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Patchwork
== Series Details == Series: drm/i915/xelpd: Enabling dithering after the CC1 URL : https://patchwork.freedesktop.org/series/90583/ State : success == Summary == CI Bug Log - changes from CI_DRM_10133 -> Patchwork_20199 Summary --- *

Re: [Intel-gfx] [PATCH 13/18] drm/i915/guc: Relax CTB response timeout

2021-05-26 Thread Michal Wajdeczko
On 26.05.2021 08:42, Matthew Brost wrote: > From: Michal Wajdeczko > > In upcoming patch we will allow more CTB requests to be sent in > parallel to the GuC for processing, so we shouldn't assume any more > that GuC will always reply without 10ms. > > Use bigger value from CONFIG_DRM_I915_GUC

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Adding Wa_14010733141 for SFC reset

2021-05-26 Thread Patchwork
== Series Details == Series: Adding Wa_14010733141 for SFC reset URL : https://patchwork.freedesktop.org/series/90587/ State : warning == Summary == $ dim checkpatch origin/drm-tip 89510e29356a drm/i915: Add Wa_14010733141 -:42: WARNING:BAD_SIGN_OFF: Co-developed-by: must be immediately follow

Re: [Intel-gfx] [PATCH 15/18] drm/i915/guc: Ensure H2G buffer updates visible before tail update

2021-05-26 Thread Michal Wajdeczko
On 26.05.2021 08:42, Matthew Brost wrote: > Ensure H2G buffer updates are visible before descriptor tail updates by > inserting a barrier between the H2G buffer update and the tail. The > barrier is simple wmb() for SMEM and is register write for LMEM. This is > needed if more than 1 H2G can be

Re: [Intel-gfx] [PATCH v7 14/15] dt-bindings: of: Add restricted DMA pool

2021-05-26 Thread Will Deacon
Hi Claire, On Tue, May 18, 2021 at 02:42:14PM +0800, Claire Chang wrote: > Introduce the new compatible string, restricted-dma-pool, for restricted > DMA. One can specify the address and length of the restricted DMA memory > region by restricted-dma-pool in the reserved-memory node. > > Signed-of

Re: [Intel-gfx] [PATCH 5/7] dma-buf: Add an API for exporting sync files (v11)

2021-05-26 Thread Christian König
Am 26.05.21 um 13:31 schrieb Daniel Stone: Hi Christian, On Wed, 26 May 2021 at 12:02, Christian König wrote: Am 25.05.21 um 23:17 schrieb Jason Ekstrand: This new IOCTL solves this problem by allowing us to get a snapshot of the implicit synchronization state of a given dma-buf in the form

Re: [Intel-gfx] [PATCH v3 08/12] drm/ttm: Use drm_memcpy_from_wc_dbm for TTM bo moves

2021-05-26 Thread Christian König
Am 21.05.21 um 17:32 schrieb Thomas Hellström: Use fast wc memcpy for reading out of wc memory for TTM bo moves. Cc: Dave Airlie Cc: Christian König Cc: Daniel Vetter Signed-off-by: Thomas Hellström Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 9 - 1 f

[Intel-gfx] [PATCH v2] drm/i915/display: relax 2big checking around initial fb

2021-05-26 Thread Matthew Auld
From: Chris Wilson The kernel prefers enabling fbc over the initial fb, since this leads to actual runtime power savings, so if the initial fb is deemed too big using some heuristic, then we simply skip allocating stolen for it. However if the kernel is not configured with fbcon then it should be

[Intel-gfx] ✓ Fi.CI.BAT: success for Adding Wa_14010733141 for SFC reset

2021-05-26 Thread Patchwork
== Series Details == Series: Adding Wa_14010733141 for SFC reset URL : https://patchwork.freedesktop.org/series/90587/ State : success == Summary == CI Bug Log - changes from CI_DRM_10133 -> Patchwork_20200 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/params: Align visibility of device level and global modparams

2021-05-26 Thread Patchwork
== Series Details == Series: drm/i915/params: Align visibility of device level and global modparams URL : https://patchwork.freedesktop.org/series/90588/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include

[Intel-gfx] [PATCH i-g-t v3 2/9] lib/i915/gem_create: Add gem_create_ext

2021-05-26 Thread Matthew Auld
From: Andrzej Turko Add a wrapper for gem_create_ext ioctl (a version of gem_create that accepts extensions). In preparation for the driver change implementing it, a local definition of its id and necessary structs have been added, which are to be erased as soon as those definitions appear in the

[Intel-gfx] [PATCH i-g-t v3 3/9] lib/i915/intel_memory_region: Add new memory region lib

2021-05-26 Thread Matthew Auld
From: Andrzej Turko With an introduction of Local Memory concept we should be able to allocate object in specific memory region. This patch implements helper functions that allow this, both for querying what the device supports and hooking into gem_create_ext to select the placements. Co-authore

[Intel-gfx] [PATCH i-g-t v3 5/9] tests/i915/gem_exec_basic: Use memory region interface

2021-05-26 Thread Matthew Auld
From: Andrzej Turko Converted the test gem_exec_basic to use the memory region uapi. Signed-off-by: Andrzej Turko Cc: Zbigniew Kempczynski Cc: Dominik Grzegorzek Cc: Petri Latvala Signed-off-by: Matthew Auld Acked-by: Petri Latvala --- tests/i915/gem_exec_basic.c | 50

[Intel-gfx] [PATCH i-g-t v3 7/9] tests/i915/gem_media_fill: Use memory region interface

2021-05-26 Thread Matthew Auld
From: Andrzej Turko Converted the test gem_media_fill to use memory region uapi. Signed-off-by: Andrzej Turko Cc: Zbigniew Kempczynski Cc: Dominik Grzegorzek Cc: Petri Latvala Signed-off-by: Matthew Auld Acked-by: Petri Latvala Reviewed-by: Zbigniew Kempczyński --- tests/i915/gem_media_f

[Intel-gfx] [PATCH i-g-t v3 9/9] tests/i915/gem_exec_basic: Iterate over all memory regions

2021-05-26 Thread Matthew Auld
From: "Kalamarz, Lukasz" As a part of local memory effort we need to make sure, that every available memory region is covered. This patch is an attempt for this problem. If it will be accepted it will be replicated on each test that can actually benefit from it. Signed-off-by: Dominik Grzegorzek

[Intel-gfx] [PATCH i-g-t v3 1/9] i915_drm.h sync

2021-05-26 Thread Matthew Auld
Sync to get gem_create_ext and the regions query stuff. Generated from kernel commit: 2459e56fd8af ("drm/i915/uapi: implement object placement extension") Signed-off-by: Matthew Auld Acked-by: Petri Latvala --- include/drm-uapi/i915_drm.h | 394 1 file chan

[Intel-gfx] [PATCH i-g-t v3 4/9] tests/gem_gpgpu_fill: Convert from simple to standard igt_main

2021-05-26 Thread Matthew Auld
From: Dominik Grzegorzek As we need to add new test variants, convert the code to standard igt_main format so those variants can be easily accommodated. Signed-off-by: Janusz Krzysztofik Signed-off-by: Matthew Auld Reviewed-by: Zbigniew Kempczyński Acked-by: Petri Latvala --- tests/i915/gem

[Intel-gfx] [PATCH i-g-t v3 6/9] tests/i915/gem_gpgpu_fill: Use memory region interface

2021-05-26 Thread Matthew Auld
From: Andrzej Turko Converted the test gem_gpgpu_fill to use memory region uapi. Signed-off-by: Andrzej Turko Cc: Zbigniew Kempczynski Cc: Dominik Grzegorzek Cc: Petri Latvala Signed-off-by: Matthew Auld Acked-by: Petri Latvala Reviewed-by: Zbigniew Kempczyński --- tests/i915/gem_gpgpu_f

[Intel-gfx] [PATCH i-g-t v3 8/9] tests/i915/gem_create: exercise placements extension

2021-05-26 Thread Matthew Auld
Add some explicit testcases for the create_ext placements extension. Signed-off-by: Matthew Auld Cc: Dominik Grzegorzek Cc: Joonas Lahtinen Acked-by: Petri Latvala --- tests/i915/gem_create.c | 188 1 file changed, 188 insertions(+) diff --git a/tests

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Patchwork
== Series Details == Series: drm/i915/xelpd: Enabling dithering after the CC1 URL : https://patchwork.freedesktop.org/series/90594/ State : warning == Summary == $ dim checkpatch origin/drm-tip 41e126e0ef3b drm/i915/xelpd: Enabling dithering after the CC1 -:27: CHECK:UNNECESSARY_PARENTHESES: U

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Patchwork
== Series Details == Series: drm/i915/xelpd: Enabling dithering after the CC1 URL : https://patchwork.freedesktop.org/series/90594/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/dr

Re: [Intel-gfx] [PATCH 5/7] dma-buf: Add an API for exporting sync files (v11)

2021-05-26 Thread Daniel Stone
Hi, On Wed, 26 May 2021 at 13:46, Christian König wrote: > Am 26.05.21 um 13:31 schrieb Daniel Stone: > > How would we insert a syncobj+val into a resv though? Like, if we pass > > an unmaterialised syncobj+val here to insert into the resv, then an > > implicit-only media user (or KMS) goes to sy

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/adl_p: enable MSO on pipe B

2021-05-26 Thread Patchwork
== Series Details == Series: drm/i915/adl_p: enable MSO on pipe B URL : https://patchwork.freedesktop.org/series/90579/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10133_full -> Patchwork_20197_full Summary --- **F

Re: [Intel-gfx] [PATCH] drm/i915/adl_p: enable MSO on pipe B

2021-05-26 Thread Ville Syrjälä
On Wed, May 26, 2021 at 11:29:03AM +0300, Jani Nikula wrote: > On ADL-P, it's possible to enable the stream splitter on pipe B in > addition to pipe A. > > Bspec: 50174 > Cc: Uma Shankar > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula I have a feeling I reviewed this already. But maybe I'm ju

Re: [Intel-gfx] [PATCH 5/7] dma-buf: Add an API for exporting sync files (v11)

2021-05-26 Thread Christian König
Am 26.05.21 um 15:12 schrieb Daniel Stone: Hi, On Wed, 26 May 2021 at 13:46, Christian König wrote: Am 26.05.21 um 13:31 schrieb Daniel Stone: How would we insert a syncobj+val into a resv though? Like, if we pass an unmaterialised syncobj+val here to insert into the resv, then an implicit-

Re: [Intel-gfx] [Mesa-dev] [PATCH 01/11] drm/amdgpu: Comply with implicit fencing rules

2021-05-26 Thread Christian König
Am 25.05.21 um 17:23 schrieb Daniel Vetter: On Tue, May 25, 2021 at 5:05 PM Christian König wrote: Hi Daniel, Am 25.05.21 um 15:05 schrieb Daniel Vetter: Hi Christian, On Sat, May 22, 2021 at 10:30:19AM +0200, Christian König wrote: Am 21.05.21 um 20:31 schrieb Daniel Vetter: This works by

Re: [Intel-gfx] [PATCH] drm/i915: Remove the repeated declaration

2021-05-26 Thread Jani Nikula
On Tue, 25 May 2021, Shaokun Zhang wrote: > Function 'intel_dbuf_init' is declared twice, remove the > repeated declaration. > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Signed-off-by: Shaokun Zhang Thanks, pushed to drm-intel-next. BR, Jani. > --- > drivers/gpu/drm/i915/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Patchwork
== Series Details == Series: drm/i915/xelpd: Enabling dithering after the CC1 URL : https://patchwork.freedesktop.org/series/90594/ State : success == Summary == CI Bug Log - changes from CI_DRM_10133 -> Patchwork_20202 Summary --- *

Re: [Intel-gfx] [PATCH v4 10/15] drm/ttm, drm/amdgpu: Allow the driver some control over swapping

2021-05-26 Thread Christian König
Am 26.05.21 um 13:32 schrieb Thomas Hellström: We are calling the eviction_valuable driver callback at eviction time to determine whether we actually can evict a buffer object. The upcoming i915 TTM backend needs the same functionality for swapout, and that might actually be beneficial to other d

Re: [Intel-gfx] [PATCH] drm/i915/adl_p: enable MSO on pipe B

2021-05-26 Thread Jani Nikula
On Wed, 26 May 2021, Ville Syrjälä wrote: > On Wed, May 26, 2021 at 11:29:03AM +0300, Jani Nikula wrote: >> On ADL-P, it's possible to enable the stream splitter on pipe B in >> addition to pipe A. >> >> Bspec: 50174 >> Cc: Uma Shankar >> Cc: Ville Syrjälä >> Signed-off-by: Jani Nikula > > I h

Re: [Intel-gfx] [Mesa-dev] [PATCH 01/11] drm/amdgpu: Comply with implicit fencing rules

2021-05-26 Thread Daniel Vetter
On Wed, May 26, 2021 at 3:32 PM Christian König wrote: > > Am 25.05.21 um 17:23 schrieb Daniel Vetter: > > On Tue, May 25, 2021 at 5:05 PM Christian König > > wrote: > >> Hi Daniel, > >> > >> Am 25.05.21 um 15:05 schrieb Daniel Vetter: > >>> Hi Christian, > >>> > >>> On Sat, May 22, 2021 at 10:30

Re: [Intel-gfx] [PATCH 1/2] drm/i915/xelpd: Enabling dithering after the CC1

2021-05-26 Thread Jani Nikula
On Wed, 26 May 2021, Bhanuprakash Modem wrote: > From: Nischal Varide > > If the panel is 12bpc then Dithering is not enabled in the Legacy > dithering block , instead its Enabled after the C1 CC1 pipe post > color space conversion.For a 6bpc pannel Dithering is enabled in > Legacy block. > > Sig

Re: [Intel-gfx] [PATCH] drm/i915/params: Align visibility of device level and global modparams

2021-05-26 Thread Ville Syrjälä
On Wed, May 26, 2021 at 11:00:06AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > We have a few modparams which get conditionaly exposed based on a Kconfig > options and in most cases this also means portions of the driver > implementing the respective feature are also left out. > > Ali

[Intel-gfx] [PATCH 01/12] drm/i915: Take rcu_read_lock for querying fence's driver/timeline names

2021-05-26 Thread Tvrtko Ursulin
From: Chris Wilson The name very often may be freed independently of the fence, with the only protection being RCU. To be safe as we read the names, hold RCU. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_sw_fence.c | 2 ++

[Intel-gfx] [PATCH 03/12] drm/i915: Lift marking a lock as used to utils

2021-05-26 Thread Tvrtko Ursulin
From: Chris Wilson After calling lock_set_subclass() the lock _must_ be used, or else lockdep's internal nr_used_locks becomes unbalanced. Extract the little utility function to i915_utils.c Signed-off-by: Chris Wilson Cc: Thomas Hellström Reviewed-by: Thomas Hellström Signed-off-by: Tvrtko U

[Intel-gfx] [PATCH 04/12] drm/i915: Wrap cmpxchg64 with try_cmpxchg64() helper

2021-05-26 Thread Tvrtko Ursulin
From: Chris Wilson Wrap cmpxchg64 with a try_cmpxchg()-esque helper. Hiding the old-value dance in the helper allows for cleaner code. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_utils.h | 32

[Intel-gfx] [PATCH 06/12] drm/i915/selftests: Use a coherent map to setup scratch batch buffers

2021-05-26 Thread Tvrtko Ursulin
From: Chris Wilson Instead of manipulating the object's cache domain, just use the device coherent map to write the batch buffer. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld Signed-off-by: Tvrtko Ursulin --- .../drm/i915/gem/selftests/i915_gem_context.c| 16 +--- 1

[Intel-gfx] [PATCH 10/12] drm/i915/selftests: Replace an unbounded set-domain wait with a timeout

2021-05-26 Thread Tvrtko Ursulin
From: Chris Wilson After the memory-region test completes, it flushes the test by calling set-to-cpu-domain. Use the igt_flush_test as it includes a timeout, recovery and reports and error for miscreant tests. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld Signed-off-by: Tvrtko Ursulin

[Intel-gfx] [PATCH 11/12] drm/i915/selftests: Remove redundant set-to-gtt-domain before batch submission

2021-05-26 Thread Tvrtko Ursulin
From: Chris Wilson In construction the rpcs_query batch we know that it is device coherent and ready for execution, the set-to-gtt-domain here is redudant. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/selftests/i915_gem_cont

[Intel-gfx] [PATCH 09/12] drm/i915/selftests: Replace unbound set-domain waits with explicit timeouts

2021-05-26 Thread Tvrtko Ursulin
From: Chris Wilson Let's prefer to use explicit request tracking and bounded timeouts in our selftests. v2 (Tvrtko): * Rebase. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld # v1 Signed-off-by: Tvrtko Ursulin --- .../gpu/drm/i915/gt/selftest_workarounds.c| 107 +++---

[Intel-gfx] [PATCH 07/12] drm/i915/selftests: Replace the unbounded set-domain with an explicit wait

2021-05-26 Thread Tvrtko Ursulin
From: Chris Wilson After running client_blt, we flush the object by changing its domain. This causes us to wait forever instead of an bounded wait suitable for the selftest timeout. So do an explicit wait with a suitable timeout -- which in turn means we have to limit the size of the object/blit

[Intel-gfx] [PATCH 02/12] drm/i915: Remove notion of GEM from i915_gem_shrinker_taints_mutex

2021-05-26 Thread Tvrtko Ursulin
From: Chris Wilson Since we dropped the use of dev->struct_mutex from inside the shrinker, we no longer include that as part of our fs_reclaim tainting. We can drop the i915 argument and rebrand it as a generic fs_reclaim tainter. v2 (Tvrtko): * Rebase. Signed-off-by: Chris Wilson Cc: Thomas

[Intel-gfx] [PATCH 12/12] drm/i915/gem: Manage all set-domain waits explicitly

2021-05-26 Thread Tvrtko Ursulin
From: Chris Wilson Only perform the domain transition under the object lock, and push the required waits to outside the lock. v2 (Tvrtko): * Rebase. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld # v1 Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_clflush.c |

[Intel-gfx] [PATCH 00/12] Catchup with a few dropped patches

2021-05-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A small chunk of dropped and mostly already reviewed patches (a couple need review updated due rebasing I had to do) with the goal of getting to actual fixes in the next round. Chris Wilson (12): drm/i915: Take rcu_read_lock for querying fence's driver/timeline names

[Intel-gfx] [PATCH 08/12] drm/i915/selftests: Remove redundant set-to-gtt-domain

2021-05-26 Thread Tvrtko Ursulin
From: Chris Wilson Since the vma's backing store is flushed upon first creation, remove the manual calls to set-to-gtt-domain. v2 (Tvrtko): * Rebase. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld # v1 Signed-off-by: Tvrtko Ursulin --- .../gpu/drm/i915/gem/selftests/i915_gem_mman.c

[Intel-gfx] [PATCH 05/12] drm/i915/selftests: Set cache status for huge_gem_object

2021-05-26 Thread Tvrtko Ursulin
From: Chris Wilson Set the cache coherency and status using the set-coherency helper. Otherwise, we forget to mark the new pages as cache dirty. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 14 +-

[Intel-gfx] [PATCH v2] drm/i915/params: Align visibility of device level and global modparams

2021-05-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We have a few modparams which get conditionaly exposed based on a Kconfig options and in most cases this also means portions of the driver implementing the respective feature are also left out. Align the visibility of device level and global modparams to make them consistent

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display/debug: Expose Dither status via debugfs

2021-05-26 Thread Jani Nikula
On Wed, 26 May 2021, Bhanuprakash Modem wrote: > It's useful to know the dithering state & pipe bpc for IGT testing. > This patch will expose the dithering state for the crtc via a debugfs > file "dither". > > Example usage: cat /sys/kernel/debug/dri/0/crtc-0/dither > > Cc: Uma Shankar > Cc: Nisc

Re: [Intel-gfx] [PATCH v4 07/15] drm, drm/i915: Move the memcpy_from_wc functionality to core drm

2021-05-26 Thread Christian König
Am 26.05.21 um 13:32 schrieb Thomas Hellström: Memcpy from wc will be used as well by TTM memcpy. Move it to core drm, and make the interface do the right thing even on !X86. Cc: Christian König Cc: Daniel Vetter Cc: Dave Airlie Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld Ac

Re: [Intel-gfx] [PATCH 12/12] drm/i915/gem: Manage all set-domain waits explicitly

2021-05-26 Thread Matthew Auld
On 26/05/2021 15:14, Tvrtko Ursulin wrote: From: Chris Wilson Only perform the domain transition under the object lock, and push the required waits to outside the lock. v2 (Tvrtko): * Rebase. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld # v1 Signed-off-by: Tvrtko Ursulin --- d

Re: [Intel-gfx] [PATCH v4 09/15] drm/ttm: Document and optimize ttm_bo_pipeline_gutting()

2021-05-26 Thread Christian König
Am 26.05.21 um 13:32 schrieb Thomas Hellström: If the bo is idle when calling ttm_bo_pipeline_gutting(), we unnecessarily create a ghost object and push it out to delayed destroy. Fix this by adding a path for idle, and document the function. Also avoid having the bo end up in a bad state vulner

[Intel-gfx] [PATCH v2 12/12] drm/i915/gem: Manage all set-domain waits explicitly

2021-05-26 Thread Tvrtko Ursulin
From: Chris Wilson Only perform the domain transition under the object lock, and push the required waits to outside the lock. v2 (Tvrtko): * Rebase. v3 (Tvrtko): * Restore write to gtt domain in coherency selftest. (Matt) Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld # v1 Signed-of

  1   2   3   >