[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dp: Use slow and wide link training for everything

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915/dp: Use slow and wide link training for everything URL : https://patchwork.freedesktop.org/series/89283/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9989_full -> Patchwork_19958_full

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Rename pm_ prefixed functions names

2021-04-21 Thread Jani Nikula
On Tue, 20 Apr 2021, Rodrigo Vivi wrote: > On Tue, Apr 20, 2021 at 05:41:47PM +0300, Jani Nikula wrote: >> On Tue, 20 Apr 2021, Rodrigo Vivi wrote: >> > On Tue, Apr 20, 2021 at 04:08:53PM +0300, Jani Nikula wrote: >> >> From: Hsin-Yi Wang >> >> >> >> pm_resume and pm_suspend might be conflict w

Re: [Intel-gfx] [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-21 Thread Tvrtko Ursulin
On 20/04/2021 18:00, Jason Ekstrand wrote: On Tue, Apr 20, 2021 at 11:34 AM Tvrtko Ursulin wrote: On 19/04/2021 16:19, Jason Ekstrand wrote: On Mon, Apr 19, 2021 at 7:02 AM Matthew Auld wrote: On 16/04/2021 17:38, Jason Ekstrand wrote: On Thu, Apr 15, 2021 at 11:04 AM Matthew Auld wro

Re: [Intel-gfx] [PATCH] drm/i915: set min brightness for aux backlight interface.

2021-04-21 Thread Jani Nikula
On Mon, 19 Apr 2021, Lee Shawn C wrote: > Min brightness level for aux backlight interface is always zero. > Driver should refer to VBT's setting to configure proper minimum > level just like PWM backlight interface. Unfortunately this change makes it harder for Lyude to extract the dpcd backligh

[Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path.

2021-04-21 Thread Rodrigo Vivi
Although this abstraction removes the convenience of grepping for the file name, it: - makes addition easier. - makes it easier to tweak global path when experiments are needed. - get in sync with guc/huc, without getting overly abstracted. - allows future junction with CSR_VERSION for simplicity.

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Create stolen memory region from local memory

2021-04-21 Thread Matthew Auld
On 20/04/2021 17:06, Tvrtko Ursulin wrote: On 20/04/2021 14:18, Matthew Auld wrote: From: CQ Tang Add "REGION_STOLEN" device info to dg1, create stolen memory region from upper portion of local device memory, starting from DSMBASE. v2: - s/drm_info/drm_dbg; userspace likely doesn't care

Re: [Intel-gfx] [PATCH 4/5] drm/i915/stolen: pass the allocation flags

2021-04-21 Thread Matthew Auld
On 20/04/2021 17:14, Tvrtko Ursulin wrote: On 20/04/2021 14:18, Matthew Auld wrote: From: CQ Tang Stolen memory is always allocated as physically contiguous pages, mark the object flags as such. v2: move setting I915_BO_ALLOC_CONTIGUOUS into create_stolen Signed-off-by: CQ Tang Signed-off-

[Intel-gfx] [PULL] gvt-next-fixes

2021-04-21 Thread Zhenyu Wang
Hi, Here're queued gvt-next-fixes changes. Two ones are for code cleanup on unused function or duplicated function call, with another one for consistent function return type. Thanks. -- The following changes since commit d153e8c156dafeb847fd655f416cf81c007e8706: Merge tag 'drm-intel-next-fixe

[Intel-gfx] [PATCH v2 1/4] drm/i915: Create stolen memory region from local memory

2021-04-21 Thread Matthew Auld
From: CQ Tang Add "REGION_STOLEN" device info to dg1, create stolen memory region from upper portion of local device memory, starting from DSMBASE. v2: - s/drm_info/drm_dbg; userspace likely doesn't care about stolen. - mem->type is only setup after the region probe, so setting the name

[Intel-gfx] [PATCH v2 2/4] drm/i915/stolen: treat stolen local as normal local memory

2021-04-21 Thread Matthew Auld
Underneath it's the same stuff, so things like the PTE_LM bits for the GTT should just keep working as-is. Signed-off-by: Matthew Auld Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v2 4/4] drm/i915/stolen: actually mark as contiguous

2021-04-21 Thread Matthew Auld
Stolen memory is always allocated as physically contiguous pages, so mark the object flags as such. It looks like the flags were previously just ignored so this had no effect. In the future we might to add the proper plumbing for passing the flags all over the way down from the caller, but for now

[Intel-gfx] [PATCH v2 3/4] drm/i915/stolen: enforce the min_page_size contract

2021-04-21 Thread Matthew Auld
From: CQ Tang Since stolen can now be device local-memory underneath, we should try to enforce any min_page_size restrictions when allocating pages. Signed-off-by: CQ Tang Signed-off-by: Matthew Auld Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 7 --- 1 fi

Re: [Intel-gfx] [PULL] gvt-next-fixes

2021-04-21 Thread Jani Nikula
On Wed, 21 Apr 2021, Zhenyu Wang wrote: > Hi, > > Here're queued gvt-next-fixes changes. Two ones are for code cleanup > on unused function or duplicated function call, with another one for > consistent function return type. Thanks, pulled to drm-intel-next-fixes. BR, Jani. > > Thanks. > -- >

Re: [Intel-gfx] [PATCH v2 00/50] Introduce Alder Lake-P

2021-04-21 Thread Jani Nikula
On Thu, 25 Mar 2021, Matt Roper wrote: > The previous version of this series was here: > > https://lists.freedesktop.org/archives/intel-gfx/2021-March/262168.html > > The preparation patches that convert display/ to use DISPLAY_VER() > instead of INTEL_GEN() have landed on drm-tip now, so

Re: [Intel-gfx] [PATCH 00/11] drm/i915/adl_p: Add support for Display Page Tables

2021-04-21 Thread Jani Nikula
On Thu, 15 Apr 2021, Jani Nikula wrote: > On Wed, 14 Apr 2021, Imre Deak wrote: >> Alder Lake-P adds a new Display Page Table hardware structure, mapping >> tiled framebuffer pages to the display engine, reducing the address >> space required in GGTT for these framebuffers. >> >> This patchset ad

Re: [Intel-gfx] [PATCH 00/11] drm/i915/adl_p: Add support for Display Page Tables

2021-04-21 Thread Imre Deak
On Wed, Apr 21, 2021 at 02:03:45PM +0300, Jani Nikula wrote: > On Thu, 15 Apr 2021, Jani Nikula wrote: > > On Wed, 14 Apr 2021, Imre Deak wrote: > >> Alder Lake-P adds a new Display Page Table hardware structure, mapping > >> tiled framebuffer pages to the display engine, reducing the address > >

Re: [Intel-gfx] [PATCH 11/19] drm/i915: Update the helper to set correct mapping

2021-04-21 Thread Matthew Auld
On 19/04/2021 16:01, Tvrtko Ursulin wrote: On 19/04/2021 15:37, Matthew Auld wrote: On 19/04/2021 15:07, Tvrtko Ursulin wrote: On 19/04/2021 12:30, Matthew Auld wrote: On 15/04/2021 12:05, Tvrtko Ursulin wrote: On 15/04/2021 10:23, Matthew Auld wrote: On Thu, 15 Apr 2021 at 09:21, Tvrtko

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove asynchronous vma binding

2021-04-21 Thread Daniel Vetter
On Tue, Apr 20, 2021 at 12:34:50PM +0200, Maarten Lankhorst wrote: > Commit e3793468b466 ("drm/i915: Use the async worker to avoid reclaim > tainting the ggtt->mutex") moves the vma binding to dma_fence_work, > but dma_fence_work has has signalling fence semantics. > > On braswell, we can call sto

[Intel-gfx] [PATCH] drm/i915: Fix docbook descriptions for i915_cmd_parser

2021-04-21 Thread Maarten Lankhorst
Fixes the following htmldocs warnings: drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_

[Intel-gfx] [PATCH] drm/i915: Fix docbook descriptions for i915_gem_shrinker

2021-04-21 Thread Maarten Lankhorst
Fixes the following htmldocs warning: drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink' Fixes: cf41a8f1dc1e ("drm/i915: Finally remove obj->mm.lock.") Reported-by: Stephen Rothwell Signed-off-by: Maarten Lankhorst ---

Re: [Intel-gfx] [PATCH 00/11] drm/i915/adl_p: Add support for Display Page Tables

2021-04-21 Thread Jani Nikula
On Wed, 21 Apr 2021, Imre Deak wrote: > On Wed, Apr 21, 2021 at 02:03:45PM +0300, Jani Nikula wrote: >> On Thu, 15 Apr 2021, Jani Nikula wrote: >> > On Wed, 14 Apr 2021, Imre Deak wrote: >> >> Alder Lake-P adds a new Display Page Table hardware structure, mapping >> >> tiled framebuffer pages to

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path.

2021-04-21 Thread Jani Nikula
On Wed, 21 Apr 2021, Rodrigo Vivi wrote: > Although this abstraction removes the convenience of grepping > for the file name, it: > - makes addition easier. > - makes it easier to tweak global path when experiments are needed. > - get in sync with guc/huc, without getting overly abstracted. > - al

[Intel-gfx] [PATCH] drm/i915: Simplify CCS and UV plane alignment handling

2021-04-21 Thread Imre Deak
We can handle the surface alignment of CCS and UV color planes for all modifiers at one place, so do this. An AUX color plane can be a CCS or a UV plane, use only the more specific query functions and remove is_aux_plane() becoming redundant. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/dis

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Extract intel_fbc_update()

2021-04-21 Thread Jani Nikula
On Wed, 14 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Pull the fbc enable vs. disable stuff into a small helper so > we don't have to have it pollute the higher level modeset code. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/i

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Rewrite the FBC tiling check a bit

2021-04-21 Thread Jani Nikula
On Thu, 15 Apr 2021, Ville Syrjälä wrote: > On Wed, Apr 14, 2021 at 06:09:23PM +0300, Jani Nikula wrote: >> On Wed, 14 Apr 2021, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > Write the tiling check in a nicer form. >> > >> > Signed-off-by: Ville Syrjälä >> > --- >> > drivers/gpu/drm/

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Add frontbuffer tracking tracepoints

2021-04-21 Thread Jani Nikula
On Wed, 14 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Add some tracpoints for frontbuffer tracking so we can > try to figure out what's going on. > > Signed-off-by: Ville Syrjälä Acked-by: Jani Nikula > --- > .../gpu/drm/i915/display/intel_frontbuffer.c | 5 +++ > drivers/gpu

Re: [Intel-gfx] [PATCH 5/8] drm/i915: Move the "recompress on activate" to a central place

2021-04-21 Thread Jani Nikula
On Wed, 14 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > On ILK+ we current do a nuke right after activating FBC. If my > memory isn't playing tricks on me this is actially required if > FBC didn't stay disabled for a full frame. In that case the > deactivate+reactivate may not invalid

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dmc: Let's abstract the dmc path. (rev2)

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Let's abstract the dmc path. (rev2) URL : https://patchwork.freedesktop.org/series/89275/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or me

Re: [Intel-gfx] [RFC PATCH] drm/i915: Simplify userptr locking

2021-04-21 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 7:51 PM Thomas Hellström wrote: > > Use an rwlock instead of spinlock for the global notifier lock > to reduce risk of contention in execbuf. > > Protect object state with the object lock whenever possible rather > than with the global notifier lock > > Don't take an explic

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Clear no_fbc_reason on activate

2021-04-21 Thread Jani Nikula
On Wed, 14 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > We try to set no_fbc_reason when FBC is not possible, let's > consistently clear when activating FBC. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_fbc.c | 13 ++

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Let's abstract the dmc path. (rev2)

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Let's abstract the dmc path. (rev2) URL : https://patchwork.freedesktop.org/series/89275/ State : success == Summary == CI Bug Log - changes from CI_DRM_9992 -> Patchwork_19959 Summary --- *

Re: [Intel-gfx] [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-21 Thread Jason Ekstrand
On Wed, Apr 21, 2021 at 3:22 AM Tvrtko Ursulin wrote: > > On 20/04/2021 18:00, Jason Ekstrand wrote: > > On Tue, Apr 20, 2021 at 11:34 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 19/04/2021 16:19, Jason Ekstrand wrote: > >>> On Mon, Apr 19, 2021 at 7:02 AM Matthew Auld > >>> wrote: > >

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Pimp the FBC debugfs output

2021-04-21 Thread Jani Nikula
On Wed, 14 Apr 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Now that each pipe tracks its own no_fbc_reason we can print that > out in debugfs, and we can also show which pipe is currently > selected for FBC duty. > > Signed-off-by: Ville Syrjälä > --- > .../drm/i915/display/intel_displ

Re: [Intel-gfx] [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-21 Thread Tvrtko Ursulin
On 21/04/2021 14:54, Jason Ekstrand wrote: On Wed, Apr 21, 2021 at 3:22 AM Tvrtko Ursulin wrote: On 20/04/2021 18:00, Jason Ekstrand wrote: On Tue, Apr 20, 2021 at 11:34 AM Tvrtko Ursulin wrote: On 19/04/2021 16:19, Jason Ekstrand wrote: On Mon, Apr 19, 2021 at 7:02 AM Matthew Auld wr

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/stolen: actually mark as contiguous

2021-04-21 Thread Tvrtko Ursulin
On 21/04/2021 11:46, Matthew Auld wrote: Stolen memory is always allocated as physically contiguous pages, so mark the object flags as such. It looks like the flags were previously just ignored so this had no effect. In the future we might to add the proper plumbing for passing the flags all ov

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/4] drm/i915: Create stolen memory region from local memory

2021-04-21 Thread Patchwork
== Series Details == Series: series starting with [v2,1/4] drm/i915: Create stolen memory region from local memory URL : https://patchwork.freedesktop.org/series/89293/ State : warning == Summary == $ dim checkpatch origin/drm-tip bb6cb02052af drm/i915: Create stolen memory region from local

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/4] drm/i915: Create stolen memory region from local memory

2021-04-21 Thread Patchwork
== Series Details == Series: series starting with [v2,1/4] drm/i915: Create stolen memory region from local memory URL : https://patchwork.freedesktop.org/series/89293/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be

Re: [Intel-gfx] [PATCH] drm/i915: Fix docbook descriptions for i915_cmd_parser

2021-04-21 Thread Daniel Vetter
On Wed, Apr 21, 2021 at 2:03 PM Maarten Lankhorst wrote: > > Fixes the following htmldocs warnings: > drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function > parameter 'trampoline' description in 'intel_engine_cmd_parser' > drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Fun

Re: [Intel-gfx] [PATCH] drm/i915: Fix docbook descriptions for i915_gem_shrinker

2021-04-21 Thread Daniel Vetter
On Wed, Apr 21, 2021 at 2:09 PM Maarten Lankhorst wrote: > > Fixes the following htmldocs warning: > drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter > or member 'ww' not described in 'i915_gem_shrink' > > Fixes: cf41a8f1dc1e ("drm/i915: Finally remove obj->mm.lock.")

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [v2,1/4] drm/i915: Create stolen memory region from local memory

2021-04-21 Thread Patchwork
== Series Details == Series: series starting with [v2,1/4] drm/i915: Create stolen memory region from local memory URL : https://patchwork.freedesktop.org/series/89293/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:10

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: Create stolen memory region from local memory

2021-04-21 Thread Tvrtko Ursulin
On 21/04/2021 11:46, Matthew Auld wrote: From: CQ Tang Add "REGION_STOLEN" device info to dg1, create stolen memory region from upper portion of local device memory, starting from DSMBASE. v2: - s/drm_info/drm_dbg; userspace likely doesn't care about stolen. - mem->type is only set

Re: [Intel-gfx] [PATCH] drm/i915: Fix docbook descriptions for i915_cmd_parser

2021-04-21 Thread Maarten Lankhorst
Op 21-04-2021 om 16:32 schreef Daniel Vetter: > On Wed, Apr 21, 2021 at 2:03 PM Maarten Lankhorst > wrote: >> Fixes the following htmldocs warnings: >> drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function >> parameter 'trampoline' description in 'intel_engine_cmd_parser' >> drive

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/4] drm/i915: Create stolen memory region from local memory

2021-04-21 Thread Patchwork
== Series Details == Series: series starting with [v2,1/4] drm/i915: Create stolen memory region from local memory URL : https://patchwork.freedesktop.org/series/89293/ State : success == Summary == CI Bug Log - changes from CI_DRM_9993 -> Patchwork_19960 =

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path.

2021-04-21 Thread Lucas De Marchi
On Wed, Apr 21, 2021 at 05:44:06AM -0400, Rodrigo Vivi wrote: Although this abstraction removes the convenience of grepping for the file name, it: - makes addition easier. - makes it easier to tweak global path when experiments are needed. - get in sync with guc/huc, without getting overly abstra

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path.

2021-04-21 Thread Lucas De Marchi
On Wed, Apr 21, 2021 at 03:18:17PM +0300, Jani Nikula wrote: On Wed, 21 Apr 2021, Rodrigo Vivi wrote: Although this abstraction removes the convenience of grepping for the file name, it: - makes addition easier. - makes it easier to tweak global path when experiments are needed. - get in sync w

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix docbook descriptions for i915_cmd_parser

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix docbook descriptions for i915_cmd_parser URL : https://patchwork.freedesktop.org/series/89295/ State : warning == Summary == $ dim checkpatch origin/drm-tip 13583b18a02b drm/i915: Fix docbook descriptions for i915_cmd_parser -:25: WARNING:LONG_LINE_CO

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/dg1: Add HWMON power sensor support

2021-04-21 Thread Jani Nikula
On Tue, 13 Apr 2021, Dale B Stimson wrote: > As part of the System Managemenent Interface (SMI), use the HWMON > subsystem to display power utilization. > > The following standard HWMON power sensors are currently supported > (and appropriately scaled): > /sys/class/drm/card0/device/hwmon/hwmon

Re: [Intel-gfx] [PATCH v3 01/20] drm/amdgpu: Add error handling to amdgpu_dm_initialize_dp_connector()

2021-04-21 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] I'm fine with having these changes go through drm-misc. Alex From: Lipski, Mikita Sent: Wednesday, April 21, 2021 10:23 AM To: Lyude Paul ; dri-de...@lists.freedesktop.org ; intel-gfx@lists.freedesktop.org ;

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix docbook descriptions for i915_cmd_parser

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix docbook descriptions for i915_cmd_parser URL : https://patchwork.freedesktop.org/series/89295/ State : success == Summary == CI Bug Log - changes from CI_DRM_9993 -> Patchwork_19961 Summary ---

[Intel-gfx] [PATCH 0/4] drm/i915: Fix older platforms

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä Fix a div-by-zero on gen2, and make the L-shaped memory detection actually work on cl/ctg. Atm the SWIZZLE_UNKNOWN stuff just trips some GEM_BUG_ONs. This doesn't fix those but since I populate all my memory channels symmetrically I get to avoid the GEM_BUG_ONs by correctly de

[Intel-gfx] [PATCH 1/4] drm/i915: Avoid div-by-zero on gen2

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä Gen2 tiles are 2KiB in size so i915_gem_object_get_tile_row_size() can in fact return <4KiB, which leads to div-by-zero here. Avoid that. Not sure i915_gem_object_get_tile_row_size() is entirely sane anyway since it doesn't account for the different tile layouts on i8xx/i915.

[Intel-gfx] [PATCH 2/4] drm/i915: Read C0DRB3/C1DRB3 as 16 bits again

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä We've defined C0DRB3/C0DRB3 as 16 bit registers, so access them as such. Fixes: 1c8242c3a4b2 ("drm/i915: Use unchecked writes for setting up the fences") Reviewed-by: Chris Wilson Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- 1 fil

[Intel-gfx] [PATCH 3/4] drm/i915: Give C0DRB3/C1DRB3 a _BW suffix

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä These are the 965g/g45/g33 specific DRB registers. Give them a suitable suffix so we can add their counterparts for other platforms. Reviewed-by: Chris Wilson Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 4 ++-- drivers/gpu/drm/i915/i915_

[Intel-gfx] [PATCH 4/4] drm/i915: Rewrite CL/CTG L-shaped memory detection

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä Currently we try to detect a symmetric memory configurations using a magic DCC2_MODIFIED_ENHANCED_DISABLE bit. That bit is either only set on a very specific subset of machines or it just does not exist (it's not mentioned in any public chipset datasheets I've found). As it ha

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix docbook descriptions for i915_gem_shrinker

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix docbook descriptions for i915_gem_shrinker URL : https://patchwork.freedesktop.org/series/89297/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parame

Re: [Intel-gfx] [PATCH 11/19] drm/i915: Update the helper to set correct mapping

2021-04-21 Thread Tvrtko Ursulin
On 21/04/2021 12:42, Matthew Auld wrote: On 19/04/2021 16:01, Tvrtko Ursulin wrote: On 19/04/2021 15:37, Matthew Auld wrote: On 19/04/2021 15:07, Tvrtko Ursulin wrote: On 19/04/2021 12:30, Matthew Auld wrote: On 15/04/2021 12:05, Tvrtko Ursulin wrote: On 15/04/2021 10:23, Matthew Auld wr

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix docbook descriptions for i915_gem_shrinker

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix docbook descriptions for i915_gem_shrinker URL : https://patchwork.freedesktop.org/series/89297/ State : success == Summary == CI Bug Log - changes from CI_DRM_9993 -> Patchwork_19962 Summary -

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Simplify CCS and UV plane alignment handling

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Simplify CCS and UV plane alignment handling URL : https://patchwork.freedesktop.org/series/89299/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Simplify CCS and UV plane alignment handling

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Simplify CCS and UV plane alignment handling URL : https://patchwork.freedesktop.org/series/89299/ State : success == Summary == CI Bug Log - changes from CI_DRM_9993 -> Patchwork_19963 Summary ---

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix older platforms

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix older platforms URL : https://patchwork.freedesktop.org/series/89306/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not descri

[Intel-gfx] [PATCH 00/17] drm/i915: DDI buf trans cleaup and fixes

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä The DDI buf trans functions keep turning into bad spaghetti every time a new platform gets added. Split the platforms up properly and turn the whole thing into a vfunc to make it easier to manage multiple platforms. Ville Syrjälä (17): drm/i915: s/intel/hsw/ for hsw/bde/sk

[Intel-gfx] [PATCH 03/17] drm/i915: Wrap the platform specific buf trans structs into a union

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä In order to abstact the buf trans stuff let's wrap the platform specific structs into a union. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 76 +- .../drm/i915/display/intel_ddi_buf_trans.c| 1318 - .../drm/i915/disp

[Intel-gfx] [PATCH 01/17] drm/i915: s/intel/hsw/ for hsw/bde/skl buf trans

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä Give the hsw/bdw/skl buf trans stuff a better namespace. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 39 + drivers/gpu/drm/i915/display/intel_ddi.h | 4 +- .../drm/i915/display/intel_ddi_buf_trans.c| 79 +---

[Intel-gfx] [PATCH 05/17] drm/i915: Wrap the buf trans tables into a struct

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä Put a wrapper struct around the buf trans tables so that we can declare the number of entries and default HDMI entry alongside the table. @wrap@ identifier old =~ "^.*translations.*"; fresh identifier new = "_" ## old; type T; @@ <... static const T - old + new [] = {

[Intel-gfx] [PATCH 06/17] drm/i915: Introduce intel_get_buf_trans()

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä Add a small helper to get the buf trans entris+num_entries from the struct. Should avoid copy-paste errors in the platform specific get_buf_trans() functions. @@ identifier T, N; @@ - *N = T.num_entries; - return T.entries; + return intel_get_buf_trans(&T, N); @@ @@ is_hobl_

[Intel-gfx] [PATCH 02/17] drm/i915: Introduce hsw_get_buf_trans()

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä All the other platforms handle the output_type stuff in their *_get_buf_trans() functions. Do the same for hsw/bdw/skl. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 27 .../drm/i915/display/intel_ddi_buf_trans.c| 43 +

[Intel-gfx] [PATCH 04/17] drm/i915: Rename dkl phy buf trans tables

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä Rename the dkl phy buf trans tables to follow the same naming pattern used by everyone else. Signed-off-by: Ville Syrjälä --- .../gpu/drm/i915/display/intel_ddi_buf_trans.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/dr

[Intel-gfx] [PATCH 07/17] drm/i915; Return the whole buf_trans struct from get_buf_trans()

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä Raise the abstraction level of the get_buf_trans() functions a bit more by returning the whole wrapper intel_ddi_buf_trans struct. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 76 +++ .../drm/i915/display/intel_ddi_buf_trans.c

[Intel-gfx] [PATCH 08/17] drm/i915: Store the HDMI default entry in the bug trans struct

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä Store the default HDMI buf trans entry in struct intel_ddi_buf_trans so that it's next to the actual table. This let's us start ridding ourselves of some platofrm specifics in intel_ddi_hdmi_num_entries(). Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_ddi_buf_

[Intel-gfx] [PATCH 09/17] drm/i915: Introduce encoder->get_buf_trans()

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä Convert the get_buf_trans() functions into an encoder vfunc. Allows us to get rid of bunch of platform if-ladders. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_crt.c | 3 + drivers/gpu/drm/i915/display/intel_ddi.c | 56 +++ .../

[Intel-gfx] [PATCH 10/17] drm/i915: Clean up hsw/bdw/skl/kbl buf trans funcs

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä Split the hsw/bdw/skl/kbl get_buf_trans() functions into clean platform specific variants. Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_ddi_buf_trans.c| 308 +++--- 1 file changed, 118 insertions(+), 190 deletions(-) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH 11/17] drm/i915: Introduce rkl_get_combo_buf_trans()

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä Give RKL its own get_buf_trans() func. Note that the spec currently only lists values for DP. Until we get that clarified let's just assume that for HDMI and eDP we should do what TGL does (except we fall back to the RKL DP values instead of TGL DP values when not using the e

[Intel-gfx] [PATCH 12/17] drm/i915: Fix dg1 buf trans tables

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä For some reason the dg1 buf trans tables have been stuffed into icl_get_combo_buf_trans_edp() which doesn't even get called on dg1. Split them out into a proper dg1 specific function, and also make sure we use the proper buf trans tables for DP as well as eDP. Signed-off-by:

[Intel-gfx] [PATCH 13/17] drm/i915: Deduplicate icl DP HBR2 vs. eDP HBR3 table

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä The icl combo phy DP HBR2 is identical to the eDP HBR3 table. Get rid of one redundant copy. Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_ddi_buf_trans.c| 39 +-- 1 file changed, 10 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH 14/17] drm/i915: Fix ehl edp hbr2 vswing table

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä EHL is supposed to use special buf trans values for eDP HBR2+. Add such a table. Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_ddi_buf_trans.c| 28 +-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/disp

[Intel-gfx] [PATCH 15/17] drm/i915: Clean up jsl/ehl buf trans functions

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä The jsl/ehl buf trans functions are needlessly conplicated. Simplify them. Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_ddi_buf_trans.c| 87 +-- 1 file changed, 20 insertions(+), 67 deletions(-) diff --git a/drivers/gpu/drm/i915/display/i

[Intel-gfx] [PATCH 16/17] drm/i915: Nuke buf_trans hdmi functions

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä All the foo_get_buf_trans_hdmi() functions just reuturn a single table. Remove the pointless wrappers. Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_ddi_buf_trans.c| 49 +++ 1 file changed, 6 insertions(+), 43 deletions(-) diff --git a/dri

[Intel-gfx] [PATCH 17/17] drm/i915: Add the missing adls vswing tables

2021-04-21 Thread Ville Syrjala
From: Ville Syrjälä adls is supposed to use special buf trans tables. Add what's missing. Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_ddi_buf_trans.c| 122 +- 1 file changed, 121 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_d

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix older platforms

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix older platforms URL : https://patchwork.freedesktop.org/series/89306/ State : success == Summary == CI Bug Log - changes from CI_DRM_9993 -> Patchwork_19964 Summary --- **SUCCESS** No reg

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: DDI buf trans cleaup and fixes

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915: DDI buf trans cleaup and fixes URL : https://patchwork.freedesktop.org/series/89311/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1a9fc1bd6978 drm/i915: s/intel/hsw/ for hsw/bde/skl buf trans 23e893369885 drm/i915: Introduce hsw_get_buf_t

Re: [Intel-gfx] [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-21 Thread Jason Ekstrand
On Wed, Apr 21, 2021 at 9:25 AM Tvrtko Ursulin wrote: > > > On 21/04/2021 14:54, Jason Ekstrand wrote: > > On Wed, Apr 21, 2021 at 3:22 AM Tvrtko Ursulin > > wrote: > >> > >> On 20/04/2021 18:00, Jason Ekstrand wrote: > >>> On Tue, Apr 20, 2021 at 11:34 AM Tvrtko Ursulin > >>> wrote: > > >>

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: DDI buf trans cleaup and fixes

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915: DDI buf trans cleaup and fixes URL : https://patchwork.freedesktop.org/series/89311/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/g

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: DDI buf trans cleaup and fixes

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915: DDI buf trans cleaup and fixes URL : https://patchwork.freedesktop.org/series/89311/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww'

[Intel-gfx] [PATCH 0/1] Add support for querying engine cycles

2021-04-21 Thread Umesh Nerlige Ramappa
This is just a refresh of the earlier patch along with cover letter for the IGT testing. The query provides the engine cs cycles counter. Signed-off-by: Umesh Nerlige Ramappa Test-with: 20210421172046.65062-1-umesh.nerlige.rama...@intel.com Umesh Nerlige Ramappa (1): i915/query: Correlate engi

[Intel-gfx] [PATCH 1/1] i915/query: Correlate engine and cpu timestamps with better accuracy

2021-04-21 Thread Umesh Nerlige Ramappa
Perf measurements rely on CPU and engine timestamps to correlate events of interest across these time domains. Current mechanisms get these timestamps separately and the calculated delta between these timestamps lack enough accuracy. To improve the accuracy of these time measurements to within a f

[Intel-gfx] [PATCH v2] drm/i915: Simplify CCS and UV plane alignment handling

2021-04-21 Thread Imre Deak
We can handle the surface alignment of CCS and UV color planes for all modifiers at one place, so do this. An AUX color plane can be a CCS or a UV plane, use only the more specific query functions and remove is_aux_plane() becoming redundant. While at it add a TODO for linear UV color plane alignm

Re: [Intel-gfx] [PATCH 000/190] Revertion of all of the umn.edu commits

2021-04-21 Thread Daniel Vetter
On Wed, Apr 21, 2021 at 3:01 PM Greg Kroah-Hartman wrote: > > I have been meaning to do this for a while, but recent events have > finally forced me to do so. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to revie

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: DDI buf trans cleaup and fixes

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915: DDI buf trans cleaup and fixes URL : https://patchwork.freedesktop.org/series/89311/ State : success == Summary == CI Bug Log - changes from CI_DRM_9993 -> Patchwork_19965 Summary --- **SUCCESS*

[Intel-gfx] How to adjust gamma & brightness for individual colors using intel_gpu_write?

2021-04-21 Thread Timbo Hidayat Siregar
Dear all, I'm looking to adjust gamma & brightness for individual colors in Linux. Windows had Intel HD graphic Control Panel which allow to adjust gamma & brightness for individual colors directly using the driver. Since there is no Intel Graphic Control Panel on Linux, after some searches on

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dmc: Let's abstract the dmc path. (rev2)

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Let's abstract the dmc path. (rev2) URL : https://patchwork.freedesktop.org/series/89275/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9992_full -> Patchwork_19959_full Summary --

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Add support for querying engine cycles

2021-04-21 Thread Patchwork
== Series Details == Series: Add support for querying engine cycles URL : https://patchwork.freedesktop.org/series/89314/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./include/uapi/drm/i915_drm.h:2234: warning: Incorrect use of kernel-doc format: * Quer

Re: [Intel-gfx] [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-21 Thread Tvrtko Ursulin
On 21/04/2021 18:17, Jason Ekstrand wrote: On Wed, Apr 21, 2021 at 9:25 AM Tvrtko Ursulin wrote: On 21/04/2021 14:54, Jason Ekstrand wrote: On Wed, Apr 21, 2021 at 3:22 AM Tvrtko Ursulin wrote: On 20/04/2021 18:00, Jason Ekstrand wrote: On Tue, Apr 20, 2021 at 11:34 AM Tvrtko Ursulin

Re: [Intel-gfx] [PATCH] drm/i915/dp: Use slow and wide link training for everything

2021-04-21 Thread Ville Syrjälä
On Wed, Apr 21, 2021 at 01:20:31PM +0800, Kai-Heng Feng wrote: > Screen flickers on Innolux eDP 1.3 panel when clock rate 54 is in use. > > According to the panel vendor, though clock rate 54 is advertised, > but the max clock rate it really supports is 27. > > Ville Syrjälä mentioned

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for querying engine cycles

2021-04-21 Thread Patchwork
== Series Details == Series: Add support for querying engine cycles URL : https://patchwork.freedesktop.org/series/89314/ State : success == Summary == CI Bug Log - changes from CI_DRM_9993 -> Patchwork_19966 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 11/19] drm/i915: Update the helper to set correct mapping

2021-04-21 Thread Matthew Auld
On Wed, 21 Apr 2021 at 16:41, Tvrtko Ursulin wrote: > > > On 21/04/2021 12:42, Matthew Auld wrote: > > On 19/04/2021 16:01, Tvrtko Ursulin wrote: > >> > >> On 19/04/2021 15:37, Matthew Auld wrote: > >>> On 19/04/2021 15:07, Tvrtko Ursulin wrote: > > On 19/04/2021 12:30, Matthew Auld wrot

Re: [Intel-gfx] [PATCH 00/11] drm/i915/adl_p: Add support for Display Page Tables

2021-04-21 Thread Imre Deak
On Wed, Apr 21, 2021 at 03:12:48PM +0300, Jani Nikula wrote: > On Wed, 21 Apr 2021, Imre Deak wrote: > > On Wed, Apr 21, 2021 at 02:03:45PM +0300, Jani Nikula wrote: > >> On Thu, 15 Apr 2021, Jani Nikula wrote: > >> > On Wed, 14 Apr 2021, Imre Deak wrote: > >> >> Alder Lake-P adds a new Display

Re: [Intel-gfx] [Mesa-dev] [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-21 Thread Daniel Vetter
On Wed, Apr 21, 2021 at 8:28 PM Tvrtko Ursulin wrote: > On 21/04/2021 18:17, Jason Ekstrand wrote: > > On Wed, Apr 21, 2021 at 9:25 AM Tvrtko Ursulin > > wrote: > >> On 21/04/2021 14:54, Jason Ekstrand wrote: > >>> On Wed, Apr 21, 2021 at 3:22 AM Tvrtko Ursulin > >>> wrote: > On 20/04/2021

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Simplify CCS and UV plane alignment handling (rev2)

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Simplify CCS and UV plane alignment handling (rev2) URL : https://patchwork.freedesktop.org/series/89299/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function para

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/4] drm/i915: Create stolen memory region from local memory

2021-04-21 Thread Patchwork
== Series Details == Series: series starting with [v2,1/4] drm/i915: Create stolen memory region from local memory URL : https://patchwork.freedesktop.org/series/89293/ State : success == Summary == CI Bug Log - changes from CI_DRM_9993_full -> Patchwork_19960_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Simplify CCS and UV plane alignment handling (rev2)

2021-04-21 Thread Patchwork
== Series Details == Series: drm/i915: Simplify CCS and UV plane alignment handling (rev2) URL : https://patchwork.freedesktop.org/series/89299/ State : success == Summary == CI Bug Log - changes from CI_DRM_9994 -> Patchwork_19967 Summary

  1   2   >