Re: [Intel-gfx] [PATCH 11/19] drm/i915: Update the helper to set correct mapping

2021-04-15 Thread Tvrtko Ursulin
On 14/04/2021 17:20, Matthew Auld wrote: On Wed, 14 Apr 2021 at 16:22, Tvrtko Ursulin wrote: On 12/04/2021 10:05, Matthew Auld wrote: From: Venkata Sandeep Dhanalakota Determine the possible coherent map type based on object location, and if target has llc or if user requires an always c

[Intel-gfx] [PATCH][V2] drm/i915/gt: Fix a lockdep warning on RT kernel

2021-04-15 Thread Jun Miao
Don`t simple disable all the HD-irq, should race the region in the intel_breadcrumbs_disarm_irq() only. BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:969 #0: 89c4c00ca970 ((wq_completion)events){+.+.}-{0:0}, at: process_one_work+0x1cf/0x6d0 #1: a433c1

Re: [Intel-gfx] [PATCH 11/19] drm/i915: Update the helper to set correct mapping

2021-04-15 Thread Matthew Auld
On Thu, 15 Apr 2021 at 09:21, Tvrtko Ursulin wrote: > > > On 14/04/2021 17:20, Matthew Auld wrote: > > On Wed, 14 Apr 2021 at 16:22, Tvrtko Ursulin > > wrote: > >> > >> > >> On 12/04/2021 10:05, Matthew Auld wrote: > >>> From: Venkata Sandeep Dhanalakota > >>> > >>> Determine the possible cohere

Re: [Intel-gfx] [RFC PATCH] tests/gem_userptr_blits: Check for banned mmap-offset

2021-04-15 Thread Marcin Bernatowicz
On Fri, 2021-04-09 at 10:57 +0200, Janusz Krzysztofik wrote: > Support for mmap-offset to userptr has been obsoleted, then related > lockdep splat reported issues are not going to be resolved other than > still banning mmap-offset to userptr attempts. > > Replace "mmap-offset-invalidate-*" and "re

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/gt: Fix a lockdep warning on RT kernel

2021-04-15 Thread Patchwork
== Series Details == Series: drm/i915/gt: Fix a lockdep warning on RT kernel URL : https://patchwork.freedesktop.org/series/89108/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or memb

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Fix a lockdep warning on RT kernel

2021-04-15 Thread Patchwork
== Series Details == Series: drm/i915/gt: Fix a lockdep warning on RT kernel URL : https://patchwork.freedesktop.org/series/89108/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9973 -> Patchwork_19941 Summary --- **F

Re: [Intel-gfx] [PATCH v2 08/12] drm/i915: finish removal of gen_mask

2021-04-15 Thread Jani Nikula
On Wed, 14 Apr 2021, Tvrtko Ursulin wrote: > On 14/04/2021 14:13, Jani Nikula wrote: >> On Wed, 14 Apr 2021, Tvrtko Ursulin wrote: >>> On 13/04/2021 06:09, Lucas De Marchi wrote: Now that it's not used anywhere, remove it from struct intel_device_info. To allow a period in which code wi

Re: [Intel-gfx] [PATCH 11/19] drm/i915: Update the helper to set correct mapping

2021-04-15 Thread Tvrtko Ursulin
On 15/04/2021 10:23, Matthew Auld wrote: On Thu, 15 Apr 2021 at 09:21, Tvrtko Ursulin wrote: On 14/04/2021 17:20, Matthew Auld wrote: On Wed, 14 Apr 2021 at 16:22, Tvrtko Ursulin wrote: On 12/04/2021 10:05, Matthew Auld wrote: From: Venkata Sandeep Dhanalakota Determine the possible

Re: [Intel-gfx] [PATCH][V2] drm/i915/gt: Fix a lockdep warning on RT kernel

2021-04-15 Thread Tvrtko Ursulin
Hi, On 14/04/2021 15:48, Jun Miao wrote: Don`t simple disable all the HD-irq, should race the region in the intel_breadcrumbs_disarm_irq() only. What is HD-irq, I am, not familiar with that term? BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:969 #0: ff

Re: [Intel-gfx] [PATCH 00/11] drm/i915/adl_p: Add support for Display Page Tables

2021-04-15 Thread Jani Nikula
On Wed, 14 Apr 2021, Imre Deak wrote: > Alder Lake-P adds a new Display Page Table hardware structure, mapping > tiled framebuffer pages to the display engine, reducing the address > space required in GGTT for these framebuffers. > > This patchset adds support for this taking a minimum set of depe

Re: [Intel-gfx] [PATCH 10/12] drm/tegra: Don't set allow_fb_modifiers explicitly

2021-04-15 Thread Daniel Vetter
On Tue, Apr 13, 2021 at 01:37:38PM +0200, Thierry Reding wrote: > On Tue, Apr 13, 2021 at 11:49:01AM +0200, Daniel Vetter wrote: > > Since > > > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > Author: Paul Kocialkowski > > Date: Fri Jan 4 09:56:10 2019 +0100 > > > > drm: Auto-set all

Re: [Intel-gfx] [RFC PATCH] tests/gem_userptr_blits: Check for banned mmap-offset

2021-04-15 Thread Janusz Krzysztofik
On czwartek, 15 kwietnia 2021 11:47:29 CEST Marcin Bernatowicz wrote: > On Fri, 2021-04-09 at 10:57 +0200, Janusz Krzysztofik wrote: > > Support for mmap-offset to userptr has been obsoleted, then related > > lockdep splat reported issues are not going to be resolved other than > > still banning mm

Re: [Intel-gfx] [PATCH 05/12] drm/imx: Don't set allow_fb_modifiers explicitly

2021-04-15 Thread Daniel Vetter
On Tue, Apr 13, 2021 at 01:47:28PM +0200, Lucas Stach wrote: > Am Dienstag, dem 13.04.2021 um 11:48 +0200 schrieb Daniel Vetter: > > Since > > > > commit 890880ddfdbe256083170866e49c87618b706ac7 > > Author: Paul Kocialkowski > > Date: Fri Jan 4 09:56:10 2019 +0100 > > > > drm: Auto-set all

Re: [Intel-gfx] [RFC PATCH 1/2] tests/core_hotunplug: Add perf health check

2021-04-15 Thread Janusz Krzysztofik
On środa, 14 kwietnia 2021 11:50:10 CEST Marcin Bernatowicz wrote: > On Thu, 2021-04-08 at 10:31 +0200, Janusz Krzysztofik wrote: > > Sometimes CI reports skips of perf subtests when run subsequently > > after > > core_hotunplug. That may be an indication of issues with restoring > > device perf f

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix error code in intel_gvt_init_device()

2021-04-15 Thread Zhenyu Wang
On 2021.04.14 09:01:38 +0300, Dan Carpenter wrote: > The intel_gvt_init_vgpu_type_groups() function is only called from > intel_gvt_init_device(). If it fails then the intel_gvt_init_device() > prints the error code and propagates it back again. That's a bug > because false is zero/success. The

[Intel-gfx] [PULL] drm-intel-fixes

2021-04-15 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2021-04-15: Display panel & power related fixes: - Backlight fix (Lyude) - Display watermark fix (Ville) - VLV panel power fix (Hans) Thanks, Rodrigo. The following changes since commit d434405aaab7d0ebc516b68a8fc4100922d7f5ef: Linux 5.12-rc7 (2

Re: [Intel-gfx] [PULL] drm-intel-fixes

2021-04-15 Thread Daniel Vetter
On Thu, Apr 15, 2021 at 08:59:11AM -0400, Rodrigo Vivi wrote: > Hi Dave and Daniel, > > Here goes drm-intel-fixes-2021-04-15: > > Display panel & power related fixes: > > - Backlight fix (Lyude) > - Display watermark fix (Ville) > - VLV panel power fix (Hans) > > Thanks, > Rodrigo. > > The fol

Re: [Intel-gfx] [RFC] Cross-driver ww transaction lock lists

2021-04-15 Thread Daniel Vetter
On Tue, Apr 13, 2021 at 09:57:06AM +0200, Christian König wrote: > > > Am 13.04.21 um 09:50 schrieb Thomas Hellström: > > Hi! > > > > During the dma_resv conversion of the i915 driver, we've been using ww > > transaction lock lists to keep track of ww_mutexes that are locked > > during the trans

Re: [Intel-gfx] [Linaro-mm-sig] [RFC] Cross-driver ww transaction lock lists

2021-04-15 Thread Intel
On 4/15/21 3:37 PM, Daniel Vetter wrote: On Tue, Apr 13, 2021 at 09:57:06AM +0200, Christian König wrote: Am 13.04.21 um 09:50 schrieb Thomas Hellström: Hi! During the dma_resv conversion of the i915 driver, we've been using ww transaction lock lists to keep track of ww_mutexes that are lock

Re: [Intel-gfx] [Linaro-mm-sig] [RFC] Cross-driver ww transaction lock lists

2021-04-15 Thread Daniel Vetter
On Thu, Apr 15, 2021 at 4:02 PM Thomas Hellström (Intel) wrote: > > > On 4/15/21 3:37 PM, Daniel Vetter wrote: > > On Tue, Apr 13, 2021 at 09:57:06AM +0200, Christian König wrote: > >> > >> Am 13.04.21 um 09:50 schrieb Thomas Hellström: > >>> Hi! > >>> > >>> During the dma_resv conversion of the i

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Rewrite the FBC tiling check a bit

2021-04-15 Thread Ville Syrjälä
On Wed, Apr 14, 2021 at 06:09:23PM +0300, Jani Nikula wrote: > On Wed, 14 Apr 2021, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Write the tiling check in a nicer form. > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/drm/i915/display/intel_fbc.c | 6 ++ > > 1 file chang

Re: [Intel-gfx] [Linaro-mm-sig] [RFC] Cross-driver ww transaction lock lists

2021-04-15 Thread Intel
On 4/15/21 4:40 PM, Daniel Vetter wrote: On Thu, Apr 15, 2021 at 4:02 PM Thomas Hellström (Intel) wrote: On 4/15/21 3:37 PM, Daniel Vetter wrote: On Tue, Apr 13, 2021 at 09:57:06AM +0200, Christian König wrote: Am 13.04.21 um 09:50 schrieb Thomas Hellström: Hi! During the dma_resv convers

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-15 Thread Ville Syrjälä
On Wed, Apr 14, 2021 at 02:06:43PM +0800, Jisheng Zhang wrote: > I met below error during boot with i915 builtin if pass > "i915.mitigations=off": > [0.015589] Booting kernel: `off' invalid for parameter `i915.mitigations' > > The reason is slab subsystem isn't ready at that time, so kstrdup()

Re: [Intel-gfx] [Linaro-mm-sig] [RFC] Cross-driver ww transaction lock lists

2021-04-15 Thread Daniel Vetter
On Thu, Apr 15, 2021 at 05:40:24PM +0200, Thomas Hellström (Intel) wrote: > > On 4/15/21 4:40 PM, Daniel Vetter wrote: > > On Thu, Apr 15, 2021 at 4:02 PM Thomas Hellström (Intel) > > wrote: > > > > > > On 4/15/21 3:37 PM, Daniel Vetter wrote: > > > > On Tue, Apr 13, 2021 at 09:57:06AM +0200, Ch

[Intel-gfx] [PATCH v3 1/4] drm/i915/uapi: hide kernel doc warnings

2021-04-15 Thread Matthew Auld
It's not properly formatted kernel doc, just nerf the warnings for now. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Jordan Justen Cc: Daniel Vetter Cc: Kenneth Graunke Cc: Jason Ekstrand Cc: Dave Airlie Cc: dri-de...@lists.freedesktop.org Cc: mesa-...@lists.freedesktop.org --- incl

[Intel-gfx] [PATCH v3 2/4] drm/i915/uapi: convert i915_user_extension to kernel doc

2021-04-15 Thread Matthew Auld
Add some example usage for the extension chaining also, which is quite nifty. Suggested-by: Daniel Vetter Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Jordan Justen Cc: Daniel Vetter Cc: Kenneth Graunke Cc: Jason Ekstrand Cc: Dave Airlie Cc: dri-de...@lists.freedesktop.org Cc: mesa-

[Intel-gfx] [PATCH v3 3/4] drm/i915/uapi: convert i915_query and friend to kernel doc

2021-04-15 Thread Matthew Auld
Add a note about the two-step process. Suggested-by: Daniel Vetter Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Jordan Justen Cc: Daniel Vetter Cc: Kenneth Graunke Cc: Jason Ekstrand Cc: Dave Airlie Cc: dri-de...@lists.freedesktop.org Cc: mesa-...@lists.freedesktop.org --- include/

[Intel-gfx] [PATCH v3 4/4] drm/doc/rfc: i915 DG1 uAPI

2021-04-15 Thread Matthew Auld
Add an entry for the new uAPI needed for DG1. v2(Daniel): - include the overall upstreaming plan - add a note for mmap, there are differences here for TTM vs i915 - bunch of other suggestions from Daniel v3: (Daniel) - add a note for set/get caching stuff - add some more docs for existi

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/4] drm/i915/uapi: hide kernel doc warnings

2021-04-15 Thread Patchwork
== Series Details == Series: series starting with [v3,1/4] drm/i915/uapi: hide kernel doc warnings URL : https://patchwork.freedesktop.org/series/89121/ State : warning == Summary == $ dim checkpatch origin/drm-tip b67e5ba57e8a drm/i915/uapi: hide kernel doc warnings e5bfc110caaa drm/i915/uapi

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v3,1/4] drm/i915/uapi: hide kernel doc warnings

2021-04-15 Thread Patchwork
== Series Details == Series: series starting with [v3,1/4] drm/i915/uapi: hide kernel doc warnings URL : https://patchwork.freedesktop.org/series/89121/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separate

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [v3,1/4] drm/i915/uapi: hide kernel doc warnings

2021-04-15 Thread Patchwork
== Series Details == Series: series starting with [v3,1/4] drm/i915/uapi: hide kernel doc warnings URL : https://patchwork.freedesktop.org/series/89121/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Funct

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/4] drm/i915/uapi: hide kernel doc warnings

2021-04-15 Thread Patchwork
== Series Details == Series: series starting with [v3,1/4] drm/i915/uapi: hide kernel doc warnings URL : https://patchwork.freedesktop.org/series/89121/ State : success == Summary == CI Bug Log - changes from CI_DRM_9976 -> Patchwork_19942

Re: [Intel-gfx] [PATCH v3 12/16] drm/i915/uapi: introduce drm_i915_gem_create_ext

2021-04-15 Thread Daniel Vetter
On Mon, Mar 29, 2021 at 12:58 AM Daniele Ceraolo Spurio wrote: > > From: Bommu Krishnaiah > > Same old gem_create but with now with extensions support. This is needed > to support various upcoming usecases. For now we use the extensions > mechanism to support PAVP. > > Signed-off-by: Bommu Krishn

Re: [Intel-gfx] [PATCH v3 11/16] drm/i915/pxp: interface for marking contexts as using protected content

2021-04-15 Thread Daniel Vetter
On Mon, Mar 29, 2021 at 12:58 AM Daniele Ceraolo Spurio wrote: > > Extra tracking and checks around protected objects, coming in a follow-up > patch, will be enabled only for contexts that opt in. Contexts can only be > marked as using protected content at creation time and they must be both > ban

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v3,1/4] drm/i915/uapi: hide kernel doc warnings

2021-04-15 Thread Patchwork
== Series Details == Series: series starting with [v3,1/4] drm/i915/uapi: hide kernel doc warnings URL : https://patchwork.freedesktop.org/series/89121/ State : success == Summary == CI Bug Log - changes from CI_DRM_9976_full -> Patchwork_19942_full

Re: [Intel-gfx] [PATCH 10/11] drm/i915/adl_p: Require a minimum of 8 tiles stride for DPT FBs

2021-04-15 Thread Imre Deak
On Wed, Apr 14, 2021 at 06:52:07PM +0300, Imre Deak wrote: > The specification only requires DPT FB strides to be POT aligned, but > there seems to be also a minimum of 8 stride tile requirement. Scanning > out FBs with < 8 stride tiles will result in pipe faults (even though > the stride is POT al

Re: [Intel-gfx] [Mesa-dev] [PATCH v3 3/4] drm/i915/uapi: convert i915_query and friend to kernel doc

2021-04-15 Thread Ian Romanick
On 4/15/21 8:59 AM, Matthew Auld wrote: > Add a note about the two-step process. > > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Jordan Justen > Cc: Daniel Vetter > Cc: Kenneth Graunke > Cc: Jason Ekstrand > Cc: Dave Airlie > Cc: dri-de...@lists.fr

Re: [Intel-gfx] [PATCH] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-15 Thread Simon Ser
Reviewed-by: Simon Ser ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx